On Sun, Jan 11, 2004 at 12:04:07PM +0100, Dirk Meyer wrote:
> But I don't like it in item.py. In fact, it is no attribute of an
> item, it's just a function call. So I added function calls support in
> info_area.py. There is a dict at the top of the page, comingup points
> to the function. And I changed 'cominup' in your skin to
> 'function:comingup'. That's cleaner I think.

That's what I was saying in my commit message:
---
cleaner way to implement this. This is a little hackish, since
"Coming Up" isn't really a item "property" so it doesn't exactly 
fit in the object model.
---

So I'm fine with you moving it.

> BTW, I have a small bug in the skin. I don't have RECORD_DIR set, so
> Freevo sets it to the first item in VIDEO_ITEMS. That dir has an image
> and a description in the folder.fxd. This looks kind of stupid with
> your skin (image over the comingup). But you can't remove the image
> because you need it when you browse the recorded shows. What about we
> change the type of the tv main menu from 'tv' to e.g. 'tv main', so
> you can set the info area for the two menus seperate.

I do have it set differently... there is 'tv extended info' and 'video
info'

> The comment is from Gustavo who wrote the first version of
> drawstringframed. Since I rewrote the whole function, this may not be
> correct anymore. 

Looks like it :) But I put in some '-' at the beginning which looks
ok. The 'items' parameter was supposed to be a template for how to
display the information, BTW, but I can't think of an easy way for
that to be passed from the skin into the function.

Aubin



-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
Freevo-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to