>> As it stands, either the NOTICE file is wrong, or the LICENSE file is wrong, because the NOTICE file should not mention 3rd party products that are not in the LICENSE file.
Thanks for the feedback! As I have already mentioned, we are tracking a bug to fix all non-blocker changes to the NOTICE file for the next release. I will include this feedback there. Correct me if I understood the long discussions on this list, but I don't think this blocks the current release. >> Add a header line before the additional licenses to say what they are for. We have the header for MIT and Nunit license. Didn't include it for the SCALA license for a project that is written in scala. Also didn't include it for the Apache license for an Apache incubator project. Hope that sounds reasonable. Thanks, Neha On Thu, Dec 1, 2011 at 12:43 AM, sebb <seb...@gmail.com> wrote: > On 1 December 2011 02:29, Neha Narkhede <neha.narkh...@gmail.com> wrote: > > Hi, > > > > The Kafka community is hoping to get some feedback on the updated NOTICE > > and LICENSE files for Kafka, before we post a new vote for it. > > > > http://people.apache.org/~nehanarkhede/NOTICE > > There are spurious "===" lines at the top of the file; these must be > removed. > > > http://people.apache.org/~nehanarkhede/LICENSE > > All license for 3rd party products should be present in the LICENSE file. > If the identical license is shared between several products, there's > only need to add it once. > Add a header line before the additional licenses to say what they are for. > > For example: > http://svn.apache.org/repos/asf/httpd/httpd/trunk/LICENSE > > For 3rd party products under AL 2.0, add a list at the end of the AL > license text, before any other licenses. > > As it stands, either the NOTICE file is wrong, or the LICENSE file is > wrong, because the NOTICE file should not mention 3rd party products > that are not in the LICENSE file. > > And neither should mention code that is not actually included in the > release artifacts. > > > The previous vote thread or release artifacts are here - > > > http://apache.markmail.org/message/hntuhwkbazwlfdoe?q=Kafka+list:org.apache.incubator.general > > > > We would appreciate it if you can please take the time to review this > now, > > since we would like to ensure a smoother vote this time around. > > > > Thanks, > > Neha > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
