"Bj�rn Mork" <[EMAIL PROTECTED]> writes:
> Dag Brattli <[EMAIL PROTECTED]> writes:
>
> > I have just put out patch-2.3.13-irda1 for testing. This patch should fix
> > IrCOMM problems (minicom etc),
>
> Somewhat, but it is still not perfect. Note the spurious data sent together
> with ATZ and the immediate "NO CARRIER":
Hmm, what should I have done without your bug-rapports telling that my code
is not perfect? Now I just had to dive into the code again :-( But I think
I found the bug. If you want to test it out before I get a chance to make a
new patch, you can move the lines below from ircomm_ttp.c,
ircomm_ttp_data_request(), to ircomm_service.c, ircomm_data_request()
/*
* Insert clen field, currently we either send data only, or control
* only frames, to make things easier and avoid queueing
*/
ASSERT(skb_headroom(skb) >= 1, return -1;);
skb_push(skb, IRCOMM_HEADER_SIZE);
skb->data[0] = 0;
Hmm, how did it work at all with this bug in place? This is something I
have to think about for a while ;-)
Just a few more hacks, and the IrCOMM impl. should be pretty good!
-- Dag
--
/ Dag Brattli | The Linux-IrDA Project /
// University of Tromsoe, Norway | Infrared communication for Linux //
/// http://www.cs.uit.no/~dagb | http://www.cs.uit.no/linux-irda/ ///
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
