Re Johannes' patch to:

> First off, I've attached a patch to completely nuke usbdevfs's VFS layer in
> favor of using devfs for all of that stuff. Nodes are still created, and you
> use the same ioctl()'s, you just use a different name and you don't have
> to worry about mounting an extra filesystem to get it.

I applied this, and have to point out that it's got two
incompatibilities with the current usbdevfs code (that I
noticed):

- Current names vs new ones, for the first root hub:

    /proc/bus/    usb/001/001        ... usbdevfs rules
    /devfs/       usb/bus1/device1   ... rule in this patch

- Read of "device1" no longer returns the device descriptor.

So on grounds that it's API-incompatible, I'd say it needs
more work yet.  Neither of these changes was mentioned as
being intended ("same API") ... what's the deal?

I'd sure rather see "ohci@address" and "uhci@port" addresses
for the busses, since that style name is not a function of the
order I modprobed drivers or plugged in hardware.  Changing
the device names doesn't seem like it was necessary.


> The patch also does a couple of other things:
> - Adds a new GET_DRIVER ioctl()

Still looking forward to trying this, once the issues above get
resolved.

- Dave


> - Set's the address for the device before grabbing the descriptors
>   This is safe since we need to do the short descriptor read to get the
>   maximum packet size of the control pipe, however SET_ADDRESS doesn't
>   have a data transfer stage, so the maximum packet size is never used





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to