Hi Uwe,
thanks for the work you are putting in to improve my changes!
On 2011-6-17 24:35 , Uwe Stöhr wrote:
I had a look and fixed this. (You forgot to define the counters.) I
created now a new file which contains all theorem environments of
classes which already define them, like the sv*** classes.
Thanks!
- defining the column and side number in svcommon is no good idea
since a book might have 2 columns and 2 sides, while an article is
only 1-sided. Some articles have 1, some 2 columns. I therefore
removed this definition
I agree that my implementation was not elegant. However, I have tested
all classes, including 1 and 2-column text for articles. According to
my testing there were no problems with my original implementation.
- Definitions like "LeftMargin "TOC title:xxx"" are problematic. The
strings will be translatd. Assume that for "TOC" there is e.g. no
corresponding abbreviation in German and it will therefore be
translated to "Inhaltsverzeichnis" which is much longer.
Thanks for pointing this out. I completely ignored localization. If
you have a better naming idea, could you please change the files
accordingly?
- for titlerunning and authorrunning the InTitle flag was missing.
This is necessary that LyX don't end the title when these commands are
inserted
Thanks. I did not notice this issue.
- svcommons contained Style Sol and Style Solution_(theorem-like).
From its definition both lead to the same LaTeX/PDF output. So we only
need one of them. The same was for Style Problem. I therefore removed
the doubled Styles.
Springer is very inconsistent with its classes and they managed to use
different names for identical environments in different classes. In
addition, they use the same name for different environments. So you
will see that some environments have been redefined in the class
specific layout files. I have actually searched the .cls files to find
out what names they have used in every instance. Could you please
revert your deletions so that the LyX classes are consistent with the
corresponding LaTeX classes?
I committed my changes to SVN trunk:
http://www.lyx.org/trac/changeset/39126
and also adapted the svjour3.lyx template file according to the latest
version of the official svjour3 example LaTeX-file. Please test.
Sorry, I am not a developer and do not know how SVN & changesets work.
Could you send me the files via email? I would then do some testing if
you would find this helpful.
I did not yet have a look at svmono and svmult. I will do this the
next days.
Please see the *testfile*.lyx files that I had uploaded to the bug
report 7301
Our template files for these classes are of course still compilable
after my changes but I guess they need to be adapted for the latest
versions of the official LaTeX example files. Do you want to do this?
Perhaps my test files could serve as template files. The advantage
would be that they use all features.
regards Uwe
