Looks pretty much ok, some minor comments/questions inline ...

----- Original Message ----- 
From: "Ian MacLean" <[EMAIL PROTECTED]>
To: "Gert Driesen" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Sunday, June 29, 2003 2:56 PM
Subject: [nant-dev] Namespaces and NAnt.Cnntrib tasks


> Gert Driesen wrote:
>
> >
> >Will you first make a proposal for incorporating the NAntContrib tasks
into
> >NAnt regarding source location, namespace and perhaps class name (don't
know
> >if we'll be needing to change class names as well, though).
> >
> >
> below is my basic proposal for where I see the nantcontrib tasks fitting
> into nant. Source location and namespace are effectively the same thing
> in our source structure. I'm not too bothered whether everything is
> moved before the next release because users will be able to use them all
> regardless. Some of these tasks need some work with regard to
> formatting, code style etc and I would prefer to have that done before
> they are moved. comments suggestions ?
>
> NAnt.DotNet
>     AssemblyInfoTask.cs
>     DiscoTask.cs
>     GacTask.cs
>     NGenTask.cs
>     WsdlTask.cs
>     XsdTask.cs
>     VersionTask.cs
>     TypedCollectionTask.cs
>
> NAnt.Win32
>     ADSIBaseTask.cs
>     ADSIGetPropertyTask.cs
>     ADSISetPropertyTask.cs

Are these actually win32 specific tasks ?  Their name does suggest that, but
these are using System.DirectoryServices right ?

We can leave them in Win32 for now, and decide later ...

>
>     TlbExpTask.cs
>     TlbImpTask.cs
>     AxImpTask.cs
>     COMRegisterTask.cs
>     RegasmTask.cs
>     Vb6Task.cs
>
> NAnt.VisualCpp
>     RcTask.cs
>     MidlTask.cs
>     McTask.cs
>
> NAnt.NUnit.NUnit2
>     NUnitReportTask.cs

Hasn't this task been supersedes by http://nunit2report.sourceforge.net ?

>
> NAnt.SourceControl.SourceSafe
>     AddTask.cs
>     BaseTask.cs
>     CheckinTask.cs
>     CheckoutTask.cs
>     GetTask.cs
>     LabelTask.cs
>     UndoCheckoutTask.cs

Will this be NAnt.SourceControl.SourceSafe.Tasks or
NAnt.SourceControl.Tasks.SourceSafe ?

>
> General/NAnt.Core ??
>     ScpTask.cs
>     ValidateXmlTask.cs
>     CodeStatsTask.cs
>     ConcatTask.cs
>

not too sure about the usefulness of the CodeStatsTask here.  Shouldn't it
be in NAnt.DotNet anyway ?

> unknown - stay in NAnt.Optional ?
>     ChecksumTask.cs
>     HxCompTask.cs
>     HxRegTask.cs
>     IISTasks.cs
>     MailExTask.cs
>     MgmtClassGenTask.cs
>     MSITask.cs
>     MSMTask.cs
>     RecordTask.cs
>     SchemaValidatedTask.cs
>     SlingshotTask.cs
>     SqlTask.cs
>
> NAnt.Optional.StarTeam
>     ...
>
> >eg. right now, the vss tasks are in a separate namespace in NAntContrib,
but
> >we have no(t yet a) separate namespace for the cvs tasks.  we should try
to
> >make it all consistent, I think
> >
> >
> of course. Can you think of a name for the directory containing the cvs
> tasks that isn't 'CVS' ?

I'm afraid not ...

Gert



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
_______________________________________________
nant-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-developers

Reply via email to