eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500134026
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -261,10 +340,23 @@ const ViewResultsModalTrigger = ({
};
const SliceHeaderControls = (props: SliceHeaderControlsPropsWithRouter) => {
+ const [dropdownIsOpen, setDropdownIsOpen] = useState(false);
+ const [tableModalIsOpen, setTableModalIsOpen] = useState(false);
+ const [drillModalIsOpen, setDrillModalIsOpen] = useState(false);
+ const [selectedKeys, setSelectedKeys] = useState<string[]>([]);
const [openScopingModal, scopingModal] = useCrossFiltersScopingModal(
props.slice.slice_id,
);
+ const queryMenuRef: RefObject<any> = useRef(null);
+ const menuRef: RefObject<any> = useRef(null);
+
+ const toggleDropdown = ({ close }: { close?: boolean } = {}) => {
Review Comment:
Yes, you're right, the functionality is the same. It's so that when you call
`toggleDropdown({ close: true });` it's more explicit than
`toggleDropdown(true);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
