eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500143454
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -309,6 +403,7 @@ const SliceHeaderControls = (props:
SliceHeaderControlsPropsWithRouter) => {
case MENU_KEYS.EXPLORE_CHART:
// eslint-disable-next-line no-unused-expressions
props.logExploreChart?.(props.slice.slice_id);
+ window.open(props.exploreUrl);
Review Comment:
When tabbing, the user will land on the Menu item (the li) and then would
need to tab again to hit the link in order to open it. This way the action for
enter is on the Menu item, so only one tab is needed. It makes sense to have
the other context menu benefits, etc, but it's actually really difficult to
right click on that element because it gets picked up by the context menu in
the chart below. If you have any suggestions about how to add it back though,
lmk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
