eschutho commented on code in PR #26138:
URL: https://github.com/apache/superset/pull/26138#discussion_r1500147799
##########
superset-frontend/src/features/home/Menu.tsx:
##########
@@ -306,11 +306,15 @@ export function Menu({
arrowPointAtCenter
>
{isFrontendRoute(window.location.pathname) ? (
- <GenericLink className="navbar-brand" to={brand.path}>
+ <GenericLink
+ className="navbar-brand"
+ to={brand.path}
+ tabIndex={-1}
+ >
<img src={brand.icon} alt={brand.alt} />
</GenericLink>
) : (
- <a className="navbar-brand" href={brand.path}>
+ <a className="navbar-brand" href={brand.path} tabIndex={-1}>
Review Comment:
I'm removing these tabs because they were out of scope. They currently will
work and open the homepage when someone tabs and hits enter, but the logo gets
larger and distorted when focused and doesn't highlight very well, and the
functionality (sending someone to the homepage) for someone who will be using
keyboard navigation on this page is not really helpful. We can add it in later,
or in this PR if someone feels it's an important step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
