subject:"test"

Hi George, you're lucky I know your architecture :) You should include a
snippet of the test module for completeness.

You'll notice the request is actually a mockito proxy setup in the @Before
of the test (in the test module).

Can you use @RequestParameter in the event (instead of
request.getParameter()?) then you can call the method and pass a value from
the test.

Otherwise you'll need to use mockito to mock request.getParameter(...)
(similar to how request.isXhr() is currently mocked). You'll need to be
careful here, there are 2 request proxies (mockito proxy wrapped by
tapestry ioc proxy). And I'm not sure mockito methods can act on the
tapestry proxy.
On 28 Aug 2014 02:47, George Christman gchrist...@cardaddy.com wrote:

 Hi everyone, I'm trying to create some unit test against a new component
 I'm working on. The new component uses request.getParameter(). I'm
 wondering how I would go about setting the request parameter in my test
 case.

 Component I'm testing

 public void keywordFacetSearch() {
 // Get the user's search keyword(s). Get optional parameters, or
 apply default values if those parameters weren't passed.
 String searchString = request.getParameter(SearchParam.KEY) != null
 ? request.getParameter(CarDaddyEnum.KEY).trim() : ;
 }

 Test case

 @Test
   public void testKeywordFacetSearch() {
 request.setAttribute(SearchParam.KEY, foo);
   }

 request.setAttribute doesn't seem to work. Any ideas?

 Thanks

 --
 George Christman
 www.CarDaddy.com
 P.O. Box 735
 Johnstown, New York

Re: Unit test component with request parameter

An even simpler approach is to grab the request parameter in the page /
component and pass through to a service. Then forget about testing the page
/ component and focus on the service.

This is what I usually do. A couple of lines of code go untested but my api
is better and tests are much easier to maintain.

Re: Unit test component with request parameter

Hi lance, I've been working on simplifying the design, so with that said
the service and page design is a little different from what I have checked
in. My goal is to remove all the request parameters from the page and put
them directly into the service so that I'm not having to pass them all over
the place.

So can I just add @Request Parameter to my service method signature and
both automatically read the request parameter from the url or just manually
pass it in through the the unit test? I'm not sure if thats what you were
suggesting.

I'm still very new to the mockito stuff, so I don't understand what it is
actually doing or how to use it.

I'm hoping to simplify the page class so that no testing is required.
Hopefully we can just test the services.
On Aug 28, 2014 3:18 AM, Lance Java lance.j...@googlemail.com wrote:

 An even simpler approach is to grab the request parameter in the page /
 component and pass through to a service. Then forget about testing the page
 / component and focus on the service.

 This is what I usually do. A couple of lines of code go untested but my api
 is better and tests are much easier to maintain.

Re: Unit test component with request parameter

@RequestParameter will only work for page and component events.

A robust service layer should never reference the Request or any other web
objects so you should really pass them through to the service. Perhaps you
want to encapsulate multiple values in a bean which can grow over time
without changing the service's method signature.

Is there a reason why you are using request parameters and not field values
or event parameters?

Re: Unit test component with request parameter

I'd do something like this to separate web from service and keep it
testable.

@Inject
private MyService myService;

public void doSearch(@RequestParam String filter1, @RequestParam Integer
filter2) {
   SearchFilter filter = new SearchFilter();
   filter.setFilter1(filter1);
   filter.setFilter2(filter2);

   ListSearchResult results = myService.doSearch(filter);
   doStuff(results);
}

Re: Unit test component with request parameter

Ah okay, so I guess what you are suggesting is similar to what I originally
had. I'm not sure I understand the differences between field values and
event parameters. I just need to be able to read parameters from the URL.


On Thu, Aug 28, 2014 at 9:08 AM, Lance Java lance.j...@googlemail.com
wrote:

 I'd do something like this to separate web from service and keep it
 testable.

 @Inject
 private MyService myService;

 public void doSearch(@RequestParam String filter1, @RequestParam Integer
 filter2) {
SearchFilter filter = new SearchFilter();
filter.setFilter1(filter1);
filter.setFilter2(filter2);

ListSearchResult results = myService.doSearch(filter);
doStuff(results);
 }




-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: Unit test component with request parameter

 Im not sure I understand the differences between field values and event
parameters
field values - What I meant here was using a t:form / and binding
properties to TextField and Select etc.
event parameters - eg: onMyEvent(String param1, String param2, ...)

Have you seen the filter demo of the observe plugin in tapestry-stitch?
http://tapestry-stitch.uklance.cloudbees.net/observedemo
It hides request parameters from you and converts to event parameters so
your code can be cleaner.

Re: Unit test component with request parameter

Wouldn't you still need to set the parameters to build the URL though? We
just need to be sure the filters remain in the URL so that the searches can
be book marked and indexed by search engines.


On Thu, Aug 28, 2014 at 10:46 AM, Lance Java lance.j...@googlemail.com
wrote:

  Im not sure I understand the differences between field values and event
 parameters
 field values - What I meant here was using a t:form / and binding
 properties to TextField and Select etc.
 event parameters - eg: onMyEvent(String param1, String param2, ...)

 Have you seen the filter demo of the observe plugin in tapestry-stitch?
 http://tapestry-stitch.uklance.cloudbees.net/observedemo
 It hides request parameters from you and converts to event parameters so
 your code can be cleaner.




-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: Unit test component with request parameter

I've been making assumptions without viewing code :) Up until now I've been
thinking it was an AJAX update.

I'm now thinking you're doing a redirect after post and you're using
request parameters to pass the values (avoiding @Persist and having
bookmarkable urls).

Sounds fine to me. The other option is to use activation context.

Re: Unit test component with request parameter

Yup you got it :) I believe you were the one who use push me away from
@Persist and build stateless apps lol.


On Thu, Aug 28, 2014 at 12:24 PM, Lance Java lance.j...@googlemail.com
wrote:

 I've been making assumptions without viewing code :) Up until now I've been
 thinking it was an AJAX update.

 I'm now thinking you're doing a redirect after post and you're using
 request parameters to pass the values (avoiding @Persist and having
 bookmarkable urls).

 Sounds fine to me. The other option is to use activation context.




-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: Unit test component with request parameter

 I believe you were the one who use push me away from @Persist
Lol... sounds like me :)

I'm no SEO guru but I think keywords in the URL score better than request
parameters. You might be interested in this recent feature I added to
@PageActivationContext

https://issues.apache.org/jira/browse/TAP5-2138

Re: Unit test component with request parameter

Your absolutely correct, context URLs are much better for SEO than request
parameters. I tend to use both at the same time, example
domain/category?make=ford, category being the context. I think what you've
done is a cool idea, however with the amount of filters that we will end up
having, it would get real messy when they are mostly all null. It would end
up looking something like this.
domain.com/category/make/$N/$N/$N/$N/$N/$N/$N/$N/$N/$N/brown

Some of the newer stuff I have planned will look something like this.
http://www.cardaddy.com/used-cars/2011-toyota-corolla-le-albany-ny-12205-4978?_rd=50color=brown

used-cars = context param
2011-toyota-corolla-le-albany-ny-12205-4978 = context param
12095 = zipcode
4978 = db pk for the year make model trim combo.

We are already doing something similar on a smaller scale here.
http://www.cardaddy.com/forsale/vehicle/2011-toyota-corolla-le-duluth-ga-4978


On Thu, Aug 28, 2014 at 2:14 PM, Lance Java lance.j...@googlemail.com
wrote:

  I believe you were the one who use push me away from @Persist
 Lol... sounds like me :)

 I'm no SEO guru but I think keywords in the URL score better than request
 parameters. You might be interested in this recent feature I added to
 @PageActivationContext

 https://issues.apache.org/jira/browse/TAP5-2138




-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: Unit test component with request parameter

2014-08-28 Thread Thiago H de Paula Figueiredo

On Thu, 28 Aug 2014 16:27:20 -0300, George Christman  
gchrist...@cardaddy.com wrote:


Your absolutely correct, context URLs are much better for SEO than  
request

parameters. I tend to use both at the same time, example
domain/category?make=ford, category being the context. I think what  
you've
done is a cool idea, however with the amount of filters that we will end  
up
having, it would get real messy when they are mostly all null. It would  
end

up looking something like this.
domain.com/category/make/$N/$N/$N/$N/$N/$N/$N/$N/$N/$N/brown


You can avoid the $N by providing your own  
org.apache.tapestry5.services.URLEncoder.



Some of the newer stuff I have planned will look something like this.
http://www.cardaddy.com/used-cars/2011-toyota-corolla-le-albany-ny-12205-4978?_rd=50color=brown


You could also map the other parameters into a single string and pass it  
as an activation context value. In this case, you'd need to do the string  
- parameters map yourself.


--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br

-
To unsubscribe, e-mail: users-unsubscr...@tapestry.apache.org
For additional commands, e-mail: users-h...@tapestry.apache.org

Re: Unit test component with request parameter

Looks like you've put a lot of thought into your urls.

 It would end up looking something like this.
domain.com
http://domain.com/category/make/$N/$N/$N/$N/$N/$N/$N/$N/$N/$N/brown
/category/make/$N/$N/$N/$N/$N/$N/$N/$N/$N/$N/brown
http://domain.com/category/make/$N/$N/$N/$N/$N/$N/$N/$N/$N/$N/brown

Haha... yeah... It's not suited to this use case. It works better when
there can only be trailing nulls (which don't appear in the url).

Unit test component with request parameter

2014-08-27 Thread George Christman

Hi everyone, I'm trying to create some unit test against a new component
I'm working on. The new component uses request.getParameter(). I'm
wondering how I would go about setting the request parameter in my test
case.

Component I'm testing

public void keywordFacetSearch() {
// Get the user's search keyword(s). Get optional parameters, or
apply default values if those parameters weren't passed.
String searchString = request.getParameter(SearchParam.KEY) != null
? request.getParameter(CarDaddyEnum.KEY).trim() : ;
}

Test case

@Test
  public void testKeywordFacetSearch() {
request.setAttribute(SearchParam.KEY, foo);
  }

request.setAttribute doesn't seem to work. Any ideas?

Thanks

-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: How do you unit test services with dependent services

2014-01-22 Thread Lance Java

I think it would be easy enough to create a TapestryJUnit4ClassRunner which
is similar to SpringJUnit4ClassRunner.

eg:

@RunWith(TapestryJUnit4ClassRunner.class)
@Modules({SecurityModule.class, HibernateModule.class, MyTestModule.class})
@ModuleDefs({SpringModuleDef.class})
public class MyIOCTest {
   public static class MyTestModule {
  public static Foo buildFoo() { return new FooImmpl(); }
   }

   @Inject
   private Foo foo;

   public void testFoo() {
  Assert.assertNotNull(fo.doStuff());
   }
}

Re: How do you unit test services with dependent services

2014-01-22 Thread Lance Java

You can use

IOCUtilities.addDefaultModules(RegistryBuilder)

To scan the classpath for META-INF entries.
On 21 Jan 2014 19:47, George Christman gchrist...@cardaddy.com wrote:

 and that is the easiest way to do it ugh lol


 On Tue, Jan 21, 2014 at 2:30 PM, Dragan Sahpaski
 dragan.sahpa...@gmail.comwrote:

  You have to manually add ALL the tapestry IOC modules you're using (in
 this
  case the tapestry-security module
  org.tynamo.security.services.SecurityModule), because you're starting
 only
  the Registry and not the entire webapp.
 
  Cheers,
  Dragan Sahpaski
 
 
  On Tue, Jan 21, 2014 at 8:22 PM, George Christman
  gchrist...@cardaddy.comwrote:
 
   Dmitry, I'm very confused. I use constructor injection in my services
  which
   I always thought was the correct way to do it based on the tap docs.
  
   I have the following test class where I'm trying to use a service.
  
   public class TimeSheetServiceTest {
  
   protected static TimeSheetService timeSheetService;
  
   @BeforeClass
   public static void setup() {
   Registry registry;
   RegistryBuilder builder = new RegistryBuilder();
   builder.add(AppModule.class);
   registry = builder.build();
   registry.performRegistryStartup();
   timeSheetService = registry.getService(TimeSheetService.class);
   }
  
   @Test
   public void testService() {
   int result =
  
 
 timeSheetService.getHolidayListForPayPeriod(Calendar.getInstance()).size();
   System.out.println(result  + result);
   }
  
   }
  
   TimeSheetService injects another service called UserInfoService
 userInfo
   like so,
  
   public class TimeSheetServiceImpl implements TimeSheetService {
  
   public TimeSheetServiceImpl(UserInfoService userInfo) {
   this.userInfo = userInfo;
   }
  
   }
  
   When I try running my test class, I get the following exception.
  
   ?xml version=1.0 encoding=UTF-8?
  
   !-- Generated by org.testng.reporters.JUnitReportReporter --
   -testsuite errors=0 time=0.000 timestamp=21 Jan 2014 19:18:58
 GMT
   failures=1 tests=1
   name=org.domain.etss.services.form.TimeSheetServiceTest
   hostname=hri185169
   !-- org.domain.etss.services.form.TimeSheetServiceTest --
   -testcase time=0.000 name=testService
  
 classname=org.domain.etss.services.form.TimeSheetServiceTest-failure
   message=Contribution
  
  
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
   SecurityFilterChainFactory) (at AppModule.java:312) is for service
   'SecurityConfiguration', which does not exist.
   type=java.lang.IllegalArgumentException
   ![CDATA[java.lang.IllegalArgumentException: Contribution
  
  
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
   SecurityFilterChainFactory) (at AppModule.java:312) is for service
   'SecurityConfiguration', which does not exist. at
  
  
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.validateContributeDefs(RegistryImpl.java:236)
   at
  
  
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.init(RegistryImpl.java:200)
   at
  org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:170)
   at
  
  
 
 org.domain.etss.services.form.TimeSheetServiceTest.setup(TimeSheetServiceTest.java:28)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
  
  
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at
  
  
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:601) at
  
  
 
 org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
   at
  org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:551)
   at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:213)
 at
   org.testng.internal.Invoker.invokeConfigurations(Invoker.java:138) at
  
  
 
 org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:175)
   at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:107)
 at
   org.testng.TestRunner.privateRun(TestRunner.java:768) at
   org.testng.TestRunner.run(TestRunner.java:617) at
   org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at
   org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at
   org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at
   org.testng.SuiteRunner.run(SuiteRunner.java:240) at
   org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at
   org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:87) at
   org.testng.TestNG.runSuitesSequentially(TestNG.java:1188) at
   org.testng.TestNG.runSuitesLocally(TestNG.java:1113) at
   org.testng.TestNG.run(TestNG.java:1025) at
  
 
 org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:72)
   at
  
  
 
 org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:88

How do you unit test services with dependent services

Hello, we are trying to unit test our services, but our services contain
other injected services. I'm wondering how you test injected services. Is
there a configuration I'm missing?

-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

Re: How do you unit test services with dependent services

2014-01-21 Thread Nourredine K.

Hi,

Just use the 
PageTester#getServicehttp://tapestry.apache.org/current/apidocs/org/apache/tapestry5/test/PageTester.html#getService%28java.lang.Class%29method
in your unit tests.




2014/1/21 George Christman gchrist...@cardaddy.com

 Hello, we are trying to unit test our services, but our services contain
 other injected services. I'm wondering how you test injected services. Is
 there a configuration I'm missing?

 --
 George Christman
 www.CarDaddy.com
 P.O. Box 735
 Johnstown, New York

Re: How do you unit test services with dependent services

I usually create base class where I construct registry instance, then I use
registry.getService(Intf.class) when I need an instance of a service.

Like here:
https://github.com/anjlab/anjlab-tapestry-commons/blob/master/anjlab-tapestry-quartz/src/test/java/com/anjlab/tapestry5/services/quartz/SchedulerTest.java


On Tue, Jan 21, 2014 at 9:07 PM, George Christman
gchrist...@cardaddy.comwrote:

 Hello, we are trying to unit test our services, but our services contain
 other injected services. I'm wondering how you test injected services. Is
 there a configuration I'm missing?

 --
 George Christman
 www.CarDaddy.com
 P.O. Box 735
 Johnstown, New York




-- 
Dmitry Gusev

AnjLab Team
http://anjlab.com

Re: How do you unit test services with dependent services

2014-01-21 Thread Dragan Sahpaski

I agree with Dimitry but thats more for integration like testing.
For basic unit testing of services methods (usually we unit test a single
method per test) we mock the dependencies (the injected services) and pass
the mocks through the constructor of the service implementation class under
test. That's why we prefer constructor based injection.

If we need to mock methods in the service that's being bested than we
usually use Spy in Spock or the equivalent feature in other mock frameworks.

Cheers,
Dragan Sahpaski


On Tue, Jan 21, 2014 at 6:34 PM, Dmitry Gusev dmitry.gu...@gmail.comwrote:

 I usually create base class where I construct registry instance, then I use
 registry.getService(Intf.class) when I need an instance of a service.

 Like here:

 https://github.com/anjlab/anjlab-tapestry-commons/blob/master/anjlab-tapestry-quartz/src/test/java/com/anjlab/tapestry5/services/quartz/SchedulerTest.java


 On Tue, Jan 21, 2014 at 9:07 PM, George Christman
 gchrist...@cardaddy.comwrote:

  Hello, we are trying to unit test our services, but our services contain
  other injected services. I'm wondering how you test injected services. Is
  there a configuration I'm missing?
 
  --
  George Christman
  www.CarDaddy.com
  P.O. Box 735
  Johnstown, New York
 



 --
 Dmitry Gusev

 AnjLab Team
 http://anjlab.com

Re: How do you unit test services with dependent services

Here's one recent thread that on the same subject:
http://apache-tapestry-mailing-list-archives.1045711.n5.nabble.com/Testing-Tapestry-td5723590.html


On Tue, Jan 21, 2014 at 9:41 PM, Dragan Sahpaski
dragan.sahpa...@gmail.comwrote:

 I agree with Dimitry but thats more for integration like testing.
 For basic unit testing of services methods (usually we unit test a single
 method per test) we mock the dependencies (the injected services) and pass
 the mocks through the constructor of the service implementation class under
 test. That's why we prefer constructor based injection.

 If we need to mock methods in the service that's being bested than we
 usually use Spy in Spock or the equivalent feature in other mock
 frameworks.

 Cheers,
 Dragan Sahpaski


 On Tue, Jan 21, 2014 at 6:34 PM, Dmitry Gusev dmitry.gu...@gmail.com
 wrote:

  I usually create base class where I construct registry instance, then I
 use
  registry.getService(Intf.class) when I need an instance of a service.
 
  Like here:
 
 
 https://github.com/anjlab/anjlab-tapestry-commons/blob/master/anjlab-tapestry-quartz/src/test/java/com/anjlab/tapestry5/services/quartz/SchedulerTest.java
 
 
  On Tue, Jan 21, 2014 at 9:07 PM, George Christman
  gchrist...@cardaddy.comwrote:
 
   Hello, we are trying to unit test our services, but our services
 contain
   other injected services. I'm wondering how you test injected services.
 Is
   there a configuration I'm missing?
  
   --
   George Christman
   www.CarDaddy.com
   P.O. Box 735
   Johnstown, New York
  
 
 
 
  --
  Dmitry Gusev
 
  AnjLab Team
  http://anjlab.com
 




-- 
Dmitry Gusev

AnjLab Team
http://anjlab.com

Re: How do you unit test services with dependent services

Right, this is for integration testing. I use mocking too, but rarely -- my
tests are 80% integration ones and involve DB (the same as in production).
For mocks I have to use constructor injection also, and this is the only
reason why I use constructor injections.
The code looks ugly in this cases, though, when you have more than 5
dependencies per service. And it's also a tedious task when you want to add
another dependency to the service, because you have to update all test
clients also. That's why I prefer @Inject.

It would be nice to have some api to override, decorate, and advise some
services on existing (built) registry instance right in the test method.
Maybe (temporarily) replace some service with a mock. So that I won't have
to build new module just to override one service for one test case, because
it requires additional setup. Just a thoughts.

On Tue, Jan 21, 2014 at 9:41 PM, Dragan Sahpaski
dragan.sahpa...@gmail.comwrote:

I agree with Dimitry but thats more for integration like testing.
For basic unit testing of services methods (usually we unit test a single
method per test) we mock the dependencies (the injected services) and pass
the mocks through the constructor of the service implementation class under
test. That's why we prefer constructor based injection.

If we need to mock methods in the service that's being bested than we
usually use Spy in Spock or the equivalent feature in other mock
frameworks.

Cheers,
Dragan Sahpaski

On Tue, Jan 21, 2014 at 6:34 PM, Dmitry Gusev dmitry.gu...@gmail.com
wrote:

I usually create base class where I construct registry instance, then I
use
registry.getService(Intf.class) when I need an instance of a service.

Like here:

https://github.com/anjlab/anjlab-tapestry-commons/blob/master/anjlab-tapestry-quartz/src/test/java/com/anjlab/tapestry5/services/quartz/SchedulerTest.java

On Tue, Jan 21, 2014 at 9:07 PM, George Christman
gchrist...@cardaddy.comwrote:

Hello, we are trying to unit test our services, but our services
contain
other injected services. I'm wondering how you test injected services.
Is
there a configuration I'm missing?

--
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York

--
Dmitry Gusev

AnjLab Team
http://anjlab.com

--
Dmitry Gusev

AnjLab Team
http://anjlab.com

Re: How do you unit test services with dependent services

Dmitry, I'm very confused. I use constructor injection in my services which
I always thought was the correct way to do it based on the tap docs.

I have the following test class where I'm trying to use a service.

public class TimeSheetServiceTest {

protected static TimeSheetService timeSheetService;

@BeforeClass
public static void setup() {
Registry registry;
RegistryBuilder builder = new RegistryBuilder();
builder.add(AppModule.class);
registry = builder.build();
registry.performRegistryStartup();
timeSheetService = registry.getService(TimeSheetService.class);
}

@Test
public void testService() {
int result =
timeSheetService.getHolidayListForPayPeriod(Calendar.getInstance()).size();
System.out.println(result  + result);
}

}

TimeSheetService injects another service called UserInfoService userInfo
like so,

public class TimeSheetServiceImpl implements TimeSheetService {

public TimeSheetServiceImpl(UserInfoService userInfo) {
this.userInfo = userInfo;
}

}

When I try running my test class, I get the following exception.

?xml version=1.0 encoding=UTF-8?

!-- Generated by org.testng.reporters.JUnitReportReporter --
-testsuite errors=0 time=0.000 timestamp=21 Jan 2014 19:18:58 GMT
failures=1 tests=1
name=org.domain.etss.services.form.TimeSheetServiceTest
hostname=hri185169
!-- org.domain.etss.services.form.TimeSheetServiceTest --
-testcase time=0.000 name=testService
classname=org.domain.etss.services.form.TimeSheetServiceTest-failure
message=Contribution
org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
SecurityFilterChainFactory) (at AppModule.java:312) is for service
'SecurityConfiguration', which does not exist.
type=java.lang.IllegalArgumentException
![CDATA[java.lang.IllegalArgumentException: Contribution
org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
SecurityFilterChainFactory) (at AppModule.java:312) is for service
'SecurityConfiguration', which does not exist. at
org.apache.tapestry5.ioc.internal.RegistryImpl.validateContributeDefs(RegistryImpl.java:236)
at
org.apache.tapestry5.ioc.internal.RegistryImpl.init(RegistryImpl.java:200)
at org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:170)
at
org.domain.etss.services.form.TimeSheetServiceTest.setup(TimeSheetServiceTest.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601) at
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:551)
at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:213) at
org.testng.internal.Invoker.invokeConfigurations(Invoker.java:138) at
org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:175)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:107) at
org.testng.TestRunner.privateRun(TestRunner.java:768) at
org.testng.TestRunner.run(TestRunner.java:617) at
org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at
org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at
org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at
org.testng.SuiteRunner.run(SuiteRunner.java:240) at
org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at
org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:87) at
org.testng.TestNG.runSuitesSequentially(TestNG.java:1188) at
org.testng.TestNG.runSuitesLocally(TestNG.java:1113) at
org.testng.TestNG.run(TestNG.java:1025) at
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:72)
at
org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:88)
at
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:101)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601) at
org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
at com.sun.proxy.$Proxy0.invoke(Unknown Source) at
org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
at
org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
]]
/failure/testcase
!-- testService --
/testsuite

From this line

public static void
contributeSecurityConfiguration(ConfigurationSecurityFilterChain
configuration,

SecurityFilterChainFactory factory) {

configuration.add

Re: How do you unit test services with dependent services

2014-01-21 Thread Dragan Sahpaski

You have to manually add ALL the tapestry IOC modules you're using (in this
case the tapestry-security module
org.tynamo.security.services.SecurityModule), because you're starting only
the Registry and not the entire webapp.

Cheers,
Dragan Sahpaski


On Tue, Jan 21, 2014 at 8:22 PM, George Christman
gchrist...@cardaddy.comwrote:

 Dmitry, I'm very confused. I use constructor injection in my services which
 I always thought was the correct way to do it based on the tap docs.

 I have the following test class where I'm trying to use a service.

 public class TimeSheetServiceTest {

 protected static TimeSheetService timeSheetService;

 @BeforeClass
 public static void setup() {
 Registry registry;
 RegistryBuilder builder = new RegistryBuilder();
 builder.add(AppModule.class);
 registry = builder.build();
 registry.performRegistryStartup();
 timeSheetService = registry.getService(TimeSheetService.class);
 }

 @Test
 public void testService() {
 int result =
 timeSheetService.getHolidayListForPayPeriod(Calendar.getInstance()).size();
 System.out.println(result  + result);
 }

 }

 TimeSheetService injects another service called UserInfoService userInfo
 like so,

 public class TimeSheetServiceImpl implements TimeSheetService {

 public TimeSheetServiceImpl(UserInfoService userInfo) {
 this.userInfo = userInfo;
 }

 }

 When I try running my test class, I get the following exception.

 ?xml version=1.0 encoding=UTF-8?

 !-- Generated by org.testng.reporters.JUnitReportReporter --
 -testsuite errors=0 time=0.000 timestamp=21 Jan 2014 19:18:58 GMT
 failures=1 tests=1
 name=org.domain.etss.services.form.TimeSheetServiceTest
 hostname=hri185169
 !-- org.domain.etss.services.form.TimeSheetServiceTest --
 -testcase time=0.000 name=testService
 classname=org.domain.etss.services.form.TimeSheetServiceTest-failure
 message=Contribution

 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
 SecurityFilterChainFactory) (at AppModule.java:312) is for service
 'SecurityConfiguration', which does not exist.
 type=java.lang.IllegalArgumentException
 ![CDATA[java.lang.IllegalArgumentException: Contribution

 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
 SecurityFilterChainFactory) (at AppModule.java:312) is for service
 'SecurityConfiguration', which does not exist. at

 org.apache.tapestry5.ioc.internal.RegistryImpl.validateContributeDefs(RegistryImpl.java:236)
 at

 org.apache.tapestry5.ioc.internal.RegistryImpl.init(RegistryImpl.java:200)
 at org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:170)
 at

 org.domain.etss.services.form.TimeSheetServiceTest.setup(TimeSheetServiceTest.java:28)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at

 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at

 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:601) at

 org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
 at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:551)
 at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:213) at
 org.testng.internal.Invoker.invokeConfigurations(Invoker.java:138) at

 org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:175)
 at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:107) at
 org.testng.TestRunner.privateRun(TestRunner.java:768) at
 org.testng.TestRunner.run(TestRunner.java:617) at
 org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at
 org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at
 org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at
 org.testng.SuiteRunner.run(SuiteRunner.java:240) at
 org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at
 org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:87) at
 org.testng.TestNG.runSuitesSequentially(TestNG.java:1188) at
 org.testng.TestNG.runSuitesLocally(TestNG.java:1113) at
 org.testng.TestNG.run(TestNG.java:1025) at
 org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:72)
 at

 org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:88)
 at

 org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:101)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at

 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at

 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:601) at

 org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
 at com.sun.proxy.$Proxy0.invoke(Unknown Source) at

 org.apache.maven.surefire.booter.SurefireStarter.invokeProvider

Re: How do you unit test services with dependent services

and that is the easiest way to do it ugh lol


On Tue, Jan 21, 2014 at 2:30 PM, Dragan Sahpaski
dragan.sahpa...@gmail.comwrote:

 You have to manually add ALL the tapestry IOC modules you're using (in this
 case the tapestry-security module
 org.tynamo.security.services.SecurityModule), because you're starting only
 the Registry and not the entire webapp.

 Cheers,
 Dragan Sahpaski


 On Tue, Jan 21, 2014 at 8:22 PM, George Christman
 gchrist...@cardaddy.comwrote:

  Dmitry, I'm very confused. I use constructor injection in my services
 which
  I always thought was the correct way to do it based on the tap docs.
 
  I have the following test class where I'm trying to use a service.
 
  public class TimeSheetServiceTest {
 
  protected static TimeSheetService timeSheetService;
 
  @BeforeClass
  public static void setup() {
  Registry registry;
  RegistryBuilder builder = new RegistryBuilder();
  builder.add(AppModule.class);
  registry = builder.build();
  registry.performRegistryStartup();
  timeSheetService = registry.getService(TimeSheetService.class);
  }
 
  @Test
  public void testService() {
  int result =
 
 timeSheetService.getHolidayListForPayPeriod(Calendar.getInstance()).size();
  System.out.println(result  + result);
  }
 
  }
 
  TimeSheetService injects another service called UserInfoService userInfo
  like so,
 
  public class TimeSheetServiceImpl implements TimeSheetService {
 
  public TimeSheetServiceImpl(UserInfoService userInfo) {
  this.userInfo = userInfo;
  }
 
  }
 
  When I try running my test class, I get the following exception.
 
  ?xml version=1.0 encoding=UTF-8?
 
  !-- Generated by org.testng.reporters.JUnitReportReporter --
  -testsuite errors=0 time=0.000 timestamp=21 Jan 2014 19:18:58 GMT
  failures=1 tests=1
  name=org.domain.etss.services.form.TimeSheetServiceTest
  hostname=hri185169
  !-- org.domain.etss.services.form.TimeSheetServiceTest --
  -testcase time=0.000 name=testService
  classname=org.domain.etss.services.form.TimeSheetServiceTest-failure
  message=Contribution
 
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
  SecurityFilterChainFactory) (at AppModule.java:312) is for service
  'SecurityConfiguration', which does not exist.
  type=java.lang.IllegalArgumentException
  ![CDATA[java.lang.IllegalArgumentException: Contribution
 
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
  SecurityFilterChainFactory) (at AppModule.java:312) is for service
  'SecurityConfiguration', which does not exist. at
 
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.validateContributeDefs(RegistryImpl.java:236)
  at
 
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.init(RegistryImpl.java:200)
  at
 org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:170)
  at
 
 
 org.domain.etss.services.form.TimeSheetServiceTest.setup(TimeSheetServiceTest.java:28)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
 
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
  at
 
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:601) at
 
 
 org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
  at
 org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:551)
  at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:213) at
  org.testng.internal.Invoker.invokeConfigurations(Invoker.java:138) at
 
 
 org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:175)
  at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:107) at
  org.testng.TestRunner.privateRun(TestRunner.java:768) at
  org.testng.TestRunner.run(TestRunner.java:617) at
  org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at
  org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at
  org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at
  org.testng.SuiteRunner.run(SuiteRunner.java:240) at
  org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at
  org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:87) at
  org.testng.TestNG.runSuitesSequentially(TestNG.java:1188) at
  org.testng.TestNG.runSuitesLocally(TestNG.java:1113) at
  org.testng.TestNG.run(TestNG.java:1025) at
 
 org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:72)
  at
 
 
 org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:88)
  at
 
 
 org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:101)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
 
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
  at
 
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43

Re: How do you unit test services with dependent services

Am I going about this all the wrong way? Am I using the services correctly?
I never see in any example test code where you guys are having to add all
the modules. Any suggestions?


On Tue, Jan 21, 2014 at 2:47 PM, George Christman
gchrist...@cardaddy.comwrote:

 and that is the easiest way to do it ugh lol


 On Tue, Jan 21, 2014 at 2:30 PM, Dragan Sahpaski 
 dragan.sahpa...@gmail.com wrote:

 You have to manually add ALL the tapestry IOC modules you're using (in
 this
 case the tapestry-security module
 org.tynamo.security.services.SecurityModule), because you're starting only
 the Registry and not the entire webapp.

 Cheers,
 Dragan Sahpaski


 On Tue, Jan 21, 2014 at 8:22 PM, George Christman
 gchrist...@cardaddy.comwrote:

  Dmitry, I'm very confused. I use constructor injection in my services
 which
  I always thought was the correct way to do it based on the tap docs.
 
  I have the following test class where I'm trying to use a service.
 
  public class TimeSheetServiceTest {
 
  protected static TimeSheetService timeSheetService;
 
  @BeforeClass
  public static void setup() {
  Registry registry;
  RegistryBuilder builder = new RegistryBuilder();
  builder.add(AppModule.class);
  registry = builder.build();
  registry.performRegistryStartup();
  timeSheetService = registry.getService(TimeSheetService.class);
  }
 
  @Test
  public void testService() {
  int result =
 
 timeSheetService.getHolidayListForPayPeriod(Calendar.getInstance()).size();
  System.out.println(result  + result);
  }
 
  }
 
  TimeSheetService injects another service called UserInfoService userInfo
  like so,
 
  public class TimeSheetServiceImpl implements TimeSheetService {
 
  public TimeSheetServiceImpl(UserInfoService userInfo) {
  this.userInfo = userInfo;
  }
 
  }
 
  When I try running my test class, I get the following exception.
 
  ?xml version=1.0 encoding=UTF-8?
 
  !-- Generated by org.testng.reporters.JUnitReportReporter --
  -testsuite errors=0 time=0.000 timestamp=21 Jan 2014 19:18:58 GMT
  failures=1 tests=1
  name=org.domain.etss.services.form.TimeSheetServiceTest
  hostname=hri185169
  !-- org.domain.etss.services.form.TimeSheetServiceTest --
  -testcase time=0.000 name=testService
  classname=org.domain.etss.services.form.TimeSheetServiceTest-failure
  message=Contribution
 
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
  SecurityFilterChainFactory) (at AppModule.java:312) is for service
  'SecurityConfiguration', which does not exist.
  type=java.lang.IllegalArgumentException
  ![CDATA[java.lang.IllegalArgumentException: Contribution
 
 
 org.domain.etss.services.AppModule.contributeSecurityConfiguration(Configuration,
  SecurityFilterChainFactory) (at AppModule.java:312) is for service
  'SecurityConfiguration', which does not exist. at
 
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.validateContributeDefs(RegistryImpl.java:236)
  at
 
 
 org.apache.tapestry5.ioc.internal.RegistryImpl.init(RegistryImpl.java:200)
  at
 org.apache.tapestry5.ioc.RegistryBuilder.build(RegistryBuilder.java:170)
  at
 
 
 org.domain.etss.services.form.TimeSheetServiceTest.setup(TimeSheetServiceTest.java:28)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
 
 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
  at
 
 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:601) at
 
 
 org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
  at
 org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:551)
  at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:213) at
  org.testng.internal.Invoker.invokeConfigurations(Invoker.java:138) at
 
 
 org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:175)
  at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:107)
 at
  org.testng.TestRunner.privateRun(TestRunner.java:768) at
  org.testng.TestRunner.run(TestRunner.java:617) at
  org.testng.SuiteRunner.runTest(SuiteRunner.java:334) at
  org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329) at
  org.testng.SuiteRunner.privateRun(SuiteRunner.java:291) at
  org.testng.SuiteRunner.run(SuiteRunner.java:240) at
  org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at
  org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:87) at
  org.testng.TestNG.runSuitesSequentially(TestNG.java:1188) at
  org.testng.TestNG.runSuitesLocally(TestNG.java:1113) at
  org.testng.TestNG.run(TestNG.java:1025) at
 
 org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:72)
  at
 
 
 org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:88)
  at
 
 
 org.apache.maven.surefire.testng.TestNGProvider.invoke

Re: How do you unit test services with dependent services