Tim,
Are you looking at this FileTest now? I've looked over this test, and
basically I think it's the test itself can be improved. If 8.3 filename
is disabled, the test_getCanonicalPath and test_getCanonicalFile fails
on both RI and Harmony. Look inside the tests, it creates a file
Do I undersyand correctly that even when spec says e.g.
that Exception1 is thrown when parameter1 == 10 and RI
throws Exception2 then we follow RI ?
Thanks,
Mikhail
-
Terms of use :
Hi Stepan:
Seems the new framework for serialization has added to Harmony, I'm
trying it and find it interesting. However I have a few questions:
1. It is strange that SerializationTest is an abstract class extends
junit.framework.testcase, in this case I can either (a) extends
Any relationship between Exception1 and Exception2?
Mikhail Loenko wrote:
Do I undersyand correctly that even when spec says e.g.
that Exception1 is thrown when parameter1 == 10 and RI
throws Exception2 then we follow RI ?
Thanks,
Mikhail
No
2006/6/30, Paulex Yang [EMAIL PROTECTED]:
Any relationship between Exception1 and Exception2?
Mikhail Loenko wrote:
Do I undersyand correctly that even when spec says e.g.
that Exception1 is thrown when parameter1 == 10 and RI
throws Exception2 then we follow RI ?
Thanks,
Mikhail
So I think it is the Rule1 to follow spec if the behavior is clearly
specified?
Mikhail Loenko wrote:
No
2006/6/30, Paulex Yang [EMAIL PROTECTED]:
Any relationship between Exception1 and Exception2?
Mikhail Loenko wrote:
Do I undersyand correctly that even when spec says e.g.
that
Hi,
I moved SerializationTest to 'support' so new approach for testing
serialization can be used by all modules.
I adjusted to naming conventions[1][2] serialization tests and resource
files for 'crypto' module and partly did it for 'security' module. But I
didn't merge serialization tests with
Mikhail Loenko wrote:
There are support classes that are shared by various types of the tests,
e.g. api and impl or classpath and bootclasspath
We can either separate them from the tests or duplicate.
I'm confused.
Either the support classes are used by API tests and only make API calls
into
Jimmy, Jing Lv wrote:
Hi Stepan:
Seems the new framework for serialization has added to Harmony, I'm
trying it and find it interesting. However I have a few questions:
1. It is strange that SerializationTest is an abstract class extends
junit.framework.testcase, in this case I can
But section Exception-throwing compatibility says that exceptions
are different
and we aim to be fully compartible with the RI by matching the
exception characteristics of each method.
2006/6/30, Paulex Yang [EMAIL PROTECTED]:
So I think it is the Rule1 to follow spec if the behavior is
I'm refereing to those support classes that are used by both API
and impl tests
2006/6/30, Tim Ellison [EMAIL PROTECTED]:
Mikhail Loenko wrote:
There are support classes that are shared by various types of the tests,
e.g. api and impl or classpath and bootclasspath
We can either separate
Latest Windows build just failed a test:
java.nio.channels.ClosedChannelException at
java.nio.channels.spi.AbstractSelectableChannel.configureBlocking(AbstractSelectableChannel.java:208)
at
org.apache.harmony.tests.java.nio.channels.SelectorTest.assert_select_OP_READ(SelectorTest.java:416)
at
Mikhail Loenko wrote:
I'm refereing to those support classes that are used by both API
and impl tests
Sure, but if the support classes themselves only use API then they can
be in the api dir right? i.e. we expect our impl tests to use some APIs
too.
Regards,
Tim
2006/6/30, Tim Ellison
On 6/30/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
But section Exception-throwing compatibility says that exceptions
are different
and we aim to be fully compartible with the RI by matching the
exception characteristics of each method.
I believe that it is for However, in most cases the
That means that all the API tests will be in the bootclasspath when
impl/bootclasspath tests run? Will this run be clear enough?
2006/6/30, Tim Ellison [EMAIL PROTECTED]:
Mikhail Loenko wrote:
I'm refereing to those support classes that are used by both API
and impl tests
Sure, but if the
Hi Jimmy,
On 6/30/06, Jimmy, Jing Lv wrote:
Hi Stepan:
Seems the new framework for serialization has added to Harmony, I'm
trying it and find it interesting. However I have a few questions:
1. It is strange that SerializationTest is an abstract class extends
junit.framework.testcase, in
Anton Avtamonov wrote:
On 6/30/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
But section Exception-throwing compatibility says that exceptions
are different
and we aim to be fully compartible with the RI by matching the
exception characteristics of each method.
I believe that it is for However,
For the example I've started this thread with it seems that complying
the spec is
more appropriate there. But probably there are other examples that
caused that the doc was worded the given way
George and Tim could you please comment?
Thanks,
Mikhail
2006/6/30, Paulex Yang [EMAIL PROTECTED]:
Hi Nathan,
I think we may be unnecessarily complicating some of this by assuming that
all of the donated tests that are currently excluded and failing are
completely valid. I believe that the currently excluded tests are either
failing because they aren't isolated according to the suggested
Matt, this sounds great to me. Thanks! I look forward to the JIRAs.
I had a couple of things I was still thinking I'd change (descriptions
in the top-level and module build.xml files was one of them). I was
also wondering if it was better to use imports for the make/build-*.xml
files since
Please hold-off any commits to classlib code for about an hour, so we
can get a stable snapshot.
There are two issues that are currently under investigation:
- this morning's windows build break, and
- unnecessary files in jre/bin (HARMONY-716)
I'll send out further mail once the snapshot is
Stepan Mishura wrote:
Hi Jimmy,
On 6/30/06, Jimmy, Jing Lv wrote:
Hi Stepan:
Seems the new framework for serialization has added to Harmony, I'm
trying it and find it interesting. However I have a few questions:
1. It is strange that SerializationTest is an abstract class extends
Sorry Tim,
I committed 704 just before your note got downloaded to my email client.
Best regards,
George
Tim Ellison wrote:
Please hold-off any commits to classlib code for about an hour, so we
can get a stable snapshot.
There are two issues that are currently under investigation:
- this
Hi Tim,
I took a look at the code, and suspected the failure is caused by network.
Here're my comments:
I guess there are two possible reasons that why this test failed. The first
possible one is network problem. If the failure is caused by network
problem, the failure point is strange. It
On 6/30/06, Jimmy, Jing Lv wrote:
Stepan Mishura wrote:
Hi Jimmy,
SNIP
3. The test needs ser-files, so it may be necessary to add a method to
create this file easily just like the old framework. I find a protected
method produceGoldenFiles(), is that used for it (why protected?)? This
may
It is not clear why we have assertEquals in this type of constructions
try {
assertEquals(CAPACITY_NORMAL, this.channel1.read(buf));
fail(Should throw ClosedChannelException);
} catch (ClosedChannelException e) {
// correct
}
Ok, I'm done -- thank you.
Regards,
Tim
Tim Ellison wrote:
Please hold-off any commits to classlib code for about an hour, so we
can get a stable snapshot.
There are two issues that are currently under investigation:
- this morning's windows build break, and
- unnecessary files in
A new class library snapshot build is available on the Harmony binary
downloads page:
http://cvs.apache.org/dist/incubator/harmony/snapshots/
This is the state of the classlib code at repository revision 418227,
and is made available as a convenience for those who do not have the
required tool
Mikhail Loenko wrote:
For the example I've started this thread with it seems that complying
the spec is
more appropriate there. But probably there are other examples that
caused that the doc was worded the given way
George and Tim could you please comment?
Thanks,
Mikhail
Hi Mikhail,
I love
Hello Mikhail,
Totally agree with you. assertEquals doesn't make any sense here.
I will remove these useless assertEquals in NIO module tests.
Thanks!
On 6/30/06, Mikhail Loenko [EMAIL PROTECTED] wrote:
It is not clear why we have assertEquals in this type of constructions
try {
Weldon,
I can guess what 'src' is - this is the object being written, right ?
But could you please point me what all other args are ?
Can't we go without all the stuff and have only 2 args - an
object being written and the destination class/array/instance ? :-)
Actually, the simplest form
--- Mark Hindess [EMAIL PROTECTED] wrote:
Matt, this sounds great to me. Thanks! I look
forward to the JIRAs.
I had a couple of things I was still thinking I'd
change (descriptions
in the top-level and module build.xml files was one
of them). I was
also wondering if it was better to
Paulex Yang wrote:
Tim,
Are you looking at this FileTest now?
I have not had time, so if you can fix them then please go ahead.
I've looked over this test, and
basically I think it's the test itself can be improved. If 8.3 filename
is disabled, the test_getCanonicalPath and
Thanks!
geir
Tim Ellison wrote:
A new class library snapshot build is available on the Harmony binary
downloads page:
http://cvs.apache.org/dist/incubator/harmony/snapshots/
This is the state of the classlib code at repository revision 418227,
and is made available as a convenience for
All,
Is it worth spending time to create MS VC++ (2005, I presume) solution and
project files for DRLVM?
Although it is possible to make DRLVM buildable from inside IDE, initial
step would be to just organize files into projects to make it possible to
use MSVS IDE as convinient editor for DRLVM
Hi Mark, DRLVM developers,
it looks like the issue HARMONY-666 to
remove String and StringBuffer was not accompanied with
corresponding update of org.apache.harmony.kernel.vm.VM
(move intern() native method from String to VM).
As I am planning to do some experiments with string interning
in
Hi community!
While looking through some of java.beans tests I found many places
where exact output of toString() method is being tested. Moreover, the
test patterns differ from the output generated by RI's toString's.
IMHO there is no much sense in testing of toString() since normally
users do
Zakirov, Salikh wrote:
By the way, there are some other issues with current state of DRLVM,
as the following smoke tests (run by 'build.sh test') fail on
Linux/ia32:
util.DoPrivileged
classloader.LogLoader
classloader.SysRes
I'm going to bisect recent commits to find
On Friday 30 June 2006 21:39 Salikh Zakirov wrote:
Zakirov, Salikh wrote:
By the way, there are some other issues with current state of DRLVM,
as the following smoke tests (run by 'build.sh test') fail on
Linux/ia32:
util.DoPrivileged
classloader.LogLoader
I'd say that (like hashCode()) there's not a lot of point in testing
the exact output, only behaviour. In other words, if it returns a
String, that should be good enough. There's nothing in the spec to say
what it should be -- all of the toString() methods could return
Harmony is Great! and it'd
Occasionally I use make/build-tests.xml to access the 'gen-reports' target.
I only do this when I run a test from within a single module, instead of a
full test run. Maybe there is a better or easier way.
-Nathan
-Original Message-
From: Mark Hindess [mailto:[EMAIL PROTECTED]
Sent:
Hello
Today I've found the reason of why drlvm currently cannot use jar files signed
with jarsigner in classpath. When it is done it throws SecurityException:
K00ec :) . The reason is that SHA1 provider cannot be found by security API
to check the signature.
It cannot be found because now
http://issues.apache.org/jira/browse/HARMONY-719
This issue identifies a valid bug in java.lang.String and good patch to fix
it. Does anyone have any objections to applying this patch or any comments?
-Nathan
43 matches
Mail list logo