Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14103 )
Change subject: IMPALA-8858: Add metrics tracking num queries running on
executor groups
..
Patch Set 16: Code-Review+2
(2
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor
groups
..
Patch Set 4: Code-Review+2
--
To view,
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor
groups
..
Patch Set 2: Code-Review+1
(3 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13906 )
Change subject: IMPALA-8615: [DOCS] Document the scalable admission control
parameters
..
Patch Set 2:
(1 comment)
This basically
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13906 )
Change subject: IMPALA-8615: [DOCS] Document the scalable admission control
parameters
..
Patch Set 3: Code-Review+2
--
To view,
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13801 )
Change subject: IMPALA-5149: Provide query profile in JSON format
..
Patch Set 8:
Should the json include the explicit version
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14103 )
Change subject: IMPALA-8858: Add metrics tracking num queries running on
executor groups
..
Patch Set 19: Code-Review+2
Reviewed
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14294 )
Change subject: IMPALA-8928: Add MEM_LIMIT_EXECUTORS query option
..
Patch Set 1: Code-Review+2
(2 comments)
This looks nice and
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
..
Patch Set 6:
(2 comments)
Still a few things to think
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version
dispalyed in OSInfo
..
Patch Set 7:
(3 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
..
Patch Set 3:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Add OS version and Kernel version in OSInfo
..
Patch Set 3:
(8 comments)
Code looks good, Comments and
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 Change the format OS version and Kernel version
dispalyed in OSInfo
..
Patch Set 8:
The code all seems
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo
..
Patch Set 9: Code-Review+2
Thanks Xiaomeng LGTM
--
To view,
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14756 )
Change subject: IMPALA-9151: Maintain cluster size in ExecutorMembershipSnapshot
..
Patch Set 1: Code-Review+2
(5 comments)
LGTM I
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14837 )
Change subject: IMPALA-7550: Add documentation to profile counters
..
Patch Set 1:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14858 )
Change subject: Update gitignore files
..
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/14858
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13748 )
Change subject: IMPALA-8571: harden QueryEventHook execution
..
Patch Set 28:
(5 comments)
Just a few replies to your useful
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504 ParseKerberosPrincipal() should use
krb5_parse_name() instead
..
Patch Set 4:
(1 comment)
Commit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use
krb5_parse_name() instead
..
Patch Set 5:
(7 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14408 )
Change subject: IMPALA-9034: fix distcc+ccache
..
Patch Set 3: Code-Review+2
(1 comment)
Thanks for fixing the lock-up
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504 ParseKerberosPrincipal() should use
krb5_parse_name() instead
..
Patch Set 2:
(10 comments)
Thanks for
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use
krb5_parse_name() instead
..
Patch Set 7: Code-Review+2
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when
running in container
..
Patch Set 2:
(7 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14433 )
Change subject: IMPALA-7504/KUDU-2979 ParseKerberosPrincipal() should use
krb5_parse_name() instead
..
Patch Set 6:
(3 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/13748 )
Change subject: IMPALA-8571: harden QueryEventHook execution
..
Patch Set 28:
(25 comments)
Hi Radford. As Bharath and Fredy have
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when
running in container
..
Patch Set 1:
(2 comments)
A
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14357 )
Change subject: IMPALA-8998: admission control accounting for mt_dop
..
Patch Set 12:
(2 comments)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14408 )
Change subject: IMPALA-9034: fix distcc+ccache
..
Patch Set 1: Code-Review+2
This LGTM.
... when I took this code and ran with it I
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
Patch Set 2:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
Patch Set 3: Code-Review+2
pull forward +2
--
To view,
Andrew Sherman has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
IMPALA-9240: add HTTP code handling to THttpClient.
Before this
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/14924
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
IMPALA-9240: add HTTP code handling to THttpClient.
Before
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
Patch Set 1:
(1 comment)
Andrew Sherman has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient.
..
IMPALA-9240: add HTTP code handling to THttpClient.
Before this
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by automatically
enable live_progress in the interactive mode
..
Patch
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15023 )
Change subject: IMPALA-9075: Add support for reading zstd text files
..
Patch Set 8: Code-Review+2
LGTM thanks Xiaomeng and Abhishek
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skip short-circuit config check for dedicated
coordinator
..
Patch Set 10: Code-Review+2
--
To view,
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15304 )
Change subject: IMPALA-9389: [DOCS] Support reading zstd text files
..
Patch Set 6: Code-Review+2
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by automatically
enable live_progress in the interactive mode
..
Patch
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15310 )
Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported
for text files
..
Patch Set 3:
(1 comment)
A quick
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by enabling
live_progress in interactive mode
..
Patch Set 3:
(3
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15310 )
Change subject: IMPALA-9431 [DOCS] Update docs to reflect Deflate is supported
for text files
..
Patch Set 5: Code-Review+2
--
To
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15304 )
Change subject: IMPALA-9389: [DOCS] Support reading zstd text files
..
Patch Set 2:
(1 comment)
I think (Abhishek and Xiaomeng to
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15023 )
Change subject: IMPALA-9075: Add support for reading zstd text files
..
Patch Set 4:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skipping short-circuit config check for
coordinator only
..
Patch Set 2:
(5 comments)
Thanks for the
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15023 )
Change subject: IMPALA-9075: Add support for reading zstd text files
..
Patch Set 5: Code-Review+1
LGTM, @arawat will review to +2
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skip short-circuit config check for
coordinator-only mode
..
Patch Set 3: Code-Review+1
LGTM
Giving +1
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15023 )
Change subject: IMPALA-9075: Add support for reading zstd text files
..
Patch Set 4:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15173 )
Change subject: IMPALA-8852: Skip short-circuit config check for
coordinator-only mode
..
Patch Set 4: Code-Review+2
LGTM, thanks
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14973 )
Change subject: IMPALA-9274: cyclic barrier implementation
..
Patch Set 3:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/14950 )
Change subject: IMPALA-9241: Remove pid files on successful shutdown of
minicluster
..
Patch Set 1: Code-Review+2
LGTM
--
To
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/15751
Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive
..
IMPALA-9666 Correct a log message in
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/15752
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
IMPALA-9540 Test that
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15766 )
Change subject: IMPALA-9665: Fixed database not found errors in
query_test.test_insert
..
Patch Set 1:
Looks good, will wait for
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15766 )
Change subject: IMPALA-9665: Fixed database not found errors in
query_test.test_insert
..
Patch Set 2: Code-Review+2
LGTM
--
To
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15607 )
Change subject: IMPALA-9483 Add logs for debugging builtin functions throw
unknown exception randomly
..
Patch Set 2:
(2 comments)
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/15620
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in
http messages.
..
Patch Thrift to 0.9.3-p8 to remove
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15607 )
Change subject: IMPALA-9483 Add logs for debugging builtin functions throw
unknown exception randomly
..
Patch Set 3: Code-Review+2
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15620 )
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in
http messages.
..
Patch Set 1: Verified+1
--
To
Andrew Sherman has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/15620 )
Change subject: Patch Thrift to 0.9.3-p8 to remove a duplicate 'Host' header in
http messages.
..
Patch Thrift to 0.9.3-p8
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
..
Patch Set 1: Code-Review+2
Thanks for fixing this
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
..
Patch Set 2: Code-Review+2
(1 comment)
LGTM
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
Patch Set 1:
(1
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
Patch Set 1:
(1
Andrew Sherman has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
IMPALA-9540 Test that
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15982 )
Change subject: IMPALA-9743: Fix ExprCardinalityTest may not be marked as in
test env
..
Patch Set 1: Code-Review+2
LGTM
--
To
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16613
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
IMPALA-10244: Make non-scalable failures to dequeue
Andrew Sherman has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
IMPALA-10244: Make non-scalable failures to dequeue
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16341 )
Change subject: IMPALA-7714: try to avoid be test crash in statestore
..
Patch Set 1:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16341 )
Change subject: IMPALA-7714: try to avoid be test crash in statestore
..
Patch Set 2: Code-Review+2
LGTM
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
Patch Set 2:
(3 comments)
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16269
Change subject: IMPALA-9909: Print body of http error code in Impala Shell.
..
IMPALA-9909: Print body of http error code in Impala
Andrew Sherman has uploaded a new patch set (#4). (
http://gerrit.cloudera.org:8080/16269 )
Change subject: IMPALA-9909: Print body of http error code in Impala Shell.
..
IMPALA-9909: Print body of http error code in Impala
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16295 )
Change subject: IMPALA-10052: Expose daemon health endpoint for statestore and
catalog
..
Patch Set 2: Code-Review+2
LGTM
--
To
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
Patch Set 5:
Andrew Sherman has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
IMPALA-9540 Test that
Andrew Sherman has uploaded a new patch set (#4). (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
IMPALA-9540 Test that
Andrew Sherman has uploaded a new patch set (#5). (
http://gerrit.cloudera.org:8080/15752 )
Change subject: IMPALA-9540 Test that Impala Shell no longer sends duplicate
"Host" headers in http mode.
..
IMPALA-9540 Test that
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16085 )
Change subject: IMPALA-3695: Remove KUDU_IS_SUPPORTED
..
Patch Set 4: Code-Review+2
This looks safe and a good cleanup.
I did look
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16102 )
Change subject: IMPALA-9871: Simplify OS version matching for SLES in
bootstrap_toolchain.py
..
Patch Set 1: Code-Review+2
LGTM
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16083 )
Change subject: IMPALA-9829: Add Write Metrics for Spilling
..
Patch Set 10:
(13 comments)
Good change! I like the detailed unit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16108 )
Change subject: IMPALA-9790: option to use resolved hostname everywhere
..
Patch Set 2: Code-Review+2
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16083 )
Change subject: IMPALA-9829: Add Write Metrics for Spilling
..
Patch Set 13: Code-Review+2
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16104 )
Change subject: IMPALA-9885: debug action for planner
..
Patch Set 2: Code-Review+2
LGTM
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16039 )
Change subject: IMPALA-9077: Remove scalable admission control configs
..
Patch Set 4: Code-Review+2
(2 comments)
This looks pretty
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16237 )
Change subject: IMPALA-10006: handle non-writable /opt/impala/logs
..
Patch Set 2: Code-Review+2
--
To view, visit
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16807 )
Change subject: IMPALA-10373: Run impala docker containers with uid/gid 1000
..
Patch Set 1: Code-Review+2
LGTM
--
To view, visit
Andrew Sherman has uploaded a new patch set (#4). (
http://gerrit.cloudera.org:8080/16702 )
Change subject: IMPALA-10309: Use sleep time from a Retry-After header in
Impala Shell
..
IMPALA-10309: Use sleep time from a
Andrew Sherman has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/16702 )
Change subject: IMPALA-10309: Use sleep time from a Retry-After header in
Impala Shell
..
IMPALA-10309: Use sleep time from a
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16702
Change subject: IMPALA-10309: Use sleep time from a Retry-After header in
Impala Shell
..
IMPALA-10309: Use sleep time from a
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16743
Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed
test.
..
IMPALA-10249: Fix the flaky
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16700 )
Change subject: IMPALA-10145,IMPALA-10299: Bump impala-shell thrift version to
0.11.0-p4
..
Patch Set 2: Code-Review+2
LGTM
--
To
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
Patch Set 2:
(2 comments)
Andrew Sherman has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
IMPALA-10244: Make non-scalable failures to dequeue
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
Patch Set 2:
(1 comment)
Andrew Sherman has uploaded a new patch set (#4). (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
IMPALA-10244: Make non-scalable failures to dequeue
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable.
..
Patch Set 2:
(1 comment)
Andrew Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/16673 )
Change subject: IMPALA-10303: Fix warnings from impala-shell with --quiet
..
Patch Set 2: Code-Review+2
LGTM
--
To view, visit
Andrew Sherman has uploaded this change for review. (
http://gerrit.cloudera.org:8080/16966
Change subject: IMPALA-10447: Add a newline when exporting shell output to a
file.
..
IMPALA-10447: Add a newline when exporting
201 - 300 of 618 matches
Mail list logo