(patched)
<https://reviews.apache.org/r/75191/#comment315163>
is this true?
docs/cgroups2-support.md
Lines 80 (patched)
<https://reviews.apache.org/r/75191/#comment315164>
recovered
- Benjamin Mahler
On Aug. 23, 2024, 5:45 p.m., Jaso
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75190/#review226882
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 23, 2024, 3:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75189/#review226881
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 23, 2024, 3:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75187/#review226878
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 22, 2024, 10:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75185/#review226876
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 22, 2024, 7:34
st of discarding the future.
- Benjamin Mahler
On Aug. 22, 2024, 7:33 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75186/#review226873
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 22, 2024, 3:32
on watcher destruction.
3rdparty/libprocess/src/posix/io.cpp
Lines 223-224 (patched)
<https://reviews.apache.org/r/75182/#comment315160>
these need to be synchronized
- Benjamin Mahler
On Aug. 20, 2024, 9:28 p.m., Jason Zhou
return Failure(
"Failed to remove directory '" + path + "': " + error.message);
}
}
-removed_cgroups.insert(cgroup);
- }
-
- foreach(const string& cgroup, removed_cgroups) {
- cgroups->erase(cgroup);
-
/cgroups2.cpp
Line 165 (original), 165 (patched)
<https://reviews.apache.org/r/75177/#comment315147>
stale now
- Benjamin Mahler
On Aug. 15, 2024, 8:44 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e
/cgroups2/cgroups2.cpp
Lines 336-343 (patched)
<https://reviews.apache.org/r/75178/#comment315146>
Since the workload runs in the leaf cgroup, we don't want to change the
non-leaf one here.
- Benjamin Mahler
On Aug. 15, 2024, 8:42 p.m., Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75176/#review226858
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 15, 2024, 8:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75175/#review226852
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 15, 2024, 8:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75174/#review226851
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 15, 2024, 8:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75173/#review226850
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 15, 2024, 8:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75172/#review226849
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 15, 2024, 8:29
Lines 636 (patched)
<https://reviews.apache.org/r/75170/#comment315144>
let's include the pid and cgroup in the message
- Benjamin Mahler
On Aug. 15, 2024, 8:52 p.m., Jason Zhou wrote:
>
> ---
> This is an automatica
Lines 568-573 (original), 568-580 (patched)
<https://reviews.apache.org/r/75171/#comment315143>
hmm this is hard to wrap one's head around, perhaps we can more clearly
capture when we need to force creation?
- Benjamin Mahler
On Aug. 15, 2024, 8:52 p.m., Jason
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75167/#review226845
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 14, 2024, 11:15
15142>
no const on primitive types in args, since they are always copied
- Benjamin Mahler
On Aug. 14, 2024, 12:09 a.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
>
> (Updated Aug. 14, 2024, 12:09 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Currently we do not support nested containers. We need to let nested
> containers pick
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75166/#review226837
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 13, 2024, 6:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75149/#review226827
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 7, 2024, 8:49
roups_root, TEST_CGROUP);
+flags.cgroups_root, TEST_CGROUP);
ASSERT_SOME(container_id);
+
Future recover = dm->recover({protobuf::slave::createContainerState(
- None(),
- None(),
- *container_id,
- -1,
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75163/#review226824
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 12, 2024, 4:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75162/#review226823
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 12, 2024, 6:16
e you instead want cgroups/all to run all the creator functions?
- Benjamin Mahler
On Aug. 9, 2024, 11:04 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
x27;t you want to check that all the various controllers we support are
enabled?
- Benjamin Mahler
On Aug. 12, 2024, 2:44 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75161/#review226811
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 9, 2024, 8:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75159/#review226810
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 9, 2024, 7:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75158/#review226809
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 9, 2024, 7:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75160/#review226808
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 9, 2024, 7:19
/core.cpp
Line 63 (original), 64-73 (patched)
<https://reviews.apache.org/r/75158/#comment315110>
hm.. rather than tokenizing here and in paths::cgroups2::containerId(),
can't we just do string handling consistently?
- Benjamin Mahler
On Aug. 9, 2024, 5:48 p.m., Jason
Lines 232-259 (original), 234-261 (patched)
<https://reviews.apache.org/r/75159/#comment315109>
why is core different from perf_event or devices? why can't we call prepare
and push it into the controllers?
- Benjamin Mahler
On Aug. 9, 2024, 3:45 p.m., Jason
-716 (patched)
<https://reviews.apache.org/r/75156/#comment315108>
a `for (int i = 0; i < root_tokens.size(); ++i)` loop seems simpler?
- Benjamin Mahler
On Aug. 9, 2024, 12:58 a.m., Jason Zhou wrote:
>
> ---
> This i
ntion specific to mesos'
containerization, so this should go up into the call site that's problematic.
- Benjamin Mahler
On Aug. 9, 2024, 3:45 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75157/#review226800
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 9, 2024, 2:29
/cgroups2.cpp
Lines 87 (patched)
<https://reviews.apache.org/r/75155/#comment315106>
we should also make "cgroups/blkio" in the `--isolation` flag work with
this, for backwards compatibility
this alisasing can be done in a different patch
- Benjamin Mahler
On Aug. 8
hm.. this won't handle slashes in `root`?
- Benjamin Mahler
On Aug. 8, 2024, 8:06 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75148/#review226791
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 7, 2024, 4:48
263 (patched)
<https://reviews.apache.org/r/75148/#comment315089>
let's default to true and only pass false in the recovery case?
- Benjamin Mahler
On Aug. 7, 2024, 4:48 p.m., Jason Zhou wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75143/#review226785
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 7, 2024, 4:55
tps://reviews.apache.org/r/75142/#comment315088>
nit: brace on next line
- Benjamin Mahler
On Aug. 7, 2024, 4:46 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
put this in the earlier patch?
- Benjamin Mahler
On Aug. 6, 2024, 8:11 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
233 (original), 266 (patched)
<https://reviews.apache.org/r/75143/#comment315078>
probably s/persist/checkpoint/ would be more clear
- Benjamin Mahler
On Aug. 6, 2024, 4:29 p.m., Jason Zhou wrote:
>
> ---
> This is a
{
state->add_deny_list(stringify(entry));
}
```
- Benjamin Mahler
On Aug. 6, 2024, 4:29 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75143/
> --
what we're doing here? This also lines
up with your file names (state.proto / state.hpp), also be sure to name the
protobuf message consistently with the other .state files (I already landed it
:))
- Benjamin Mahler
On Aug. 6, 2024, 4:29 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75141/#review226775
---
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 6, 2024, 4:29
/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Lines 566-572 (original), 716-722 (patched)
<https://reviews.apache.org/r/75074/#comment315071>
(see note above, this could be more concise with a helper)
- Benjamin Mahler
On Aug. 3, 2024, 1:20 a.m., Jason Zhou wrote:
>
>
ators/gpu/isolator.cpp
Lines 681-685 (patched)
<https://reviews.apache.org/r/75074/#comment315051>
seems like this could be shortened with an asDeviceEntries?
- Benjamin Mahler
On Aug. 2, 2024, 7:13 p.m., Jason Zhou wrote:
>
> ---
>
332 (patched)
<https://reviews.apache.org/r/75074/#comment315041>
use a continuation here rather than blocking, but since you want multiple
states, you'll want to use something like collect() to gather all the futures
into a single one
- Benjamin Mahler
On Aug. 2, 2024, 2:37
/device_manager.hpp
Lines 55-56 (patched)
<https://reviews.apache.org/r/75137/#comment315040>
maybe just ::create? or ::from?
- Benjamin Mahler
On Aug. 2, 2024, 2:34 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically gener
/device_manager.cpp
Lines 48-67 (original), 48-65 (patched)
<https://reviews.apache.org/r/75135/#comment315037>
nit: indentation is off here
- Benjamin Mahler
On Aug. 1, 2024, 9:10 p.m., Jason Zhou wrote:
>
> ---
> This is a
location_entries
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Lines 685 (patched)
<https://reviews.apache.org/r/75074/#comment315033>
nit: remove extra newline
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
Line 565 (
conditions
around the device allow/deny behavior?
- Benjamin Mahler
On July 31, 2024, 7:29 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75130/#review226753
---
Ship it!
Ship It!
- Benjamin Mahler
On July 31, 2024, 6:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75121/#review226752
---
Ship it!
Ship It!
- Benjamin Mahler
On July 29, 2024, 9:04
<https://reviews.apache.org/r/75098/#comment315013>
never block within Processes
- Benjamin Mahler
On July 29, 2024, 9:05 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75016/#review226750
---
Ship it!
Ship It!
- Benjamin Mahler
On July 29, 2024, 3:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75120/#review226749
---
Ship it!
Ship It!
- Benjamin Mahler
On July 29, 2024, 6:31
> On July 31, 2024, 8:04 p.m., Benjamin Mahler wrote:
> > Ship It!
will add the needed include for this
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75128/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75128/#review226747
---
Ship it!
Ship It!
- Benjamin Mahler
On July 30, 2024, 3:38
case DeviceManager::NonWildcardEntry::Selector::Type::BLOCK:
return Entry::Selector::Type::BLOCK;
case DeviceManager::NonWildcardEntry::Selector::Type::CHARACTER:
return Entry::Selector::Type::CHARACTER;
}
UNREACHABLE();
```
- Benj
e reviewers
one tool that will help you here is `git add -p`, it makes incrementally
committing much easier!
I'll locally split it out on this one for you on landing
- Benjamin Mahler
On July 26, 2024, 11:33 p.m.,
result
- Benjamin Mahler
On July 26, 2024, 10:04 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75115/#review226727
---
Ship it!
- Benjamin Mahler
On July 26, 2024, 6:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75114/#review226726
---
Ship it!
Ship It!
- Benjamin Mahler
On July 26, 2024, 6:04
/device_manager.cpp
Lines 348-364 (patched)
<https://reviews.apache.org/r/75113/#comment315005>
let's use lambdas here
- Benjamin Mahler
On July 26, 2024, 6:04 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically genera
(patched)
<https://reviews.apache.org/r/75104/#comment315004>
this could just use a hashmap?
src/linux/cgroups2.cpp
Lines 1590-1592 (patched)
<https://reviews.apache.org/r/75104/#comment315003>
simplifiable with selector equality
- Benjamin Mahler
On July 26, 2024, 6:04
)
<https://reviews.apache.org/r/75099/#comment315002>
this could just use the selector stringify?
- Benjamin Mahler
On July 26, 2024, 6:04 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
er.hpp
Lines 75-77 (patched)
<https://reviews.apache.org/r/75099/#comment315001>
comment on when this would return an error?
- Benjamin Mahler
On July 25, 2024, 11:48 p.m., Jason Zhou wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75109/#review226719
---
Ship it!
Ship It!
- Benjamin Mahler
On July 25, 2024, 11:48
ess::create(...) function that rejects
invalid.
2. Adding a CHECK(normalized()) inside this function before we run this
logic. And there's a normalize() function that can be called on it as well by
whoever is editing the struct.
- Benjamin Mahler
On July 24, 2024, 9:46 p.m.,
tps://reviews.apache.org/r/75106/#comment314994>
we can use this in Entry::encompasses?
- Benjamin Mahler
On July 24, 2024, 6:26 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75107/#review226714
---
Ship it!
- Benjamin Mahler
On July 24, 2024, 6:26 p.m
/slave/containerizer/device_manager/device_manager.cpp
Lines 163 (patched)
<https://reviews.apache.org/r/75102/#comment314993>
this looks like a const function in terms of not mutating internal state of
this class?
- Benjamin Mahler
On July 23, 2024, 8:54 p.m., Jason Zhou
src/slave/containerizer/device_manager/device_manager.cpp
Lines 279 (patched)
<https://reviews.apache.org/r/75006/#comment314989>
> If deny access becomes none, remove it.
stale comment now?
src/slave/containerizer/device_manager/devi
PECT_TRUE(selector.has_wildcard());
+
selector.type = cgroups::devices::Entry::Selector::Type::BLOCK;
selector.major = 1;
selector.minor = 1;
@@ -1498,4 +1519,4 @@ TEST(DeviceTest, SelectorWildcardTest) {
} // namespace tests {
} // namespace internal {
-} // namespace mesos {
\ No newline a
ps_tests.cpp
Lines 1416 (patched)
<https://reviews.apache.org/r/75096/#comment314958>
use `subset->...` rather than `(*subset).`
- Benjamin Mahler
On July 18, 2024, 8:19 p.m., Jason Zhou wrote:
>
> ---
> This is a
-88 (patched)
<https://reviews.apache.org/r/75091/#comment314955>
should either:
1. Remove the older 16.04 condition (since we no longer support < 22.04?),
or:
2. Keep 16.04, 20.04 and 22.04 conditions.
- Benjamin Mahler
On July 16, 2024, 10:59 p.m., Jason Z
to set target MAC address");
}
return Nothing();
}
```
src/linux/routing/link/link.cpp
Lines 273 (patched)
<https://reviews.apache.org/r/75057/#comment314857>
looks like your editor is allowing trailing whitespace
src/linux/
)
<https://reviews.apache.org/r/75090/#comment314954>
no need for explicit return type hint now
- Benjamin Mahler
On July 15, 2024, 9:21 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically generated e-mail.
--
>
> (Updated July 15, 2024, 7:53 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10243
> https://issues.apache.org/jira/browse/MESOS-10243
>
>
> Repository: mesos
>
>
> Description
> ---
&g
), 126 (patched)
<https://reviews.apache.org/r/75089/#comment314947>
comment seems ok, could say `20.04+` or `20.04 or newer`, or `>= 20.04`
- Benjamin Mahler
On July 15, 2024, 5:07 p.m., Jason Zhou wrote:
>
> -
n)
{
- ASSERT_SOME(link::veth::create(TEST_VETH_LINK, TEST_PEER_LINK, None(),
None()));
+ ASSERT_SOME(
+ link::veth::create(TEST_VETH_LINK, TEST_PEER_LINK, None(), None()));
EXPECT_SOME_TRUE(link::exists(TEST_VETH_LINK));
EXPECT_SOME_TRUE(link::exists(TEST_PEER_LINK));
```
- Benjamin Mahler
O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75087/#review226681
---
Ship it!
Ship It!
- Benjamin Mahler
On July 15, 2024, 2:45
t them? we should put a comment in the code if
there's a need to split these, or just not check any specific functions since
that can get very verbose if we start checking every function we need from
every library?
- Benjamin Mahler
On July 15, 2024, 3:46
org/r/75086/#comment314931>
nit: indentation has gone wild here?
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
Lines 3626-3633 (original)
<https://reviews.apache.org/r/75086/#comment314932>
do you plan to remove the "workaround" logic inside link::set
Lines 5184-5193 (patched)
<https://reviews.apache.org/r/75087/#comment314928>
mind referencing a MESOS jira ticket in apache (that explains the bug,
points to the mailing list, fix patches, etc) both in the code here as well as
in this review description and 'Bugs' field?
-
" device controller program");
}
}
```
src/linux/ebpf.cpp
Lines 150 (patched)
<https://reviews.apache.org/r/75080/#comment314927>
naked Try de-reference: this can crash the program, we need to check for
error here
src/tests/containerizer/cgroups2_tests.cpp
Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75081/#review226664
---
Ship it!
Ship It!
- Benjamin Mahler
On July 11, 2024, 7:07
@@ INSTANTIATE_TEST_CASE_P(
}
));
-TEST_F(Cgroups2Test, ROOT_CGROUPS2_GetBpfFdById) {
+
+TEST_F(Cgroups2Test, ROOT_CGROUPS2_GetBpfFdById)
+{
const string& cgroup = TEST_CGROUP;
ASSERT_SOME(cgroups2::create(cgroup));
```
- Benjamin Mahler
On July 11, 202
w unit test for this, since we're not testing allow/deny
functionality and don't care about the parameterization
- Benjamin Mahler
On July 10, 2024, 7:17 p.m., Jason Zhou wrote:
>
> ---
> This is an automatically g
> On July 10, 2024, 8:18 p.m., Benjamin Mahler wrote:
> > Ship It!
```
diff --git a/src/linux/cgroups2.cpp b/src/linux/cgroups2.cpp
index 9ae8df387..59c212ebc 100644
--- a/src/linux/cgroups2.cpp
+++ b/src/linux/cgroups2.cpp
@@ -1164,7 +1164,8 @@ public:
// |Exit instruction to de
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75026/#review226649
---
Ship it!
Ship It!
- Benjamin Mahler
On July 9, 2024, 11:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75075/#review226629
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 11:39
(patched)
<https://reviews.apache.org/r/75026/#comment314898>
might want to test some more cases here:
* allow all char devices but deny one?
- Benjamin Mahler
On June 3, 2024, 7:45 p.m., Jason Zhou wrote:
>
> ---
e allows first for
this variable to make sense here
Maybe instead we can just take in an argument of the deny block jump, and
this returns the size of the code generated (or maybe the caller can infer that
from the program size change?)
- Benjamin Mahler
On June 3, 2024,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75070/#review226624
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 8:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75066/#review226623
---
Ship it!
Ship It!
- Benjamin Mahler
On July 2, 2024, 8:29
1 - 100 of 1001 matches
Mail list logo
