Martin Betak has abandoned this change.
Change subject: vdsm: Reboot capability for VM
..
Abandoned
Abandoned in favor of a more lightweight patch http://gerrit.ovirt.org/22440
adding only guest agent reboot support without ch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6114/ : SUCCESS
http://jenkins.ovirt.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1729: self.timeout
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ayal Baron has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38:
Dan, this is patchset number 37. The patch started out as seperate patches and
that didn't make sense (there is no
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1764: # flag for su
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Code-Review-1
Maybe it would be easier for me to follow if you move the current shutdown
implementation to the
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(2 comments)
File vdsm/vm.py
Line 1729: self.timeo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5987/ : SUCCESS
http://jenkins.ovirt.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
File vdsm/vm.py
Line 1729: self.timeout
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/set
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
I find it hard to digest the VmPowerDown class. To me it seems that it could be
replaced by a cou
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790: event.wait(se
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5874/ : SUCCESS
http://jenkins.ovirt.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 36:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5859/ : SUCCESS
http://jenkins.ovirt.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(2 comments)
File client/vdsClient.py
Line 1922:
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Code-Review+1
I see just minor comments. +1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscrib
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1726:
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1725: s
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File client/vdsClient.py
Line 1922:
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790: event.wai
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748: i
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4895/ : SUCCESS
http://jenki
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
(1 comment)
File vdsm/vm.py
Line 1747:
Line 1748:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4876/ : SUCCESS
http://jenki
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 34: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while not che
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
(1 comment)
File vdsm/vm.py
Line 1780: while not
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 33:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4802/ : SUCCESS
http://jenki
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 32:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4800/ : SUCCESS
http://jenki
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4731/ : SUCCESS
http://jenki
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 31: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30: Verified+1
The "retry check success" mechanism in VmPowerDown enabled us to drop support
for timeouts in Callback
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 30:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4659/ : SUCCESS
http://jenki
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28:
(4 comments)
File vdsm/vm.py
Line 1734:
Line 1735:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 29:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4577/ : SUCCESS
http://jenki
Ayal Baron has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28:
(8 comments)
File vdsm/vm.py
Line 1734:
Line 1735: gr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 28: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5039/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 27: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5010/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 26: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5007/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 25: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4669/ : SUCCESS
http://jenkins
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 25:
Reviewed interface change only and I approved
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 25: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4537/ : FAILURE
http://j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 24: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4406/ : SUCCESS
http://j
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
and we still have one working on engine as a backup, we'll use him as a last
resort;-)
--
To view, visi
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Sorry folks, I think I got confused by the multiplicity of Martins..
--
To view, visit http://gerrit.ovirt.org
Martin Polednik has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Would it be possible to generalize VmPowerDown class to something like
VmPowerOperations, so in future we coul
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: First of all, sorry for this incomplete patch set. Its purpose was to
serve as a quick check if all the bull
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Dan: IIRC the checkSuccess approach was just a convenient way of doing this
without having to pass the callback r
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
+1 for tests and split
also please make sure the logic is to follow the grace period as configured in
all cir
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23: Code-Review-1
Martin, when I've asked for an explanation about the benefits of using
checkSuccess, I really mea
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(1 comment)
File vdsm/guestIF.py
Line 298: self.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4338/ : SUCCESS
http://jenkins.
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
(6 comments)
Ok, I went through what we have now and it got so much bigger than what I saw
at the beginning. Bas
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review-1
(7 comments)
File lib/vdsm/utils.py
Line 25:
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/s
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4287/ : SUCCESS
http://jenkins.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4281/ : SUCCESS
http://jenkins.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4280/ : SUCCESS
http://jenkins.
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Code-Review-1
(1 comment)
File lib/vdsm/utils.py
Line 92
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 2413: def shutdown(
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 2413: def shutdown(
Peter V. Saveliev has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4194/ : SUCCESS
http://jenkins.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18:
(1 comment)
File vdsm/vm.py
Line 1631: super(VmP
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 1631:
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 163
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: -Code-Review
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4043/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Code-Review-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4043/ : SUCCESS
htt
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 1619:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619: return m
Line
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1631: super(VmP
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Code-Review-1
(1 comment)
-1 for visibility, awaiting answer.
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
(1 comment)
File vdsm/vm.py
Line 1619: return
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4018/ : SUCCESS
http://jenkins.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3954/ : SUCCESS
http://jenkins.
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
(6 comments)
Generally it looks good, I appreciate your good will of adding docstrings you
might think to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3852/ : SUCCESS
http://jenkins.
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
(7 comments)
File lib/vdsm/utils.py
Line 913: os.killpg(
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: I would prefer that you didn't submit this
(9 inline comments)
Sorry for the late review.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2695/ : SUCCESS
http://jenki
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, v
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 14: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2546/ : SUCCESS
http://jenki
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: (6 inline comments)
File lib/vdsm/utils.py
Line 929: _che
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 12: I would prefer that you didn't submit this
(7 inline comments)
I think it is reasonably good, but I have some res
1 - 100 of 115 matches
Mail list logo