Re: Colorized console
How do you expect this to work during multithreaded build, when there is more than one running plugin at any given time? What you probably want is some sort of thread-local logging level, which can be scoped to specific plugin and configured from the core. -- Regards, Igor On Sat, Apr 4, 2015, at 09:15 AM, Robert Scholte wrote: In case of logging frameworks you actually want to know the configuration before starting the application, in this case Maven. On my todo list is still a wish to change the logging level once reaching a specific plugin. Concrete: debugging is now way too verbose. In most cases you just want to specify debug-logging for a specific plugin. The simple solution would be: logging at default level, once reaching the plugin remove *all* Loggers and change the root logging level. Once done: again remove all Loggers and reset the root logging level. Now that's too expensive. My idea is to use a different logger (with dynamic root logging level) if and only if someone specifies logging for a certain plugin/goal, e.g -Xcompiler:compile. So far I haven't been able to solve this, since there can be only 1 org.slf4j.impl.StaticLoggerBinder on the classpath. So yes, if -B would automatically switch to current slf4j-simple otherwise use slf4j-log4j2 with ansi colors, that would be great, but that means that the mvn scripts must construct the correct classpath. How about making 2 distributions: a Maven-dist-user and Maven-dist-system, each with their predefined logging configuration? thanks, Robert Op Wed, 01 Apr 2015 18:15:45 +0200 schreef Arnaud Héritier aherit...@gmail.com: Right. In CI server we may have ansi colors (at least in jenkins) but yes we may consider to deactivate color with batch mode. Or we add a new command line option to turn it off. On Wed, Apr 1, 2015 at 5:48 PM, Manfred Moser manf...@mosabuam.com wrote: I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch It is only one useful commit now : https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9 We should consider to integrate it in the next minor release I think The fact that log4j2 is Java6+ is not anymore a problem and it is now stable (2.2 nowadays). We should also from my point of view activate colors by default. I hope it will be considered for a future 3.4 Cheers, - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console
Indeed, that's how it should work. What's important to me is that the logging is *not* reduced to the plugin classes. So also Maven Core should switch to this new root logging level (for this thread), because that often gives the required info you need. Anyhow, it is a challenge, but I'm sure we would make a lot of users very happy :) Robert Op Sat, 04 Apr 2015 15:31:03 +0200 schreef Igor Fedorenko i...@ifedorenko.com: How do you expect this to work during multithreaded build, when there is more than one running plugin at any given time? What you probably want is some sort of thread-local logging level, which can be scoped to specific plugin and configured from the core. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console
In case of logging frameworks you actually want to know the configuration before starting the application, in this case Maven. On my todo list is still a wish to change the logging level once reaching a specific plugin. Concrete: debugging is now way too verbose. In most cases you just want to specify debug-logging for a specific plugin. The simple solution would be: logging at default level, once reaching the plugin remove *all* Loggers and change the root logging level. Once done: again remove all Loggers and reset the root logging level. Now that's too expensive. My idea is to use a different logger (with dynamic root logging level) if and only if someone specifies logging for a certain plugin/goal, e.g -Xcompiler:compile. So far I haven't been able to solve this, since there can be only 1 org.slf4j.impl.StaticLoggerBinder on the classpath. So yes, if -B would automatically switch to current slf4j-simple otherwise use slf4j-log4j2 with ansi colors, that would be great, but that means that the mvn scripts must construct the correct classpath. How about making 2 distributions: a Maven-dist-user and Maven-dist-system, each with their predefined logging configuration? thanks, Robert Op Wed, 01 Apr 2015 18:15:45 +0200 schreef Arnaud Héritier aherit...@gmail.com: Right. In CI server we may have ansi colors (at least in jenkins) but yes we may consider to deactivate color with batch mode. Or we add a new command line option to turn it off. On Wed, Apr 1, 2015 at 5:48 PM, Manfred Moser manf...@mosabuam.com wrote: I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch It is only one useful commit now : https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9 We should consider to integrate it in the next minor release I think The fact that log4j2 is Java6+ is not anymore a problem and it is now stable (2.2 nowadays). We should also from my point of view activate colors by default. I hope it will be considered for a future 3.4 Cheers, - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console
I'm +1 to have color by default but wonder if associated config shouldn't be in settings.xml. Personally my mvn often looks like: http://img11.hostingpics.net/pics/867383mvn.png Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com 2015-04-01 17:48 GMT+02:00 Manfred Moser manf...@mosabuam.com: I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch It is only one useful commit now : https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9 We should consider to integrate it in the next minor release I think The fact that log4j2 is Java6+ is not anymore a problem and it is now stable (2.2 nowadays). We should also from my point of view activate colors by default. I hope it will be considered for a future 3.4 Cheers, - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console
Right. In CI server we may have ansi colors (at least in jenkins) but yes we may consider to deactivate color with batch mode. Or we add a new command line option to turn it off. On Wed, Apr 1, 2015 at 5:48 PM, Manfred Moser manf...@mosabuam.com wrote: I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch It is only one useful commit now : https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9 We should consider to integrate it in the next minor release I think The fact that log4j2 is Java6+ is not anymore a problem and it is now stable (2.2 nowadays). We should also from my point of view activate colors by default. I hope it will be considered for a future 3.4 Cheers, - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: Colorized console
Yes for now color settings have to be in ${MAVEN_HOME}/
conf/logging/log4j2.xml
For it gives this :
https://www.dropbox.com/s/ottf0nc11sscgsz/Screenshot%202015-04-01%2018.19.11.png?dl=0
But I agree we won't make everyone happy and people will want to adapt them
On Wed, Apr 1, 2015 at 6:04 PM, Romain Manni-Bucau rmannibu...@gmail.com
wrote:
I'm +1 to have color by default but wonder if associated config shouldn't
be in settings.xml. Personally my mvn often looks like:
http://img11.hostingpics.net/pics/867383mvn.png
Romain Manni-Bucau
@rmannibucau https://twitter.com/rmannibucau | Blog
http://rmannibucau.wordpress.com | Github
https://github.com/rmannibucau |
LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber
http://www.tomitribe.com
2015-04-01 17:48 GMT+02:00 Manfred Moser manf...@mosabuam.com:
I agree we should activate colors by default, but only if they are
automatically turned OFF in batch mode so that logs in CI server runs are
no invalidated in terms of readability.
manfred
Arnaud Héritier wrote on 01.04.2015 02:33:
Hi,
Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch
It is only one useful commit now :
https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9
We should consider to integrate it in the next minor release I think
The fact that log4j2 is Java6+ is not anymore a problem and it is now
stable (2.2 nowadays).
We should also from my point of view activate colors by default.
I hope it will be considered for a future 3.4
Cheers,
-
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
--
-
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
Re: Colorized console
I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the slf4j-log4j2 branch It is only one useful commit now : https://github.com/apache/maven/commit/dbad2e536a7024a277eef1c56eaa2286f9f2a7f9 We should consider to integrate it in the next minor release I think The fact that log4j2 is Java6+ is not anymore a problem and it is now stable (2.2 nowadays). We should also from my point of view activate colors by default. I hope it will be considered for a future 3.4 Cheers, - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I've tested this on Windows, there's only one small issue: the info-text is probably black, which makes it unreadable on the default background-color, which is black as well. The rest looks great! Op Mon, 03 Dec 2012 14:47:24 +0100 schreef Olivier Lamy ol...@apache.org: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
ANSI can set the BG color... Gary On Dec 9, 2012, at 8:25, Robert Scholte rfscho...@apache.org wrote: I've tested this on Windows, there's only one small issue: the info-text is probably black, which makes it unreadable on the default background-color, which is black as well. The rest looks great! Op Mon, 03 Dec 2012 14:47:24 +0100 schreef Olivier Lamy ol...@apache.org: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
Just tested it. It's working fine Thx a lot. On Sun, Dec 9, 2012 at 4:38 AM, Jason van Zyl ja...@tesla.io wrote: Arnaud, It's all in there now. While I was fixing the logging in embedded mode for SLF4J Simple, I updated the Logback branch to do the same. I had to patch SLF4J Simple to get around some static initialization that doesn't work in embedded mode so I haven't updated trunk, but the Logback branch works. On Dec 4, 2012, at 12:44 PM, Arnaud Héritier aherit...@gmail.com wrote: Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug cheers Arnaud On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
yes we discussed about it. That one reason why we should not activate it by default. We'll never find a solution that will satisfy everybody On Sun, Dec 9, 2012 at 2:25 PM, Robert Scholte rfscho...@apache.org wrote: I've tested this on Windows, there's only one small issue: the info-text is probably black, which makes it unreadable on the default background-color, which is black as well. The rest looks great! Op Mon, 03 Dec 2012 14:47:24 +0100 schreef Olivier Lamy ol...@apache.org : 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~**olamy/maven/dynamic-logging-**impl/http://people.apache.org/~olamy/maven/dynamic-logging-impl/ . Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/**log4j/2.x/manual/layouts.htmlhttp://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/**log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/**log4j/2.x/manual/index.htmlhttp://logging.apache.org/log4j/2.x/manual/index.html ) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
Arnaud, It's all in there now. While I was fixing the logging in embedded mode for SLF4J Simple, I updated the Logback branch to do the same. I had to patch SLF4J Simple to get around some static initialization that doesn't work in embedded mode so I haven't updated trunk, but the Logback branch works. On Dec 4, 2012, at 12:44 PM, Arnaud Héritier aherit...@gmail.com wrote: Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug cheers Arnaud On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug cheers Arnaud On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
On Dec 4, 2012, at 9:44 AM, Arnaud Héritier aherit...@gmail.com wrote: Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug I've been talking to Ceki about configuration in SLF4J as there is really no way to change the log level without assuming an implementation. If that's the way then for embedding the user can change the SLF4J implementation but for the CLI this will not be possible. What I would effectively have to do is what the Sonar folks did which is to grab hold of the implementation and programmatically change the log level. So if the default log level is INFO I don't think it's possible to ship all implementations and be able to flip to debug mode easily. So I think if we pick one implementation then for the CLI we can make that assumption. Again this should not affect folks who embed like m2e as we just use the components and do our own SLF4J integration. cheers Arnaud On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I did that in the branches using sys props
properties
property name=maven.logging.root.levelINFO/property
/properties
root level=${sys:maven.logging.root.level}
appender-ref ref=console/
/root
When starting and before any slf4j access, MavenCli check -q or -X or
none of both and correctly set the value to the level
(INFO,ERROR,DEBUG)
Works fine for all slf4j impls using this naming convention.
2012/12/4 Jason van Zyl ja...@tesla.io:
On Dec 4, 2012, at 9:44 AM, Arnaud Héritier aherit...@gmail.com wrote:
Jason,
I'll test more later but FYI it seems that your logback branch doesn't
support options -X/--debug
I've been talking to Ceki about configuration in SLF4J as there is really no
way to change the log level without assuming an implementation. If that's the
way then for embedding the user can change the SLF4J implementation but for
the CLI this will not be possible. What I would effectively have to do is
what the Sonar folks did which is to grab hold of the implementation and
programmatically change the log level.
So if the default log level is INFO I don't think it's possible to ship all
implementations and be able to flip to debug mode easily. So I think if we
pick one implementation then for the CLI we can make that assumption. Again
this should not affect folks who embed like m2e as we just use the components
and do our own SLF4J integration.
cheers
Arnaud
On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote:
I already have started a logback version, but I don't think this should
affect rolling the 3.1.0.
On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote:
I pushed the prototype developed by olivier using log4j2 in the
branch feature/colorized-console/log4j2
I updated with latest master changes
You can test the distro of this code : http://cl.ly/1B1z051O0T10
Tonight I'll try to do a logback version
cheers
Arnaud
On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com
wrote:
On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr
wrote:
I just created and fixed MNG-5395 and MNG-5396, which are logger names
enhancements from the actual values that will give value even with
slf4j-
simple
These should be a starting point for more global discussion about our
logging
conventions then fixed in our global codebase, since IMHO, these issues
show
how we didn't use the logger names until now then we have a lot of
place
where
our logging pratice is not good
Of course, I'm interested in colorized output, but since it has impact
on
logging implementation choice, which will require a strong discussion,
this
can't be done for the moment :|
A strong discussion ? seriously ?
We have 3 choices from my point of view :
* We do nothing, we keep the slf4j-simple
* We choose logback which is mature and used by a lot of people.
Nowadays
from my point of view it is the reference implementation
* We choose log4j2 which is really promising but always in beta. But we
may do this political to support this project which is rising from the
ashes (http://logging.apache.org/log4j/2.x/manual/index.html)
In any case doing a choice nowadays for 3.1.0 won't prevent us to change
it in the future. I really hope that the ability to switch from a logger
implementation to another won't require several days of developments or
I
really missed something about it.
Cheers
Arnaud
Regards,
Hervé
Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit :
Hi Jason,
Couldn't we have a look at olamy's log4j2 branch to see if we could
sanitize / merge it to propose at least one change for the end user
and demonstrate the interest of the change about logs : a colorized
console.
I remember you did that in mvnsh/teslashell a long time ago (as an
extension ?) and perhaps it could be easy to add properly this feature
in 3.1.0 (otherwise it won't be before a 3.2.0).
Myself I'm using a 3.1.0 fork with this patch and I' m really
satisfied (it's so good to quickly see highlighted warning and errors
). I merged it back in the last 3.1.0 tag you did without issue
Wdyt?
-
Arnaud
Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit :
I'm done with the issues that cropped up so I'm ready to re-spin
3.1.0.
Anyone want to add anything or discuss anything before I spin this?
I'm
not in any rush so if folks want to talk about logging we can. But
given
the fact once SLF4J initializes it can't change the implementation
plugins integrating with Maven need to use the implementation we
choose.
This is how everything else in the world that integrates SLF4J has to
operate so I don't really see us being any different.
I'll wait until tomorrow to re-spin.
Thanks,
Jason
--
Jason van Zyl
Founder CTO, Sonatype
Founder, Apache Maven
http://twitter.com/jvanzyl
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
On 04.12.2012 19:18, Jason van Zyl wrote:
I've been talking to Ceki about configuration in SLF4J as there is
really no way to change the log level without assuming an
implementation. If that's the way then for embedding the user can
change the SLF4J implementation but for the CLI this will not be
possible. What I would effectively have to do is what the Sonar folks
did which is to grab hold of the implementation and programmatically
change the log level.
So if the default log level is INFO I don't think it's possible to
ship all implementations and be able to flip to debug mode easily. So
I think if we pick one implementation then for the CLI we can make
that assumption. Again this should not affect folks who embed like m2e
as we just use the components and do our own SLF4J integration.
It would be possible to set the level of a logger by invoking
framework-specific directives. Here is some pseudo-code:
// pseudo code
public void setLevel(Logger logger, int level) {
if(logger instanceof org.apache.log4j.Logger) {
log4jSetLevel(logger, level);
} else if(logger instanceof ch.qos.logback.classic.Logger) {
logbackSetLevel(logger, level);
} else if (logger instanceof java.util.logging.Logger) {
julSetLevel(logger, level);
} else if (you get the idea...) {
...
}
}
Historically, SLF4J has shied away from providing abstractions for
logging configuration for two reasons:
1) logging configuration can have quite a large scope.
2) insufficient demand
If the scope of configuration is limited to logger level
configuration, the problem becomes much easier to tackle as
illustrated by the pseudo code above. Would Maven's logging
configuration requirements be satisfied by logger level configuration
or are there requirements beyond logger level configuration?
By the way, the is no reason why Maven could not implement similar
level configuration code on its own without depending on a slf4j
configuration module which currently does not exist.
--
Ceki
http://twitter.com/#!/ceki
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail:
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
On Mon, Dec 3, 2012 at 8:47 AM, Olivier Lamy ol...@apache.org wrote: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). I'm pretty sure it will not work in Eclipse because the Eclipse console is not a real console. At least it did not work for me when I was working on the color log features for log4j2. Works great in a real console of course. Gary [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
yes it is the same thing for logback version For sure we'll provided it by default the day we'll provide this feature. On Mon, Dec 3, 2012 at 2:05 PM, Marc Pasteur marc.past...@gmail.com wrote: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin.
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I had the feedback (not tested myself) that the log4j2 (I suppose it is the same for the logback) adds colors in netbeans console. Arnaud On Mon, Dec 3, 2012 at 2:47 PM, Olivier Lamy ol...@apache.org wrote: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
works fine but as someone (don't remember who... arnaud maybe) said the color for info message is black so... not so readable on a black background :-) for la vie en rose i've to made a patch as only MAGENTA is allowed at the moment but that could be cute :-) it works neither in intellij nor in eclipse (Helios) regards, 2012/12/3 Olivier Lamy ol...@apache.org 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? for sure it's (at least in dynamic-logging-impl branch) Test that http://people.apache.org/~olamy/maven/dynamic-logging-impl/. Let us know if that work on Windows. Happy to give you some colors in your terminal life ! (la vie en rose maybe :-) ) BTW does it works too when running maven in various IDE ? (sorry I'm an eternal terminal console lover). [1] http://logging.apache.org/log4j/2.x/manual/layouts.html regards, 2012/12/2 Arnaud Héritier aherit...@gmail.com +1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.com wrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I agree but sincerely I'm sure that less than 0,01% of our users will customize their logs. On Sat, Dec 1, 2012 at 9:27 PM, Anders Hammar and...@hammar.net wrote: In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Well, very likely it would affect the end users as the logger configuration would be different. And that could be confusing and also have people convert their adapted logger config files. /Anders Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
Thanks a lot to have pushed it. I tested it with success I like it, at least something that will improve the user experience soon. Note : Like Olivier's branch the default logging setup has an issue because the default color is set to black (or white) which are backgrounds colors commonly used. This is something we'll have to take care. The best should be to not touch the default foreground color for INFO level and just add colors for others levels. Cheers, On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
+1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33 PM, Benson Margulies bimargul...@gmail.comwrote: OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.com wrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.fr wrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks,
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.comwrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.frwrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.comwrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.frwrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl -
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM, Arnaud Héritier aherit...@gmail.comwrote: On Sat, Dec 1, 2012 at 9:40 AM, Hervé BOUTEMY herve.bout...@free.frwrote: I just created and fixed MNG-5395 and MNG-5396, which are logger names enhancements from the actual values that will give value even with slf4j- simple These should be a starting point for more global discussion about our logging conventions then fixed in our global codebase, since IMHO, these issues show how we didn't use the logger names until now then we have a lot of place where our logging pratice is not good Of course, I'm interested in colorized output, but since it has impact on logging implementation choice, which will require a strong discussion, this can't be done for the moment :| A strong discussion ? seriously ? We have 3 choices from my point of view : * We do nothing, we keep the slf4j-simple * We choose logback which is mature and used by a lot of people. Nowadays from my point of view it is the reference implementation * We choose log4j2 which is really promising but always in beta. But we may do this political to support this project which is rising from the ashes (http://logging.apache.org/log4j/2.x/manual/index.html) In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail:
Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0
In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Well, very likely it would affect the end users as the logger configuration would be different. And that could be confusing and also have people convert their adapted logger config files. /Anders Cheers Arnaud Regards, Hervé Le samedi 1 décembre 2012 09:17:52 Arnaud Héritier a écrit : Hi Jason, Couldn't we have a look at olamy's log4j2 branch to see if we could sanitize / merge it to propose at least one change for the end user and demonstrate the interest of the change about logs : a colorized console. I remember you did that in mvnsh/teslashell a long time ago (as an extension ?) and perhaps it could be easy to add properly this feature in 3.1.0 (otherwise it won't be before a 3.2.0). Myself I'm using a 3.1.0 fork with this patch and I' m really satisfied (it's so good to quickly see highlighted warning and errors ). I merged it back in the last 3.1.0 tag you did without issue Wdyt? - Arnaud Le 1 déc. 2012 à 00:20, Jason van Zyl ja...@tesla.io a écrit : I'm done with the issues that cropped up so I'm ready to re-spin 3.1.0. Anyone want to add anything or discuss anything before I spin this? I'm not in any rush so if folks want to talk about logging we can. But given the fact once SLF4J initializes it can't change the implementation plugins integrating with Maven need to use the implementation we choose. This is how everything else in the world that integrates SLF4J has to operate so I don't really see us being any different. I'll wait until tomorrow to re-spin. Thanks, Jason -- Jason van Zyl Founder CTO, Sonatype Founder, Apache Maven http://twitter.com/jvanzyl - - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- - Arnaud Héritier http://aheritier.net Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
