Re: Review Request 24464: Redirect docker logs

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
---

(Updated Aug. 12, 2014, 7:44 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24464


Diffs (updated)
-

  src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
  src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
  src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
  src/tests/docker_containerizer_tests.cpp 
a559836dd11a9a97e5939364c4b35a8dbb6a503d 

Diff: https://reviews.apache.org/r/24464/diff/


Testing
---

make check


Thanks,

Timothy Chen

Build failed in Jenkins: mesos-reviewbot #1316

[Apache Jenkins Server]

See 

Changes:

[benjamin.hindman] Added missing 'defer' helpers.

--
[...truncated 5571 lines...]
rm -f state/.dirstamp
rm -f log/tool/*.lo
rm -f tests/.deps/.dirstamp
rm -f logging/*.o
rm -f tests/.dirstamp
rm -f logging/*.lo
rm -f usage/.deps/.dirstamp
rm -f master/*.o
rm -f usage/.dirstamp
rm -f zookeeper/.deps/.dirstamp
rm -f zookeeper/.dirstamp
rm -f master/*.lo
rm -f messages/*.o
rm -f messages/*.lo
rm -f sasl/*.o
rm -f sasl/*.lo
rm -f sched/*.o
rm -f sched/*.lo
rm -f scheduler/*.o
rm -f scheduler/*.lo
rm -f slave/*.o
rm -f slave/*.lo
rm -f slave/containerizer/*.o
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -f state/*.lo
rm -f tests/*.o
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs 
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs 
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps 
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps 
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps 
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps 
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps 
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps 
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps 
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps 
state/.deps tests/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory 
`
Making distclean in ec2
make[2]: Entering directory 
`
rm -rf .libs _libs
rm -f *.lo
test -z "" || rm -f 
test . = "../../ec2" || test -z "" || rm -f 
rm -f Makefile
make[2]: Leaving directory 
`
rm -f config.status config.cache config.log configure.lineno 
config.status.lineno
rm -f Makefile
make[1]: Leaving directory 
`
if test -d "mesos-0.20.0"; then find "mesos-0.20.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.20.0" || { sleep 5 && rm -rf 
"mesos-0.20.0"; }; else :; fi
==
mesos-0.20.0 archives ready for distribution: 
mesos-0.20.0.tar.gz
==

real19m55.369s
user133m47.499s
sys 7m13.421s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am 
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap 
compile config.guess config.log config.lt config.status config.sub configure 
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh 
m4 mesos-0.20.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #264

[Apache Jenkins Server]

See 

Re: Review Request 24475: Add new Docker configurations

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/
---

(Updated Aug. 12, 2014, 8:45 a.m.)


Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.


Repository: mesos-git


Description
---

Added new DockerInfo for future docker options, and allow command uris to be 
fetched and mapped into docker before launching docker container.


Diffs (updated)
-

  include/mesos/mesos.proto cc9f20e 
  src/docker/docker.hpp 98b2d60 
  src/docker/docker.cpp 1cba381 
  src/slave/containerizer/containerizer.hpp 02754cd 
  src/slave/containerizer/containerizer.cpp c91ba38 
  src/slave/containerizer/docker.cpp 904cdd3 
  src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
  src/slave/flags.hpp 841de23 
  src/slave/slave.cpp 787bd05 
  src/tests/docker_containerizer_tests.cpp a559836 
  src/tests/docker_tests.cpp 4ef1df4 

Diff: https://reviews.apache.org/r/24475/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

[Yifan Gu]

> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1097
> > 
> >
> > I think you can get rid of 'runTask' future and just work with 
> > 'updateCall' future. Any reason to need both?

Thanks! Vinod!
Now I changed to

AWAIT_READY(update);
EXPECT_TRUE(status2.isPending());

Do you think

AWAIT_READY(update);
Clock::pause();
Clock::settle();
EXPECT_TRUE(status2.isPending());
Clock::resume();

will be better?


> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1254
> > 
> >
> > Why are you failing the promise here? Don't you want to set it to 
> > Nothing and then make sure that task doesn't launch? Otherwise, what you 
> > are testing is "containerizer update failure" path and not 
> > "executor/framework removed" path.

Umm, I can return Nothing here, but I think since the "executor/framework 
removed" path is visited first, so either will test this path.


> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1314
> > 
> >
> > Kill this? Why would there be subsequent updates here?

I remember that last time I ignored the subsequent updates, it will cause the 
tests to fail.
https://issues.apache.org/jira/browse/MESOS-1460

But I have run these tests for more than 3000 times without 
.WillRepeatedly(Return()); They haven't failed yet...


> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 1338
> > 
> >
> > I think you also want to return immediately if executor is in 
> > TERMINATING/TERMINATED state.

Thanks!
I think I need to add tests to test the case of:
1, the framework is in terminating/terminated.
2, the executor is in terminating/terminated.
3, the executor is removed...

I am not sure if there is any chance that a framework is not NULL but the 
executor is NULL...


- Yifan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review50239
---


On Aug. 12, 2014, 6:10 a.m., Yifan Gu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22313/
> ---
> 
> (Updated Aug. 12, 2014, 6:10 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-886
> https://issues.apache.org/jira/browse/MESOS-886
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added __runTask() to wait for the completion of containerizer->update() and 
> check the result before sending RunTaskMessage.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 9d4607e 
>   src/slave/slave.cpp 787bd05 
>   src/tests/slave_tests.cpp 69be28f 
> 
> Diff: https://reviews.apache.org/r/22313/diff/
> 
> 
> Testing
> ---
> 
> SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
> SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
> SlaveTest.LaunchTaskAfterContainerizerUpdate
> 
> ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
> --gtest_filter=*LaunchTask*
> 
> successful times > 2000
> 
> make check
> 
> 
> File Attachments
> 
> 
> framework will exit
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
> log
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2330

[Apache Jenkins Server]

See 


Changes:

[benjamin.hindman] Added missing 'defer' helpers.

--
[...truncated 4015 lines...]
[ RUN  ] IntervalTest.Subtraction
[   OK ] IntervalTest.Subtraction (0 ms)
[ RUN  ] IntervalTest.Contains
[   OK ] IntervalTest.Contains (0 ms)
[ RUN  ] IntervalTest.LargeInterval
[   OK ] IntervalTest.LargeInterval (0 ms)
[ RUN  ] IntervalTest.IntervalIteration
[   OK ] IntervalTest.IntervalIteration (0 ms)
[ RUN  ] IntervalTest.EmptyInterval
[   OK ] IntervalTest.EmptyInterval (0 ms)
[ RUN  ] IntervalTest.Intersection
[   OK ] IntervalTest.Intersection (0 ms)
[ RUN  ] IntervalTest.IntersectionTest
[   OK ] IntervalTest.IntersectionTest (0 ms)
[ RUN  ] IntervalTest.Addition
[   OK ] IntervalTest.Addition (0 ms)
[ RUN  ] IntervalTest.Stream
[   OK ] IntervalTest.Stream (0 ms)
[ RUN  ] IntervalTest.Constructor
[   OK ] IntervalTest.Constructor (0 ms)
[ RUN  ] IntervalTest.Interval
[   OK ] IntervalTest.Interval (0 ms)
[--] 13 tests from IntervalTest (0 ms total)

[--] 1 test from OsSignalsTest
[ RUN  ] OsSignalsTest.suppress
[   OK ] OsSignalsTest.suppress (0 ms)
[--] 1 test from OsSignalsTest (0 ms total)

[--] 1 test from Thread
[ RUN  ] Thread.local
[   OK ] Thread.local (0 ms)
[--] 1 test from Thread (0 ms total)

[--] 29 tests from StringsTest
[ RUN  ] StringsTest.Format
[   OK ] StringsTest.Format (0 ms)
[ RUN  ] StringsTest.Trim
[   OK ] StringsTest.Trim (0 ms)
[ RUN  ] StringsTest.Replace
[   OK ] StringsTest.Replace (0 ms)
[ RUN  ] StringsTest.SplitNStringWithDelimsAtStart
[   OK ] StringsTest.SplitNStringWithDelimsAtStart (0 ms)
[ RUN  ] StringsTest.SplitNDelimOnlyString
[   OK ] StringsTest.SplitNDelimOnlyString (0 ms)
[ RUN  ] StringsTest.TokenizeWithMultipleDelims
[   OK ] StringsTest.TokenizeWithMultipleDelims (0 ms)
[ RUN  ] StringsTest.SplitStringWithDelimsAtEnd
[   OK ] StringsTest.SplitStringWithDelimsAtEnd (0 ms)
[ RUN  ] StringsTest.TokenizeNullByteDelim
[   OK ] StringsTest.TokenizeNullByteDelim (0 ms)
[ RUN  ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd
[   OK ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd (0 ms)
[ RUN  ] StringsTest.TokenizeDelimOnlyString
[   OK ] StringsTest.TokenizeDelimOnlyString (0 ms)
[ RUN  ] StringsTest.SplitNWithMultipleDelims
[   OK ] StringsTest.SplitNWithMultipleDelims (0 ms)
[ RUN  ] StringsTest.SplitWithMultipleDelims
[   OK ] StringsTest.SplitWithMultipleDelims (0 ms)
[ RUN  ] StringsTest.Contains
[   OK ] StringsTest.Contains (0 ms)
[ RUN  ] StringsTest.Split
[   OK ] StringsTest.Split (0 ms)
[ RUN  ] StringsTest.TokenizeEmptyString
[   OK ] StringsTest.TokenizeEmptyString (0 ms)
[ RUN  ] StringsTest.Pairs
[   OK ] StringsTest.Pairs (0 ms)
[ RUN  ] StringsTest.Tokenize
[   OK ] StringsTest.Tokenize (0 ms)
[ RUN  ] StringsTest.TokenizeStringWithDelimsAtStart
[   OK ] StringsTest.TokenizeStringWithDelimsAtStart (0 ms)
[ RUN  ] StringsTest.SplitNStringWithDelimsAtStartAndEnd
[   OK ] StringsTest.SplitNStringWithDelimsAtStartAndEnd (0 ms)
[ RUN  ] StringsTest.StartsWith
[   OK ] StringsTest.StartsWith (0 ms)
[ RUN  ] StringsTest.TokenizeStringWithDelimsAtEnd
[   OK ] StringsTest.TokenizeStringWithDelimsAtEnd (0 ms)
[ RUN  ] StringsTest.SplitNZero
[   OK ] StringsTest.SplitNZero (0 ms)
[ RUN  ] StringsTest.SplitStringWithDelimsAtStart
[   OK ] StringsTest.SplitStringWithDelimsAtStart (0 ms)
[ RUN  ] StringsTest.SplitN
[   OK ] StringsTest.SplitN (0 ms)
[ RUN  ] StringsTest.SplitStringWithDelimsAtStartAndEnd
[   OK ] StringsTest.SplitStringWithDelimsAtStartAndEnd (0 ms)
[ RUN  ] StringsTest.Remove
[   OK ] StringsTest.Remove (0 ms)
[ RUN  ] StringsTest.SplitNStringWithDelimsAtEnd
[   OK ] StringsTest.SplitNStringWithDelimsAtEnd (0 ms)
[ RUN  ] StringsTest.SplitDelimOnlyString
[   OK ] StringsTest.SplitDelimOnlyString (0 ms)
[ RUN  ] StringsTest.SplitEmptyString
[   OK ] StringsTest.SplitEmptyString (0 ms)
[--] 29 tests from StringsTest (1 ms total)

[--] 2 tests from HashMapTest
[ RUN  ] HashMapTest.Contains
[   OK ] HashMapTest.Contains (0 ms)
[ RUN  ] HashMapTest.Insert
[   OK ] HashMapTest.Insert (0 ms)
[--] 2 tests from HashMapTest (0 ms total)

[--] 2 tests from Base64
[ RUN  ] Base64.Encode
[   OK ] Base64.Encode (0 ms)
[ RUN  ] Base64.Decode
[   OK ] Base64.Decode (0 ms)
[--] 2 tests from Base64 (0 ms total)

[--] 5 tests from LinkedHashmapTest
[ RUN  ] LinkedHashmapTest.Values
[   OK ] LinkedHashmapTest.Values (0 ms)
[ RUN  ] LinkedHashmapTest

Re: Review Request 24349: Add ContainerInfo and Volumes proto defs

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24349/#review50308
---


Patch looks great!

Reviews applied: [24349]

All tests passed.

- Mesos ReviewBot


On Aug. 8, 2014, 6:10 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24349/
> ---
> 
> (Updated Aug. 8, 2014, 6:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ian Downes.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24349
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto efb42395f040eb9a9a25fbbb08582460b42a4390 
> 
> Diff: https://reviews.apache.org/r/24349/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Jenkins build is back to normal : mesos-reviewbot #1317

[Apache Jenkins Server]

See 

Re: Review Request 24264: Installed python libraries during make install.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24264/#review50315
---


Bad patch!

Reviews applied: [24264]

Failed command: git apply --index 24264.patch

Error:
 error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz'
error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz'
error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply
error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz'
error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz'
error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply


- Mesos ReviewBot


On Aug. 11, 2014, 6:09 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24264/
> ---
> 
> (Updated Aug. 11, 2014, 6:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-899
> https://issues.apache.org/jira/browse/MESOS-899
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Because eggs are impossible to uninstall, pip + wheel has been added as a
> packaging format. The wheels are generated in addition to eggs and then
> subsequently installed/uninstalled.
> 
> Note that the building of eggs has not been removed. This is because wheels
> cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs
> are needed for all the test scripts to run correctly without actually
> installing anything locally.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 
>   3rdparty/pip-1.5.6.tar.gz PRE-CREATION 
>   3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 
>   3rdparty/wheel-0.24.0.tar.gz PRE-CREATION 
>   configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b 
>   mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 
>   src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 
>   src/examples/python/test-containerizer.in 
> f71828db98a90f455c88d90cb4e3320b7e8c9e9e 
>   src/examples/python/test-executor.in 
> b22e7a7dc0c26f805eb63c7139066ce7dc830636 
>   src/examples/python/test-framework.in 
> 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb 
> 
> Diff: https://reviews.apache.org/r/24264/diff/
> 
> 
> Testing
> ---
> 
> `make distcheck -j6`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Build failed in Jenkins: mesos-reviewbot #1319

[Apache Jenkins Server]

See 

--
[...truncated 5570 lines...]
rm -f state/.dirstamp
rm -f tests/.deps/.dirstamp
rm -f tests/.dirstamp
rm -f usage/.deps/.dirstamp
rm -f log/tool/*.lo
rm -f usage/.dirstamp
rm -f logging/*.o
rm -f zookeeper/.deps/.dirstamp
rm -f logging/*.lo
rm -f zookeeper/.dirstamp
rm -f master/*.o
rm -f master/*.lo
rm -f messages/*.o
rm -f messages/*.lo
rm -f sasl/*.o
rm -f sasl/*.lo
rm -f sched/*.o
rm -f sched/*.lo
rm -f scheduler/*.o
rm -f scheduler/*.lo
rm -f slave/*.o
rm -f slave/*.lo
rm -f slave/containerizer/*.o
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -f state/*.lo
rm -f tests/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -f usage/*.o
rm -rf linux/.libs linux/_libs
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs 
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs 
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps 
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps 
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps 
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps 
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps 
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps 
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps 
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps 
state/.deps tests/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory 
`
Making distclean in ec2
make[2]: Entering directory 
`
rm -rf .libs _libs
rm -f *.lo
test -z "" || rm -f 
test . = "../../ec2" || test -z "" || rm -f 
rm -f Makefile
make[2]: Leaving directory 
`
rm -f config.status config.cache config.log configure.lineno 
config.status.lineno
rm -f Makefile
make[1]: Leaving directory 
`
if test -d "mesos-0.20.0"; then find "mesos-0.20.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.20.0" || { sleep 5 && rm -rf 
"mesos-0.20.0"; }; else :; fi
==
mesos-0.20.0 archives ready for distribution: 
mesos-0.20.0.tar.gz
==

real20m24.106s
user134m40.105s
sys 7m24.270s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am 
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap 
compile config.guess config.log config.lt config.status config.sub configure 
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh 
m4 mesos-0.20.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
Removing 3rdparty/libprocess/3rdparty/stout/co

Re: Review Request 24464: Redirect docker logs

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50333
---

Ship it!


Looks good! Thanks for the cleanup!


src/docker/docker.hpp


s/the/The/



src/docker/docker.hpp


This fits in one line?



src/docker/docker.cpp


Hum, why revert this change. No need to save the temp var 'msg'.



src/slave/containerizer/docker.cpp


s/containerName/container/



src/slave/containerizer/docker.cpp


I would probably do the following (reads better):

if (!containerLogs.contains(containerId)) {
  LOG(WARNING) << "...";

  ___destroy(containerId, killed, status);
  return;
}

Docker::Logs logs = containerLogs[containerId];

logs.close();

logs.wait().onAny(defer(
self(),
&destroy,
containerId,
killed,
status,
lambda::_1));



src/slave/containerizer/docker.cpp


One small issue here is that: if the 'docker logs' fails, we won't be able 
to notice that (through mesos logging) until the container is about to be 
destroyed. Worth adding a comment here.



src/slave/containerizer/docker.cpp


s/logStatus/waited/


- Jie Yu


On Aug. 12, 2014, 7:44 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> ---
> 
> (Updated Aug. 12, 2014, 7:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24464
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
>   src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
>   src/tests/docker_containerizer_tests.cpp 
> a559836dd11a9a97e5939364c4b35a8dbb6a503d 
> 
> Diff: https://reviews.apache.org/r/24464/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24588: Added Docker::pull.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24588/#review50341
---


Probably worth adding some tests.


src/docker/docker.cpp


Here, you are reading the output from 'pull'? Shouldn't you read the output 
from 'inspect'?


- Jie Yu


On Aug. 12, 2014, 5:07 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24588/
> ---
> 
> (Updated Aug. 12, 2014, 5:07 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
> 
> Diff: https://reviews.apache.org/r/24588/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24194: Fixed bug in io::poll.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24194/#review50346
---


Ben, can you commit this patch? Thanks!

- Jie Yu


On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24194/
> ---
> 
> (Updated Aug. 1, 2014, 8:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-1658
> https://issues.apache.org/jira/browse/MESOS-1658
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See bug. Note that we already had tests for discarding an io::poll.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b 
> 
> Diff: https://reviews.apache.org/r/24194/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24475: Add new Docker configurations

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/#review50347
---


flying by review:)


src/docker/docker.hpp


Given that, consider putting docker.hpp/cpp into namespace mesos::internal ?


- Jie Yu


On Aug. 12, 2014, 8:45 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24475/
> ---
> 
> (Updated Aug. 12, 2014, 8:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added new DockerInfo for future docker options, and allow command uris to be 
> fetched and mapped into docker before launching docker container.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cc9f20e 
>   src/docker/docker.hpp 98b2d60 
>   src/docker/docker.cpp 1cba381 
>   src/slave/containerizer/containerizer.hpp 02754cd 
>   src/slave/containerizer/containerizer.cpp c91ba38 
>   src/slave/containerizer/docker.cpp 904cdd3 
>   src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
>   src/slave/flags.hpp 841de23 
>   src/slave/slave.cpp 787bd05 
>   src/tests/docker_containerizer_tests.cpp a559836 
>   src/tests/docker_tests.cpp 4ef1df4 
> 
> Diff: https://reviews.apache.org/r/24475/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

[Yifan Gu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---

(Updated Aug. 12, 2014, 7:28 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Bugs: MESOS-886
https://issues.apache.org/jira/browse/MESOS-886


Repository: mesos-git


Description
---

Added __runTask() to wait for the completion of containerizer->update() and 
check the result before sending RunTaskMessage.


Diffs (updated)
-

  src/slave/slave.hpp 9d4607e 
  src/slave/slave.cpp 787bd05 
  src/tests/slave_tests.cpp 69be28f 

Diff: https://reviews.apache.org/r/22313/diff/


Testing
---

SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
SlaveTest.LaunchTaskAfterContainerizerUpdate

./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
--gtest_filter=*LaunchTask*

successful times > 2000

make check


File Attachments


framework will exit
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
log
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log


Thanks,

Yifan Gu

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

[Yifan Gu]

> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 1338
> > 
> >
> > I think you also want to return immediately if executor is in 
> > TERMINATING/TERMINATED state.
> 
> Yifan Gu wrote:
> Thanks!
> I think I need to add tests to test the case of:
> 1, the framework is in terminating/terminated.
> 2, the executor is in terminating/terminated.
> 3, the executor is removed...
> 
> I am not sure if there is any chance that a framework is not NULL but the 
> executor is NULL...

Looks like when the framework has more than one executors, then it's possible 
that one of the executors in removed, and the framework is not removed...


- Yifan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review50239
---


On Aug. 12, 2014, 7:28 p.m., Yifan Gu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22313/
> ---
> 
> (Updated Aug. 12, 2014, 7:28 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-886
> https://issues.apache.org/jira/browse/MESOS-886
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added __runTask() to wait for the completion of containerizer->update() and 
> check the result before sending RunTaskMessage.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 9d4607e 
>   src/slave/slave.cpp 787bd05 
>   src/tests/slave_tests.cpp 69be28f 
> 
> Diff: https://reviews.apache.org/r/22313/diff/
> 
> 
> Testing
> ---
> 
> SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
> SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
> SlaveTest.LaunchTaskAfterContainerizerUpdate
> 
> ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
> --gtest_filter=*LaunchTask*
> 
> successful times > 2000
> 
> make check
> 
> 
> File Attachments
> 
> 
> framework will exit
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
> log
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>

Re: Review Request 24194: Fixed bug in io::poll.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24194/#review50363
---

Ship it!


Also curious about calling ev_async_send after the watcher is stopped, per 
Jie's comment.


3rdparty/libprocess/src/process.cpp


Is there a reason that you added this CHECK here but not in 'polled' above? 
Seems like the same case?


- Ben Mahler


On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24194/
> ---
> 
> (Updated Aug. 1, 2014, 8:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-1658
> https://issues.apache.org/jira/browse/MESOS-1658
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See bug. Note that we already had tests for discarding an io::poll.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b 
> 
> Diff: https://reviews.apache.org/r/24194/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 22066: Added timeout to rescind unused offers

[Benjamin Mahler]

Hey Kapil, it looks like Tim had been following up with a separate review
for this:

https://reviews.apache.org/r/22796/


On Mon, Aug 11, 2014 at 8:09 PM, Mesos ReviewBot 
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22066/#review50281
> ---
>
>
> Patch looks great!
>
> Reviews applied: [22066]
>
> All tests passed.
>
> - Mesos ReviewBot
>
>
> On Aug. 9, 2014, 12:57 a.m., Kapil Arya wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/22066/
> > ---
> >
> > (Updated Aug. 9, 2014, 12:57 a.m.)
> >
> >
> > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and
> Timothy Chen.
> >
> >
> > Bugs: mesos-186
> > https://issues.apache.org/jira/browse/mesos-186
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > ---
> >
> > A timer is associated with each newly created offer.
> > The offer is rescinded on timeout.
> > The timer is disarmed on a launchTask or decline.
> >
> >
> > Diffs
> > -
> >
> >   src/master/flags.hpp 0db4c95
> >   src/master/master.hpp 29e8f49
> >   src/master/master.cpp e688b41
> >   src/tests/master_tests.cpp 9de2424
> >
> > Diff: https://reviews.apache.org/r/22066/diff/
> >
> >
> > Testing
> > ---
> >
> > Added one more test after Tim's patch to test offer is not rescinded
> once it has been declined.
> >
> > make check
> >
> >
> > Thanks,
> >
> > Kapil Arya
> >
> >
>
>

Re: Review Request 24576: Some Master cleanups.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24576/#review50366
---

Ship it!



src/master/master.cpp


Why loop through all validators and offers when one of them returns error? 
Short circuting as did earlier seems fine to me, though a bit verbose.



src/master/master.cpp


CHECK_SOME?


- Vinod Kone


On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24576/
> ---
> 
> (Updated Aug. 11, 2014, 11:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> There were a few cleanups here that I did on the way to MESOS-1620.
> 
> (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned<>.
> (2) Restructured the launch task code to be easier to read and understand.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
> 
> Diff: https://reviews.apache.org/r/24576/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 24563: MESOS-1693: enable build against non-x86 arch

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24563/#review50368
---


Patch looks great!

Reviews applied: [24563]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 8:32 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24563/
> ---
> 
> (Updated Aug. 11, 2014, 8:32 p.m.)
> 
> 
> Review request for mesos, Adam B and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1693
> https://issues.apache.org/jira/browse/MESOS-1693
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable building against non-x86 arch, namely arm builders on Fedora.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/internal.hpp 9f478ec 
>   3rdparty/libprocess/src/process.cpp 14cf317 
>   configure.ac 8fb0a3a 
> 
> Diff: https://reviews.apache.org/r/24563/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Jenkins build is back to normal : mesos-reviewbot #1321

[Apache Jenkins Server]

See 

Re: Review Request 24515: Model pending tasks in the Master's metrics and JSON.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24515/#review50367
---

Ship it!



src/common/http.cpp


#include 



src/common/http.cpp


why kill the new line?


- Vinod Kone


On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24515/
> ---
> 
> (Updated Aug. 11, 2014, 11:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We were not surfacing tasks that are pending validation / authorization.
> 
> These are now surfaced as staging tasks through metrics and through the http 
> state endpoint.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 
>   src/common/http.hpp 8216401e116406da7557f144ea13756013ec1c09 
>   src/common/http.cpp d27fe21cd381ed2b6a52b1246bf6c7db33c0873e 
>   src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
>   src/tests/common/http_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24515/diff/
> 
> 
> Testing
> ---
> 
> Added a test for the JSON modeling, there were no tests previously.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 22066: Added timeout to rescind unused offers

[Timothy Chen]

Hi Ben,

Kapil is continuing where I left off and finish the patch (that he originally 
started himself).

So the one he posted should have all my changes plus addressing your comments.

Tim

Sent from my iPhone

> On Aug 12, 2014, at 2:18 PM, Benjamin Mahler  
> wrote:
> 
> Hey Kapil, it looks like Tim had been following up with a separate review for 
> this:
> 
> https://reviews.apache.org/r/22796/
> 
> 
>> On Mon, Aug 11, 2014 at 8:09 PM, Mesos ReviewBot  
>> wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22066/#review50281
>> ---
>> 
>> 
>> Patch looks great!
>> 
>> Reviews applied: [22066]
>> 
>> All tests passed.
>> 
>> - Mesos ReviewBot
>> 
>> 
>> On Aug. 9, 2014, 12:57 a.m., Kapil Arya wrote:
>> >
>> > ---
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/22066/
>> > ---
>> >
>> > (Updated Aug. 9, 2014, 12:57 a.m.)
>> >
>> >
>> > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy 
>> > Chen.
>> >
>> >
>> > Bugs: mesos-186
>> > https://issues.apache.org/jira/browse/mesos-186
>> >
>> >
>> > Repository: mesos-git
>> >
>> >
>> > Description
>> > ---
>> >
>> > A timer is associated with each newly created offer.
>> > The offer is rescinded on timeout.
>> > The timer is disarmed on a launchTask or decline.
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   src/master/flags.hpp 0db4c95
>> >   src/master/master.hpp 29e8f49
>> >   src/master/master.cpp e688b41
>> >   src/tests/master_tests.cpp 9de2424
>> >
>> > Diff: https://reviews.apache.org/r/22066/diff/
>> >
>> >
>> > Testing
>> > ---
>> >
>> > Added one more test after Tim's patch to test offer is not rescinded once 
>> > it has been declined.
>> >
>> > make check
>> >
>> >
>> > Thanks,
>> >
>> > Kapil Arya
>> >
>> >
> 

Re: Review Request 24516: Expose pending tasks during reconciliation.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/#review50371
---

Ship it!



src/master/master.cpp


i don't think we should because that's a cache and people might 
un-necessarily depend on it.



src/tests/reconciliation_tests.cpp


update the comment.



src/tests/reconciliation_tests.cpp


update the comment.



src/tests/reconciliation_tests.cpp


update the comment.


- Vinod Kone


On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24516/
> ---
> 
> (Updated Aug. 11, 2014, 11:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We were not surfacing tasks that are pending validation / authorization.
> 
> These are now surfaced as staging tasks
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
>   src/tests/master_authorization_tests.cpp 
> 5c3557752df86e798ba5d804de588db55ddcfbf6 
>   src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 
> 
> Diff: https://reviews.apache.org/r/24516/diff/
> 
> 
> Testing
> ---
> 
> Updated the existing test.
> 
> I also removed the MasterAuthorizationTest.ReconcileTask test because it was 
> redundant with ReconciliationTest.PendingTask.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

4.8.0 Cxx11 compilation issue

[Chinmaya Manjunath]

Hello Guys:

I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting the 
following issue,  help is appreciated.


Thanks!



ake[6]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'

make[6]: Nothing to be done for `all'.
make[6]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'

make[6]: Nothing to be done for `all-am'.
make[6]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[4]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'

Making all in .
make[4]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess'
/bin/sh ./libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" 
-DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" 
-DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. 
-I../../../3rdparty/libprocess  -I../../../3rdparty/libprocess/include 
-I../../../3rdparty/libprocess/3rdparty/stout/include 
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15 
-I3rdparty/picojson-4f93734  -I3rdparty/ry-http-parser-1c3624a  
-Iparser/include  -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT 
libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c 
-o libprocess_la-metrics.lo `test -f 'src/metrics/metrics.cpp' || echo 
'../../../3rdparty/libprocess/'`src/metrics/metrics.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"libprocess\" 
-DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" 
"-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. 
-I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include 
-I../../../3rdparty/libprocess/3rdparty/stout/include 
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15 
-I3rdparty/picojson-4f93734 -I3rdparty/ry-http-parser-1c3624a 
-Iparser/include -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT 
libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c 
../../../3rdparty/libprocess/src/metrics/metrics.cpp  -fPIC -DPIC -o 
libprocess_la-metrics.o
In file included from 
../../../3rdparty/libprocess/include/process/check.hpp:22:0,
 from 
../../../3rdparty/libprocess/include/process/collect.hpp:6,
 from 
../../../3rdparty/libprocess/src/metrics/metrics.cpp:6:
../../../3rdparty/libprocess/include/process/future.hpp: In 
instantiation of 'class process::Future':
/usr/local/include/c++/4.8.0/functional:2177:71:   required by 
substitution of 'template 
template using _Invoke = decltype 
(std::__callable_functor(declval<_Functor&>())((declval<_ArgTypes>)()...)) 
[with _Functor = const std::function(const 
process::Future&)>&; _Res = process::Future; _ArgTypes = 
{const process::Future&}]'
/usr/local/include/c++/4.8.0/functional:2331:2:   required by 
substitution of 'template std::function<_Res(_ArgTypes 
...)>::_Requires...)>::_CheckResult...)>::_Invoke<_Functor>, _Res>, std::function<_Res(_ArgTypes ...)>&> 
std::function<_Res(_ArgTypes ...)>::operator=(_Functor&&) [with _Functor 
= _Functor; _Res = process::Future; _ArgTypes = {const 
process::Future&}] [with _Functor = const 
std::function(const process::Future&)>&]'
/usr/local/include/c++/4.8.0/tuple:236:72:   required from 'struct 
std::_Tuple_impl<0ul, std::function(const 
process::Future&)>, std::_Placeholder<1> >'
/usr/local/include/c++/4.8.0/tuple:521:11:   required from 'class 
std::tuple(const 
process::Future&)>, std::_Placeholder<1> >'
/usr/local/include/c++/4.8.0/functional:1288:29:   required from 'struct 
std::_Bind 
(std::function(const 
process::Future&)>::*)(const 
process::Future&)const>(std::function(const process::Future&)>, 
std::_Placeholder<1>)>'
../../../3rdparty/libprocess/include/process/c++11/defer.hpp:237:3:   
required by substitution of 'templateA0> process::_Deferredstd::function(P0)>::operator()), 
std::function(P0)>(), a0))> process::defer(const 
process::PID&, R (T::*)(P0), A0) [with R = void; T = 
process::internal::AwaitProcess; P0 = const 
process::Future&; A0 = std::_Placeholder<1>]'
../../..

Re: Review Request 22066: Added timeout to rescind unused offers

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22066/
---

(Updated Aug. 12, 2014, 6:14 p.m.)


Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy Chen.


Bugs: mesos-186
https://issues.apache.org/jira/browse/mesos-186


Repository: mesos-git


Description (updated)
---

A timer is associated with each newly created offer.
The offer is rescinded on timeout.
The timer is disarmed on a launchTask or decline.

This is continuation of Tim's patch: https://reviews.apache.org/r/22796/.  
Revision two represents the latest patch from Tim. I have tried to address the 
comments/concerns from that request into the third revision.


Diffs
-

  src/master/flags.hpp 0db4c95 
  src/master/master.hpp 29e8f49 
  src/master/master.cpp e688b41 
  src/tests/master_tests.cpp 9de2424 

Diff: https://reviews.apache.org/r/22066/diff/


Testing
---

Added one more test after Tim's patch to test offer is not rescinded once it 
has been declined.

make check


Thanks,

Kapil Arya

Re: Review Request 24464: Redirect docker logs

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/
---

(Updated Aug. 12, 2014, 10:28 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24464


Diffs (updated)
-

  src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
  src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
  src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
  src/tests/docker_containerizer_tests.cpp 
a559836dd11a9a97e5939364c4b35a8dbb6a503d 

Diff: https://reviews.apache.org/r/24464/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 22066: Added timeout to rescind unused offers

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22066/#review50377
---


Thanks Kapil, looks great, just some minor cleanups for the tests.

These items are not 'issues' per se, but I've made them issues so that you can 
fix or drop them as a checklist. I wish ReviewBoard would add a non-"issue" way 
to tag things in a manner that they tracked as addressed or dropped, but alas!


src/master/flags.hpp


End with a period. :)



src/tests/master_tests.cpp


Maybe s/OfferTimeoutNonZero/OfferTimeout/ here and 
s/OfferTimeoutZero/NoOfferTimeout/ below? Seems a bit clearer?



src/tests/master_tests.cpp


Why do you need to wait for this? Seems we could remove the FUTURE_PROTOBUF 
and AWAIT_READY here.



src/tests/master_tests.cpp


s/resourceOffered/resourceOffers/

When we name these Futures satisfied by the callbacks, we'll try to match 
their name with the callback name.



src/tests/master_tests.cpp


Please end comments with a period. :)



src/tests/master_tests.cpp


Doesn't look like the Clock::settle and Clock::resume are necessary.

Since you are waiting for the offer to be rescinded, you don't need to 
ensure the pending timers/events are flushed in libprocess via Clock::settle.



src/tests/master_tests.cpp


How about expecting that the resources are re-offered to the framework 
after the rescind?



src/tests/master_tests.cpp


How about saying "if there is no rescind timeout" rather than referring to 
zero?



src/tests/master_tests.cpp


How about pluralizing since there are many offers: s/offer1/offers1/

Or per my comment above with matching the callback name: 
s/offer1/resourceOffers1/



src/tests/master_tests.cpp


Ditto for ending with a period.



src/tests/master_tests.cpp


Don't think you need to capture or wait on this future, since you are 
waiting for the TASK_RUNNING status below. Anything I'm missing here?



src/tests/master_tests.cpp


You can be explicit about no rescind occurring by using .Times(0) as you 
did above. Any reason not to here?





src/tests/master_tests.cpp


Period here.



src/tests/master_tests.cpp


I don't think this is enough for this test.

We're not sure by the time that we advance the clock whether the offer has 
been created yet.

I would suggest the following:

Remove this future, instead wait for the decline LaunchTasksMessage to 
reach the master, then settle the clock to process it. After this point you can 
advance it and settle it to ensure that no rescind occurs. Make sense? 


- Ben Mahler


On Aug. 12, 2014, 10:14 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22066/
> ---
> 
> (Updated Aug. 12, 2014, 10:14 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy 
> Chen.
> 
> 
> Bugs: mesos-186
> https://issues.apache.org/jira/browse/mesos-186
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> A timer is associated with each newly created offer.
> The offer is rescinded on timeout.
> The timer is disarmed on a launchTask or decline.
> 
> This is continuation of Tim's patch: https://reviews.apache.org/r/22796/.  
> Revision two represents the latest patch from Tim. I have tried to address 
> the comments/concerns from that request into the third revision.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 0db4c95 
>   src/master/master.hpp 29e8f49 
>   src/master/master.cpp e688b41 
>   src/tests/master_tests.cpp 9de2424 
> 
> Diff: https://reviews.apache.org/r/22066/diff/
> 
> 
> Testing
> ---
> 
> Added one more test after Tim's patch to test offer is not rescinded once it 
> has been declined.
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: 4.8.0 Cxx11 compilation issue

[Benjamin Mahler]

Just curious, do you see this with gcc 4.8.1 / 4.8.2 or only with 4.8.0?


On Tue, Aug 12, 2014 at 3:07 PM, Chinmaya Manjunath 
wrote:

> Hello Guys:
>
> I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting the
> following issue,  help is appreciated.
>
> Thanks!
>
>
>
> ake[6]: Entering directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty/stout'
> make[6]: Nothing to be done for `all'.
> make[6]: Leaving directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty/stout'
> make[6]: Entering directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty'
> make[6]: Nothing to be done for `all-am'.
> make[6]: Leaving directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty'
> make[5]: Leaving directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty'
> make[4]: Leaving directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess/3rdparty'
> Making all in .
> make[4]: Entering directory `/home/chinmaya/work/mesos.
> old/build/3rdparty/libprocess'
> /bin/sh ./libtool  --tag=CXX   --mode=compile g++
> -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\"
> -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\"
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\"
> -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
> -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
> -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I.
> -I../../../3rdparty/libprocess  -I../../../3rdparty/libprocess/include
> -I../../../3rdparty/libprocess/3rdparty/stout/include
> -I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15
> -I3rdparty/picojson-4f93734  -I3rdparty/ry-http-parser-1c3624a
>  -Iparser/include  -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT
> libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c
> -o libprocess_la-metrics.lo `test -f 'src/metrics/metrics.cpp' || echo
> '../../../3rdparty/libprocess/'`src/metrics/metrics.cpp
> libtool: compile:  g++ -DPACKAGE_NAME=\"libprocess\" 
> -DPACKAGE_TARNAME=\"libprocess\"
> -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\""
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\"
> -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
> -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
> -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I.
> -I../../../3rdparty/libprocess -I../../../3rdparty/libprocess/include
> -I../../../3rdparty/libprocess/3rdparty/stout/include
> -I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15
> -I3rdparty/picojson-4f93734 -I3rdparty/ry-http-parser-1c3624a
> -Iparser/include -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT
> libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c
> ../../../3rdparty/libprocess/src/metrics/metrics.cpp  -fPIC -DPIC -o
> libprocess_la-metrics.o
> In file included from ../../../3rdparty/libprocess/
> include/process/check.hpp:22:0,
>  from ../../../3rdparty/libprocess/
> include/process/collect.hpp:6,
>  from ../../../3rdparty/libprocess/
> src/metrics/metrics.cpp:6:
> ../../../3rdparty/libprocess/include/process/future.hpp: In instantiation
> of 'class process::Future':
> /usr/local/include/c++/4.8.0/functional:2177:71:   required by
> substitution of 'template template _Functor> using _Invoke = decltype (std::__callable_functor(
> declval<_Functor&>())((declval<_ArgTypes>)()...)) [with _Functor = const
> std::function(const process::Future&)>&;
> _Res = process::Future; _ArgTypes = {const process::Future&}]'
> /usr/local/include/c++/4.8.0/functional:2331:2:   required by
> substitution of 'template std::function<_Res(_ArgTypes
> ...)>::_Requires ...)>::_CheckResult ...)>::_Invoke<_Functor>, _Res>, std::function<_Res(_ArgTypes ...)>&>
> std::function<_Res(_ArgTypes ...)>::operator=(_Functor&&) [with _Functor =
> _Functor; _Res = process::Future; _ArgTypes = {const
> process::Future&}] [with _Functor = const
> std::function(const process::Future&)>&]'
> /usr/local/include/c++/4.8.0/tuple:236:72:   required from 'struct
> std::_Tuple_impl<0ul, std::function(const
> process::Future&)>, std::_Placeholder<1> >'
> /usr/local/include/c++/4.8.0/tuple:521:11:   required from 'class
> std::tuple(const
> process::Future&)>, std::_Placeholder<1> >'
> /usr/local/include/c++/4.8.0/functional:1288:29:   required from 'struct
> std::_Bind 
> (std::function(const
> process::Future&)>::*)(const process::Future&)
> const>(std::function(const
> process::Future&)>, std::_Placeholder<1>)>'
> ../../../3rdparty/libprocess/include/process/c++11/defer.hpp:237:3:
> required by substitution of

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

[Yifan Gu]

> On Aug. 11, 2014, 10:56 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 1338
> > 
> >
> > I think you also want to return immediately if executor is in 
> > TERMINATING/TERMINATED state.
> 
> Yifan Gu wrote:
> Thanks!
> I think I need to add tests to test the case of:
> 1, the framework is in terminating/terminated.
> 2, the executor is in terminating/terminated.
> 3, the executor is removed...
> 
> I am not sure if there is any chance that a framework is not NULL but the 
> executor is NULL...
> 
> Yifan Gu wrote:
> Looks like when the framework has more than one executors, then it's 
> possible that one of the executors in removed, and the framework is not 
> removed...
>

I added two more tests to test these pathes.

Let me take another time to review that before ping you :)


- Yifan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review50239
---


On Aug. 12, 2014, 11:07 p.m., Yifan Gu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22313/
> ---
> 
> (Updated Aug. 12, 2014, 11:07 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Vinod Kone.
> 
> 
> Bugs: MESOS-886
> https://issues.apache.org/jira/browse/MESOS-886
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added __runTask() to wait for the completion of containerizer->update() and 
> check the result before sending RunTaskMessage.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 9d4607e 
>   src/slave/slave.cpp 787bd05 
>   src/tests/slave_tests.cpp 69be28f 
> 
> Diff: https://reviews.apache.org/r/22313/diff/
> 
> 
> Testing
> ---
> 
> SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
> SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
> SlaveTest.LaunchTaskAfterContainerizerUpdate
> 
> ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
> --gtest_filter=*LaunchTask*
> 
> successful times > 2000
> 
> make check
> 
> 
> File Attachments
> 
> 
> framework will exit
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
> log
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log
> 
> 
> Thanks,
> 
> Yifan Gu
> 
>

Re: Review Request 22313: MESOS-886: Prevented slave from launching tasks before containerize's update completes.

[Yifan Gu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---

(Updated Aug. 12, 2014, 11:07 p.m.)


Review request for mesos, Ian Downes and Vinod Kone.


Changes
---

Added two more tests to test when framework is removed/terminating, executor is 
removed/terminated.


Bugs: MESOS-886
https://issues.apache.org/jira/browse/MESOS-886


Repository: mesos-git


Description
---

Added __runTask() to wait for the completion of containerizer->update() and 
check the result before sending RunTaskMessage.


Diffs (updated)
-

  src/slave/slave.hpp 9d4607e 
  src/slave/slave.cpp 787bd05 
  src/tests/slave_tests.cpp 69be28f 

Diff: https://reviews.apache.org/r/22313/diff/


Testing
---

SlaveTest.WillNotLaunchTaskBeforeContainerizerUpdate
SlaveTest.WillNotLaunchTaskIfFrameworkIsRemoved
SlaveTest.LaunchTaskAfterContainerizerUpdate

./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure 
--gtest_filter=*LaunchTask*

successful times > 2000

make check


File Attachments


framework will exit
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/fbe73273-7aa9-4faa-b1c5-003ab03042a9__issue-886.diff
log
  
https://reviews.apache.org/media/uploaded/files/2014/06/18/84d801a0-5c2a-4bb9-901b-e1962031461c__log


Thanks,

Yifan Gu

Review Request 24619: Made value in CommandInfo optional and added argv.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  include/mesos/mesos.proto cc9f20e 

Diff: https://reviews.apache.org/r/24619/diff/


Testing
---


Thanks,

Jie Yu

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/#review50386
---

Ship it!


Ship It!

- Timothy Chen


On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24619/
> ---
> 
> (Updated Aug. 12, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cc9f20e 
> 
> Diff: https://reviews.apache.org/r/24619/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: 4.8.0 Cxx11 compilation issue

[Chinmaya Manjunath]

I just tried it with 4.8.0 and got this. Would think that it could 
happen with 4.8.1 as well.


This error disappears if I configure without cxx11 support, but I see 
that it is a deprecated setting.





Benjamin Mahler 
August 12, 2014 4:05 PM
Just curious, do you see this with gcc 4.8.1 / 4.8.2 or only with 4.8.0?


On Tue, Aug 12, 2014 at 3:07 PM, Chinmaya Manjunath 



Chinmaya Manjunath 
August 12, 2014 3:07 PM
Hello Guys:

I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting 
the following issue,  help is appreciated.


Thanks!



ake[6]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'

make[6]: Nothing to be done for `all'.
make[6]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'

make[6]: Nothing to be done for `all-am'.
make[6]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
make[4]: Leaving directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'

Making all in .
make[4]: Entering directory 
`/home/chinmaya/work/mesos.old/build/3rdparty/libprocess'
/bin/sh ./libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" 
-DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" 
-DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. 
-I../../../3rdparty/libprocess  -I../../../3rdparty/libprocess/include 
-I../../../3rdparty/libprocess/3rdparty/stout/include 
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src 
-I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734  
-I3rdparty/ry-http-parser-1c3624a  -Iparser/include  -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-metrics.lo -MD 
-MP -MF .deps/libprocess_la-metrics.Tpo -c -o libprocess_la-metrics.lo 
`test -f 'src/metrics/metrics.cpp' || echo 
'../../../3rdparty/libprocess/'`src/metrics/metrics.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"libprocess\" 
-DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" 
"-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess 
-I../../../3rdparty/libprocess/include 
-I../../../3rdparty/libprocess/3rdparty/stout/include 
-I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src 
-I3rdparty/libev-4.15 -I3rdparty/picojson-4f93734 
-I3rdparty/ry-http-parser-1c3624a -Iparser/include -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT libprocess_la-metrics.lo -MD 
-MP -MF .deps/libprocess_la-metrics.Tpo -c 
../../../3rdparty/libprocess/src/metrics/metrics.cpp  -fPIC -DPIC -o 
libprocess_la-metrics.o
In file included from 
../../../3rdparty/libprocess/include/process/check.hpp:22:0,
 from 
../../../3rdparty/libprocess/include/process/collect.hpp:6,
 from 
../../../3rdparty/libprocess/src/metrics/metrics.cpp:6:
../../../3rdparty/libprocess/include/process/future.hpp: In 
instantiation of 'class process::Future':
/usr/local/include/c++/4.8.0/functional:2177:71:   required by 
substitution of 'template 
template using _Invoke = decltype 
(std::__callable_functor(declval<_Functor&>())((declval<_ArgTypes>)()...)) 
[with _Functor = const std::function(const 
process::Future&)>&; _Res = process::Future; _ArgTypes = 
{const process::Future&}]'
/usr/local/include/c++/4.8.0/functional:2331:2:   required by 
substitution of 'template std::function<_Res(_ArgTypes 
...)>::_Requires...)>::_CheckResult...)>::_Invoke<_Functor>, _Res>, std::function<_Res(_ArgTypes ...)>&> 
std::function<_Res(_ArgTypes ...)>::operator=(_Functor&&) [with 
_Functor = _Functor; _Res = process::Future; _ArgTypes = {const 
process::Future&}] [with _Functor = const 
std::function(const process::Future&)>&]'
/usr/local/include/c++/4.8.0/tuple:236:72:   required from 'struct 
std::_Tuple_impl<0ul, std::function(const 
process::Future&)>, std::_Placeholder<1> >'
/usr/local/include/c++/4.8.0/tuple:521:11:   required from 'class 
std::tuple(const 
process::Future&)>, std::_Placeholder<1> >'
/usr/local/include/c++/4.8.0/functional:1288:29:   required from 
'struct std::_Bind 
(std::function(cons

Re: 4.8.0 Cxx11 compilation issue

[Benjamin Mahler]

Can you try it with 4.8.2?

I ask because most of the developers and many of the CI jobs compile with
4.8.1 or 4.8.2, so it would be nice to rule out an issue with 4.8.0.


On Tue, Aug 12, 2014 at 4:35 PM, Chinmaya Manjunath 
wrote:

> I just tried it with 4.8.0 and got this. Would think that it could happen
> with 4.8.1 as well.
>
> This error disappears if I configure without cxx11 support, but I see that
> it is a deprecated setting.
>
>
>
>   Benjamin Mahler 
>  August 12, 2014 4:05 PM
> Just curious, do you see this with gcc 4.8.1 / 4.8.2 or only with 4.8.0?
>
>
> On Tue, Aug 12, 2014 at 3:07 PM, Chinmaya Manjunath
>  
>
>   Chinmaya Manjunath 
>  August 12, 2014 3:07 PM
> Hello Guys:
>
> I am trying to build mesos on Centos6.5 and 4.8.0 g++ and am hitting the
> following issue,  help is appreciated.
>
> Thanks!
>
>
>
> ake[6]: Entering directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
> make[6]: Nothing to be done for `all'.
> make[6]: Leaving directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty/stout'
> make[6]: Entering directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
> make[6]: Nothing to be done for `all-am'.
> make[6]: Leaving directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
> make[5]: Leaving directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
> make[4]: Leaving directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess/3rdparty'
> Making all in .
> make[4]: Entering directory
> `/home/chinmaya/work/mesos.old/build/3rdparty/libprocess'
> /bin/sh ./libtool  --tag=CXX   --mode=compile g++
> -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\"
> -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\"
> -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\"
> -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1
> -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
> -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
> -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I.
> -I../../../3rdparty/libprocess  -I../../../3rdparty/libprocess/include
> -I../../../3rdparty/libprocess/3rdparty/stout/include
> -I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15
> -I3rdparty/picojson-4f93734  -I3rdparty/ry-http-parser-1c3624a
> -Iparser/include  -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT
> libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c -o
> libprocess_la-metrics.lo `test -f 'src/metrics/metrics.cpp' || echo
> '../../../3rdparty/libprocess/'`src/metrics/metrics.cpp
> libtool: compile:  g++ -DPACKAGE_NAME=\"libprocess\"
> -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\"
> "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\"
> -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\"
> -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
> -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
> -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\"
> -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../3rdparty/libprocess
> -I../../../3rdparty/libprocess/include
> -I../../../3rdparty/libprocess/3rdparty/stout/include
> -I3rdparty/boost-1.53.0 -I3rdparty/glog-0.3.3/src -I3rdparty/libev-4.15
> -I3rdparty/picojson-4f93734 -I3rdparty/ry-http-parser-1c3624a
> -Iparser/include -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT
> libprocess_la-metrics.lo -MD -MP -MF .deps/libprocess_la-metrics.Tpo -c
> ../../../3rdparty/libprocess/src/metrics/metrics.cpp  -fPIC -DPIC -o
> libprocess_la-metrics.o
> In file included from
> ../../../3rdparty/libprocess/include/process/check.hpp:22:0,
>  from
> ../../../3rdparty/libprocess/include/process/collect.hpp:6,
>  from
> ../../../3rdparty/libprocess/src/metrics/metrics.cpp:6:
> ../../../3rdparty/libprocess/include/process/future.hpp: In instantiation
> of 'class process::Future':
> /usr/local/include/c++/4.8.0/functional:2177:71:   required by
> substitution of 'template template _Functor> using _Invoke = decltype
> (std::__callable_functor(declval<_Functor&>())((declval<_ArgTypes>)()...))
> [with _Functor = const std::function(const
> process::Future&)>&; _Res = process::Future; _ArgTypes =
> {const process::Future&}]'
> /usr/local/include/c++/4.8.0/functional:2331:2:   required by substitution
> of 'template std::function<_Res(_ArgTypes
> ...)>::_Requires ...)>::_CheckResult::_Invoke<_Functor>,
> _Res>, std::function<_Res(_ArgTypes ...)>&> std::function<_Res(_ArgTypes
> ...)>::operator=(_Functor&&) [with _Functor = _Functor; _Res =
> process::Future; _ArgTypes = {const process::Future&}] [with
> _Functor = const std::function(const
> process::Future&)>&]'
> /usr/local/include/c++/4.8.0/tuple:236:72:   required from 'struct
> std::_Tuple_impl<0ul, 

Re: Review Request 24562: ZK URL Parsing Consolidation

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24562/#review50390
---


Patch looks great!

Reviews applied: [24562]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 7:54 p.m., Ken Sipe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24562/
> ---
> 
> (Updated Aug. 11, 2014, 7:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Consolidated redundant code for zk url parsing.   Through that, identified a 
> test that used zk file for something other than zk.  Fixed test, and added 
> test for file parsing.  It is tough to know if something other than zk can be 
> in the file (assuming it is a zk file).  If other things can go into the file 
> in question, then I can create a file parser.   The current URL::Parser lives 
> in the zookeeper namespace.
> 
> This patch also completes several documented todo is the code.
> 
> 
> Diffs
> -
> 
>   src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 
>   src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
>   src/tests/master_contender_detector_tests.cpp 
> fdddfa1a9c793bb406d85d214a18ca4ced53b09f 
>   src/zookeeper/url.hpp 16e711c5c0bc29b1967a20f0827238f8a7b0deaf 
> 
> Diff: https://reviews.apache.org/r/24562/diff/
> 
> 
> Testing
> ---
> 
> 1 test changed and 1 test added to: master_contender_detector_tests.cpp
> MasterContenderDetectorTest
> BasicMasterContenderDetectorTest
> 
> all tests pass including styling.
> 
> 
> Thanks,
> 
> Ken Sipe
> 
>

Fixing a buggy key/value pair in slave's /stats.json

[Vinod Kone]

Hi,

As BenM pointed out in https://issues.apache.org/jira/browse/MESOS-1695 a
tiny bug was introduced ~year ago in slave's /stats.json endpoint.
Specifically, the "registered" key in the JSON has a value "1"/"0" instead
of 1/0 (i.e., string instead of number).

I plan to fix it soon (likely 0.21.0), but wanted to know if anyone in the
community is already using/depending on this key/value from the endpoint.
If you are, please let me know and we can figure out a deprecation plan.

Sorry for the inconvenience

Vinod

Re: Review Request 24619: Made value in CommandInfo optional and added argv.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24619/#review50393
---


Could you include more information in the summary about the motivation? :)
For API changes so close to a cut, we should probably have a few eyes on it too.

This has come up before, be sure to take a look at the approach by Jason here: 
https://reviews.apache.org/r/15542/

Notably, the path and arguments were split apart, in a similar manner to how 
execv works. We also didn't need the boolean as you have in your patch here. 
Curious to hear your thoughts on that.

- Ben Mahler


On Aug. 12, 2014, 11:21 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24619/
> ---
> 
> (Updated Aug. 12, 2014, 11:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cc9f20e 
> 
> Diff: https://reviews.apache.org/r/24619/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 24628: MESOS-1171: unbundle gmock

[Timothy St. Clair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24628/
---

Review request for mesos, Jie Yu and Vinod Kone.


Bugs: MESOS-1171
https://issues.apache.org/jira/browse/MESOS-1171


Repository: mesos-git


Description
---

Enable support to build against unbundled versions of gmock.  


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 497d038 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/configure.ac 7b39e63 
  configure.ac 8fb0a3a 

Diff: https://reviews.apache.org/r/24628/diff/


Testing
---

configure && make check
configure --disable-bundled && make check
configure --with-gmock=/opt/gmock && make check


Thanks,

Timothy St. Clair

Re: Review Request 23086: MESOS-1174: Update system check to unbundle protobuf

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23086/#review50395
---


Patch looks great!

Reviews applied: [23086]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 7:11 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23086/
> ---
> 
> (Updated Aug. 11, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1174
> https://issues.apache.org/jira/browse/MESOS-1174
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enable mesos to build against system installed version of protobuf. 
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 497d038 
>   3rdparty/libprocess/configure.ac 7b39e63 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/Makefile.am 39af036 
>   src/examples/java/test-exception-framework.in 065f3c0 
>   src/examples/java/test-executor.in 35559d2 
>   src/examples/java/test-framework.in 9af48f9 
>   src/examples/java/test-log.in 8afed0d 
>   src/examples/java/test-multiple-executors-framework.in 235eb23 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
>   src/python/native/ext_modules.py.in 477e63d 
> 
> Diff: https://reviews.apache.org/r/23086/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24576: Some Master cleanups.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24576/#review50396
---

Ship it!


Modulo Vinod's comments. Looks good otherwise!


src/master/master.cpp


It this comment still relevant?


- Niklas Nielsen


On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24576/
> ---
> 
> (Updated Aug. 11, 2014, 4:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> There were a few cleanups here that I did on the way to MESOS-1620.
> 
> (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned<>.
> (2) Restructured the launch task code to be easier to read and understand.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
> 
> Diff: https://reviews.apache.org/r/24576/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 24475: Add new Docker configurations

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/
---

(Updated Aug. 13, 2014, 2:59 a.m.)


Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.


Repository: mesos-git


Description
---

Added new DockerInfo for future docker options, and allow command uris to be 
fetched and mapped into docker before launching docker container.


Diffs (updated)
-

  include/mesos/mesos.proto cc9f20e 
  src/docker/docker.hpp 98b2d60 
  src/docker/docker.cpp 1cba381 
  src/slave/containerizer/containerizer.hpp 02754cd 
  src/slave/containerizer/containerizer.cpp c91ba38 
  src/slave/containerizer/docker.cpp 904cdd3 
  src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
  src/slave/flags.hpp 841de23 
  src/slave/slave.cpp 787bd05 
  src/tests/docker_containerizer_tests.cpp a559836 
  src/tests/docker_tests.cpp 4ef1df4 

Diff: https://reviews.apache.org/r/24475/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24475: Add new Docker configurations

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/#review50398
---


Rebased and added unit test for fetch

- Timothy Chen


On Aug. 13, 2014, 2:59 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24475/
> ---
> 
> (Updated Aug. 13, 2014, 2:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added new DockerInfo for future docker options, and allow command uris to be 
> fetched and mapped into docker before launching docker container.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cc9f20e 
>   src/docker/docker.hpp 98b2d60 
>   src/docker/docker.cpp 1cba381 
>   src/slave/containerizer/containerizer.hpp 02754cd 
>   src/slave/containerizer/containerizer.cpp c91ba38 
>   src/slave/containerizer/docker.cpp 904cdd3 
>   src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
>   src/slave/flags.hpp 841de23 
>   src/slave/slave.cpp 787bd05 
>   src/tests/docker_containerizer_tests.cpp a559836 
>   src/tests/docker_tests.cpp 4ef1df4 
> 
> Diff: https://reviews.apache.org/r/24475/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24555: MESOS-1169: unbundle distribute

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24555/#review50399
---


Patch looks great!

Reviews applied: [24555]

All tests passed.

- Mesos ReviewBot


On Aug. 11, 2014, 3:43 p.m., Timothy St. Clair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24555/
> ---
> 
> (Updated Aug. 11, 2014, 3:43 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-1169
> https://issues.apache.org/jira/browse/MESOS-1169
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Enabling unbundling for distribute python utils.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 70b45fe 
>   configure.ac 8fb0a3a 
>   mpi/mpiexec-mesos.in 8812ee2 
>   src/examples/python/test-containerizer.in f71828d 
>   src/examples/python/test-executor.in b22e7a7 
>   src/examples/python/test-framework.in 64fb1dd 
> 
> Diff: https://reviews.apache.org/r/24555/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> ./configure --disable-bundled  && make check
> 
> For prefixed installs require updated PYTHON_PATH.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>

Re: Review Request 24475: Add new Docker configurations

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/#review50404
---

Ship it!



src/slave/containerizer/docker.cpp


What about taking a lambda::_1 here to just get the failure message? Then 
you can pass just failure messages to _fetchFailed from _fetch without having 
to pass the whole future.



src/slave/containerizer/docker.cpp


A CHECK_FAILED(status) would be nice here, but I don't think it's necessary 
if this function just takes a string.


- Benjamin Hindman


On Aug. 13, 2014, 2:59 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24475/
> ---
> 
> (Updated Aug. 13, 2014, 2:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added new DockerInfo for future docker options, and allow command uris to be 
> fetched and mapped into docker before launching docker container.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto cc9f20e 
>   src/docker/docker.hpp 98b2d60 
>   src/docker/docker.cpp 1cba381 
>   src/slave/containerizer/containerizer.hpp 02754cd 
>   src/slave/containerizer/containerizer.cpp c91ba38 
>   src/slave/containerizer/docker.cpp 904cdd3 
>   src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
>   src/slave/flags.hpp 841de23 
>   src/slave/slave.cpp 787bd05 
>   src/tests/docker_containerizer_tests.cpp a559836 
>   src/tests/docker_tests.cpp 4ef1df4 
> 
> Diff: https://reviews.apache.org/r/24475/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 24631: Refactored the protobuf message comparison logic.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24631/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

See summary. We need update CommandInfo comparison code to deal with the new 
fields.


Diffs
-

  src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee 

Diff: https://reviews.apache.org/r/24631/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 24632: Updated health check to use the new CommandInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/
---

Review request for mesos and Benjamin Hindman.


Summary (updated)
-

Updated health check to use the new CommandInfo.


Repository: mesos-git


Description (updated)
---

See summary.


Diffs (updated)
-

  src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 

Diff: https://reviews.apache.org/r/24632/diff/


Testing (updated)
---

make check


Thanks,

Jie Yu

Re: Review Request 24632: Updated health check to use the new CommandInfo.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
---



src/health-check/main.cpp


Thanks for the update! Do you mind adding a test for the shell path?


- Timothy Chen


On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> ---
> 
> (Updated Aug. 13, 2014, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 
> 
> Diff: https://reviews.apache.org/r/24632/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 24633: Updated mesos containerizer launcher to use the new CommandInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24633/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  src/slave/containerizer/mesos/launch.cpp 
f8324bb36f520412a6d44a856b37d0cbf27c0dbd 

Diff: https://reviews.apache.org/r/24633/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 24634: Updated slave http to use the new CommmandInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24634/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  src/slave/http.cpp 98bdab61bcfd581cc70c69112bdef37b6382423f 

Diff: https://reviews.apache.org/r/24634/diff/


Testing
---

make check


Thanks,

Jie Yu

Review Request 24635: Updated command executor to use the new CommandInfo.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24635/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

See summary.


Diffs
-

  src/launcher/executor.cpp b096b6879e395483fa49aab6abe2c0c9fc8f0216 
  src/slave/slave.cpp 787bd05d8c95eac5eaff02c7f31c848a0d873a83 

Diff: https://reviews.apache.org/r/24635/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 24632: Updated health check to use the new CommandInfo.

[Jie Yu]

> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > 
> >
> > Thanks for the update! Do you mind adding a test for the shell path?

I think the shell path should have already been tested by the existing tests, 
right?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
---


On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> ---
> 
> (Updated Aug. 13, 2014, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 
> 
> Diff: https://reviews.apache.org/r/24632/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24631: Refactored the protobuf message comparison logic.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24631/#review50407
---

Ship it!


Not exactly the most efficient way of doing this, but let's profile and 
optimize later if necessary! ;-)

- Benjamin Hindman


On Aug. 13, 2014, 5:17 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24631/
> ---
> 
> (Updated Aug. 13, 2014, 5:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary. We need update CommandInfo comparison code to deal with the new 
> fields.
> 
> 
> Diffs
> -
> 
>   src/common/type_utils.cpp c8fc7b3f1454baf5eeb04b5c781c0a0d05fd98ee 
> 
> Diff: https://reviews.apache.org/r/24631/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24593: Updated Docker::run to look for entrypoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24593/#review50408
---


Patch looks great!

Reviews applied: [24588, 24593]

All tests passed.

- Mesos ReviewBot


On Aug. 12, 2014, 6:38 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24593/
> ---
> 
> (Updated Aug. 12, 2014, 6:38 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
> 
> Diff: https://reviews.apache.org/r/24593/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 24632: Updated health check to use the new CommandInfo.

[Timothy Chen]

> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > 
> >
> > Thanks for the update! Do you mind adding a test for the shell path?
> 
> Jie Yu wrote:
> I think the shell path should have already been tested by the existing 
> tests, right?

Yes sorry the new exec path that you have.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
---


On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> ---
> 
> (Updated Aug. 13, 2014, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 
> 
> Diff: https://reviews.apache.org/r/24632/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24632: Updated health check to use the new CommandInfo.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50410
---

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> ---
> 
> (Updated Aug. 13, 2014, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 
> 
> Diff: https://reviews.apache.org/r/24632/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24633: Updated mesos containerizer launcher to use the new CommandInfo.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24633/#review50411
---

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 13, 2014, 5:25 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24633/
> ---
> 
> (Updated Aug. 13, 2014, 5:25 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> f8324bb36f520412a6d44a856b37d0cbf27c0dbd 
> 
> Diff: https://reviews.apache.org/r/24633/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24634: Updated slave http to use the new CommmandInfo.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24634/#review50412
---

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 13, 2014, 5:25 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24634/
> ---
> 
> (Updated Aug. 13, 2014, 5:25 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 98bdab61bcfd581cc70c69112bdef37b6382423f 
> 
> Diff: https://reviews.apache.org/r/24634/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24635: Updated command executor to use the new CommandInfo.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24635/#review50413
---

Ship it!



src/launcher/executor.cpp


Is your thought here that rather than do the validation at the master this 
will just cause the executor to fail (thus the task fail) so the framework will 
still find out? It's a slightly harder debugging problem, but maybe okay for 
now. How about a brief comment that explains this reasoning as much, and maybe 
even a TODO to do some validation in the master?


- Benjamin Hindman


On Aug. 13, 2014, 5:26 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24635/
> ---
> 
> (Updated Aug. 13, 2014, 5:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp b096b6879e395483fa49aab6abe2c0c9fc8f0216 
>   src/slave/slave.cpp 787bd05d8c95eac5eaff02c7f31c848a0d873a83 
> 
> Diff: https://reviews.apache.org/r/24635/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2331

[Apache Jenkins Server]

See 


Changes:

[benjamin.hindman] Add ContainerInfo and Volumes protobufs.

--
[...truncated 1596 lines...]
/bin/bash ./libtool --tag=CXX   --mode=link g++   -Wall -Wwrite-strings 
-Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -DNDEBUG -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11-o libglog.la -rpath /usr/local/lib  
libglog_la-logging.lo libglog_la-raw_logging.lo libglog_la-vlog_is_on.lo 
libglog_la-utilities.lo libglog_la-demangle.lo libglog_la-symbolize.lo 
libglog_la-signalhandler.lo -lpthread 
libtool: link: ar cru .libs/libglog.a  libglog_la-logging.o 
libglog_la-raw_logging.o libglog_la-vlog_is_on.o libglog_la-utilities.o 
libglog_la-demangle.o libglog_la-symbolize.o libglog_la-signalhandler.o
libtool: link: ranlib .libs/libglog.a
libtool: link: ( cd ".libs" && rm -f "libglog.la" && ln -s "../libglog.la" 
"libglog.la" )
g++ -DHAVE_CONFIG_H -I. -I./src  -I./src  -pthread-Wall -Wwrite-strings 
-Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT logging_unittest-logging_unittest.o 
-MD -MP -MF .deps/logging_unittest-logging_unittest.Tpo -c -o 
logging_unittest-logging_unittest.o `test -f 'src/logging_unittest.cc' || echo 
'./'`src/logging_unittest.cc
mv -f .deps/logging_unittest-logging_unittest.Tpo 
.deps/logging_unittest-logging_unittest.Po
/bin/bash ./libtool --tag=CXX   --mode=link g++ -pthread-Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g 
-g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread  -o logging_unittest  
logging_unittest-logging_unittest.o  libglog.la   -lpthread 
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual 
-Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs 
-std=c++11 -pthread -o logging_unittest logging_unittest-logging_unittest.o  
./.libs/libglog.a -lpthread -pthread
g++ -DHAVE_CONFIG_H -I. -I./src  -I./src  -pthread-Wall -Wwrite-strings 
-Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT demangle_unittest-demangle_unittest.o 
-MD -MP -MF .deps/demangle_unittest-demangle_unittest.Tpo -c -o 
demangle_unittest-demangle_unittest.o `test -f 'src/demangle_unittest.cc' || 
echo './'`src/demangle_unittest.cc
mv -f .deps/demangle_unittest-demangle_unittest.Tpo 
.deps/demangle_unittest-demangle_unittest.Po
/bin/bash ./libtool --tag=CXX   --mode=link g++ -pthread-Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g 
-g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread  -o demangle_unittest  
demangle_unittest-demangle_unittest.o  libglog.la   -lpthread 
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual 
-Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs 
-std=c++11 -pthread -o demangle_unittest demangle_unittest-demangle_unittest.o  
./.libs/libglog.a -lpthread -pthread
g++ -DHAVE_CONFIG_H -I. -I./src  -I./src  -pthread-Wall -Wwrite-strings 
-Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT 
stacktrace_unittest-stacktrace_unittest.o -MD -MP -MF 
.deps/stacktrace_unittest-stacktrace_unittest.Tpo -c -o 
stacktrace_unittest-stacktrace_unittest.o `test -f 'src/stacktrace_unittest.cc' 
|| echo './'`src/stacktrace_unittest.cc
mv -f .deps/stacktrace_unittest-stacktrace_unittest.Tpo 
.deps/stacktrace_unittest-stacktrace_unittest.Po
/bin/bash ./libtool --tag=CXX   --mode=link g++ -pthread-Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g 
-g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread  -o stacktrace_unittest  
stacktrace_unittest-stacktrace_unittest.o  libglog.la-lpthread 
libtool: link: g++ -pthread -Wall -Wwrite-strings -Woverloaded-virtual 
-Wno-sign-compare -DNO_FRAME_POINTER -g -g2 -O2 -Wno-unused-local-typedefs 
-std=c++11 -pthread -o stacktrace_unittest 
stacktrace_unittest-stacktrace_unittest.o  ./.libs/libglog.a -lpthread -pthread
g++ -DHAVE_CONFIG_H -I. -I./src  -I./src  -pthread-Wall -Wwrite-strings 
-Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g -g2 -O2 
-Wno-unused-local-typedefs -std=c++11 -MT 
symbolize_unittest-symbolize_unittest.o -MD -MP -MF 
.deps/symbolize_unittest-symbolize_unittest.Tpo -c -o 
symbolize_unittest-symbolize_unittest.o `test -f 'src/symbolize_unittest.cc' || 
echo './'`src/symbolize_unittest.cc
mv -f .deps/symbolize_unittest-symbolize_unittest.Tpo 
.deps/symbolize_unittest-symbolize_unittest.Po
/bin/bash ./libtool --tag=CXX   --mode=link g++ -pthread-Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  -DNO_FRAME_POINTER  -g 
-g2 -O2 -Wno-unused-local-typedefs -std=c++11 -pthread  -o symbolize_unittest  
symbolize_unittest-symbolize_unittest.o  

Re: Review Request 24475: Add new Docker configurations

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24475/
---

(Updated Aug. 13, 2014, 5:47 a.m.)


Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.


Repository: mesos-git


Description
---

Added new DockerInfo for future docker options, and allow command uris to be 
fetched and mapped into docker before launching docker container.


Diffs (updated)
-

  include/mesos/mesos.proto cc9f20e 
  src/docker/docker.hpp 98b2d60 
  src/docker/docker.cpp 1cba381 
  src/slave/containerizer/containerizer.hpp 02754cd 
  src/slave/containerizer/containerizer.cpp c91ba38 
  src/slave/containerizer/docker.cpp 904cdd3 
  src/slave/containerizer/mesos/containerizer.cpp 694c9d1 
  src/slave/flags.hpp 841de23 
  src/slave/slave.cpp 787bd05 
  src/tests/docker_containerizer_tests.cpp a559836 
  src/tests/docker_tests.cpp 4ef1df4 

Diff: https://reviews.apache.org/r/24475/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24516: Expose pending tasks during reconciliation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24516/#review50416
---


Bad patch!

Reviews applied: [24582, 24583, 24576, 24515, 24516]

Failed command: git apply --index 24516.patch

Error:
 error: patch failed: src/tests/master_authorization_tests.cpp:523
error: src/tests/master_authorization_tests.cpp: patch does not apply


- Mesos ReviewBot


On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24516/
> ---
> 
> (Updated Aug. 11, 2014, 11:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-1620
> https://issues.apache.org/jira/browse/MESOS-1620
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> We were not surfacing tasks that are pending validation / authorization.
> 
> These are now surfaced as staging tasks
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
>   src/tests/master_authorization_tests.cpp 
> 5c3557752df86e798ba5d804de588db55ddcfbf6 
>   src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 
> 
> Diff: https://reviews.apache.org/r/24516/diff/
> 
> 
> Testing
> ---
> 
> Updated the existing test.
> 
> I also removed the MasterAuthorizationTest.ReconcileTask test because it was 
> redundant with ReconciliationTest.PendingTask.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 24632: Updated health check to use the new CommandInfo.

[Jie Yu]

> On Aug. 13, 2014, 5:23 a.m., Timothy Chen wrote:
> > src/health-check/main.cpp, line 171
> > 
> >
> > Thanks for the update! Do you mind adding a test for the shell path?
> 
> Jie Yu wrote:
> I think the shell path should have already been tested by the existing 
> tests, right?
> 
> Timothy Chen wrote:
> Yes sorry the new exec path that you have.

Done.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24632/#review50405
---


On Aug. 13, 2014, 5:21 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24632/
> ---
> 
> (Updated Aug. 13, 2014, 5:21 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/health-check/main.cpp 472bffceab2feedd19903843af430ebc8fa6b789 
> 
> Diff: https://reviews.apache.org/r/24632/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 24464: Redirect docker logs

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50423
---


Patch looks great!

Reviews applied: [24464]

All tests passed.

- Mesos ReviewBot


On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> ---
> 
> (Updated Aug. 12, 2014, 10:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24464
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
>   src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
>   src/tests/docker_containerizer_tests.cpp 
> a559836dd11a9a97e5939364c4b35a8dbb6a503d 
> 
> Diff: https://reviews.apache.org/r/24464/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24464: Redirect docker logs

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24464/#review50426
---


Just realized. What's the recover story?
1) what if the slave exits, does the log process terminate?
2) if the log process does not terminate, how do we recover it (so that we can 
destroy it later)?

- Jie Yu


On Aug. 12, 2014, 10:28 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24464/
> ---
> 
> (Updated Aug. 12, 2014, 10:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24464
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 
>   src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 
>   src/slave/containerizer/docker.cpp 904cdd32362591777aecaa58e723af36419f011c 
>   src/tests/docker_containerizer_tests.cpp 
> a559836dd11a9a97e5939364c4b35a8dbb6a503d 
> 
> Diff: https://reviews.apache.org/r/24464/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24194: Fixed bug in io::poll.

[Benjamin Hindman]

> On Aug. 4, 2014, 10:48 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 3709
> > 
> >
> > It's likely that _poll is called after poll->watcher.async has been 
> > stopped. Will that cause any issue when we invoke ev_async_send(loop, 
> > async.get()) in _poll?
> > 
> > If not, it worths adding a comment here.

Added a comment!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24194/#review49473
---


On Aug. 1, 2014, 8:05 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24194/
> ---
> 
> (Updated Aug. 1, 2014, 8:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-1658
> https://issues.apache.org/jira/browse/MESOS-1658
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See bug. Note that we already had tests for discarding an io::poll.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 6f6f3f96a2c2354faf7a58f8627cd87fd22d9b9b 
> 
> Diff: https://reviews.apache.org/r/24194/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>