Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

Hey Cesar,

I have fixed a compilation issue after the MP work has been merged.
Lemme know if you need some help with this and I'm happy to help
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 13, 2018 at 7:10 AM César Hernández Mendoza <
cesargu...@gmail.com> wrote:

> Hi @Jean-Louis,
>
> The fix you did solve the general build if the test is skipt, but today I
> was starting to work on TOMEE-2357 [1] but when I pull the latest master,
> now the mp-rest-jwt example[2] PR you merged today is broken:
>
> I've attached the entire log. But the first exception present is:
> Dec 12, 2018 10:19:24 PM org.apache.webbeans.plugins.PluginLoader startUp
> INFO: Adding OpenWebBeansPlugin : [CdiPlugin]
> Dec 12, 2018 10:19:25 PM org.apache.webbeans.config.BeansDeployer
> deploySingleAnnotatedType
> WARNING: Skipping deployment of Class class
> org.apache.tomee.microprofile.jwt.config.ConfigurableJWTAuthContextInfo due
> to a NoClassDefFoundError: Lorg/eclipse/microprofile/config/Config;
> Dec 12, 2018 10:19:25 PM org.apache.openejb.cdi.OpenEJBLifecycle
> startApplication
> SEVERE: CDI Beans module deployment failed
> org.apache.webbeans.exception.WebBeansDeploymentException:
> javax.enterprise.inject.UnsatisfiedResolutionException: Api type
> [org.apache.tomee.microprofile.jwt.config.ConfigurableJWTAuthContextInfo]
> is not found with the qualifiers
> Qualifiers: [@javax.enterprise.inject.Default()]
> for injection into Field Injection Point, field name :
> configurableJWTAuthContextInfo, Bean Owner : [MPJWTFilter,
> WebBeansType:MANAGED, Name:null, API
> Types:[org.apache.tomee.microprofile.jwt.MPJWTFilter,javax.servlet.Filter,java.lang.Object],
> Qualifiers:[javax.enterprise.inject.Default,javax.enterprise.inject.Any]]
> at org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:356)
> at
> org.apache.openejb.cdi.OpenEJBLifecycle.startApplication(OpenEJBLifecycle.java:196)
> at
> org.apache.openejb.cdi.ThreadSingletonServiceImpl.initialize(ThreadSingletonServiceImpl.java:229)
>
> I notice that the PR for TOMEE-2247 - MicroProfile JWT Propagation 1.1 [3]
> was merged a couple days ago so I tried to upgrade in the mp-rest-jwt  pom
> file from 1.0
> to  1.1.1 but still the example test
> failed.
>
> At this point, I'm blocked to move forward TOMEE-2357 since I don't know
> the internals of the JWT implementation we currently have on master.
> Any help or pointers are more than welcome :)
>
> [1] TOMEE-2357 - MicroProfile JWT @RolesAllowed is been applied with an
> all or nothing policy
> [2] https://github.com/apache/tomee/tree/master/examples/mp-rest-jwt
> [3] https://github.com/apache/tomee/pull/173
>
> El mié., 12 dic. 2018 a las 18:39, Jean-Louis Monteiro (<
> jlmonte...@tomitribe.com>) escribió:
>
>> Of course
>>
>> Le mer. 12 déc. 2018 à 23:28, Roberto Cortez > >
>> a écrit :
>>
>> > Yeah, sorry I got it.
>> >
>> > > On 12 Dec 2018, at 16:55, Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com>
>> > wrote:
>> > >
>> > > Yes, here is the fix
>> > >
>> >
>> https://github.com/apache/tomee/commit/c17b93cb644bc7cbdd463d59ccfbf6a08998553f
>> > >
>> > > --
>> > > Jean-Louis Monteiro
>> > > http://twitter.com/jlouismonteiro
>> > > http://www.tomitribe.com
>> > >
>> > >
>> > > On Wed, Dec 12, 2018 at 12:44 PM Roberto Cortez
>> > 
>> > > wrote:
>> > >
>> > >> Hey JL,
>> > >>
>> > >> Were you able to fix the issue?
>> > >>
>> > >>> On 11 Dec 2018, at 09:03, Jean-Louis Monteiro <
>> > jlmonte...@tomitribe.com>
>> > >> wrote:
>> > >>>
>> > >>> I think I found the bug on this one. Let's open a PR and then if you
>> > >> could
>> > >>> give me your thoughts
>> > >>> --
>> > >>> Jean-Louis Monteiro
>> > >>> http://twitter.com/jlouismonteiro
>> > >>> http://www.tomitribe.com
>> > >>>
>> > >>>
>> > >>> On Mon, Dec 10, 2018 at 5:27 PM Jean-Louis Monteiro <
>> > >>> jlmonte...@tomitribe.com> wrote:
>> > >>>
>> > >>>> If you have some pointers, I'm happy to look at the issue. I'll
>> > probably
>> > >>>> learn something.
>> > >>>> --
>> > >>>> Jean-Louis Monteiro
>> > >>>&

Re: OWASP Dependency Checking?

[Jean-Louis Monteiro]

No issue for me.
Sounds like a good idea and a valuable contribution
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 13, 2018 at 10:10 AM Richard Zowalla 
wrote:

> Hey,
>
> any objectives against automatic checking of known, publicly disclosed
> dependency vulnerabilities in the Maven build process (e.g. via a profile).
>
> I was thinking about introducing OWASP dependency checking (see
> https://www.owasp.org/index.php/OWASP_Dependency_Check) in the TomEE
> project, so we are aware of security risks introduced by (transient)
> dependencies.
>
> Any thoughs on this?
>
> Best,
>
> Richard
>
>
>
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

Of course

Le mer. 12 déc. 2018 à 23:28, Roberto Cortez 
a écrit :

> Yeah, sorry I got it.
>
> > On 12 Dec 2018, at 16:55, Jean-Louis Monteiro 
> wrote:
> >
> > Yes, here is the fix
> >
> https://github.com/apache/tomee/commit/c17b93cb644bc7cbdd463d59ccfbf6a08998553f
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Dec 12, 2018 at 12:44 PM Roberto Cortez
> 
> > wrote:
> >
> >> Hey JL,
> >>
> >> Were you able to fix the issue?
> >>
> >>> On 11 Dec 2018, at 09:03, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> >> wrote:
> >>>
> >>> I think I found the bug on this one. Let's open a PR and then if you
> >> could
> >>> give me your thoughts
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>> On Mon, Dec 10, 2018 at 5:27 PM Jean-Louis Monteiro <
> >>> jlmonte...@tomitribe.com> wrote:
> >>>
> >>>> If you have some pointers, I'm happy to look at the issue. I'll
> probably
> >>>> learn something.
> >>>> --
> >>>> Jean-Louis Monteiro
> >>>> http://twitter.com/jlouismonteiro
> >>>> http://www.tomitribe.com
> >>>>
> >>>>
> >>>> On Mon, Dec 10, 2018 at 5:27 PM Jonathan Gallimore <
> >>>> jonathan.gallim...@gmail.com> wrote:
> >>>>
> >>>>> Ok, sounds like something has gone wrong somewhere.  Do you want to
> >> look
> >>>>> or
> >>>>> do you want me to?
> >>>>>
> >>>>> On Mon, 10 Dec 2018, 16:21 Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com
> >>>>> wrote:
> >>>>>
> >>>>>> In core yes for sure, but I've seen in the tomee-embedded module as
> >> well
> >>>>>> (need to check this one though)
> >>>>>> --
> >>>>>> Jean-Louis Monteiro
> >>>>>> http://twitter.com/jlouismonteiro
> >>>>>> http://www.tomitribe.com
> >>>>>>
> >>>>>>
> >>>>>> On Mon, Dec 10, 2018 at 5:05 PM Jonathan Gallimore <
> >>>>>> jonathan.gallim...@gmail.com> wrote:
> >>>>>>
> >>>>>>> Was it in openejb-core or the jwt TCK?
> >>>>>>>
> >>>>>>> I'm sure the latter was working.
> >>>>>>>
> >>>>>>> On Mon, 10 Dec 2018, 15:56 Jean-Louis Monteiro <
> >>>>> jlmonte...@tomitribe.com
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> I'll pull from master and rebuild the whole thing here
> >>>>>>>> Gimme 30 minutes
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Jean-Louis Monteiro
> >>>>>>>> http://twitter.com/jlouismonteiro
> >>>>>>>> http://www.tomitribe.com
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Mon, Dec 10, 2018 at 4:55 PM Jonathan Gallimore <
> >>>>>>>> jonathan.gallim...@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>>> It _was_ working ok. Where are you seeing that exception?
> >>>>>>>>>
> >>>>>>>>> On Mon, 10 Dec 2018, 15:52 Jean-Louis Monteiro <
> >>>>>>> jlmonte...@tomitribe.com
> >>>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> This is after I merged the PR from Roberto on JWT yes.
> >>>>>>>>>>
> >>>>>>>>>> Caused by: java.lang.ClassCastException: Cannot cast
> >>>>>>>>> com.sun.proxy.$Proxy55
> >>>>>>>>>> to java.security.Principal
> >>>>>>>>>> at java.lang.Class.cast(Class.java:3369)
> >>>>>>>>>> at
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>
> org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
> >>>>>>>>>> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> >>>>>>>> Method)
> >>>>>>>>>> at
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> >>>>>>>>>> at
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> >>>>>>>>>> at
> >>>>> java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> >>>>>>>>>> at
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>
> org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
> >>>>>>>>>> --
> >>>>>>>>>> Jean-Louis Monteiro
> >>>>>>>>>> http://twitter.com/jlouismonteiro
> >>>>>>>>>> http://www.tomitribe.com
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
> >>>>>>>>>> jonathan.gallim...@gmail.com> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> What's the context? JWT?
> >>>>>>>>>>>
> >>>>>>>>>>> Jon
> >>>>>>>>>>>
> >>>>>>>>>>> On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro <
> >>>>>>>>> jlmonte...@tomitribe.com
> >>>>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Hey Jon,
> >>>>>>>>>>>>
> >>>>>>>>>>>> I think you worked on this issue. What's the status?
> >>>>>>>>>>>> Do you have some inputs?
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Jean-Louis Monteiro
> >>>>>>>>>>>> http://twitter.com/jlouismonteiro
> >>>>>>>>>>>> http://www.tomitribe.com
> >>>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>
> >>
>
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

I'll take the first one first

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 12, 2018 at 5:21 PM Roberto Cortez 
wrote:

> Thank you JL,
>
> At least this test is failing:
> org.apache.openejb.config.rules.CheckMissingClassTest
>
> And this one seems to fail randomly.
> org.apache.openejb.resource.AutoConnectionTrackerTest
>
> Cheers,
> Roberto
>
> > On 12 Dec 2018, at 16:18, Jean-Louis Monteiro 
> wrote:
> >
> > I have merged a couple of PR and I'm running a full build locally. I'll
> > work on fixes any issues if I find some but I'll report first here
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Dec 12, 2018 at 3:33 PM Roberto Cortez
> 
> > wrote:
> >
> >> Hey Jon,
> >>
> >> The following commit:
> >>
> >>
> https://github.com/apache/tomee/commit/4d535f969e9769f0403fddd100b085a0d1de15a9
> >> <
> >>
> https://github.com/apache/tomee/commit/4d535f969e9769f0403fddd100b085a0d1de15a9
> >>>
> >>
> >> Is failing the test:
> >> org.apache.openejb.config.rules.CheckMissingClassTest
> >>
> >> Can you help?
> >>
> >> Cheers,
> >> Roberto
> >>
> >>> On 12 Dec 2018, at 04:41, Frankie  wrote:
> >>>
> >>> Hi Cesar,
> >>>
> >>>> This is a valuable piece of information.
> >>> That's what I thohght, too when I read the information on IRC ...
> >>> Thanks that you want to preserve it on the website.
> >>>
> >>> The JIRA task is now assigned to you.
> >>>
> >>> Frankie
> >>>
> >>>
> >>>
> >>> --
> >>> Sent from:
> >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >>
> >>
>
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

I have merged a couple of PR and I'm running a full build locally. I'll
work on fixes any issues if I find some but I'll report first here
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 12, 2018 at 3:33 PM Roberto Cortez 
wrote:

> Hey Jon,
>
> The following commit:
>
> https://github.com/apache/tomee/commit/4d535f969e9769f0403fddd100b085a0d1de15a9
> <
> https://github.com/apache/tomee/commit/4d535f969e9769f0403fddd100b085a0d1de15a9
> >
>
> Is failing the test:
> org.apache.openejb.config.rules.CheckMissingClassTest
>
> Can you help?
>
> Cheers,
> Roberto
>
> > On 12 Dec 2018, at 04:41, Frankie  wrote:
> >
> > Hi Cesar,
> >
> >> This is a valuable piece of information.
> > That's what I thohght, too when I read the information on IRC ...
> > Thanks that you want to preserve it on the website.
> >
> > The JIRA task is now assigned to you.
> >
> > Frankie
> >
> >
> >
> > --
> > Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>
>

Re: Move to Gitbox?

[Jean-Louis Monteiro]

To be honest. We'll have to do anyways. So being proactive can be only a
good thing.

Le mer. 12 déc. 2018 à 11:25, Jonathan Gallimore <
jonathan.gallim...@gmail.com> a écrit :

> Thanks for all the responses. Going to give it another 24 hours, just in
> case there's an objection, and then I'll get the process started with
> infra.
>
> Cheers
>
> Jon
>
> On Tue, Dec 11, 2018 at 5:21 PM David Blevins 
> wrote:
>
> > Huge +1.  That looks amazing.
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> > > On Dec 11, 2018, at 3:44 AM, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> > >
> > > Hi Folks
> > >
> > > It appears that the git-wip service is going to be retired, and the
> > > repositories are going to be migrated over to Gitbox -
> > > https://gitbox.apache.org/.
> > >
> > > We can voluntarily move to GitBox anytime between now and January 9th
> > 2019.
> > > After January 9th, Infra will require us to move to move within one
> month
> > > by February 7th 2019.
> > >
> > > I propose that we be proactive and look to move now, and we should get
> > the
> > > benefits of better GitHub integration, which given that we are seeing
> > > bigger numbers of PRs coming through GitHub, this seems to make sense
> to
> > me.
> > >
> > > I'm happy to work with infra, and provide guidance to everyone on this
> > > list. We don't necessarily need a vote, but we do need consensus on
> this
> > > list in order to move ahead.
> > >
> > > Are there any objections or other feedback?
> > >
> > > Many thanks
> > >
> > > Jon
> >
> >
>

Re: Move to Gitbox?

[Jean-Louis Monteiro]

yes agreed
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Dec 11, 2018 at 1:13 PM Bruno Baptista  wrote:

> +1 on move to Gitbox
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 11/12/18 11:44, Jonathan Gallimore wrote:
> > Hi Folks
> >
> > It appears that the git-wip service is going to be retired, and the
> > repositories are going to be migrated over to Gitbox -
> > https://gitbox.apache.org/.
> >
> > We can voluntarily move to GitBox anytime between now and January 9th
> 2019.
> > After January 9th, Infra will require us to move to move within one month
> > by February 7th 2019.
> >
> > I propose that we be proactive and look to move now, and we should get
> the
> > benefits of better GitHub integration, which given that we are seeing
> > bigger numbers of PRs coming through GitHub, this seems to make sense to
> me.
> >
> > I'm happy to work with infra, and provide guidance to everyone on this
> > list. We don't necessarily need a vote, but we do need consensus on this
> > list in order to move ahead.
> >
> > Are there any objections or other feedback?
> >
> > Many thanks
> >
> > Jon
> >
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

I think I found the bug on this one. Let's open a PR and then if you could
give me your thoughts
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 5:27 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> If you have some pointers, I'm happy to look at the issue. I'll probably
> learn something.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Dec 10, 2018 at 5:27 PM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
>> Ok, sounds like something has gone wrong somewhere.  Do you want to look
>> or
>> do you want me to?
>>
>> On Mon, 10 Dec 2018, 16:21 Jean-Louis Monteiro > wrote:
>>
>> > In core yes for sure, but I've seen in the tomee-embedded module as well
>> > (need to check this one though)
>> > --
>> > Jean-Louis Monteiro
>> > http://twitter.com/jlouismonteiro
>> > http://www.tomitribe.com
>> >
>> >
>> > On Mon, Dec 10, 2018 at 5:05 PM Jonathan Gallimore <
>> > jonathan.gallim...@gmail.com> wrote:
>> >
>> > > Was it in openejb-core or the jwt TCK?
>> > >
>> > > I'm sure the latter was working.
>> > >
>> > > On Mon, 10 Dec 2018, 15:56 Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com
>> > > wrote:
>> > >
>> > > > I'll pull from master and rebuild the whole thing here
>> > > > Gimme 30 minutes
>> > > >
>> > > > --
>> > > > Jean-Louis Monteiro
>> > > > http://twitter.com/jlouismonteiro
>> > > > http://www.tomitribe.com
>> > > >
>> > > >
>> > > > On Mon, Dec 10, 2018 at 4:55 PM Jonathan Gallimore <
>> > > > jonathan.gallim...@gmail.com> wrote:
>> > > >
>> > > > > It _was_ working ok. Where are you seeing that exception?
>> > > > >
>> > > > > On Mon, 10 Dec 2018, 15:52 Jean-Louis Monteiro <
>> > > jlmonte...@tomitribe.com
>> > > > > wrote:
>> > > > >
>> > > > > > This is after I merged the PR from Roberto on JWT yes.
>> > > > > >
>> > > > > > Caused by: java.lang.ClassCastException: Cannot cast
>> > > > > com.sun.proxy.$Proxy55
>> > > > > > to java.security.Principal
>> > > > > > at java.lang.Class.cast(Class.java:3369)
>> > > > > > at
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
>> > > > > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>> > > > Method)
>> > > > > > at
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>> > > > > > at
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>> > > > > > at
>> java.lang.reflect.Constructor.newInstance(Constructor.java:423)
>> > > > > > at
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
>> > > > > > --
>> > > > > > Jean-Louis Monteiro
>> > > > > > http://twitter.com/jlouismonteiro
>> > > > > > http://www.tomitribe.com
>> > > > > >
>> > > > > >
>> > > > > > On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
>> > > > > > jonathan.gallim...@gmail.com> wrote:
>> > > > > >
>> > > > > > > What's the context? JWT?
>> > > > > > >
>> > > > > > > Jon
>> > > > > > >
>> > > > > > > On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro <
>> > > > > jlmonte...@tomitribe.com
>> > > > > > > wrote:
>> > > > > > >
>> > > > > > > > Hey Jon,
>> > > > > > > >
>> > > > > > > > I think you worked on this issue. What's the status?
>> > > > > > > > Do you have some inputs?
>> > > > > > > > --
>> > > > > > > > Jean-Louis Monteiro
>> > > > > > > > http://twitter.com/jlouismonteiro
>> > > > > > > > http://www.tomitribe.com
>> > > > > > > >
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

Yes you can do that with IRC

Le mar. 11 déc. 2018 à 04:27, César Hernández Mendoza 
a écrit :

> Hi,
> Is there a way to trigger a Buildbot just against current master and not
> related with a specific PR?
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
>
>
> El lun., 10 dic. 2018 a las 8:25, Jonathan Gallimore (<
> jonathan.gallim...@gmail.com>) escribió:
>
> > Pulling and building it now :). Thanks Dani!
> >
> > On Mon, Dec 10, 2018 at 2:23 PM Daniel Cunha 
> wrote:
> >
> > > Nice!
> > >
> > > PR opened: https://github.com/apache/tomee/pull/267
> > >
> > > Em seg, 10 de dez de 2018 às 11:01, Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> escreveu:
> > >
> > > > Awesome, SNAPSHOT is good. Send a PR :)
> > > >
> > > >
> > > > On Mon, Dec 10, 2018 at 1:45 PM Daniel Cunha 
> > > > wrote:
> > > >
> > > > > Hi folks,
> > > > >
> > > > > The fix for testes below is already on bval master branch.
> > > > > Just update bval to 2.0.1-SNAPSHOT and it will be fixed.
> > > > >
> > > > > DuplicateConfigurationTest
> > > > > XMLConfigurationTest
> > > > > XMLConfiguredConstraintValidatorTest
> > > > >
> > > > > Can we use SNAPSHOT for now or wait for the next bval release?
> > > > >
> > > > >
> > > > > Em dom, 9 de dez de 2018 às 20:23, Roberto Cortez
> > > > >  escreveu:
> > > > >
> > > > > > Agree on both.
> > > > > >
> > > > > > > On 9 Dec 2018, at 07:52, Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com
> > > > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > I only fixed the 2 imports for checkstyle
> > > > > > >
> > > > > > > I don't think from an end user perspective the information is
> > very
> > > > > > > important in the changelog so did not created any ticket.
> > > > > > >
> > > > > > > If everyone thinks this is important for the user. I'm happy to
> > > > create
> > > > > > one.
> > > > > > >
> > > > > > > In that area I don't think it makes sense either to create a
> bug
> > in
> > > > > Jira
> > > > > > > for a non released feature. So if there is a new example and
> you
> > > > find a
> > > > > > > bug. Go ahead and fix it. No need to create a new ticket. Use
> the
> > > one
> > > > > > > mentioning we are creating a new example.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Le sam. 8 déc. 2018 à 19:30, Frankie 
> a
> > > > > écrit :
> > > > > > >
> > > > > > >> Overlooked that, sorry.
> > > > > > >> I intended to concentrate on the documentation for
> contribution
> > > > > > workflow,
> > > > > > >> that's why I asked.
> > > > > > >> So no problem if Jean-Louis picks it up.
> > > > > > >> And: what about a JIRA ticket for that ... ? ;-)
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> --
> > > > > > >> Sent from:
> > > > > > >>
> > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > Daniel "soro" Cunha
> > > > > https://twitter.com/dvlc_
> > > > >
> > > >
> > >
> > >
> > > --
> > > Daniel "soro" Cunha
> > > https://twitter.com/dvlc_
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>

Re: MicroProfile 2.0

[Jean-Louis Monteiro]

Should be in.
See thread with classcastexception. Not sure why. I need to discuss with
Jon so I can investigate tomorrow.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 6:54 PM Roberto Cortez 
wrote:

> Now we just need to merge the JWT 1.1 work. There are couple of conflicts
> now, since MP 2.0 work and JWT 1.1 were done on separate branches. These
> should be easy to fix.
>
> > On 7 Dec 2018, at 17:38, Jean-Louis Monteiro 
> wrote:
> >
> > Agreed.
> > Merged. Let's hack ahead now
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Fri, Dec 7, 2018 at 6:37 PM David Blevins 
> > wrote:
> >
> >>> On Dec 7, 2018, at 8:38 AM, Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>>
> >>> I have built and reviewed this PR. We should merge it. The master is
> >> broken
> >>> anyway because we need to update the rest-client api version.
> >>>
> >>> Are we ok to merge it and continue the work on master?
> >>
> >> You know my philosophy:
> >>
> >> - if it's a step forward or sideways and no steps backwards, it's good
> >>
> >> More people will be able to help if it's in master.
> >>
> >>
> >> -David
> >>
> >>
>
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

If you have some pointers, I'm happy to look at the issue. I'll probably
learn something.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 5:27 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Ok, sounds like something has gone wrong somewhere.  Do you want to look or
> do you want me to?
>
> On Mon, 10 Dec 2018, 16:21 Jean-Louis Monteiro  wrote:
>
> > In core yes for sure, but I've seen in the tomee-embedded module as well
> > (need to check this one though)
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Dec 10, 2018 at 5:05 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > Was it in openejb-core or the jwt TCK?
> > >
> > > I'm sure the latter was working.
> > >
> > > On Mon, 10 Dec 2018, 15:56 Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > > wrote:
> > >
> > > > I'll pull from master and rebuild the whole thing here
> > > > Gimme 30 minutes
> > > >
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Mon, Dec 10, 2018 at 4:55 PM Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com> wrote:
> > > >
> > > > > It _was_ working ok. Where are you seeing that exception?
> > > > >
> > > > > On Mon, 10 Dec 2018, 15:52 Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com
> > > > > wrote:
> > > > >
> > > > > > This is after I merged the PR from Roberto on JWT yes.
> > > > > >
> > > > > > Caused by: java.lang.ClassCastException: Cannot cast
> > > > > com.sun.proxy.$Proxy55
> > > > > > to java.security.Principal
> > > > > > at java.lang.Class.cast(Class.java:3369)
> > > > > > at
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
> > > > > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> > > > Method)
> > > > > > at
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> > > > > > at
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> > > > > > at
> java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> > > > > > at
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
> > > > > > --
> > > > > > Jean-Louis Monteiro
> > > > > > http://twitter.com/jlouismonteiro
> > > > > > http://www.tomitribe.com
> > > > > >
> > > > > >
> > > > > > On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
> > > > > > jonathan.gallim...@gmail.com> wrote:
> > > > > >
> > > > > > > What's the context? JWT?
> > > > > > >
> > > > > > > Jon
> > > > > > >
> > > > > > > On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro <
> > > > > jlmonte...@tomitribe.com
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hey Jon,
> > > > > > > >
> > > > > > > > I think you worked on this issue. What's the status?
> > > > > > > > Do you have some inputs?
> > > > > > > > --
> > > > > > > > Jean-Louis Monteiro
> > > > > > > > http://twitter.com/jlouismonteiro
> > > > > > > > http://www.tomitribe.com
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

In core yes for sure, but I've seen in the tomee-embedded module as well
(need to check this one though)
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 5:05 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Was it in openejb-core or the jwt TCK?
>
> I'm sure the latter was working.
>
> On Mon, 10 Dec 2018, 15:56 Jean-Louis Monteiro  wrote:
>
> > I'll pull from master and rebuild the whole thing here
> > Gimme 30 minutes
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Dec 10, 2018 at 4:55 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > It _was_ working ok. Where are you seeing that exception?
> > >
> > > On Mon, 10 Dec 2018, 15:52 Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > > wrote:
> > >
> > > > This is after I merged the PR from Roberto on JWT yes.
> > > >
> > > > Caused by: java.lang.ClassCastException: Cannot cast
> > > com.sun.proxy.$Proxy55
> > > > to java.security.Principal
> > > > at java.lang.Class.cast(Class.java:3369)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
> > > > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> > Method)
> > > > at
> > > >
> > > >
> > >
> >
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> > > > at
> > > >
> > > >
> > >
> >
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> > > > at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> > > > at
> > > >
> > > >
> > >
> >
> org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com> wrote:
> > > >
> > > > > What's the context? JWT?
> > > > >
> > > > > Jon
> > > > >
> > > > > On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com
> > > > > wrote:
> > > > >
> > > > > > Hey Jon,
> > > > > >
> > > > > > I think you worked on this issue. What's the status?
> > > > > > Do you have some inputs?
> > > > > > --
> > > > > > Jean-Louis Monteiro
> > > > > > http://twitter.com/jlouismonteiro
> > > > > > http://www.tomitribe.com
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

I'll pull from master and rebuild the whole thing here
Gimme 30 minutes

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 4:55 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> It _was_ working ok. Where are you seeing that exception?
>
> On Mon, 10 Dec 2018, 15:52 Jean-Louis Monteiro  wrote:
>
> > This is after I merged the PR from Roberto on JWT yes.
> >
> > Caused by: java.lang.ClassCastException: Cannot cast
> com.sun.proxy.$Proxy55
> > to java.security.Principal
> > at java.lang.Class.cast(Class.java:3369)
> > at
> >
> >
> org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
> > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> > at
> >
> >
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> > at
> >
> >
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> > at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> > at
> >
> >
> org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > What's the context? JWT?
> > >
> > > Jon
> > >
> > > On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro <
> jlmonte...@tomitribe.com
> > > wrote:
> > >
> > > > Hey Jon,
> > > >
> > > > I think you worked on this issue. What's the status?
> > > > Do you have some inputs?
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > >
> >
>

Re: ClassCastException: Cannot cast com.sun.proxy.$Proxy55 to java.security.Principal

[Jean-Louis Monteiro]

This is after I merged the PR from Roberto on JWT yes.

Caused by: java.lang.ClassCastException: Cannot cast com.sun.proxy.$Proxy55
to java.security.Principal
at java.lang.Class.cast(Class.java:3369)
at
org.apache.openejb.cdi.ManagedSecurityService.(ManagedSecurityService.java:64)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.webbeans.config.WebBeansContext.createInstance(WebBeansContext.java:440)
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 4:51 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> What's the context? JWT?
>
> Jon
>
> On Mon, 10 Dec 2018, 15:28 Jean-Louis Monteiro  wrote:
>
> > Hey Jon,
> >
> > I think you worked on this issue. What's the status?
> > Do you have some inputs?
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
>

Re: Apache GIT Repo issue

[Jean-Louis Monteiro]

I've been able to push after as you may have seen. Weird. Probably a small
outage

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 3:07 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Its worked ok for me today. Might be pushing another commit shortly, I'll
> post if it fails.
>
> Jon
>
> On Mon, Dec 10, 2018 at 1:44 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Hi dev,
> >
> > Anyone having issues with Apache GIT?
> > I merged https://github.com/apache/tomee/pull/261
> >
> > and wanted to push but got
> >
> > git push
> > ERROR: Permission to apache/tomee.git denied to .
> > fatal: Could not read from remote repository.
> >
> > Please make sure you have the correct access rights
> > and the repository exists.
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

For the moment we can use the snapshot and monotor when bval is released
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 2:45 PM Daniel Cunha  wrote:

> Hi folks,
>
> The fix for testes below is already on bval master branch.
> Just update bval to 2.0.1-SNAPSHOT and it will be fixed.
>
> DuplicateConfigurationTest
> XMLConfigurationTest
> XMLConfiguredConstraintValidatorTest
>
> Can we use SNAPSHOT for now or wait for the next bval release?
>
>
> Em dom, 9 de dez de 2018 às 20:23, Roberto Cortez
>  escreveu:
>
> > Agree on both.
> >
> > > On 9 Dec 2018, at 07:52, Jean-Louis Monteiro  >
> > wrote:
> > >
> > > I only fixed the 2 imports for checkstyle
> > >
> > > I don't think from an end user perspective the information is very
> > > important in the changelog so did not created any ticket.
> > >
> > > If everyone thinks this is important for the user. I'm happy to create
> > one.
> > >
> > > In that area I don't think it makes sense either to create a bug in
> Jira
> > > for a non released feature. So if there is a new example and you find a
> > > bug. Go ahead and fix it. No need to create a new ticket. Use the one
> > > mentioning we are creating a new example.
> > >
> > >
> > >
> > > Le sam. 8 déc. 2018 à 19:30, Frankie  a
> écrit :
> > >
> > >> Overlooked that, sorry.
> > >> I intended to concentrate on the documentation for contribution
> > workflow,
> > >> that's why I asked.
> > >> So no problem if Jean-Louis picks it up.
> > >> And: what about a JIRA ticket for that ... ? ;-)
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> Sent from:
> > >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > >>
> >
> >
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>

Apache GIT Repo issue

[Jean-Louis Monteiro]

Hi dev,

Anyone having issues with Apache GIT?
I merged https://github.com/apache/tomee/pull/261

and wanted to push but got

git push
ERROR: Permission to apache/tomee.git denied to .
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: Update to PR 263

[Jean-Louis Monteiro]

Hi,

I'm going to review and merge if ok
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 10, 2018 at 11:45 AM Michael Redlich  wrote:

> Hi Richard:
>
> Thanks for all your support and from everyone else on the team!
>
> Mike.
>
> On Mon, Dec 10, 2018 at 3:15 AM Richard Monson-Haefel <
> monsonhae...@gmail.com> wrote:
>
> > Awesome!  Thank you, Mike!
> >
> > On Sun, Dec 9, 2018 at 5:58 PM Michael Redlich 
> wrote:
> >
> >> Hello everyone:
> >>
> >> I just updated my pull request to add *mp-metrics-histogram* as a module
> >> in
> >> *examples/pom.xml* as suggested by Jose Henrique Ventura.
> >>
> >> https://github.com/apache/tomee/pull/263
> >>
> >> Best regards,
> >>
> >> Mike.
> >>
> >>
> >> --
> >> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
> >> *Sleep ... Repeat*
> >>
> >> *InfoQ <https://www.infoq.com/> Java Queue Editor*
> >> https://about.me/mpredli <http://about.me/mpredli/>
> >> https://twitter.com/mpredli
> >> https://redlich.net/
> >> https://javasig.org/
> >> *Laissez Les Bon Temps Rouler*
> >>
> >
> >
> > --
> > Richard Monson-Haefel
> > https://twitter.com/rmonson
> > https://www.linkedin.com/in/monsonhaefel/
> >
>
>
> --
> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
> *Sleep ... Repeat*
>
> *InfoQ <https://www.infoq.com/> Java Queue Editor*
> https://about.me/mpredli <http://about.me/mpredli/>
> https://twitter.com/mpredli
> https://redlich.net/
> https://javasig.org/
> *Laissez Les Bon Temps Rouler*
>

Re: TOMEE-2336

[Jean-Louis Monteiro]

You just need to ask, but as Jon already assigned the ticket to you, you
are already in the contributors group :)
Thanks for the help
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Sun, Dec 9, 2018 at 11:22 AM Michael Redlich  wrote:

> Hi Jean-Louis:
>
> Thanks for the information about that.  How may I be added to the
> contributors group?
>
> Mike.
>
>
> On Sun, Dec 9, 2018 at 2:49 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
>> For information. You need to first be added to the contributors group and
>> then the ticket can be assigned to you.
>>
>> This can only be done by a committer .
>>
>> Le sam. 8 déc. 2018 à 14:15, Michael Redlich  a
>> écrit :
>>
>>> Hello everyone:
>>>
>>> I am trying to assign TOMEE-2336 to myself, but there doesn't seem to be
>>> a
>>> link in the JIRA to do so.  I would appreciate some advice on this.
>>>
>>> Also, please advise if there is a way to change the assignee to myself on
>>> TOMEE-2287, the histogram example.
>>>
>>> Thanks!
>>>
>>> Mike.
>>>
>>> --
>>> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
>>> *Sleep ... Repeat*
>>>
>>> *InfoQ <https://www.infoq.com/> Java Queue Editor*
>>> https://about.me/mpredli <http://about.me/mpredli/>
>>> https://twitter.com/mpredli
>>> https://redlich.net/
>>> https://javasig.org/
>>> *Laissez Les Bon Temps Rouler*
>>>
>>
>
> --
> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
> *Sleep ... Repeat*
>
> *InfoQ <https://www.infoq.com/> Java Queue Editor*
> https://about.me/mpredli <http://about.me/mpredli/>
> https://twitter.com/mpredli
> https://redlich.net/
> https://javasig.org/
> *Laissez Les Bon Temps Rouler*
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

I only fixed the 2 imports for checkstyle

I don't think from an end user perspective the information is very
important in the changelog so did not created any ticket.

If everyone thinks this is important for the user. I'm happy to create one.

In that area I don't think it makes sense either to create a bug in Jira
for a non released feature. So if there is a new example and you find a
bug. Go ahead and fix it. No need to create a new ticket. Use the one
mentioning we are creating a new example.



Le sam. 8 déc. 2018 à 19:30, Frankie  a écrit :

> Overlooked that, sorry.
> I intended to concentrate on the documentation for contribution workflow,
> that's why I asked.
> So no problem if Jean-Louis picks it up.
> And: what about a JIRA ticket for that ... ? ;-)
>
>
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: TOMEE-2336

[Jean-Louis Monteiro]

For information. You need to first be added to the contributors group and
then the ticket can be assigned to you.

This can only be done by a committer .

Le sam. 8 déc. 2018 à 14:15, Michael Redlich  a écrit :

> Hello everyone:
>
> I am trying to assign TOMEE-2336 to myself, but there doesn't seem to be a
> link in the JIRA to do so.  I would appreciate some advice on this.
>
> Also, please advise if there is a way to change the assignee to myself on
> TOMEE-2287, the histogram example.
>
> Thanks!
>
> Mike.
>
> --
> *Code*, *Write*, *Cycle*, *Run*, *Drink*,
> *Sleep ... Repeat*
>
> *InfoQ  Java Queue Editor*
> https://about.me/mpredli 
> https://twitter.com/mpredli
> https://redlich.net/
> https://javasig.org/
> *Laissez Les Bon Temps Rouler*
>

Re: MicroProfile 2.0

[Jean-Louis Monteiro]

Agreed.
Merged. Let's hack ahead now
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 6:37 PM David Blevins 
wrote:

> > On Dec 7, 2018, at 8:38 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > I have built and reviewed this PR. We should merge it. The master is
> broken
> > anyway because we need to update the rest-client api version.
> >
> > Are we ok to merge it and continue the work on master?
>
> You know my philosophy:
>
>  - if it's a step forward or sideways and no steps backwards, it's good
>
> More people will be able to help if it's in master.
>
>
> -David
>
>

Re: MicroProfile 2.0

[Jean-Louis Monteiro]

I have built and reviewed this PR. We should merge it. The master is broken
anyway because we need to update the rest-client api version.

Are we ok to merge it and continue the work on master?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 5:25 PM Jean-Louis Monteiro 
wrote:

> Ok, then I'll checkout your PR and build it locally
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Dec 7, 2018 at 5:07 PM Roberto Cortez 
> wrote:
>
>> We already released a TomEE 8 M1 with MP 1.3 support.
>>
>> And in reality, MP 2.x is the one we should be targeting with TomEE 8,
>> since we have CDI 2.0.
>>
>> > On 7 Dec 2018, at 15:49, Otávio Gonçalves de Santana <
>> osant...@tomitribe.com> wrote:
>> >
>> > JL, I like baby steps.
>> > Maybe, keep MP 1.3, release a TomEE 8 RC-2, then upgrade the version to
>> MP
>> > 2.0.
>> >
>> > On Fri, Dec 7, 2018 at 1:40 PM Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com>
>> > wrote:
>> >
>> >> Let's revive this discussion ...
>> >>
>> >> We are working on build stability (see other thread).
>> >> I was digging into an issue where there is a mismatch between the API
>> we
>> >> pick in TomEE 8.x (master) which is for the moment MP 1.3 compliant.
>> >>
>> >> Unfortunately we have upgraded CXF which is now rest-client 1.1 as
>> opposed
>> >> to 1.0 before. As a result, the TCK fails because of a
>> >> NoSuchMethodException.
>> >>
>> >> So what do we target in terms of TomEE 8.x (master)?
>> >> Do we stay MP 1.3 or MP 2.0 or else?
>> >>
>> >> Thoughts?
>> >>
>> >>
>> >> --
>> >> Jean-Louis Monteiro
>> >> http://twitter.com/jlouismonteiro
>> >> http://www.tomitribe.com
>> >>
>> >>
>> >> On Tue, Dec 4, 2018 at 11:24 PM Roberto Cortez
>> > >>>
>> >> wrote:
>> >>
>> >>> Good question.
>> >>>
>> >>> I think the community could help with the following topics:
>> >>>
>> >>> - Test the new MP dependencies in your projects. You can build the
>> >>> project with PR (until is not merged) and try it out.
>> >>>
>> >>> - Contribute with additional tests outside the scope of the TCK. Might
>> >> be
>> >>> tricky, since you need to read both the TCK and Spec to figure out
>> what
>> >> is
>> >>> missing. For instance, JWT spec mentions that "MicroProfile JWT
>> >>> implementations are required to throw a `DeploymentException` if both
>> >>> `mp.jwt.verify.publickey` and `mp.jwt.verify.publickey.location` are
>> >>> supplied.” I believe the TCK doesn’t test this scenario. You need to
>> go
>> >> out
>> >>> there to find them.
>> >>>
>> >>> - Contribute with samples showing a particular feature of MP. We don’t
>> >>> have samples around OpenAPI or OpenTracing, so these are good
>> candidates.
>> >>>
>> >>> - Help on Fault Tolerance implementation for 1.1. This should be our
>> >> main
>> >>> concern. Until this is done, we cannot rely say we are MP 2.0
>> compliant
>> >> (or
>> >>> 2.x for that matter).
>> >>>
>> >>> Cheers,
>> >>> Roberto
>> >>>
>> >>>> On 4 Dec 2018, at 21:52, David Blevins 
>> >> wrote:
>> >>>>
>> >>>> How can people help?
>> >>>>
>> >>>>
>> >>>> --
>> >>>> David Blevins
>> >>>> http://twitter.com/dblevins
>> >>>> http://www.tomitribe.com
>> >>>>
>> >>>>> On Dec 4, 2018, at 11:30 AM, Roberto Cortez
>> >> 
>> >>> wrote:
>> >>>>>
>> >>>>> Hi folks,
>> >>>>>
>> >>>>> I’ve done some work on update our implementations for MP 2.0:
>> >>>>> https://github.com/apache/tomee/pull/212 <
>> >>> https://github.com/apache/tomee/pull/212>
>> >>>>>
>> >>>>> With our latest implementation of JWT 1.1, we are almost there. To
>> be
>> >>> compliant, we are only missing Fault Tolerance 1.1. There are some
>> >>> discussions about that on the Geronimo list. You may want to have a
>> look
>> >>> into it as well.
>> >>>>>
>> >>>>> Cheers,
>> >>>>> Roberto
>> >>>>
>> >>>
>> >>>
>> >>
>>
>>

Re: MicroProfile 2.0

[Jean-Louis Monteiro]

Ok, then I'll checkout your PR and build it locally

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 5:07 PM Roberto Cortez 
wrote:

> We already released a TomEE 8 M1 with MP 1.3 support.
>
> And in reality, MP 2.x is the one we should be targeting with TomEE 8,
> since we have CDI 2.0.
>
> > On 7 Dec 2018, at 15:49, Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
> >
> > JL, I like baby steps.
> > Maybe, keep MP 1.3, release a TomEE 8 RC-2, then upgrade the version to
> MP
> > 2.0.
> >
> > On Fri, Dec 7, 2018 at 1:40 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> > wrote:
> >
> >> Let's revive this discussion ...
> >>
> >> We are working on build stability (see other thread).
> >> I was digging into an issue where there is a mismatch between the API we
> >> pick in TomEE 8.x (master) which is for the moment MP 1.3 compliant.
> >>
> >> Unfortunately we have upgraded CXF which is now rest-client 1.1 as
> opposed
> >> to 1.0 before. As a result, the TCK fails because of a
> >> NoSuchMethodException.
> >>
> >> So what do we target in terms of TomEE 8.x (master)?
> >> Do we stay MP 1.3 or MP 2.0 or else?
> >>
> >> Thoughts?
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Tue, Dec 4, 2018 at 11:24 PM Roberto Cortez
>  >>>
> >> wrote:
> >>
> >>> Good question.
> >>>
> >>> I think the community could help with the following topics:
> >>>
> >>> - Test the new MP dependencies in your projects. You can build the
> >>> project with PR (until is not merged) and try it out.
> >>>
> >>> - Contribute with additional tests outside the scope of the TCK. Might
> >> be
> >>> tricky, since you need to read both the TCK and Spec to figure out what
> >> is
> >>> missing. For instance, JWT spec mentions that "MicroProfile JWT
> >>> implementations are required to throw a `DeploymentException` if both
> >>> `mp.jwt.verify.publickey` and `mp.jwt.verify.publickey.location` are
> >>> supplied.” I believe the TCK doesn’t test this scenario. You need to go
> >> out
> >>> there to find them.
> >>>
> >>> - Contribute with samples showing a particular feature of MP. We don’t
> >>> have samples around OpenAPI or OpenTracing, so these are good
> candidates.
> >>>
> >>> - Help on Fault Tolerance implementation for 1.1. This should be our
> >> main
> >>> concern. Until this is done, we cannot rely say we are MP 2.0 compliant
> >> (or
> >>> 2.x for that matter).
> >>>
> >>> Cheers,
> >>> Roberto
> >>>
> >>>> On 4 Dec 2018, at 21:52, David Blevins 
> >> wrote:
> >>>>
> >>>> How can people help?
> >>>>
> >>>>
> >>>> --
> >>>> David Blevins
> >>>> http://twitter.com/dblevins
> >>>> http://www.tomitribe.com
> >>>>
> >>>>> On Dec 4, 2018, at 11:30 AM, Roberto Cortez
> >> 
> >>> wrote:
> >>>>>
> >>>>> Hi folks,
> >>>>>
> >>>>> I’ve done some work on update our implementations for MP 2.0:
> >>>>> https://github.com/apache/tomee/pull/212 <
> >>> https://github.com/apache/tomee/pull/212>
> >>>>>
> >>>>> With our latest implementation of JWT 1.1, we are almost there. To be
> >>> compliant, we are only missing Fault Tolerance 1.1. There are some
> >>> discussions about that on the Geronimo list. You may want to have a
> look
> >>> into it as well.
> >>>>>
> >>>>> Cheers,
> >>>>> Roberto
> >>>>
> >>>
> >>>
> >>
>
>

Re: CI with Jenkins

[Jean-Louis Monteiro]

There is a Jenkins at Apache. Some projects like OWB uses it.
Not sure the boxes are big enough though
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 3:21 PM Richard Monson-Haefel 
wrote:

> Cesar,
>
> Whatever happened to this discussion about implementing a CI using
> Jenkins?  Seems like people felt it would be a good idea.  You've been on
> vacation.  Can you spearhead this?
>
> Past discussion
>
> http://tomee-openejb.979440.n4.nabble.com/Continuous-integration-and-a-PR-td4685376.html
>
> --
> Richard Monson-Haefel
> https://twitter.com/rmonson
> https://www.linkedin.com/in/monsonhaefel/
>

Re: MicroProfile 2.0

[Jean-Louis Monteiro]

Let's revive this discussion ...

We are working on build stability (see other thread).
I was digging into an issue where there is a mismatch between the API we
pick in TomEE 8.x (master) which is for the moment MP 1.3 compliant.

Unfortunately we have upgraded CXF which is now rest-client 1.1 as opposed
to 1.0 before. As a result, the TCK fails because of a
NoSuchMethodException.

So what do we target in terms of TomEE 8.x (master)?
Do we stay MP 1.3 or MP 2.0 or else?

Thoughts?


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Dec 4, 2018 at 11:24 PM Roberto Cortez 
wrote:

> Good question.
>
> I think the community could help with the following topics:
>
>  - Test the new MP dependencies in your projects. You can build the
> project with PR (until is not merged) and try it out.
>
>  - Contribute with additional tests outside the scope of the TCK. Might be
> tricky, since you need to read both the TCK and Spec to figure out what is
> missing. For instance, JWT spec mentions that "MicroProfile JWT
> implementations are required to throw a `DeploymentException` if both
> `mp.jwt.verify.publickey` and `mp.jwt.verify.publickey.location` are
> supplied.” I believe the TCK doesn’t test this scenario. You need to go out
> there to find them.
>
>  - Contribute with samples showing a particular feature of MP. We don’t
> have samples around OpenAPI or OpenTracing, so these are good candidates.
>
>  - Help on Fault Tolerance implementation for 1.1. This should be our main
> concern. Until this is done, we cannot rely say we are MP 2.0 compliant (or
> 2.x for that matter).
>
> Cheers,
> Roberto
>
> > On 4 Dec 2018, at 21:52, David Blevins  wrote:
> >
> > How can people help?
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >> On Dec 4, 2018, at 11:30 AM, Roberto Cortez 
> wrote:
> >>
> >> Hi folks,
> >>
> >> I’ve done some work on update our implementations for MP 2.0:
> >> https://github.com/apache/tomee/pull/212 <
> https://github.com/apache/tomee/pull/212>
> >>
> >> With our latest implementation of JWT 1.1, we are almost there. To be
> compliant, we are only missing Fault Tolerance 1.1. There are some
> discussions about that on the Geronimo list. You may want to have a look
> into it as well.
> >>
> >> Cheers,
> >> Roberto
> >
>
>

Re: Approving Pull Requests

[Jean-Louis Monteiro]

+1
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 4:21 PM Otávio Gonçalves de Santana <
osant...@tomitribe.com> wrote:

> That is a nice point.
>
> I usually do this, I just keep one PR active and just open a second one
> when the first is merged. I think that became easier to review and merge
> process.
>
> On Thu, Dec 6, 2018 at 10:24 AM Richard Monson-Haefel <
> monsonhae...@gmail.com> wrote:
>
> > I went through and gave my approval to several of cchacin's pull requests
> > (252 - 255). I stopped after five because I wanted to be sure I was doing
> > this right.  I'll wait for feedback on my actions before doing more.
> >
> > Thanks,
> >
> > Richard
> >
> > --
> > Richard Monson-Haefel
> > https://twitter.com/rmonson
> > https://www.linkedin.com/in/monsonhaefel/
> >
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

Looks like a CXF upgrade changed the API CXF is implementing. If we upgrade
the API on our MicroProfile module then we won't be 1.3 compliant.

But other solution is to downgrade CXF to match MP 1.3 which has
rest-client 1.0

I'd rather get TomEE 8 to be upgraded in regards to MP so we support MP
higher than 1.3

Thoughts


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 4:29 PM Roberto Cortez 
wrote:

> Hi folks,
>
> Thank you for working on this.
>
> Were we able to determine the cause of all these issues? When we did the
> M1 release and even after that we had green builds, so it seems we did
> something that broke a lot of tests?
>
> Cheers,
> Roberto
>
> > On 7 Dec 2018, at 15:05, Jean-Louis Monteiro 
> wrote:
> >
> > The rest-client seems to be a version issue
> >
> > [ERROR]
> >
> testInvokesPostOperation(org.eclipse.microprofile.rest.client.tck.cditests.CDIInvokeWithRegisteredProvidersTest)
> > Time elapsed: 0.521 s  <<< FAILURE!
> > java.lang.NoSuchMethodError:
> >
> org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;
> >
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Fri, Dec 7, 2018 at 3:56 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> > wrote:
> >
> >> The Duplicate one is also BVal Jon.
> >> I'l looking at the rest-client part.
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>
> >>> JmsInjectionTests works locally
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>> On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
> >>> jlmonte...@tomitribe.com> wrote:
> >>>
> >>>> I have been digging and running tests locally.
> >>>> Here is the list of tests failures I have extracted.
> >>>>
> >>>> - JMSInjectionTest
> >>>> - CDIInvokeSimpleGetOperationTest
> >>>> - CDIInvokeWithRegisteredProviderTest
> >>>> - FeatureRegistrationTest
> >>>> - InvokeWithJsonProviderTest
> >>>> - DuplicateConfigurationTest
> >>>> - XMLConfigurationTest
> >>>> - XMLConfiguredConstraintValidatorTest
> >>>> - MoviesArquillianHtmlUnitTest
> >>>> - DeployInWebAppsDirectoryTest
> >>>> - LegacyServerTest
> >>>> - LegacyClientTest
> >>>> - (StickyConnection|RoundRobin|Random)StrategyTest
> >>>> - ReconnectDelayCaseInsensitiveTest
> >>>> - ReconnectDelayListSelfTest
> >>>> - ReconnectTest
> >>>>
> >>>> Anything else I missed?
> >>>>
> >>>> --
> >>>> Jean-Louis Monteiro
> >>>> http://twitter.com/jlouismonteiro
> >>>> http://www.tomitribe.com
> >>>>
> >>>>
> >>>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
> >>>> jonathan.gallim...@gmail.com> wrote:
> >>>>
> >>>>> I've merged a few PRs in which appear to have kept the build in the
> same
> >>>>> state. I also fixed up the itest failures. I'll work on bval
> tomorrow. I
> >>>>> get failures with the MicroProfile REST client locally, so if someone
> >>>>> can
> >>>>> take a look at that, that would be great.
> >>>>>
> >>>>> Thanks
> >>>>>
> >>>>> Jon
> >>>>>
> >>>>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
> >>>>> 
> >>>>> wrote:
> >>>>>
> >>>>>> Hi folks,
> >>>>>>
> >>>>>> It is great to see so many contributions and we hope to continue and
> >>>>> even
> >>>>>> increase the traffic.
> >>>>>>
> >>>>>> Now, this also comes with a few challenges. Our build has been red
> >>>>> for a
> >>>>>> while and I would like to get it 

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

The rest-client seems to be a version issue

[ERROR]
testInvokesPostOperation(org.eclipse.microprofile.rest.client.tck.cditests.CDIInvokeWithRegisteredProvidersTest)
Time elapsed: 0.521 s  <<< FAILURE!
java.lang.NoSuchMethodError:
org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 3:56 PM Jean-Louis Monteiro 
wrote:

> The Duplicate one is also BVal Jon.
> I'l looking at the rest-client part.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
>> JmsInjectionTests works locally
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>>
>>> I have been digging and running tests locally.
>>> Here is the list of tests failures I have extracted.
>>>
>>> - JMSInjectionTest
>>> - CDIInvokeSimpleGetOperationTest
>>> - CDIInvokeWithRegisteredProviderTest
>>> - FeatureRegistrationTest
>>> - InvokeWithJsonProviderTest
>>> - DuplicateConfigurationTest
>>> - XMLConfigurationTest
>>> - XMLConfiguredConstraintValidatorTest
>>> - MoviesArquillianHtmlUnitTest
>>> - DeployInWebAppsDirectoryTest
>>> - LegacyServerTest
>>> - LegacyClientTest
>>> - (StickyConnection|RoundRobin|Random)StrategyTest
>>> - ReconnectDelayCaseInsensitiveTest
>>> - ReconnectDelayListSelfTest
>>> - ReconnectTest
>>>
>>> Anything else I missed?
>>>
>>> --
>>> Jean-Louis Monteiro
>>> http://twitter.com/jlouismonteiro
>>> http://www.tomitribe.com
>>>
>>>
>>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
>>> jonathan.gallim...@gmail.com> wrote:
>>>
>>>> I've merged a few PRs in which appear to have kept the build in the same
>>>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>>>> get failures with the MicroProfile REST client locally, so if someone
>>>> can
>>>> take a look at that, that would be great.
>>>>
>>>> Thanks
>>>>
>>>> Jon
>>>>
>>>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>>>> 
>>>> wrote:
>>>>
>>>> > Hi folks,
>>>> >
>>>> > It is great to see so many contributions and we hope to continue and
>>>> even
>>>> > increase the traffic.
>>>> >
>>>> > Now, this also comes with a few challenges. Our build has been red
>>>> for a
>>>> > while and I would like to get it green again:
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>>>> >
>>>> > The latest build has some checkstyle violations and test failures:
>>>> >
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>>> > <
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>>> > >
>>>> >
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>>> > <
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>>> > >
>>>> >
>>>> > It would be great if someone could pick these issues and fix them and
>>>> we
>>>> > should prioritize any build fixing PR above everything else.
>>>> >
>>>> > Also, when someone sends a PR, your work doesn’t end when it gets
>>>> merged.
>>>> > Running a full build takes almost 5 hours, so the committer most of
>>>> the
>>>> > times is not able to run the entire build to check your PR. I kindly
>>>> ask
>>>> > you to monitor the tomee build bot here:
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>>>> > gets merged and if you uncover something wrong, please send a
>>>> corrective PR.
>>>> >
>>>> > I’ll be out the next couple of days, so I hope someone can pick this
>>>> up :)
>>>> >
>>>> > Cheers,
>>>> > Roberto
>>>>
>>>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

The Duplicate one is also BVal Jon.
I'l looking at the rest-client part.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro 
wrote:

> JmsInjectionTests works locally
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
>> I have been digging and running tests locally.
>> Here is the list of tests failures I have extracted.
>>
>> - JMSInjectionTest
>> - CDIInvokeSimpleGetOperationTest
>> - CDIInvokeWithRegisteredProviderTest
>> - FeatureRegistrationTest
>> - InvokeWithJsonProviderTest
>> - DuplicateConfigurationTest
>> - XMLConfigurationTest
>> - XMLConfiguredConstraintValidatorTest
>> - MoviesArquillianHtmlUnitTest
>> - DeployInWebAppsDirectoryTest
>> - LegacyServerTest
>> - LegacyClientTest
>> - (StickyConnection|RoundRobin|Random)StrategyTest
>> - ReconnectDelayCaseInsensitiveTest
>> - ReconnectDelayListSelfTest
>> - ReconnectTest
>>
>> Anything else I missed?
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>>
>>> I've merged a few PRs in which appear to have kept the build in the same
>>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>>> get failures with the MicroProfile REST client locally, so if someone can
>>> take a look at that, that would be great.
>>>
>>> Thanks
>>>
>>> Jon
>>>
>>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>>> 
>>> wrote:
>>>
>>> > Hi folks,
>>> >
>>> > It is great to see so many contributions and we hope to continue and
>>> even
>>> > increase the traffic.
>>> >
>>> > Now, this also comes with a few challenges. Our build has been red for
>>> a
>>> > while and I would like to get it green again:
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>>> >
>>> > The latest build has some checkstyle violations and test failures:
>>> >
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>> > <
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>> > >
>>> >
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>> > <
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>> > >
>>> >
>>> > It would be great if someone could pick these issues and fix them and
>>> we
>>> > should prioritize any build fixing PR above everything else.
>>> >
>>> > Also, when someone sends a PR, your work doesn’t end when it gets
>>> merged.
>>> > Running a full build takes almost 5 hours, so the committer most of the
>>> > times is not able to run the entire build to check your PR. I kindly
>>> ask
>>> > you to monitor the tomee build bot here:
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>>> > gets merged and if you uncover something wrong, please send a
>>> corrective PR.
>>> >
>>> > I’ll be out the next couple of days, so I hope someone can pick this
>>> up :)
>>> >
>>> > Cheers,
>>> > Roberto
>>>
>>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

JmsInjectionTests works locally
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> I have been digging and running tests locally.
> Here is the list of tests failures I have extracted.
>
> - JMSInjectionTest
> - CDIInvokeSimpleGetOperationTest
> - CDIInvokeWithRegisteredProviderTest
> - FeatureRegistrationTest
> - InvokeWithJsonProviderTest
> - DuplicateConfigurationTest
> - XMLConfigurationTest
> - XMLConfiguredConstraintValidatorTest
> - MoviesArquillianHtmlUnitTest
> - DeployInWebAppsDirectoryTest
> - LegacyServerTest
> - LegacyClientTest
> - (StickyConnection|RoundRobin|Random)StrategyTest
> - ReconnectDelayCaseInsensitiveTest
> - ReconnectDelayListSelfTest
> - ReconnectTest
>
> Anything else I missed?
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
>> I've merged a few PRs in which appear to have kept the build in the same
>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>> get failures with the MicroProfile REST client locally, so if someone can
>> take a look at that, that would be great.
>>
>> Thanks
>>
>> Jon
>>
>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>> 
>> wrote:
>>
>> > Hi folks,
>> >
>> > It is great to see so many contributions and we hope to continue and
>> even
>> > increase the traffic.
>> >
>> > Now, this also comes with a few challenges. Our build has been red for a
>> > while and I would like to get it green again:
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>> >
>> > The latest build has some checkstyle violations and test failures:
>> >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > <
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > >
>> >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > <
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > >
>> >
>> > It would be great if someone could pick these issues and fix them and we
>> > should prioritize any build fixing PR above everything else.
>> >
>> > Also, when someone sends a PR, your work doesn’t end when it gets
>> merged.
>> > Running a full build takes almost 5 hours, so the committer most of the
>> > times is not able to run the entire build to check your PR. I kindly ask
>> > you to monitor the tomee build bot here:
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>> > gets merged and if you uncover something wrong, please send a
>> corrective PR.
>> >
>> > I’ll be out the next couple of days, so I hope someone can pick this up
>> :)
>> >
>> > Cheers,
>> > Roberto
>>
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

I have been digging and running tests locally.
Here is the list of tests failures I have extracted.

- JMSInjectionTest
- CDIInvokeSimpleGetOperationTest
- CDIInvokeWithRegisteredProviderTest
- FeatureRegistrationTest
- InvokeWithJsonProviderTest
- DuplicateConfigurationTest
- XMLConfigurationTest
- XMLConfiguredConstraintValidatorTest
- MoviesArquillianHtmlUnitTest
- DeployInWebAppsDirectoryTest
- LegacyServerTest
- LegacyClientTest
- (StickyConnection|RoundRobin|Random)StrategyTest
- ReconnectDelayCaseInsensitiveTest
- ReconnectDelayListSelfTest
- ReconnectTest

Anything else I missed?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> I've merged a few PRs in which appear to have kept the build in the same
> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
> get failures with the MicroProfile REST client locally, so if someone can
> take a look at that, that would be great.
>
> Thanks
>
> Jon
>
> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez  >
> wrote:
>
> > Hi folks,
> >
> > It is great to see so many contributions and we hope to continue and even
> > increase the traffic.
> >
> > Now, this also comes with a few challenges. Our build has been red for a
> > while and I would like to get it green again:
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
> >
> > The latest build has some checkstyle violations and test failures:
> >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > <
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > >
> >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > <
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > >
> >
> > It would be great if someone could pick these issues and fix them and we
> > should prioritize any build fixing PR above everything else.
> >
> > Also, when someone sends a PR, your work doesn’t end when it gets merged.
> > Running a full build takes almost 5 hours, so the committer most of the
> > times is not able to run the entire build to check your PR. I kindly ask
> > you to monitor the tomee build bot here:
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
> > gets merged and if you uncover something wrong, please send a corrective
> PR.
> >
> > I’ll be out the next couple of days, so I hope someone can pick this up
> :)
> >
> > Cheers,
> > Roberto
>

Re: TomEE 8 Release Preview

[Jean-Louis Monteiro]

Yes we are trying to work on Java EE 8, Java 11 support, the website
update, and MicroProfile compliancy.
If you are willing to help, we can definitely guide you.

JLouis


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 5, 2018 at 2:59 PM j4fm  wrote:

> I know there is an incredible amount of work going on.  Is there any chance
> that MP can be added to Plus anytime soon?  I think there was an offer of
> some help above too.
>
> Thanks!
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: Fix pom.xml in examples.

[Jean-Louis Monteiro]

Thanks Bruno for reviewing and for the ticket to fix the issue.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 6, 2018 at 3:04 PM Bruno Baptista  wrote:

> Hi Folks,
>
> Yet in relation with the examples...
>
> I've noticed that project folder names and artifact ids not always match.
>
> Some of the sub-projects are absent from the parent modules... They are
> not being built.
>
> Some of them declare a Parent in the pom.xml with no need and should be
> removed.
>
> I'll create a Jira to fix these issues and try to split the work in at
> least 2 PRs in order no minimize the impact in the ongoing work.
>
> Cheers
>
> --
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
>

Re: Example maven parent

[Jean-Louis Monteiro]

There are some typos in there. See review
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 6, 2018 at 3:43 PM Jean-Louis Monteiro 
wrote:

> Thanks Bruno. I'll review it very quick
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Dec 6, 2018 at 2:44 PM Bruno Baptista  wrote:
>
>> Hi folks,
>>
>> I've created a jira and a PR to define the rules/guidelines in the
>> creation of new examples.
>>
>> Jira: https://issues.apache.org/jira/browse/TOMEE-2326
>>
>> PR: https://github.com/apache/tomee/pull/257
>>
>> Please feel free to comment and ask for changes.
>>
>> Cheers.
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 05/12/18 22:23, Bruno Baptista wrote:
>> > Thanks for the context David.
>> >
>> > I'll write a PR with README at the Examples project level with some
>> > guidelines that we can discuss. There were some other resources to
>> > help make new examples. Will research that too.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>> >
>> >
>> > On 05/12/18 21:21, David Blevins wrote:
>> >>> On Dec 5, 2018, at 10:28 AM, Bruno Baptista 
>> wrote:
>> >>>
>> >>> I'd say we have a problem here. What do you guys think we should do?
>> >>>
>> >>> • Remove Parent definition on examples and fix the ones that
>> >>> will break.
>> >>> • Use Parent always and fix the dependencies scope.
>> >>> • A mix of both. Use parent when needed and fix the dependencies
>> >>> scope.
>> >> Historically we've not used parents because the goal of each example
>> >> is to be completely independent in every way from the other examples
>> >> and the TomEE build overall.  The intention is people can grab an
>> >> example and build on it in their own projects without having to
>> >> perform surgery to "cut it free" from the parent pom.
>> >>
>> >> This conversation typically comes up because people are trying to
>> >> remove duplication between the examples, which is good habit normally
>> >> and therefore most people's initial gut reaction.
>> >>
>> >> When you're on the learning side, however, it significantly increases
>> >> the complexity of the example because:
>> >>
>> >>   - basic "project" structure is moved to the example parent, which
>> >> then has complexity of removing duplication between 139 examples
>> >>   - some of that complexity will then move to the top-level tomee
>> >> parent pom to reduce duplication further
>> >>   - inevitably someone will say "maybe MicroProfile examples should
>> >> have their own parent pom"
>> >>
>> >> The result is then if a user would want to make their own tiny
>> >> project based on a MicroProfile example they would need to spend a
>> >> few hours learning how to untangle this theoretical pom inheritance
>> >> chain:
>> >>
>> >>   - tomee/examples/microprofile/metrics-counted/pom.xml
>> >>   - tomee/examples/microprofile/pom.xml
>> >>   - tomee/examples/pom.xml
>> >>   - tomee/pom.xml
>> >>
>> >> As coders we'll be thrilled by how much duplication we removed. As
>> >> someone learning, you basically have to be an expert in maven and our
>> >> build structure and be extremely willing to invest time in trial and
>> >> error to recreate your own truly independent example you can then
>> >> build from.
>> >>
>> >> For certain things like Arquillian, the pom is the hardest part, so
>> >> if it isn't completely self contained and independent, it is pretty
>> >> much an unusable example.
>> >>
>> >> At least that's how the conversation has historically gone.  We can
>> >> certainly have it again and maybe create some documentation to help
>> >> example authors understand the goals/motivations.
>> >>
>> >>
>> >> -David
>> >>
>> >>
>> >>
>> >>
>>
>

Re: Example maven parent

[Jean-Louis Monteiro]

Thanks Bruno. I'll review it very quick

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 6, 2018 at 2:44 PM Bruno Baptista  wrote:

> Hi folks,
>
> I've created a jira and a PR to define the rules/guidelines in the
> creation of new examples.
>
> Jira: https://issues.apache.org/jira/browse/TOMEE-2326
>
> PR: https://github.com/apache/tomee/pull/257
>
> Please feel free to comment and ask for changes.
>
> Cheers.
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 05/12/18 22:23, Bruno Baptista wrote:
> > Thanks for the context David.
> >
> > I'll write a PR with README at the Examples project level with some
> > guidelines that we can discuss. There were some other resources to
> > help make new examples. Will research that too.
> >
> > Cheers
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 05/12/18 21:21, David Blevins wrote:
> >>> On Dec 5, 2018, at 10:28 AM, Bruno Baptista 
> wrote:
> >>>
> >>> I'd say we have a problem here. What do you guys think we should do?
> >>>
> >>> • Remove Parent definition on examples and fix the ones that
> >>> will break.
> >>> • Use Parent always and fix the dependencies scope.
> >>> • A mix of both. Use parent when needed and fix the dependencies
> >>> scope.
> >> Historically we've not used parents because the goal of each example
> >> is to be completely independent in every way from the other examples
> >> and the TomEE build overall.  The intention is people can grab an
> >> example and build on it in their own projects without having to
> >> perform surgery to "cut it free" from the parent pom.
> >>
> >> This conversation typically comes up because people are trying to
> >> remove duplication between the examples, which is good habit normally
> >> and therefore most people's initial gut reaction.
> >>
> >> When you're on the learning side, however, it significantly increases
> >> the complexity of the example because:
> >>
> >>   - basic "project" structure is moved to the example parent, which
> >> then has complexity of removing duplication between 139 examples
> >>   - some of that complexity will then move to the top-level tomee
> >> parent pom to reduce duplication further
> >>   - inevitably someone will say "maybe MicroProfile examples should
> >> have their own parent pom"
> >>
> >> The result is then if a user would want to make their own tiny
> >> project based on a MicroProfile example they would need to spend a
> >> few hours learning how to untangle this theoretical pom inheritance
> >> chain:
> >>
> >>   - tomee/examples/microprofile/metrics-counted/pom.xml
> >>   - tomee/examples/microprofile/pom.xml
> >>   - tomee/examples/pom.xml
> >>   - tomee/pom.xml
> >>
> >> As coders we'll be thrilled by how much duplication we removed. As
> >> someone learning, you basically have to be an expert in maven and our
> >> build structure and be extremely willing to invest time in trial and
> >> error to recreate your own truly independent example you can then
> >> build from.
> >>
> >> For certain things like Arquillian, the pom is the hardest part, so
> >> if it isn't completely self contained and independent, it is pretty
> >> much an unusable example.
> >>
> >> At least that's how the conversation has historically gone.  We can
> >> certainly have it again and maybe create some documentation to help
> >> example authors understand the goals/motivations.
> >>
> >>
> >> -David
> >>
> >>
> >>
> >>
>

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

Oups, then I believe I need to apologize guys.

I wanted to at least fix the 2 imports so we can get a build with some
results.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> I appreciate that. Can I ask you be mindful that Frankie posted, and I
> asked him if he wanted to have a go in my reply? We should give him some
> time to respond, before someone else picks it up. If Frankie worked on
> fixing those, and then found someone else had done the same work without a
> JIRA, I suspect that would be pretty frustrating.
>
> Jon
>
> On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > I can help fixing some of those
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > Great question. The commands are:
> > >
> > > Checkstyle: mvn -Pstyle checkstyle:check
> > > PMD: mvn -Pstyle pmd:check
> > >
> > > These are relatively quick to run - about a minute or so.
> > >
> > > Looks like we have 2 checkstyle violations in the build at the moment:
> > >
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > >
> > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> > >
> > >
> >
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> > > ruleset.
> > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> > > (imports) UnusedImports: Unused import -
> > > org.apache.openejb.loader.SystemClassPath.
> > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> > > (imports) UnusedImports: Unused import -
> > > org.apache.openejb.loader.JarLocation.jarLocation.
> > >
> > > Frankie, would you like to have a go at resolving these?
> > >
> > > Cheers
> > >
> > > Jon
> > >
> > > On Wed, Dec 5, 2018 at 6:50 AM Frankie 
> wrote:
> > >
> > > > What can I do to already detect such problems when I work on the
> code?
> > > > What is the difference on the build system? (additional checkstyle
> > rules
> > > > ...?
> > > >
> > > > Frankie
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from:
> > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > >
> > >
> >
>

PR 236 - Backport of the tomee.sh script

[Jean-Louis Monteiro]

Hey Dani,

I looked at your PR yesterday and left a comment.
Can you have a look please?

https://github.com/apache/tomee/pull/236

Thanks

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: Stabilize TomEE Build

[Jean-Louis Monteiro]

I can help fixing some of those

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Hi,
>
> Great question. The commands are:
>
> Checkstyle: mvn -Pstyle checkstyle:check
> PMD: mvn -Pstyle pmd:check
>
> These are relatively quick to run - about a minute or so.
>
> Looks like we have 2 checkstyle violations in the build at the moment:
>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>
> [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> ruleset.
> [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> (imports) UnusedImports: Unused import -
> org.apache.openejb.loader.SystemClassPath.
> [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> (imports) UnusedImports: Unused import -
> org.apache.openejb.loader.JarLocation.jarLocation.
>
> Frankie, would you like to have a go at resolving these?
>
> Cheers
>
> Jon
>
> On Wed, Dec 5, 2018 at 6:50 AM Frankie  wrote:
>
> > What can I do to already detect such problems when I work on the code?
> > What is the difference on the build system? (additional checkstyle rules
> > ...?
> >
> > Frankie
> >
> >
> >
> > --
> > Sent from:
> > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >
>

Re: Github Permissions

[Jean-Louis Monteiro]

No you can't do that on Github.
It needs to be done on the Apache GIT repo and then it will be propagated
to Github and the PR closed

Try something like this
git commit --allow-empty -m "TOMEE- closes apache/tomee# *Won't
fix*"

Won't fix can be any github label you want.
Then push to apache/master and wait few seconds.


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Dec 4, 2018 at 12:47 PM Roberto Cortez 
wrote:

> Hi,
>
> Does anyone knows if we have Github permissions to close PR’s? We have
> some really old PR’s already merged but still open that I’m unable to close.
>
> Cheers,
> Roberto

Re: Forking for new PRs

[Jean-Louis Monteiro]

I agree with Romain and Bruno on this.
I'm not a fan of squashing even if from time to time I think it's useful
(See Bruno's example).

Jean-Louis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 3, 2018 at 6:49 PM César Hernández Mendoza 
wrote:

> Thanks Bruno, I'm starting to follow your approach.
> +1
>
> El lun., 3 dic. 2018 a las 5:24, Bruno Baptista ()
> escribió:
>
> > Hi folks,
> >
> > I'm also not a big fan of squashing...
> >
> > I do however understand the need to easily find commits from a certain
> > PR for portability reasons.
> >
> > There are 2 mitigating steps that can be done:
> >
> >  1. Always put the jira issue in the beginning of all comments, like:
> > "TOMEE-1234 - some comment"
> >  2. Squash commits that don't add anything to the history like, typos
> > and minor changes.
> >
> > This way, we can retain the dev's reasoning and make PRs easily portable
> > to other branches.
> >
> > Cheers.
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 30/11/18 15:41, César Hernández Mendoza wrote:
> > > Like in many things in life, we all have different opinions, you can
> find
> > > in this thread "Why we don't have Jira and Github integration?" why I
> > > prefer to have cleaner branches with squashed commits.
> > >
> > > One thing is building something, but another task is troubleshooting
> > > something someone else did and the time each person takes to do that
> will
> > > depend on different factors.
> > > Doing git bisect in a huge branch with +5 commits per functionality is
> > > something I don't wish to others.
> > >
> > >
> > >
> > >
> > >
> > >
> > > El vie., 30 nov. 2018 a las 9:23, Richard Monson-Haefel (<
> > > monsonhae...@gmail.com>) escribió:
> > >
> > >> Thanks, Guys! I really don't see the point in squashing commits as you
> > >> describe it. Seems like it cooks the books on what is actually being
> > done.
> > >> Not sure why anyone would care if a PR has multiple commits. In fact,
> > that
> > >> would make it far easier to evaluate the PR, I believe. Anyway, I get
> it
> > >> now and I thank everyone for stepping up to explain it to me but
> unless
> > >> there is some mandate for it, I won't be squashing commits.
> > >>
> > >> On Fri, Nov 30, 2018 at 8:55 AM Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > >> wrote:
> > >>
> > >>> Hi Richard,
> > >>>
> > >>> if you have 3 commit in your PR you create a single one "squashing"
> > them
> > >> 3
> > >>> (or you can select just 2 if you want)
> > >>>
> > >>> Some people are fan of it, some people hate it cause it break the
> > history
> > >>> and the "thinking" of the devs so you loose precious information (yes
> > i'm
> > >>> in this last partbeing said at the end you can't rely on the
> > history
> > >>> whatever effort you put in the writing of it). I have a colleague who
> > is
> > >>> quite interesting on that, he says "I squash 'fix typo' commits
> only".
> > >>>
> > >>> Romain Manni-Bucau
> > >>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > >>> <https://rmannibucau.metawerx.net/> | Old Blog
> > >>> <http://rmannibucau.wordpress.com> | Github <
> > >>> https://github.com/rmannibucau> |
> > >>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > >>> <
> > >>>
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >>>
> > >>> Le ven. 30 nov. 2018 à 15:50, Richard Monson-Haefel <
> > >>> monsonhae...@gmail.com>
> > >>> a écrit :
> > >>>
> > >>>> Hi,
> > >>>>
> > >>>> What does "Squashing your PR" mean?
> > >>>>
> > >>>> Thank you!
> > >>>>
> > >>>> Richard
> > >>>>
> > >>>> On Thu, Nov 29, 2018 at 5:00 PM exabrial12 
> > wrote:
> > >>>>
> > >>>>> Also, if you don't mind Squashing your PR before submitting the
> > >>> request,
> > >>>>> that
> > >>>>> will help port anything to other branches!
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Sent from:
> > >>>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > >>>>>
> > >>>>
> > >>>> --
> > >>>> Richard Monson-Haefel
> > >>>> https://twitter.com/rmonson
> > >>>> https://www.linkedin.com/in/monsonhaefel/
> > >>>>
> > >>
> > >> --
> > >> Richard Monson-Haefel
> > >> https://twitter.com/rmonson
> > >> https://www.linkedin.com/in/monsonhaefel/
> > >>
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>

PR review/merge status

[Jean-Louis Monteiro]

Hey TomEE community,

I spent some time reviewing some PRs this morning. I could merge some in
and commented out some others.

Please, make sure you read the comments.
If some PRs are outdate, please let me know with the number so I can close
them.

Thanks
Jean-Louis


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: How can I help?

[Jean-Louis Monteiro]

You did a great job.
There is no need to be sorry here.

When I started on the project someone told me, as soon as the contribution
moves us forward and not backwards, we are fine. In that regard, your
contribution definitely moves us forward.

So feel free to continue.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Dec 4, 2018 at 8:10 AM Hayri Cicek  wrote:

> Hi Louis,
>
> Yes saw your comment and I'm really sorry about that and will not rush and
> do it properly next time
>
> /Hayri
>
> Den tis 4 dec. 2018 08:06 skrev Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>:
>
> > Hey Hayri!
> >
> > I have reviewed PR https://github.com/apache/tomee/pull/231 related to
> > code
> > clean up.
> > It was a big long to review. Next time if you could make the PRs smaller
> so
> > they are easier to review and merge, that'd me great.
> >
> > There is a conflict to solve and then it's ready to go.
> >
> > Thanks
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Dec 3, 2018 at 7:55 PM Hayri Cicek  wrote:
> >
> > > Thanks Richard
> > >
> > > Den mån 3 dec. 2018 kl 13:24 skrev Richard Monson-Haefel <
> > > monsonhae...@gmail.com>:
> > >
> > > > Welcome to TomEE, Hayri!
> > > >
> > > > On Fri, Nov 30, 2018 at 1:12 PM Hayri Cicek 
> > > wrote:
> > > >
> > > > > Hi everyone,
> > > > >
> > > > > My name is Hayri Cicek and we use TomEE everyday where I work and
> > would
> > > > > love to contribute back to the project and
> > > > > I saw the how can I help and would love to try help but I started
> > > trying
> > > > to
> > > > > contribute about 3 month ago and have 2 PR's where I did some final
> > > > > parameters and use of diamond operator and would love to see if the
> > > PR's
> > > > > are okej or if not then I would love to help with something else 
> > > > >
> > > > > Links to PR's
> > > > > https://github.com/apache/tomee/pull/168
> > > > >
> > > > > https://github.com/apache/tomee/pull/163
> > > > >
> > > > > Best regards
> > > > > Hayri Cicek
> > > > > https://kodnito.com
> > > > >
> > > >
> > > >
> > > > --
> > > > Richard Monson-Haefel
> > > > https://twitter.com/rmonson
> > > > https://www.linkedin.com/in/monsonhaefel/
> > > >
> > >
> >
>

Re: How can I help?

[Jean-Louis Monteiro]

Hey Hayri!

I have reviewed PR https://github.com/apache/tomee/pull/231 related to code
clean up.
It was a big long to review. Next time if you could make the PRs smaller so
they are easier to review and merge, that'd me great.

There is a conflict to solve and then it's ready to go.

Thanks

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Dec 3, 2018 at 7:55 PM Hayri Cicek  wrote:

> Thanks Richard
>
> Den mån 3 dec. 2018 kl 13:24 skrev Richard Monson-Haefel <
> monsonhae...@gmail.com>:
>
> > Welcome to TomEE, Hayri!
> >
> > On Fri, Nov 30, 2018 at 1:12 PM Hayri Cicek 
> wrote:
> >
> > > Hi everyone,
> > >
> > > My name is Hayri Cicek and we use TomEE everyday where I work and would
> > > love to contribute back to the project and
> > > I saw the how can I help and would love to try help but I started
> trying
> > to
> > > contribute about 3 month ago and have 2 PR's where I did some final
> > > parameters and use of diamond operator and would love to see if the
> PR's
> > > are okej or if not then I would love to help with something else 
> > >
> > > Links to PR's
> > > https://github.com/apache/tomee/pull/168
> > >
> > > https://github.com/apache/tomee/pull/163
> > >
> > > Best regards
> > > Hayri Cicek
> > > https://kodnito.com
> > >
> >
> >
> > --
> > Richard Monson-Haefel
> > https://twitter.com/rmonson
> > https://www.linkedin.com/in/monsonhaefel/
> >
>

Re: How can I help?

[Jean-Louis Monteiro]

Hi José,

We just got Jon answering a similar question yesterday so I'm going to
copy/paste his answer as it totally applies to your query.

Welcome to the community! We have a few things going on with TomEE at the
> moment including:
>
> * Java EE 8 support
> * Java 11 support
> * Microprofile examples
>
> In addition, improvements to the website, documentation and any patches are
> welcome. I myself am looking at MicroProfile JWT 1.1 support which is
> almost there, and also some experimentation with security managers on the
> side (likely quite a challenge). If either of those sound interesting to
> you, I'm happy to give you some pointers. Similarly, if you like the sound
> of something else, that is cool too, and I'm sure one of us can give you
> something to get started on.
>
> Is there a particular area of interest that you'd like to dive into? If
> you're completely new to TomEE, I'd suggest starting by grabbing the server
> and trying your existing applications on it. The general idea is "if it
> runs on Tomcat, it should run on TomEE". There are some cases where that
> doesn't quite hold true, but it should be possible for the most part.
> Similarly if you have apps on WildFly, Glassfish or another server, give
> them a go and see how you get on. Its great to see new people come to the
> project looking to help out, thank you!
>

Hope it helps.
If not, feel free to shot again and we'd be happy to help in any possible
way.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 10:31 PM Jose Henrique Ventura
 wrote:

> Hi Guys,
>
> Today I stepped by Richard Monson-Haefel's tweet where he describes his
> journey with Open Source projects and
> I really liked the initiative of encouraging developers to join an Open
> Source project. I know that there are many Open Source project around there
> but I think there is a lack of information of how people can get started
> with.
>
> I'm really interested in getting started with an Open Source project
> especially now with Jakarta EE and MicroProfile.
>
> I'm interested and I would like to know "How can I help?". =)
>
> Best Regards,
> José Henrique Ventura.
> https://josehenriqueventura.github.io
>
> Sent with [ProtonMail](https://protonmail.com) Secure Email.

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

Done!
Also added you as a contributor
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 5:39 PM Ivan Junckes Filho 
wrote:

> Username: ivanjunckes
>
> You  can add my name on  https://issues.apache.org/jira/browse/TOMEE-2284.
>
>
> On Thu, Nov 22, 2018 at 2:36 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Fail!
> >
> > [image: image.png]
> >
> > Which issue would you like to work on?
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Nov 22, 2018 at 5:33 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> >> We have a contributors group if I recall for that.
> >> Lemme see
> >>
> >> What's your ID?
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Thu, Nov 22, 2018 at 5:30 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com>
> >> wrote:
> >>
> >>> Ok, I started creating them here.
> >>>
> >>> https://issues.apache.org/jira/browse/TOMEE-2285
> >>>
> >>> Any contributions of tickets are highly appreciated. :)
> >>>
> >>> Quick question: As I am not a commiter, I can't assign tasks to myself
> >>> right?
> >>>
> >>> On Thu, Nov 22, 2018 at 2:26 PM Jean-Louis Monteiro <
> >>> jlmonte...@tomitribe.com> wrote:
> >>>
> >>> > Great
> >>> > --
> >>> > Jean-Louis Monteiro
> >>> > http://twitter.com/jlouismonteiro
> >>> > http://www.tomitribe.com
> >>> >
> >>> >
> >>> > On Thu, Nov 22, 2018 at 5:20 PM Ivan Junckes Filho <
> >>> ivanjunc...@gmail.com>
> >>> > wrote:
> >>> >
> >>> > > Yes, I can do that myself then, thanks :)
> >>> > >
> >>> > >
> >>> > > On Thu, Nov 22, 2018 at 2:19 PM Jean-Louis Monteiro <
> >>> > > jlmonte...@tomitribe.com> wrote:
> >>> > >
> >>> > > > The JIRA from Apache does not support Agile extension I believe
> as
> >>> I
> >>> > > can't
> >>> > > > see in project configuration anything related. So let's go simple
> >>> maybe
> >>> > > and
> >>> > > > create a ticket for the MicroProfile example that has sub-tasks.
> >>> > > >
> >>> > > > Sounds easy?
> >>> > > > --
> >>> > > > Jean-Louis Monteiro
> >>> > > > http://twitter.com/jlouismonteiro
> >>> > > > http://www.tomitribe.com
> >>> > > >
> >>> > > >
> >>> > > > On Thu, Nov 22, 2018 at 5:16 PM Jean-Louis Monteiro <
> >>> > > > jlmonte...@tomitribe.com> wrote:
> >>> > > >
> >>> > > > > Hey Ivan,
> >>> > > > >
> >>> > > > > Lemme look at it and create an epic for you.
> >>> > > > > If that helps organizing the work and contributions, of course
> >>> we are
> >>> > > > > happy to create an Epic.
> >>> > > > >
> >>> > > > > Jean-Louis
> >>> > > > > --
> >>> > > > > Jean-Louis Monteiro
> >>> > > > > http://twitter.com/jlouismonteiro
> >>> > > > > http://www.tomitribe.com
> >>> > > > >
> >>> > > > >
> >>> > > > > On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho <
> >>> > > > ivanjunc...@gmail.com>
> >>> > > > > wrote:
> >>> > > > >
> >>> > > > >> Hey guys, there is new people that would like to contribute
> and
> >>> I
> >>> > > would
> >>> > > > >> like to suggest that we organize the effort.
> >>> > > > >>
> >>> > > > >> I propose creating an Epic and there we could add all the
> >>> tickets
> >>> > > > related
> >>> > > > >> to MicroProfile examples. It will allow contributors to go
> there
> >>> > pick
> >>> > > > up a
> >>> > > > >> ticket and work on it.
> >>> > > > >>
> >>> > > > >> The idea is to create tickets like this:
> >>> > > > >> https://issues.apache.org/jira/browse/TOMEE-2284
> >>> > > > >>
> >>> > > > >> Can anyone create an Epic so we can file tickets? I don't have
> >>> > > > permission
> >>> > > > >> I
> >>> > > > >> think, I tried it, but couldn't do it.
> >>> > > > >>
> >>> > > > >
> >>> > > >
> >>> > >
> >>> >
> >>>
> >>
>

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

Fail!

[image: image.png]

Which issue would you like to work on?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 5:33 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> We have a contributors group if I recall for that.
> Lemme see
>
> What's your ID?
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Nov 22, 2018 at 5:30 PM Ivan Junckes Filho 
> wrote:
>
>> Ok, I started creating them here.
>>
>> https://issues.apache.org/jira/browse/TOMEE-2285
>>
>> Any contributions of tickets are highly appreciated. :)
>>
>> Quick question: As I am not a commiter, I can't assign tasks to myself
>> right?
>>
>> On Thu, Nov 22, 2018 at 2:26 PM Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>>
>> > Great
>> > --
>> > Jean-Louis Monteiro
>> > http://twitter.com/jlouismonteiro
>> > http://www.tomitribe.com
>> >
>> >
>> > On Thu, Nov 22, 2018 at 5:20 PM Ivan Junckes Filho <
>> ivanjunc...@gmail.com>
>> > wrote:
>> >
>> > > Yes, I can do that myself then, thanks :)
>> > >
>> > >
>> > > On Thu, Nov 22, 2018 at 2:19 PM Jean-Louis Monteiro <
>> > > jlmonte...@tomitribe.com> wrote:
>> > >
>> > > > The JIRA from Apache does not support Agile extension I believe as I
>> > > can't
>> > > > see in project configuration anything related. So let's go simple
>> maybe
>> > > and
>> > > > create a ticket for the MicroProfile example that has sub-tasks.
>> > > >
>> > > > Sounds easy?
>> > > > --
>> > > > Jean-Louis Monteiro
>> > > > http://twitter.com/jlouismonteiro
>> > > > http://www.tomitribe.com
>> > > >
>> > > >
>> > > > On Thu, Nov 22, 2018 at 5:16 PM Jean-Louis Monteiro <
>> > > > jlmonte...@tomitribe.com> wrote:
>> > > >
>> > > > > Hey Ivan,
>> > > > >
>> > > > > Lemme look at it and create an epic for you.
>> > > > > If that helps organizing the work and contributions, of course we
>> are
>> > > > > happy to create an Epic.
>> > > > >
>> > > > > Jean-Louis
>> > > > > --
>> > > > > Jean-Louis Monteiro
>> > > > > http://twitter.com/jlouismonteiro
>> > > > > http://www.tomitribe.com
>> > > > >
>> > > > >
>> > > > > On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho <
>> > > > ivanjunc...@gmail.com>
>> > > > > wrote:
>> > > > >
>> > > > >> Hey guys, there is new people that would like to contribute and I
>> > > would
>> > > > >> like to suggest that we organize the effort.
>> > > > >>
>> > > > >> I propose creating an Epic and there we could add all the tickets
>> > > > related
>> > > > >> to MicroProfile examples. It will allow contributors to go there
>> > pick
>> > > > up a
>> > > > >> ticket and work on it.
>> > > > >>
>> > > > >> The idea is to create tickets like this:
>> > > > >> https://issues.apache.org/jira/browse/TOMEE-2284
>> > > > >>
>> > > > >> Can anyone create an Epic so we can file tickets? I don't have
>> > > > permission
>> > > > >> I
>> > > > >> think, I tried it, but couldn't do it.
>> > > > >>
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

We have a contributors group if I recall for that.
Lemme see

What's your ID?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 5:30 PM Ivan Junckes Filho 
wrote:

> Ok, I started creating them here.
>
> https://issues.apache.org/jira/browse/TOMEE-2285
>
> Any contributions of tickets are highly appreciated. :)
>
> Quick question: As I am not a commiter, I can't assign tasks to myself
> right?
>
> On Thu, Nov 22, 2018 at 2:26 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Great
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Nov 22, 2018 at 5:20 PM Ivan Junckes Filho <
> ivanjunc...@gmail.com>
> > wrote:
> >
> > > Yes, I can do that myself then, thanks :)
> > >
> > >
> > > On Thu, Nov 22, 2018 at 2:19 PM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > > > The JIRA from Apache does not support Agile extension I believe as I
> > > can't
> > > > see in project configuration anything related. So let's go simple
> maybe
> > > and
> > > > create a ticket for the MicroProfile example that has sub-tasks.
> > > >
> > > > Sounds easy?
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Thu, Nov 22, 2018 at 5:16 PM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com> wrote:
> > > >
> > > > > Hey Ivan,
> > > > >
> > > > > Lemme look at it and create an epic for you.
> > > > > If that helps organizing the work and contributions, of course we
> are
> > > > > happy to create an Epic.
> > > > >
> > > > > Jean-Louis
> > > > > --
> > > > > Jean-Louis Monteiro
> > > > > http://twitter.com/jlouismonteiro
> > > > > http://www.tomitribe.com
> > > > >
> > > > >
> > > > > On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho <
> > > > ivanjunc...@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Hey guys, there is new people that would like to contribute and I
> > > would
> > > > >> like to suggest that we organize the effort.
> > > > >>
> > > > >> I propose creating an Epic and there we could add all the tickets
> > > > related
> > > > >> to MicroProfile examples. It will allow contributors to go there
> > pick
> > > > up a
> > > > >> ticket and work on it.
> > > > >>
> > > > >> The idea is to create tickets like this:
> > > > >> https://issues.apache.org/jira/browse/TOMEE-2284
> > > > >>
> > > > >> Can anyone create an Epic so we can file tickets? I don't have
> > > > permission
> > > > >> I
> > > > >> think, I tried it, but couldn't do it.
> > > > >>
> > > > >
> > > >
> > >
> >
>

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

Great
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 5:20 PM Ivan Junckes Filho 
wrote:

> Yes, I can do that myself then, thanks :)
>
>
> On Thu, Nov 22, 2018 at 2:19 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > The JIRA from Apache does not support Agile extension I believe as I
> can't
> > see in project configuration anything related. So let's go simple maybe
> and
> > create a ticket for the MicroProfile example that has sub-tasks.
> >
> > Sounds easy?
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Nov 22, 2018 at 5:16 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > > Hey Ivan,
> > >
> > > Lemme look at it and create an epic for you.
> > > If that helps organizing the work and contributions, of course we are
> > > happy to create an Epic.
> > >
> > > Jean-Louis
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho <
> > ivanjunc...@gmail.com>
> > > wrote:
> > >
> > >> Hey guys, there is new people that would like to contribute and I
> would
> > >> like to suggest that we organize the effort.
> > >>
> > >> I propose creating an Epic and there we could add all the tickets
> > related
> > >> to MicroProfile examples. It will allow contributors to go there pick
> > up a
> > >> ticket and work on it.
> > >>
> > >> The idea is to create tickets like this:
> > >> https://issues.apache.org/jira/browse/TOMEE-2284
> > >>
> > >> Can anyone create an Epic so we can file tickets? I don't have
> > permission
> > >> I
> > >> think, I tried it, but couldn't do it.
> > >>
> > >
> >
>

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

The JIRA from Apache does not support Agile extension I believe as I can't
see in project configuration anything related. So let's go simple maybe and
create a ticket for the MicroProfile example that has sub-tasks.

Sounds easy?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 5:16 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Hey Ivan,
>
> Lemme look at it and create an epic for you.
> If that helps organizing the work and contributions, of course we are
> happy to create an Epic.
>
> Jean-Louis
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho 
> wrote:
>
>> Hey guys, there is new people that would like to contribute and I would
>> like to suggest that we organize the effort.
>>
>> I propose creating an Epic and there we could add all the tickets related
>> to MicroProfile examples. It will allow contributors to go there pick up a
>> ticket and work on it.
>>
>> The idea is to create tickets like this:
>> https://issues.apache.org/jira/browse/TOMEE-2284
>>
>> Can anyone create an Epic so we can file tickets? I don't have permission
>> I
>> think, I tried it, but couldn't do it.
>>
>

Re: TomEE Microprofile examples Epic

[Jean-Louis Monteiro]

Hey Ivan,

Lemme look at it and create an epic for you.
If that helps organizing the work and contributions, of course we are happy
to create an Epic.

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 1:17 PM Ivan Junckes Filho 
wrote:

> Hey guys, there is new people that would like to contribute and I would
> like to suggest that we organize the effort.
>
> I propose creating an Epic and there we could add all the tickets related
> to MicroProfile examples. It will allow contributors to go there pick up a
> ticket and work on it.
>
> The idea is to create tickets like this:
> https://issues.apache.org/jira/browse/TOMEE-2284
>
> Can anyone create an Epic so we can file tickets? I don't have permission I
> think, I tried it, but couldn't do it.
>

Re: Just Joined - Introduction

[Jean-Louis Monteiro]

Hi Ferdi,

Welcome and thank you for the message.

It's always great to see new people around.
What would you like to work on?

>From what I can see, I would probably suggest the examples approach. This
is usually a perfect way to get into TomEE, learn how it works.
Eventually, you get into some bugs or improvements you can contribute in
addition to the examples.

Also if you are learning still, that is a perfect way to learn more and
improve your skills.
Otherwise, you can look after the JIRA project and see if you see some
tickets you would like to work on.

Definitely let us know what you would like to do and we'll drive you
through the way to do it.

Jean-Louis




--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 22, 2018 at 4:29 AM Ferdi  wrote:

> Hi, I'm Ferdi. I live in UTC+8. Currently work as UI tester in a
> consulting company.
>
> I recently learned Java EE 7 and have been playing with WildFly 14.
> The knowledge I have for Java is limited, but I know my way around the
> IDE and Maven, and would like to contribute to TomEE.
>
> I hope this is thorough enough for an introduction.
> Thank you.
>

Re: How to help people become contributors

[Jean-Louis Monteiro]

Does not make me younger but so true.
Thanks David.

Le jeu. 22 nov. 2018 à 02:05, David Blevins  a
écrit :

> I see the tweets going on, inviting people to contribute!  That's awesome.
>
> It's a real art and challenge for both the people who want to contribute
> and those who want to help.  Figuring how to connect and enable is a team
> effort for everyone involved.
>
> Here's a couple examples of past attempts to carve out digestible chunks
> of work for people to do.
>
>  -
> https://lists.apache.org/thread.html/5a5b59289d2b4d045154aa29978f94e3362d894a65ca87c9b19a121e@1164234823@%3Cdev.tomee.apache.org%3E
>  -
> https://lists.apache.org/thread.html/07bdbaf62260d38076495ff24ae4ce1838eee93c92e2315638e1553a@1195845493@%3Cdev.tomee.apache.org%3E
>
> Everything listed in the emails is of course work I could have done
> myself.  That's always the case, otherwise you're asking people to
> instantly come into a project and instantly be better at it than you.  The
> skill you need to develop is how to plan out some work, vividly, that you
> think is hopefully achievable for people and then help them do it.
>
> This is usually very hard as you have to dream up initiatives that you
> could have people work on that new people can do.  Ideally in an hour or
> half day.  Ensure there are many of these tasks.  Then file many JIRAs,
> then advertise them.
>
> Even harder is to encourage people to not beat themselves up if they
> struggle.  People tend to be very hard on themselves.  I always encourage
> people to start small.  Get your first commit in an hour, get a taste of
> success, work your way up from there.  Most people want to dive straight
> into the hardest most exciting thing they can imagine, then struggle, stop
> asking questions for fear of exposing they are struggling, then when they
> haven't said anything for a long time feel even less able to ask questions,
> then they hurt themselves.
>
> Open source is a team effort.  You need to be comfortable failing in front
> of everyone, everyone needs to be letting you know it's ok encouraging you
> to do your best and "struggle loudly" so we can all help.
>
> *Every* *single* *time* in the last 19 years that I've seen someone be
> brave enough to struggle loudly and get help, one or two more people
> suddenly get brave enough to join them.  We've voted almost all committers
> in in twos.
>
> Here's a doc I tried to write to encourage a healthy start:
>
>  - http://tomee.apache.org/dev/contribution-tips.html
>
> These days you "EJB Examples" could be "MicroProfile examples" and all the
> same techniques and advice could work.  Someone would need to spend the
> time to think creatively and make a list of 20+ MicroProfile examples that
> could be created, then file the jiras.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

Re: Could you vote for this one please ?

[Jean-Louis Monteiro]

The description on that text file is quite small.
That being said, I don't why we could not submit a backport to Tomcat 7.x
or 8.x.

If the patch is clean and well tested, I don't see any reason why the
community would reject it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Nov 21, 2018 at 12:23 PM COURTAULT Francois <
francois.courta...@gemalto.com> wrote:

> Hello Jonathan,
>
> There is a reference to a discussion on a Tomcat list regarding Tomcat
> roadmap at https://svn.apache.org/viewvc?view=revision=1846691
> If you open the file TOMCAT-NEXT.txt, you will see in it (section New
> items for 10.0.x onwards):
> "4.  Clean-up content-type header processing. Remove the optional space
> after the
> ';' character (if any). Don't mutate the header if there is no
> charset
> parameter. See BZ 62912 for some discussion and additional
> references."
>
> This is why I am worried because the fix is scheduled only, for the
> moment, for Tomcat 10 and neither for Tomcat 8.5.x (base for TomEE 7.1.x)
> nor for Tomcat 9.0.x (base for TomEE 8.0.0).
>
> Regarding the user-agent, it's ours and we don't have anything between
> Tomcat/TomEE and the client.
>
> Best Regards.
>
> -Original Message-
> From: Jonathan Gallimore [mailto:jonathan.gallim...@gmail.com]
> Sent: mercredi 21 novembre 2018 11:11
> To: us...@tomee.apache.org
> Cc: dev@tomee.apache.org
> Subject: Re: Could you vote for this one please ?
>
> Thanks for sending this over. I've had a read through of the bug, and the
> response from the Tomcat team on the ticket. I note that there is reference
> to a discussion on a Tomcat list, but can't find a link to it (other than
> this one:
>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftomcat.10.x6.nabble.com%2FBug-62912-New-Tomcat-adds-a-space-character-in-the-Content-Type-header-if-this-one-has-a-character-rr-td5080079.htmldata=02%7C01%7CFrancois.COURTAULT%40gemalto.com%7C03da7170e1b540c5a7d708d64f99b50e%7C37d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636783918917597143sdata=XCFQB7z84PfK9ioY%2BgA6fZi%2B4uAfxLw7GQUHwB6n9vs%3Dreserved=0
> ,
> which seems to mirror the ticket). If you have one, it would be great if
> you can post it here so we can join the conversation.
>
> I'd suggest that providing a well-tested patch that includes a config
> setting to enable/disable the behaviour, in addition to voting on the issue
> would probably greatly increase the chances of success.
>
> Out of curiosity, what is the client/user-agent that is struggling with
> the issue, and do you have anything between Tomcat/TomEE (e.g. proxy server
> / load balancer) and the client?
>
> Jon
>
> On Wed, Nov 21, 2018 at 9:30 AM COURTAULT Francois <
> francois.courta...@gemalto.com> wrote:
>
> > Hello,
> >
> > We have an issue reported Bug 62912<
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbz.
> > apache.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D62912data=02%7C01%7CF
> > rancois.COURTAULT%40gemalto.com%7C03da7170e1b540c5a7d708d64f99b50e%7C3
> > 7d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636783918917597143sdata
> > =TtofsMNQilwenKQWglA7ZM661DdWjC1P7PQ8xYysJVg%3Dreserved=0> (
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbz.
> > apache.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D62912data=02%7C01%7CF
> > rancois.COURTAULT%40gemalto.com%7C03da7170e1b540c5a7d708d64f99b50e%7C3
> > 7d0a9db7c464096bfe31add5b495d6d%7C1%7C0%7C636783918917597143sdata
> > =TtofsMNQilwenKQWglA7ZM661DdWjC1P7PQ8xYysJVg%3Dreserved=0)
> >
> > Could you vote for it (to be included in the next Tomcat 8.5.x and
> > 9.0.x releases hoping those versions to be used by TomEE) ?
> > Thank you in advance.
> >
> > Best Regards.
> > 
> > This message and any attachments are intended solely for the
> > addressees and may contain confidential information. Any unauthorized
> > use or disclosure, either whole or partial, is prohibited.
> > E-mails are susceptible to alteration. Our company shall not be liable
> > for the message if altered, changed or falsified. If you are not the
> > intended recipient of this message, please delete it and notify the
> sender.
> > Although all reasonable efforts have been made to keep this
> > transmission free from viruses, the sender will not be liable for
> > damages caused by a transmitted virus.
> >
> 
>  This message and any attachments are intended solely for the addressees
> and may contain confidential information. Any unauthorized use or
> disclosure, either whole or partial, is

Re: Creates an unmarshal that does not filter to JavaEE namespace

[Jean-Louis Monteiro]

Make sure you add the apache headers in there or we won't be able to apply
your patch
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Nov 21, 2018 at 2:22 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> Sure. I'll take a look.
>
> On Wed, Nov 21, 2018 at 12:58 PM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
> > Hey, I would like to add a new test in this case.
> > I created a test, however, I had an issue to inject the Users interface.
> I
> > tried multiples way without a good result.
> >
> > Can someone help me with this?
> > https://github.com/apache/tomee/pull/211
> >
> > On Mon, Nov 19, 2018 at 1:07 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > So the issue here is that when ReadDescriptors tries to unmarshal
> > > openejb-cmp-orm.xml here:
> > >
> > >
> >
> https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/config/ReadDescriptors.java#L551
> > >
> > > fails, because JaxbJavaee.unmarshalJavaee() forces a
> > > http://java.sun.com/xml/ns/javaee namespace, and so you get the error
> > > below:
> > >
> > > unexpected element (uri:"http://java.sun.com/xml/ns/javaee;,
> > > local:"entity"). Expected elements are <{
> > > http://java.sun.com/xml/ns/persistence/orm}embeddable>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}entity>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}table-generator>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}named-native-query>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}sequence-generator>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}sql-result-set-mapping>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}named-query>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}description>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}persistence-unit-metadata
> >,<{
> > > http://java.sun.com/xml/ns/persistence/orm}catalog>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}schema>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}access>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}mapped-superclass>,<{
> > > http://java.sun.com/xml/ns/persistence/orm}package>
> > >
> > > My guess is its been broken a while, and is broken in master, 7.1.x,
> > 7.0.x,
> > > 1.7.x and maybe even earlier than that.
> > >
> > > I'll merge this PR in and we'll see what the build looks like on the
> CI.
> > > Thanks for the PR Otavio!
> > >
> > > Jon
> > >
> > > On Mon, Nov 19, 2018 at 12:37 PM Otávio Gonçalves de Santana <
> > > osant...@tomitribe.com> wrote:
> > >
> > > > Hey, sorry I missed this email.
> > > > It isn't related to Java 11.
> > > > That is an XML unmarshal error around CMP configuration.
> > > >
> > > > On Mon, Nov 19, 2018 at 10:09 AM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com> wrote:
> > > >
> > > > > That's why I was asking for the Java version and the version of
> TomEE
> > > > > --
> > > > > Jean-Louis Monteiro
> > > > > http://twitter.com/jlouismonteiro
> > > > > http://www.tomitribe.com
> > > > >
> > > > >
> > > > > On Mon, Nov 19, 2018 at 12:55 PM Thomas Andraschko <
> > > > > andraschko.tho...@gmail.com> wrote:
> > > > >
> > > > > > Is it related to
> https://issues.apache.org/jira/browse/TOMEE-2271?
> > > > > >
> > > > > > Am Mo., 19. Nov. 2018 um 12:38 Uhr schrieb Jonathan Gallimore <
> > > > > > jonathan.gallim...@gmail.com>:
> > > > > >
> > > > > > > Thanks for providing that extra detail here. I did take a look
> at
> > > > this
> > > > > > one,
> > > > > > > and I'm surprised we haven't run into it before. I'll pick up
> > your
> > > PR
> > > > > and
> > > > > > > review.
> > > > > > >
> > > > > > > Cheers!
> > > > > > >
> > > > > > > Jon
> > > > > > >
> > > > > > > On Mon, Nov 19, 2018 at 11:33 AM Otávio Gonçalves de San

Re: MicroProfile JWT 1.1

[Jean-Louis Monteiro]

Ok, yes I see it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Nov 20, 2018 at 4:11 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> The commits are showing for me (at the bottom). Here's the latest one:
>
> https://github.com/apache/tomee/commit/7ce1f8033e239331cfa7843e4e5565ed0aa83345
>
> On Tue, Nov 20, 2018 at 2:44 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Hey Jon,
> >
> > I clicked on the link and the diff tab does not show any difference.
> > Did you push?
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Nov 19, 2018 at 12:36 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > I now have the principal injection part of this working - thanks Romain
> > for
> > > your help and explanations. Progress is in my fork here:
> > > https://github.com/jgallimore/tomee/tree/jwt-1.1 (changes here:
> > >
> > >
> >
> https://github.com/apache/tomee/compare/master...jgallimore:jwt-1.1?expand=1
> > > ).
> > > There are still a couple of TODOs to clean up, and 3 tests to get
> > passing.
> > > Any feedback is appreciated.
> > >
> > > Jon
> > >
> > > On Sat, Nov 3, 2018 at 9:10 AM Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> wrote:
> > >
> > > > Yep, got it. Thanks for the feedback - makes sense now.
> > > >
> > > > Cheers
> > > >
> > > > Jon
> > > >
> > > > On Fri, 2 Nov 2018, 16:46 Romain Manni-Bucau  > > wrote:
> > > >
> > > >> Answered hopefully "long enough" on dev@geronimo so will just do a
> > > short
> > > >> one here and shout if not enough: ManagedSecurityService in cdi
> > package
> > > of
> > > >> openejb-core must make the getCurrentPrincipal contextual so hidden
> > > behind
> > > >> a proxy. The proxied API must be Principal and JsonWebToken when
> > > available
> > > >> (try { add if can load } catch { ignore } works as pattern). The
> proxy
> > > >> instance can be created once for all app using the container loader
> or
> > > per
> > > >> app using the app loader and avoiding to leak between apps since the
> > API
> > > >> can use different loaders.
> > > >>
> > > >> Le ven. 2 nov. 2018 14:44, Jonathan Gallimore <
> > > >> jonathan.gallim...@gmail.com>
> > > >> a écrit :
> > > >>
> > > >> > Thanks for the reply, but I am confused by your response. The PR I
> > > >> > referenced adds a single test to the geronimo-jwt-auth project (
> > > >> > https://github.com/apache/geronimo-jwt-auth/pull/3), based on
> > > >> >
> > > org.eclipse.microprofile.jwt.tck.container.jaxrs.PrincipalInjectionTest
> > > >> > from the TCK. It fails at present (hopefully we agree on that - my
> > > >> results
> > > >> > attached). The geronimo-jwt-auth project doesn't touch TomEE at
> all
> > -
> > > it
> > > >> > uses OWB/Meecrowave to run the MicroProfile JWT TCK. I have not
> > > modified
> > > >> > the project config at all, so it is using the SecurityService code
> > you
> > > >> > previously posted. If this additional test were part of the
> > > MicroProfile
> > > >> > JWT TCK (and I'm going to propose it), the Geronimo JWT Auth
> > > >> implementation
> > > >> > would *not* pass the TCK.
> > > >> >
> > > >> > I posted this here as I originally found the issue when continuing
> > > >> > Roberto's efforts, but this has probably contributed to some
> > > confusion.
> > > >> I
> > > >> > would suggest we continue this over on the Geronimo and OWB lists
> to
> > > >> avoid
> > > >> > further confusion.
> > > >> >
> > > >> > Jon
> > > >> >
> > > >> > On Fri, Nov 2, 2018 at 12:46 PM Romain Manni-Bucau <
> > > >> rmannibu...@gmail.com>
> > > >> > wrote:
> > > >> >
> > > >> >> Hi
> > > >> >>
> > > >> >> 

Re: MicroProfile JWT 1.1

[Jean-Louis Monteiro]

Hey Jon,

I clicked on the link and the diff tab does not show any difference.
Did you push?
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 12:36 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> I now have the principal injection part of this working - thanks Romain for
> your help and explanations. Progress is in my fork here:
> https://github.com/jgallimore/tomee/tree/jwt-1.1 (changes here:
>
> https://github.com/apache/tomee/compare/master...jgallimore:jwt-1.1?expand=1
> ).
> There are still a couple of TODOs to clean up, and 3 tests to get passing.
> Any feedback is appreciated.
>
> Jon
>
> On Sat, Nov 3, 2018 at 9:10 AM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > Yep, got it. Thanks for the feedback - makes sense now.
> >
> > Cheers
> >
> > Jon
> >
> > On Fri, 2 Nov 2018, 16:46 Romain Manni-Bucau  wrote:
> >
> >> Answered hopefully "long enough" on dev@geronimo so will just do a
> short
> >> one here and shout if not enough: ManagedSecurityService in cdi package
> of
> >> openejb-core must make the getCurrentPrincipal contextual so hidden
> behind
> >> a proxy. The proxied API must be Principal and JsonWebToken when
> available
> >> (try { add if can load } catch { ignore } works as pattern). The proxy
> >> instance can be created once for all app using the container loader or
> per
> >> app using the app loader and avoiding to leak between apps since the API
> >> can use different loaders.
> >>
> >> Le ven. 2 nov. 2018 14:44, Jonathan Gallimore <
> >> jonathan.gallim...@gmail.com>
> >> a écrit :
> >>
> >> > Thanks for the reply, but I am confused by your response. The PR I
> >> > referenced adds a single test to the geronimo-jwt-auth project (
> >> > https://github.com/apache/geronimo-jwt-auth/pull/3), based on
> >> >
> org.eclipse.microprofile.jwt.tck.container.jaxrs.PrincipalInjectionTest
> >> > from the TCK. It fails at present (hopefully we agree on that - my
> >> results
> >> > attached). The geronimo-jwt-auth project doesn't touch TomEE at all -
> it
> >> > uses OWB/Meecrowave to run the MicroProfile JWT TCK. I have not
> modified
> >> > the project config at all, so it is using the SecurityService code you
> >> > previously posted. If this additional test were part of the
> MicroProfile
> >> > JWT TCK (and I'm going to propose it), the Geronimo JWT Auth
> >> implementation
> >> > would *not* pass the TCK.
> >> >
> >> > I posted this here as I originally found the issue when continuing
> >> > Roberto's efforts, but this has probably contributed to some
> confusion.
> >> I
> >> > would suggest we continue this over on the Geronimo and OWB lists to
> >> avoid
> >> > further confusion.
> >> >
> >> > Jon
> >> >
> >> > On Fri, Nov 2, 2018 at 12:46 PM Romain Manni-Bucau <
> >> rmannibu...@gmail.com>
> >> > wrote:
> >> >
> >> >> Hi
> >> >>
> >> >> Yes this is an owb misconfiguration/integration
> >> >>
> >> >> Geronimo is fine here so likely tomee owb spi to update as in
> geronimo
> >> tck
> >> >>
> >> >> Le ven. 2 nov. 2018 10:42, Jonathan Gallimore <
> >> >> jonathan.gallim...@gmail.com>
> >> >> a écrit :
> >> >>
> >> >> > Thanks for the reply. I am still sure there is some sort of issue.
> >> >> Putting
> >> >> > TomEE to one side for the moment, I am able to reproduce this in
> the
> >> >> > Geronimo JWT auth library as well. This PR includes a test to show
> >> what
> >> >> I
> >> >> > mean: https://github.com/apache/geronimo-jwt-auth/pull/3.
> >> >> >
> >> >> > I can confirm that this change:
> >> >> > https://github.com/apache/openwebbeans/pull/12 enables that new
> >> test to
> >> >> > pass.
> >> >> >
> >> >> > In short, if you @Inject JsonWebToken, or individual claims, or
> >> >> > use @RolesAllowed, I think you're ok, but if you @Inject Principal,
> >> you
> >> >> > will most likely get the wrong principal because the instance is
> >> cache
> >> >> in a
&

Re: Github not syncing?

[Jean-Louis Monteiro]

The issue has been fixed. All seems to be working now
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Nov 20, 2018 at 12:28 AM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> I've filed a ticket with ASF infra to take a look:
> https://issues.apache.org/jira/browse/INFRA-17276
>
> Cheers
>
> Jon
>
> On Mon, Nov 19, 2018 at 11:15 PM Roberto Cortez
> 
> wrote:
>
> > Hi folks,
> >
> > It seems that Apache Git is not syncing with Github:
> >
> > https://git-wip-us.apache.org/repos/asf?p=tomee.git <
> > https://git-wip-us.apache.org/repos/asf?p=tomee.git> -> We can see
> > commits from today and from 3 days ago.
> >
> > https://github.com/apache/tomee/commits/master <
> > https://github.com/apache/tomee/commits/master> -> Last commit was 4
> days
> > ago.
> >
> > It shouldn’t take so much time to sync. Any idea what is going on?
> >
> > Cheers,
> > Roberto
> >
> >
>

Re: Writing presentable examples

[Jean-Louis Monteiro]

Thanks David. Fixed few typos in it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Nov 20, 2018 at 1:51 AM David Blevins 
wrote:

> I gave this doc a quick review and it looks good.  It doesn't have the
> directory layout or SEO information in there, but it does have a few valid
> brain hacks.
>
>  - http://tomee.apache.org/dev/writing-examples.html
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>

Re: Richard, thanks for the contribution

[Jean-Louis Monteiro]

Yes, but very happy to see the co-founder of the project back and willing
to contribute again.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 8:13 PM Richard Monson-Haefel <
monsonhae...@gmail.com> wrote:

> Thanks!  It's a start!
>
> On Mon, Nov 19, 2018 at 1:00 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Thanks Richard and welcome back to the fun.
> >
> > Merge it.
> > [image: image.png]
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
>

Richard, thanks for the contribution

[Jean-Louis Monteiro]

Thanks Richard and welcome back to the fun.

Merge it.
[image: image.png]

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: [3/4] tomee git commit: Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into 60ef186b31702bafbcb2c0ea73f867ce8b419ec6

[Jean-Louis Monteiro]

Hey Richard,

Thanks for the PR.
I just merged it.

JLouis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 7:56 PM  wrote:

> Merge a82fdd5d10f4d0813cfdcdccc363ce6cf292b292 into
> 60ef186b31702bafbcb2c0ea73f867ce8b419ec6
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/8efecf9e
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/8efecf9e
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/8efecf9e
>
> Branch: refs/heads/master
> Commit: 8efecf9e35fdfb9f14d8c210d391d9811220d750
> Parents: 60ef186 a82fdd5
> Author: monsonhaefel 
> Authored: Mon Nov 19 18:48:24 2018 +
> Committer: GitHub 
> Committed: Mon Nov 19 18:48:24 2018 +
>
> --
>  examples/access-timeout-meta/README.md | 6 +++---
>  examples/access-timeout/README.md  | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> --
>
>
>

Re: TomEE 8 - Next steps

[Jean-Louis Monteiro]

No this is a different flavor.

It is based on webprofile though


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 5:33 PM exabrial12  wrote:

> Is MP support only in a WebProfile release currently?
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: [4/5] tomee git commit: keeps the original behavior of the filter

[Jean-Louis Monteiro]

Hey Otavio,

This is a great contribution. Thanks and congrats for your first commit.

JLouis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 4:09 PM  wrote:

> keeps the original behavior of the filter
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/3e75a75b
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/3e75a75b
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/3e75a75b
>
> Branch: refs/heads/master
> Commit: 3e75a75b31ad5c61309b58af9944587f5d0e1258
> Parents: 0165264
> Author: Otavio Santana 
> Authored: Mon Nov 19 09:34:03 2018 -0200
> Committer: Otavio Santana 
> Committed: Mon Nov 19 09:34:03 2018 -0200
>
> --
>  .../src/main/java/org/apache/openejb/jee/JaxbJavaee.java   | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/3e75a75b/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> --
> diff --git
> a/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> b/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> index a76be06..407e183 100644
> ---
> a/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> +++
> b/container/openejb-jee/src/main/java/org/apache/openejb/jee/JaxbJavaee.java
> @@ -315,11 +315,7 @@ public class JaxbJavaee {
>  if (uri != null && (uri.startsWith("http://jboss.org;) ||
> uri.startsWith("urn:java:"))) { // ignore it to be able to read beans.xml
> with weld config for instances
>  ignore = true;
>  } else {
> -if ("entity-mappings".equals(localName) &&
> "entity-mappings".equals(localName)) {
> -super.startElement("http://java.sun.com/xml/ns/javaee;,
> localName, qname, atts);
> -} else {
> -super.startElement("
> http://java.sun.com/xml/ns/persistence/orm;, localName, qname, atts);
> -}
> +super.startElement("http://java.sun.com/xml/ns/javaee;,
> localName, qname, atts);
>  }
>  }
>
>
>

Re: DISCUSS: Java 11 naming convention for modules

[Jean-Louis Monteiro]

For the moment I have been struggling getting something to work.
I have pushed a few modules and I'll continue to do so. We can do a
search/replace whenever we want if we find something that goes better.

I must say that I'm not so familiar with Java Modules and I'm still
learning a lot.
Happy to hear feedback and get advices.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 4:09 PM Roberto Cortez 
wrote:

> I believe we could reach out to Sander Mak. He wrote the Java Modularity
> Book and he was pushing heavily for libraries to update to Java 9 modules.
> I’m sure we can ask him some recommendations on how to do this.
>
> > On 16 Nov 2018, at 06:01, David Blevins  wrote:
> >
> > I think the natural response is few people have Java 11 or modularity
> experience, so really the bigger part is there something critical we have
> to document here for when people suddenly have unforgiving opinions 1 or 2
> years in the future :)
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >> On Nov 15, 2018, at 6:43 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >>
> >> Hi,
> >>
> >> I have configured the Maven JAR plugin to add the module information.
> >> Unfortunately the default (artifact name) does not work so well because
> of
> >> the dash (-).
> >>
> >> I'll need to go through all modules and define a proper java module name
> >> without.
> >> The prefix would be for all of them "org.apache.tomee"
> >>
> >> Then we would have
> >>
> >>  - org.apache.tomee.container.core
> >>  - org.apache.tomee.container.javaagent
> >>  - org.apache.tomee.container.junit
> >>  - org.apache.tomee.container.jee
> >>  - org.apache.tomee.server.cxf
> >>  - org.apache.tomee.server.ejbd
> >>  - org.apache.tomee.server.activemq
> >>  - ...
> >>
> >>
> >> What do you think?
> >>
> >> I can do a first round for it.
> >>
> >> Jean-Louis
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >
>
>

Re: Creates an unmarshal that does not filter to JavaEE namespace

[Jean-Louis Monteiro]

That's why I was asking for the Java version and the version of TomEE
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 19, 2018 at 12:55 PM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Is it related to https://issues.apache.org/jira/browse/TOMEE-2271?
>
> Am Mo., 19. Nov. 2018 um 12:38 Uhr schrieb Jonathan Gallimore <
> jonathan.gallim...@gmail.com>:
>
> > Thanks for providing that extra detail here. I did take a look at this
> one,
> > and I'm surprised we haven't run into it before. I'll pick up your PR and
> > review.
> >
> > Cheers!
> >
> > Jon
> >
> > On Mon, Nov 19, 2018 at 11:33 AM Otávio Gonçalves de Santana <
> > osant...@tomitribe.com> wrote:
> >
> > > Sorry, a sent the first one as an accident.
> > >
> > > I’ve created a PR: https://github.com/apache/tomee/pull/200
> > >
> > > The error class happened at this class JaxbJavaee.java, because of this
> > > filter:
> > >
> > > final JavaeeNamespaceFilter xmlFilter = new
> > > JavaeeNamespaceFilter(parser.getXMLReader());
> > > xmlFilter.setContentHandler(unmarshaller.getUnmarshallerHandler());
> > > // unmarshall
> > > source = new SAXSource(xmlFilter, new InputSource(in));
> > >
> > > Most precise, at this piece of code:
> > >
> > > super.startElement("http://java.sun.com/xml/ns/javaee;, localName,
> > qname,
> > > atts);
> > >
> > > This is the code file to test: unmarshalling openejb-cmp-orm.xml
> > > <
> > >
> >
> https://github.com/apache/tomee/pull/200/files#diff-78d8a62617e6ef5c7a0567ee4a62711e
> > > >
> > > <
> > >
> >
> https://github.com/apache/tomee/pull/200/files#diff-78d8a62617e6ef5c7a0567ee4a62711e
> > > >
> > >
> > >
> > >
> > >
> > > On Mon, Nov 19, 2018 at 8:44 AM Jonathan Gallimore <
> > > jonathan.gallim...@gmail.com> wrote:
> > >
> > > > Hey Otavio
> > > >
> > > > Thanks for posting. At what point do you run into this exception
> (your
> > > > stacktrace shows the unmarshal, but not where its called from).  If
> you
> > > > have a PR, shoot a link here and I'll be happy to take a look.
> > > >
> > > > Jon
> > > >
> > > > On Mon, Nov 19, 2018 at 10:31 AM Otávio Gonçalves de Santana <
> > > > osant...@tomitribe.com> wrote:
> > > >
> > > > > Hi all.
> > > > >
> > > > > We found an error when using CMP; when the container starts, it
> > returns
> > > > an
> > > > > unmarshal error:
> > > > >
> > > > >
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.handleEvent(UnmarshallingContext.java:662)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError(Loader.java:258)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError(Loader.java:253)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportUnexpectedChildElement(Loader.java:120)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.childElement(Loader.java:105)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.StructureLoader.childElement(StructureLoader.java:262)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext._startElement(UnmarshallingContext.java:498)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.startElement(UnmarshallingContext.java:480)
> > > > > at
> > > > >
> > > >
> > >
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.SAXConnector.startElement(SAXConnector.java:150)
> > > > > at
> > > > >
> > org.xml.sax.helpers.XMLFilterImpl.startElement(XMLFilterIm

Re: Creates an unmarshal that does not filter to JavaEE namespace

[Jean-Louis Monteiro]

Is it Java 11 related?
What version are you running against?

Le lun. 19 nov. 2018 à 11:44, Jonathan Gallimore <
jonathan.gallim...@gmail.com> a écrit :

> Hey Otavio
>
> Thanks for posting. At what point do you run into this exception (your
> stacktrace shows the unmarshal, but not where its called from).  If you
> have a PR, shoot a link here and I'll be happy to take a look.
>
> Jon
>
> On Mon, Nov 19, 2018 at 10:31 AM Otávio Gonçalves de Santana <
> osant...@tomitribe.com> wrote:
>
> > Hi all.
> >
> > We found an error when using CMP; when the container starts, it returns
> an
> > unmarshal error:
> >
> >
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.handleEvent(UnmarshallingContext.java:662)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError(Loader.java:258)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportError(Loader.java:253)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.reportUnexpectedChildElement(Loader.java:120)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.Loader.childElement(Loader.java:105)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.StructureLoader.childElement(StructureLoader.java:262)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext._startElement(UnmarshallingContext.java:498)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallingContext.startElement(UnmarshallingContext.java:480)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.SAXConnector.startElement(SAXConnector.java:150)
> > at
> > org.xml.sax.helpers.XMLFilterImpl.startElement(XMLFilterImpl.java:551)
> > at
> >
> org.apache.openejb.jee.JaxbJavaee$JavaeeNamespaceFilter.startElement(JaxbJavaee.java:291)
> > at
> >
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(AbstractSAXParser.java:509)
> > at
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:1359)
> > at
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2784)
> > at
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)
> > at
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)
> > at
> >
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842)
> > at
> >
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771)
> > at
> >
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> > at
> >
> com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
> > at
> >
> com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643)
> > at org.xml.sax.helpers.XMLFilterImpl.parse(XMLFilterImpl.java:357)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:258)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:236)
> > at
> >
> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:288)
> >
> > I found the error at the JavaeeNamespaceFilter that initially I try to
> use
> > either Strategy or Strategy to do a bypass on this filter when is CMP.
> > However, with a not good result. So, I created a more straightforward
> > solution that creates a new method that does not use this filter.
> >
>

DISCUSS: Java 11 naming convention for modules

[Jean-Louis Monteiro]

Hi,

I have configured the Maven JAR plugin to add the module information.
Unfortunately the default (artifact name) does not work so well because of
the dash (-).

I'll need to go through all modules and define a proper java module name
without.
The prefix would be for all of them "org.apache.tomee"

Then we would have

   - org.apache.tomee.container.core
   - org.apache.tomee.container.javaagent
   - org.apache.tomee.container.junit
   - org.apache.tomee.container.jee
   - org.apache.tomee.server.cxf
   - org.apache.tomee.server.ejbd
   - org.apache.tomee.server.activemq
   - ...


What do you think?

I can do a first round for it.

Jean-Louis
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: tomee git commit: TOMEE-2277 Java 11 - define modules for TomEE At the moment, they are tight to maven artifact but we can improve later.

[Jean-Louis Monteiro]

I'll do now

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 15, 2018 at 12:11 PM Romain Manni-Bucau 
wrote:

> The full tomee build does not rely on modules even ran with java11 so it
> does not surprises me much.
>
> Try to create a new project and require openejb-core module for instance.
> Will be enough to check
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le jeu. 15 nov. 2018 à 12:09, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> a écrit :
>
> > I built and ran TomEE with some opens and exports and did not get any
> > exception.
> > But I'm happy to do a second round and override the default name
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Thu, Nov 15, 2018 at 11:40 AM Romain Manni-Bucau <
> rmannibu...@gmail.com
> > >
> > wrote:
> >
> > > Hey JL, did you check these names are valid? Think the - can be an
> issue
> > > (jdk.internal.module.Checks#requireModuleName)
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > -- Forwarded message -
> > > From: 
> > > Date: jeu. 15 nov. 2018 à 11:32
> > > Subject: tomee git commit: TOMEE-2277 Java 11 - define modules for
> TomEE
> > At
> > > the moment, they are tight to maven artifact but we can improve later.
> > > To: 
> > >
> > >
> > > Repository: tomee
> > > Updated Branches:
> > >   refs/heads/master b470fc8ce -> 127207255
> > >
> > >
> > > TOMEE-2277 Java 11 - define modules for TomEE
> > > At the moment, they are tight to maven artifact but we can improve
> later.
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/12720725
> > > Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/12720725
> > > Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/12720725
> > >
> > > Branch: refs/heads/master
> > > Commit: 12720725544cd731f7192d7d9d4483974c62ac06
> > > Parents: b470fc8
> > > Author: Jean-Louis Monteiro 
> > > Authored: Thu Nov 15 11:32:12 2018 +0100
> > > Committer: Jean-Louis Monteiro 
> > > Committed: Thu Nov 15 11:32:12 2018 +0100
> > >
> > > --
> > >  container/openejb-core/pom.xml   | 3 ++-
> > >  container/openejb-javaagent/pom.xml  | 3 ++-
> > >  itests/openejb-itests-client/pom.xml | 5 -
> > >  pom.xml  | 8 +++-
> > >  server/openejb-client/pom.xml| 5 -
> > >  tomee/apache-tomee/pom.xml   | 5 +
> > >  tomee/tomee-embedded/pom.xml | 5 -
> > >  tomee/tomee-webapp/pom.xml   | 5 +
> > >  8 files changed, 33 insertions(+), 6 deletions(-)
> > > --
> > >
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/container/openejb-core/pom.xml
> > > --
> > > diff --git a/container/openejb-core/pom.xml
> > > b/container/openejb-core/pom.xml
> > > index bcd6dd6..7aadde4 100644
> > > --- a/container/openejb-core/pom.xml
> > > +++ b/container/openejb-core/pom.xml
> > > @@ -392,12 +392,13 @@
> > >  org.apache.maven.plugins
> > >  maven-jar-plugin
> > >  
> > > -  
> > > +  
> > >

Re: tomee git commit: TOMEE-2277 Java 11 - define modules for TomEE At the moment, they are tight to maven artifact but we can improve later.

[Jean-Louis Monteiro]

I built and ran TomEE with some opens and exports and did not get any
exception.
But I'm happy to do a second round and override the default name

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Nov 15, 2018 at 11:40 AM Romain Manni-Bucau 
wrote:

> Hey JL, did you check these names are valid? Think the - can be an issue
> (jdk.internal.module.Checks#requireModuleName)
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> -- Forwarded message -
> From: 
> Date: jeu. 15 nov. 2018 à 11:32
> Subject: tomee git commit: TOMEE-2277 Java 11 - define modules for TomEE At
> the moment, they are tight to maven artifact but we can improve later.
> To: 
>
>
> Repository: tomee
> Updated Branches:
>   refs/heads/master b470fc8ce -> 127207255
>
>
> TOMEE-2277 Java 11 - define modules for TomEE
> At the moment, they are tight to maven artifact but we can improve later.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/12720725
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/12720725
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/12720725
>
> Branch: refs/heads/master
> Commit: 12720725544cd731f7192d7d9d4483974c62ac06
> Parents: b470fc8
> Author: Jean-Louis Monteiro 
> Authored: Thu Nov 15 11:32:12 2018 +0100
> Committer: Jean-Louis Monteiro 
> Committed: Thu Nov 15 11:32:12 2018 +0100
>
> --
>  container/openejb-core/pom.xml   | 3 ++-
>  container/openejb-javaagent/pom.xml  | 3 ++-
>  itests/openejb-itests-client/pom.xml | 5 -
>  pom.xml  | 8 +++-
>  server/openejb-client/pom.xml| 5 -
>  tomee/apache-tomee/pom.xml   | 5 +
>  tomee/tomee-embedded/pom.xml | 5 -
>  tomee/tomee-webapp/pom.xml   | 5 +
>  8 files changed, 33 insertions(+), 6 deletions(-)
> --
>
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/container/openejb-core/pom.xml
> --
> diff --git a/container/openejb-core/pom.xml
> b/container/openejb-core/pom.xml
> index bcd6dd6..7aadde4 100644
> --- a/container/openejb-core/pom.xml
> +++ b/container/openejb-core/pom.xml
> @@ -392,12 +392,13 @@
>  org.apache.maven.plugins
>  maven-jar-plugin
>  
> -  
> +  
>  
>org.apache.openejb.cli.Bootstrap
>
>  
>  
> +  ${tomee.build.name
> }
>openejb-loader-${project.version}.jar
> openejb-client-${project.version}.jar
>  xbean-finder-shaded-${xbeanVersion}.jar
> xbean-asm7-shaded-${xbeanVersion}.jar
>
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/container/openejb-javaagent/pom.xml
> --
> diff --git a/container/openejb-javaagent/pom.xml
> b/container/openejb-javaagent/pom.xml
> index 5e69a63..4405551 100644
> --- a/container/openejb-javaagent/pom.xml
> +++ b/container/openejb-javaagent/pom.xml
> @@ -32,8 +32,9 @@
>  org.apache.maven.plugins
>  maven-jar-plugin
>  
> -  
> +  
>  
> +  ${tomee.build.name
> }
>
>  org.apache.openejb.javaagent.Agent
>
>  org.apache.openejb.javaagent.Agent
>true
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/12720725/itests/openejb-itests-client/pom.xml
> --
> diff --git a/itests/openejb-itests-client/pom.xml
> b/itests/openejb-itests-client/pom.xml
> index 626a74d..fe3b24b 100644
> --- a/itests/openejb-itests-client/pom.xml
> +++ b/itests/openejb-itests-client/pom.xml
> @@ -45,11 +45,14 @@
>  org.apache.maven.plugins
>  maven-jar-plugin
>  
> -  
> +  
>  
>org.apache.openejb.test.Main
>true
>  
> +
> +  ${tomee.build.name
> }
> +   

DISCUSS: openejb-javaagent - Java11: Unable to initialize agent with embedded-maven-plugin

[Jean-Louis Monteiro]

Hi,

After looking at this ticket with Thomas and when reading Romain's
feedback, I'm wondering if we should discuss this or try to find a better
option for the user.

Long story short, the javaagent currently pre-loads the JPA entities and
forces the instrumentation in a different class loader (it can throw away)
so when TomEE needs the classes, they are already instrumented.

>From Romain's perspective, this brings more issues than it solves.
This is not my main area of expertise so I'm seeking for some thoughts to
understand.

Jean-Louis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: tomee git commit: TomEE-2274 Java 11 compatibility - upgrade to Jaxb 2.3.1 Thanks Cees Bos

[Jean-Louis Monteiro]

I already reverted yes.
I noticed it right after upgrade, so re-opened the ticket and reverted the
change already ;-)

Thanks for checking emails and for feedback

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Nov 13, 2018 at 2:33 PM Romain Manni-Bucau 
wrote:

> Hi JL,
>
> did you mean 2.3.0.1? 2.3.1 does not exist under these coordinates
>
> also take care it is built with java 9 so maybe not what we want to deliver
> in tomee
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> -- Forwarded message -
> From: 
> Date: mar. 13 nov. 2018 à 14:20
> Subject: tomee git commit: TomEE-2274 Java 11 compatibility - upgrade to
> Jaxb 2.3.1 Thanks Cees Bos
> To: 
>
>
> Repository: tomee
> Updated Branches:
>   refs/heads/master 03a4ca9f9 -> 7aa041047
>
>
> TomEE-2274 Java 11 compatibility - upgrade to Jaxb 2.3.1
> Thanks Cees Bos
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/7aa04104
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/7aa04104
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/7aa04104
>
> Branch: refs/heads/master
> Commit: 7aa0410472acd3010577007889d4a3076f7891b3
> Parents: 03a4ca9
> Author: Jean-Louis Monteiro 
> Authored: Tue Nov 13 14:19:50 2018 +0100
> Committer: Jean-Louis Monteiro 
> Committed: Tue Nov 13 14:19:50 2018 +0100
>
> --
>  pom.xml | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/7aa04104/pom.xml
> --
> diff --git a/pom.xml b/pom.xml
> index 537ec3a..d00622f 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -137,6 +137,8 @@
>
>  3.2.7
>  2.10.3
> +2.3.1
> +
>  
>  7.5.3.v20111011
>  1.3.5
> @@ -1695,17 +1697,17 @@
>
>  javax.xml.bind
>  jaxb-api
> -2.3.0
> +${jaxb.version}
>
>
>  com.sun.xml.bind
>  jaxb-impl
> -2.3.0
> +${jaxb.version}
>
>
>  com.sun.xml.bind
>  jaxb-core
> -2.3.0
> +${jaxb.version}
>
> 
>  org.fusesource.jansi
>

Re: Some jars in TomEE 8 SNAPSHOT are not Java 11 compatible

[Jean-Louis Monteiro]

Hi,

Thank you very much for the detailed list.

I have upgraded yesterday and today XBean and OWB so they are Java 11
compatible.
I'll do the Jaxb upgrade in few minutes.

BVal - I'll chat with Romain or Mark. They are both committers.

ECJ - this is a Tomcat dependency, so I'd check first with Tomcat community
CXF - also need to check with the community

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Nov 13, 2018 at 2:02 PM Cees Bos  wrote:

> Hi all,
>
>
> We are doing a Java 11 validation for our product.
>
> We validate all our own code, Third party jars we use and TomEE jars.
>
>
> We validate it with jdeprscan, jdeps (both tools from the JDK) and we
> decompile the code and grep for known issue patterns.
>
> We found an issue in Openwebbean 2.0.7, which is fixed in 2.0.8. That is
> released yesterday and updated for TomEE 8, that is great.
>
>
> Problems we found more:
>
>
>   *   2 bval jars in bval-jsr-2.0.1-20181030.140436-1.jar and
> bval-jsr-2.0.1-SNAPSHOT.jar
>  *   bval uses javafx from an abstract class. Javafx is not part of
> Java 11 anymore. But it looks like it is not used by default. So at first
> glace this does not look like a problem
>  *   2 jars seems overkill, so 1 can be removed I guess
>
>   *   ecj-4.7.3a.jar There are some checks with java.version which only
> deal with Java 9 and 10, but 11 and higher fail.
> See org.eclipse.jdt.internal.compiler.impl.CompilerOptions (methods
> versionFromJdkLevel, releaseToJDKLevel, versionToJdkLevel)
> Eclipse JDT code has done fixes for Java 11, see <
> https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=aecd2d1f6ce62d2ae12bcc68e57f73ab4cf27583>
>
> https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tree/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/impl/CompilerOptions.java?id=aecd2d1f6ce62d2ae12bcc68e57f73ab4cf27583
> So the latest version support Java 11 as well.
>
>   *   CXF 3.2.7 is not yet Java 11 ready.
>  *
> https://github.com/apache/cxf/commit/a3295e61bcf8c00c13a79707841a58131fd9c97d#diff-b3f6b10d6fc20e1c16fbaef5d67ba228
> Fixed Java 11 issue, see https://issues.apache.org/jira/browse/CXF-7741
> This will be part of 3.3.0, which is not released yet.
>
>   *   Jaxb Impl 2.3.0 class
> com.sun.xml.bind.v2.runtime.reflect.opt.Injector.java is using
> Unsafe.defineClass which cannot be used anymore in Java 11, see
> https://www.oracle.com/technetwork/java/javase/11-relnote-issues-5012449.html#JDK-8193033
> In Jaxb impl 2.3.1 the Injector class is gone. So upgrade to 2.3.1 to
> prevent issues with Java 11 here.
>
>   *   OpenEJB client and core use some Corba classes which are not part of
> Java anymore. That can give issues for some users, as these classes are not
> available in the runtime anymore. For us it is no problem.
>
>
> Hopefully this can help to make TomEE 8 ready for Java 11 usage for all
> users.
>
> With kind regards,
> Cees
>
>
>
>
>

Build stability

[Jean-Louis Monteiro]

Hi community,

I was checking the CI to see if the build was green after the 2 upgrades
(XBean and OWB) and realized that it's not.

After checking the history at
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8
Looks like the build has been failing a lot but a few greens.

Anyone looking at the failures?
Thoughts?

We are heavily working on MicroProfile and Java 11 to name a few and if we
can't reliably check the CI and know if we broke something, it will be hard.

We should probably stop pushing and fix the tests/code.

JLouis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: Java 11 status

[Jean-Louis Monteiro]

Ok, working on ticket TOMEE-2273
<https://issues.apache.org/jira/browse/TOMEE-2273> Thomas created.
I'll be switching to OWB 2.0.8 that just got released.

@Thomas, should I be looking at TOMEE-2270 and TOMEE-2271?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 12, 2018 at 12:05 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Ok, created https://issues.apache.org/jira/browse/TOMEE-2272 for XBean
> upgrade
> Here is the commit
> https://github.com/apache/tomee/commit/14919e15178e6f45254da74d3574dcb9312c54a1
>
> Build locally passes. Waiting for buildbot now
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Nov 12, 2018 at 9:59 AM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
>> done:
>> https://issues.apache.org/jira/browse/TOMEE-2270
>> https://issues.apache.org/jira/browse/TOMEE-2271
>>
>> Am So., 11. Nov. 2018 um 23:28 Uhr schrieb Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com>:
>>
>> > Yes please.
>> >
>> >
>> > Le dim. 11 nov. 2018 à 23:15, Thomas Andraschko <
>> > andraschko.tho...@gmail.com>
>> > a écrit :
>> >
>> > > @Jean-Louis
>> > > should i create jira tickets for my 2 issues in this thread?
>> > >
>> > > <
>> > >
>> >
>> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
>> > > >
>> > > Virenfrei.
>> > > www.avast.com
>> > > <
>> > >
>> >
>> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
>> > > >
>> > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>> > >
>> > > Am So., 11. Nov. 2018 um 22:51 Uhr schrieb Jean-Louis Monteiro <
>> > > jlmonte...@tomitribe.com>:
>> > >
>> > > > If you are willing to help me, I can do it tomorrow
>> > > >
>> > > > Le dim. 11 nov. 2018 à 12:21, Romain Manni-Bucau <
>> > rmannibu...@gmail.com>
>> > > a
>> > > > écrit :
>> > > >
>> > > > > The unit tests point is likely easy to solve either using another
>> > pool
>> > > or
>> > > > > just not using a pool for tests. Also the bug you fixed happens
>> under
>> > > > some
>> > > > > particular case we can workaround using bigger pools I think.
>> > > > > Asm upgrade is really a few seds (I can help end of next week -
>> > > thursday
>> > > > I
>> > > > > think - if needed).
>> > > > >
>> > > > > Overall point was to not lock an ecosystem for features not used
>> in
>> > > half
>> > > > of
>> > > > > it. Commons-[pool|dbcp] is not required dependency of openjpa so
>> > > shouldnt
>> > > > > block its release and if it does we must work to fix that issue
>> IMHO.
>> > > > >
>> > > > > Romain Manni-Bucau
>> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
>> > > > > <http://rmannibucau.wordpress.com> | Github <
>> > > > > https://github.com/rmannibucau> |
>> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> > > > > <
>> > > > >
>> > > >
>> > >
>> >
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> > > > > >
>> > > > >
>> > > > >
>> > > > > Le dim. 11 nov. 2018 à 12:11, Mark Struberg
>> > > > > >
>> > > > a
>> > > > > écrit :
>> > > > >
>> > > > > >  The problem is that the unit tests in OpenJPA do not pass with
>> the
>> > > old
>> > > > > > pool.
>> > > > > > So for getting OpenJPA-3.0.1 we need commons-pool.
>> > > > > > OpenJPA-3.0.0 still uses xbean-asm6. Means different package.We
>> > would
>> > > > > need
>> > > > > > to package both xbean-asm6 and xbean-asm7 if we want to ship
>> TomEE
>> > > with
>> > > > > > 

Re: Java 11 status

[Jean-Louis Monteiro]

Ok, created https://issues.apache.org/jira/browse/TOMEE-2272 for XBean
upgrade
Here is the commit
https://github.com/apache/tomee/commit/14919e15178e6f45254da74d3574dcb9312c54a1

Build locally passes. Waiting for buildbot now

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Nov 12, 2018 at 9:59 AM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> done:
> https://issues.apache.org/jira/browse/TOMEE-2270
> https://issues.apache.org/jira/browse/TOMEE-2271
>
> Am So., 11. Nov. 2018 um 23:28 Uhr schrieb Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>:
>
> > Yes please.
> >
> >
> > Le dim. 11 nov. 2018 à 23:15, Thomas Andraschko <
> > andraschko.tho...@gmail.com>
> > a écrit :
> >
> > > @Jean-Louis
> > > should i create jira tickets for my 2 issues in this thread?
> > >
> > > <
> > >
> >
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
> > > >
> > > Virenfrei.
> > > www.avast.com
> > > <
> > >
> >
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
> > > >
> > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
> > >
> > > Am So., 11. Nov. 2018 um 22:51 Uhr schrieb Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com>:
> > >
> > > > If you are willing to help me, I can do it tomorrow
> > > >
> > > > Le dim. 11 nov. 2018 à 12:21, Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > a
> > > > écrit :
> > > >
> > > > > The unit tests point is likely easy to solve either using another
> > pool
> > > or
> > > > > just not using a pool for tests. Also the bug you fixed happens
> under
> > > > some
> > > > > particular case we can workaround using bigger pools I think.
> > > > > Asm upgrade is really a few seds (I can help end of next week -
> > > thursday
> > > > I
> > > > > think - if needed).
> > > > >
> > > > > Overall point was to not lock an ecosystem for features not used in
> > > half
> > > > of
> > > > > it. Commons-[pool|dbcp] is not required dependency of openjpa so
> > > shouldnt
> > > > > block its release and if it does we must work to fix that issue
> IMHO.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > > >
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > > >
> > > > >
> > > > >
> > > > > Le dim. 11 nov. 2018 à 12:11, Mark Struberg
> >  > > >
> > > > a
> > > > > écrit :
> > > > >
> > > > > >  The problem is that the unit tests in OpenJPA do not pass with
> the
> > > old
> > > > > > pool.
> > > > > > So for getting OpenJPA-3.0.1 we need commons-pool.
> > > > > > OpenJPA-3.0.0 still uses xbean-asm6. Means different package.We
> > would
> > > > > need
> > > > > > to package both xbean-asm6 and xbean-asm7 if we want to ship
> TomEE
> > > with
> > > > > > OpenJPA-3.0.0.
> > > > > > LieGrue,strub
> > > > > >
> > > > > > On Saturday, 10 November 2018, 22:52:48 CET, Jean-Louis
> > Monteiro
> > > <
> > > > > > jlmonte...@tomitribe.com> wrote:
> > > > > >
> > > > > >  Agreed. Probably we don't need to wait for it. At least we could
> > do
> > > a
> > > > M2
> > > > > > which is Java 11 ready.
> > > > > >
> > > > > >
> > > > > >
> > > > > > Le sam. 10 nov. 2018 à 21:49, Romain Manni-Bucau <
> > > > rmannibu...@gmail.com>
> > > > > a
> > > > > > écrit :
> > > > > >
> > > > > >

Re: Java 11 status

[Jean-Louis Monteiro]

Yes please.


Le dim. 11 nov. 2018 à 23:15, Thomas Andraschko 
a écrit :

> @Jean-Louis
> should i create jira tickets for my 2 issues in this thread?
>
> <
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
> >
> Virenfrei.
> www.avast.com
> <
> https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail
> >
> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
> Am So., 11. Nov. 2018 um 22:51 Uhr schrieb Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>:
>
> > If you are willing to help me, I can do it tomorrow
> >
> > Le dim. 11 nov. 2018 à 12:21, Romain Manni-Bucau 
> a
> > écrit :
> >
> > > The unit tests point is likely easy to solve either using another pool
> or
> > > just not using a pool for tests. Also the bug you fixed happens under
> > some
> > > particular case we can workaround using bigger pools I think.
> > > Asm upgrade is really a few seds (I can help end of next week -
> thursday
> > I
> > > think - if needed).
> > >
> > > Overall point was to not lock an ecosystem for features not used in
> half
> > of
> > > it. Commons-[pool|dbcp] is not required dependency of openjpa so
> shouldnt
> > > block its release and if it does we must work to fix that issue IMHO.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le dim. 11 nov. 2018 à 12:11, Mark Struberg  >
> > a
> > > écrit :
> > >
> > > >  The problem is that the unit tests in OpenJPA do not pass with the
> old
> > > > pool.
> > > > So for getting OpenJPA-3.0.1 we need commons-pool.
> > > > OpenJPA-3.0.0 still uses xbean-asm6. Means different package.We would
> > > need
> > > > to package both xbean-asm6 and xbean-asm7 if we want to ship TomEE
> with
> > > > OpenJPA-3.0.0.
> > > > LieGrue,strub
> > > >
> > > > On Saturday, 10 November 2018, 22:52:48 CET, Jean-Louis Monteiro
> <
> > > > jlmonte...@tomitribe.com> wrote:
> > > >
> > > >  Agreed. Probably we don't need to wait for it. At least we could do
> a
> > M2
> > > > which is Java 11 ready.
> > > >
> > > >
> > > >
> > > > Le sam. 10 nov. 2018 à 21:49, Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > a
> > > > écrit :
> > > >
> > > > > Shouldnt be the case Mark since openjpa is not bound to a pool -
> > except
> > > > in
> > > > > tests - and tomee default pool is not dbcp2 but tomcat-jdbc. So it
> is
> > > > not a
> > > > > requirement but more a nice to have IMHO. Also not a regression
> since
> > > > last
> > > > > release so not a blocker ;).
> > > > >
> > > > >
> > > > > Le sam. 10 nov. 2018 21:02, Mark Struberg
>  > >
> > > a
> > > > > écrit :
> > > > >
> > > > > >  We also need to wait for commons-pool and commons-dbcp. I fixed
> a
> > > > > > deadlock in the pool.Only after that I'll be able to release
> > OpenJPA.
> > > > > > LieGrue,strub
> > > > > >
> > > > > >On Friday, 9 November 2018, 21:02:13 CET, Mark Struberg
> > > > > >  wrote:
> > > > > >
> > > > > >  Right now I do a lot of OpenJPA hacking.
> > > > > > One of the tasks is to also support xbean-asm7.
> > > > > > That should go into openjpa-3.0.1.
> > > > > >
> > > > > > What is the timeframe we want to target?
> > > > > >
> > > > > > LieGrue,
> > > > > > strub
> > > > > >
> > > > > >
> > > > > > > Am 09.11.2018 um 14:18 schrieb Romain Manni-Bucau <
> > > > > rmannibu...@gmail.com
> > > > > > >:
> > > >

Re: Java 11 status

[Jean-Louis Monteiro]

If you are willing to help me, I can do it tomorrow

Le dim. 11 nov. 2018 à 12:21, Romain Manni-Bucau  a
écrit :

> The unit tests point is likely easy to solve either using another pool or
> just not using a pool for tests. Also the bug you fixed happens under some
> particular case we can workaround using bigger pools I think.
> Asm upgrade is really a few seds (I can help end of next week - thursday I
> think - if needed).
>
> Overall point was to not lock an ecosystem for features not used in half of
> it. Commons-[pool|dbcp] is not required dependency of openjpa so shouldnt
> block its release and if it does we must work to fix that issue IMHO.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le dim. 11 nov. 2018 à 12:11, Mark Struberg  a
> écrit :
>
> >  The problem is that the unit tests in OpenJPA do not pass with the old
> > pool.
> > So for getting OpenJPA-3.0.1 we need commons-pool.
> > OpenJPA-3.0.0 still uses xbean-asm6. Means different package.We would
> need
> > to package both xbean-asm6 and xbean-asm7 if we want to ship TomEE with
> > OpenJPA-3.0.0.
> > LieGrue,strub
> >
> > On Saturday, 10 November 2018, 22:52:48 CET, Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> >  Agreed. Probably we don't need to wait for it. At least we could do a M2
> > which is Java 11 ready.
> >
> >
> >
> > Le sam. 10 nov. 2018 à 21:49, Romain Manni-Bucau 
> a
> > écrit :
> >
> > > Shouldnt be the case Mark since openjpa is not bound to a pool - except
> > in
> > > tests - and tomee default pool is not dbcp2 but tomcat-jdbc. So it is
> > not a
> > > requirement but more a nice to have IMHO. Also not a regression since
> > last
> > > release so not a blocker ;).
> > >
> > >
> > > Le sam. 10 nov. 2018 21:02, Mark Struberg 
> a
> > > écrit :
> > >
> > > >  We also need to wait for commons-pool and commons-dbcp. I fixed a
> > > > deadlock in the pool.Only after that I'll be able to release OpenJPA.
> > > > LieGrue,strub
> > > >
> > > >On Friday, 9 November 2018, 21:02:13 CET, Mark Struberg
> > > >  wrote:
> > > >
> > > >  Right now I do a lot of OpenJPA hacking.
> > > > One of the tasks is to also support xbean-asm7.
> > > > That should go into openjpa-3.0.1.
> > > >
> > > > What is the timeframe we want to target?
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > > > Am 09.11.2018 um 14:18 schrieb Romain Manni-Bucau <
> > > rmannibu...@gmail.com
> > > > >:
> > > > >
> > > > > I don't have the list handy but tomee will need at least some
> > > --add-opens
> > > > > etc to run on java11 (you can add it in setenv.sh) - likely for
> > unsafe
> > > > and
> > > > > the agent.
> > > > >
> > > > > Romain Manni-Bucau
> > > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > > <
> > > >
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > > >
> > > > >
> > > > >
> > > > > Le ven. 9 nov. 2018 à 14:09, Thomas Andraschko <
> > > > andraschko.tho...@gmail.com>
> > > > > a écrit :
> > > > >
> > > > >> (e.g. Tomcat and DeltaSpike still uses the old namespace it's in
> > > > >> web/beans.xml)
> > > > >>
> > > > >> Am Fr., 9. Nov. 2018 um 13:35 Uhr schrieb Thomas Andraschko <
> > > > >> andraschko.tho...@gmail.com>:
> > > > >>
> > > > >>> Also looks like XML unmarshalling is broken:
> >

Re: Java 11 status

[Jean-Louis Monteiro]

t;
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement
> > >>> (XMLNSDocumentScannerImpl.java:374)
> > >>>at
> > >>>
> > >>
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next
> > >>> (XMLDocumentFragmentScannerImpl.java:2708)
> > >>>at
> > >> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next
> > >>> (XMLDocumentScannerImpl.java:605)
> > >>>at
> > >>> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next
> > >>> (XMLNSDocumentScannerImpl.java:112)
> > >>>at
> > >>>
> > >>
> >
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument
> > >>> (XMLDocumentFragmentScannerImpl.java:534)
> > >>>at
> > >> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse
> > >>> (XML11Configuration.java:888)
> > >>>at
> > >> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse
> > >>> (XML11Configuration.java:824)
> > >>>at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse
> > >>> (XMLParser.java:141)
> > >>>at
> > com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse
> > >>> (AbstractSAXParser.java:1216)
> > >>>at
> > >>>
> > com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse
> > >>> (SAXParserImpl.java:635)
> > >>>at org.xml.sax.helpers.XMLFilterImpl.parse
> (XMLFilterImpl.java:357)
> > >>>at
> > >>> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0
> > >>> (UnmarshallerImpl.java:258)
> > >>>at
> > >> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal
> > >>> (UnmarshallerImpl.java:236)
> > >>>at
> > >> com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal
> > >>> (UnmarshallerImpl.java:288)
> > >>>at org.apache.openejb.jee.JaxbJavaee.unmarshalJavaee
> > >>> (JaxbJavaee.java:133)
> > >>>at org.apache.openejb.config.ReadDescriptors.readBeans
> > >>> (ReadDescriptors.java:691)
> > >>>at org.apache.openejb.config.DeploymentLoader.mergeBeansXml
> > >>> (DeploymentLoader.java:1196)
> > >>>at org.apache.openejb.config.DeploymentLoader.addBeansXmls
> > >>> (DeploymentLoader.java:1184)
> > >>>at org.apache.openejb.config.DeploymentLoader.createWebModule
> > >>> (DeploymentLoader.java:1098)
> > >>>at org.apache.openejb.config.DeploymentLoader.createWebModule
> > >>> (DeploymentLoader.java:823)
> > >>>at org.apache.openejb.config.DeploymentLoader.load
> > >>> (DeploymentLoader.java:234)
> > >>>at org.apache.tomee.catalina.TomcatWebAppBuilder.loadApplication
> > >>> (TomcatWebAppBuilder.java:2347)
> > >>>at org.apache.tomee.catalina.TomcatWebAppBuilder.startInternal
> > >>> (TomcatWebAppBuilder.java:1197)
> > >>>at org.apache.tomee.catalina.TomcatWebAppBuilder.configureStart
> > >>> (TomcatWebAppBuilder.java:1130)
> > >>>at org.apache.tomee.catalina.GlobalListenerSupport.lifecycleEvent
> > >>> (GlobalListenerSupport.java:133)
> > >>>at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent
> > >>> (LifecycleBase.java:123)
> > >>>
> > >>>
> > >>>
> > >>> Am Fr., 9. Nov. 2018 um 13:27 Uhr schrieb Thomas Andraschko <
> > >>> andraschko.tho...@gmail.com>:
> > >>>
> > >>>> @Jean-Louis
> > >>>> Are you saying that TomEE8 M1 itself is not compatbile with Java11?
> > >>>>
> > >>>> Currently trying to run my application with tomee-maven-embedded and
> > it
> > >>>> fails:
> > >>>> java.lang.IllegalStateException: Unable to initialize agent
> > >>>>at
> > >>>>
> org.apache.openejb.javaagent.Agent.checkInitialization(Agent.java:104)
> > >>>>at
> > >>>> org.apache.openejb.javaagent.Agent.getInstrumentation(Agent.java:94)
> > >>>>at
> > >>>> org.apache.tomee.embedded.Container.(Container.java:128)
> > >>>>at
> > >>>>
> > >>
> >
> org.apache.openejb.maven.plugins.TomEEEmbeddedMojo.execute(TomEEEmbeddedMojo.java:392)
> > >>>>at
> > >>>>
> > >>
> >
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> > >>>>
> > >>>>
> > >>>> Am Do., 8. Nov. 2018 um 21:36 Uhr schrieb Romain Manni-Bucau <
> > >>>> rmannibu...@gmail.com>:
> > >>>>
> > >>>>> Hi JL
> > >>>>>
> > >>>>> Openjpa needs xbean upgrade but should be quick. Cxf stack needs
> some
> > >>>>> jaxb
> > >>>>> upgrades from memory. After the stack "supports" java11 as "run it"
> > but
> > >>>>> think no spec in EE is java >= 9 compatible (modules, spi etc).
> > >>>>>
> > >>>>> Should be enough for tomee that said.
> > >>>>>
> > >>>>>
> > >>>>> Le jeu. 8 nov. 2018 20:27, Jean-Louis Monteiro <
> > >> jlmonte...@tomitribe.com>
> > >>>>> a
> > >>>>> écrit :
> > >>>>>
> > >>>>>> Hey TomEE lovers,
> > >>>>>>
> > >>>>>> I would like to push the Java 11 support forward.
> > >>>>>>
> > >>>>>> I tried to gather information here and there. Here is a status
> with
> > >> my
> > >>>>>> view. Please, lemme know if you have further updates or any
> > >> additional
> > >>>>>> information.
> > >>>>>>
> > >>>>>> XBean: ready and released
> > >>>>>> OWB: ready and released
> > >>>>>> TomEE itself (OpenEJB and other integration): ready but not
> released
> > >>>>> yet
> > >>>>>> OpenJPA: not clear, but looks like there is still some work to be
> > >> done
> > >>>>>> CXF: ready and released
> > >>>>>> MyFaces, ActiveMQ, EclipseLink, Mojorra: unknown
> > >>>>>> Tomcat: ready and released
> > >>>>>>
> > >>>>>> Are we on the same page?
> > >>>>>>
> > >>>>>> I propose to reach out to communities when libraries are not yet
> > >> ready
> > >>>>> or
> > >>>>>> released and see how we can help.
> > >>>>>>
> > >>>>>> Thoughts?
> > >>>>>>
> > >>>>>> --
> > >>>>>> Jean-Louis Monteiro
> > >>>>>> http://twitter.com/jlouismonteiro
> > >>>>>> http://www.tomitribe.com
> > >>>>>>
> > >>>>>
> > >>>>
> > >>
> >
>

Java 11 status

[Jean-Louis Monteiro]

Hey TomEE lovers,

I would like to push the Java 11 support forward.

I tried to gather information here and there. Here is a status with my
view. Please, lemme know if you have further updates or any additional
information.

XBean: ready and released
OWB: ready and released
TomEE itself (OpenEJB and other integration): ready but not released yet
OpenJPA: not clear, but looks like there is still some work to be done
CXF: ready and released
MyFaces, ActiveMQ, EclipseLink, Mojorra: unknown
Tomcat: ready and released

Are we on the same page?

I propose to reach out to communities when libraries are not yet ready or
released and see how we can help.

Thoughts?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: TomEE 8 Release Preview

[Jean-Louis Monteiro]

I'm ok with it
let's see if this does not break anything.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Oct 23, 2018 at 11:47 AM Roberto Cortez 
wrote:

> I think we can add it.
>
> Also, I think we wanted to be careful about it, so to not disrupt any of
> the other profiles and people could test it.
>
> We could add MP specs for M2.
>
> > On 23 Oct 2018, at 08:26, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
> >
> > I'd also like to see it part of Plus and Plume. It adds about 3MB to the
> > distribution size. Any other thoughts?
> >
> > Jon
> >
> > On Tue, Oct 23, 2018 at 4:44 PM dkwakkel  wrote:
> >
> >> I was also planning to use Plus and expected micro profile being part of
> >> it.
> >> We don't see that our customers maintain their own distro. We just
> instruct
> >> them how to download/install tomee.
> >> Could you reconsider making microprofile part of Plus?
> >>
> >>
> >>
> >> --
> >> Sent from:
> >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >>
>
>

Re: [VOTE][RESULT] Release Apache TomEE 8.0.0 MILESTONE 1

[Jean-Louis Monteiro]

That would be awesome

Le ven. 19 oct. 2018 à 14:57, Roberto Cortez 
a écrit :

> I wouldn’t say that.
>
> I’ve probably run mvn release:prepare, release:perform more than 100 times
> :)
>
> In the meanwhile, I plan to update our Release Instructions page:
> http://tomee.apache.org/dev/release-tomee.html <
> http://tomee.apache.org/dev/release-tomee.html>
>
> It is a little outdated :)
>
> > On 19 Oct 2018, at 14:25, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
> >
> > Well done on what looks to have been a very smooth release!
> >
> > On Fri, Oct 19, 2018 at 10:04 PM Roberto Cortez
> 
> > wrote:
> >
> >> Release is done.
> >>
> >> It is already on public apache repo:
> >>
> >>
> https://repository.apache.org/content/groups/public/org/apache/tomee/apache-tomee/8.0.0-M1/
> >> <
> >>
> https://repository.apache.org/content/groups/public/org/apache/tomee/apache-tomee/8.0.0-M1/
> >>>
> >>
> >> And in TomEE website:
> >> http://tomee.apache.org/download-ng.html <
> >> http://tomee.apache.org/download-ng.html>
> >>
> >> Mirrors should be syncing up.
> >>
> >> Again, thank you to Jon for helping me out flush the remaining steps.
> >>
> >> Cheers,
> >> Roberto
> >>
> >>> On 19 Oct 2018, at 08:19, Roberto Cortez 
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> Yeah. Sorry, I was travelling.
> >>>
> >>> Here are the votes:
> >>>
> >>> + 1 Binding: David, Jean Louis, Mark and Jon.
> >>> +1 Non Binding: Romain, César, Richard, Matthew, Roberto
> >>>
> >>> And the vote PASSES! :)
> >>>
> >>> Thank you everyone for participating. I will proceed now with the
> >> remaining tasks to promote the release.
> >>>
> >>> Cheers,
> >>> Roberto
> >>>
> >>>> On 19 Oct 2018, at 11:46, Jonathan Gallimore <
> >> jonathan.gallim...@gmail.com> wrote:
> >>>>
> >>>> +1. Let me know if I can help at all.
> >>>>
> >>>> On Fri, Oct 19, 2018 at 11:30 AM Jean-Louis Monteiro <
> >>>> jlmonte...@tomitribe.com> wrote:
> >>>>
> >>>>> Maybe time to close the vote and promote the staging repo?
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Jean-Louis Monteiro
> >>>>> http://twitter.com/jlouismonteiro
> >>>>> http://www.tomitribe.com
> >>>>>
> >>>>>
> >>>>> On Thu, Oct 18, 2018 at 11:30 AM Mark Struberg
> >> 
> >>>>> wrote:
> >>>>>
> >>>>>> +1
> >>>>>> looks good enough for a first release ;)
> >>>>>>
> >>>>>>
> >>>>>> LieGrue,
> >>>>>> strub
> >>>>>>
> >>>>>>
> >>>>>>> Am 17.10.2018 um 18:31 schrieb Mark Struberg
> >>  >>>>>>> :
> >>>>>>>
> >>>>>>> On travel, will review tonight.
> >>>>>>>
> >>>>>>> Sent with autocorrect...
> >>>>>>>
> >>>>>>>> On 17.10.2018, at 16:05, Richard Monson-Haefel <
> >>>>> monsonhae...@gmail.com>
> >>>>>> wrote:
> >>>>>>>>
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> On Tue, Oct 16, 2018 at 3:29 PM Jonathan Gallimore <
> >>>>>>>> jonathan.gallim...@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>>> +1
> >>>>>>>>>
> >>>>>>>>> Many thanks for working on the release Roberto!
> >>>>>>>>>
> >>>>>>>>> Jon
> >>>>>>>>>
> >>>>>>>>> On Mon, Oct 15, 2018 at 1:13 AM Roberto Cortez
> >>>>>>  >>>>>>>>>>
> >>>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> Hi everyone,
> >>>>>>>>>>
> >>>>>>>>>> I’ve tried to push all the r

Re: [VOTE] Release Apache TomEE 8.0.0 MILESTONE 1

[Jean-Louis Monteiro]

Maybe time to close the vote and promote the staging repo?


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Oct 18, 2018 at 11:30 AM Mark Struberg 
wrote:

> +1
> looks good enough for a first release ;)
>
>
> LieGrue,
> strub
>
>
> > Am 17.10.2018 um 18:31 schrieb Mark Struberg  >:
> >
> > On travel, will review tonight.
> >
> > Sent with autocorrect...
> >
> >> On 17.10.2018, at 16:05, Richard Monson-Haefel 
> wrote:
> >>
> >> +1
> >>
> >> On Tue, Oct 16, 2018 at 3:29 PM Jonathan Gallimore <
> >> jonathan.gallim...@gmail.com> wrote:
> >>
> >>> +1
> >>>
> >>> Many thanks for working on the release Roberto!
> >>>
> >>> Jon
> >>>
> >>> On Mon, Oct 15, 2018 at 1:13 AM Roberto Cortez
>  >>>>
> >>> wrote:
> >>>
> >>>> Hi everyone,
> >>>>
> >>>> I’ve tried to push all the required stuff to have a Milestone version
> >>>> release of TomEE 8. Please, realize that this is no way a FINAL
> release
> >>> and
> >>>> it doesn’t need to be perfect. We may have several Milestone versions
> >>> until
> >>>> we reach a Final one.
> >>>>
> >>>> Some of us, are doing sessions on Oracle Code One next week, so it
> would
> >>>> be nice if we could use an actual release instead of a SNAPSHOT.
> >>>>
> >>>> For this, I’ve released 3 projects: Java EE 8 API, a patched version
> of
> >>>> BVal2 with our groupId and TomEE itself.
> >>>>
> >>>> Staging Repos:
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1124 <
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1124>
> >>>> (EE8 API)
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1125 <
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1125>
> >>>> (BVal 2)
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1127 <
> >>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1127>
> >>>> (TomEE)
> >>>>
> >>>> Source:
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/javaee-api-8.0-source-release.zip
> >>>> <
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/javaee-api-8.0-source-release.zip
> >>>>>
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/bval-parent-2.0.0-nonfinal-57300f3-source-release.zip
> >>>> <
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/bval-parent-2.0.0-nonfinal-57300f3-source-release.zip
> >>>>>
> >>>>
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/tomee-project-8.0.0-M1-source-release.zip
> >>>> <
> >>>>
> >>>
> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/tomee-project-8.0.0-M1-source-release.zip
> >>>>>
> >>>>
> >>>> Dist Area:
> >>>> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/ <
> >>>> https://dist.apache.org/repos/dist/dev/tomee/tomee-8.0.0-M1/>
> >>>>
> >>>> JIRA:
> >>>> https://issues.apache.org/jira/projects/TOMEE/versions/12341354 <
> >>>> https://issues.apache.org/jira/projects/TOMEE/versions/12341354>
> >>>>
> >>>> Unfortunately, I was not able to add my key to the KEYS files. I
> believe
> >>>> someone on the PMC needs to do it, but I did upload it to
> >>>> http://pgp.mit.edu/ <http://pgp.mit.edu/>, where Nexus checks for the
> >>>> keys when closing the repo. Here is the direct url:
> >>>> http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1 <
> >>>> http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1>
> >>>>
> >>>> A special thanks to Jon, for helping me out through the process! Thank
> >>> you!
> >>>>
> >>>> Please vote:
> >>>> +1: Release
> >>>> 0: I don’t care
> >>>> -1 Do not release because ...
> >>>>
> >>>> The vote will be open for 3 days or the consensus is binding (At
> least 3
> >>>> binding votes).
> >>>>
> >>>> Cheers,
> >>>> Roberto
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >
>
>

Re: [VOTE] Release Apache TomEE 8.0.0 MILESTONE 1

[Jean-Louis Monteiro]

It works for me too Romain.
+1

Le mar. 16 oct. 2018 à 11:57, Romain Manni-Bucau  a
écrit :

> +1 (non-binding) if we clearly state it is not usable in production (the
> bval security issue the fork didnt fix), -1 (still not binding) otherwise
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mar. 16 oct. 2018 à 08:22, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> a écrit :
>
> > Yes totally agree on the approach.
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Oct 16, 2018 at 1:17 AM David Blevins 
> > wrote:
> >
> > > > On Oct 14, 2018, at 5:13 PM, Roberto Cortez
> > 
> > > wrote:
> > > >
> > > > Unfortunately, I was not able to add my key to the KEYS files. I
> > believe
> > > someone on the PMC needs to do it, but I did upload it to
> > > http://pgp.mit.edu/ <http://pgp.mit.edu/>, where Nexus checks for the
> > > keys when closing the repo. Here is the direct url:
> > > http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1<
> > > http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1>
> > >
> > > Your key should be in there now.
> > >
> > > Thanks for the release, Roberto!
> > >
> > > I think the key thing for us is to verify that the legal files are
> > correct.
> > >
> > > As long as that checks out, it's totally ok and smart to publish a
> > release
> > > for the purposes of getting feedback and flushing out performance
> issues
> > > like the one Thomas found.  I actually think attempting to go for a
> final
> > > as the first release of a major version is an anti-pattern.  Not
> because
> > it
> > > doesn't sound awesome, just because in 18+ years I've never seen it be
> > > faster or more stable than releasing milestones or betas at first
> > > opportunity.
> > >
> > >
> > > -David
> > >
> > >
> >
>

Re: [VOTE] Release Apache TomEE 8.0.0 MILESTONE 1

[Jean-Louis Monteiro]

Yes totally agree on the approach.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Tue, Oct 16, 2018 at 1:17 AM David Blevins 
wrote:

> > On Oct 14, 2018, at 5:13 PM, Roberto Cortez 
> wrote:
> >
> > Unfortunately, I was not able to add my key to the KEYS files. I believe
> someone on the PMC needs to do it, but I did upload it to
> http://pgp.mit.edu/ <http://pgp.mit.edu/>, where Nexus checks for the
> keys when closing the repo. Here is the direct url:
> http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1<
> http://pgp.mit.edu/pks/lookup?op=vindex=0x3D4683C24EDC64D1>
>
> Your key should be in there now.
>
> Thanks for the release, Roberto!
>
> I think the key thing for us is to verify that the legal files are correct.
>
> As long as that checks out, it's totally ok and smart to publish a release
> for the purposes of getting feedback and flushing out performance issues
> like the one Thomas found.  I actually think attempting to go for a final
> as the first release of a major version is an anti-pattern.  Not because it
> doesn't sound awesome, just because in 18+ years I've never seen it be
> faster or more stable than releasing milestones or betas at first
> opportunity.
>
>
> -David
>
>

Re: Connector issues

[Jean-Louis Monteiro]

Great note Jon.
Thanks it's appreciated

+1

Le jeu. 4 oct. 2018 à 12:01, Romain Manni-Bucau  a
écrit :

> +1 looks good
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le jeu. 4 oct. 2018 à 11:59, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> a écrit :
>
> > I have pushed some commits onto the PR here:
> > https://github.com/apache/tomee/pull/174, and would appreciate some
> > review.
> > One the things I found was that if I hold onto a reference to the proxy
> for
> > the transaction, it doesn't get cleaned up, but then losing the reference
> > from the scope at the end of the transaction also didn't clean things up.
> > What was actually going on was:
> >
> > 
> > connection = cf.createConnection();
> >
> > // forget to close it
> >
> > connection2 = cf.createConnection(); // different proxy, but same
> > ManagedConnectionInfo as the TransactionCachingInterceptor provides the
> > same connection
> > connection2.close(); // this removed the ManagedConnectionInfo from the
> > references field on AutoConnectionTracker, so it was no longer tracked
> for
> > cleanup.
> > 
> >
> > The transaction then completed, and connection dropped from scope, but
> > because the ManagedConnectionInfo associated with it wasn't in the
> > references list anymore, it never got cleaned up.
> >
> > To make matters worse, TransactionCachingInterceptor sees that the
> > ManagedConnectionInfo has open handles and refuses to send it back to the
> > pool. The effect is the connections leaked and never went back to the
> pool.
> >
> > So, my latest changes:
> >
> > * Keep a proxy for as long as the transaction runs
> > * Checks the reference list and cleans up at the end
> > * Checks the ManagedConnectionInfo object, and if there are open handles,
> > destroys the connection.
> > * Additionally, if OpenEJB.connector is set to log at FINEST, it should
> > reveal where any unclosed connections are originally opened, to provide
> the
> > developer with a hint on how to fix them.
> >
> > I'll add some tests this afternoon, but any thoughts would be much
> > appreciated.
> >
> > Jon
> >
> >
> > On Fri, Sep 28, 2018 at 3:18 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > I was thinking the same - do it through the registry. Let me have a go
> at
> > > hacking on that and I'll post back here. Many thanks for the feedback.
> > >
> > > Jon
> > >
> > > On Fri, Sep 28, 2018 at 3:15 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > wrote:
> > >
> > >> that is what I had in mind, throught it was already the case to be
> > honest
> > >> through the transaction registry - excess of enthusiasm probably ;)
> > >>
> > >> Side note: dropped G for now, if we find something impacting g-txmgr
> > we'll
> > >> add it back
> > >>
> > >> Romain Manni-Bucau
> > >> @rmannibucau  |  Blog
> > >>  | Old Blog
> > >>  | Github <
> > >> https://github.com/rmannibucau> |
> > >> LinkedIn  | Book
> > >> <
> > >>
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >> >
> > >>
> > >>
> > >> Le ven. 28 sept. 2018 à 16:11, Jonathan Gallimore <
> > >> jonathan.gallim...@gmail.com> a écrit :
> > >>
> > >> > I apologize, I CC'd Geronimo in case there was anything relevant on
> > the
> > >> > Geronimo connector side. Happy to drop the CC if its not relevant.
> > >> >
> > >> > Thanks for the quick response!
> > >> >
> > >> > Off the top of my head, I wonder if we could keep a reference to the
> > >> > connection proxy in the transaction (if there is one), and remove
> the
> > >> > reference when the transaction is complete?
> > >> >
> > >> > Jon
> > >> >
> > >> > On Fri, Sep 28, 2018 at 2:57 PM Romain Manni-Bucau <
> > >> rmannibu...@gmail.com>
> > >> > wrote:
> > >> >
> > >> > > Hi Jon,
> > >> > >
> > >> > > I experienced that kind of "surprise" in recent jvm since gc is
> way
> > >> more
> > >> > > aggressive - cause lambda are way more memory consuming ;). This
> > lead
> > >> to
> > >> > > this kind of issue where the GC happens before the object should
> > >> actually
> > >> > > be finalizable.
> > >> > > I suspect we need to rework the AutoConnectionTracker to take into
> > >> > account
> > >> > > these new behaviors and actually take into consideration the
> > >> lifecycle of
> > >> > > the underlying connection.
> > >> > >
> > >> > > Maybe I got it wrong but I see the ability to disable the proxying
> > as
> > >> a
> > >> > > quickfix/workaround - which is ok - but it means we need to fix
> the
> > >> > source
> > >> > > anyway as a 

Re: [ANNOUNCE] Welcome Roberto Cortez as new Apache TomEE committer

[Jean-Louis Monteiro]

Hey Roberto.

Welcome man and thanks for the contributions

JLouis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Mon, Sep 10, 2018 at 9:20 AM, Mark Struberg 
wrote:

> Good morning ladies and gents!
>
> It's a great pleasure to announce that Roberto Cortez has accepted our
> invitation to become an Apache TomEE committer!
>
> Welcome Roberto!
>
> your Apache TomEE PMC

Re: [VOTE] Release Apache TomEE 7.1.0 (take 2)

[Jean-Louis Monteiro]

+1
Thanks

Le jeu. 6 sept. 2018 à 12:50, Mark Struberg  a
écrit :

> checked with an app.
> sigs fine, source zip hash oh, rat ok.
>
> +1
>
> LieGrue,
> strub
>
>
> > Am 03.09.2018 um 23:22 schrieb Jonathan Gallimore <
> jonathan.gallim...@gmail.com>:
> >
> > Hi Everyone,
> >
> > Here is the first roll of TomEE 7.1.0. Please can you take a look and
> > vote? Everyone,
> > committer or not, is encouraged to test and vote.
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/orgapachetomee-1120
> >
> > Source zip:
> >
> https://repository.apache.org/content/repositories/orgapachetomee-1120/org/apache/tomee/tomee-project/7.1.0/tomee-project-7.1.0-source-release.zip
> >
> > Dist area:
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1120/
> >
> > Legal:
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1120/legal.zip
> >
> > Keys:
> > https://dist.apache.org/repos/dist/release/tomee/KEYS
> >
> > Please vote:
> > +1: Release
> > -1 Do not release because ...
> >
> > The vote will be open for 3 days or the consensus is binding (At least 3
> > binding votes).
> >
> > Here is my +1.
> >
> > Many thanks
> >
> > Jon
>
> --
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: [VOTE] Release Apache TomEE 7.1.0

[Jean-Louis Monteiro]

A full reroll is usually faster.

Le ven. 31 août 2018 à 23:49, Roberto Cortez 
a écrit :

> Ok, I’ve figured out the NOTICE file issue.
>
> Apparently, we have duplicate places where we need to place the files. One
> in the webapp module and another one in the dist module :(
>
> Here is a PR to fix the issue:
> https://github.com/apache/tomee/pull/158 <
> https://github.com/apache/tomee/pull/158>
>
> I would suggest that instead of a full reroll, we update the TAG with this
> change and redeploy only the MP dist binary. Not sure if this is allowed :)
>
> Cheers,
> Roberto
>
> > On 31 Aug 2018, at 22:31, Roberto Cortez 
> wrote:
> >
> > I was writing some MP sample app cases that we can use.
> >
> > Or are you referring to something else?
> >
> >
> >> On 31 Aug 2018, at 16:00, Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
> >>
> >> Roberto - did you have a test/sample app for this?
> >>
> >> Looks like the microprofile zip is short of a NOTICE file, and that
> would
> >> need to include the same notices as webprofile, plus this one:
> >>
> >> (
> >>
> https://bitbucket.org/b_c/jose4j/src/7f9624414a1baf752adbc61d4a1be16253eeec23/NOTICE.txt?at=master=file-view-default
> >> )
> >> -
> >> jose4j
> >> Copyright 2012-2015 Brian Campbell
> >>
> >> EcdsaUsingShaAlgorithm contains code for converting the concatenated
> >> R & S values of the signature to and from DER, which was originally
> >> derived from the Apache Santuario XML Security library's SignatureECDSA
> >> implementation. http://santuario.apache.org/
> >>
> >> The Base64 implementation in this software was derived from the
> >> Apache Commons Codec project.
> >> http://commons.apache.org/proper/commons-codec/
> >>
> >> JSON processing in this software was derived from the JSON.simple
> toolkit.
> >> https://code.google.com/p/json-simple/
> >> -
> >>
> >> Thoughts?
> >>
> >> Other than that I can't see any issues.
> >>
> >> Jon
> >>
> >>
> >> On Fri, Aug 31, 2018 at 2:39 PM Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>
> >>> +1
> >>>
> >>> Thank you very much Jon for the release and Roberto for the
> microprofile
> >>> work
> >>>
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>> On Fri, Aug 31, 2018 at 1:33 PM, Mark Struberg
> 
> >>> wrote:
> >>>
> >>>> +1
> >>>>
> >>>> LieGrue,
> >>>> strub
> >>>>
> >>>>
> >>>>> Am 30.08.2018 um 12:24 schrieb Jonathan Gallimore <
> >>>> jonathan.gallim...@gmail.com>:
> >>>>>
> >>>>> Hi Everyone,
> >>>>>
> >>>>> Here is the first roll of TomEE 7.1.0. Please can you take a look and
> >>>>> vote? Everyone,
> >>>>> committer or not, is encouraged to test and vote.
> >>>>>
> >>>>> Staging repo:
> >>>>>
> https://repository.apache.org/content/repositories/orgapachetomee-1119
> >>>>>
> >>>>> Source zip:
> >>>>> https://repository.apache.org/content/repositories/
> >>>> orgapachetomee-1119/org/apache/tomee/tomee-project/7.
> >>>> 1.0/tomee-project-7.1.0-source-release.zip
> >>>>>
> >>>>> Dist area:
> >>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/
> >>>>>
> >>>>> Legal:
> >>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1119/legal.zip
> >>>>>
> >>>>> Keys:
> >>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS
> >>>>>
> >>>>> Please vote:
> >>>>> +1: Release
> >>>>> -1 Do not release because ...
> >>>>>
> >>>>> The vote will be open for 3 days or the consensus is binding (At
> least
> >>> 3
> >>>>> binding votes).
> >>>>>
> >>>>> Many thanks
> >>>>>
> >>>>> Jon
> >>>>
> >>>>
> >>>
> >
>
>

Re: [VOTE] Release Apache TomEE 7.1.0

[Jean-Louis Monteiro]

+1

Thank you very much Jon for the release and Roberto for the microprofile
work

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Fri, Aug 31, 2018 at 1:33 PM, Mark Struberg 
wrote:

> +1
>
> LieGrue,
> strub
>
>
> > Am 30.08.2018 um 12:24 schrieb Jonathan Gallimore <
> jonathan.gallim...@gmail.com>:
> >
> > Hi Everyone,
> >
> > Here is the first roll of TomEE 7.1.0. Please can you take a look and
> > vote? Everyone,
> > committer or not, is encouraged to test and vote.
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/orgapachetomee-1119
> >
> > Source zip:
> > https://repository.apache.org/content/repositories/
> orgapachetomee-1119/org/apache/tomee/tomee-project/7.
> 1.0/tomee-project-7.1.0-source-release.zip
> >
> > Dist area:
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1119/
> >
> > Legal:
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1119/legal.zip
> >
> > Keys:
> > https://dist.apache.org/repos/dist/release/tomee/KEYS
> >
> > Please vote:
> > +1: Release
> > -1 Do not release because ...
> >
> > The vote will be open for 3 days or the consensus is binding (At least 3
> > binding votes).
> >
> > Many thanks
> >
> > Jon
>
>

Re: MP Summary in TomEE

[Jean-Louis Monteiro]

Hi Roberto,

Thanks for the update. I won't have time tonight, but I'll review tomorrow
morning your PRs and merge for you if that's ok.

Jean-Louis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Mon, Aug 13, 2018 at 6:19 PM, Roberto Cortez  wrote:

> An update status:
>
> TomEE 7.1:
> - MicroProfile 1.2.
> - Support for Config, JWT, Fault Tolerance and Health added.
> - Metrics seems to require CDI 2.0 that is not available on TomEE 7, so it
> is out for now.
> - Health has an issue with the JSON response because of JSONB annotation.
> May need the JSONB Provider as well.
> - PR’s: TOMEE-2209 - TomEE 7.1 Added MP Specs: Fault Tolerance and Health.
> <https://github.com/apache/tomee/pull/145>
>
> TomEE 8:
> - MicroProfile 1.2 and 1.3
> - Support for Config, JWT, Fault Tolerance, Health, Metrics, Rest Client
> and OpenAPI.
> - Still working on the Open Tracing support.
> - Requires the JSONB Provider.
> - PR’s: TOMEE-2209 - TomEE 8 Microprofile 1.2 Support <
> https://github.com/apache/tomee/pull/141>, TOMEE-2210 - TomEE 8
> Microprofile 1.3 Support <https://github.com/apache/tomee/pull/146>,
> TOMEE-2221 - Added Johnzon Jsonb Provider. <https://github.com/apache/
> tomee/pull/142>
>
> Main JIRAS:
> TOMEE-2209 <https://issues.apache.org/jira/browse/TOMEE-2209>
> TOMEE-2210 <https://issues.apache.org/jira/browse/TOMEE-2210>
> TOMEE-2221 <https://issues.apache.org/jira/browse/TOMEE-2221>
>
> Hope it helps!
>
> Cheers,
> Roberto
>
> > On 9 Aug 2018, at 21:33, Gurkan Erdogdu  wrote:
> >
> >>
> >> Sure. Here it is:
> >> https://issues.apache.org/jira/browse/TOMEE-2209 <
> >> https://issues.apache.org/jira/browse/TOMEE-2209>
> >
> > Thank you.
> >
> > On Thu, Aug 9, 2018 at 7:41 PM, Roberto Cortez
> 
> > wrote:
> >
> >> Would a main JIRA Issue “MicroProfile Support” and sub-tasks with
> >> everything related under the parent task work?
> >>
> >>> On 9 Aug 2018, at 17:36, David Blevins 
> wrote:
> >>>
> >>>> On Aug 9, 2018, at 4:28 AM, Gurkan Erdogdu 
> wrote:
> >>>>
> >>>> Can you also please open JIRA issue (main issue and we
> >>>> can create sub-tasks under it) to track MP related work?
> >>>
> >>> Agreed.  And for those reading, our release notes are generated from
> >> JIRA (or at least they used to be).  So we should file JIRAs with the
> >> subject written from the perspective of someone reading the release
> notes.
> >> That's clean and simple subjects.
> >>>
> >>> It would be very common for me to file a handful of JIRAs even though
> >> one would do it from a tracking perspective.  It was also common for me
> to
> >> go back through commits at release time and spend 2 days filing them
> >> because the release notes were too thin.
> >>>
> >>> Here's the template:
> >>>
> >>> - https://svn.apache.org/repos/asf/tomee/sandbox/release-
> >> tools/src/main/resources/release-notes.vm
> >>>
> >>> As far as JIRAs, I'd probably aim for release notes looking like this:
> >>>
> >>>
> >>>   Upgrades:
> >>>
> >>>- ...
> >>>
> >>>   New Features:
> >>>
> >>>- MicroProfile 1.3 Support
> >>>- MicroProfile JWT 1.0
> >>>- MicroProfile FaultTolerance 1.0
> >>>[list them all cleanly]
> >>>
> >>> That'd mean you'd have to file a JIRA of type "New Feature" with the
> >> clean subject "MicroProfile JWT 1.0."  If you used talkative text like,
> >> "Adding some MP-JWT Stuff", you'll get strange looking release notes.
> >>>
> >>>
> >>>   Upgrades:
> >>>
> >>>- ...
> >>>
> >>>   New Features:
> >>>
> >>>- Implement MP in TomEE
> >>>[list them all cleanly]
> >>>
> >>>   Tasks & Subtasks:
> >>>
> >>>- Update the pom.xml with MP-JWT
> >>>- Fix integration issue with JWT Filter
> >>>[list them all cleanly]
> >>>
> >>> This doesn't clearly communicate our status to the world and just puts
> >> more work on the release manager who would have to ensure the release
> notes
> >> make sense, so it's to not just file JIRAs, but think of the future
> release
> >> note readers when we file them.
> >>>
> >>>
> >>> -David
> >>>
> >>>
> >>
> >>
>
>

Re: [VOTE] Allow an MicroProfile-focused TomEE 7.1 release

[Jean-Louis Monteiro]

+1

Still don't see why a vote is needed. Let's move on and work on TomEE now

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Aug 9, 2018 at 11:05 AM, Roberto Cortez  wrote:

> +1
>
> > On 9 Aug 2018, at 09:54, Matthew Broadhead 
> > 
> wrote:
> >
> > +0
> >
> > if TomEE 8 is available then i will use that, and probably never install
> 7.1.x.  they both target java 8 anyway so it won't help if you are stuck on
> a lower version?
> >
> > On 09/08/18 08:08, David Blevins wrote:
> >> For a few months we've discussed doing and not doing a TomEE 7 flavored
> release of MicroProfile 1.x for Java EE 7 users on Java 8, tentatively
> versioned TomEE 7.1.
> >>
> >> Earliest email with TomEE 7.1 in the subject is around April, though I
> vaguely recall it mentioned before.  I recall seeing a request from Mark to
> wait on it till after 7.0.5 was released.  That's now out and a TomEE 7.1.x
> branch has been created and being actively worked on.
> >>
> >> There seem to be concerns that this will draw attention away from TomEE
> 8, which is understandable, and some sentiment that this work should stop
> and everyone focus on TomEE 8.  I haven't seen anyone suggest not working
> on TomEE 8, so I'll assume that as a constant that doesn't need to be voted
> on.
> >>
> >> As the concern is largely resources, I propose the following compromise:
> >>
> >>  - MicroProfile related PRs that can possibly apply to TomEE 8 must be
> merged to master *before* the equivalent can be merged to TomEE 7.1.x. In
> short, everyone must work on TomEE 8.
> >>
> >>  - Those who wish to focus time only on TomEE 8 may do so, someone else
> can merge the PR to 7.1.x if they have the energy.  In short, only the
> willing need work on TomEE 7.1.x
> >>
> >> With this in mind, the vote:
> >>
> >>   +1 Allow work on TomEE 7.1 to proceed with the above two conditions
> >>  +-O Abstain or don't feel strongly
> >>   -1 I have a better idea
> >>
> >>
> >>
> >> -David
> >>
> >
>
>

Re: MP Summary in TomEE

[Jean-Louis Monteiro]

We have what we have and we can release with it.
We can also integrate some of the geronimo stuff.
If users want more, they can help and contribute I believe.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Aug 9, 2018 at 9:11 AM, Romain Manni-Bucau 
wrote:

> Ok, let's be concrete, who will implement the specs on tomee 7 and under
> which deadline? I think it is the main point to recenter on tomee 8 where
> all the work is already done and investment is very low.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-
> ee-8-high-performance>
>
>
> Le jeu. 9 août 2018 à 08:49, Jean-Louis Monteiro  >
> a écrit :
>
> > I also don't get why there is resistance to backport if we can and if a
> > contriibutor/committer is wiling to.
> > We have most of our users not using TomEE because it's not finished or
> > certified.
> >
> > They would certainely be happy to being able to use MP on a stable TomEE
> > version.
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> > On Thu, Aug 9, 2018 at 8:33 AM, David Blevins 
> > wrote:
> >
> > > Good morning :)
> > >
> > > > On Aug 8, 2018, at 10:53 PM, Gurkan Erdogdu 
> > wrote:
> > > >
> > > >>
> > > >> We can definitely vote, but would be great if we can way a day or
> two
> > to
> > > >> discuss what we'd be voting and what our status is and how to best
> > > address
> > > >> our concerns.
> > > >>
> > > > +1
> > >
> > > I maybe jumped the gun.  I'm happy to trash the vote I put up if we
> feel
> > > that's best.  Or we let it continue and consider it informational and
> > > non-binding.
> > >
> > > >> We all universally agree we want MP in TomEE 8 and are actively
> > working
> > > on
> > > >> it
> > > >>
> > > > I am not sure there is an active MP work in TomEE
> > >
> > > It's not roaring active, but config and jwt are there and passing in
> > TomEE
> > > 8 and 7.1. Roberto has done a good chunk of that integration work,
> > > obviously Jean-Louis a large part of the JWT support, Jon has indicated
> > in
> > > the past a willingness to spin the release.
> > >
> > > > My understanding of the concern is that we end up ignoring TomEE 8,
> > which
> > > >> is a concern I would share.
> > > >>
> > > > I did not understand what you mean by ignoring TomEE 8 .Can you
> please
> > a
> > > > bit elaborate? Who ignore?
> > >
> > > This is me attempting to understand the objection to a TomEE 7.1 and
> > > apparently doing a bad job of it :)
> > >
> > > I got the impression the concern was that energy would be shifted away
> > > from TomEE 8 to a TomEE 7.1, i.e. TomEE 8 would suffer and be ignored
> as
> > a
> > > result.  If that's not the case, I suspect I need someone who is
> > concerned
> > > about a 7.1 to say more specifically the concern is.
> > >
> > > > Perhaps the most effective vote would be to vote to require those who
> > do
> > > >> work on a TomEE 7.1 to also submit the same PR to TomEE 8. If a PR
> > comes
> > > >> into TomEE 7.1 only and that work is needed in TomEE 8, but there
> > isn't
> > > a
> > > >> PR, we reject it.
> > > >>
> > > > -1. Different people can work on TomEE 7.1 and TomEE 8. We need to
> > > > differentiate TomEE 7.1 from TomEE 8. TomEE 7.1 is just in there to
> > only
> > > > include MP1. We don't want to wait TomEE 7.1 for TomEE 8.
> > >
> > > I'm ok with us not being that strict.  I only proposed it as a
> compromise
> > > to address concerns.  I have a growing awareness I haven't clearly
> > > understood the concern well enough to address it.
> > >
> > > I'll shut my mouth for a bit and re-open my ears, hopefully something
> > good
> > > will jump in. :)
> > >
> > >
> > > -David
> > >
> > >
> >
>

Re: MP Summary in TomEE

[Jean-Louis Monteiro]

I also don't get why there is resistance to backport if we can and if a
contriibutor/committer is wiling to.
We have most of our users not using TomEE because it's not finished or
certified.

They would certainely be happy to being able to use MP on a stable TomEE
version.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Aug 9, 2018 at 8:33 AM, David Blevins 
wrote:

> Good morning :)
>
> > On Aug 8, 2018, at 10:53 PM, Gurkan Erdogdu  wrote:
> >
> >>
> >> We can definitely vote, but would be great if we can way a day or two to
> >> discuss what we'd be voting and what our status is and how to best
> address
> >> our concerns.
> >>
> > +1
>
> I maybe jumped the gun.  I'm happy to trash the vote I put up if we feel
> that's best.  Or we let it continue and consider it informational and
> non-binding.
>
> >> We all universally agree we want MP in TomEE 8 and are actively working
> on
> >> it
> >>
> > I am not sure there is an active MP work in TomEE
>
> It's not roaring active, but config and jwt are there and passing in TomEE
> 8 and 7.1. Roberto has done a good chunk of that integration work,
> obviously Jean-Louis a large part of the JWT support, Jon has indicated in
> the past a willingness to spin the release.
>
> > My understanding of the concern is that we end up ignoring TomEE 8, which
> >> is a concern I would share.
> >>
> > I did not understand what you mean by ignoring TomEE 8 .Can you please a
> > bit elaborate? Who ignore?
>
> This is me attempting to understand the objection to a TomEE 7.1 and
> apparently doing a bad job of it :)
>
> I got the impression the concern was that energy would be shifted away
> from TomEE 8 to a TomEE 7.1, i.e. TomEE 8 would suffer and be ignored as a
> result.  If that's not the case, I suspect I need someone who is concerned
> about a 7.1 to say more specifically the concern is.
>
> > Perhaps the most effective vote would be to vote to require those who do
> >> work on a TomEE 7.1 to also submit the same PR to TomEE 8. If a PR comes
> >> into TomEE 7.1 only and that work is needed in TomEE 8, but there isn't
> a
> >> PR, we reject it.
> >>
> > -1. Different people can work on TomEE 7.1 and TomEE 8. We need to
> > differentiate TomEE 7.1 from TomEE 8. TomEE 7.1 is just in there to only
> > include MP1. We don't want to wait TomEE 7.1 for TomEE 8.
>
> I'm ok with us not being that strict.  I only proposed it as a compromise
> to address concerns.  I have a growing awareness I haven't clearly
> understood the concern well enough to address it.
>
> I'll shut my mouth for a bit and re-open my ears, hopefully something good
> will jump in. :)
>
>
> -David
>
>

Re: Microprofile JWT impl Enum injection

[Jean-Louis Monteiro]

Hey Ivan,

Thanks for the patch.
I have reviewed and merge the PR against master and the backport to
tomee-7.1.x



--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Fri, Aug 3, 2018 at 9:51 PM, Ivan Junckes Filho 
wrote:

> Hello guys, I did a fix so the Microprofile JWT impl has support for
> injecting Enums. Basically checks if the injection point is an enum and
> then convert it.
>
> Please review:
> https://github.com/apache/tomee/pull/143
>
> Thanks.
>

TomEE 7.1.x branch mistake

[Jean-Louis Monteiro]

Hey guys,

While merging PR 138 from Roberto into branch tomee-7.1.x, I messed up with
the names and created a new branch apache/tomee-7.1.x instead of pushing to
tomee-7.1.x of the apache git repo.

I'll be deleting the apache/tomee-7.1.x branch and push to the right one

Sorry about the noise


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: TomEE 7.1 with MP

[Jean-Louis Monteiro]

I think the 7.1.x was a proposal to have a stable TomEE with microprofile
until we are ready to release something based on TomEE 8


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Jul 26, 2018 at 12:07 PM, Romain Manni-Bucau 
wrote:

> Hmm, did we get anything new compared to the thread "TomEE 7.1.x with
> Microprofile" to justify a 7.1 compared to directly jump to 8.0?
> Does it mean 7.0 is no more supported if we stick to only supportting 2
> main branches?
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-
> ee-8-high-performance>
>
>
> Le jeu. 26 juil. 2018 à 11:53, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> a écrit :
>
> > Hey Roberto,
> >
> > Thanks for the PR. I have reviewed it and it looks good. So I'll proceed
> > and merge. I'll see if I can throw a vote out for the 7.1.x
> >
> > +1 to switch master to 8.x as discussed.
> > For TomEE 8.x we can try adding all the other microprofile
> implementations
> > available at apache.
> >
> > Jean-Louis
> >
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> > On Thu, Jul 26, 2018 at 11:04 AM, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > On Thu, Jul 26, 2018 at 5:57 AM, Romain Manni-Bucau <
> > rmannibu...@gmail.com
> > > >
> > > wrote:
> > >
> > > > Hi guys
> > > >
> > > > Didnt we plan to switch master to tomee 8 after the 7.0.5?
> > >
> > >
> > > We did agree that, and I'm happy to do that provided we can keep a
> branch
> > > for 7.0.x to maintain it. Unless anyone throws an objection on that in
> > the
> > > next couple of hours, I'll switch that over today. I think it has been
> > > discussed plenty.
> > >
> > >
> > > > Also not sure we
> > > > want the 7.1 (we didnt finish the discussion IIRC).
> > > >
> > >
> > > I'm sure we want the MP stuff in TomEE 8 as well, but I'd be in favour
> > of a
> > > TomEE 7.1 also.
> > >
> > >
> > > >
> > > > As a side note: geronimo is MP complete (yes I didnt resist to the
> > joke)
> > > so
> > > > maybe time to just import it all?
> > > >
> > >
> > > I'd certainly be happy to give that a go.
> > >
> > > Jon
> > >
> > >
> > > >
> > > > Romain
> > > >
> > > >
> > > > Le jeu. 26 juil. 2018 01:26, Jonathan Gallimore <
> > > > jonathan.gallim...@gmail.com> a écrit :
> > > >
> > > > > Awesome, thanks Roberto!
> > > > >
> > > > > On Wed, Jul 25, 2018 at 7:16 PM, Roberto Cortez
> > > > >  > > > > > wrote:
> > > > >
> > > > > > Hi everyone,
> > > > > > I've picked up some of the work started by JL on the tomee-7.1.x
> > > branch
> > > > > to
> > > > > > have a release with some MP support.
> > > > > > I've updated the branch with the latest 7.0.5 code, plus, fixed
> > some
> > > > > > issues with the MP Configuration and MP JWT integration.
> > > > > > I've opened the following PR:https://github.com/apache/
> > > tomee/pull/138
> > > > > >
> > > > > > Hope it is ok.
> > > > > > Cheers,Roberto
> > > > >
> > > >
> > >
> >
>

Re: TomEE 7.1 with MP

[Jean-Louis Monteiro]

Hey Roberto,

Thanks for the PR. I have reviewed it and it looks good. So I'll proceed
and merge. I'll see if I can throw a vote out for the 7.1.x

+1 to switch master to 8.x as discussed.
For TomEE 8.x we can try adding all the other microprofile implementations
available at apache.

Jean-Louis


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Jul 26, 2018 at 11:04 AM, Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:

> On Thu, Jul 26, 2018 at 5:57 AM, Romain Manni-Bucau  >
> wrote:
>
> > Hi guys
> >
> > Didnt we plan to switch master to tomee 8 after the 7.0.5?
>
>
> We did agree that, and I'm happy to do that provided we can keep a branch
> for 7.0.x to maintain it. Unless anyone throws an objection on that in the
> next couple of hours, I'll switch that over today. I think it has been
> discussed plenty.
>
>
> > Also not sure we
> > want the 7.1 (we didnt finish the discussion IIRC).
> >
>
> I'm sure we want the MP stuff in TomEE 8 as well, but I'd be in favour of a
> TomEE 7.1 also.
>
>
> >
> > As a side note: geronimo is MP complete (yes I didnt resist to the joke)
> so
> > maybe time to just import it all?
> >
>
> I'd certainly be happy to give that a go.
>
> Jon
>
>
> >
> > Romain
> >
> >
> > Le jeu. 26 juil. 2018 01:26, Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> a écrit :
> >
> > > Awesome, thanks Roberto!
> > >
> > > On Wed, Jul 25, 2018 at 7:16 PM, Roberto Cortez
> > >  > > > wrote:
> > >
> > > > Hi everyone,
> > > > I've picked up some of the work started by JL on the tomee-7.1.x
> branch
> > > to
> > > > have a release with some MP support.
> > > > I've updated the branch with the latest 7.0.5 code, plus, fixed some
> > > > issues with the MP Configuration and MP JWT integration.
> > > > I've opened the following PR:https://github.com/apache/
> tomee/pull/138
> > > >
> > > > Hope it is ok.
> > > > Cheers,Roberto
> > >
> >
>

Re: Closing JIRA Issues

[Jean-Louis Monteiro]

Have you done a first round on the JIRAs?


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Tue, Jul 24, 2018 at 10:07 PM, Gurkan Erdogdu 
wrote:

> Hi team,
> Could you please go over the current JIRA issues and update them according
> to the latest status? (i.e Change their state as Close, Not Fix, or Update
> the Fix for version).
> Regards.
> Gurkan
>

Re: [VOTE] Release Apache TomEE 7.0.5 (round 2)

[Jean-Louis Monteiro]

+1 to go as it is.
We can release again when Tomcat is ready and then also include some
feedback


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

On Thu, Jul 12, 2018 at 3:30 PM, Matthew Broadhead <
matthew.broadh...@nbmlaw.co.uk.invalid> wrote:

> +1 for a release as it is
>
> but shouldn't it be released with 8.5.31 if there are objections? it was
> quite unlucky that you had just run a release cycle when Gurkan realised
> the issue.  so hopefully there won't be any more objections this time...
>
>
> On 12/07/18 12:24, Jonathan Gallimore wrote:
>
>> I currently have:
>>
>> 1 +1 for the release as it is (Romain)
>> 3 requests for a release with Tomcat 8.5.31 (Gurkan, Felipe, and Alex
>> (Alex
>> replied to me directly))
>>
>> Is anyone -1 for a TomEE 7.0.5 release built on Tomcat 8.5.31? Please
>> speak
>> up now if you do object so we can talk about it more on the list here.
>> From
>> my own perspective, I'm ok with the release as it is, and I'd also +1 a
>> 7.0.5 release with Tomcat 8.5.31 provided it didn't have other issues.
>>
>> I'll look to re-roll the release again later today, unless someone
>> objects.
>>
>> Many thanks everyone.
>>
>> Jon
>>
>> On Wed, Jul 11, 2018 at 1:17 AM, Gurkan Erdogdu 
>> wrote:
>>
>> Hi Jon
>>> Thanks for initiating this.
>>> I opened a bug in Tomcat regarding java:/ namespace and it will be
>>> corrected in 8.5.33 and upper versions. If we distribute the TomEE with
>>> 8.5.32, it will be a problem for users who uses lookups with openejb. So,
>>> for this release we can stick to 8.5.31. WDYT?
>>> Regards.
>>> Gurkan
>>>
>>>
>>> On Tue, Jul 10, 2018 at 9:26 PM, Jonathan Gallimore <
>>> jonathan.gallim...@gmail.com> wrote:
>>>
>>> Hi Everyone,
>>>>
>>>> Here is the second roll of TomEE 7.0.5. Please can you take a look and
>>>> vote? Everyone, committer or not, is encouraged to test and vote.
>>>>
>>>> Staging repo:
>>>> https://repository.apache.org/content/repositories/orgapachetomee-1115
>>>>
>>>> Source zip:
>>>> https://repository.apache.org/content/repositories/
>>>> orgapachetomee-1115/org/apache/tomee/tomee-project/7.
>>>> 0.5/tomee-project-7.0.5-source-release.zip
>>>>
>>>> Dist area:
>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1115/
>>>>
>>>> Legal:
>>>> https://dist.apache.org/repos/dist/dev/tomee/staging-1115/legal.zip
>>>>
>>>> Keys:
>>>> https://dist.apache.org/repos/dist/release/tomee/KEYS
>>>>
>>>> Libraries changed since TomEE 7.0.4:
>>>>
>>>> Tomcat => 8.5.32
>>>> CXF => 3.1.15
>>>> Johnzon => 1.0.1
>>>> OWB => 1.7.5
>>>> XBean => 4.9
>>>> XmlSchema core => 2.2.3
>>>> OpenJPA => 2.4.3
>>>>
>>>> Changes since the last roll:
>>>>
>>>> - Remove javax.xml.soap-api-1.3.5.jar library which was incorrectly
>>>> included
>>>> - Update to Tomcat 8.5.32
>>>> - Change JNDI name used for datasource in CDI TCK test to use an
>>>>
>>> equivalent
>>>
>>>> name under the java: namespace
>>>>
>>>> Changelog:
>>>> https://issues.apache.org/jira/browse/TOMEE-2175?jql=project
>>>> %20%3D%20TOMEE%20AND%20(status%20%3D%20Resolved%20OR%20statu
>>>> s%20%3D%20CLOSED)%20AND%20fixVersion%20%3D%207.0.5%20O
>>>> RDER%20BY%20priority%20DESC%2C%20updated%20DESC
>>>>
>>>> (If anyone knows a better way to get that list, let me know ;-) )
>>>>
>>>> Please vote:
>>>>   +1: Release
>>>>   -1 Do not release because ...
>>>>
>>>> The vote will be open for 3 days or the consensus is binding (At least 3
>>>> binding votes).
>>>>
>>>> Many thanks
>>>>
>>>> Jon
>>>>
>>>>
>