GWT 2.8 with Java 7
Those are warnings, and should not break the build (unless maybe you use -strict). Ideally the GWT compiler should be run with java 8, but you can compile (JavaC) your classes with java 7 and deploy gwt-servlet to a 1.7 JVM. -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
GWT 2.8 with Java 7
Can a GWT 2.8 project still be run with Java 7? I have it working with beta1, but not any of the release candidates or the final release? When I do try to use anything beyond GWT beta1, I receive a series of errors similar to the below statement [WARN] Ignoring unresolvable annotation type java.lang.FunctionalInterface -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Re: GWT 2.8 with App Engine on Java 7
I've had the same problem - was using GWT 2.8 and playing with a few lambdas and such in my GWT code, and even though there was no Java 8 code in my /server package, something (probably the target version in the pom.xml) stopped the maven plugin from deploying, so I had to revert. Fingers crossed they get round to Java 8 sooner rather than later! On Thursday, 10 March 2016 16:06:47 UTC, Paul Mazzuca wrote: > > Thanks as alway for the prompt response. I went ahead and reverted to > Java 7 (while still using GWT 2.8) as the quick solution, with Google > Guava for some more advanced Java 8 like APIs. After some cursory > research, I believe the GAE sandbox will be supporting Java 8 at some point > this year, so hopefully the wait won't be too long, at which point I will > use Java 8 across the board. > > I am still going to explore the Toolchains option though. Having more of > a clear separation between the client and server may make things easier, at > least in my case. If I get it working, I will share the pom. Thanks > again for all the GWT support. > > On Thu, Mar 10, 2016 at 12:41 AM, Thomas Broyer <t.br...@gmail.com > > wrote: > >> GWT 2.8 should support JDK 7, but if you want to use Java 8 features then >> indeed you need to use a JDK 8 to JavaC your classes. >> >> You could possibly exclude your client code from being compiled with >> JavaC, and only processed by GWT. >> >> Alternatives I can think of are: >> - use Maven Toolchains to use JDK 7 and JDK 8 in the same build; >> - use JDK 8 and retrolambda: https://github.com/orfjackal/retrolambda >> - split your code into 2 projects/modules, compiled in 2 phases: mvn >> install the client code with JDK8, then mvn appengine:update the server >> code with JDK7, which has a dependency in the client code (resolved from >> local Maven repo). >> >> The cleaner solution IMO is to use separate JDKs (or proper >> cross-compilation, with bootclasspath et al); either with toolchains or >> separate build phases. Retrolambda would need some testing in a Java 7 >> environment to confirm the transformation went well. >> >> Also, Animal Sniffer on your server code would help, in case you don't >> compile it with a JDK7. >> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "GWT Users" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/google-web-toolkit/cK12H59iY0Y/unsubscribe >> . >> To unsubscribe from this group and all its topics, send an email to >> google-web-toolkit+unsubscr...@googlegroups.com . >> To post to this group, send email to google-we...@googlegroups.com >> . >> Visit this group at https://groups.google.com/group/google-web-toolkit. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Re: GWT 2.8 with App Engine on Java 7
Thanks as alway for the prompt response. I went ahead and reverted to Java 7 (while still using GWT 2.8) as the quick solution, with Google Guava for some more advanced Java 8 like APIs. After some cursory research, I believe the GAE sandbox will be supporting Java 8 at some point this year, so hopefully the wait won't be too long, at which point I will use Java 8 across the board. I am still going to explore the Toolchains option though. Having more of a clear separation between the client and server may make things easier, at least in my case. If I get it working, I will share the pom. Thanks again for all the GWT support. On Thu, Mar 10, 2016 at 12:41 AM, Thomas Broyer <t.bro...@gmail.com> wrote: > GWT 2.8 should support JDK 7, but if you want to use Java 8 features then > indeed you need to use a JDK 8 to JavaC your classes. > > You could possibly exclude your client code from being compiled with > JavaC, and only processed by GWT. > > Alternatives I can think of are: > - use Maven Toolchains to use JDK 7 and JDK 8 in the same build; > - use JDK 8 and retrolambda: https://github.com/orfjackal/retrolambda > - split your code into 2 projects/modules, compiled in 2 phases: mvn > install the client code with JDK8, then mvn appengine:update the server > code with JDK7, which has a dependency in the client code (resolved from > local Maven repo). > > The cleaner solution IMO is to use separate JDKs (or proper > cross-compilation, with bootclasspath et al); either with toolchains or > separate build phases. Retrolambda would need some testing in a Java 7 > environment to confirm the transformation went well. > > Also, Animal Sniffer on your server code would help, in case you don't > compile it with a JDK7. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GWT Users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/google-web-toolkit/cK12H59iY0Y/unsubscribe > . > To unsubscribe from this group and all its topics, send an email to > google-web-toolkit+unsubscr...@googlegroups.com. > To post to this group, send email to google-web-toolkit@googlegroups.com. > Visit this group at https://groups.google.com/group/google-web-toolkit. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
GWT 2.8 with App Engine on Java 7
GWT 2.8 should support JDK 7, but if you want to use Java 8 features then indeed you need to use a JDK 8 to JavaC your classes. You could possibly exclude your client code from being compiled with JavaC, and only processed by GWT. Alternatives I can think of are: - use Maven Toolchains to use JDK 7 and JDK 8 in the same build; - use JDK 8 and retrolambda: https://github.com/orfjackal/retrolambda - split your code into 2 projects/modules, compiled in 2 phases: mvn install the client code with JDK8, then mvn appengine:update the server code with JDK7, which has a dependency in the client code (resolved from local Maven repo). The cleaner solution IMO is to use separate JDKs (or proper cross-compilation, with bootclasspath et al); either with toolchains or separate build phases. Retrolambda would need some testing in a Java 7 environment to confirm the transformation went well. Also, Animal Sniffer on your server code would help, in case you don't compile it with a JDK7. -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Re: GWT 2.8 with App Engine on Java 7
"mvn appengine:update" abstracts most of the packaging and compiling, so I am unsure where that separation would need to be implemented. I will check it out though. Thanks. On Wed, Mar 9, 2016 at 11:59 AM, Michael Joyner <mich...@newsrx.com> wrote: > Is there any reason you can't split the project up into two projects? A > java8 => js frontend, and the java7 backend? > > On 03/09/2016 02:57 PM, Paul Mazzuca wrote: > > Using the maven gwt and appengine plugins, is it possible to compile GWT > 2.8 in Java 8, and then app engine related files using Java 7? I realize > the managed VMs support Java 8, but it would be nice to stick with the app > engine environment which currently only support Java 7? > > I am wondering if there exists some maven configuration that would first > compile all the GWT files in Java 8, thereby converting them to javascript, > and then use java 7 for all the server files. > -- > You received this message because you are subscribed to the Google Groups > "GWT Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit+unsubscr...@googlegroups.com. > To post to this group, send email to google-web-toolkit@googlegroups.com. > Visit this group at https://groups.google.com/group/google-web-toolkit. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to a topic in the > Google Groups "GWT Users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/google-web-toolkit/cK12H59iY0Y/unsubscribe > . > To unsubscribe from this group and all its topics, send an email to > google-web-toolkit+unsubscr...@googlegroups.com. > To post to this group, send email to google-web-toolkit@googlegroups.com. > Visit this group at https://groups.google.com/group/google-web-toolkit. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Re: GWT 2.8 with App Engine on Java 7
Is there any reason you can't split the project up into two projects? A java8 => js frontend, and the java7 backend? On 03/09/2016 02:57 PM, Paul Mazzuca wrote: Using the maven gwt and appengine plugins, is it possible to compile GWT 2.8 in Java 8, and then app engine related files using Java 7? I realize the managed VMs support Java 8, but it would be nice to stick with the app engine environment which currently only support Java 7? I am wondering if there exists some maven configuration that would first compile all the GWT files in Java 8, thereby converting them to javascript, and then use java 7 for all the server files. -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com <mailto:google-web-toolkit+unsubscr...@googlegroups.com>. To post to this group, send email to google-web-toolkit@googlegroups.com <mailto:google-web-toolkit@googlegroups.com>. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
GWT 2.8 with App Engine on Java 7
Using the maven gwt and appengine plugins, is it possible to compile GWT 2.8 in Java 8, and then app engine related files using Java 7? I realize the managed VMs support Java 8, but it would be nice to stick with the app engine environment which currently only support Java 7? I am wondering if there exists some maven configuration that would first compile all the GWT files in Java 8, thereby converting them to javascript, and then use java 7 for all the server files. -- You received this message because you are subscribed to the Google Groups "GWT Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at https://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
It is true that GIN is kind of unmaintained. There has been some internal patches but nobody bothered moving the project out of Google code and export those due to initial overhead. Bu regardless, right now GIN uses reflection with a ClassLoader hack to access types. And at least some code visible by GIN will be compiled by JDT (e.g. super-source code, classes generated by other generators etc.) so it will see java8 byte code (hence the error). I don't see a practical way to make GIN work in a JDK 7 environment. If there are other similar generators, they will not work in JDK7 as well but I don't believe there are many like that. On Thu, Feb 18, 2016 at 9:51 AM, Thomas Broyer <t.bro...@gmail.com> wrote: > > > On Thursday, February 18, 2016 at 6:29:22 PM UTC+1, Jens wrote: >> >> >> Isn't GIN unmaintained anyway? >>> >> (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) >>> >> >> I don't know. GIN works well and a ton of apps use it. >> > > Well, at least it's not actively developed: with the last version released > nearly 2.5 years ago, the last commit exactly two years ago tomorrow (on > the Ant build, so without the need to re-release), and more importantly > with the repository being archived on Google Code Hosting and not migrated > to GitHub. > That sounds like "unmaintained" to me. > > >> A lot of these apps will probably not migrate to Dagger 2 anytime soon >> (especially not if it takes ages for a PR to be accepted). >> > > So they probably won't migrate to GWT 2.8 either. > > >> Anyways any generator that tries to load JDT generated classes while >> being executed with Java 7 will fail. >> > > Just like when "-sourceLevel 7" was added a few years back; except that > at the time it would break DevMode also (it still does, the difference > being that nobody will use it anymore). > > >> I wouldn't bet that GIN is the only library affected. I just wanted to >> note that the current situation is not "GWT 2.8 is fully compatible to Java >> 7", its more like "GWT 2.8 might work with Java 7 depending on the library >> you use" which is kind of a bad statement. >> > > What GIN does with the classloader is clearly a hack, people using hacks > shouldn't complain when the hacks stop working (remember CSS hacks?) > > YMMV. > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/eb227511-e93a-434d-9d1f-08784d75f4a9%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/eb227511-e93a-434d-9d1f-08784d75f4a9%40googlegroups.com?utm_medium=email_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3P043Po3XpfD-FikDc8tMZjH0Xx0_QA5SzfxBSTC-YKg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
That's fair. I wasn't expecting much need either but just wanted a simpler way out if it ended up being important for the community. On Wed, Feb 17, 2016 at 11:57 PM, Manuel Carrasco Moñino <man...@apache.org> wrote: > I follow, but I have a couple of thoughts > > - Is it actually useful from the user perspective to use a sourceLevel=1.7 > if he has to manually provide a compatible gwt-jre-emulation? > IMO, he might want that everything works out-of-the-boxy. Right now, gwt > emul classes in the 2.8-snapshot make fail sourceLevel=1.7 though, so I > don't see any reason to deliver gwt-2.8.0 with a non working flag. > > - IMHO, for real users having to code in 1.7, it's not a problem to set > javac.source=1.7 and have gwtc.sourceLevel=default=1.8. In this case the > javac compiler will validate his source code and gwtc compiler does not > need to do the validation, it simply works without raising any error when > processing its internal jre-emul classes. > > So, since gwtc can be run with a sdk7 (even with gwt java8 sources), there > should not be any problem compiling gwt projects written in java7 and > compiled with sdk7, and the user does not bother about the sourceLevel flag. > > > > On Wed, Feb 17, 2016 at 9:13 PM, 'Goktug Gokdogan' via GWT Contributors < > google-web-toolkit-contributors@googlegroups.com> wrote: > >> I think you didn't understand what I said. Let me try to clarify: >> >> "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >> source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it >> by supplying *a java7 compatible JRE emulation* without any compiler/SDK >> changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't >> originally remove Java7 option from the SourceLevel flag. >> By removing the flag (which seems submitted now), the community will not >> have that option *(i.e. they need also supply a modified compiler >> together with the emulation)*." >> >> This may never happen but keeping the flag was cheap so I kept it. >> >> On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino < >> man...@apache.org> wrote: >> >>> Removing the 1.7 flag does not make the compiler fail when using a java7 >>> sdk. >>> Now the compiler always thinks that source code is sourced-level 1.8 so >>> it does not fail when looking at java8 emul classes. >>> >>> You can still have the java.source property set to 1.7 when compiling >>> your project and javac will validate that your code is java7 compliant, >>> because javac process your client code. >>> >>> In summary javac and gwtc could use at the same time different source >>> languages, but we always need to force gwtc to use 1.8 since new java8 api >>> emul code. >>> >>> >>> On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors >>> <google-web-toolkit-contributors@googlegroups.com> wrote: >>> >>>> To remind the backlog of this: >>>> >>>> GWT 2.8 decided to support only Java8 source level (see related threads >>>> from last year) as the emulation will include Java 8 APIs which cannot be >>>> compiled in Java7 mode. >>>> >>>> However, GWT compiler itself is intended to be runnable in a Java 7 >>>> JVM. This should enable slow-to-upgrade enterprises business to keep their >>>> legacy dev environments. >>>> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>>> source level, they can theoretically do it by supplying a java7 compatible >>>> JRE emulation without any compiler/SDK changes. That's why I didn't >>>> originally remove Java7 option from the SourceLevel flag. >>>> By removing the flag (which seems submitted now), the community will >>>> not have that option. >>>> >>>> (It is not import from Google side; just wanted to let you know if the >>>> community cares about it.) >>>> >>>> On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>>>>> Moñino wrote: >>>>>>> >>>>>>> Thomas, I want to experiment with this, pls, could you give me some >>>>>>>
Re: [gwt-contrib] Re: Compiler failing with java 7
On Thursday, February 18, 2016 at 6:29:22 PM UTC+1, Jens wrote: > > > Isn't GIN unmaintained anyway? >> > (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) >> > > I don't know. GIN works well and a ton of apps use it. > Well, at least it's not actively developed: with the last version released nearly 2.5 years ago, the last commit exactly two years ago tomorrow (on the Ant build, so without the need to re-release), and more importantly with the repository being archived on Google Code Hosting and not migrated to GitHub. That sounds like "unmaintained" to me. > A lot of these apps will probably not migrate to Dagger 2 anytime soon > (especially not if it takes ages for a PR to be accepted). > So they probably won't migrate to GWT 2.8 either. > Anyways any generator that tries to load JDT generated classes while being > executed with Java 7 will fail. > Just like when "-sourceLevel 7" was added a few years back; except that at the time it would break DevMode also (it still does, the difference being that nobody will use it anymore). > I wouldn't bet that GIN is the only library affected. I just wanted to > note that the current situation is not "GWT 2.8 is fully compatible to Java > 7", its more like "GWT 2.8 might work with Java 7 depending on the library > you use" which is kind of a bad statement. > What GIN does with the classloader is clearly a hack, people using hacks shouldn't complain when the hacks stop working (remember CSS hacks?) YMMV. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/eb227511-e93a-434d-9d1f-08784d75f4a9%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
On Wednesday, February 17, 2016 at 9:13:43 PM UTC+1, Goktug Gokdogan wrote: > > I think you didn't understand what I said. Let me try to clarify: > > "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 > source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it by > supplying *a java7 compatible JRE emulation* without any compiler/SDK > changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't > originally remove Java7 option from the SourceLevel flag. > By removing the flag (which seems submitted now), the community will not > have that option *(i.e. they need also supply a modified compiler > together with the emulation)*." > > This may never happen but keeping the flag was cheap so I kept it. > Thanks for the reminder Goktug. We had a quick discussion with Manolo about whether we should remove the -sourceLevel entirely, remove the 1.7 value only (only keeping 1.8), or "aliasing" 1.7 to 1.8 (with a warning). The immediate goal was to make it possible to build GWT with a JDK 7. Things can still change back. Let's see what we had and we could have (incl. what we have now): The problem we were having is that -sourceLevel defaulted to the level of the Java version being used to run GWTC, and defaulting to 7 as a last resort, which means that with a Java 7 (or 6) VM you'd have to pass "-sourceLevel 8" to make it work with the new Java 8-only emul. We have (had) several options: - leave it like that, forcing every Java 7 user to explicitly pass "-sourceLevel 8". They'd see it as a breaking change (which it could be, according to Daniel in this thread) and wouldn't understand why there's a "7" value that doesn't work. As a user, I'd probably see it as a bug. - change the default value to Java 8 (independently of the current JVM). This is backwards-compatible with people passing "-sourceLevel 8", breaking those passing "-sourceLevel 7" with cryptic errors due to GWT being incapable of compiling the Java 8-only emul, and "transparently upgrades" others to sourceLevel 8. - remove the "7" value, only leaving "8" as a valid value. Given that the default value depends on the current JVM and always has a valid fallback, that means GWT always uses Java 8, but starts to fail if you pass a sourceLevel with a value different from 8 or 1.8. This is backwards-compatible with people passing "-sourceLevel 8", breaking those passing "-sourceLevel 7" with an explicit error that this value is not supported, and "transparently upgrades" others to sourceLevel 8. This is what we did. - remove the -sourceLevel flag entirely; this would break many, many people; including those passing a "compatible" sourceLevel value. - alias the "-sourceLevel 7" to "-sourceLevel 8". In many cases this wouldn't break builds, except for those cases where people run into differences between Java 7 and Java 8, as Daniel mentioned. Those people possibly won't understand why their explicit "-sourceLevel 7" isn't honored (even if we issue a warning). - deprecate -sourceLevel and make it a no-op. This "transparently upgrades" everyone to Java 8, and is similar to the above case where "-sourceLevel 7" is aliased to "-sourceLevel 8" I think we chose the "least bad" of those options, by being explicit. People using Java 7 *and* using an explicit sourceLevel should be aware that JavaC and GWTC would use different rules, so let's force them to be extra-explicit. Note that whether you pass -sourceLevel or not, and with which value depends on how you call GWTC: In Maven, you have to configure your project with an explicit source level version (even for JavaC) unless you're OK with Java 1.4 or 1.5 (depending on the version of the maven-compiler-plugin, whose default version depends on the version of Maven you're using), and depending on how you configure it, it could instruct the gwt-maven-plugin (both flavors) to pass an explicit -sourceLevel to GWTC. This would break people using Java 7. In other words, it's quite likely that many projects (but far from all) have a configured (possibly implicitly) sourceLevel matching their JavaC source level. Gradle (gwt-gradle-plugin) only passes a sourceLevel if configured explicitly (through a specific property), independently of the source level configured for JavaC. Others (Ant, Buck, etc.) probably have to pass arguments explicitly. I have no idea what IDEs (Eclipse, IntelliJ) do. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolk
Re: [gwt-contrib] Re: Compiler failing with java 7
> Isn't GIN unmaintained anyway? > (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) > I don't know. GIN works well and a ton of apps use it. A lot of these apps will probably not migrate to Dagger 2 anytime soon (especially not if it takes ages for a PR to be accepted). Anyways any generator that tries to load JDT generated classes while being executed with Java 7 will fail. I wouldn't bet that GIN is the only library affected. I just wanted to note that the current situation is not "GWT 2.8 is fully compatible to Java 7", its more like "GWT 2.8 might work with Java 7 depending on the library you use" which is kind of a bad statement. -- J. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/9e6107b4-143b-4f22-839b-f745dc8867c3%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
Isn't GIN unmaintained anyway? (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) On Thursday, February 18, 2016 at 1:20:34 PM UTC+1, Jens wrote: > > Seems like GWT apps that use GIN will still require Java 8. I just tried > latest master from today using Guava 20-SNAPSHOT, Gin 2.1.2, Guice 4. > > When we compile our app using JDK 1.7 and -sourceLevel 1.8 for GWT > compiler we get warnings for all java.util.function.* emulated classes that > reference java.lang.FunctionalInterface, e.g. > > Resolving java.util.Objects > Found type 'java.util.Objects' >Resolving method requireNonNull > Found type 'java.util.function.Supplier' > [WARN] Ignoring unresolvable annotation type > java.lang.FunctionalInterface > Resolving java.util.Optional > Found type 'java.util.Optional' >Resolving method ifPresent > Found type 'java.util.function.Consumer' > [WARN] Ignoring unresolvable annotation type > java.lang.FunctionalInterface >Resolving method filter > > > Thats not really nice for a potential final release of GWT. > > But the real issue is GIN as it fails with unsupported major.minor version > 52.0: > > Caused by: java.lang.UnsupportedClassVersionError: > xx/xx/xx/xx/SomeGinjector : Unsupported major.minor version 52.0 > at java.lang.ClassLoader.defineClass1(Native Method) > at java.lang.ClassLoader.defineClass(ClassLoader.java:800) > at java.lang.ClassLoader.defineClass(ClassLoader.java:643) > at > com.google.gwt.inject.rebind.GinBridgeClassLoader.findClass(GinBridgeClassLoader.java:160) > at > com.google.gwt.inject.rebind.GinBridgeClassLoader.loadClass(GinBridgeClassLoader.java:106) > at java.lang.ClassLoader.loadClass(ClassLoader.java:358) > at java.lang.Class.forName0(Native Method) > at java.lang.Class.forName(Class.java:278) > at > com.google.gwt.inject.rebind.GinjectorGenerator.loadClass(GinjectorGenerator.java:223) > at > com.google.gwt.inject.rebind.GinjectorGenerator.getGinjectorType(GinjectorGenerator.java:104) > at > com.google.gwt.inject.rebind.GinjectorGenerator.generate(GinjectorGenerator.java:60) > at > com.google.gwt.core.ext.IncrementalGenerator.generateNonIncrementally(IncrementalGenerator.java:40) > at > com.google.gwt.dev.javac.StandardGeneratorContext.runGeneratorIncrementally(StandardGeneratorContext.java:745) > at > com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:103) > at > com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebindOracle.java:78) > at > com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.java:262) > at > com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.java:251) > at > com.google.gwt.dev.PrecompilationContextCreator$1.getAllPossibleRebindAnswers(PrecompilationContextCreator.java:86) > > > Looks like GIN, executed with JDK 7, loads a class generated by JDT in > Java8 mode. Not sure if that can be fixed in GIN. For now we will use > master branch without the first Java 8 commits. > > So I guess if we want GWT 2.8 to be fully JDK 7 compatible we have to > revert Java 8 commits and reintroduce -sourceLevel 1.7. However that would > mean we would need to release GWT 2.9 with Java 8 only support in a couple > of month at the time Guava 21 will be released (mid 2016, requires Java 8). > So I am not sure if its worth it to buy people a couple of extra month of > 1.7 support. > > Alternatively we could also make two releases 2.7.1 and 2.8 with 2.7.1 > containing everything of 2.8 up until the first Java 8 commit. Then 2.7.1 > will be Java 7 compatible and has lots of bug fixes while 2.8 is Java 8 > only and contains only a couple more commits. > > -- J. > > > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/2ede1376-6d7b-47c8-b4db-8df55c1ef646%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
Agree, there are some corner cases, but normally gwt developers have to deal with a bunch of differences between java and gwt. Anyway I think that it's better that SDK7 users assume some language issues than not be able to compile their projects at all. On Thu, Feb 18, 2016 at 10:17 AM, 'Daniel Kurka' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > We have seen issues internally where some code would be a compile error in > Java8 but not in Java7 (especially around type checking). This setup will > leave users vulnerable to this since their code will compile in their IDE, > but will fail GWT compile. > > On Thu, Feb 18, 2016 at 8:57 AM Manuel Carrasco Moñino <man...@apache.org> > wrote: > >> I follow, but I have a couple of thoughts >> >> - Is it actually useful from the user perspective to use a >> sourceLevel=1.7 if he has to manually provide a compatible >> gwt-jre-emulation? >> IMO, he might want that everything works out-of-the-boxy. Right now, gwt >> emul classes in the 2.8-snapshot make fail sourceLevel=1.7 though, so I >> don't see any reason to deliver gwt-2.8.0 with a non working flag. >> >> - IMHO, for real users having to code in 1.7, it's not a problem to set >> javac.source=1.7 and have gwtc.sourceLevel=default=1.8. In this case the >> javac compiler will validate his source code and gwtc compiler does not >> need to do the validation, it simply works without raising any error when >> processing its internal jre-emul classes. >> >> So, since gwtc can be run with a sdk7 (even with gwt java8 sources), >> there should not be any problem compiling gwt projects written in java7 and >> compiled with sdk7, and the user does not bother about the sourceLevel flag. >> >> >> >> On Wed, Feb 17, 2016 at 9:13 PM, 'Goktug Gokdogan' via GWT Contributors < >> google-web-toolkit-contributors@googlegroups.com> wrote: >> >>> I think you didn't understand what I said. Let me try to clarify: >>> >>> "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>> source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it >>> by supplying *a java7 compatible JRE emulation* without any >>> compiler/SDK changes *(but just setting the gwtc sourcelevel 7)*. >>> That's why I didn't originally remove Java7 option from the SourceLevel >>> flag. >>> By removing the flag (which seems submitted now), the community will not >>> have that option *(i.e. they need also supply a modified compiler >>> together with the emulation)*." >>> >>> This may never happen but keeping the flag was cheap so I kept it. >>> >>> On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino < >>> man...@apache.org> wrote: >>> >>>> Removing the 1.7 flag does not make the compiler fail when using a >>>> java7 sdk. >>>> Now the compiler always thinks that source code is sourced-level 1.8 so >>>> it does not fail when looking at java8 emul classes. >>>> >>>> You can still have the java.source property set to 1.7 when compiling >>>> your project and javac will validate that your code is java7 compliant, >>>> because javac process your client code. >>>> >>>> In summary javac and gwtc could use at the same time different source >>>> languages, but we always need to force gwtc to use 1.8 since new java8 api >>>> emul code. >>>> >>>> >>>> On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors >>>> <google-web-toolkit-contributors@googlegroups.com> wrote: >>>> >>>>> To remind the backlog of this: >>>>> >>>>> GWT 2.8 decided to support only Java8 source level (see related >>>>> threads from last year) as the emulation will include Java 8 APIs which >>>>> cannot be compiled in Java7 mode. >>>>> >>>>> However, GWT compiler itself is intended to be runnable in a Java 7 >>>>> JVM. This should enable slow-to-upgrade enterprises business to keep their >>>>> legacy dev environments. >>>>> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>>>> source level, they can theoretically do it by supplying a java7 compatible >>>>> JRE emulation without any compiler/SDK changes. That's why I didn't >>>>> originally remove Java7 option from the SourceLevel flag. >>>>> By removing the flag (which seems submitted now), th
Re: [gwt-contrib] Re: Compiler failing with java 7
We have seen issues internally where some code would be a compile error in Java8 but not in Java7 (especially around type checking). This setup will leave users vulnerable to this since their code will compile in their IDE, but will fail GWT compile. On Thu, Feb 18, 2016 at 8:57 AM Manuel Carrasco Moñino <man...@apache.org> wrote: > I follow, but I have a couple of thoughts > > - Is it actually useful from the user perspective to use a sourceLevel=1.7 > if he has to manually provide a compatible gwt-jre-emulation? > IMO, he might want that everything works out-of-the-boxy. Right now, gwt > emul classes in the 2.8-snapshot make fail sourceLevel=1.7 though, so I > don't see any reason to deliver gwt-2.8.0 with a non working flag. > > - IMHO, for real users having to code in 1.7, it's not a problem to set > javac.source=1.7 and have gwtc.sourceLevel=default=1.8. In this case the > javac compiler will validate his source code and gwtc compiler does not > need to do the validation, it simply works without raising any error when > processing its internal jre-emul classes. > > So, since gwtc can be run with a sdk7 (even with gwt java8 sources), there > should not be any problem compiling gwt projects written in java7 and > compiled with sdk7, and the user does not bother about the sourceLevel flag. > > > > On Wed, Feb 17, 2016 at 9:13 PM, 'Goktug Gokdogan' via GWT Contributors < > google-web-toolkit-contributors@googlegroups.com> wrote: > >> I think you didn't understand what I said. Let me try to clarify: >> >> "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >> source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it >> by supplying *a java7 compatible JRE emulation* without any compiler/SDK >> changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't >> originally remove Java7 option from the SourceLevel flag. >> By removing the flag (which seems submitted now), the community will not >> have that option *(i.e. they need also supply a modified compiler >> together with the emulation)*." >> >> This may never happen but keeping the flag was cheap so I kept it. >> >> On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino < >> man...@apache.org> wrote: >> >>> Removing the 1.7 flag does not make the compiler fail when using a java7 >>> sdk. >>> Now the compiler always thinks that source code is sourced-level 1.8 so >>> it does not fail when looking at java8 emul classes. >>> >>> You can still have the java.source property set to 1.7 when compiling >>> your project and javac will validate that your code is java7 compliant, >>> because javac process your client code. >>> >>> In summary javac and gwtc could use at the same time different source >>> languages, but we always need to force gwtc to use 1.8 since new java8 api >>> emul code. >>> >>> >>> On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors >>> <google-web-toolkit-contributors@googlegroups.com> wrote: >>> >>>> To remind the backlog of this: >>>> >>>> GWT 2.8 decided to support only Java8 source level (see related threads >>>> from last year) as the emulation will include Java 8 APIs which cannot be >>>> compiled in Java7 mode. >>>> >>>> However, GWT compiler itself is intended to be runnable in a Java 7 >>>> JVM. This should enable slow-to-upgrade enterprises business to keep their >>>> legacy dev environments. >>>> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>>> source level, they can theoretically do it by supplying a java7 compatible >>>> JRE emulation without any compiler/SDK changes. That's why I didn't >>>> originally remove Java7 option from the SourceLevel flag. >>>> By removing the flag (which seems submitted now), the community will >>>> not have that option. >>>> >>>> (It is not import from Google side; just wanted to let you know if the >>>> community cares about it.) >>>> >>>> On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>>>>> Moñino wrote: >>>>>>> >>>>
Re: [gwt-contrib] Re: Compiler failing with java 7
I follow, but I have a couple of thoughts - Is it actually useful from the user perspective to use a sourceLevel=1.7 if he has to manually provide a compatible gwt-jre-emulation? IMO, he might want that everything works out-of-the-boxy. Right now, gwt emul classes in the 2.8-snapshot make fail sourceLevel=1.7 though, so I don't see any reason to deliver gwt-2.8.0 with a non working flag. - IMHO, for real users having to code in 1.7, it's not a problem to set javac.source=1.7 and have gwtc.sourceLevel=default=1.8. In this case the javac compiler will validate his source code and gwtc compiler does not need to do the validation, it simply works without raising any error when processing its internal jre-emul classes. So, since gwtc can be run with a sdk7 (even with gwt java8 sources), there should not be any problem compiling gwt projects written in java7 and compiled with sdk7, and the user does not bother about the sourceLevel flag. On Wed, Feb 17, 2016 at 9:13 PM, 'Goktug Gokdogan' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > I think you didn't understand what I said. Let me try to clarify: > > "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 > source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it by > supplying *a java7 compatible JRE emulation* without any compiler/SDK > changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't > originally remove Java7 option from the SourceLevel flag. > By removing the flag (which seems submitted now), the community will not > have that option *(i.e. they need also supply a modified compiler > together with the emulation)*." > > This may never happen but keeping the flag was cheap so I kept it. > > On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino < > man...@apache.org> wrote: > >> Removing the 1.7 flag does not make the compiler fail when using a java7 >> sdk. >> Now the compiler always thinks that source code is sourced-level 1.8 so >> it does not fail when looking at java8 emul classes. >> >> You can still have the java.source property set to 1.7 when compiling >> your project and javac will validate that your code is java7 compliant, >> because javac process your client code. >> >> In summary javac and gwtc could use at the same time different source >> languages, but we always need to force gwtc to use 1.8 since new java8 api >> emul code. >> >> >> On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors < >> google-web-toolkit-contributors@googlegroups.com> wrote: >> >>> To remind the backlog of this: >>> >>> GWT 2.8 decided to support only Java8 source level (see related threads >>> from last year) as the emulation will include Java 8 APIs which cannot be >>> compiled in Java7 mode. >>> >>> However, GWT compiler itself is intended to be runnable in a Java 7 JVM. >>> This should enable slow-to-upgrade enterprises business to keep their >>> legacy dev environments. >>> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >>> source level, they can theoretically do it by supplying a java7 compatible >>> JRE emulation without any compiler/SDK changes. That's why I didn't >>> originally remove Java7 option from the SourceLevel flag. >>> By removing the flag (which seems submitted now), the community will not >>> have that option. >>> >>> (It is not import from Google side; just wanted to let you know if the >>> community cares about it.) >>> >>> On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> >>> wrote: >>> >>>> >>>> >>>> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>>>> >>>>> >>>>> >>>>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>>>> Moñino wrote: >>>>>> >>>>>> Thomas, I want to experiment with this, pls, could you give me some >>>>>> advise what are the classes I have to look at? >>>>>> >>>>> >>>>> https://gwt-review.googlesource.com/14353 >>>>> (currently running the testsuite locally) >>>>> >>>> >>>> Tests pass \o/ >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to &
Re: [gwt-contrib] Re: Compiler failing with java 7
I think you didn't understand what I said. Let me try to clarify: "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it by supplying *a java7 compatible JRE emulation* without any compiler/SDK changes *(but just setting the gwtc sourcelevel 7)*. That's why I didn't originally remove Java7 option from the SourceLevel flag. By removing the flag (which seems submitted now), the community will not have that option *(i.e. they need also supply a modified compiler together with the emulation)*." This may never happen but keeping the flag was cheap so I kept it. On Tue, Feb 16, 2016 at 11:35 PM, Manuel Carrasco Moñino <man...@apache.org> wrote: > Removing the 1.7 flag does not make the compiler fail when using a java7 > sdk. > Now the compiler always thinks that source code is sourced-level 1.8 so it > does not fail when looking at java8 emul classes. > > You can still have the java.source property set to 1.7 when compiling your > project and javac will validate that your code is java7 compliant, because > javac process your client code. > > In summary javac and gwtc could use at the same time different source > languages, but we always need to force gwtc to use 1.8 since new java8 api > emul code. > > > On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors < > google-web-toolkit-contributors@googlegroups.com> wrote: > >> To remind the backlog of this: >> >> GWT 2.8 decided to support only Java8 source level (see related threads >> from last year) as the emulation will include Java 8 APIs which cannot be >> compiled in Java7 mode. >> >> However, GWT compiler itself is intended to be runnable in a Java 7 JVM. >> This should enable slow-to-upgrade enterprises business to keep their >> legacy dev environments. >> For any reason, if community wants to run the GWT 2.8 SDK in Java 7 >> source level, they can theoretically do it by supplying a java7 compatible >> JRE emulation without any compiler/SDK changes. That's why I didn't >> originally remove Java7 option from the SourceLevel flag. >> By removing the flag (which seems submitted now), the community will not >> have that option. >> >> (It is not import from Google side; just wanted to let you know if the >> community cares about it.) >> >> On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> >> wrote: >> >>> >>> >>> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>>> >>>> >>>> >>>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>>> Moñino wrote: >>>>> >>>>> Thomas, I want to experiment with this, pls, could you give me some >>>>> advise what are the classes I have to look at? >>>>> >>>> >>>> https://gwt-review.googlesource.com/14353 >>>> (currently running the testsuite locally) >>>> >>> >>> Tests pass \o/ >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com >>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com?utm_medium=email_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com?utm_medium=email_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the
Re: [gwt-contrib] Re: Compiler failing with java 7
Removing the 1.7 flag does not make the compiler fail when using a java7 sdk. Now the compiler always thinks that source code is sourced-level 1.8 so it does not fail when looking at java8 emul classes. You can still have the java.source property set to 1.7 when compiling your project and javac will validate that your code is java7 compliant, because javac process your client code. In summary javac and gwtc could use at the same time different source languages, but we always need to force gwtc to use 1.8 since new java8 api emul code. On Wed, Feb 17, 2016 at 2:32 AM, 'Goktug Gokdogan' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > To remind the backlog of this: > > GWT 2.8 decided to support only Java8 source level (see related threads > from last year) as the emulation will include Java 8 APIs which cannot be > compiled in Java7 mode. > > However, GWT compiler itself is intended to be runnable in a Java 7 JVM. > This should enable slow-to-upgrade enterprises business to keep their > legacy dev environments. > For any reason, if community wants to run the GWT 2.8 SDK in Java 7 source > level, they can theoretically do it by supplying a java7 compatible JRE > emulation without any compiler/SDK changes. That's why I didn't originally > remove Java7 option from the SourceLevel flag. > By removing the flag (which seems submitted now), the community will not > have that option. > > (It is not import from Google side; just wanted to let you know if the > community cares about it.) > > On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> wrote: > >> >> >> On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >>> >>> >>> >>> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco >>> Moñino wrote: >>>> >>>> Thomas, I want to experiment with this, pls, could you give me some >>>> advise what are the classes I have to look at? >>>> >>> >>> https://gwt-review.googlesource.com/14353 >>> (currently running the testsuite locally) >>> >> >> Tests pass \o/ >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com?utm_medium=email_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com?utm_medium=email_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAsQGwM4MRA-aBxoze-1MQ_fzeCQp4Jxw1Hc2o0FiOtmHA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
To remind the backlog of this: GWT 2.8 decided to support only Java8 source level (see related threads from last year) as the emulation will include Java 8 APIs which cannot be compiled in Java7 mode. However, GWT compiler itself is intended to be runnable in a Java 7 JVM. This should enable slow-to-upgrade enterprises business to keep their legacy dev environments. For any reason, if community wants to run the GWT 2.8 SDK in Java 7 source level, they can theoretically do it by supplying a java7 compatible JRE emulation without any compiler/SDK changes. That's why I didn't originally remove Java7 option from the SourceLevel flag. By removing the flag (which seems submitted now), the community will not have that option. (It is not import from Google side; just wanted to let you know if the community cares about it.) On Mon, Feb 15, 2016 at 5:12 AM, Thomas Broyer <t.bro...@gmail.com> wrote: > > > On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: >> >> >> >> On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco Moñino >> wrote: >>> >>> Thomas, I want to experiment with this, pls, could you give me some >>> advise what are the classes I have to look at? >>> >> >> https://gwt-review.googlesource.com/14353 >> (currently running the testsuite locally) >> > > Tests pass \o/ > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com?utm_medium=email_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2BRAZ1%2Bu33NNK%2BgqNdijZs7a0V7YY4fasWCes2iGJ%2Bvg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: > > > > On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco Moñino > wrote: >> >> Thomas, I want to experiment with this, pls, could you give me some >> advise what are the classes I have to look at? >> > > https://gwt-review.googlesource.com/14353 > (currently running the testsuite locally) > Tests pass \o/ -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/a96d8bde-37f5-4bdd-92f2-7fda3492cc94%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Re: Compiler failing with java 7
On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco Moñino wrote: > > Thomas, I want to experiment with this, pls, could you give me some advise > what are the classes I have to look at? > https://gwt-review.googlesource.com/14353 (currently running the testsuite locally) > On Sun, Feb 14, 2016 at 12:00 PM, Thomas Broyer <t.bro...@gmail.com> > wrote: > >> Just to make it clearer, my suggestion is: >> >> * force sourceLevel to 8 (either make the argument a no-op –using 8 even >> if arg says 7–, or fail on "-sourceLevel 7") >> * build GWT with JDK 7; particularly the release artifacts (snapshots >> matter less). Note that this means changing the CI builds to run tests in >> prod mode rather than dev mode, this is probably a good idea anyway given >> we recently changed GWTTestCase to use prod mode by default. >> >> We can revise those rules after 2.8. >> >> >> On Saturday, February 13, 2016 at 6:06:24 PM UTC+1, Manuel Carrasco >> Moñino wrote: >>> >>> Hi all, in the behave of gwt-maintainers, I'm forwarding this discussion >>> started in the maintainer list to the contributors one. Feel free to >>> contribute with your opinions. >>> Basically the matter is about the convenience of not breaking java7 >>> compatibility in 2.8 >>> >>> Thanks >>> -Manolo >>> >>> On Fri, Feb 12, 2016 at 6:14 PM, Thomas Broyer <t.bro...@gmail.com> >>> wrote: >>> >>>> FWIW, I just tried the latest snapshot (from today) with Java 7 and it >>>> seems to work (for now; see below). >>>> I think the issue in the samples is with -sourceLevel: the POMs there >>>> set maven.compiler.source to 1.7, which automatically passes -sourceLevel >>>> 1.7 to GWT, which then fails to parse the emul. >>>> >>>> I think that: >>>> * now that we no longer run tests in "dev mode", it shouldn't be a >>>> problem using -sourceLevel 8 with a JDK 7 (it's a problem in dev mode as >>>> dev mode will compile sources to classes –using JDT so with the >>>> -sourceLevel compat– and then won't be able to read them back in a JDK 7; >>>> IIRC) >>>> * we should then be able to *build* GWT with a JDK 7, and ensure >>>> compatibility of gwt-servlet with Java 7 runtimes. >>>> * we could make GWT ignore "-sourceLevel 7" (automatically upgrading >>>> to "8", or simply removing -sourceLevel processing entirely and >>>> hard-coding >>>> the value as in older versions of GWT) >>>> This only holds as long as we don't use Java 8 language features and >>>> APIs in GWT proper (and non-GWT tests), but maybe we could set it as a >>>> goal >>>> for 2.8? >>>> >>>> Note: I said above that it works "for now", because if we build with >>>> JDK 8, we can never be sure that it'll run with a JDK 7, unless we >>>> correctly cross-compile, by passing the bootclasspath to a JDK 7 too >>>> (which >>>> is equivalent to use a JDK 7, except you're using a different version of >>>> JavaC that has a different set of bugs ;-) ) Hence my suggestion above to >>>> *build* the final SDK with a JDK 7. >>>> >>>> Let's continue that discussion publicly on gwt-contrib though. >>>> >>>> On Fri, Feb 12, 2016 at 5:28 PM 'Daniel Kurka' via gwt-maintainers < >>>> gwt-maintain...@googlegroups.com> wrote: >>>> >>>>> GWT 2.8 needs to contain Java8 APIs so taht guava will start working >>>>> again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 >>>>> will not work with Java7. >>>>> >>>>> >>>>> On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier < >>>>> jens.nehlme...@gmail.com> wrote: >>>>> >>>>>> Its not just about adding new classes but we also add APIs to existing >>>>>> classes that require Java8 classes in their signature. So you would >>>>>> need to ignore these changes on method level. >>>>>> >>>>>> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >>>>>> require Java8. If someone needs Java7 support they need to replace the >>>>>> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >>>>>> possibility we don't use
Re: [gwt-contrib] Re: Compiler failing with java 7
Thomas, I want to experiment with this, pls, could you give me some advise what are the classes I have to look at? On Sun, Feb 14, 2016 at 12:00 PM, Thomas Broyer <t.bro...@gmail.com> wrote: > Just to make it clearer, my suggestion is: > > * force sourceLevel to 8 (either make the argument a no-op –using 8 even > if arg says 7–, or fail on "-sourceLevel 7") > * build GWT with JDK 7; particularly the release artifacts (snapshots > matter less). Note that this means changing the CI builds to run tests in > prod mode rather than dev mode, this is probably a good idea anyway given > we recently changed GWTTestCase to use prod mode by default. > > We can revise those rules after 2.8. > > > On Saturday, February 13, 2016 at 6:06:24 PM UTC+1, Manuel Carrasco Moñino > wrote: >> >> Hi all, in the behave of gwt-maintainers, I'm forwarding this discussion >> started in the maintainer list to the contributors one. Feel free to >> contribute with your opinions. >> Basically the matter is about the convenience of not breaking java7 >> compatibility in 2.8 >> >> Thanks >> -Manolo >> >> On Fri, Feb 12, 2016 at 6:14 PM, Thomas Broyer <t.bro...@gmail.com> >> wrote: >> >>> FWIW, I just tried the latest snapshot (from today) with Java 7 and it >>> seems to work (for now; see below). >>> I think the issue in the samples is with -sourceLevel: the POMs there >>> set maven.compiler.source to 1.7, which automatically passes -sourceLevel >>> 1.7 to GWT, which then fails to parse the emul. >>> >>> I think that: >>> * now that we no longer run tests in "dev mode", it shouldn't be a >>> problem using -sourceLevel 8 with a JDK 7 (it's a problem in dev mode as >>> dev mode will compile sources to classes –using JDT so with the >>> -sourceLevel compat– and then won't be able to read them back in a JDK 7; >>> IIRC) >>> * we should then be able to *build* GWT with a JDK 7, and ensure >>> compatibility of gwt-servlet with Java 7 runtimes. >>> * we could make GWT ignore "-sourceLevel 7" (automatically upgrading to >>> "8", or simply removing -sourceLevel processing entirely and hard-coding >>> the value as in older versions of GWT) >>> This only holds as long as we don't use Java 8 language features and >>> APIs in GWT proper (and non-GWT tests), but maybe we could set it as a goal >>> for 2.8? >>> >>> Note: I said above that it works "for now", because if we build with JDK >>> 8, we can never be sure that it'll run with a JDK 7, unless we correctly >>> cross-compile, by passing the bootclasspath to a JDK 7 too (which is >>> equivalent to use a JDK 7, except you're using a different version of JavaC >>> that has a different set of bugs ;-) ) Hence my suggestion above to *build* >>> the final SDK with a JDK 7. >>> >>> Let's continue that discussion publicly on gwt-contrib though. >>> >>> On Fri, Feb 12, 2016 at 5:28 PM 'Daniel Kurka' via gwt-maintainers < >>> gwt-maintain...@googlegroups.com> wrote: >>> >>>> GWT 2.8 needs to contain Java8 APIs so taht guava will start working >>>> again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 >>>> will not work with Java7. >>>> >>>> >>>> On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier < >>>> jens.nehlme...@gmail.com> wrote: >>>> >>>>> Its not just about adding new classes but we also add APIs to existing >>>>> classes that require Java8 classes in their signature. So you would >>>>> need to ignore these changes on method level. >>>>> >>>>> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >>>>> require Java8. If someone needs Java7 support they need to replace the >>>>> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >>>>> possibility we don't use Java8 APIs in gwt-user code. gwt-servlet.jar >>>>> is something to think about as soon as we want to add GWT-RPC >>>>> serializer for Java 8 classes. If we really want to give users the >>>>> possibility to compile GWT 2.8 with Java 7 after replacing the >>>>> emulation code we probably need a build target that builds >>>>> gwt-servlet-jdk8.jar when running Java8 only. >>>>> >>>>> Generally I thought Java8 stuff will be committed after GWT 2.8 has >>>>> b
[gwt-contrib] Re: Compiler failing with java 7
Just to make it clearer, my suggestion is: * force sourceLevel to 8 (either make the argument a no-op –using 8 even if arg says 7–, or fail on "-sourceLevel 7") * build GWT with JDK 7; particularly the release artifacts (snapshots matter less). Note that this means changing the CI builds to run tests in prod mode rather than dev mode, this is probably a good idea anyway given we recently changed GWTTestCase to use prod mode by default. We can revise those rules after 2.8. On Saturday, February 13, 2016 at 6:06:24 PM UTC+1, Manuel Carrasco Moñino wrote: > > Hi all, in the behave of gwt-maintainers, I'm forwarding this discussion > started in the maintainer list to the contributors one. Feel free to > contribute with your opinions. > Basically the matter is about the convenience of not breaking java7 > compatibility in 2.8 > > Thanks > -Manolo > > On Fri, Feb 12, 2016 at 6:14 PM, Thomas Broyer <t.bro...@gmail.com> wrote: > >> FWIW, I just tried the latest snapshot (from today) with Java 7 and it >> seems to work (for now; see below). >> I think the issue in the samples is with -sourceLevel: the POMs there set >> maven.compiler.source to 1.7, which automatically passes -sourceLevel 1.7 >> to GWT, which then fails to parse the emul. >> >> I think that: >> * now that we no longer run tests in "dev mode", it shouldn't be a >> problem using -sourceLevel 8 with a JDK 7 (it's a problem in dev mode as >> dev mode will compile sources to classes –using JDT so with the >> -sourceLevel compat– and then won't be able to read them back in a JDK 7; >> IIRC) >> * we should then be able to *build* GWT with a JDK 7, and ensure >> compatibility of gwt-servlet with Java 7 runtimes. >> * we could make GWT ignore "-sourceLevel 7" (automatically upgrading to >> "8", or simply removing -sourceLevel processing entirely and hard-coding >> the value as in older versions of GWT) >> This only holds as long as we don't use Java 8 language features and APIs >> in GWT proper (and non-GWT tests), but maybe we could set it as a goal for >> 2.8? >> >> Note: I said above that it works "for now", because if we build with JDK >> 8, we can never be sure that it'll run with a JDK 7, unless we correctly >> cross-compile, by passing the bootclasspath to a JDK 7 too (which is >> equivalent to use a JDK 7, except you're using a different version of JavaC >> that has a different set of bugs ;-) ) Hence my suggestion above to *build* >> the final SDK with a JDK 7. >> >> Let's continue that discussion publicly on gwt-contrib though. >> >> On Fri, Feb 12, 2016 at 5:28 PM 'Daniel Kurka' via gwt-maintainers < >> gwt-maintain...@googlegroups.com> wrote: >> >>> GWT 2.8 needs to contain Java8 APIs so taht guava will start working >>> again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 >>> will not work with Java7. >>> >>> >>> On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier <jens.nehlme...@gmail.com> >>> wrote: >>> >>>> Its not just about adding new classes but we also add APIs to existing >>>> classes that require Java8 classes in their signature. So you would >>>> need to ignore these changes on method level. >>>> >>>> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >>>> require Java8. If someone needs Java7 support they need to replace the >>>> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >>>> possibility we don't use Java8 APIs in gwt-user code. gwt-servlet.jar >>>> is something to think about as soon as we want to add GWT-RPC >>>> serializer for Java 8 classes. If we really want to give users the >>>> possibility to compile GWT 2.8 with Java 7 after replacing the >>>> emulation code we probably need a build target that builds >>>> gwt-servlet-jdk8.jar when running Java8 only. >>>> >>>> Generally I thought Java8 stuff will be committed after GWT 2.8 has >>>> been released so that GWT 2.8 stays Java7 compatible. I don't know >>>> about the Guava issue that requires GWT 2.8 to already have Java8 APIs >>>> available. I thought Guava will just release Guava 20 when 2.8 is >>>> released because Gauva 19 did use some private APIs of GWT that do not >>>> exist anymore. >>> >>> >>>> 2016-02-12 16:06 GMT+01:00 Daniel Kurka <danku...@google.com>: >>>> > +Colin Alworth +Jens >>>> > >
[gwt-contrib] Re: Compiler failing with java 7
Hi all, in the behave of gwt-maintainers, I'm forwarding this discussion started in the maintainer list to the contributors one. Feel free to contribute with your opinions. Basically the matter is about the convenience of not breaking java7 compatibility in 2.8 Thanks -Manolo On Fri, Feb 12, 2016 at 6:14 PM, Thomas Broyer <t.bro...@gmail.com> wrote: > FWIW, I just tried the latest snapshot (from today) with Java 7 and it > seems to work (for now; see below). > I think the issue in the samples is with -sourceLevel: the POMs there set > maven.compiler.source to 1.7, which automatically passes -sourceLevel 1.7 > to GWT, which then fails to parse the emul. > > I think that: > * now that we no longer run tests in "dev mode", it shouldn't be a > problem using -sourceLevel 8 with a JDK 7 (it's a problem in dev mode as > dev mode will compile sources to classes –using JDT so with the > -sourceLevel compat– and then won't be able to read them back in a JDK 7; > IIRC) > * we should then be able to *build* GWT with a JDK 7, and ensure > compatibility of gwt-servlet with Java 7 runtimes. > * we could make GWT ignore "-sourceLevel 7" (automatically upgrading to > "8", or simply removing -sourceLevel processing entirely and hard-coding > the value as in older versions of GWT) > This only holds as long as we don't use Java 8 language features and APIs > in GWT proper (and non-GWT tests), but maybe we could set it as a goal for > 2.8? > > Note: I said above that it works "for now", because if we build with JDK > 8, we can never be sure that it'll run with a JDK 7, unless we correctly > cross-compile, by passing the bootclasspath to a JDK 7 too (which is > equivalent to use a JDK 7, except you're using a different version of JavaC > that has a different set of bugs ;-) ) Hence my suggestion above to *build* > the final SDK with a JDK 7. > > Let's continue that discussion publicly on gwt-contrib though. > > On Fri, Feb 12, 2016 at 5:28 PM 'Daniel Kurka' via gwt-maintainers < > gwt-maintain...@googlegroups.com> wrote: > >> GWT 2.8 needs to contain Java8 APIs so taht guava will start working >> again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 >> will not work with Java7. >> >> >> On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier <jens.nehlme...@gmail.com> >> wrote: >> >>> Its not just about adding new classes but we also add APIs to existing >>> classes that require Java8 classes in their signature. So you would >>> need to ignore these changes on method level. >>> >>> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >>> require Java8. If someone needs Java7 support they need to replace the >>> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >>> possibility we don't use Java8 APIs in gwt-user code. gwt-servlet.jar >>> is something to think about as soon as we want to add GWT-RPC >>> serializer for Java 8 classes. If we really want to give users the >>> possibility to compile GWT 2.8 with Java 7 after replacing the >>> emulation code we probably need a build target that builds >>> gwt-servlet-jdk8.jar when running Java8 only. >>> >>> Generally I thought Java8 stuff will be committed after GWT 2.8 has >>> been released so that GWT 2.8 stays Java7 compatible. I don't know >>> about the Guava issue that requires GWT 2.8 to already have Java8 APIs >>> available. I thought Guava will just release Guava 20 when 2.8 is >>> released because Gauva 19 did use some private APIs of GWT that do not >>> exist anymore. >> >> >>> 2016-02-12 16:06 GMT+01:00 Daniel Kurka <danku...@google.com>: >>> > +Colin Alworth +Jens >>> > >>> > Colin and Jens have been doing a lot of the Java8 API work, I believe >>> this >>> > will touch many classes within the JRE and thus will not be as easy as >>> > ignoring a few classes. >>> > >>> > To be clear: >>> > We won't be putting any resources into addressing this since its not an >>> > issue for us, if someone feels strongly (s)he can step up and tackle >>> this, >>> > but the whole case does not seem to be convincing for me, why would >>> agencies >>> > that are slow to adopt things adopt the latest GWT version? >>> > >>> > -Daniel >>> > >>> > On Fri, Feb 12, 2016 at 3:52 PM Manuel Carrasco Moñino < >>> man...@apache.org> >>> > wrote: >>> >> >>> >> Well the situation I know,
[gwt-contrib] Re: Compiler failing with java 7
I would choose Java 1.8 all the way if you have to choose. I would do this because this is going to be a long standing maintenance release. Just a note, the Eclipse neon out in June will require Java 1.8. I think it makes sense to upgrade. I think folks can go through the pain of upgrading there servlet containers to Java 1.8 if they want to move forward. On Friday, February 12, 2016 at 8:39:41 AM UTC-8, Colin Alworth wrote: > > Switching to gwt-contrib, we're losing voices who are involved in this > discussion. > > Maybe I am missing something, but I had that that the discussion moved > toward the fact that the compiler and dev mode will require Java8, but that > gwt-servlet could still be compiled to Java7, allowing deployment on Java7. > > The supersource classes do require Java8 language level in the GWT > compiler (in order to have "default" mean anything), but these emulation > classes are not compiled to bytecode, and not required to compile the rest > of GWT. > > We already have cases where GWT will not work without Java8 (specifically > Dev Mode and anything that leans on it), so this isn't a change from the > beta. I agree with Daniel that effort will be required to compile to Java7 > bytecode (as previously discussed), and while I would be interested in > helping to achieve this, we've also clearly stated that Java8 support is a > more important goal (both in terms of keeping GWT modern and up to date in > the Java world, but also in terms of staying relevant for web development > with lambdas and JSInterop). > > Even if we manage to compile to Java7 bytecode from a Java8 JDK, it has > been encouraged that we extensively test to ensure that all of the code > does as we expect, as regressions have been seen in the past. RetroLambda > was another suggestion that also may have merit. > > On Fri, Feb 12, 2016 at 10:28 AM Daniel Kurka <dank...@google.com > > wrote: > >> GWT 2.8 needs to contain Java8 APIs so taht guava will start working >> again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 >> will not work with Java7. >> >> >> On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier <jens.ne...@gmail.com >> > wrote: >> >>> Its not just about adding new classes but we also add APIs to existing >>> classes that require Java8 classes in their signature. So you would >>> need to ignore these changes on method level. >>> >>> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >>> require Java8. If someone needs Java7 support they need to replace the >>> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >>> possibility we don't use Java8 APIs in gwt-user code. gwt-servlet.jar >>> is something to think about as soon as we want to add GWT-RPC >>> serializer for Java 8 classes. If we really want to give users the >>> possibility to compile GWT 2.8 with Java 7 after replacing the >>> emulation code we probably need a build target that builds >>> gwt-servlet-jdk8.jar when running Java8 only. >>> >>> Generally I thought Java8 stuff will be committed after GWT 2.8 has >>> been released so that GWT 2.8 stays Java7 compatible. I don't know >>> about the Guava issue that requires GWT 2.8 to already have Java8 APIs >>> available. I thought Guava will just release Guava 20 when 2.8 is >>> released because Gauva 19 did use some private APIs of GWT that do not >>> exist anymore. >>> >>> >>> >>> 2016-02-12 16:06 GMT+01:00 Daniel Kurka <dank...@google.com >>> >: >>> > +Colin Alworth +Jens >>> > >>> > Colin and Jens have been doing a lot of the Java8 API work, I believe >>> this >>> > will touch many classes within the JRE and thus will not be as easy as >>> > ignoring a few classes. >>> > >>> > To be clear: >>> > We won't be putting any resources into addressing this since its not an >>> > issue for us, if someone feels strongly (s)he can step up and tackle >>> this, >>> > but the whole case does not seem to be convincing for me, why would >>> agencies >>> > that are slow to adopt things adopt the latest GWT version? >>> > >>> > -Daniel >>> > >>> > On Fri, Feb 12, 2016 at 3:52 PM Manuel Carrasco Moñino < >>> man...@apache.org > >>> > wrote: >>> >> >>> >> Well the situation I know, is that there are many big companies and >>> >> government agencies moving very slow, their standard
[gwt-contrib] Re: Compiler failing with java 7
Switching to gwt-contrib, we're losing voices who are involved in this discussion. Maybe I am missing something, but I had that that the discussion moved toward the fact that the compiler and dev mode will require Java8, but that gwt-servlet could still be compiled to Java7, allowing deployment on Java7. The supersource classes do require Java8 language level in the GWT compiler (in order to have "default" mean anything), but these emulation classes are not compiled to bytecode, and not required to compile the rest of GWT. We already have cases where GWT will not work without Java8 (specifically Dev Mode and anything that leans on it), so this isn't a change from the beta. I agree with Daniel that effort will be required to compile to Java7 bytecode (as previously discussed), and while I would be interested in helping to achieve this, we've also clearly stated that Java8 support is a more important goal (both in terms of keeping GWT modern and up to date in the Java world, but also in terms of staying relevant for web development with lambdas and JSInterop). Even if we manage to compile to Java7 bytecode from a Java8 JDK, it has been encouraged that we extensively test to ensure that all of the code does as we expect, as regressions have been seen in the past. RetroLambda was another suggestion that also may have merit. On Fri, Feb 12, 2016 at 10:28 AM Daniel Kurka <danku...@google.com> wrote: > GWT 2.8 needs to contain Java8 APIs so taht guava will start working > again. All the outstanding Java8 patches need to go in before 2.8. So 2.8 > will not work with Java7. > > > On Fri, Feb 12, 2016 at 5:25 PM Jens Nehlmeier <jens.nehlme...@gmail.com> > wrote: > >> Its not just about adding new classes but we also add APIs to existing >> classes that require Java8 classes in their signature. So you would >> need to ignore these changes on method level. >> >> AFAICT it was said that as soon as Java 8 APIs are committed GWT will >> require Java8. If someone needs Java7 support they need to replace the >> emulation code of GWT 2.8 with the one of GWT 2.7. Because of this >> possibility we don't use Java8 APIs in gwt-user code. gwt-servlet.jar >> is something to think about as soon as we want to add GWT-RPC >> serializer for Java 8 classes. If we really want to give users the >> possibility to compile GWT 2.8 with Java 7 after replacing the >> emulation code we probably need a build target that builds >> gwt-servlet-jdk8.jar when running Java8 only. >> >> Generally I thought Java8 stuff will be committed after GWT 2.8 has >> been released so that GWT 2.8 stays Java7 compatible. I don't know >> about the Guava issue that requires GWT 2.8 to already have Java8 APIs >> available. I thought Guava will just release Guava 20 when 2.8 is >> released because Gauva 19 did use some private APIs of GWT that do not >> exist anymore. >> >> >> >> 2016-02-12 16:06 GMT+01:00 Daniel Kurka <danku...@google.com>: >> > +Colin Alworth +Jens >> > >> > Colin and Jens have been doing a lot of the Java8 API work, I believe >> this >> > will touch many classes within the JRE and thus will not be as easy as >> > ignoring a few classes. >> > >> > To be clear: >> > We won't be putting any resources into addressing this since its not an >> > issue for us, if someone feels strongly (s)he can step up and tackle >> this, >> > but the whole case does not seem to be convincing for me, why would >> agencies >> > that are slow to adopt things adopt the latest GWT version? >> > >> > -Daniel >> > >> > On Fri, Feb 12, 2016 at 3:52 PM Manuel Carrasco Moñino < >> man...@apache.org> >> > wrote: >> >> >> >> Well the situation I know, is that there are many big companies and >> >> government agencies moving very slow, their standard server >> configuration is >> >> java7, as well as their code standards. >> >> >> >> Their GWT projects are compiled in one phase (not client and server >> >> sides). It could be very difficult for them to compile their byte code >> for >> >> 1.7. >> >> It's true that if they don't use java 8 many features in 2.8 are >> useless >> >> for them, but we have to facilitate and encourage users to be in latest >> >> version. >> >> >> >> I don't know how complex it could be, but if for example, ignoring >> java8 >> >> /emul/ classes could fix the problem I think it's worth to consider. >> >> >> >> On Fri, Feb 12, 2016 at 3:42 PM, 'Daniel Kurka' via gwt-
Re: [gwt-contrib] Upgrading Checkstyle to 5.7 (Java 7 grammar support and more)
OK, thank you for that info. Odd that I'm not seeing those changes in my trunk. I thought that I was updated but I'm still on 973b708 which apparently is 382 changes behind, doh! On Saturday, June 7, 2014 2:55:36 PM UTC-4, Roberto Lublinerman wrote: We upgraded to checkstyle 5.7 in trunk ( https://gwt-review.googlesource.com/#/c/6670/). If you checkout out trunk or download the nighty builds (2.7.0-SNAPSHOP) from maven all the required changes (to ant, the style files, etc) are there. On Sat, Jun 7, 2014 at 1:26 AM, Michael Prentice spla...@gmail.com javascript: wrote: Today, I was able to get Eclipse building the trunk with the latest Checkstyle v5.7 from http://eclipse-cs.sourceforge.net/update I was seeing a ton (1200-1900+) of OrderCheck and FieldCheck errors using Checkstyle 4.2 or 4.3 in Eclipse. But with 5.7, I am not seeing any errors. It does appear that Checkstyle 4.2 is still being used by Ant though. There was some discussion about upgrading Checkstyle last year here https://groups.google.com/forum/#!searchin/google-web-toolkit-contributors/checkstyle/google-web-toolkit-contributors/0aqmDB2tHfI/ZZTLRdinx-sJ . *Checkstyle 5.7 includes Java 7 grammar support, which is now supported (and the default) in gwt 2.6.0+.* *In order to upgrade the current .xml configuration files for Checkstyle, the following appear to be needed:* *PackageHtml* looks like it can just be changed to *JavadocPackage*. *GenericIllegalRegexp* looks like it can just be changed to *RegexpSingleline*. It needs to be pulled out of the TreeWalker module. *TabCharacter* needs to be replaced with *FileTabCharacter*. It needs to be pulled out of the TreeWalker module and have the following added to it: property name=fileExtensions value=java/ *RegexpHeader* needs to be pulled out of the TreeWalker module and have the following added to it: property name=fileExtensions value=java/ There seems to be a bug with *SuppressionCommentFilter* and the use of messageFormat AND checkFormat not properly working together. Removing messageFormat seems to help for now. There is an issue about this here https://github.com/checkstyle/checkstyle/issues/123. There are 4 files in gwt-user that break the *AvoidStarImport* check which will need to be fixed. From the checkstyle release notes: Removed the DoubleCheckedLocking check, as in Java 5 (and beyond), using the volatile keyword addresses the issue. See here http://jeremymanson.blogspot.com.au/2008/05/double-checked-locking.html for more details. *Can this check be removed for gwt as well?* It looks like checkstyle-5.7-all.jar is already in gwt/tools/antlib/. So this would just mean a small change to trunk/common.ant.xml in addition to the configuration mentioned above. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com javascript:. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/dc4df58a-3381-4daf-961a-3e820fea50c5%40googlegroups.com https://groups.google.com/d/msgid/google-web-toolkit-contributors/dc4df58a-3381-4daf-961a-3e820fea50c5%40googlegroups.com?utm_medium=emailutm_source=footer . For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/e08eb205-49fd-4d3e-b524-89c4f5f8107b%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Upgrading Checkstyle to 5.7 (Java 7 grammar support and more)
Awesome. Looks like you got all of the changes that I had found, plus you cleaned up a ton of the code as well. This is extremely helpful! On Saturday, June 7, 2014 2:55:36 PM UTC-4, Roberto Lublinerman wrote: We upgraded to checkstyle 5.7 in trunk ( https://gwt-review.googlesource.com/#/c/6670/). If you checkout out trunk or download the nighty builds (2.7.0-SNAPSHOP) from maven all the required changes (to ant, the style files, etc) are there. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/3314eeb9-7499-40e3-90af-61da866eb834%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Upgrading Checkstyle to 5.7 (Java 7 grammar support and more)
We upgraded to checkstyle 5.7 in trunk ( https://gwt-review.googlesource.com/#/c/6670/). If you checkout out trunk or download the nighty builds (2.7.0-SNAPSHOP) from maven all the required changes (to ant, the style files, etc) are there. On Sat, Jun 7, 2014 at 1:26 AM, Michael Prentice splak...@gmail.com wrote: Today, I was able to get Eclipse building the trunk with the latest Checkstyle v5.7 from http://eclipse-cs.sourceforge.net/update I was seeing a ton (1200-1900+) of OrderCheck and FieldCheck errors using Checkstyle 4.2 or 4.3 in Eclipse. But with 5.7, I am not seeing any errors. It does appear that Checkstyle 4.2 is still being used by Ant though. There was some discussion about upgrading Checkstyle last year here https://groups.google.com/forum/#!searchin/google-web-toolkit-contributors/checkstyle/google-web-toolkit-contributors/0aqmDB2tHfI/ZZTLRdinx-sJ . *Checkstyle 5.7 includes Java 7 grammar support, which is now supported (and the default) in gwt 2.6.0+.* *In order to upgrade the current .xml configuration files for Checkstyle, the following appear to be needed:* *PackageHtml* looks like it can just be changed to *JavadocPackage*. *GenericIllegalRegexp* looks like it can just be changed to *RegexpSingleline*. It needs to be pulled out of the TreeWalker module. *TabCharacter* needs to be replaced with *FileTabCharacter*. It needs to be pulled out of the TreeWalker module and have the following added to it: property name=fileExtensions value=java/ *RegexpHeader* needs to be pulled out of the TreeWalker module and have the following added to it: property name=fileExtensions value=java/ There seems to be a bug with *SuppressionCommentFilter* and the use of messageFormat AND checkFormat not properly working together. Removing messageFormat seems to help for now. There is an issue about this here https://github.com/checkstyle/checkstyle/issues/123. There are 4 files in gwt-user that break the *AvoidStarImport* check which will need to be fixed. From the checkstyle release notes: Removed the DoubleCheckedLocking check, as in Java 5 (and beyond), using the volatile keyword addresses the issue. See here http://jeremymanson.blogspot.com.au/2008/05/double-checked-locking.html for more details. *Can this check be removed for gwt as well?* It looks like checkstyle-5.7-all.jar is already in gwt/tools/antlib/. So this would just mean a small change to trunk/common.ant.xml in addition to the configuration mentioned above. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/dc4df58a-3381-4daf-961a-3e820fea50c5%40googlegroups.com https://groups.google.com/d/msgid/google-web-toolkit-contributors/dc4df58a-3381-4daf-961a-3e820fea50c5%40googlegroups.com?utm_medium=emailutm_source=footer . For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAC7T7gmgqOTr5FRhQ-qY66rF5RQ5W0KkdoJZA7w%2BV_shnFjieg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Compiling GWT 2.6.1 at Java 7 source level
I resolved this. In combination of explictly setting the source level target to the Java and GWT compilers, I had to delete the gwt-unitCache directory as well. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Compiling GWT 2.6.1 at Java 7 source level
I've recently updated my GWT project to 2.6.1, and started to make use of Java 7 syntax since 2.6 now supports Java 7. However, when I attempt to compile, I'm receiving compiler errors such as [ERROR] Line 42: '' operator is not allowed for source level below 1.7 Full output Compiling module com.Project Validating units: Ignored 85 units with compilation errors in first pass. Compile with -strict or with -logLevel set to TRACE or DEBUG to see all errors. Computing all possible rebind results for 'com.google.gwt.useragent.client.UserAgentAsserter' Rebinding com.google.gwt.useragent.client.UserAgentAsserter Checking rule generate-with class='com.google.gwt.editor.rebind.SimpleBeanEditorDriverGenerator'/ [WARN] Detected warnings related to 'com.google.gwt.editor.client.SimpleBeanEditorDriver'. Are validation-api-version.jar and validation-api-version-sources.jar on the classpath? Specify -logLevel DEBUG to see all errors. [WARN] Unknown type 'com.google.gwt.editor.client.SimpleBeanEditorDriver' specified in deferred binding rule [ERROR] Errors in 'file:/C:/workspace/Project/src/com/project/ProjectFile.java' [ERROR] Line 42: '' operator is not allowed for source level below 1.7 [ERROR] Errors in 'file:/C:/workspace/Project/src/com/project/AnotherProjectFile.java' [ERROR] Line 188: Cannot switch on a value of type String for source level below 1.7. Only convertible int values or enum variables are permitted C:\workspace\Project\build.xml:51: Java returned: 1 at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:390) at org.apache.tools.ant.Target.performTasks(Target.java:411) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:809) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.Main.start(Main.java:180) at org.apache.tools.ant.Main.main(Main.java:268) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.intellij.rt.ant.execution.AntMain2.main(AntMain2.java:30) C:\workspace\Project\build.xml:51: Java returned: 1 at org.apache.tools.ant.taskdefs.Java.execute(Java.java:111) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106) at org.apache.tools.ant.Task.perform(Task.java:348) at org.apache.tools.ant.Target.execute(Target.java:390) at org.apache.tools.ant.Target.performTasks(Target.java:411) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1399) at org.apache.tools.ant.Project.executeTarget(Project.java:1368) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:809) at org.apache.tools.ant.Main.startAnt(Main.java:217) at org.apache.tools.ant.Main.start(Main.java:180) at org.apache.tools.ant.Main.main(Main.java:268) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.intellij.rt.ant.execution.AntMain2.main(AntMain2.java:30) C:\workspace\Project\build.xml:51: Java returned: 1
Re: Compiling GWT 2.6.1 at Java 7 source level
Probably worth nothing that I can compile and run the project just fine through the IntelliJ run configurations. It's just when I attempt to compile via the Ant targets (either within IntelliJ or at a system command line) that I have issues. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/d/optout.
Switch on String shouldn't this work in GWT 2.6 / Java 7 ?
Something like ;
switch (book) {
case Harry Potter:
break;
case Hitch Hikers Guide To The Galaxy:
break;
Should now work with the latest GWT from here;
https://code.google.com/p/google-web-toolkit/downloads/list
Correct?
Because I am still getting a[ERROR] Line 1971: Cannot switch on a
value of type String. Only convertible int values or enum constants are
permitted
error.
Screenshot;
http://www.darkflame.co.uk//temppics/StringSwitch.png
Have I somehow setup GWT 2.6 wrongly?
Thanks,
-Thomas
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Switch on String shouldn't this work in GWT 2.6 / Java 7 ?
Have I somehow setup GWT 2.6 wrongly? Using switch() with strings works in GWT 2.6. I guess you have to double check your setup. Maybe you have used an old run configuration that is not up-to-date? -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/groups/opt_out.
Re: Switch on String shouldn't this work in GWT 2.6 / Java 7 ?
Ah, Bingo...it was either down to not clearing the cache's, or the fact a non-GWT 2.6 project was being inherited in. Fixing both of those and it works. *goes of to enjoy Java7* ~~~ Thomas Bertines online review show: http://randomreviewshow.com/index.html Try it! You might even feel ambivalent about it :) On 28 January 2014 20:23, Jens jens.nehlme...@gmail.com wrote: Have I somehow setup GWT 2.6 wrongly? Using switch() with strings works in GWT 2.6. I guess you have to double check your setup. Maybe you have used an old run configuration that is not up-to-date? -- J. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/pHHK4a2KuWc/unsubscribe . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Doesn't Leeroy like Java 7 syntax?
We have not decided on a Java minimum version for GWT code with 3.0. Maybe we go with an approach to leave server side code at Java 6 and may require a newer version for the client side. This would allow us to leverage Java 8 features while still being able to run Java 6 server side. On Nov 13, 2013 5:18 AM, Thomas Broyer t.bro...@gmail.com wrote: On Wednesday, November 13, 2013 12:00:49 AM UTC+1, Jens wrote: If you take a look at https://gwt-review.googlesource.com/#/c/5372/2/ user/src/com/google/gwt/event/dom/client/DomEvent.java https://gwt-review.googlesource.com/#/c/5372/2/user/test/com/google/gwt/ event/dom/client/DomEventTest.java Leeroy has commented some strange EOF errors. I have then removed the diamond operator and he seems to be happy again. Is this a bug or is it not yet allowed to use Java 7 syntax in GWT source? Those come from checkstyle, of which we use an old version that predates Java 7. That said, I don't really remember the outcome of the previous discussion on the subject but I believe we still want to support Java 6 (GWT compiler has a -sourceLevel 6) for GWT 3.0, which means we can't use Java 7 syntax yet. Also note that in the Ant build scripts the javac tasks use source=1.6 target=1.6. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Doesn't Leeroy like Java 7 syntax?
I see. Thanks for the information. -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Doesn't Leeroy like Java 7 syntax?
If you take a look at https://gwt-review.googlesource.com/#/c/5372/2/user/src/com/google/gwt/event/dom/client/DomEvent.java https://gwt-review.googlesource.com/#/c/5372/2/user/test/com/google/gwt/event/dom/client/DomEventTest.java Leeroy has commented some strange EOF errors. I have then removed the diamond operator and he seems to be happy again. Is this a bug or is it not yet allowed to use Java 7 syntax in GWT source? -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Doesn't Leeroy like Java 7 syntax?
On Wednesday, November 13, 2013 12:00:49 AM UTC+1, Jens wrote: If you take a look at https://gwt-review.googlesource.com/#/c/5372/2/user/src/com/google/gwt/event/dom/client/DomEvent.java https://gwt-review.googlesource.com/#/c/5372/2/user/test/com/google/gwt/event/dom/client/DomEventTest.java Leeroy has commented some strange EOF errors. I have then removed the diamond operator and he seems to be happy again. Is this a bug or is it not yet allowed to use Java 7 syntax in GWT source? Those come from checkstyle, of which we use an old version that predates Java 7. That said, I don't really remember the outcome of the previous discussion on the subject but I believe we still want to support Java 6 (GWT compiler has a -sourceLevel 6) for GWT 3.0, which means we can't use Java 7 syntax yet. Also note that in the Ant build scripts the javac tasks use source=1.6 target=1.6. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Ray Cromwell has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: Code-Review+2 (1 comment) File dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java Line 109: OptionSource.DEFAULT_SOURCE_LEVEL); Why is generated code compiled a different source level? -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Ray Cromwell has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 8: Code-Review+2 (1 comment) File dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java Line 895: IteratorJType it = clause.getTypes().iterator(); visitCollectionWithCommas(CHARS_PIPE, it) ? -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: (1 comment) Thanks. File dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java Line 109: OptionSource.DEFAULT_SOURCE_LEVEL); Isn't this only used for testing purposes? There is no obvious way to thread the flag. In any case we will be pushing the default to Java7 in a not too distant time in the future. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 8: (1 comment) Thanks for this as well. File dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java Line 895: IteratorJType it = clause.getTypes().iterator(); Originaly that is what I planned but it the accept for JClassType prints the whole class declaration and here we only need to print the type name. I crave for lambdas -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Ray Cromwell, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#9). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java 20 files changed, 761 insertions(+), 89 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 9: Previous patch was approved and changes since then are trivial. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 9: Code-Review+2 Previous patch was approved and changes since then are trivial. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: Ping. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 6: Ping. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 8: I assume you're pinging for John and/or Ray? -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8: Code-Review+1
(7 comments)
Looks fine to me. I have a few nits, but they don't need to be fixed.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Nit: INTEGER_LITERALS to match the use of underscores elsewhere in this
file.
More nits: also, some of the constants match the class being created
(INTEGER_LITERALS matches IntegerLiterals) but others don't. Some classes
end with Test and others don't. It would be a bit cleaner to make them
match.
Line 26: StringBuilder code = new StringBuilder();
This sort of code could be made slightly more concise with a helper method:
/**
* Concatenate lines of text, adding a newline to the end of each string.
*/
static String concat(String... lines);
But it's fine as-is.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Maybe SourceLevel should be a top-level enum? It would make imports shorter
by default.
Line 27: _6(1.6, 6),
perhaps JAVA6 and JAVA7 instead of underscore?
Line 39: * Returns a string value representation for the source level.
The javadoc here seems to be boilerplate. Better to give an example of what
will be returned, and perhaps say when to use 1.6 and when to use 6?
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Perhaps import SourceLevel directly.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
must exist
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#7). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 21 files changed, 760 insertions(+), 89 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#9). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,150 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 9 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has posted comments on this change.
Change subject: Adds part of Java 7 new language features.
..
Patch Set 8:
(7 comments)
@Ray, can you have a look at this patch and its successor and if ok +2 them.
File
dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java
Line 22: public static final MockJavaResource INTEGERLITERALS = new
MockJavaResource(
Done
Line 26: StringBuilder code = new StringBuilder();
I followed JavaResouceBase.java. But I agree, will fix here.
File dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
Line 26: enum SourceLevel {
Done
Line 27: _6(1.6, 6),
Done
Line 39: * Returns a string value representation for the source level.
Added an explanation in the class doc. Done
File dev/core/test/com/google/gwt/dev/CompilerTest.java
Line 60: assertEquals(OptionSource.SourceLevel._7,
options.getSourceLevel());
Done. Made SourceLevel a top level enum.
File
user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java
Line 27: * IMPORTANT: For each test here there must exists the
corresponding method in the non super sourced
Done
--
To view, visit https://gwt-review.googlesource.com/2650
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70
Gerrit-PatchSet: 8
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#10). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java A dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 36 files changed, 1,151 insertions(+), 430 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#8). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 21 files changed, 760 insertions(+), 89 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Brian Slesinsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 10: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 10 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2650 to look at the new patch set (#8). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java A dev/core/src/com/google/gwt/dev/javac/testing/impl/Java7MockResources.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 35 files changed, 1,002 insertions(+), 116 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@gmail.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Matthew Dempsky, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#6). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 21 files changed, 763 insertions(+), 92 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#4). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Exception.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 23 files changed, 893 insertions(+), 94 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#5). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/ast/JClassType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java M dev/core/src/com/google/gwt/dev/jjs/ast/JMethodCall.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 22 files changed, 869 insertions(+), 93 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#5). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 34 files changed, 944 insertions(+), 45 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has abandoned this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Abandoned Redid as dependent patch. -- To view, visit https://gwt-review.googlesource.com/2680 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic46ae3c9ee49518cfddc6f6f329b721e6645802d Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 1: Verified-1 Oops, this change failed the build and/or style presubmit. :( More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/46 -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 5: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/45 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 1: (1 comment) File user/super/com/google/gwt/emul/java/lang/Throwable.java Line 19: import com.google.gwt.lang.Array; Unused import. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Goktug Gokdogan has posted comments on this change.
Change subject: Adds the remaining (and more complex) Java 7 new language
features.
..
Patch Set 1:
(9 comments)
File user/src/com/google/gwt/core/shared/SerializableThrowable.java
Line 34: * NOTE: Does not serialize suppressed exceptions to remain
compatible with Java 6 and below.
Don't forget to create a thread on this issue =)
File user/super/com/google/gwt/emul/java/lang/AutoCloseable.java
Line 3: *
nit: spaces here
Line 19: * Indicates that a class implements codeclose()/code and can
be used in a try-with-resources
Can you just refer to jdk documentation like the other classes in this
package?
Line 26:* @throws Exception
remove empty @throws
File user/super/com/google/gwt/emul/java/lang/Exception.java
Line 38: }
I guess this class is not intended to be here :)
File user/super/com/google/gwt/emul/java/lang/Throwable.java
Line 40:* SerializabilityUtil.fieldQualifiesForSerialization(Field)
method.
can you put a todo item for missing stuff related to suppressed exceptions?
Also can you create an issue to follow up on this?
Line 44: private transient Throwable[] suppressed = new Throwable[0];
it is better to instantiate this lazily.
Line 74:
asserts are just like javadocs, nothing more. In this kind of scenarios we
want guaranteed checks. (see go/java-practices/assertions).
Line 78: }
you don't need the whole array copy. This will only run in script mode.
just set the array. The whole method can look something like:
public final void addSuppressed(Throwable exception) {
if (exception == null) {
throw new NPE();
}
if (exception == this) {
throw new IllegalArgumentException(Self-suppress not permitted);
}
if (suppressed == null ) {
suppressed = new Throwable[] { exception };
} else {
suppressed[suppressed.length] = exception;
}
}
--
To view, visit https://gwt-review.googlesource.com/2681
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#2). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Exception.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 18 files changed, 922 insertions(+), 78 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 2: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/47 -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#3). Change subject: Adds Java 7 new language features. .. Adds Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, multiexception catch, switch/case on string literals and try-with-resources. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issues 7999, 6960, 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/build.xml M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java D dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsCheckerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M eclipse/dev/.classpath M eclipse/dev/compiler/.classpath M user/src/com/google/gwt/core/shared/SerializableThrowable.java M user/src/com/google/gwt/junit/JUnitShell.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Enum.java M user/super/com/google/gwt/emul/java/lang/Throwable.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 53 files changed, 1,854 insertions(+), 1,812 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#4). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 34 files changed, 944 insertions(+), 45 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Java 7 new language features.
Roberto Lublinerman has posted comments on this change. Change subject: Adds Java 7 new language features. .. Patch Set 1: This patch includes the JDT 3.8 update patch; I am uploading to start the review process for the Java 7 features. Once the JDT patch gets submitted I'll update this one accordingly. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds Java 7 new language features. .. Patch Set 1: Are the JDT 3.8 jars that you want to use stable? If so, maybe we should go ahead and add those internally and then also mirror them to Google Code. -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds Java 7 new language features. .. Patch Set 1: Oh, disregard that comment then. Didn't realize this was the child patch. :) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#2). Change subject: Adds Java 7 new language features. .. Adds Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, multiexception catch, switch/case on string literals and try-with-resources. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issues 7999, 6960, 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/build.xml M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java D dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsCheckerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M eclipse/dev/.classpath M eclipse/dev/compiler/.classpath M user/src/com/google/gwt/core/shared/SerializableThrowable.java M user/src/com/google/gwt/junit/JUnitShell.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Enum.java M user/super/com/google/gwt/emul/java/lang/Throwable.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 50 files changed, 1,794 insertions(+), 1,751 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
I invite you to contribute the java support 7. You can do this together with your teammates Why not? It's all a matter of priorties, vote an issue in the issue tracker and it will get a higher priority Wouldn't it be nice that you could latter say that you were responsibly for the jdk 7 support in gwt? On Tue, Apr 16, 2013 at 7:28 AM, Gilberto gilberto.torre...@gmail.comwrote: It's just my opinion, but in my mind making the JDK compliance to 1.6 and call that fully compatible with JDK 7 is not... well... what I was expecting (at least). I understand that tweaking the compiler to actually and truly support Java 7 is not easy and demand time. But Java 7 is around for ... uh... years? (since July - 2011 according to Wikipedia). I understand that GWT is now handled by a committee, since last year. And still, there's no public roadmap of when we are going to have the real Java 7 support (and I'm not even talking about Java 8). So, eh, am I wrong on asking such things? Should I recommend other frameworks to my teammates for new projects or still wait for news from GWT? I understand we have to wait till you guys commit the code to Gerrit/GitHub, to organize the project, to mavenize it, to deal with contributors, Google itself and so on. But till when? Sorry for my impatience, but at this stage I don't really feel comfortable with the situation. Maybe it's only me. On Wednesday, April 3, 2013 5:09:35 AM UTC-3, Thomas Broyer wrote: On Wednesday, April 3, 2013 8:15:03 AM UTC+2, Max Völkel wrote: How well does this play together with AppEngine 1.7.7? From their release notes: The Java runtime now defaults to Java7. If you still need to use the Java6 runtime, please use the --use_java6 flag when deploying your app. We encourage you to move to Java7 as soon as possible. It sounds I should compile for a 1.7 target. So I should *not* set maven.compiler.source to 1.6, right? I don't know how AppEngine's Java runtime works, but my 7 and 8 JREs are very well capable of running classes compiled with -target 1.6 or earlier, and mixing classes compiled with different -target (you'd never be able to use Maven, or pretty much any third-party dependency actually, if that wasn't the case; btw GWT is compiled with -target 1.6 and is fully compatible with a JDK 7, and we haven't yet heard of anyone having issues using RPC or RequestFactory on AppEngine) -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/dM8D9imIvAI/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
Java 6 is still used a lot in enterprise developments, I am actually more looking forward to Java 8 support due to project lambda which could have a very nice impact on readability of all these async operations we tend to chain together in GWT client applications. On Tuesday, April 16, 2013 9:12:55 AM UTC+2, Ed wrote: I invite you to contribute the java support 7. You can do this together with your teammates Why not? It's all a matter of priorties, vote an issue in the issue tracker and it will get a higher priority Wouldn't it be nice that you could latter say that you were responsibly for the jdk 7 support in gwt? On Tue, Apr 16, 2013 at 7:28 AM, Gilberto gilberto...@gmail.comjavascript: wrote: It's just my opinion, but in my mind making the JDK compliance to 1.6 and call that fully compatible with JDK 7 is not... well... what I was expecting (at least). I understand that tweaking the compiler to actually and truly support Java 7 is not easy and demand time. But Java 7 is around for ... uh... years? (since July - 2011 according to Wikipedia). I understand that GWT is now handled by a committee, since last year. And still, there's no public roadmap of when we are going to have the real Java 7 support (and I'm not even talking about Java 8). So, eh, am I wrong on asking such things? Should I recommend other frameworks to my teammates for new projects or still wait for news from GWT? I understand we have to wait till you guys commit the code to Gerrit/GitHub, to organize the project, to mavenize it, to deal with contributors, Google itself and so on. But till when? Sorry for my impatience, but at this stage I don't really feel comfortable with the situation. Maybe it's only me. On Wednesday, April 3, 2013 5:09:35 AM UTC-3, Thomas Broyer wrote: On Wednesday, April 3, 2013 8:15:03 AM UTC+2, Max Völkel wrote: How well does this play together with AppEngine 1.7.7? From their release notes: The Java runtime now defaults to Java7. If you still need to use the Java6 runtime, please use the --use_java6 flag when deploying your app. We encourage you to move to Java7 as soon as possible. It sounds I should compile for a 1.7 target. So I should *not* set maven.compiler.source to 1.6, right? I don't know how AppEngine's Java runtime works, but my 7 and 8 JREs are very well capable of running classes compiled with -target 1.6 or earlier, and mixing classes compiled with different -target (you'd never be able to use Maven, or pretty much any third-party dependency actually, if that wasn't the case; btw GWT is compiled with -target 1.6 and is fully compatible with a JDK 7, and we haven't yet heard of anyone having issues using RPC or RequestFactory on AppEngine) -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/dM8D9imIvAI/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com javascript:. To post to this group, send email to google-we...@googlegroups.comjavascript: . Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
On Tuesday, April 16, 2013 7:28:17 AM UTC+2, Gilberto wrote: It's just my opinion, but in my mind making the JDK compliance to 1.6 and call that fully compatible with JDK 7 is not... well... what I was expecting (at least). I understand that tweaking the compiler to actually and truly support Java 7 is not easy and demand time. But Java 7 is around for ... uh... years? (since July - 2011 according to Wikipedia). I understand that GWT is now handled by a committee, since last year. And still, there's no public roadmap of when we are going to have the real Java 7 support (and I'm not even talking about Java 8). So, eh, am I wrong on asking such things? Should I recommend other frameworks to my teammates for new projects or still wait for news from GWT? I understand we have to wait till you guys commit the code to Gerrit/GitHub, to organize the project, to mavenize it, to deal with contributors, Google itself and so on. But till when? Sorry for my impatience, but at this stage I don't really feel comfortable with the situation. Maybe it's only me. Java 7 (language) support is coming: https://gwt-review.googlesource.com/2361 Java 8 will have to wait 'til the Eclipse compiler supports it. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
It's just my opinion, but in my mind making the JDK compliance to 1.6 and call that fully compatible with JDK 7 is not... well... what I was expecting (at least). I understand that tweaking the compiler to actually and truly support Java 7 is not easy and demand time. But Java 7 is around for ... uh... years? (since July - 2011 according to Wikipedia). I understand that GWT is now handled by a committee, since last year. And still, there's no public roadmap of when we are going to have the real Java 7 support (and I'm not even talking about Java 8). So, eh, am I wrong on asking such things? Should I recommend other frameworks to my teammates for new projects or still wait for news from GWT? I understand we have to wait till you guys commit the code to Gerrit/GitHub, to organize the project, to mavenize it, to deal with contributors, Google itself and so on. But till when? Sorry for my impatience, but at this stage I don't really feel comfortable with the situation. Maybe it's only me. On Wednesday, April 3, 2013 5:09:35 AM UTC-3, Thomas Broyer wrote: On Wednesday, April 3, 2013 8:15:03 AM UTC+2, Max Völkel wrote: How well does this play together with AppEngine 1.7.7? From their release notes: The Java runtime now defaults to Java7. If you still need to use the Java6 runtime, please use the --use_java6 flag when deploying your app. We encourage you to move to Java7 as soon as possible. It sounds I should compile for a 1.7 target. So I should *not* set maven.compiler.source to 1.6, right? I don't know how AppEngine's Java runtime works, but my 7 and 8 JREs are very well capable of running classes compiled with -target 1.6 or earlier, and mixing classes compiled with different -target (you'd never be able to use Maven, or pretty much any third-party dependency actually, if that wasn't the case; btw GWT is compiled with -target 1.6 and is fully compatible with a JDK 7, and we haven't yet heard of anyone having issues using RPC or RequestFactory on AppEngine) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
How well does this play together with AppEngine 1.7.7? From their release notes: The Java runtime now defaults to Java7. If you still need to use the Java6 runtime, please use the --use_java6 flag when deploying your app. We encourage you to move to Java7 as soon as possible. It sounds I should compile for a 1.7 target. So I should *not* set maven.compiler.source to 1.6, right? I hope AppEngine and GWT remain compatible. Do you know more on this? On Thursday, February 21, 2013 2:55:24 PM UTC+1, Thomas Broyer wrote: On Thursday, February 21, 2013 1:32:44 PM UTC+1, Seamus McMorrow wrote: Hi, Sorry for resurrecting a slightly old thread. JDK 1.6 is EOL end of this month, so I am thinking of migrating my GWT project to JDK7 I am using GWT 2.5, and wondering if many people are using JDK7 in their GWT projects. Is it okay to do so and if so, what are the gotchas? GWT 2.5 is fully compatible with JDK 7 (see https://developers.google.com/web-toolkit/release-notes#Release_Notes_2_5_0_RC2 ). Just make sure you only use Java 6 constructs in your client code (in Eclipse, Project properties → Java Compiler, set “JDK Compliance” to 1.6; in Maven, set “maven.compiler.source” and “maven.compiler.target” to 1.6 or 6). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
On Wednesday, April 3, 2013 8:15:03 AM UTC+2, Max Völkel wrote: How well does this play together with AppEngine 1.7.7? From their release notes: The Java runtime now defaults to Java7. If you still need to use the Java6 runtime, please use the --use_java6 flag when deploying your app. We encourage you to move to Java7 as soon as possible. It sounds I should compile for a 1.7 target. So I should *not* set maven.compiler.source to 1.6, right? I don't know how AppEngine's Java runtime works, but my 7 and 8 JREs are very well capable of running classes compiled with -target 1.6 or earlier, and mixing classes compiled with different -target (you'd never be able to use Maven, or pretty much any third-party dependency actually, if that wasn't the case; btw GWT is compiled with -target 1.6 and is fully compatible with a JDK 7, and we haven't yet heard of anyone having issues using RPC or RequestFactory on AppEngine) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
Hi, Sorry for resurrecting a slightly old thread. JDK 1.6 is EOL end of this month, so I am thinking of migrating my GWT project to JDK7 I am using GWT 2.5, and wondering if many people are using JDK7 in their GWT projects. Is it okay to do so and if so, what are the gotchas? Thanks, S On Monday, 1 October 2012 14:59:51 UTC+1, Konstantin Solomatov wrote: And what about JDK8? I think, implementing closures support in GWT makes a lot of sense since you can translate them to native javascript closures. On Wednesday, September 26, 2012 1:21:26 AM UTC+4, Brian Slesinsky wrote: GWT 2.5 rc2 should run on a JDK 7 virtual machine (there was a recent fix to make dev mode work). We've occasionally talked about supporting Java 7 features, but there's no concrete plan or schedule to implement them. - Brian On Tuesday, September 25, 2012 4:38:28 AM UTC-7, Benjamin Wolff wrote: Hi, sorry for gravedigging, but the title of this thread seems suitable. Since Java 6 reaches its End-Of-Life cycle at the beginning of next year, does the GWT team has concrete plans to support Java 7? See: http://www.oracle.com/technetwork/java/eol-135779.html Cheers, Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
Em quinta-feira, 21 de fevereiro de 2013 09h32min44s UTC-3, Seamus McMorrow escreveu: Sorry for resurrecting a slightly old thread. JDK 1.6 is EOL end of this month, so I am thinking of migrating my GWT project to JDK7 I am using GWT 2.5, and wondering if many people are using JDK7 in their GWT projects. Is it okay to do so and if so, what are the gotchas? We are using JDK7 with GWT -- UiBinder, ClientBundle, GWT-RPC -- and Eclipse 4.2. No gotchas so far. -- P. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
On Thursday, February 21, 2013 1:32:44 PM UTC+1, Seamus McMorrow wrote: Hi, Sorry for resurrecting a slightly old thread. JDK 1.6 is EOL end of this month, so I am thinking of migrating my GWT project to JDK7 I am using GWT 2.5, and wondering if many people are using JDK7 in their GWT projects. Is it okay to do so and if so, what are the gotchas? GWT 2.5 is fully compatible with JDK 7 (see https://developers.google.com/web-toolkit/release-notes#Release_Notes_2_5_0_RC2 ). Just make sure you only use Java 6 constructs in your client code (in Eclipse, Project properties → Java Compiler, set “JDK Compliance” to 1.6; in Maven, set “maven.compiler.source” and “maven.compiler.target” to 1.6 or 6). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Java 7
And what about JDK8? I think, implementing closures support in GWT makes a lot of sense since you can translate them to native javascript closures. On Wednesday, September 26, 2012 1:21:26 AM UTC+4, Brian Slesinsky wrote: GWT 2.5 rc2 should run on a JDK 7 virtual machine (there was a recent fix to make dev mode work). We've occasionally talked about supporting Java 7 features, but there's no concrete plan or schedule to implement them. - Brian On Tuesday, September 25, 2012 4:38:28 AM UTC-7, Benjamin Wolff wrote: Hi, sorry for gravedigging, but the title of this thread seems suitable. Since Java 6 reaches its End-Of-Life cycle at the beginning of next year, does the GWT team has concrete plans to support Java 7? See: http://www.oracle.com/technetwork/java/eol-135779.html Cheers, Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/XnxLqk0C7LkJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
When does 2.5 rc2 will be available to download? Thanks, Krzysztof On Tuesday, 25 September 2012 22:21:26 UTC+1, Brian Slesinsky wrote: GWT 2.5 rc2 should run on a JDK 7 virtual machine (there was a recent fix to make dev mode work). We've occasionally talked about supporting Java 7 features, but there's no concrete plan or schedule to implement them. - Brian On Tuesday, September 25, 2012 4:38:28 AM UTC-7, Benjamin Wolff wrote: Hi, sorry for gravedigging, but the title of this thread seems suitable. Since Java 6 reaches its End-Of-Life cycle at the beginning of next year, does the GWT team has concrete plans to support Java 7? See: http://www.oracle.com/technetwork/java/eol-135779.html Cheers, Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/nfvfcGOGkfoJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
Hi, sorry for gravedigging, but the title of this thread seems suitable. Since Java 6 reaches its End-Of-Life cycle at the beginning of next year, does the GWT team has concrete plans to support Java 7? See: http://www.oracle.com/technetwork/java/eol-135779.html Cheers, Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/buQJiZhy3m4J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
GWT 2.5 rc2 should run on a JDK 7 virtual machine (there was a recent fix to make dev mode work). We've occasionally talked about supporting Java 7 features, but there's no concrete plan or schedule to implement them. - Brian On Tuesday, September 25, 2012 4:38:28 AM UTC-7, Benjamin Wolff wrote: Hi, sorry for gravedigging, but the title of this thread seems suitable. Since Java 6 reaches its End-Of-Life cycle at the beginning of next year, does the GWT team has concrete plans to support Java 7? See: http://www.oracle.com/technetwork/java/eol-135779.html Cheers, Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/5Ylnu5MPnZAJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Java 7 - Diamond Operator
Hi everyone, The following error is returned when compiling code using the diamond operator (part of project coin in Java 7). Syntax error on token , ? expected after this token I am using the GWT 2.40 (Plugin - com.google.gwt.eclipse.sdkbundle_2.4.0.v201205091048-rel-r37). The following fragment is a simple example of the diamond operator: ListString names = new ArrayList**(); Question: 1. Does GWT support Java 7 features? 2. What changed do I need to perform in order to have the Java 7 code working without having to change the source? 3. What other features from the latest Java 7 GWT does not support? Thank you in advance for any input. Albert Attard -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/14KX0SNqJUEJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7 - Diamond Operator
On Thursday, June 14, 2012 12:49:55 PM UTC+2, Albert Attard wrote: Question: 1. Does GWT support Java 7 features? No. Not yet. Though it will likely take some time. 1. What changed do I need to perform in order to have the Java 7 code working without having to change the source? In terms of what should be done *within GWT* to make it support Java 7? Well, first and foremost upgrade ECJ to a version that supports Java 7. Hopefully that would be enough to support the diamond operator, and possibly all other Java 7 features. Switch on strings would hwoever greatly benefit from a specific handling in GWT, to compile it to an equivalent switch in JS. 1. What other features from the latest Java 7 GWT does not support? No single one. GWT uses a Java 6 parser, so it only supports Java 6. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/MJiQklnvo2YJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7 - Diamond Operator
Thanks for your reply. Albert On Thursday, June 14, 2012 12:57:36 PM UTC+2, Thomas Broyer wrote: On Thursday, June 14, 2012 12:49:55 PM UTC+2, Albert Attard wrote: Question: 1. Does GWT support Java 7 features? No. Not yet. Though it will likely take some time. 1. What changed do I need to perform in order to have the Java 7 code working without having to change the source? In terms of what should be done *within GWT* to make it support Java 7? Well, first and foremost upgrade ECJ to a version that supports Java 7. Hopefully that would be enough to support the diamond operator, and possibly all other Java 7 features. Switch on strings would hwoever greatly benefit from a specific handling in GWT, to compile it to an equivalent switch in JS. 1. What other features from the latest Java 7 GWT does not support? No single one. GWT uses a Java 6 parser, so it only supports Java 6. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/QdwYFrC4TR0J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7 - Diamond Operator
The page ( https://developers.google.com/web-toolkit/doc/latest/DevGuideCodingBasicsCompatibility) only mentions support for Java 1.5. Sorry for the trouble, I missed it before. I was looking for diamond operator before and found nothing, where my search criteria had to be different :(. There are plenty of posts about this. Thanks again, Albert Attard On Thursday, June 14, 2012 12:57:36 PM UTC+2, Thomas Broyer wrote: On Thursday, June 14, 2012 12:49:55 PM UTC+2, Albert Attard wrote: Question: 1. Does GWT support Java 7 features? No. Not yet. Though it will likely take some time. 1. What changed do I need to perform in order to have the Java 7 code working without having to change the source? In terms of what should be done *within GWT* to make it support Java 7? Well, first and foremost upgrade ECJ to a version that supports Java 7. Hopefully that would be enough to support the diamond operator, and possibly all other Java 7 features. Switch on strings would hwoever greatly benefit from a specific handling in GWT, to compile it to an equivalent switch in JS. 1. What other features from the latest Java 7 GWT does not support? No single one. GWT uses a Java 6 parser, so it only supports Java 6. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/3C3uGa67GKUJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
Just stumbled on that: Note: As of GWT 1.5, GWT compiles the Java language syntax that is compatible with J2SE 1.5 or earlier. Versions of GWT prior to GWT 1.5 are limited to Java 1.4 source compatibility. For example, GWT 2.0 supports generics, whereas GWT 1.4 does not. — *Source: * http://code.google.com/webtoolkit/doc/latest/DevGuideCodingBasicsCompatibility.html And the warning about support for Java 1.5 being deprecated since GWT 2.2 is done by checking at the current JVM: http://code.google.com/p/google-web-toolkit/source/detail?r=9636 This is different from what GWT accepts as input, which then *officially* doesn't support Java 6 (even though it emulates java.lang.String.isEmpty() and accepts @Override on interface-method's implementations, which makes it practically usable with (most) Java 6 source files). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/QU38WfzTl0sJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
On Jul 5, 1:21 am, Magno Machado magn...@gmail.com wrote: Is there any current work on supporting java 7 syntax on gwt? Will it be available on GWT 2.4? I think this question is of general interest. But as nobody replied yet, I suppose not :( -Alex -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
Well, GWT uses Eclipse's JDT (a patched version AFAIK), so it would first have to be updated to a version that supports Java 7, and then GWT code updated to support the changes (such as mapping switch on strings to the same switch on strings construct in JavaScript). …but Eclipse's JDT support for Java7 is still in beta, so… See http://wiki.eclipse.org/JDT/Eclipse_Java_7_Support_(BETA) and http://wiki.eclipse.org/JDT_Core/Java7 Also, GWT added support for Java 5 when Java 1.4 reached EOL, and Java 6 was already released, and GWT does not officially support Java 6 (that's going to change, and a few features are already there, such as @Override on implementations of interface methods, and String#isEmpty); let's hope it'll be faster for Java 7, but don't be too impatient IMO. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/7Cg33qsKa0gJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
Also, GWT added support for Java 5 when Java 1.4 reached EOL, and Java 6 was already released, and GWT does not officially support Java 6 (that's going to change, and a few features are already there, such as @Override on implementations of interface methods, and String#isEmpty); let's hope it'll be faster for Java 7, but don't be too impatient IMO. Are you sure this is true? I thought 1.6 is supported as of 2.3, but not required. 1.6 will be required in future releases of GWT however (it may be required for 2.3, i'm not sure) but I know commits to trunk are going in with @Override on interface methods, so in order to get stuff to compile 1.6 will be required. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/Laj9dlhZOe8J. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7
GWT requiring a Java6 JVM is different from officially supporting Java 6 language features in what the GWT Compiler accepts as input ;-) (I believe Java 6 is supported –as I said, at least some features already are, for quite some time, and I've almost always been using Java 6 compliance level in Eclipse without any issue–, what I don't know is whether we can call it official support for Java 6 –a couple features might not be enough for that claim, or maybe they are?–) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit https://groups.google.com/d/msg/google-web-toolkit/-/3RqkCd6MYPIJ. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Java 7
Java 7 is going to be released in a few days and will introduce some changes on the java syntax Is there any current work on supporting java 7 syntax on gwt? Will it be available on GWT 2.4? -- Magno Machado Paulo http://blog.magnomachado.com.br http://code.google.com/p/emballo/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
is it possible to use Java 7 in GWT ?
Hello, is it possible to use Java 7 in GWT ? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
Re: Java 7 And Closures
Hi, well, without wanting to be destructive: where is the big difference compared to the command pattern? I really like GWT's stability and maturity. I'd like to keep it as simple and straightforward as possible. It would be great if that stays as the design goal - and whether or not J7 closures come in, I still like the command pattern... Regards Sebastian On Jul 19, 8:15 pm, dolcra...@gmail.com dolcra...@gmail.com wrote: I think GWT should refrain from including Java 7 features until it is released at least... On Jul 19, 1:48 pm, Daniel Simons daniel.simo...@gmail.com wrote: Hey Guys, I was wondering if there have been plans centered around including Java 7 features such as closures to future versions of GWT. Thanks, Daniel -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
