Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 3:59 p.m.) Review request for mesos and Timothy Chen. Changes --- Style fixes Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36574: Added a helper testing functions for Labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/ --- (Updated July 21, 2015, 12:45 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Changes --- addressed BenH's comments. Summary (updated) - Added a helper testing functions for Labels. Bugs: MESOS-3076 https://issues.apache.org/jira/browse/MESOS-3076 Repository: mesos Description (updated) --- * createLabel(key, value) return a new key:value Label. Diffs (updated) - src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 Diff: https://reviews.apache.org/r/36574/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/ --- (Updated July 21, 2015, 12:45 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Changes --- Rebased Bugs: MESOS-3076 https://issues.apache.org/jira/browse/MESOS-3076 Repository: mesos Description --- The labels would allow executors and Slave modules to pass in some meta-data about the task to the framework and Mesos-DNS (via state.json). Diffs (updated) - include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 src/common/protobuf_utils.hpp afe5a85d3f58eaabb16807253c5fcc07cabcf8e8 src/common/protobuf_utils.cpp 9ac81c38efd70f92c64a5865fa79fe516e84dd92 src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 Diff: https://reviews.apache.org/r/36575/diff/ Testing --- make check with new tests to verify state.json output. Thanks, Kapil Arya
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 4:42 p.m.) Review request for mesos and Timothy Chen. Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36425: Enabling IP Discovery script
On July 19, 2015, 8:09 p.m., Benjamin Hindman wrote:
src/master/main.cpp, line 139
https://reviews.apache.org/r/36425/diff/4/?file=1010039#file1010039line139
We've tried to name our flags the same as how you'd see them on the
command line, so s/ipDiscoveryScript/ip_discovery_script/ here please.
Also, what about s/script/command/ here? Since we might not be
executing a script here and it's more inline with the fact that we'll be
executing this via the shell (i.e., it's a shell command, as opposed to say
doing s/script/executable/ which might imply we're going to fork/exec).
I'd actually asked about this to Nik - so long as we're clear that we're
breaking the style guide here, I guess it's ok.
There's also no good reason for it (apart from tradition? or consistency?)
as we could have the default snake_to_camelCase convention for flags.
http://despair.com/collections/demotivators/products/consistency
On July 19, 2015, 8:09 p.m., Benjamin Hindman wrote:
src/master/main.cpp, lines 181-209
https://reviews.apache.org/r/36425/diff/4/?file=1010039#file1010039line181
Apologies for not giving you this feedback sooner, but we already have
a wrapper for `popen` with `os::shell`. It's used a handful of places in
the code instead of `popen`:
ostringstream out;
Tryint status = os::shell(out, ip_discovery_script.get());
if (status.isError()) {
EXIT(EXIT_FAILURE) ...;
} else if (WIFSIGNALED(status.get())) {
EXIT(EXIT_FAILURE) ... strsignal(WTERMSIG(status.get()));
} else if (WEXITSTATUS(status.get()) != EXIT_SUCCESS) {
EXIT(EXIT_FAILURE) ... stringify
(WEXITSTATUS(status.get()));
}
const string ipAddress = strings::trim(out.get());
LOG(INFO) ...;
os::setenv(LIBPROCESS_IP, ipAddress);
LoL - no one seemed to know about it :) I asked in the 'core' slack and was
pointed to at least five different ways of doing this.
Thanks!
On July 19, 2015, 8:09 p.m., Benjamin Hindman wrote:
src/master/main.cpp, line 184
https://reviews.apache.org/r/36425/diff/4/?file=1010039#file1010039line184
What is process::executeCommand? Did you mean process::subprocess here?
it's the method I'm introducing in the patch immediately before this:
https://reviews.apache.org/r/36424/
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review92219
---
On July 13, 2015, 9:35 p.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/
---
(Updated July 13, 2015, 9:35 p.m.)
Review request for mesos, Benjamin Hindman and Cody Maloney.
Bugs: MESOS-2902
https://issues.apache.org/jira/browse/MESOS-2902
Repository: mesos
Description
---
Jira: MESOS-2902
It is sometimes useful to enable an external script to
configure the IP address the Mesos Master will bind to
on the server, where it's not desirable to set the
--ip flag and/or a wrapper script is not a viable option.
This patch adds a --ip_discovery_script to point to a local
script that will emit as its only output the IP address that
the Master will bind to: only spaces and newlines are allowed;
further, as we cannot use the `libprocess` sub-processing
facilities, we cannot timeout the script, should this block
for long times (or even forever).
This will override the --ip flag, which, even if set, will be
ignored.
Diffs
-
docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01
src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1
Diff: https://reviews.apache.org/r/36425/diff/
Testing
---
make check
Thanks,
Marco Massenzio
Re: Review Request 36667: Moved createLabel to protobuf_utils.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36667/#review92531 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 11:37 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36667/ --- (Updated July 21, 2015, 11:37 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary Diffs - src/common/protobuf_utils.hpp 64974c57b91747409f37457b4df0cafe239eef59 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/mesos.hpp f14b8f721e057efbd93dd38263c22b4b4e3881da src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36667/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/#review92532 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 11:37 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/ --- (Updated July 21, 2015, 11:37 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary Diffs - src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36668/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/#review92533 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 12:46 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- (Updated July 22, 2015, 12:46 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- The expected value should come first. Diffs - src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 4:37 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36673: Removed pthread from Once and Gate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92539 --- Ship it! But see comments on https://reviews.apache.org/r/36629 regarding parameters of `synchronized_wait`. - Benjamin Hindman On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 22, 2015, 5:55 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- addressed issues. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/ --- (Updated July 22, 2015, 5:56 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Changes --- address issues. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs (updated) - include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 include/mesos/scheduler.hpp 9dae0a8f5af168f25eb462e30473f8fd7da50913 src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 Diff: https://reviews.apache.org/r/36674/diff/ Testing --- make check Thanks, Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote: 3rdparty/libprocess/src/gate.hpp, line 18 https://reviews.apache.org/r/36673/diff/1/?file=1018363#file1018363line18 Is this todo still valid? Joris Van Remoortere wrote: Sort of. Although it is true that std::mutex is implemented using futex, you could in theory directly implement on them? Ben, what do you think? We can kill this TODO. ;-) I think it's from 2008 (pre Mesos). - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92538 --- On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36404: Added support for peek() to process::io
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated July 21, 2015, 10:29 p.m.) Review request for mesos, Joris Van Remoortere and Joseph Wu. Changes --- Rebased and changed comments to Doxygen format. Repository: mesos Description --- JIRA: https://issues.apache.org/jira/browse/MESOS-2964 Diffs (updated) - 3rdparty/libprocess/include/process/io.hpp 975923f40f82357f31b89428f24d01df6a8ac9fc 3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 3rdparty/libprocess/src/tests/io_tests.cpp c642bab9e2845668767ad237985cb9ce1109 Diff: https://reviews.apache.org/r/36404/diff/ Testing --- - Added a test case for process::io::peek - make check Thanks, Artem Harutyunyan
Re: Review Request 36425: Enabling IP Discovery script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 21, 2015, 4:47 p.m.) Review request for mesos, Benjamin Hindman and Cody Maloney. Changes --- Addressed Ben's comments. Bugs: MESOS-2902 https://issues.apache.org/jira/browse/MESOS-2902 Repository: mesos Description --- Jira: MESOS-2902 It is sometimes useful to enable an external script to configure the IP address the Mesos Master will bind to on the server, where it's not desirable to set the --ip flag and/or a wrapper script is not a viable option. This patch adds a --ip_discovery_script to point to a local script that will emit as its only output the IP address that the Master will bind to: only spaces and newlines are allowed; further, as we cannot use the `libprocess` sub-processing facilities, we cannot timeout the script, should this block for long times (or even forever). This will override the --ip flag, which, even if set, will be ignored. Diffs (updated) - docs/configuration.md babbd2f67b32d4f317cfdf8bb87f8725917b0aca src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 Diff: https://reviews.apache.org/r/36425/diff/ Testing --- make check Thanks, Marco Massenzio
Re: Review Request 36585: Exposed docker container IP via state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 21, 2015, 1:02 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Changes --- Updated to expsoe just the IP. Summary (updated) - Exposed docker container IP via state.json Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description (updated) --- This would allow Mesos-DNS to lookup container information such as its IP address. Diffs (updated) - src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504 src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16 src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43 Diff: https://reviews.apache.org/r/36585/diff/ Testing --- sudo make check Thanks, Kapil Arya
Re: Review Request 36596: Added jsonify() to stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36596/#review92431 --- Bad patch! Reviews applied: [36596] Failed command: ./support/apply-review.sh -n -r 36596 Error: 2015-07-21 17:07:43 URL:https://reviews.apache.org/r/36596/diff/raw/ [8815/8815] - 36596.patch [1] Successfully applied: Added jsonify() to stout. The jsonify() function converts a Protobuf/string/double/bool to JSON::Value. Added some tests as well. Review: https://reviews.apache.org/r/36596 Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: stout: 3rdparty/libprocess/3rdparty/stout/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp libprocess: 3rdparty/libprocess/3rdparty/Makefile.am Failed to commit patch - Mesos ReviewBot On July 19, 2015, 12:43 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36596/ --- (Updated July 19, 2015, 12:43 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- The jsonify() function converts a Protobuf/string/double/bool to JSON::Value. Added some tests as well. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 3rdparty/libprocess/3rdparty/stout/Makefile.am 89e7b1854bd7f449f4f0027d76c6430d259a24de 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36596/diff/ Testing --- make check with added tests. Thanks, Kapil Arya
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing (updated) --- sudo make check Thanks, Joerg Schad
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:46 p.m.) Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Timothy St. Clair. Changes --- Address Ben's complaints. Repository: mesos Description --- This commit is the second in a series of two commits that will introduce a CMake-based build system for Mesos. The first introduced the build system for the core Mesos project; this one will introduce a similar system for the process library. For more details see the core Mesos commit. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/cmake/ProcessConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/External.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/PatchCommand.cmake PRE-CREATION 3rdparty/libprocess/src/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer
Re: Review Request 36580: Added TaskStatus label decorator hook for Slave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/ --- (Updated July 21, 2015, 12:46 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Changes --- removed master hook; addressed BenH's comments. Summary (updated) - Added TaskStatus label decorator hook for Slave Repository: mesos Description (updated) --- This allows Slave modules to expose some information to the frameworks as well as Mesos-DNS via state.json. Diffs (updated) - include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db Diff: https://reviews.apache.org/r/36580/diff/ Testing --- make check with a new hook test. Thanks, Kapil Arya
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92432 --- Could you please attach a ticket or explain in the description about the motivation? - Jie Yu On July 21, 2015, 4:42 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 4:42 p.m.) Review request for mesos and Timothy Chen. Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92448 --- Bad patch! Reviews applied: [36513, 36514] Failed command: ./support/apply-review.sh -n -r 36514 Error: 2015-07-21 18:18:35 URL:https://reviews.apache.org/r/36514/diff/raw/ [26989/26989] - 36514.patch [1] Successfully applied: [MESOS-898] Add CMake-based build system for the process library This commit is the second in a series of two commits that will introduce a CMake-based build system for Mesos. The first introduced the build system for the core Mesos project; this one will introduce a similar system for the process library. For more details see the core Mesos commit. Review: https://reviews.apache.org/r/36514 No files to lint ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: CMakeLists.txt libprocess: 3rdparty/libprocess/3rdparty/CMakeLists.txt 3rdparty/libprocess/CMakeLists.txt 3rdparty/libprocess/cmake/ProcessConfigure.cmake 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3rdparty/libprocess/cmake/macros/External.cmake 3rdparty/libprocess/cmake/macros/PatchCommand.cmake 3rdparty/libprocess/src/CMakeLists.txt 3rdparty/libprocess/src/tests/CMakeLists.txt Failed to commit patch - Mesos ReviewBot On July 21, 2015, 4:54 p.m., Alex Clemmer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:54 p.m.) Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Timothy St. Clair. Repository: mesos Description --- This commit is the second in a series of two commits that will introduce a CMake-based build system for Mesos. The first introduced the build system for the core Mesos project; this one will introduce a similar system for the process library. For more details see the core Mesos commit. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/cmake/ProcessConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/External.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/PatchCommand.cmake PRE-CREATION 3rdparty/libprocess/src/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer
Re: Review Request 36617: Improved task reconciliation documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92436 --- can you add @bmahler to the review? docs/reconciliation.md (line 45) https://reviews.apache.org/r/36617/#comment146601 Master doesn't check if the task states match, it just reponds with the latest state of the tasks. docs/reconciliation.md (line 83) https://reviews.apache.org/r/36617/#comment146602 s/just restarted/restarts/ docs/reconciliation.md (line 87) https://reviews.apache.org/r/36617/#comment146603 Also add a blurb about explicit reconciliation of tasks that belong to transitionary slaves. docs/reconciliation.md (line 96) https://reviews.apache.org/r/36617/#comment146604 what about other terminal states? docs/reconciliation.md (line 98) https://reviews.apache.org/r/36617/#comment146605 what does this mean? s/Let/Ask/ ? - Vinod Kone On July 21, 2015, 9:29 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 21, 2015, 9:29 a.m.) Review request for mesos and Joerg Schad. Repository: mesos Description --- Improved task reconciliation documentation. Diffs - docs/reconciliation.md 17537ba8420c95d833e64ccf82ff9bb4530497f0 Diff: https://reviews.apache.org/r/36617/diff/ Testing --- https://gist.github.com/nfnt/73532d62fe39d27ff33d Thanks, Jan Schlicht
Re: Review Request 36625: Windows: Splitting platform specific functions into separate headers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36625/ --- (Updated July 21, 2015, 11:10 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joris Van Remoortere. Changes --- Add modifications to Makefile.am. Style changes. Bugs: MESOS-3101 https://issues.apache.org/jira/browse/MESOS-3101 Repository: mesos Description --- To avoid having `#if defined(_WIN32)` all over the code. This first patch is to establish a pattern in splitting up the headers. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 3aa9487bed2df038ca27a8bb94c24608ca7910a4 3rdparty/libprocess/3rdparty/stout/include/stout/linux/abort.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/windows/abort.hpp PRE-CREATION Diff: https://reviews.apache.org/r/36625/diff/ Testing --- `make` and `make check` Thanks, Joseph Wu
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92521 --- Ship it! 3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines 140 - 141) https://reviews.apache.org/r/36514/#comment146729 I'll kill spaces before committing. CMakeLists.txt (line 27) https://reviews.apache.org/r/36514/#comment146728 This needs to be in the previous review, I'll fix up for you before committing. - Benjamin Hindman On July 21, 2015, 4:54 p.m., Alex Clemmer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:54 p.m.) Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Timothy St. Clair. Repository: mesos Description --- This commit is the second in a series of two commits that will introduce a CMake-based build system for Mesos. The first introduced the build system for the core Mesos project; this one will introduce a similar system for the process library. For more details see the core Mesos commit. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/cmake/ProcessConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/External.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/PatchCommand.cmake PRE-CREATION 3rdparty/libprocess/src/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer
Re: Review Request 36629: stout: Added support for 'synchronized_wait'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/#review92537 --- Ship it! Great, can we do the 70 character comment wraps here though? Thanks! 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 165) https://reviews.apache.org/r/36629/#comment146743 s/support/supported/ 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 177) https://reviews.apache.org/r/36629/#comment146744 Can we use pointers here and below please? Thanks! 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 210) https://reviews.apache.org/r/36629/#comment146746 Newline before we start this comment and the one below? 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp (line 230) https://reviews.apache.org/r/36629/#comment146745 Awesome awesome awesome sauce. - Benjamin Hindman On July 21, 2015, 1:11 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/ --- (Updated July 21, 2015, 1:11 a.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85 Diff: https://reviews.apache.org/r/36629/diff/ Testing --- `make check` Thanks, Michael Park
Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- (Updated July 21, 2015, 8:46 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- The expected value should come first. Diffs - src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya
Review Request 36669: Fixed the order of expected value in EXPECT_EQ.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- The expected value should come first. Diffs - src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/#review92524 --- Patch looks great! Reviews applied: [36667, 36668, 36669] All tests passed. - Mesos ReviewBot On July 22, 2015, 12:46 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36669/ --- (Updated July 22, 2015, 12:46 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- The expected value should come first. Diffs - src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/#review92518 --- Patch looks great! Reviews applied: [36667, 36668] All tests passed. - Mesos ReviewBot On July 21, 2015, 11:37 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/ --- (Updated July 21, 2015, 11:37 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary Diffs - src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36668/diff/ Testing --- make check Thanks, Kapil Arya
Review Request 36673: Removed pthread from Once and Gate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92534 --- Ship it! 3rdparty/libprocess/src/openssl.cpp (line 489) https://reviews.apache.org/r/36656/#comment146739 Can we leave a longer comment as to why we do this? Maybe link to something if that's helpful? Maybe even include a quick comment where we define the flags why we specifically omit v2 there as well? It'll be helpful to leave a nice trail of breadcrumbs so someone else doesn't come and try and re-add it. 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 674) https://reviews.apache.org/r/36656/#comment146740 We missed some! s/openssl/OpenSSL/ ;-) Here and throughout please. - Benjamin Hindman On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92543 --- Ship it! docs/home.md (line 27) https://reviews.apache.org/r/36658/#comment146754 s/ssl/SSL/ ;-) docs/mesos-ssl.md (line 51) https://reviews.apache.org/r/36658/#comment146753 I thought you said it was also broken on some distribution ... does broken here just mean insecure or actually doesn't work? Please clarify and/or update this comment and then let's commit. Thanks! - Benjamin Hindman On July 21, 2015, 10:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Review Request 36674: Removed pthread and used Latch in executor and scheduler drivers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36674/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - include/mesos/executor.hpp f3cd3ccd505ed4b308a1a42b238fc21fe45cc3b3 include/mesos/scheduler.hpp 9dae0a8f5af168f25eb462e30473f8fd7da50913 src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3 src/sched/sched.cpp 25e2d660f4ee4c0b21c887f78ad04819012966f9 Diff: https://reviews.apache.org/r/36674/diff/ Testing --- make check Thanks, Joris Van Remoortere
Review Request 36672: Removed pthread specialization from Synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85 Diff: https://reviews.apache.org/r/36672/diff/ Testing --- Breaking patch, requires dependent patches. Thanks, Joris Van Remoortere
Re: Review Request 36672: Removed pthread specialization from Synchronized.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/#review92536 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36672/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3118 https://issues.apache.org/jira/browse/MESOS-3118 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/synchronized.hpp e40ec55f7818fad8703787ecb67869c9e1922e85 Diff: https://reviews.apache.org/r/36672/diff/ Testing --- Breaking patch, requires dependent patches. Thanks, Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92538 --- 3rdparty/libprocess/src/gate.hpp (line 18) https://reviews.apache.org/r/36673/#comment146747 Is this todo still valid? - Artem Harutyunyan On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 21, 2015, 9:07 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote: 3rdparty/libprocess/src/gate.hpp, line 18 https://reviews.apache.org/r/36673/diff/1/?file=1018363#file1018363line18 Is this todo still valid? Sort of. Although it is true that std::mutex is implemented using futex, you could in theory directly implement on them? Ben, what do you think? - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92538 --- On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/ --- (Updated July 22, 2015, 4:07 a.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3119 https://issues.apache.org/jira/browse/MESOS-3119 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b Diff: https://reviews.apache.org/r/36673/diff/ Testing --- make check in libprocess. Thanks, Joris Van Remoortere
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92549 --- Bad patch! Reviews applied: [36612] Failed command: ./support/apply-review.sh -n -r 36612 Error: 2015-07-22 05:28:09 URL:https://reviews.apache.org/r/36612/diff/raw/ [12620/12620] - 36612.patch [1] error: patch failed: src/linux/cgroups.hpp:92 error: src/linux/cgroups.hpp: patch does not apply error: patch failed: src/linux/cgroups.cpp:110 error: src/linux/cgroups.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On July 22, 2015, 4:37 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 4:37 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36663: Added ip_address field to MasterInfo
On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote: LGTM, thanks for adding much needed documentation too for the fields ! Upon reading the corresponding JIRA, I am assuming that we had an agreement to not use the Address field that BenM introduced in r36450 for readability of the field. Well, I summarized the alternatives and put forward my recommendation - that was on 6/15: there was no further comment since, so I acted on the principle of lazy consensus. Also, please note that this will be serialized in JSON and the users of this are largely assumed NOT to use libmesos, so the benefits of the `Address` protobuf are very limited (in fact, it makes the generated JSON more difficult to parse and the entire structure more confusing; as I articulated in MESOS-2736) as we cannot remove existing fields without breaking backward compatibility, and the information would be repeated in difference places making the whole thing mightily confusing. On July 21, 2015, 11:59 p.m., Anand Mazumdar wrote: include/mesos/mesos.proto, line 382 https://reviews.apache.org/r/36663/diff/1/?file=1018235#file1018235line382 Minor Nitpick : Did you refer to a name; here instead of name: Thanks, you're right `;` works better. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 --- On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 21, 2015, 10:50 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2736 https://issues.apache.org/jira/browse/MESOS-2736 Repository: mesos Description --- As part of the new HTTP API and the need to provide a better interface for clients that do not integrate libmesos, we provide the IP address of the Leader Master in string format; this will eventually supersed the int32 existing `ip`, which also cannot support IPv6 addresses. Jira: MESOS-2736 Diffs - include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 Diff: https://reviews.apache.org/r/36663/diff/ Testing --- make check (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio
Re: Review Request 36514: [MESOS-898] Add CMake-based build system for the process library
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/#review92520 --- Ship it! Ship It! - Benjamin Hindman On July 21, 2015, 4:54 p.m., Alex Clemmer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36514/ --- (Updated July 21, 2015, 4:54 p.m.) Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Timothy St. Clair. Repository: mesos Description --- This commit is the second in a series of two commits that will introduce a CMake-based build system for Mesos. The first introduced the build system for the core Mesos project; this one will introduce a similar system for the process library. For more details see the core Mesos commit. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/cmake/ProcessConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/External.cmake PRE-CREATION 3rdparty/libprocess/cmake/macros/PatchCommand.cmake PRE-CREATION 3rdparty/libprocess/src/CMakeLists.txt PRE-CREATION 3rdparty/libprocess/src/tests/CMakeLists.txt PRE-CREATION CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/36514/diff/ Testing --- Includes tests for the process library that all run and pass. Thanks, Alex Clemmer
Re: Review Request 36618: Fixed ROOT_CGROUPS_Tasks and ROOT_CGROUPS_Read on Ubunu 14.04.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36618/#review92546 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2015, 2:56 p.m., Artem Harutyunyan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36618/ --- (Updated July 20, 2015, 2:56 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-3079 https://issues.apache.org/jira/browse/MESOS-3079 Repository: mesos Description --- See summary. Diffs - src/tests/cgroups_tests.cpp 9f5028f831a5a2fd4f7f0a0b7459c184ea9598fb Diff: https://reviews.apache.org/r/36618/diff/ Testing --- sudo make check Thanks, Artem Harutyunyan
Review Request 36676: Removed pthread from Zookeeper test helper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36676/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park. Bugs: MESOS-3120 https://issues.apache.org/jira/browse/MESOS-3120 Repository: mesos Description --- See summary. Diffs - src/tests/zookeeper.hpp 32fc83b95cd779fdf9b75460a7daeb9a053f21b6 src/tests/zookeeper.cpp 5012017226bd08d3c0ddc2fd625e3db442497cee Diff: https://reviews.apache.org/r/36676/diff/ Testing --- Make check. Waiting for reviewbot to run java based tests. Thanks, Joris Van Remoortere
Re: Review Request 36585: Exposed docker container IP via state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92452 --- src/docker/executor.cpp (line 163) https://reviews.apache.org/r/36585/#comment146623 I like this a lot better, but I'm still thinking if this is what labels are intended for, and what is the implications of storing this in the labels. - Timothy Chen On July 21, 2015, 5:02 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 21, 2015, 5:02 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allow Mesos-DNS to lookup container information such as its IP address. Diffs - src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504 src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16 src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43 Diff: https://reviews.apache.org/r/36585/diff/ Testing --- sudo make check Thanks, Kapil Arya
Re: Review Request 34137: Add support for container image provisioners.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review92462 --- Ship it! Ship It! - Jie Yu On July 12, 2015, 4:47 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/ --- (Updated July 12, 2015, 4:47 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- The MesosContainerizer can optionally provision a root filesystem for the containers. Diffs - include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91 src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 src/slave/containerizer/provisioner.hpp PRE-CREATION src/slave/containerizer/provisioner.cpp PRE-CREATION src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 src/slave/paths.hpp 00476f107ed8233123a6eab0925c9f28aac0a86f src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 src/slave/state.hpp bb0eee78e118210ccd7fcbd909029412ff106128 src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7 src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 36585: Exposed docker container IP via state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92456 --- Patch looks great! Reviews applied: [36574, 36575, 36580, 36585] All tests passed. - Mesos ReviewBot On July 21, 2015, 5:02 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 21, 2015, 5:02 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allow Mesos-DNS to lookup container information such as its IP address. Diffs - src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504 src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16 src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43 Diff: https://reviews.apache.org/r/36585/diff/ Testing --- sudo make check Thanks, Kapil Arya
Re: Review Request 34137: Add support for container image provisioners.
On July 17, 2015, 1:36 a.m., Jie Yu wrote: src/slave/containerizer/mesos/containerizer.cpp, lines 637-643 https://reviews.apache.org/r/34137/diff/3/?file=1009143#file1009143line637 No test for checkpointing??? I decided to punt this in this review. Will follow up with a test shortly. The idea is to create a TestProvisioner which will prepare a chroot based on copying the host filesystem (similar to that in launch_tests.cpp). - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review92000 --- On July 12, 2015, 4:47 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/ --- (Updated July 12, 2015, 4:47 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- The MesosContainerizer can optionally provision a root filesystem for the containers. Diffs - include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91 src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 src/slave/containerizer/provisioner.hpp PRE-CREATION src/slave/containerizer/provisioner.cpp PRE-CREATION src/slave/flags.hpp 26c778db2303167369af8675fe0441a00a1e9151 src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3 src/slave/paths.hpp 00476f107ed8233123a6eab0925c9f28aac0a86f src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 src/slave/state.hpp bb0eee78e118210ccd7fcbd909029412ff106128 src/slave/state.cpp f8a9514f52bf9f886171c2a0e674e5a89f8dbea7 src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92457 --- src/linux/cgroups.cpp (line 1504) https://reviews.apache.org/r/36620/#comment146628 This is actually the Freezer right? And we should make this VLOG(1) src/linux/cgroups.cpp (line 1627) https://reviews.apache.org/r/36620/#comment146629 To me this doesn't killer doesn't atomically kill all of them, as that implies either all or none. I think the TaskKiller actually best effort try to kill by signal and reintrospect all tasks in a cgroup within the timeout src/linux/cgroups.cpp (line 1650) https://reviews.apache.org/r/36620/#comment146630 100 ms seems way too fast? And why not use the default timeout that's already there? src/linux/cgroups.cpp (line 1668) https://reviews.apache.org/r/36620/#comment146632 This should go to line 1674? src/linux/cgroups.cpp (line 1676) https://reviews.apache.org/r/36620/#comment146631 Move to previous line. src/linux/cgroups.cpp (line 1684) https://reviews.apache.org/r/36620/#comment146633 This fits on to previous line? - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92459 --- src/linux/cgroups.cpp (line 1671) https://reviews.apache.org/r/36620/#comment146638 It's very odd to see the failure message set here but then a lot more attempts to try to set it in the finished callback. How about having a failed method that sets the failure and another finished callback that is what you have? src/linux/cgroups.cpp (line 1683) https://reviews.apache.org/r/36620/#comment146637 Very wierd identation? src/linux/cgroups.cpp (line 1686) https://reviews.apache.org/r/36620/#comment146634 //check - // Check src/linux/cgroups.cpp (line 1688) https://reviews.apache.org/r/36620/#comment146636 one more space to the right src/linux/cgroups.cpp (line 1708) https://reviews.apache.org/r/36620/#comment146635 extra space between the and pids - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/#review92479 --- Patch looks great! Reviews applied: [36646] All tests passed. - Mesos ReviewBot On July 21, 2015, 8:30 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- (Updated July 21, 2015, 8:30 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-2963 https://issues.apache.org/jira/browse/MESOS-2963 Repository: mesos Description --- Also added libevent dependency to jenkins build. In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL. Diffs - support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef Diff: https://reviews.apache.org/r/36646/diff/ Testing --- `OS=CENTOS COMPILER=GCC CONFIGURATION=--enable-libevent --enable-ssl ./support/jenkins_build.sh` Thanks, Joris Van Remoortere
Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- Updated SSL documentation. Added to home page. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2. Diffs - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Re: Review Request 36612: Cleanup of right angle brackets in cgroups code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36612/#review92474 --- Ship it! Ship It! - Timothy Chen On July 20, 2015, 8:36 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36612/ --- (Updated July 20, 2015, 8:36 a.m.) Review request for mesos and Timothy Chen. Bugs: Mesos-3086 https://issues.apache.org/jira/browse/Mesos-3086 Repository: mesos Description --- Cleanup of right angle brackets in cgroups code. Diffs - src/linux/cgroups.hpp a47f9a26ead097d5b9a1cf605844d2801d9db6d5 src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36612/diff/ Testing --- make check ubuntu 14.4 Thanks, Joerg Schad
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92480 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 183 - 185) https://reviews.apache.org/r/34135/#comment146681 I just realized an issue here (not your fault). Since we don't checkpoint 'resources' in this isolator, when slave restarts and recovers, the 'resources' in Info will be empty, but there are symlinks exists in the sandbox. We'll end up with trying to create already exist symlinks (and fail). I think this is easy to resolve because we can just ignore EEXIST. Also, it's likely that we fail to remove some symlinks because they do not exist (e.g., a task finishes but the slave crashes after containerizer-update is called but before the status update is checkpointed). - Jie Yu On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92487 --- Patch looks great! Reviews applied: [36656, 36658] All tests passed. - Mesos ReviewBot On July 21, 2015, 9:39 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 21, 2015, 9:39 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- Updated SSL documentation. Added to home page. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 36574: Added a helper testing functions for Labels.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/#review92463 --- Ship it! src/tests/mesos.hpp (line 1382) https://reviews.apache.org/r/36574/#comment146658 We should really move this to src/common/protobuf_utils.cpp. - Benjamin Hindman On July 21, 2015, 4:45 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36574/ --- (Updated July 21, 2015, 4:45 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Bugs: MESOS-3076 https://issues.apache.org/jira/browse/MESOS-3076 Repository: mesos Description --- * createLabel(key, value) return a new key:value Label. Diffs - src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 Diff: https://reviews.apache.org/r/36574/diff/ Testing --- make check Thanks, Kapil Arya
Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-2963 https://issues.apache.org/jira/browse/MESOS-2963 Repository: mesos Description --- Also added libevent dependency to jenkins build. In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL. Diffs - support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef Diff: https://reviews.apache.org/r/36646/diff/ Testing --- `OS=CENTOS COMPILER=GCC CONFIGURATION=--enable-libevent --enable-ssl ./support/jenkins_build.sh` Thanks, Joris Van Remoortere
Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/#review92464 --- Ship it! src/tests/master_tests.cpp (line 3198) https://reviews.apache.org/r/36575/#comment146659 I know you're just copying code from previous tests, but I'd like to suggest that we come back here and replace trailing underscore variable names, in this case we can cleanly do something like s/labelsObject_/find/ and then `JSON::Array labelsObject = find.get();` below. - Benjamin Hindman On July 21, 2015, 4:45 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36575/ --- (Updated July 21, 2015, 4:45 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Bugs: MESOS-3076 https://issues.apache.org/jira/browse/MESOS-3076 Repository: mesos Description --- The labels would allow executors and Slave modules to pass in some meta-data about the task to the framework and Mesos-DNS (via state.json). Diffs - include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 src/common/http.cpp 2bb1ba87a2755a4bd9b762280dea6fce81db1320 src/common/protobuf_utils.hpp afe5a85d3f58eaabb16807253c5fcc07cabcf8e8 src/common/protobuf_utils.cpp 9ac81c38efd70f92c64a5865fa79fe516e84dd92 src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc src/tests/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 Diff: https://reviews.apache.org/r/36575/diff/ Testing --- make check with new tests to verify state.json output. Thanks, Kapil Arya
Re: Review Request 36580: Added TaskStatus label decorator hook for Slave
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/#review92467
---
Ship it!
src/examples/test_hook_module.cpp (line 166)
https://reviews.apache.org/r/36580/#comment146668
I'd explicitly call out the test, so that a reader of the code can
understand the global invariant here.
src/hook/manager.cpp (line 212)
https://reviews.apache.org/r/36580/#comment146665
Why do we copy the result into a TaskStatus only to return it below? seems
like the code here should just be:
if (result.isSome()) {
return result.get();
} else if (result.isError()) {
LOG(WARNING) Slave TaskStatus label decorator hook failed for
module ' name ': result.error();
}
return status.labels();
And then we can take in TaskStatus as a const. I see that this pattern is
used everywhere so let's not do this now but unless I'm missing something we
should circle back.
src/tests/hook_tests.cpp (line 509)
https://reviews.apache.org/r/36580/#comment14
Here and everywhere else in this review and other reviews, the expected
value comes first, and the actual value comes second. Again, since all this
code looks like this we can take care of it in a subsequent clean up review.
- Benjamin Hindman
On July 21, 2015, 4:46 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36580/
---
(Updated July 21, 2015, 4:46 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
Repository: mesos
Description
---
This allows Slave modules to expose some information to the
frameworks as well as Mesos-DNS via state.json.
Diffs
-
include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f
src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab
src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc
src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
---
make check with a new hook test.
Thanks,
Kapil Arya
Re: Review Request 36646: Added 'CONFIGURATION' flag to jenkins_build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/#review92478 --- did you also test with ubuntu? support/jenkins_build.sh (line 57) https://reviews.apache.org/r/36646/#comment146677 no need to install ssl package for ubuntu? - Vinod Kone On July 21, 2015, 8:30 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36646/ --- (Updated July 21, 2015, 8:30 p.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-2963 https://issues.apache.org/jira/browse/MESOS-2963 Repository: mesos Description --- Also added libevent dependency to jenkins build. In jenkins we can now provide 3 options for the `CONFIGURATION` environment variable that are: ` ` for the default build, `--enable-libevent` for libevent, and `--enable-libevent --enable-ssl` for SSL. Diffs - support/jenkins_build.sh 7276fe28b558d96f90fc950b3ffad78573732eef Diff: https://reviews.apache.org/r/36646/diff/ Testing --- `OS=CENTOS COMPILER=GCC CONFIGURATION=--enable-libevent --enable-ssl ./support/jenkins_build.sh` Thanks, Joris Van Remoortere
Re: Review Request 36585: Exposed docker container IP via state.json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/#review92471 --- Ship it! src/tests/docker_containerizer_tests.cpp (line 729) https://reviews.apache.org/r/36585/#comment146670 Need to flip expectation and actual. - Benjamin Hindman On July 21, 2015, 5:02 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36585/ --- (Updated July 21, 2015, 5:02 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. Bugs: MESOS-3061 https://issues.apache.org/jira/browse/MESOS-3061 Repository: mesos Description --- This would allow Mesos-DNS to lookup container information such as its IP address. Diffs - src/docker/docker.hpp fbae7bd382b675bba602494f0aa8679797c41504 src/docker/docker.cpp 27932585423bde6789f634edbc21c548e1924d16 src/docker/executor.cpp cdcd8ee7ad0b53748819bc1e565f708e30e99a5d src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43 Diff: https://reviews.apache.org/r/36585/diff/ Testing --- sudo make check Thanks, Kapil Arya
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description (updated) --- See summary. Diffs - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Review Request 36663: Added ip_address field to MasterInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2736 https://issues.apache.org/jira/browse/MESOS-2736 Repository: mesos Description --- As part of the new HTTP API and the need to provide a better interface for clients that do not integrate libmesos, we provide the IP address of the Leader Master in string format; this will eventually supersed the int32 existing `ip`, which also cannot support IPv6 addresses. Jira: MESOS-2736 Diffs - include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 Diff: https://reviews.apache.org/r/36663/diff/ Testing --- make check (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description (updated) --- See summary. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92494 --- src/slave/containerizer/mesos/containerizer.cpp (line 52) https://reviews.apache.org/r/34135/#comment146705 This shouldn't under #ifdef __linux__ guard - Jie Yu On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Re: Review Request 36658: Updated SSL documentation. Added to home page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92490 --- Ship it! Rendered affected files, everything looks good. - Artem Harutyunyan On July 21, 2015, 2:39 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 21, 2015, 2:39 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- Updated SSL documentation. Added to home page. Diffs - docs/home.md a02fea62360b39ed6af2025db52c06014f0a4ef2 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 Diff: https://reviews.apache.org/r/36658/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/#review92492 --- Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 673) https://reviews.apache.org/r/36656/#comment146704 Since it's used in several places, will it make sense to have a helper function that returns a vector with protocols? 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 675) https://reviews.apache.org/r/36656/#comment146699 s/protocol/protocols/ 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 807) https://reviews.apache.org/r/36656/#comment146700 ditto. 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 865) https://reviews.apache.org/r/36656/#comment146701 ditto. - Artem Harutyunyan On July 21, 2015, 3:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 21, 2015, 3:51 p.m.) Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-3121 https://issues.apache.org/jira/browse/MESOS-3121 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477 Diff: https://reviews.apache.org/r/36656/diff/ Testing --- make check. Thanks, Joris Van Remoortere
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92497 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 91 - 92) https://reviews.apache.org/r/34135/#comment146709 This check does not seem to be necessary. - Jie Yu On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Review Request 36667: Moved createLabel to protobuf_utils.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36667/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary Diffs - src/common/protobuf_utils.hpp 64974c57b91747409f37457b4df0cafe239eef59 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/tests/hook_tests.cpp 6827dec560265ad5ebfb0b600f783780bb00bfc6 src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/mesos.hpp f14b8f721e057efbd93dd38263c22b4b4e3881da src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36667/diff/ Testing --- make check Thanks, Kapil Arya
Review Request 36668: Removed some trailing underscores from {master, slave}_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36668/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description --- See summary Diffs - src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61 src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36668/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 36663: Added ip_address field to MasterInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92510 --- Patch looks great! Reviews applied: [36663] All tests passed. - Mesos ReviewBot On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 21, 2015, 10:50 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2736 https://issues.apache.org/jira/browse/MESOS-2736 Repository: mesos Description --- As part of the new HTTP API and the need to provide a better interface for clients that do not integrate libmesos, we provide the IP address of the Leader Master in string format; this will eventually supersed the int32 existing `ip`, which also cannot support IPv6 addresses. Jira: MESOS-2736 Diffs - include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 Diff: https://reviews.apache.org/r/36663/diff/ Testing --- make check (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92512 --- src/slave/containerizer/isolators/filesystem/posix.cpp (lines 198 - 204) https://reviews.apache.org/r/34135/#comment146722 Rebase is needed to pickup the change that setup the ownership. - Jie Yu On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Re: Review Request 36580: Added TaskStatus label decorator hook for Slave
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/#review92513 --- src/hook/manager.cpp (line 212) https://reviews.apache.org/r/36580/#comment146723 There are a couple of reasons for the pattern (here and in TaskInfo): 1. A decorator hooks can also act as undecorator hooks, i.e., it is allowed to remove labels from the given TaskStatus/TaskInfo. Thus everytime a hook is called, it is called with the current state of TaskInfo/TaskStatus Labels. 2. There can be multiple hooks for label decoration, so we can't simply return on `result.isSome()`. We need to accumulate all of those. - Kapil Arya On July 21, 2015, 12:46 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36580/ --- (Updated July 21, 2015, 12:46 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. Repository: mesos Description --- This allows Slave modules to expose some information to the frameworks as well as Mesos-DNS via state.json. Diffs - include/mesos/hook.hpp 0995c249e9f07c6c4a26d1c5c369d48bb8056f1f src/examples/test_hook_module.cpp d61cd557d8e44e5089f324edf97b0335a4ededab src/hook/manager.hpp 47e8eb7d54d55049d054cf9b1225e67333f22adc src/hook/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db Diff: https://reviews.apache.org/r/36580/diff/ Testing --- make check with a new hook test. Thanks, Kapil Arya
Re: Review Request 36663: Added ip_address field to MasterInfo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92514 --- Ship it! LGTM, thanks for adding much needed documentation too for the fields ! Upon reading the corresponding JIRA, I am assuming that we had an agreement to not use the Address field that BenM introduced in r36450 for readability of the field. include/mesos/mesos.proto (line 382) https://reviews.apache.org/r/36663/#comment146724 Minor Nitpick : Did you refer to a name; here instead of name: - Anand Mazumdar On July 21, 2015, 10:50 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 21, 2015, 10:50 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-2736 https://issues.apache.org/jira/browse/MESOS-2736 Repository: mesos Description --- As part of the new HTTP API and the need to provide a better interface for clients that do not integrate libmesos, we provide the IP address of the Leader Master in string format; this will eventually supersed the int32 existing `ip`, which also cannot support IPv6 addresses. Jira: MESOS-2736 Diffs - include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 src/common/protobuf_utils.cpp 9ba57a73e44ddbebfc44d0de61ebefd1ab620209 src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 Diff: https://reviews.apache.org/r/36663/diff/ Testing --- make check (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized to ZK is readable and as expected). Thanks, Marco Massenzio
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92516 --- Ship it! Ship It! - Jie Yu On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.
On July 21, 2015, 9:41 p.m., Jie Yu wrote: src/slave/containerizer/isolators/filesystem/posix.cpp, lines 183-185 https://reviews.apache.org/r/34135/diff/3/?file=1009133#file1009133line183 I just realized an issue here (not your fault). Since we don't checkpoint 'resources' in this isolator, when slave restarts and recovers, the 'resources' in Info will be empty, but there are symlinks exists in the sandbox. We'll end up with trying to create already exist symlinks (and fail). I think this is easy to resolve because we can just ignore EEXIST. Also, it's likely that we fail to remove some symlinks because they do not exist (e.g., a task finishes but the slave crashes after containerizer-update is called but before the status update is checkpointed). Since this is not a issue introduced by this review. I created https://issues.apache.org/jira/browse/MESOS-3124 to track. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review92480 --- On July 12, 2015, 4:46 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 12, 2015, 4:46 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- Moved code from Mesos Containerizer to filesystem isolators - filesystem/posix (symlinks, doesn't support container rootfs) - The filesystem/posix isolator will be automatically included if no filesystem/ isolator is specified. Diffs - src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes
Re: Review Request 36617: Improved task reconciliation documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92395 --- Patch looks great! Reviews applied: [36617] All tests passed. - Mesos ReviewBot On July 21, 2015, 9:29 a.m., Jan Schlicht wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 21, 2015, 9:29 a.m.) Review request for mesos and Joerg Schad. Repository: mesos Description --- Improved task reconciliation documentation. Diffs - docs/reconciliation.md 17537ba8420c95d833e64ccf82ff9bb4530497f0 Diff: https://reviews.apache.org/r/36617/diff/ Testing --- https://gist.github.com/nfnt/73532d62fe39d27ff33d Thanks, Jan Schlicht
Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review91875 --- 3rdparty/libprocess/src/tests/process_tests.cpp (lines 1757 - 1761) https://reviews.apache.org/r/30032/#comment145574 I think the error was the lack of an await here. - Alexander Rojas On June 17, 2015, 5:42 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated June 17, 2015, 5:42 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and Till Toenshoff. Bugs: mesos-708 https://issues.apache.org/jira/browse/mesos-708 Repository: mesos Description --- When serving a static file, libprocess returns the header `Last-Modified` which is used by browsers to control Cache. When a http request arrives containing the header `If-Modified-Since`, a response `304 Not Modified` is returned if the date in the request and the modification time (as returned by doing `stat` in the file) coincide. Unit tests added. Diffs - 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417 3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6 3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058 Diff: https://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36617: Improved task reconciliation documentation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 21, 2015, 11:29 a.m.) Review request for mesos and Joerg Schad. Repository: mesos Description (updated) --- Improved task reconciliation documentation. Diffs - docs/reconciliation.md 17537ba8420c95d833e64ccf82ff9bb4530497f0 Diff: https://reviews.apache.org/r/36617/diff/ Testing --- https://gist.github.com/nfnt/73532d62fe39d27ff33d Thanks, Jan Schlicht
