Change in vdsm[master]: StorageDomainManifest: move path getters
Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move path getters .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/41995/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 45: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE) Line 46: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid, voluuid)) Line 47: Line 48: def test_getisodomainimagesdir(self): Line 49: with namedTemporaryDir() as path: Do we need always temporary directory? Can use unbound manifest for testing? Line 50: manifest = self.make_manifest(path) Line 51: isopath = os.path.join(manifest.domaindir, sd.DOMAIN_IMAGES, Line 52:sd.ISO_IMAGE_UUID) Line 53: self.assertEquals(isopath, manifest.getIsoDomainImagesDir()) -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
Sandro Bonazzola has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move BlockSD.getVSize
Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/41994/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 41: def test_getvsize(self): Line 42: with namedTemporaryDir() as path: Line 43: manifest = self.make_manifest(path) Line 44: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE) Line 45: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid, voluuid)) This will use the real oop object - I wonder how this test can pass. Maybe oop is using in-process functions by defualt? Line 46: Line 47: def make_manifest(self, path): Line 48: sduuid = str(uuid.uuid4()) Line 49: domain_path = os.path.join(path, sduuid) -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move BlockSD.getVSize
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: move BlockSD.getVSize
..
Patch Set 12:
(20 comments)
I looked only in the FakeLVM, since it is very complex now. I think we can make
it simpler.
https://gerrit.ovirt.org/#/c/41994/12/tests/manifest_tests.py
File tests/manifest_tests.py:
Line 32
Line 33
Line 34
Line 35
Line 36
Use tmpdir to make it clear what is this path.
Line 60
Line 61
Line 62
Line 63
Line 64
Same, use tmpdir, or better term (e.g. root, basedir etc.)
Or remove it - we don't use it.
Line 38: manifest = self.make_manifest(path)
Line 39: self.assertIsInstance(manifest.getReadDelay(), float)
Line 40:
Line 41: def test_getvsize(self):
Line 42: with namedTemporaryDir() as path:
path - tmpdir
Line 43: manifest = self.make_manifest(path)
Line 44: imguuid, voluuid = make_volume(manifest.domaindir, VOLSIZE)
Line 45: self.assertEqual(VOLSIZE, manifest.getVSize(imguuid,
voluuid))
Line 46:
Line 67:
Line 68: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
Line 69: self.assertIsInstance(manifest.getReadDelay(), float)
Line 70:
Line 71: def test_getvsize_via_dev(self):
It is more correct to call this test_getvsize_active_lv()
Line 72: # Tests the fast path when the device file is present
Line 73: with namedTemporaryDir() as path:
Line 74: manifest = self.make_manifest(path)
Line 75: vg = manifest.sdUUID
Line 71: def test_getvsize_via_dev(self):
Line 72: # Tests the fast path when the device file is present
Line 73: with namedTemporaryDir() as path:
Line 74: manifest = self.make_manifest(path)
Line 75: vg = manifest.sdUUID
Lets use vgname or to make it easy to detect a vg name and a vg object returned
from lvm apis - we have the same distinction in the code.
Line 76: lvm = FakeLVM(path)
Line 77: voluuid = str(uuid.uuid4())
Line 78: volpath = lvm.lvPath(vg, voluuid)
Line 79: os.makedirs(os.path.dirname(volpath))
Line 73: with namedTemporaryDir() as path:
Line 74: manifest = self.make_manifest(path)
Line 75: vg = manifest.sdUUID
Line 76: lvm = FakeLVM(path)
Line 77: voluuid = str(uuid.uuid4())
Maybe lvname instead of voluuid?
Line 78: volpath = lvm.lvPath(vg, voluuid)
Line 79: os.makedirs(os.path.dirname(volpath))
Line 80: with open(volpath, w) as f:
Line 81: f.truncate(VOLSIZE)
Line 74: manifest = self.make_manifest(path)
Line 75: vg = manifest.sdUUID
Line 76: lvm = FakeLVM(path)
Line 77: voluuid = str(uuid.uuid4())
Line 78: volpath = lvm.lvPath(vg, voluuid)
Here a comment can help
# Create fake file for calculating the file size via dev symlink
Or better, a function like:
lvm.create_fake_lv_symlink(vgname, lvname)
It belongs to fake lvm makes because it knows the root direcotory and the dev
directory, and we can reuse this in many tests.
Line 79: os.makedirs(os.path.dirname(volpath))
Line 80: with open(volpath, w) as f:
Line 81: f.truncate(VOLSIZE)
Line 82: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
Line 79: os.makedirs(os.path.dirname(volpath))
Line 80: with open(volpath, w) as f:
Line 81: f.truncate(VOLSIZE)
Line 82: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
Line 83: self.assertEqual(VOLSIZE, manifest.getVSize('unused',
voluuid))
I think it will be more clear to use:
manifest.getVSize(imguuid, voluuid)
Otherwise I look at the code an I don't feel I know what's going on, unless I
check the original code to understand what is unused.
Line 84:
Line 85: def test_getvsize_via_lvm(self):
Line 86: # Tests the slow path in getVSize when the device file is not
present
Line 87: with namedTemporaryDir() as path:
Line 81: f.truncate(VOLSIZE)
Line 82: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
Line 83: self.assertEqual(VOLSIZE, manifest.getVSize('unused',
voluuid))
Line 84:
Line 85: def test_getvsize_via_lvm(self):
More correct to call this test_getvsize_inactive_lv()
Line 86: # Tests the slow path in getVSize when the device file is not
present
Line 87: with namedTemporaryDir() as path:
Line 88: manifest = self.make_manifest(path)
Line 89: vg = manifest.sdUUID
Line 82: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]):
Line 83: self.assertEqual(VOLSIZE, manifest.getVSize('unused',
voluuid))
Line 84:
Line 85: def test_getvsize_via_lvm(self):
Line 86: # Tests the slow path in
Change in vdsm[master]: resize-lun: Cleanup getDeviceList
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Cleanup getDeviceList .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fa844b211037347de3f6bbbc448fd58ace2dcca Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Resize devices in connectStorageServer
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Resize devices in connectStorageServer .. Patch Set 16: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40864/16/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2396: def __prefetchDomains(self, domType, conObj): Line 2397: uuidPatern = ---- Line 2398: Line 2399: if domType in (sd.FCP_DOMAIN, sd.ISCSI_DOMAIN): Line 2400: sdCache.refreshStorage() I think it would have been clearer in connectStorageServer with a proper comment. Line 2401: uuids = tuple(blockSD.getStorageDomainsList()) Line 2402: elif domType is sd.NFS_DOMAIN: Line 2403: lPath = conObj._mountCon._getLocalPath() Line 2404: self.log.debug(nfs local path: %s, lPath) -- To view, visit https://gerrit.ovirt.org/40864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia574a59047d2fb5dd3ac7360c2c3a9dde05237ef Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Add resizePV verb
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Add resizePV verb .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40467/5/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 714: Line 715: def resizePV(self, guid): Line 716: with self._extendlock: Line 717: lvm.resizePV(self.sdUUID, guid) Line 718: self.updateMapping() Is this to update only pecount or is there something else as well? Line 719: newsize = self.metaSize(self.sdUUID) Line 720: lvm.extendLV(self.sdUUID, sd.METADATA, newsize) Line 721: Line 722: _lvTagMetaSlotLock = threading.Lock() -- To view, visit https://gerrit.ovirt.org/40467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38f9e603a66adbe2655173b8043766f6c04a7913 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: introduce class heirarchy
Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy .. Patch Set 12: Code-Review+1 (6 comments) https://gerrit.ovirt.org/#/c/41993/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 32: class FileManifestTests(VdsmTestCase): Line 33: MDSIZE = 524288 Line 34: Line 35: def test_getreaddelay(self): Line 36: with namedTemporaryDir() as path: I would call path tmpdir to avoid confusion. Line 37: manifest = self.make_manifest(path) Line 38: self.assertIsInstance(manifest.getReadDelay(), float) Line 39: Line 40: def make_manifest(self, path): Line 49: manifest.bind(dict()) Line 50: return manifest Line 51: Line 52: Line 53: class BlockManifestTests(VdsmTestCase): lets add empty line after the class for consistency. Line 54: def test_getreaddelay(self): Line 55: with namedTemporaryDir() as path: Line 56: manifest = self.make_manifest(path) Line 57: vg = manifest.sdUUID Line 53: class BlockManifestTests(VdsmTestCase): Line 54: def test_getreaddelay(self): Line 55: with namedTemporaryDir() as path: Line 56: manifest = self.make_manifest(path) Line 57: vg = manifest.sdUUID better call this vg_name, to avoid confusion later with vg namedtuple returned from lvm apis. Line 58: lvm = FakeLVM(path) Line 59: make_metafile(lvm.lvPath(vg, 'metadata')) Line 60: Line 61: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]): Line 64: def make_manifest(self, path): Line 65: sduuid = str(uuid.uuid4()) Line 66: manifest = blockSD.BlockStorageDomainManifest(sduuid) Line 67: Line 68: # Just use a dict for the metadata I think the code explain itself, lets remove the comments. Line 69: manifest.bind(dict()) Line 70: return manifest Line 71: Line 72: Line 69: manifest.bind(dict()) Line 70: return manifest Line 71: Line 72: Line 73: def make_metafile(metafile): Lets rename it to make_fake_metafile and remove the comments. Line 74: os.makedirs(os.path.dirname(metafile)) Line 75: with open(metafile, w) as f: https://gerrit.ovirt.org/#/c/41993/12/tests/storagefakelib.py File tests/storagefakelib.py: Line 1: # Copyright 2012 Red Hat, Inc. 2015 Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Add resize map support in multipath
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Add resize map support in multipath .. Patch Set 18: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40468/18/vdsm/storage/multipath.py File vdsm/storage/multipath.py: Line 130: Raises Error if multipathd failed to resize the map. Line 131: Line 132: log.debug(Resizing map %r, name) Line 133: cmd = [_MULTIPATHD.cmd, resize, map, name] Line 134: start = utils.monotonic_time() This could be a contextmanager (start/stop, logging time elapsed, etc.) Line 135: rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log) Line 136: # multipathd reports some errors using non-zero exit code and stderr (need Line 137: # to be root), but the command may return 0, and the result is reported Line 138: # using stdout. -- To view, visit https://gerrit.ovirt.org/40468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1020667baeb5976fb1c78daedcc88727648f13d Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Support guids parameter in getDeviceList
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Support guids parameter in getDeviceList .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic173d94a132e617ae97353d38520a86bede657d7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: introduce class heirarchy
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy .. Patch Set 12: (6 comments) https://gerrit.ovirt.org/#/c/41993/12/tests/manifest_tests.py File tests/manifest_tests.py: Line 32: class FileManifestTests(VdsmTestCase): Line 33: MDSIZE = 524288 Line 34: Line 35: def test_getreaddelay(self): Line 36: with namedTemporaryDir() as path: I would call path tmpdir to avoid confusion. Done Line 37: manifest = self.make_manifest(path) Line 38: self.assertIsInstance(manifest.getReadDelay(), float) Line 39: Line 40: def make_manifest(self, path): Line 49: manifest.bind(dict()) Line 50: return manifest Line 51: Line 52: Line 53: class BlockManifestTests(VdsmTestCase): lets add empty line after the class for consistency. Done Line 54: def test_getreaddelay(self): Line 55: with namedTemporaryDir() as path: Line 56: manifest = self.make_manifest(path) Line 57: vg = manifest.sdUUID Line 53: class BlockManifestTests(VdsmTestCase): Line 54: def test_getreaddelay(self): Line 55: with namedTemporaryDir() as path: Line 56: manifest = self.make_manifest(path) Line 57: vg = manifest.sdUUID better call this vg_name, to avoid confusion later with vg namedtuple retur Done Line 58: lvm = FakeLVM(path) Line 59: make_metafile(lvm.lvPath(vg, 'metadata')) Line 60: Line 61: with MonkeyPatchScope([(blockSD, 'lvm', lvm)]): Line 64: def make_manifest(self, path): Line 65: sduuid = str(uuid.uuid4()) Line 66: manifest = blockSD.BlockStorageDomainManifest(sduuid) Line 67: Line 68: # Just use a dict for the metadata I think the code explain itself, lets remove the comments. Done Line 69: manifest.bind(dict()) Line 70: return manifest Line 71: Line 72: Line 69: manifest.bind(dict()) Line 70: return manifest Line 71: Line 72: Line 73: def make_metafile(metafile): Lets rename it to make_fake_metafile and remove the Done Line 74: os.makedirs(os.path.dirname(metafile)) Line 75: with open(metafile, w) as f: https://gerrit.ovirt.org/#/c/41993/12/tests/storagefakelib.py File tests/storagefakelib.py: Line 1: # Copyright 2012 Red Hat, Inc. 2015 Done Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Resize multipath maps in refreshStorage
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: Resize multipath maps in refreshStorage .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b1b699b1a905e949e98f435f339a21dad640c6 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Feng Yang yangf...@cloud-times.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move extend and extendVolume .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move logBlkSize
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move logBlkSize .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/41996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b9b20e9c8c20fa5c151f7c86337bc54ab526e11 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move path getters
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move path getters .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move extend and extendVolume
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move extend and extendVolume .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/42266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ad1769d7e4db6fc0883b37a67d071c278b96c8b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: deleteImage and deps
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: deleteImage and deps .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e418262d70ed50b45fdddf2fc77eb80a03a3811 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move logBlkSize
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move logBlkSize .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b9b20e9c8c20fa5c151f7c86337bc54ab526e11 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: Move getRepoPath and other metadata g...
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: Move getRepoPath and other metadata getters .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I571437a10a53d5aa20c83438350476d03111a704 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: introduce class heirarchy
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move BlockSD.getVSize
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move path getters
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move path getters .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb49591357e0ae77268789da78e8504864a8057 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move image and volume enumeration
automat...@ovirt.org has posted comments on this change. Change subject: StorageDomainManifest: move image and volume enumeration .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56214a7024b1f894b8e4e0b951faf0567a1606c9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: Move getRepoPath and other metadata g...
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: Move getRepoPath and other metadata getters .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/42267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I571437a10a53d5aa20c83438350476d03111a704 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: move BlockSD.getVSize
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: move BlockSD.getVSize .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/41994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00eba218cfb4af201aebcdc5071f95164c31687 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: StorageDomainManifest: introduce class heirarchy
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: introduce class heirarchy .. Patch Set 13: Verified+1 -- To view, visit https://gerrit.ovirt.org/41993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia275424a8d423722efb229a4d8545f035fe5fa51 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: introducing KernelConfig
Dan Kenigsberg has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 14: Code-Review-1
(12 comments)
https://gerrit.ovirt.org/#/c/41973/14/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 209: for bond, bond_attr in netinfo.bondings.iteritems():
Line 210: yield bond, self._translate_netinfo_bond(bond_attr)
Line 211:
Line 212: def _translate_netinfo_net(self, net, net_attr):
Line 213: nics, vlan, bonds =
self._netinfo.getNicsVlanAndBondingForNetwork(net)
bonds-bonding
Line 214: attributes = {}
Line 215: self._translate_bridged(attributes, net_attr)
Line 216: self._translate_mtu(attributes, net_attr)
Line 217: self._translate_vlan(attributes, vlan)
Line 231:
Line 232: def _translate_ipaddr(self, attributes, net_attr):
Line 233: attributes['bootproto'] = 'dhcp' if net_attr['dhcpv4'] else
'none'
Line 234: attributes['dhcpv6'] = net_attr['dhcpv6']
Line 235: ifcfg = net_attr.get('cfg')
TODO: we must not depend on 'cfg', which is configurator-dependent. Look up in
the routing table instead.
Line 236: if ifcfg and ifcfg.get('DEFROUTE') == 'yes':
Line 237: attributes['defaultRoute'] = True
Line 238: else:
Line 239: attributes['defaultRoute'] = False
Line 236: if ifcfg and ifcfg.get('DEFROUTE') == 'yes':
Line 237: attributes['defaultRoute'] = True
Line 238: else:
Line 239: attributes['defaultRoute'] = False
Line 240: # only report ip addresses of non dhcp interfaces. This is
because we
I believe the following comment would be clearer
# only static addresses are part of {Persistent,Running}Config.
Line 241: # don't know if the address is already configured.
Line 242: if attributes['bootproto'] == 'none':
Line 243: if net_attr['addr']:
Line 244: attributes['ipaddr'] = net_attr['addr']
Line 300: net_attr['vlan'] = str(net_attr['vlan'])
Line 301:
Line 302: def _normalize_bridge(self, config_copy):
Line 303: for net_attr in config_copy.networks.itervalues():
Line 304: bridged = net_attr.get('bridged')
get(..., True)
would be a bit simpler
Line 305: if bridged or bridged is None:
Line 306: net_attr['bridged'] = True
Line 307: net_attr['stp'] = self._netinfo.stpBooleanize(
Line 308: net_attr.get('stp'))
Line 330: return config_copy
Line 331:
Line 332: def _normalize_bonding_opts(self, config_copy):
Line 333: for bond, bond_attr in config_copy.bonds.iteritems():
Line 334: non_default_opts =
self._netinfo.getNonDefaultBondingOptions(bond)
_normalize*() functions should not read netinfo.
instead, have _parse_bond_options() extract the 'mode' of the requested bonding.
then compare bond_opts to getDefaultBondingOptions(mode) much like
netinfo._getBondingOptions() does.
Line 335: bond_opts =
self._parse_bond_options(bond_attr.get('options', ''))
Line 336: if bond_opts:
Line 337: normalized_opts = {}
Line 338: for k, v in bond_opts.iteritems():
Line 352: for bond_attr in config_copy.bonds.itervalues():
Line 353: if 'nics' in bond_attr:
Line 354: bond_attr['nics'].sort()
Line 355:
Line 356: def _normalize_custom_properties(self, config_copy):
drop this function, and add hack to tests of custom properties.
Line 357: # custom properties are not part of the kernel and are
expected to be
Line 358: # different
Line 359: for net_attr in config_copy.networks.itervalues():
Line 360: if 'custom' in net_attr:
Line 362:
Line 363: def _normalize_address(self, config_copy):
Line 364: for net_attr in config_copy.networks.itervalues():
Line 365: prefix = net_attr.pop('prefix', None)
Line 366: if prefix:
if prefix is not None
Line 367: net_attr['netmask'] =
self._netinfo.prefix2netmask(int(prefix))
Line 368: if 'ipv6addr' in net_attr:
Line 369: net_attr['ipv6addr'] = [net_attr['ipv6addr']]
Line 370:
Line 368: if 'ipv6addr' in net_attr:
Line 369: net_attr['ipv6addr'] = [net_attr['ipv6addr']]
Line 370:
Line 371: def _parse_bond_options(self, opts):
Line 372: return dict((pair.split('=') for pair in opts.split()))
split('=', 1)
just in case we ever want to support the = value.
Line 373:
Line 374: def _translate_net_qos(self, net_qos):
Line 375: stripped_qos = {}
Line 376: for part, part_config in net_qos.iteritems():
Line 370:
Line 371: def _parse_bond_options(self, opts):
Line 372: return dict((pair.split('=') for pair in opts.split()))
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
Freddy Rolland has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
Allon Mureinik has uploaded a new change for review. Change subject: hooks: Fix RHEVM references in README file .. hooks: Fix RHEVM references in README file Replaced outdated references of rhevm-config to oVirt's engine-config. Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Signed-off-by: Allon Mureinik amure...@redhat.com --- M vdsm_hooks/README 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/42485/1 diff --git a/vdsm_hooks/README b/vdsm_hooks/README index 1659610..6eab80c 100644 --- a/vdsm_hooks/README +++ b/vdsm_hooks/README @@ -9,26 +9,26 @@ Working with VDSM hooks === To work with VDSM hooks you need first to do the following: -1. Update UserDefinedVMProperties property by using the rhevm-config tool: - # rhevm-config -s UserDefinedVMProperties='pincpu=^[0-9]+$' --cver=3.0 +1. Update UserDefinedVMProperties property by using the engine-config tool: + # engine-config -s UserDefinedVMProperties='pincpu=^[0-9]+$' --cver=3.0 * Note: for simplification we use pincpu=^[0-9]+$ which enable only numbers, the actual regex need to be pincpu=^[\^]?\d+(-\d+)?(,[\^]?\d+(-\d+)?)*$ which enable range of CPUs. That command will enable VMs to use pincpu custom hook. * Please note that this command will override the existing value of UserDefinedVMProperties you can concatenate the old value by getting it with the following command: - # rhevm-config -g UserDefinedVMProperties --cver=3.0 - * note for the version in rhevm-config tool, the current version is 3.0 and its the first + # engine-config -g UserDefinedVMProperties --cver=3.0 + * note for the version in engine-config tool, the current version is 3.0 and its the first version that use custom hooks, to use the version you can do the following: - # rhevm-config -g UserDefinedVMProperties --cver=3.0 + # engine-config -g UserDefinedVMProperties --cver=3.0 If you want to enable more then one custom hook use the semicolon as a separator: - # rhevm-config -s UserDefinedVMProperties='pincpu=^[0-9]+$;sap_agent=^(true|false)$' --cver=3.0 + # engine-config -s UserDefinedVMProperties='pincpu=^[0-9]+$;sap_agent=^(true|false)$' --cver=3.0 The convention is [hook name]=[value], the value is evaluate with regular expression, If you find regular expression too complex, you can always use the following command: - # rhevm-config -s UserDefinedVMProperties='pincpu=.*' --cver=3.0 + # engine-config -s UserDefinedVMProperties='pincpu=.*' --cver=3.0 Which mean that RHEV-M validation will get any input - but please note that giving a bad input - the hook will probably fail or run with unexpected results! @@ -45,7 +45,7 @@ select the last option from the left option list with the label Custom Properties add your custom property value, in our pincpu hook case: pincpu=1 - if you want to use more then on hook and you did enable it with the rhevm-config + if you want to use more then on hook and you did enable it with the engine-config tool, you can use the semicolon as a separator: pincpu=1;sap_agent=true b. Another option is to use Run Once dialog which mean that you add a custom property -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Fix RHEVM references in README file .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: reset bonding options to defaults.
Dan Kenigsberg has posted comments on this change. Change subject: net: reset bonding options to defaults. .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe720674e63119e954265735e9f5ccb994c3531a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: serial console: require ovirt-vmconsole
Francesco Romani has posted comments on this change. Change subject: spec: serial console: require ovirt-vmconsole .. Patch Set 2: Alon doesn't like this approach https://bugzilla.redhat.com/show_bug.cgi?id=1229827#c3 Anyway I still believe that hard-depending on ovirt-vmconsole (shared package) will make thing easier -- To view, visit https://gerrit.ovirt.org/42479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b251b3cd92652bd79f22e088ddd5fd01760cebe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Fix RHEVM references in README file .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
Allon Mureinik has posted comments on this change. Change subject: hooks: Fix RHEVM references in README file .. Patch Set 1: Verified+1 Verified manually the tool is indeed called engine-config. This patch is just a README change, verified all places were git grep rhevm-config. -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Fix RHEVM references in README file .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Fix RHEVM references in README file
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: Fix RHEVM references in README file .. hooks: Fix RHEVM references in README file Replaced outdated references of rhevm-config to oVirt's engine-config. Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Signed-off-by: Allon Mureinik amure...@redhat.com Reviewed-on: https://gerrit.ovirt.org/42485 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm_hooks/README 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/42485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef360e6685951daf416a45a9d714d0666c018b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: during boot, restore only networks that were actually c...
Dan Kenigsberg has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 10: Code-Review-1
(4 comments)
very partial review
https://gerrit.ovirt.org/#/c/42355/10/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 364: if prefix:
Line 365: net_attr['netmask'] =
self._netinfo.prefix2netmask(int(prefix))
Line 366: if 'ipv6addr' in net_attr:
Line 367: net_attr['ipv6addr'] = [net_attr['ipv6addr']]
Line 368: if 'defaultRoute' not in net_attr:
seems to belong to the introducing patch
Line 369: net_attr['defaultRoute'] = False
Line 370:
Line 371: def _parse_bond_options(self, opts):
Line 372: return dict((pair.split('=') for pair in opts.split()))
https://gerrit.ovirt.org/#/c/42355/10/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1515: BOND_MISSING: {'nics': [nic_b]}
Line 1516: }
Line 1517: status, msg = self.setupNetworks(nets, bonds, NOCHK)
Line 1518: self.assertEquals(status, SUCCESS, msg)
Line 1519: _assert_all_nets_exist()
the try block should start here.
Line 1520:
Line 1521: self.vdsm_net.save_config()
Line 1522:
Line 1523: addrFlush(NET_CHANGED)
Line 1524: linkSet(NET_MISSING, ['down'])
Line 1525: execCmd([EXT_BRCTL, 'delbr', NET_MISSING])
Line 1526: linkDel(BOND_MISSING)
Line 1527: self.vdsm_net.refreshNetinfo()
Line 1528: self.assertNotEqual(
assertEqual to ''
Line 1529:
self.vdsm_net.netinfo.networks[NET_CHANGED]['addr'],
Line 1530: IP_ADDR_NET_CHANGED
Line 1531: )
Line 1532: self.assertNotIn(NET_MISSING,
self.vdsm_net.netinfo.networks)
https://gerrit.ovirt.org/#/c/42355/10/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 100: as running configuration.
Line 101:
Line 102: _remove_networks_in_running_config()
Line 103:
Line 104: # _flush_configurators_leftovers()
we should remove the dead code, since we'd better be sure this is no longer
needed.
Line 105:
Line 106: _restore_non_vdsm_net_devices()
Line 107:
Line 108: nets, bonds = _filter_nets_bonds()
--
To view, visit https://gerrit.ovirt.org/42355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66307a7cf6b0f7269a1ae04aa7c1748dde768144
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Martin Polednik has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 3: Verified+1 Code-Review+1 Builds as expected. -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Remove duplicate mom requirement
Nir Soffer has uploaded a new change for review.
Change subject: spec: Remove duplicate mom requirement
..
spec: Remove duplicate mom requirement
Commit 851b302be77a (Separate MOM to an external process) updated mom
requirement so we require the same version when building for rhev or for
other platforms. This patch removes the now unneeded condition.
Change-Id: I0c914871a641cf48d374931bf9a6cbb85aad58f9
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/42474/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 1b0baf0..af1d6fd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -157,12 +157,7 @@
Requires: %{name}-jsonrpc = %{version}-%{release}
Requires: safelease = 1.0-5
Requires: ceph-common
-
-%if 0%{?rhev_build}
Requires: mom = 0.4.5
-%else
-Requires: mom = 0.4.5
-%endif
%if 0%{?rhel}
Requires: libguestfs-tools-c = 1:1.20.11-10
--
To view, visit https://gerrit.ovirt.org/42474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c914871a641cf48d374931bf9a6cbb85aad58f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Remove duplicate mom requirement
Nir Soffer has posted comments on this change. Change subject: spec: Remove duplicate mom requirement .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c914871a641cf48d374931bf9a6cbb85aad58f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Remove duplicate mom requirement
automat...@ovirt.org has posted comments on this change. Change subject: spec: Remove duplicate mom requirement .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c914871a641cf48d374931bf9a6cbb85aad58f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Remove duplicate mom requirement
Francesco Romani has posted comments on this change. Change subject: spec: Remove duplicate mom requirement .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c914871a641cf48d374931bf9a6cbb85aad58f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Do not perform disconnect actions when destroyed
Francesco Romani has posted comments on this change. Change subject: virt: Do not perform disconnect actions when destroyed .. Patch Set 4: Code-Review+1 thanks! -- To view, visit https://gerrit.ovirt.org/41373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d384a057e2d6b9093b5ad9ce67d0ba33c42264 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 26: Verified+1 There was not change since version 19 on May 17. -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
Francesco Romani has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 17: Code-Review+1 changing score. Cleaner solution exists and are in progrss, but it is too late for 3.6.x. This is good enough for 3.6.x API-wise. Code-wise no objections, so +1 -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Francesco Romani has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 3: Code-Review+1 well, what else can we do? :) -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Darshan N has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/41568/8//COMMIT_MSG Commit Message: Line 7: refactor you need to change the heading properly. Done https://gerrit.ovirt.org/#/c/41568/8/vdsm.spec.in File vdsm.spec.in: Line 283: with_gluster is this still valid here? Done Line 641: replication please define gluster_version prior and use it everywhere Done -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Do not perform disconnect actions when destroyed
Francesco Romani has posted comments on this change.
Change subject: virt: Do not perform disconnect actions when destroyed
..
Patch Set 3: Code-Review-1
(1 comment)
looks OK (-1 for visibility only). Please reiterate using a comment near to the
code that we know this is racy and this is not the definitive fix.
Yes, this will partially repeat the content of the commit message, but we
dealing with this kind of bugs I prefer a little redundancy to make sure our
future selves are aware of what we thought back in time.
https://gerrit.ovirt.org/#/c/41373/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 856: if clientIp:
Line 857: self.conf['clientIp'] = clientIp
Line 858:
Line 859: def _timedDesktopLock(self):
Line 860: if not self.conf.get('clientIp', '') and not self._destroyed:
Please add one-line(-ish) comment stating that we know this is still racy and
this is only a quick fix.
Line 861: delay = config.get('vars', 'user_shutdown_timeout')
Line 862: timeout = config.getint('vars', 'sys_shutdown_timeout')
Line 863: CDA = ConsoleDisconnectAction
Line 864: if self._consoleDisconnectAction == CDA.LOCK_SCREEN:
--
To view, visit https://gerrit.ovirt.org/41373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d384a057e2d6b9093b5ad9ce67d0ba33c42264
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
automat...@ovirt.org has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino ah...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 9: * Update tracker::#1232197::OK * Check Bug-Url::OK * Check Public Bug::#1232197::OK, public bug * Check Product::#1232197::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Daniel Erez has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Do not perform disconnect actions when destroyed
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Do not perform disconnect actions when destroyed
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/41373/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 856: if clientIp:
Line 857: self.conf['clientIp'] = clientIp
Line 858:
Line 859: def _timedDesktopLock(self):
Line 860: if not self.conf.get('clientIp', '') and not self._destroyed:
Please add one-line(-ish) comment stating that we know this is still racy a
Done
Line 861: delay = config.get('vars', 'user_shutdown_timeout')
Line 862: timeout = config.getint('vars', 'sys_shutdown_timeout')
Line 863: CDA = ConsoleDisconnectAction
Line 864: if self._consoleDisconnectAction == CDA.LOCK_SCREEN:
--
To view, visit https://gerrit.ovirt.org/41373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34d384a057e2d6b9093b5ad9ce67d0ba33c42264
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
Nir Soffer has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 17: Verified+1 -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add vdsClient secrets verbs
Nir Soffer has posted comments on this change. Change subject: ceph: Add vdsClient secrets verbs .. Patch Set 22: Verified+1 -- To view, visit https://gerrit.ovirt.org/40735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a2a6a7ccb036d0055a0935cbe6f3efb43a6546 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
Nir Soffer has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Open vSwitch configurator
automat...@ovirt.org has posted comments on this change. Change subject: hooks: Open vSwitch configurator .. Patch Set 41: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Barak Azulay bazu...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Darshan N has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 9: Verified+1 Have verified that vdsm package is no longer dependent on glusterfs-server package. And vdsm-gluster sub package is dependent on glusterfs-server package. Also gluster related verbs are working fine. Can somebody also verify, if things are working fine in storage domain perspective. -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: network: when using bonding, attach at least 2 slaves
Dan Kenigsberg has posted comments on this change. Change subject: tests: network: when using bonding, attach at least 2 slaves .. Patch Set 2: needs a manual rebase, I presume -- To view, visit https://gerrit.ovirt.org/41840 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1763bc3409aa7da91dcd2e3b21dd8540870138ef Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: allow custom bondOption
Dan Kenigsberg has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 7: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40882/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2367:
Line 2368: @cleanupNet
Line 2369: @ValidateRunningAsRoot
Line 2370: def test_setupNetworks_bond_with_custom_option(self):
Line 2371: with dummyIf(1) as nics:
OVS loves two ifaces
Line 2372: status, msg = self.vdsm_net.setupNetworks(
Line 2373: {},
Line 2374: {BONDING_NAME: {'nics': nics,
Line 2375: 'options': 'custom=foo
mode=balance-rr'}},
Line 2368: @cleanupNet
Line 2369: @ValidateRunningAsRoot
Line 2370: def test_setupNetworks_bond_with_custom_option(self):
Line 2371: with dummyIf(1) as nics:
Line 2372: status, msg = self.vdsm_net.setupNetworks(
needs a rebase for vdsm_net removal
Line 2373: {},
Line 2374: {BONDING_NAME: {'nics': nics,
Line 2375: 'options': 'custom=foo
mode=balance-rr'}},
Line 2376: NOCHK)
--
To view, visit https://gerrit.ovirt.org/40882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ace532d959bc3195a8a92b4536bdc0062bc7d1d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice .. virt: make SkipIOMMUPlaceholderDevice generic SkipDevice If we encounter the need to skip any device in future, the SkipDevice exception (in vmdevices.core) can be raised and caught to accomplish this in very consistent way. Change-Id: I19733c16cb865fa7118835511185ee1c52426838 Signed-off-by: Martin Polednik mpoled...@redhat.com Reviewed-on: https://gerrit.ovirt.org/42152 Reviewed-by: Jenkins CI Continuous-Integration: Jenkins CI Tested-by: Jenkins CI Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/hostdev.py M vdsm/virt/vm.py M vdsm/virt/vmdevices/core.py M vdsm/virt/vmdevices/hostdevice.py 4 files changed, 7 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve; Passed CI tests Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/42152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19733c16cb865fa7118835511185ee1c52426838 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice
automat...@ovirt.org has posted comments on this change. Change subject: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19733c16cb865fa7118835511185ee1c52426838 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice
Dan Kenigsberg has posted comments on this change. Change subject: virt: make SkipIOMMUPlaceholderDevice generic SkipDevice .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19733c16cb865fa7118835511185ee1c52426838 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Undefine existing secret if usage changed
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Undefine existing secret if usage changed .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib258f0be1cdd4f2672b9adaad35da13d48279ce6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add option to clear other secrets
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Add option to clear other secrets .. Patch Set 18: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I476e5aa0bd4a48d1837de09c59597f180fa38823 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Add vdsClient secrets verbs
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Add vdsClient secrets verbs .. Patch Set 23: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29a2a6a7ccb036d0055a0935cbe6f3efb43a6546 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear only ovirt secrets
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Clear only ovirt secrets .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41302 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b86bd43a6d33a31ef2ee638a16f46657113316d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Clear all secrets during startup and shutdown
automat...@ovirt.org has posted comments on this change. Change subject: ceph: Clear all secrets during startup and shutdown .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c5aa36ed752642745b7febc785750b438c102bb Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs with periodic false negative
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs with periodic false negative .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f0f5a46bcb8ed1197fe389a0b2904fa6939659d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: serial console: require ovirt-vmconsole
Francesco Romani has uploaded a new change for review.
Change subject: spec: serial console: require ovirt-vmconsole
..
spec: serial console: require ovirt-vmconsole
The ovirt-vmconsole package owns the ovirt-vmconsole
user/group, and ships shared utility code.
It doesn't add any service, so it is safe to depend
on it to make sure the ovirt-vmconsole group is
present on the system.
Change-Id: I0b251b3cd92652bd79f22e088ddd5fd01760cebe
Bug-Url: https://bugzilla.redhat.com/1223671
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/42479/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index af1d6fd..025f9a9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -158,6 +158,7 @@
Requires: safelease = 1.0-5
Requires: ceph-common
Requires: mom = 0.4.5
+Requires: ovirt-vmconsole = 1.0.0-0
%if 0%{?rhel}
Requires: libguestfs-tools-c = 1:1.20.11-10
--
To view, visit https://gerrit.ovirt.org/42479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b251b3cd92652bd79f22e088ddd5fd01760cebe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Dan Kenigsberg has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42471/3/vdsm.spec.in
File vdsm.spec.in:
Line 156: Requires: %{name}-xmlrpc = %{version}-%{release}
Line 157: Requires: %{name}-jsonrpc = %{version}-%{release}
Line 158: Requires: safelease = 1.0-5
Line 159:
Line 160: %if %{_arch} == ppc64le
I believe this is evaluated only once, during build time.
I am not aware of a way of adding arch-specific dependecies to a noarch package.
What we did before is the horribly despicable hack of placing the dependency in
safelease.
Line 161: %{warn:Ceph is not avilable on ppc64le}
Line 162: %else
Line 163: Requires: ceph-common
Line 164: %endif
--
To view, visit https://gerrit.ovirt.org/42471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eyal Edri ee...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: testAddVlanedBridgeless should use a standard name
automat...@ovirt.org has posted comments on this change. Change subject: net: tests: testAddVlanedBridgeless should use a standard name .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id188d189731439a11f774fdc4d5adf1272ee1ed0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tolerate missing ovirt-vmconsole group
Dan Kenigsberg has posted comments on this change. Change subject: virt: tolerate missing ovirt-vmconsole group .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42451/3//COMMIT_MSG Commit Message: Line 12: group in order to let ovirt-vmconsole-host Line 13: connect to that socket. Line 14: Line 15: ovirt-vmconsole-host it is a soft dependency. Line 16: VDSM should happily run without that package, ...however, Vdsm must not happily start a VM where this new feature was explicitly requested by Engine, but Vdsm cannot deliver. Line 17: but incorrectly assumed the ovirt-vmconsole Line 18: group existed in the system Line 19: Line 20: This patch lift this requirement: -- To view, visit https://gerrit.ovirt.org/42451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55b708953e5871053f0063bb82434c5c0dcb6103 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Open vSwitch configurator
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Open vSwitch configurator .. Patch Set 41: (2 comments) https://gerrit.ovirt.org/#/c/40312/41/vdsm.spec.in File vdsm.spec.in: Line 607: openvswitch we should find (or found..) a yum repo hosting this. Or at lease point users to http://cbs.centos.org/kojifiles/packages/openvswitch/2.3.1/2.el7/x86_64/openvswitch-2.3.1-2.el7.x86_64.rpm https://gerrit.ovirt.org/#/c/40312/41/vdsm_hooks/ovs/ovs_before_network_setup.py File vdsm_hooks/ovs/ovs_before_network_setup.py: Line 25: - print created command in a nicer way - single line for one command, Line 26: `comment adding|editing|removing network ` Line 27: - improve performance, iterations, data structures, joining lists etc Line 28: - use some sets to not iterate running config over and over Line 29: - create libvirt network? ! this is required so that we can use the network for a VM's display network. Line 30: - more caps and stats from ovs-ofctl show Line 31: - if ovs command fail, dont end with unexpected exception but smt more verbose Line 32: - not able to rewrite non ovs network with ovs (?) - list all limitations Line 33: in README -- To view, visit https://gerrit.ovirt.org/40312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f Gerrit-PatchSet: 41 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Barak Azulay bazu...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Nir Soffer has posted comments on this change. Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg .. Patch Set 9: Ala, can you take this patch for a final ride with your patches? -- To view, visit https://gerrit.ovirt.org/41568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Save state only if disk was updated
Freddy Rolland has posted comments on this change. Change subject: vm: Save state only if disk was updated .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081a0c7f544a003665bd02769489d601bdf7a86b Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding StorageDomain.getBackedUpVmsInfo
automat...@ovirt.org has posted comments on this change. Change subject: adding StorageDomain.getBackedUpVmsInfo .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2896897bccc493457695181436a55f688bb596f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: adding StorageDomain.detachHsm
automat...@ovirt.org has posted comments on this change. Change subject: sp: adding StorageDomain.detachHsm .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0799873c2fb57853d5a8f058577612cef42b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding the StorageDomain.upgradeVersion verb
automat...@ovirt.org has posted comments on this change. Change subject: adding the StorageDomain.upgradeVersion verb .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fb87c6e04e48072ec90d07a0f4c7a61411a808 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding StorageDomain.getBackedUpVmsInfo
Liron Aravot has restored this change. Change subject: adding StorageDomain.getBackedUpVmsInfo .. Restored -- To view, visit https://gerrit.ovirt.org/42129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ie2896897bccc493457695181436a55f688bb596f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: adding detachAnyStoragePoolHsm
automat...@ovirt.org has posted comments on this change. Change subject: adding detachAnyStoragePoolHsm .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd060b575105364b73325fa8c22b3a61d8ece742 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tolerate missing ovirt-vmconsole group
Nir Soffer has posted comments on this change.
Change subject: virt: tolerate missing ovirt-vmconsole group
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/42451/2/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:
Line 102: try:
Line 103: supervdsm.getProxy().prepareVmChannel(
Line 104: self._path,
Line 105: constants.OVIRT_VMCONSOLE_GROUP)
Line 106: except KeyError:
KeyError is pretty bad error to check here, but this is stdlib fault.
We should fix this later in fileUtils, raise an error that cannot mask a bug in
the calling code.
Line 107: self.log.warn('unknown group %s, permissions not
updated',
Line 108: constants.OVIRT_VMCONSOLE_GROUP)
Line 109:
Line 110: def cleanup(self):
--
To view, visit https://gerrit.ovirt.org/42451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55b708953e5871053f0063bb82434c5c0dcb6103
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
Nir Soffer has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 3: Code-Review-1 This works for building vdsm on ppc64le machine, but we build vdsm once on x86_64 for all platforms. -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sagi Shnaidman sshna...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added standard build skeleton
automat...@ovirt.org has posted comments on this change. Change subject: Added standard build skeleton .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro dcaro...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: configuredPorts should handle empty nets.
automat...@ovirt.org has posted comments on this change. Change subject: net: configuredPorts should handle empty nets. .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72d929f413fd98db46b58ada8e1353436f6cf06a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: tests: testAddVlanedBridgeless should use a standard name
Ido Barkan has uploaded a new change for review. Change subject: net: tests: testAddVlanedBridgeless should use a standard name .. net: tests: testAddVlanedBridgeless should use a standard name Names that do not start with NETWORK_NAME are not cleared by shell_helper emergency_net_cleanup command. Change-Id: Id188d189731439a11f774fdc4d5adf1272ee1ed0 Signed-off-by: Ido Barkan ibar...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/42480/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 5db352d..92a14ed 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -1595,7 +1595,7 @@ @cleanupNet def testAddVlanedBridgeless(self): # BZ# 980174 -vlan_name = 'vlan_net' +vlan_name = NETWORK_NAME + '-v' with dummyIf(1) as nics: nic, = nics # net NETWORK_NAME has bootproto:none because we can't use dhcp -- To view, visit https://gerrit.ovirt.org/42480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id188d189731439a11f774fdc4d5adf1272ee1ed0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: SetupNetworks small cleanups.
automat...@ovirt.org has posted comments on this change. Change subject: net: SetupNetworks small cleanups. .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: during boot, restore only networks that were actually c...
automat...@ovirt.org has posted comments on this change. Change subject: net: during boot, restore only networks that were actually changed. .. Patch Set 10: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66307a7cf6b0f7269a1ae04aa7c1748dde768144 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ifcfg: ONBOOT=yes on all persisted network files.
automat...@ovirt.org has posted comments on this change. Change subject: net: ifcfg: ONBOOT=yes on all persisted network files. .. Patch Set 6: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia942827745945f0f2e2a0e1691996824511cc111 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: reset bonding options to defaults.
automat...@ovirt.org has posted comments on this change. Change subject: net: reset bonding options to defaults. .. Patch Set 17: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe720674e63119e954265735e9f5ccb994c3531a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: serial console: require ovirt-vmconsole
Francesco Romani has posted comments on this change. Change subject: spec: serial console: require ovirt-vmconsole .. Patch Set 1: Verified-1 cannot merge this until we are sure ovirt-vmconsole package is widely available (checking it out) -- To view, visit https://gerrit.ovirt.org/42479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b251b3cd92652bd79f22e088ddd5fd01760cebe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: introducing KernelConfig
automat...@ovirt.org has posted comments on this change. Change subject: net: introducing KernelConfig .. Patch Set 14: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: log skipped devices
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: log skipped devices .. virt: log skipped devices Since hostdev passthrough doesn't require all of the devices in the same iommu group to be assigned to VM but they still have to be detached, it might help future debugging to actually log skipped devices. Change-Id: I8b5bb6c930b825500e8a798ff157d90ac15b8f31 Signed-off-by: Martin Polednik mpoled...@redhat.com Reviewed-on: https://gerrit.ovirt.org/42433 Reviewed-by: Dan Kenigsberg dan...@redhat.com Continuous-Integration: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/42433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5bb6c930b825500e8a798ff157d90ac15b8f31 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: log skipped devices
automat...@ovirt.org has posted comments on this change. Change subject: virt: log skipped devices .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b5bb6c930b825500e8a798ff157d90ac15b8f31 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: log skipped devices
Dan Kenigsberg has posted comments on this change. Change subject: virt: log skipped devices .. Patch Set 1: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/42433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b5bb6c930b825500e8a798ff157d90ac15b8f31 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
Nir Soffer has posted comments on this change. Change subject: ceph: Support ephemeral Libvirt secrets .. Patch Set 27: Verified+1 Rebase and renumber secret errors after ksm error was merged. -- To view, visit https://gerrit.ovirt.org/40712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
