Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: vdscli: Provide py3 compatible xmlrpclib (using six)
..


vdscli: Provide py3 compatible xmlrpclib (using six)

Change-Id: I6fa6125076826c1b975fbfd3d9e788a914b9b913
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/58366
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/61150
Tested-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/vdscli.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61150
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fa6125076826c1b975fbfd3d9e788a914b9b913
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net virt: Support connecting VM/s to an ovs bridge

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net virt: Support connecting VM/s to an ovs bridge
..


net virt: Support connecting VM/s to an ovs bridge

Change-Id: Id233c3b46f0d3a546d1524456fc681d16873ad50
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/57508
Tested-by: Petr Horáček 
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/61119
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch.py
M lib/vdsm/network/ovs/info.py
M tests/deviceTests.py
M vdsm/supervdsm_api/network.py
M vdsm/virt/vmdevices/network.py
6 files changed, 102 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id233c3b46f0d3a546d1524456fc681d16873ad50
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: move ip configuration to ip.address module

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: move ip configuration to ip.address module
..


net: move ip configuration to ip.address module

We need to share IP configuration functions with OVS switch.

Change-Id: I19fb50a41d9798b8f9b6c9c7549a4415c940f5a0
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58447
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61116
---
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/ip/address.py
2 files changed, 27 insertions(+), 27 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61116
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19fb50a41d9798b8f9b6c9c7549a4415c940f5a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: netswitch: split setup actions on netswitch level

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: netswitch: split setup actions on netswitch level
..


netswitch: split setup actions on netswitch level

This patch relocates split of nets and bonds actions (add, edit,
remove) from ovs/switch.py to netswitch.py.

We need this change to be able to run IP configuration directly from
netswitch.

This function can replace legacy switch actions split as well.

Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58502
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61115
---
M lib/vdsm/network/netswitch.py
M lib/vdsm/network/ovs/switch.py
A tests/network/netswitch_test.py
M tests/network/ovs_test.py
4 files changed, 90 insertions(+), 77 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61115
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: py3: Require libselinux-python3

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: py3: Require libselinux-python3
..


py3: Require libselinux-python3

The selinux package/module is not required in the spec and CI automation
packages, therefore py3 unit tests are failing.

Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/59425
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/61137
Tested-by: Petr Horáček 
---
M automation/check-merged.packages.fc23
M automation/check-patch.packages.fc23
M vdsm.spec.in
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: Setup ipv6autoconf with OVS switch

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: Setup ipv6autoconf with OVS switch
..


net: Setup ipv6autoconf with OVS switch

When handling an OVS switch setup, set ipv6autoconf for its northbound
ifaces.

This is required at this stage for passing functional tests.

Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/59444
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61114
Tested-by: Petr Horáček 
---
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/netswitch.py
M lib/vdsm/sysctl.py
3 files changed, 51 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61114
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: don't count bond slave duplicates

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: don't count bond slave duplicates
..


ovs: don't count bond slave duplicates

We should check that set(slaves) contains 2 or more slaves to not
get fooled by two slaves with the same name.

Change-Id: I073b555799bd1f558078e993127f3dfbaad09204
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58368
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61113
---
M lib/vdsm/network/ovs/validator.py
M tests/network/ovs_test.py
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I073b555799bd1f558078e993127f3dfbaad09204
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: edit bond mode

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: edit bond mode
..


ovs: edit bond mode

With this patch we allow setup of OVS bond with one of 'fallback'
modes 1 and 4 and miimon.

In another patch we will allow users to edit all OVS bond parameters.
Fallback modes must be used for legacy->ovs migration. Bonds with other
modes or options cannot be migrated.

Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58437
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61112
---
M lib/vdsm/network/kernelconfig.py
M lib/vdsm/network/ovs/info.py
M lib/vdsm/network/ovs/switch.py
M tests/functional/networkTests.py
M tests/network/ovs_info_test.py
5 files changed, 109 insertions(+), 23 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network based on a bond

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: add/remove OVS network based on a bond
..


ovs: add/remove OVS network based on a bond

Bond modes will be handled in a following patch.

Change-Id: I67305c97b2a00abd05523134c24ef497f33c1c88
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58202
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/6
---
M lib/vdsm/network/ovs/info.py
M lib/vdsm/network/ovs/switch.py
M tests/network/ovs_test.py
3 files changed, 163 insertions(+), 43 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/6
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67305c97b2a00abd05523134c24ef497f33c1c88
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: use transaction class for devices setup

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: use transaction class for devices setup
..


ovs: use transaction class for devices setup

With this patch we use transaction class instead of plain functions
to setup OVS networks.

This will be handy with following OVS bonds patch where we need a few
shared dictionaries across methods.

Change-Id: Idadab1330a5ae3a420fc7622f8b24e2a4ea4df15
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58841
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61109
---
M lib/vdsm/network/ovs/switch.py
M tests/network/ovs_test.py
2 files changed, 70 insertions(+), 51 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idadab1330a5ae3a420fc7622f8b24e2a4ea4df15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: fix bond removal validation

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: fix bond removal validation
..


ovs: fix bond removal validation

We should allow removal of a bond which network-user will use nic
instead.

Change-Id: I5fd0a51fca056c04949f1916d0af435d1a125090
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/58723
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61108
---
M lib/vdsm/network/ovs/validator.py
M tests/network/ovs_test.py
2 files changed, 49 insertions(+), 9 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5fd0a51fca056c04949f1916d0af435d1a125090
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: validate that to-be-removed bond is not used

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: validate that to-be-removed bond is not used
..


ovs: validate that to-be-removed bond is not used

Change-Id: I8f8287fff7f000594c2b7a95873787ae02a27fe1
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58210
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61103
---
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/network/ovs/validator.py
M tests/network/ovs_test.py
3 files changed, 76 insertions(+), 14 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f8287fff7f000594c2b7a95873787ae02a27fe1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network based on a VLAN

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: add/remove OVS network based on a VLAN
..


ovs: add/remove OVS network based on a VLAN

Change-Id: I98be71c300f2413ea8a8f6c71ba7daac0cd16d5d
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58085
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61102
---
M lib/vdsm/network/ovs/switch.py
M tests/functional/networkTests.py
2 files changed, 11 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98be71c300f2413ea8a8f6c71ba7daac0cd16d5d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network that is based on a nic

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: add/remove OVS network that is based on a nic
..


ovs: add/remove OVS network that is based on a nic

Change-Id: Ie54c6f008eb2ee823c0dc4d56c9ec86aab5a4602
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/58012
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61101
---
M lib/vdsm/network/netswitch.py
M lib/vdsm/network/ovs/switch.py
M tests/functional/networkTests.py
3 files changed, 111 insertions(+), 8 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61101
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie54c6f008eb2ee823c0dc4d56c9ec86aab5a4602
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: don't check if changes are needed in net editation

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: don't check if changes are needed in net editation
..


ovs: don't check if changes are needed in net editation

We cannot compare query attributes with netinfo ones - they
incompatible. With this patch, settting up a network with the exact
same attribute as already define ends up with removing it and adding it
again.

Change-Id: I825a19dd9984b4eb99f0e520cf277c5da5c1a8ce
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58254
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/61100
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I825a19dd9984b4eb99f0e520cf277c5da5c1a8ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: use unfaked ovs_netinfo under ovs package

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: use unfaked ovs_netinfo under ovs package
..


ovs: use unfaked ovs_netinfo under ovs package

Change-Id: I283500f7e395b561a53ce67027fd54fbf8c000e0
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58253
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60874
---
M lib/vdsm/network/ovs/info.py
M lib/vdsm/network/ovs/switch.py
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I283500f7e395b561a53ce67027fd54fbf8c000e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: add bridges_by_sb property to OvsInfo

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: add bridges_by_sb property to OvsInfo
..


ovs: add bridges_by_sb property to OvsInfo

This will be used in a following ovs setupNetworks patch.

Change-Id: I885c15da0478c3bf8f726bdd335f55afd6c4caf6
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58159
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60873
---
M lib/vdsm/network/ovs/info.py
M tests/network/ovs_info_test.py
2 files changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I885c15da0478c3bf8f726bdd335f55afd6c4caf6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: ovs: bridge is optional for del-port

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: ovs: bridge is optional for del-port
..


ovs: bridge is optional for del-port

ovs-vsctl does not require bridge name for port removal. We will
use this in L2 setup.

Change-Id: I875ea661afef46fcbeb62a62adcb004696d4d872
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/58078
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60872
---
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
M tests/network/ovs_driver_test.py
3 files changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I875ea661afef46fcbeb62a62adcb004696d4d872
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: use netinfo to split OVS nets and bonds

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: use netinfo to split OVS nets and bonds
..


net: use netinfo to split OVS nets and bonds

Our decision of what should be done with a query (add, edit, remove)
should not be based on expected running configuration (saved in
RunningConfig) but on actual system state reported by netinfo.

Change-Id: I67f80ac27b824b7a07e87165fd43db48b919d957
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57446
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60871
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 6 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67f80ac27b824b7a07e87165fd43db48b919d957
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: use netinfo to split OVS/legacy nets and bonds

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: use netinfo to split OVS/legacy nets and bonds
..


net: use netinfo to split OVS/legacy nets and bonds

Netinfo now contains 'switch' attribute and therefore we can use
real running configuration to split OVS/legacy entries.

Change-Id: I2f48aa7a5b51f11ed5239b658cf46415f69942ac
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57445
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60870
---
M lib/vdsm/network/netswitch.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60870
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f48aa7a5b51f11ed5239b658cf46415f69942ac
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: use netinfo for OVS validation

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: use netinfo for OVS validation
..


net: use netinfo for OVS validation

Use real running netinfo configuration for OVS validation instead
of running config.

Change-Id: Ic75a6c52fd4f944daba50a3442a4756268998b22
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57444
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60869
---
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/network/ovs/validator.py
M tests/network/ovs_test.py
3 files changed, 21 insertions(+), 25 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60869
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic75a6c52fd4f944daba50a3442a4756268998b22
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: ovs validator should accept multiple untagged nets

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: ovs validator should accept multiple untagged nets
..


net: ovs validator should accept multiple untagged nets

Change-Id: I7857dad7333a6da9892b70b2eaa83079e17bd240
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57443
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60868
---
M lib/vdsm/network/ovs/validator.py
M tests/network/ovs_test.py
2 files changed, 1 insertion(+), 18 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60868
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7857dad7333a6da9892b70b2eaa83079e17bd240
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: fix validation bug: ovs_bonds should be used

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: fix validation bug: ovs_bonds should be used
..


net: fix validation bug: ovs_bonds should be used

Change-Id: Ifbafbd2c0ecacf70c3dd7aae9c4a89c3218da0ed
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57442
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60867
---
M lib/vdsm/network/netswitch.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbafbd2c0ecacf70c3dd7aae9c4a89c3218da0ed
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: common and legacy CachingNetInfo

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: common and legacy CachingNetInfo
..


net: common and legacy CachingNetInfo

CachingNetInfo is not suitable for mixed OVS and Legacy networks.

CachingNetInfo should be used only in legacy networks configuration
where we don't need the whole system netinfo. It contains
updateDevices() method which cannot be easily used with OVS netinfo.

For all the other code newly introduced NetInfo should be used. It
has no implicit arguments. Netinfo dictionary has to be passed to it
every time, so we have full control of its contents.

Legacy netinfo should be divided into NICs netinfo and legacy networks
netinfo.

Change-Id: Ib8c88b1454245364d5dadd4d2baf147658faaef2
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1195208
Reviewed-on: https://gerrit.ovirt.org/57441
Reviewed-by: Edward Haas 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60866
Reviewed-by: Francesco Romani 
---
M lib/vdsm/network/netinfo/cache.py
M lib/vdsm/tool/unified_persistence.py
M tests/functional/networkTests.py
M tests/network/unified_persistence_test.py
M vdsm/vdsm-restore-net-config
M vdsm_hooks/extra_ipv4_addrs/extra_ipv4_addrs.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
7 files changed, 39 insertions(+), 30 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60866
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8c88b1454245364d5dadd4d2baf147658faaef2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: common and legacy CachingNetInfo

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: common and legacy CachingNetInfo
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60866
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8c88b1454245364d5dadd4d2baf147658faaef2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: report OVS netinfo in caps

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: report OVS netinfo in caps
..


net: report OVS netinfo in caps

Even non-root caps (legacy networks+nics) are now obtained
from supervdsm. The reason is, that we do not want to keep logic
of legacy-OVS netinfo merging in two places (caps and netswitch).

When we manage to split legacy netinfo to legacy networks and NICs
parts, we will be able to simply divide netinfo between root and
non-root.

Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57102
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/60865
Reviewed-by: Edward Haas 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch.py
M vdsm/caps.py
M vdsm/supervdsm_api/network.py
4 files changed, 41 insertions(+), 14 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: report OVS netinfo in caps

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: netinfo: report 'vlanid' only if vlan is set

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: netinfo: report 'vlanid' only if vlan is set
..


netinfo: report 'vlanid' only if vlan is set

Change-Id: I6a0c30177f238154b34513f83b7914d1783fd422
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/57818
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/60864
---
M lib/vdsm/network/netinfo/cache.py
M lib/vdsm/network/ovs/info.py
M tests/network/ovs_info_test.py
3 files changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/60864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a0c30177f238154b34513f83b7914d1783fd422
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: refactor tests

[fromani]

Francesco Romani has posted comments on this change.

Change subject: sampling: refactor tests
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/61309/1//COMMIT_MSG
Commit Message:

PS1, Line 7: sampling: refactor tests
> tests: add (robust) fake monotonic clock?
better, yes. Will change.


https://gerrit.ovirt.org/#/c/61309/1/tests/samplingTests.py
File tests/samplingTests.py:

PS1, Line 240: @property
 : def frozen(self):
 : return self._frozen
> I don't like this. Just access the attribute directly.
We don't actually need this yet, so I'll just drop this.


-- 
To view, visit https://gerrit.ovirt.org/61309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: virt net: Change graphics type from network to address
..


virt net: Change graphics type from network to address

This patch changes the graphics listen type of VM/s from a libvirt
network name to an address for OVS based display networks.

OVS integration has avoided the use of libvirt network entities, for
simplicitly and as part of a general effort to eliminate VDSM networking
libvirt dependency.
With this patch, a VM graphics may be assign to an OVS based host network.

NOTE: This patch must be merged with the libvirt hook patch.
(id: Ie7d32f9605f9ca99d1e070621)

This reverts commit 9e3ff6d62bd42fad387e69c1a6bdab153cd3.

Change-Id: Id809e90f2340caffaf30a5749dd75ec39516c96c
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/59336
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Tested-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/61120
Reviewed-on: https://gerrit.ovirt.org/61262
Reviewed-by: Dan Kenigsberg 
Tested-by: Dan Kenigsberg 
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 19 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/61262
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id809e90f2340caffaf30a5749dd75ec39516c96c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: periodic: fix stats age reporting
..


Patch Set 1: Verified+1

verified
1. using the tests
2. as described in BZ: running one VM, SIGSTOP'ing QEMU, waited > 60s (default 
timeout), checked monitor Response was OK before the timeout, reported 
unresponsive afterwards; then SIGCON'd QEMU, verified that monitor Response is 
reported OK again.

-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: refactor tests

[fromani]

Francesco Romani has posted comments on this change.

Change subject: sampling: refactor tests
..


Patch Set 1: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/61309/1/tests/samplingTests.py
File tests/samplingTests.py:

Line 228: memorySample = sampling.NumaNodeMemorySample()
Line 229: self.assertEqual(memorySample.nodesMemSample, expected)
Line 230: 
Line 231: 
Line 232: class FakeClock(object):
not strictly needed, but helps making the tests clearer, especially the ones 
needed by the next patch.
Line 233: 
Line 234: STEP = 1
Line 235: 
Line 236: def __init__(self, value=0):


-- 
To view, visit https://gerrit.ovirt.org/61309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[fromani]

Francesco Romani has posted comments on this change.

Change subject: sampling: micro-optimization
..


Patch Set 1: Verified-1

not yet ready.

-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: refactor tests

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: sampling: refactor tests
..

sampling: refactor tests

Refactor the tests to make them clearer and to make room
for further improvements.

Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1357798
Signed-off-by: Francesco Romani 
---
M tests/samplingTests.py
1 file changed, 33 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/61309/1

diff --git a/tests/samplingTests.py b/tests/samplingTests.py
index caca2c6..bba216f 100644
--- a/tests/samplingTests.py
+++ b/tests/samplingTests.py
@@ -229,17 +229,37 @@
 self.assertEqual(memorySample.nodesMemSample, expected)
 
 
+class FakeClock(object):
+
+STEP = 1
+
+def __init__(self, value=0):
+self.value = value
+self._frozen = False
+
+@property
+def frozen(self):
+return self._frozen
+
+def freeze(self, value=None):
+if value is not None:
+self.value = value
+self._frozen = True
+
+def unfreeze(self):
+self._frozen = False
+
+def __call__(self):
+if not self._frozen:
+self.value += self.STEP
+return self.value
+
+
 class StatsCacheTests(TestCaseBase):
 
-FAKE_CLOCK_STEP = 1
-
 def setUp(self):
-self.clock = 0
+self.fake_monotonic_time = FakeClock()
 self.cache = sampling.StatsCache(clock=self.fake_monotonic_time)
-
-def fake_monotonic_time(self):
-self.clock += self.FAKE_CLOCK_STEP
-return self.clock
 
 def test_empty(self):
 res = self.cache.get('x')  # vmid not relevant
@@ -261,8 +281,8 @@
 self.assertEqual(res,
  ('foo',
   'bar',
-  self.FAKE_CLOCK_STEP,
-  self.FAKE_CLOCK_STEP))
+  FakeClock.STEP,
+  FakeClock.STEP))
 
 def test_get_missing(self):
 self._feed_cache((
@@ -282,8 +302,8 @@
 self.assertEqual(res,
  ('bar',
   'baz',
-  self.FAKE_CLOCK_STEP,
-  self.FAKE_CLOCK_STEP))
+  FakeClock.STEP,
+  FakeClock.STEP))
 
 def test_put_out_of_order(self):
 self._feed_cache((
@@ -295,7 +315,7 @@
 self.assertEqual(res,
  ('foo',
   'baz',
-  self.FAKE_CLOCK_STEP,
+  FakeClock.STEP,
   0))
 
 def test_skip_one_cycle(self):
@@ -308,7 +328,7 @@
 ({'a': 'baz', 'b': 'baz'}, 3),
 ))
 self.assertEqual(self.cache.get('a'),
- ('bar', 'baz', 1, self.FAKE_CLOCK_STEP))
+ ('bar', 'baz', 1, FakeClock.STEP))
 self.assertEqual(self.cache.get('b'),
  sampling.EMPTY_SAMPLE)
 


-- 
To view, visit https://gerrit.ovirt.org/61309
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic88fc4e5f625ed97aa68bba87e1979ff06621b5b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: periodic: fix stats age reporting

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: periodic: fix stats age reporting
..

vm: periodic: fix stats age reporting

The Vm class reports the monitor responsiveness in two ways:
1. if a libvirt operation reports a timeout (a standard libvirt
exception)
2. if one sampling operation hangs for too long

In the second case, given the transient nature of the detected
failure, the responsiveness is reported, but not stored as Vm
field. This is noteworthy, but totally expected and legitimate.

The sampling code stores the bulk samples only for a limited
number of cycles, and drops the old values.
The sampling code also used to calculate the sample age
based on the stored values.

But if a VM hangs for too long, all its samples are eventually
evicted from the samples cache, so it stats age becomes None,
which is misinterpred as responsive VM.

We should keep reporting None when we don't have enough meaningful
data, but we should also fix the sampling age reporting; we do
so using earlier in the flow the vm last timestamp, which is needed
and guaranteed to be present for the sampling code to work at all.

Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1357798
Signed-off-by: Francesco Romani 
---
M lib/vdsm/virt/sampling.py
M tests/samplingTests.py
2 files changed, 26 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/61310/1

diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 4cfd3b1..4c34e13 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -411,18 +411,23 @@
 Return the available StatSample for the given VM.
 """
 with self._lock:
-first_batch, last_batch, interval = self._samples.stats()
-
-if first_batch is None:
+last_ts = self._vm_last_timestamp.get(vmid)
+if last_ts is None:
+# this VM was never seen (yet)
 return EMPTY_SAMPLE
 
+first_batch, last_batch, interval = self._samples.stats()
+if first_batch is None:
+# not yet sampled
+return EMPTY_SAMPLE
+
+stats_age = self._clock() - last_ts
 first_sample = first_batch.get(vmid)
 last_sample = last_batch.get(vmid)
 
 if first_sample is None or last_sample is None:
-return EMPTY_SAMPLE
-
-stats_age = self._clock() - self._vm_last_timestamp[vmid]
+# recovering, or just gone disrupted
+return StatsSample(None, None, None, stats_age)
 
 return StatsSample(first_sample, last_sample,
interval, stats_age)
diff --git a/tests/samplingTests.py b/tests/samplingTests.py
index bba216f..a2ecadf 100644
--- a/tests/samplingTests.py
+++ b/tests/samplingTests.py
@@ -327,10 +327,23 @@
 # here we lost sampling for 'b'
 ({'a': 'baz', 'b': 'baz'}, 3),
 ))
+self.fake_monotonic_time.freeze(value=4)
 self.assertEqual(self.cache.get('a'),
- ('bar', 'baz', 1, FakeClock.STEP))
+ ('bar', 'baz', 1, 1))
 self.assertEqual(self.cache.get('b'),
- sampling.EMPTY_SAMPLE)
+ (None, None, None, 1))
+
+def test_missing_initially(self):
+self._feed_cache((
+({'a': 'foo'}, 1),
+({'a': 'bar', 'b': 'baz'}, 2)
+))
+self.fake_monotonic_time.freeze(value=3)
+res = self.cache.get('b')
+self.assertEqual(
+res,
+(None, None, None, 1),
+)
 
 def _feed_cache(self, samples):
 for sample in samples:


-- 
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e61626625a2e0517d55dc61e361f3f5eb690c00
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sampling: micro-optimization

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: sampling: micro-optimization
..

sampling: micro-optimization

make timestamp update faster.

Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
TODO: benchmark this.
Signed-off-by: Francesco Romani 
---
M lib/vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/61311/1

diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 4c34e13..4595701 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -452,17 +452,14 @@
 if monotonic_ts >= last_sample_time:
 self._samples.append(bulk_stats)
 self._last_sample_time = monotonic_ts
-
-self._update_ts(bulk_stats, monotonic_ts)
+# FIXME: this is expected to be costly performance-wise.
+self._vm_last_timestamp.update(
+(vm_id, monotonic_ts) for vm_id in bulk_stats
+)
 else:
 self._log.warning(
 'dropped stale old sample: sampled %f stored %f',
 monotonic_ts, last_sample_time)
-
-def _update_ts(self, bulk_stats, monotonic_ts):
-# FIXME: this is expected to be costly performance-wise.
-for vmid in bulk_stats:
-self._vm_last_timestamp[vmid] = monotonic_ts
 
 
 stats_cache = StatsCache()


-- 
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4361bf4ccae67be3a9e42a0d3368e1e1c246393
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Do not give Xen a special treatment.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Do not give Xen a special treatment.
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57430/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 995: except libvirt.libvirtError as e:
Line 996: if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
Line 997: logging.exception('Error checking for existing 
snapshots.')
Line 998: # else: The snapshot related API is not implemented in all 
libvirt
Line 999: #   drivers. It is missing e.g. in Xen.
> Look good if we don't care about the driver, and can work with any driver b
+1 - also, the new code seems slightly better
Line 1000: else:
Line 1001: params['has_snapshots'] = ret > 0
Line 1002: 
Line 1003: 


-- 
To view, visit https://gerrit.ovirt.org/57430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I597118940d42ee953d9cdc83bb44afd13b5e882a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: Improve logging when receiving signals
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: logging: Improve logging when receiving signals

[fromani]

Francesco Romani has posted comments on this change.

Change subject: logging: Improve logging when receiving signals
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1462d296ca99e8eb2eee8640648db0eea039a83c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: refmt: Use more standard main() function

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: refmt: Use more standard main() function
..


refmt: Use more standard main() function

There is no need to make main() private.

Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/60769
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
---
M contrib/refmt
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/60769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: remft: Add online help

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: remft: Add online help
..


remft: Add online help

Example:

$ contrib/refmt -h
usage: refmt [-h] [file [file ...]]

Reformat python literals

positional arguments:
  fileFiles to reformat, nothing to process stdin

optional arguments:
  -h, --help  show this help message and exit

Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/60768
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
---
M contrib/refmt
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/60768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move namespace declaration

[fromani]

Francesco Romani has abandoned this change.

Change subject: vmxml: move namespace declaration
..


Abandoned

made obsolete by updated https://gerrit.ovirt.org/#/c/60481/15

-- 
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie33d816707cc76d4cce61a7d61d42a4304737ee6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/59817/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS5, Line 1844: self._guestEventTime = self._startTime
> Please make the newlines consistent when refactoring.
fixed (after too long :\)


-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: split guest agent init from domDependentInit
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: split device init from domDependentInit
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/59817/18/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1643: if not self._dom.connected:
Line 1644: raise 
MissingLibvirtDomainError(vmexitreason.LIBVIRT_START_FAILED)
Line 1645: 
Line 1646: sampling.stats_cache.add(self.id)
Line 1647: self._guestEventTime = self._startTime
this is harmless, but requires more work to be done correctly and really 
improving the code. Firs draft (little more than a braindump atm here: 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:guestevent-fix)
Line 1648: 
Line 1649: self._updateDomainDescriptor()
Line 1650: 
Line 1651: self._dom_init_devices()


-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 18: Code-Review-2

Let's do like this:
1. improve Vm.domDependentInit() separately: 
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:dom-dep-fixes
2. reorganize this series to not need this patch

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 18: Code-Review-2

the plan changed as follows:
1. improve Vm.domDependentInit in a separate series
2. abandon this patch, is not strictly needed for container support.

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/59814/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS5, Line 1883: def _dom_init_devices(self):
> This function is too packed. I believe it would be slightly better to keep 
I'll drop this patch for the time being, let's continue discussing the 
improvements to the parent function here:

https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:dom-dep-fixes


-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: rename Vm._guestEvent

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: rename Vm._guestEvent
..

vm: rename Vm._guestEvent

The _guestEvent field of Vm class is misleading.
It does not track a "guest event", but rather sets a transient
VM status which overrides the real VM status for a fixed amount of time.

After the amount of time expires, the transient VM status is ignored,
and the proper VM status is used.

Research why this logic was introduced is still in progress;
the most likely cause is to provide the correct information to Engine
while lenghty operation (VM startup or powerdown) is in progress;
should this lengthy operation fail, the transient nature provides
automatic readjustement avoiding the need of proper recovering.

However, the price to pay is increased complexity and more VM fields
to track.

This patch just renames the field to make their real purpose clearer.

Change-Id: I9fd081830146840890cf22749b41eab4b06f31db
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/61245/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7c21eca..1135896 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -267,8 +267,8 @@
 self._volPrepareLock = threading.Lock()
 self._initTimePauseCode = None
 self._initTimeRTC = int(self.conf.get('timeOffset', 0))
-self._guestEvent = vmstatus.POWERING_UP
-self._guestEventTime = 0
+self._transient_status = vmstatus.POWERING_UP
+self._transient_status_time = 0
 self._guestCpuRunning = False
 self._guestCpuLock = threading.Lock()
 self._startTime = time.time() - \
@@ -658,8 +658,8 @@
 try:
 self.log.info('reboot event')
 self._startTime = time.time()
-self._guestEventTime = self._startTime
-self._guestEvent = vmstatus.REBOOT_IN_PROGRESS
+self._transient_status_time = self._startTime
+self._transient_status = vmstatus.REBOOT_IN_PROGRESS
 self._powerDownEvent.set()
 self.saveState()
 # this always triggers onStatusChange event, which
@@ -1070,13 +1070,13 @@
 
 delay = int(delay)
 
-self._guestEventTime = time.time()
+self._transient_status_time = time.time()
 if reboot:
-self._guestEvent = vmstatus.REBOOT_IN_PROGRESS
+self._transient_status = vmstatus.REBOOT_IN_PROGRESS
 powerDown = VmReboot(self, delay, message, timeout, force,
  self._powerDownEvent)
 else:
-self._guestEvent = vmstatus.POWERING_DOWN
+self._transient_status = vmstatus.POWERING_DOWN
 powerDown = VmShutdown(self, delay, message, timeout, force,
self._powerDownEvent)
 return powerDown.start()
@@ -1312,16 +1312,17 @@
 
 def _getVmStatus(self):
 def _getVmStatusFromGuest():
-GUEST_WAIT_TIMEOUT = 60
+TRANSIENT_STATUS_VALIDITY = 60
 now = time.time()
-if now - self._guestEventTime < 5 * GUEST_WAIT_TIMEOUT and \
-self._guestEvent == vmstatus.POWERING_DOWN:
-return self._guestEvent
+if (((now - self._transient_status_time) < 
+(5 * TRANSIENT_STATUS_VALIDITY) and 
+self._transient_status == vmstatus.POWERING_DOWN):
+return self._transient_status
 if self.guestAgent and self.guestAgent.isResponsive() and \
 self.guestAgent.getStatus():
 return self.guestAgent.getStatus()
-if now - self._guestEventTime < GUEST_WAIT_TIMEOUT:
-return self._guestEvent
+if now - self._transient_status_time < TRANSIENT_STATUS_VALIDITY:
+return self._transient_status
 return vmstatus.UP
 
 statuses = (vmstatus.SAVING_STATE, vmstatus.RESTORING_STATE,
@@ -1665,7 +1666,7 @@
 supervdsm.getProxy().setPortMirroring(network,
   nic.name)
 
-self._guestEventTime = self._startTime
+self._transient_status_time = self._startTime
 try:
 self.guestAgent.start()
 except Exception:


-- 
To view, visit https://gerrit.ovirt.org/61245
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd081830146840890cf22749b41eab4b06f31db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: legacy rng devices fix not needed anymore

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: legacy rng devices fix not needed anymore
..

vm: legacy rng devices fix not needed anymore

We introduced this fix to deal with upgrades from Vdsm
4.16.z, and we don't need this anymore.

Change-Id: I34eef559ef3d789fd502490acc9691df15c684b9
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/61243/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 61a59ca..df32da0 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1647,13 +1647,6 @@
 
 self._updateDomainDescriptor()
 
-# REQUIRED_FOR migrate from vdsm-4.16
-#
-# We need to clean out unknown devices that are created for
-# RNG devices by VDSM 3.5 and are left in the configuration
-# after upgrade to 3.6.
-self._fixLegacyRngConf()
-
 self._getUnderlyingVmDevicesInfo()
 self._updateAgentChannels()
 
@@ -4604,25 +4597,6 @@
 newChain = [x for x in device['volumeChain']
 if x['volumeID'] in volumes]
 device['volumeChain'] = drive.volumeChain = newChain
-
-def _fixLegacyRngConf(self):
-def _is_legacy_rng_device_conf(dev):
-"""
-Returns True if dev is a legacy (3.5) RNG device conf,
-False otherwise.
-"""
-return dev['type'] == hwclass.RNG and (
-'specParams' not in dev or
-'source' not in dev['specParams']
-)
-
-with self._confLock:
-self._devices[hwclass.RNG] = [dev for dev
-  in self._devices[hwclass.RNG]
-  if 'source' in dev.specParams]
-self.conf['devices'] = [dev for dev
-in self.conf['devices']
-if not _is_legacy_rng_device_conf(dev)]
 
 def getDiskDevices(self):
 return self._devices[hwclass.DISK]


-- 
To view, visit https://gerrit.ovirt.org/61243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34eef559ef3d789fd502490acc9691df15c684b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: move device initialization together

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: move device initialization together
..

vm: move device initialization together

It was scatthered around in Vm._domDependentInit for no good reason
No intended changes in behaviour

Change-Id: Ife7c85069e3a6703fdde74c87c68615308b2674e
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/61242/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7c21eca..61a59ca 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1665,6 +1665,9 @@
 supervdsm.getProxy().setPortMirroring(network,
   nic.name)
 
+for con in self._devices[hwclass.CONSOLE]:
+con.prepare()
+
 self._guestEventTime = self._startTime
 try:
 self.guestAgent.start()
@@ -1682,9 +1685,6 @@
 
 # Drop enableGuestEvents from conf - Not required from here anymore
 self.conf.pop('enableGuestEvents', None)
-
-for con in self._devices[hwclass.CONSOLE]:
-con.prepare()
 
 self._guestCpuRunning = self._isDomainRunning()
 self._logGuestCpuStatus('domain initialization')


-- 
To view, visit https://gerrit.ovirt.org/61242
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7c85069e3a6703fdde74c87c68615308b2674e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:

PS2, Line 19: configuring
> configure
Done


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 3: Verified+1

copied score.

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:

Line 29: `LEVEL` is one of DEBUG, INFO, WARNING, ERROR, CRITICAL
Line 30: `logger` is any logger Vdsm uses. Please check the configuration file
Line 31: to learn about some predefined loggers.
Line 32: 
Line 33: If no logger is given, the root logger default level is changed.
> Why? this is good feature and important note.
I just meant the current phrasing is misleading. Will keep the concept and 
rephrase the text.
Line 34: 
Line 35: Please note that the logging configuration of Vdsm is quite complex, so
Line 36: few trivial settings may yield surprising results.
Line 37: 


Line 46: vdsClient -s 0 setLogLevel WARNING virt
Line 47: 
Line 48: 3. same as #2, for storage (case is significant here)
Line 49: vdsClient -s 0 setLogLevel WARNING Storage
Line 50: vdsClient -s 0 setLogLevel WARNING storage
> We don't have time to work no this now - lets keep this text as is for now.
Ok, I'll keep this.
Line 51: 
Line 52: 4. silence JSONRPC logs:
Line 53: vdsClient -s 0 setLogLevel ERROR jsonrpc
Line 54: 


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: build: Remove python 3 test run

[fromani]

Francesco Romani has posted comments on this change.

Change subject: build: Remove python 3 test run
..


Patch Set 1:

We can make an exception to the flow for this patch.

-- 
To view, visit https://gerrit.ovirt.org/61189
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6723272a95b407e3fa9ad8e12f595d0b8f0d6a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: virt net: Change graphics type from network to address
..


virt net: Change graphics type from network to address

This patch changes the graphics listen type of VM/s from a libvirt
network name to an address for OVS based display networks.

OVS integration has avoided the use of libvirt network entities, for
simplicitly and as part of a general effort to eliminate VDSM networking
libvirt dependency.
With this patch, a VM graphics may be assign to an OVS based host network.

NOTE: This patch must be merged with the libvirt hook patch.
(id: Ie7d32f9605f9ca99d1e070621)

Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/59336
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Tested-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/61120
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 19 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Francesco Romani: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: remft: Add online help

[fromani]

Francesco Romani has posted comments on this change.

Change subject: remft: Add online help
..


Patch Set 2:

need ACK from Dan before merge into master. Nir, feel free to go forward if you 
wish.

-- 
To view, visit https://gerrit.ovirt.org/60768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8babaf66a86f5b540ee2c07b639ac59f27d3ebfc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: refmt: Use more standard main() function

[fromani]

Francesco Romani has posted comments on this change.

Change subject: refmt: Use more standard main() function
..


Patch Set 2:

need ACK from Dan before merge into master. Nir, feel free to go forward if you 
wish.

-- 
To view, visit https://gerrit.ovirt.org/60769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9caf13a436968a5fc800a0209cc37aea50a1a4eb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: add back setup log message

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add back setup log message
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5818fcff3c930adfe7a7c5cd0d97ecfcd4a51058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: add back setup log message

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add back setup log message
..


Patch Set 2: Code-Review+1

(1 comment)

one question inside

https://gerrit.ovirt.org/#/c/61181/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

PS2, Line 44: device
device or hostdev?


-- 
To view, visit https://gerrit.ovirt.org/61181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5818fcff3c930adfe7a7c5cd0d97ecfcd4a51058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: json: use forzenset for filtered methods

[fromani]

Francesco Romani has posted comments on this change.

Change subject: json: use forzenset for filtered methods
..


Patch Set 3: Code-Review-2

we are using this scapegoat patch to verify if a previously reported failure is 
real or not. I believe it is not real, but due diligence mandates some extra 
checks.

-- 
To view, visit https://gerrit.ovirt.org/58796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: json: use forzenset for filtered methods

[fromani]

Francesco Romani has restored this change.

Change subject: json: use forzenset for filtered methods
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/58796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/60533/2/README.logging
File README.logging:

PS2, Line 19: configuring
configure


PS2, Line 33: default
drop this


PS2, Line 50: vdsClient -s 0 setLogLevel WARNING storage
let's just fix the logging instead


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: add utlity to generate positive cpuset notation
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/60639/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 932: return dict
Line 933: return rget(dict.get(keys[0]), keys[1:], default)
Line 934: 
Line 935: 
Line 936: def cpuset(included_cpus):
> cpuinfo.py
Not terribly against this, but still suboptimal; isn't cpuinfo about parsing 
/proc/cpuinfo and present the content in a convenient way? adding those two 
functions feels like a stretch.
Line 937: """
Line 938: Create a "positive" cpuset notation. The cpuset notation is a 
string
Line 939: containing groups of ranges of numbers or numbers itself, 
describing
Line 940: which CPUs are included. The groups are separated by comma, 
ranges by dash.


-- 
To view, visit https://gerrit.ovirt.org/60639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba61cf59d17fed6b0d7a035f948885ce73c92bf1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: add utlity to generate positive cpuset notation
..


Patch Set 4: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/60639/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 932: return dict
Line 933: return rget(dict.get(keys[0]), keys[1:], default)
Line 934: 
Line 935: 
Line 936: def cpuset(included_cpus):
> We already have the inverse function taskset._cpulist_parse. It would be ni
Have them both in the sample place is a very good point; 

however, not sure which place it should be:
1. we are trying to put utils.py on a diet, so we should better go in the 
opposite direction (moving code out of it)
2. taskset.py is not the best place either, this new function will be unused 
there and not really belongs there

so perhaps the best approach is to add a new tiny module with _cpulist_parse 
(renamed correctly, let's not forget the tests!) and the one Martin is adding 
here.
Line 937: """
Line 938: Create a "positive" cpuset notation. The cpuset notation is a 
string
Line 939: containing groups of ranges of numbers or numbers itself, 
describing
Line 940: which CPUs are included. The groups are separated by comma, 
ranges by dash.


-- 
To view, visit https://gerrit.ovirt.org/60639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba61cf59d17fed6b0d7a035f948885ce73c92bf1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 2: Verified+1

we can't really break anything here.
"make rpm" still works as expected.

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60533/1/README.logging
File README.logging:

Line 36: 
Line 37: Examples of runtime tuning of logging
Line 38: -
Line 39: 
Line 40: WRITEME
> how about just "vdsClient -s 0 setLogLevel DEBUG"?:)
Fixed, added few more examples
Line 41: 
Line 42: Notes
Line 43: -
Line 44: 


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/60640/4/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS4, Line 526: nodeset=utils.cpuset(set([dev_object.numa_node for dev_object in
 :   devices if 
dev_object.numa_node])))
> Or only prefer a node if we have all devices from the same group.
Well, this is one thing Vdsm should not guess, not in the current architecture.
I think your second option sounfs better, but I'm using only my gut feeling. 
Any official recommendations/advice to follow?


-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: Use ovirt-4.0 repositories

[fromani]

Francesco Romani has posted comments on this change.

Change subject: automation: Use ovirt-4.0 repositories
..


Patch Set 1:

no changes to code whatsoever -> we can make one exception to the flow.

-- 
To view, visit https://gerrit.ovirt.org/61161
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44d766ad40d48afdc49df4e4f558eafa9561f812
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: Use ovirt-4.0 repositories

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: automation: Use ovirt-4.0 repositories
..


automation: Use ovirt-4.0 repositories

The master repositories do not provide the fc23 packages any more,
failing installation check for patches changing the build system.

Change-Id: I44d766ad40d48afdc49df4e4f558eafa9561f812
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/61161
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M automation/check-patch.repos.el7
M automation/check-patch.repos.fc23
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/61161
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44d766ad40d48afdc49df4e4f558eafa9561f812
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: automation: Use ovirt-4.0 repositories

[fromani]

Francesco Romani has posted comments on this change.

Change subject: automation: Use ovirt-4.0 repositories
..


Patch Set 1: Code-Review+2

thanks, I missed this and I was wondering what was broken :\

-- 
To view, visit https://gerrit.ovirt.org/61161
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44d766ad40d48afdc49df4e4f558eafa9561f812
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

[fromani]

Francesco Romani has posted comments on this change.

Change subject: WIP: vm: skip domDependentInit for containers
..


Patch Set 24:

(1 comment)

https://gerrit.ovirt.org/#/c/54179/24/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS24, Line 1834: _stubDependentInit
btw this was an exceptionally bad name :\


-- 
To view, visit https://gerrit.ovirt.org/54179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: add utlity to generate positive cpuset notation
..


Patch Set 3:

If you used a recipe, a link/reference/whatever to that recipe is an awesome 
first step to make reviewers (at least one of them :) ) happy!

-- 
To view, visit https://gerrit.ovirt.org/60639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba61cf59d17fed6b0d7a035f948885ce73c92bf1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder operations in _domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reorder operations in _domDependentInit
..


Patch Set 16:

rationale for this patch is to pave the road for 
https://gerrit.ovirt.org/#/c/53820
AND make the code a little nicer overall.
In this order :)

-- 
To view, visit https://gerrit.ovirt.org/59817
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7eb9897a35a554550a463ba562b28f5fe939352
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 16:

rationale for this patch is to pave the road for 
https://gerrit.ovirt.org/#/c/53820
AND make the code a little nicer overall.
In this order :)

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 16:

rationale for this patch is to pave the road for 
https://gerrit.ovirt.org/#/c/53820
AND make the code a little nicer overall.
In this order :)

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: virt: add optional container support

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vdsm: virt: add optional container support
..


Patch Set 39:

(1 comment)

https://gerrit.ovirt.org/#/c/53820/39/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1830: self.log.error("Failed to make a agent channel 
symlink "
Line 1831:"from %s -> %s for channel %s", 
path,
Line 1832:uuidPath, name)
Line 1833: 
Line 1834: def _domDependentInit(self):
alternative approach: dup this method, like I did in 
https://gerrit.ovirt.org/#/c/54179/24/vdsm/virt/vm.py
Line 1835: if self._destroy_requested.is_set():
Line 1836: # reaching here means that Vm.destroy() was called 
before we could
Line 1837: # handle it. We must handle it now
Line 1838: try:


-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 3: Code-Review-1

(1 comment)

only one minor style comment

https://gerrit.ovirt.org/#/c/60640/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS3, Line 1586:  if not domxml.appendNumaTune():
this is one of the few cases on which we should use a temporary.
We should really highlight that we do appendNumaTune(), and not """hide""" (yes 
I know "hide" is a too strong word here, but let's look at the concept :\) into 
a conditional.


-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: add appendNumaTune return value

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vmxml: add appendNumaTune return value
..


Patch Set 1: Code-Review+2

why not?

-- 
To view, visit https://gerrit.ovirt.org/61106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3bfbf7a17dc1396c45e0672b6f4a72199b4f800
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc.
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56107
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15b041ab89caa7b967d2a7e0a9d262274a5a3f90
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor formatting fix in vmdevices/storage.py

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Minor formatting fix in vmdevices/storage.py
..


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility, no really strong feelings here

https://gerrit.ovirt.org/#/c/61104/1/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 108: # the past (generally as soon as the VM is created) 
we should
Line 109: # verify that the cached path is the one used in 
libvirt.
Line 110: # We already hit few times the problem that after a 
live
Line 111: # migration the paths were not in sync anymore 
(BZ#1059482).
Line 112: if hasattr(d, 'alias') and d.alias == alias and \
probably out of habit, I think the old code reads better.
It was flake8 that complained about the old style?
I wonder if we should stick to certain versions of pep8/pyflakes and update 
once in a while.
Line 113:d.path != devPath:
Line 114: vm.log.warning('updating drive %s path from %s to 
%s',
Line 115:d.alias, d.path, devPath)
Line 116: d.path = devPath


-- 
To view, visit https://gerrit.ovirt.org/61104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fdd6ef28f4119e3fb02232c2f9c439294e26c65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use vmxml DOM helpers in storage devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Use vmxml DOM helpers in storage devices
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485b23748779e8161768f5a9a6607d72bffa1eef
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

[fromani]

Francesco Romani has posted comments on this change.

Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..


Patch Set 2: Code-Review+1

much nicer this way

-- 
To view, visit https://gerrit.ovirt.org/61153
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f852103dcd90e1350b406d8bd053976e5820a1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: osutils: Start the osutils module

[fromani]

Francesco Romani has posted comments on this change.

Change subject: osutils: Start the osutils module
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia995c083f31c3489ced16265d459f30355f854b0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: add utlity to generate positive cpuset notation
..


Patch Set 3: Code-Review-1

(1 comment)

-1 for visibility. The code is clever, but maybe too packed :\

https://gerrit.ovirt.org/#/c/60639/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:

PS3, Line 936: cpuset
this utility begs for one (or few :)) tests


-- 
To view, visit https://gerrit.ovirt.org/60639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba61cf59d17fed6b0d7a035f948885ce73c92bf1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: report device MMIO numa node

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: report device MMIO numa node
..


Patch Set 3: Code-Review+2

could also be useful for Engine's scheduler, so looks like a good change on its 
own.

-- 
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: expose numa_node in host device

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: expose numa_node in host device
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt net: Change graphics type from network to address
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61120
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmdevices: New method Base._update_device_attributes

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vmdevices: New method Base._update_device_attributes
..


Patch Set 2: Code-Review-1

(1 comment)

this method is a bit messy, but overall I think that confining all the mess in 
a single place is an improvement. So I like the concept, let's discuss a bit 
the details, -1 for visibility only.

https://gerrit.ovirt.org/#/c/60940/2/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

PS2, Line 64: tag, device_class,
I'd dare a bit more, because the 'tag' is always the value of the 
'device_class'. E.g.


VIDEO = 'video'
SOUND = 'sound'
CONTROLLER = 'controller'
BALLOON = 'balloon'
REDIR = 'redir'
RNG = 'rng'
WATCHDOG = 'watchdog'
CONSOLE = 'console'
SMARTCARD = 'smartcard'
TPM = 'tpm'
HOSTDEV = 'hostdev'
MEMORY = 'memory'

So: device_class could be replace by self.device or self.deviceType (I don't 
remember now, sorry), and we can use tag == device_class.

Problem: we are in a classmethod, so no luck with self.device* :)

to unblock this we could just move the right field as class method: each 
instance is supposed to have the same class, and not change after all.

Not sure how easy this will turn out given our (ab)use of __slots__, however.

What do you think?


-- 
To view, visit https://gerrit.ovirt.org/60940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a342d033ab2b705c25a3f99fadbf411e248cce3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:

Line 118: element = None
Line 119: text = vmxml.dom_text(element)
Line 120: self.assertIsInstance(text, result.__class__)
Line 121: self.assertEqual(text, result)
Line 122: 
> I'm definitely going to check test coverage of all the new and modified cod
Fine for me.
Line 123: 
Line 124: @expandPermutations
Line 125: class TestDomainDescriptor(VmXmlTestCase):
Line 126: 


https://gerrit.ovirt.org/#/c/55769/7/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS7, Line 37: xml_to_dom
> It would be nice but it would require using wrapped elements and using the 
Agreed: let's start with the functions, and let's do the switch to etree. This 
is the big goal after all :) Once this is done, we could discuss if we need 
wrapper object or not.


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use DOM helpers in Vm.setLinkAndNetwork

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Use DOM helpers in Vm.setLinkAndNetwork
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58190
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idba2262b106c6ceb136eeb95defcf07280699ed6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Return first child from vmxml.xml_to_dom

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Return first child from vmxml.xml_to_dom
..


Patch Set 6: Code-Review+1

good enough for now.

-- 
To view, visit https://gerrit.ovirt.org/58194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4c92c32e8fa88836d9434a3917b758feead277
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Switch to etree in vmxml.py

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Switch to etree in vmxml.py
..


Patch Set 6: Code-Review+1

my previous comment was addressed partially. I'm fine to have it as proof of 
concept and complete the changes once consensus is reached, so here it comes my 
partial ACK

-- 
To view, visit https://gerrit.ovirt.org/58196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c6d3d6e6bf5ae012f2e0ee4363f742a8cfcdcce
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use DOM helpers in Vm disk device handling

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Use DOM helpers in Vm disk device handling
..


Patch Set 7: Code-Review+1

thanks, for the updates, looks better now

-- 
To view, visit https://gerrit.ovirt.org/56108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I165819d5bfaaccc76296f58e7f59d18ad4240fc1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Introduce MutableDomainDescriptor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Introduce MutableDomainDescriptor
..


Patch Set 1: Code-Review+1

I tend to like it, still not sure this is the best approach (perhaps changing 
the surrounding code yields overall better result), but let's try this way 
first.

-- 
To view, visit https://gerrit.ovirt.org/61105
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e54129472da12f49d72ae96eadf3c7c09c55148
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use DOM helpers in vmxml.device_address

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Use DOM helpers in vmxml.device_address
..


Patch Set 7:

Milan answered to this comment in a previous patch, I'm fine with his plan.

-- 
To view, visit https://gerrit.ovirt.org/56104
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409b2b290df5ee52418addd008325294594b5283
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Send vm info report each sampling interval from VMBulkSampler
..


Patch Set 5:

Here is a *proof of concept* of the periodic uploader, the alternative approach 
I mentioned in the review.
https://gerrit.ovirt.org/#/c/61107/

-- 
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: oop: Explicitly close running ioprocesses

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: oop: Explicitly close running ioprocesses
..


oop: Explicitly close running ioprocesses

IOProcess client is using __del__ for automatic closing when the last
reference to the client disappears. This attempt fail consistency when
__del__ is called during shutdown, since Python is partly tore down.

In the worst cases, the entire application will get stuck during
shutdown. We see this randomly when running the tests in the CI.
Looking in backtraces, all the threads are blocked trying to acquire a
lock that may have been already destroyed.

This patch avoid this issue by explicitly closing all running
ioprocesses during application shutdown and when cleaning up after
storage tests. This ensure that IOProcess's close() and __del__() are
running in a well defined environment.

Change-Id: Id9fce2bcc8a7916dd9e31a8b23a4199611c7938f
Bug-Url: https://bugzilla.redhat.com/1334274
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/60830
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/61050
---
M tests/storagetestlib.py
M vdsm/storage/hsm.py
M vdsm/storage/outOfProcess.py
3 files changed, 28 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/61050
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9fce2bcc8a7916dd9e31a8b23a4199611c7938f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org