Re: [ath5k-devel] Rookie needs helps with ath5k basics

2014-11-07 Thread Bruno Randolf
Hi, I don't remember all the details but there are various places which can limit the available channels in ath5k. Check ath5k_is_standard_channel() ath5k_setup_channels() ath5k_setup_bands() in drivers/net/wireless/ath/ath5k/base.c Good luck! bruno On 11/07/2014 02:27 PM, Sergey Ryazanov wro

Re: [ath5k-devel] [RFT] A few calibration tests...

2011-02-06 Thread Bruno Randolf
On Tuesday 01 February 2011 14:36:40 Nick Kossifidis wrote: > Hello all ;-) Hi Nick! > It seems that NF calibration doesn't interfere with traffic, it just > takes time to complete because it waits for the medium to be free (it > measures on inter-frame time), I read the patent doc again and it

Re: [ath5k-devel] [PATCH] ath5k: Fix short and long retry configuration

2011-02-02 Thread Bruno Randolf
On Wednesday 02 February 2011 11:52:54 Bob Copeland wrote: > On Wed, Feb 02, 2011 at 09:06:40AM +0100, Sedat Dilek wrote: > > As I saw your patch in linux-next/wireless-next-2.6, I wanted to ask > > what's up with Bob's > > "mac80211-minstrel-honor-max-retry-counts-from-cfg80211.patch" (see > > [1]

[ath5k-devel] [PATCH] ath5k: Fix short and long retry configuration

2011-01-27 Thread Bruno Randolf
tru ah_retry_long/short. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h| 18 -- drivers/net/wireless/ath/ath5k/attach.c |4 +- drivers/net/wireless/ath/ath5k/base.c |3 +- drivers/net/wireless/ath/ath5k/mac80211-ops.c |9 + dr

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-27 Thread Bruno Randolf
On Thu January 27 2011 14:51:05 Vasanthakumar Thiagarajan wrote: > On Wed, Jan 26, 2011 at 04:06:02PM +0530, Bruno Randolf wrote: > > On Wed January 26 2011 18:37:00 Jouni Malinen wrote: > > > On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > > > > E

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Bruno Randolf
On Wed January 26 2011 18:37:00 Jouni Malinen wrote: > On Wed, Jan 26, 2011 at 11:38:53AM +0900, Bruno Randolf wrote: > > Even without my patch, WEP does not work with multiple vifs. > > Are you sure about that? Yes, I'm sure. Please test it yourself, if you don't belie

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-26 Thread Bruno Randolf
On Wed January 26 2011 17:29:48 Johannes Berg wrote: > On Wed, 2011-01-26 at 11:38 +0900, Bruno Randolf wrote: > > Even without my patch, WEP does not work with multiple vifs. > > (As far as i understand it, with WEP the lookup is just done based on the > > key index in

Re: [ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-25 Thread Bruno Randolf
On Wed January 26 2011 03:32:05 Jouni Malinen wrote: > On Tue, Jan 25, 2011 at 01:15:49PM +0900, Bruno Randolf wrote: > > In AP mode hardware encryption for WEP was not used on the RX side > > because there was a mismatch in the key indices. The key index in the > > WLAN he

[ath5k-devel] [PATCH 6/6] ath: Fix WEP hardware encryption

2011-01-24 Thread Bruno Randolf
rved for that. Tested with ath5k on a 600MHz mips board the difference is ~15% CPU load (with this patch) vs. ~45% CPU load (before) when the AP receives 28Mbps of WEP encrypted data. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/key.c | 14 +++--- 1 files changed, 11 ins

[ath5k-devel] [PATCH 5/6] ath9k: Remove unused IEEE80211_WEP_NKID

2011-01-24 Thread Bruno Randolf
IEEE80211_WEP_NKID is not used in ath9k any more since the key handling code has been moved to ath/. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath9k/ath9k.h |1 - drivers/net/wireless/ath/ath9k/common.h |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git

[ath5k-devel] [PATCH 4/6] ath5k: Enable 802.11j 4.9GHz frequencies

2011-01-24 Thread Bruno Randolf
This enables 4.9GHz frequencies in ath5k if they are allowed as indicated by the regulatory domain code. Currently this is MKK9_MKKC (0xfe). Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/caps.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a

[ath5k-devel] [PATCH 3/6] ath: Add function to check if 4.9GHz channels are allowed

2011-01-24 Thread Bruno Randolf
o indicate 4.9GHz channels support and that there might be other domain codes as well, but as I don't have any documentation I'm just putting in what I need right now. It can be extended later. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/regd.c |7 +++ drivers/net/wirele

[ath5k-devel] [PATCH 2/6] ath5k: Use local variable for capabilities

2011-01-24 Thread Bruno Randolf
Shorten some lines and make code more readable. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/caps.c | 39 +++-- 1 files changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/caps.c b/drivers/net/wireless/ath

[ath5k-devel] [PATCH 1/6] ath5k: ath5k_setup_channels cleanup and whitespace

2011-01-24 Thread Bruno Randolf
Remove useless test_bit - it's not going to happen because of the way this function is called only when that bit is set. And fix some whitespace. Signed-off-by: Bruno Randolf Acked-by: Bob Copeland Acked-by: Nick Kossifidis --- Has this been lost from my last series? --- driver

Re: [ath5k-devel] [PATCH/RFC] ath5k: use tracing for packet tx/rx dump

2011-01-23 Thread Bruno Randolf
On Sun January 23 2011 08:13:50 Bob Copeland wrote: > This adds a few tracepoints to ath5k driver transmit and > receive callbacks in order to record packet traffic. > We record the entire packet in the trace buffer so that > the data can be extracted with trace-cmd and external > plugins. > > Thi

Re: [ath5k-devel] [PATCH] RFC: ath: Fix WEP hardware encryption

2011-01-21 Thread Bruno Randolf
On Saturday 22 January 2011 00:10:23 Vasanthakumar Thiagarajan wrote: > On Fri, Jan 21, 2011 at 03:46:08PM +0530, Bruno Randolf wrote: > > I need this to enable HW encryption for WEP. > > Otherwise we fall back to software decryption - i only checked the > > decryption

[ath5k-devel] [PATCH] RFC: ath: Fix WEP hardware encryption

2011-01-21 Thread Bruno Randolf
I need this to enable HW encryption for WEP. Otherwise we fall back to software decryption - i only checked the decryption case. Any comments? bruno --- drivers/net/wireless/ath/key.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/

[ath5k-devel] [PATCH v3] ath5k: Simplify loop when setting up channels

2011-01-20 Thread Bruno Randolf
Simplify confusing code and get rid of an unnecessary variable. Signed-off-by: Bruno Randolf --- v3: Bob pointed out another wrong check: count <= max. The loop really was confusing _me_... --- drivers/net/wireless/ath/ath5k/base.c |7 +++ 1 files changed, 3 inserti

Re: [ath5k-devel] [PATCH 1/8] ath5k: Use mac80211 channel mapping function

2011-01-19 Thread Bruno Randolf
On Wed January 19 2011 20:48:28 Bruno Randolf wrote: > > I like this, but we can also change ath5k_channel_ok and get rid of > > chfreq completely, no? And then maybe the CHANNEL_ defines. > > True. Could be done and would be a nice cleanup too. We have too many > redunda

Re: [ath5k-devel] multiple access points broke on nl80211

2011-01-19 Thread Bruno Randolf
On Wed January 19 2011 23:15:11 Cory Coager wrote: > On Tue, Jan 18, 2011 at 07:04:26PM -0800, Ben Greear wrote: > > Worked fine last I tried. I'm not sure the ath5k virtualization stuff > > got into stock 2.6.36, by the way. It *should* be in .37. > > > > Thanks, > > Ben > > Anymore suggestion

Re: [ath5k-devel] [PATCH 1/8] ath5k: Use mac80211 channel mapping function

2011-01-19 Thread Bruno Randolf
On Wed January 19 2011 20:03:38 you wrote: > On Wed, Jan 19, 2011 at 3:54 AM, Bruno Randolf wrote: > > Use mac80211 channel mapping function instead of own homegrown version. > > > > Signed-off-by: Bruno Randolf > > --- > > > > @@ -274,6 +262,7 @@

[ath5k-devel] [PATCH] RFC: ath5k: Enable 802.11j 4.9GHz frequencies

2011-01-19 Thread Bruno Randolf
RFC: This enables 4.9GHz frequencies in ath5k if the regdomain is set to MKK9_MKKC (0xfe). I have added a helper function to common ath/regd.c since we know about MKK9_MKKC there, however in the place where i'm using the function we don't have an ath_regulatory structure yet, so i'm passing the r

[ath5k-devel] [PATCH 8/8] ath5k: Remove redundant sc->curband

2011-01-19 Thread Bruno Randolf
Remove sc->curband because the band is already stored in the current channel. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 11 --- drivers/net/wireless/ath/ath5k/base.h |2 -- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/

[ath5k-devel] [PATCH 7/8] ath5k: Remove unused sc->curmode

2011-01-19 Thread Bruno Randolf
sc->curmode is set but never used. Remove it and the helper function. Also the ath5k_rate_update which is refered to in the comment does not exist (any more?) so we don't need to setup the band in that place. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.

[ath5k-devel] [PATCH 6/8] ath5: Remove unused CTL definitions

2011-01-19 Thread Bruno Randolf
They are unused in ath5k and a more detailled definition is in ath/regd_common.h. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/eeprom.h | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/eeprom.h b

[ath5k-devel] [PATCH 5/8] ath5k: Add 802.11j 4.9GHz channels to allowed channels

2011-01-19 Thread Bruno Randolf
Add the 802.11j (20MHz channel width) channels to the allowed channels. This still does not enable 802.11j in ath5k since these frequencies are out of the configured range. A later patch will deal with that. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 19

[ath5k-devel] [PATCH 4/8] ath5k: ath5k_setup_channels cleanup and whitespace

2011-01-19 Thread Bruno Randolf
Remove useless test_bit - it's not going to happen because of the way this function is called only when that bit is set. And fix some whitespace. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-)

[ath5k-devel] [PATCH 3/8] ath5k: Rename ath5k_copy_channels

2011-01-19 Thread Bruno Randolf
Rename ath5k_copy_channels() to ath5k_setup_channels() - nothing is copied here. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless

[ath5k-devel] [PATCH 2/8] ath5k: Simplify loop when setting up channels

2011-01-19 Thread Bruno Randolf
Simplify confusing code and get rid of an unnecessary variable. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c

[ath5k-devel] [PATCH 1/8] ath5k: Use mac80211 channel mapping function

2011-01-19 Thread Bruno Randolf
Use mac80211 channel mapping function instead of own homegrown version. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 23 --- 1 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net

[ath5k-devel] [PATCH 0/8] ath5k 802.11j preparation and cleanup

2011-01-19 Thread Bruno Randolf
This series prepares ath5k for 802.11j (4.9GHz) support but most of the patches are just cleaning up things i found in the process. 802.11j is still not enabled. bruno --- Bruno Randolf (8): ath5k: Use mac80211 channel mapping function ath5k: Simplify loop when setting up channels

Re: [ath5k-devel] multiple access points broke on nl80211

2011-01-18 Thread Bruno Randolf
On Wed January 19 2011 11:48:37 Cory Coager wrote: > On 01/18/2011 09:37 PM, Bruno Randolf wrote: > > Up to 4 AP are supported. Please check if you have a compat-wireless > > version or kernel version later than 2010-10-05. Yes the interface is > > nl80211 now. > > Tha

Re: [ath5k-devel] multiple access points broke on nl80211

2011-01-18 Thread Bruno Randolf
On Wed January 19 2011 11:21:45 Cory Coager wrote: > I have been using hostapd to run multiple access points with madwifi. > Recently I upgraded my kernel and it looks like the driver uses nl80211 > now. I am no longer able to run multiple access points with ath5k. > What is the current status of

Re: [ath5k-devel] [PATCH] ath5k: fix locking in tx_complete_poll_work

2011-01-18 Thread Bruno Randolf
ieee80211_queue_delayed_work(sc->hw, &sc->tx_complete_work, > msecs_to_jiffies(ATH5K_TX_COMPLETE_POLL_INT)); > } Acked-by: Bruno Randolf ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Re: [ath5k-devel] gain calibration timeout error

2011-01-16 Thread Bruno Randolf
On Mon January 17 2011 11:31:08 Nick Kossifidis wrote: > 2011/1/17 Bruno Randolf : > > On Fri January 14 2011 21:16:31 Jussi Haakana wrote: > >> On 13.1.2011 18:13, Neo Tida wrote: > >> > Hi, > >> > I have 2 problems. at first some times ath5k starts

Re: [ath5k-devel] gain calibration timeout error

2011-01-16 Thread Bruno Randolf
On Fri January 14 2011 21:16:31 Jussi Haakana wrote: > On 13.1.2011 18:13, Neo Tida wrote: > > Hi, > > I have 2 problems. at first some times ath5k starts to show this error > > continually with different freqs in parentheses and connection will be > > lost: > > ath5k phy0: gain calibration timeout

Re: [ath5k-devel] [PATCH 1/6] ath5k: Always write tx powertable on hw

2011-01-01 Thread Bruno Randolf
On Thursday 30 December 2010 06:02:29 Bob Copeland wrote: > On Thu, Dec 2, 2010 at 11:03 PM, Nick Kossifidis wrote: > > * By skipping tx power table calibration we also skip setting > > tx power table on hw. Make sure we always write tx power table > > on hw since it gets cleared on reset. > >

Re: [ath5k-devel] [PATCH] ath5k: fix cycle counter inconsistent locking

2010-12-26 Thread Bruno Randolf
*/ > memset(&sc->survey, 0, sizeof(sc->survey)); > - spin_lock(&common->cc_lock); > + spin_lock_bh(&common->cc_lock); > ath_hw_cycle_counters_update(common); > memset(&common->cc_survey, 0, sizeof(common->cc_survey)); > memset(&common->cc_ani, 0, sizeof(common->cc_ani)); > - spin_unlock(&common->cc_lock); > + spin_unlock_bh(&common->cc_lock); > > /* >* Change channels and update the h/w rate map if we're switching; Acked-by: Bruno Randolf ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel

[ath5k-devel] [PATCH] ath5k: Move mac80211 functions into new file

2010-12-22 Thread Bruno Randolf
Move mac80211 functions into new file mac80211-ops.c to have a better separation and to make base.c smaller. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/Makefile |1 drivers/net/wireless/ath/ath5k/base.c | 763 ++--- drivers/net

[ath5k-devel] [PATCH 5/5] ath5k: Use helper function to get eeprom mode from channel

2010-12-21 Thread Bruno Randolf
Introduce a helper function to get the EEPROM mode from channel and remove multiple similar switch statements. Also since it's now easy to get the EEPROM mode from the channel, use them inside the functions which need it, instead of passing a redundant ee_mode parameter. Signed-off-by:

[ath5k-devel] [PATCH 4/5] ath5k: Remove ATH5K_INI_RFGAIN defines, use band instead

2010-12-21 Thread Bruno Randolf
Remove redundant defines. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |6 +- drivers/net/wireless/ath/ath5k/phy.c | 18 ++ drivers/net/wireless/ath/ath5k/reset.c | 11 +++ 3 files changed, 10 insertions(+), 25 deletions(-) diff

[ath5k-devel] [PATCH 3/5] ath5k: Track current TX power separately from max TX power

2010-12-21 Thread Bruno Randolf
power is not yet set. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 + drivers/net/wireless/ath/ath5k/phy.c |7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ath5k.h b/drivers/net/wireless/ath/ath5k

[ath5k-devel] [PATCH 2/5] ath5k: Separate powertable setup and writing

2010-12-21 Thread Bruno Randolf
And rename functions which write the powertable to make it clearer. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/phy.c | 34 -- 1 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers

[ath5k-devel] [PATCH 1/5] ath5k: Simplify powertable recalculation

2010-12-21 Thread Bruno Randolf
Let ath5k_hw_txpower() decide if it can re-use the powertable or if it has to be recalculated instead of passing a 'fast' flag from the outside. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 + drivers/net/wireless/ath/ath5k/phy.

Re: [ath5k-devel] [PATCH 2/2] ath5k: Add channel time to survey data

2010-12-15 Thread Bruno Randolf
m today - I verified it works now. bruno > -- > Jonathan Guerin > > On Tue, Oct 19, 2010 at 5:56 PM, Bruno Randolf wrote: > > Include the channel utilization (busy, rx, tx) in the survey results. > > > > Signed-off-by: Bruno Randolf > > --- > > driver

[ath5k-devel] [PATCH] ath5k: Fix survey

2010-12-15 Thread Bruno Randolf
ey is retrieved. If survey is retrieved often enough to avoid cycle counter overflows this works fine, otherwise we could update survey more often, like ath9k does. Still only the survey for the current channel is kept. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |

Re: [ath5k-devel] ath5k: IBSS Join Fail

2010-12-12 Thread Bruno Randolf
On Thu December 9 2010 11:36:17 Jonathan Guerin wrote: > Hi, > > I'm currently running 2 Linux nodes. One is running kernel version > 2.6.37-rc2, the other -rc5. I'm finding that the rc5 node refuses to > join the IBSS, and simply ignores any probe requests from other > stations. The card is worki

Re: [ath5k-devel] In response to Hardware encryption on AR5413 broken?

2010-12-12 Thread Bruno Randolf
On Thu December 9 2010 19:48:44 Jeroen Avonts wrote: > Hardware encryption works with following patch: Is that to say HW encryption does NOT work without this patch? bruno > commit dacc09a722cc0064b299b59deca1806d93d661db > Author: Bruno Randolf > Date: Tue Oct 19 12:22:5

Re: [ath5k-devel] [PATCH RFC] ath5k: Clean up retry limit configuration

2010-12-08 Thread Bruno Randolf
On Wed December 8 2010 18:05:33 Nick Kossifidis wrote: > 2010/12/8 Bruno Randolf : > > ath5k should take the retry limit (short and long) configuration from > > mac80211 instead of relyinng on some dubious initial values. > > > > More importantly, the register definit

Re: [ath5k-devel] ath5k low speed with ar5414 based cards

2010-12-08 Thread Bruno Randolf
s. How can you receive faster than you can send something? ;) > Now with ath5k and your patch, receive speed is about > 27Mbps and send speed is about 30Mbps. > Is there any other trick to make it better? None that i know of. bruno > > > ________

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-08 Thread Bruno Randolf
> > When ath5k doesn't get retry limits from above it uses the following > > defaults on dcu. > > For now i don't think we use local->hw.conf.short_frame_max_tx_count > > for that so the > > default is ah_limit_tx_retries (AR5K_INIT_TX_RETRY) but seems it's > > wrong and we should > > fix it... > >

[ath5k-devel] [PATCH RFC] ath5k: Clean up retry limit configuration

2010-12-08 Thread Bruno Randolf
documentation and clean up the code. Signed-off-by: Bruno Randolf --- Notes: This does not fix the problems, Jonathan Guerin reported, but cleans up the ath5k part which is involved. Anyone knows what's the matter with retry limits vs. STA retry limits? What's the difference? --- d

Re: [ath5k-devel] [PATCH] ath5k: Use capabilities information for the number of TX queues

2010-12-07 Thread Bruno Randolf
On Tue December 7 2010 23:01:21 John W. Linville wrote: > On Tue, Dec 07, 2010 at 11:08:12AM +0900, Bruno Randolf wrote: > > One thing I missed in my WME series: Older hardware does not have enough > > hardware queues to support WME. In this case we just set up one data >

Re: [ath5k-devel] ath5k low speed with ar5414 based cards

2010-12-07 Thread Bruno Randolf
Oh - just remembering: there is a patch in OpenWRT, which limits DMA bust sizes to work around a HW problem, but it's too conservative. I have sent a patch to them but they didn't apply it. That's the change you have to make: commit dacc09a722cc0064b299b59deca1806d93d661db Author:

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-06 Thread Bruno Randolf
On Tue December 7 2010 10:12:18 Jonathan Guerin wrote: > > Another thing that strikes me here is: why use multi rate retries if the > > rate is all the same? (Ignore the actual value of the rate, this is the > > HW rate code). > > > > Other examples: > > > > *** txdesc tries 2 > > *** mrr 0 tries

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-06 Thread Bruno Randolf
On Mon December 6 2010 19:53:49 Sedat Dilek wrote: > >> But it seems weird that there are so many retransmissions. The default > >> maximum numbers of retransmissions should be 7 for short frames and 4 > >> for long frames (dot11[Short|Long]RetryLimit), and this is what is set > >> as defaults in m

[ath5k-devel] [PATCH] ath5k: Use capabilities information for the number of TX queues

2010-12-06 Thread Bruno Randolf
One thing I missed in my WME series: Older hardware does not have enough hardware queues to support WME. In this case we just set up one data queue. Use the capability information to decide how many queues to set up. Signed-off-by: Bruno Randolf -- resend, seems like it got lost somewhere in a

Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

2010-12-06 Thread Bruno Randolf
On Mon December 6 2010 15:30:00 Jonathan Guerin wrote: > Hi, > > > I've been doing some investigation into the behaviour of contention > windows and retransmissions. > > Firstly, I'll just describe the test scenario and setup that I have. I > have 3 Via x86 nodes with Atheros AR5001X+ cards. The

Re: [ath5k-devel] ath5k becomes unusable after xx mins of idle

2010-12-05 Thread Bruno Randolf
On Mon December 6 2010 16:22:49 Mark Williams wrote: > Please, anyone?? > If im asking in the wrong place, can you advise me as to where i > should be asking? This is the right place for ath5k related things, but since you are running a custom emdebian kernel nobody here knows what's going on wit

[ath5k-devel] [PATCH] ath5k: Use capabilities information for the number of TX queues

2010-12-02 Thread Bruno Randolf
One thing I missed in my WME series: Older hardware does not have enough hardware queues to support WME. In this case we just set up one data queue. Use the capability information to decide how many queues to set up. Signed-off-by: Bruno Randolf -- resend, seems like it got lost somewhere in a

Re: [ath5k-devel] [PATCH 12/30] ath5k: Increase PHY settling parameters for turo mode

2010-11-23 Thread Bruno Randolf
On Wed November 24 2010 05:11:57 Nick Kossifidis wrote: > 2010/11/23 Luis R. Rodriguez : > > On Tue, Nov 23, 2010 at 11:04:43AM -0800, Nick Kossifidis wrote: > > > > Are you willing to deal with *all* bug reports for this? > > > > Luis > > I don't enable 5/10/40MHz operation anywhere for now, i

Re: [ath5k-devel] Hardware encryption on AR5413 broken?

2010-11-17 Thread Bruno Randolf
On Wed November 17 2010 18:28:36 Stefan Nickl wrote: > > > I used CCMP/AES with PSK and several different APs. > > > > Ok. I did the same (only one ath5k AP, though...). > > Umh, could you try a non-ath5k AP to be sure it's not a symmetric thing? Sorry, I can't. > > Can you check if WPA1 (TKIP

Re: [ath5k-devel] Hardware encryption on AR5413 broken?

2010-11-16 Thread Bruno Randolf
On Tue November 16 2010 18:30:02 Stefan Nickl wrote: > > 1.) What is your chipset revision (check in dmesg)? Mine is: > > ath5k phy1: Atheros AR5414 chip found (MAC: 0xa5, PHY: 0x61). AR5413 and > > AR5414 should be very similar, AFAIK. > > Interestingly, I have the same chipset as you when lookin

Re: [ath5k-devel] Hardware encryption on AR5413 broken?

2010-11-15 Thread Bruno Randolf
On Wed November 10 2010 18:26:16 Stefan Nickl wrote: > Hello list, > > I'm experiencing encryption problems that may be related to this bug > report (although the report is about AR2413): > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568090 > > The crypto handshake appears to complete ju

[ath5k-devel] [PATCH] ath5k: Use capabilities information for the number of TX queues

2010-11-15 Thread Bruno Randolf
One thing I missed in my WME series: Older hardware does not have enough hardware queues to support WME. In this case we just set up one data queue. Use the capability information to decide how many queues to set up. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 65

[ath5k-devel] [PATCH] ath5k: Use capabilities information for the number of TX queues

2010-11-10 Thread Bruno Randolf
One thing I missed in my WME series: Older hardware does not have enough hardware queues to support WME. In this case we just set up one data queue. Use the capability information to decide how many queues to set up. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 65

Re: [ath5k-devel] [PATCH] ath5k: Cleanup opmode setting logic.

2010-11-10 Thread Bruno Randolf
ode = NL80211_IFTYPE_STATION; > > - ath_do_set_opmode(sc); > + ath5k_hw_set_opmode(sc->ah, sc->opmode); > + ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "mode setup opmode %d (%s)\n", > + sc->opmode, ath_opmode_to_string(sc->opmode)); > >

Re: [ath5k-devel] Access Channel Utilization

2010-10-25 Thread Bruno Randolf
On Tue October 26 2010 15:24:42 Jonathan Guerin wrote: > Hi, > > I'm trying to access the phy-layer stats that were recently added to > cfg80211 and nl80211. I'm using a modified version of iw as per this > patch: > https://dev.openwrt.org/browser/trunk/package/iw/patches/110-survey_phy_sta > ts.p

[ath5k-devel] ath5k negative RSSI?

2010-10-21 Thread Bruno Randolf
Hello! I'm looking at the RSSI values provided by the hardware in the RX descriptor (rs_rssi) in ath5k. Sometimes the RSSI value is negative (-1, -2, -3) or zero (0), which logically does not make sense. madwifi and ath9k work around negative values by setting them to zero. Is this a known hard

[ath5k-devel] [PATCH 2/2] ath5k: Add channel time to survey data

2010-10-19 Thread Bruno Randolf
Include the channel utilization (busy, rx, tx) in the survey results. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless

[ath5k-devel] [PATCH 1/2] ath5k: Optimize descriptor alignment

2010-10-19 Thread Bruno Randolf
Similar to Felix Fietkau "ath9k_hw: optimize all descriptor access functions" (13db2a80244908833502189a24de82a856668b8a). Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/desc.h | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/d

Re: [ath5k-devel] [PATCH] ath5k: Properly initialize ath_common->cc_lock.

2010-10-17 Thread Bruno Randolf
th5k_pci_probe(struct pci_dev *pdev, > common->ah = sc->ah; > common->hw = hw; > common->cachelsz = csz << 2; /* convert to bytes */ > + spin_lock_init(&common->cc_lock); > > /* Initialize device */ > ret = ath5k_hw_attach(sc)

Re: [ath5k-devel] How to profile this strange effect under high load?

2010-10-14 Thread Bruno Randolf
On Wed October 13 2010 02:14:19 Qasim Javed wrote: > How about using trace-cmd and kernelshark with function graph tracer > to see what is getting called so often? > > -Qasim > > On Tue, Oct 12, 2010 at 5:33 AM, Bruno Randolf wrote: > > Hello! > > > > I am

Re: [ath5k-devel] Fwd: [PATCH v2] ath5k: Move debugfs under ieee80211/[wiphy-name]

2010-10-12 Thread Bruno Randolf
+138,9 @@ enum ath5k_debug_level { > } while (0) > > void > -ath5k_debug_init(void); > - > -void > ath5k_debug_init_device(struct ath5k_softc *sc); > > void > -ath5k_debug_finish(void); > - > -void > ath5k_debug_finish_device(struct ath5k_softc *sc)

[ath5k-devel] How to profile this strange effect under high load?

2010-10-12 Thread Bruno Randolf
Hello! I am trying to debug a strange effect, I am seeing on soekris net48xx boards with two ath5k interfaces: * wlan0 [phy0] configured in ad-hoc mode, A band, and it is getting a lot of traffic routed thru it * wlan1 [phy1] also configured in ad-hoc mode, G band, but not actively sending (

Re: [ath5k-devel] bug asking

2010-10-11 Thread Bruno Randolf
On Tue October 12 2010 12:30:24 wangyaotwins wrote: > Mr: > Hello! I operatate as you show "make > KLIB=/home/mcgrof/kernels/linux-2.6.27.22 \ > KLIB_BUILD=/home/mcgrof/kernels/linux-2.6.27.22",but it result that"No > rule to make target `missing-syscalls' ". Could you help me deal with the > pro

Re: [ath5k-devel] Race condition in CRDA calls?

2010-10-08 Thread Bruno Randolf
hello! sorry to revive an old thread, but i finally found the time to continue on this. i can reproduce the regdomain intersection problem fairly regularly now. it happens on slow boards (soekris net4826), with more than one ath5k card, especially under high load. unfortunately this seems to be

Re: [ath5k-devel] Kernel panic

2010-10-07 Thread Bruno Randolf
On Fri October 8 2010 13:05:51 Ben Greear wrote: > On 10/07/2010 08:12 PM, Jonathan Guerin wrote: > > On Thu, Oct 7, 2010 at 4:22 PM, Bruno Randolf wrote: > >> On Thu October 7 2010 14:41:18 Jonathan Guerin wrote: > >>>> I seem to be getting a kernel pan

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-07 Thread Bruno Randolf
On Thu October 7 2010 15:51:49 Helmut Schaa wrote: > On Thu, Oct 7, 2010 at 3:03 AM, Bruno Randolf wrote: > > On Wed October 6 2010 18:54:37 Helmut Schaa wrote: > >> On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: > >> > This adds three ne

Re: [ath5k-devel] Kernel panic

2010-10-06 Thread Bruno Randolf
On Thu October 7 2010 14:41:18 Jonathan Guerin wrote: > > I seem to be getting a kernel panic when creating an IBSS with the > > latest ath5k driver. I remember Bruno submitting patches recently > > which modifies the behaviour of timestamps in ath5k, so I was > > wondering if this was related. di

Re: [ath5k-devel] adhoc mode atheros communication ar5413 802.11abg

2010-10-06 Thread Bruno Randolf
On Wed October 6 2010 21:06:07 yassine antir wrote: > i habe tried iw but it doesn't work too: > > 1) first i have used iw > 0.9.4-nogit there is many options not supported so i could not find out > how to set the adhoc mode so i upgraded to new version 0.9.21 i am using ad-hoc mode every day wit

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-06 Thread Bruno Randolf
On Wed October 6 2010 18:54:37 Helmut Schaa wrote: > On Tue, Oct 5, 2010 at 11:55 AM, Bruno Randolf wrote: > > This adds three new values to the survey results: > > > > * BUSY - percentage of time the channel was busy > > * BUSY_TX - percentage of time spent transmi

Re: [ath5k-devel] [PATCH 5/5] ath5k: Add busy ratios to survey data

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 11:45:46 Felix Fietkau wrote: > On 2010-10-06 4:25 AM, Bruno Randolf wrote: > > On Wed October 6 2010 07:38:34 Luis R. Rodriguez wrote: > >> This is all being sucked out of common, so can we just share the > >> filler for the survey between ath5

Re: [ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 07:36:30 Luis R. Rodriguez wrote: > On Tue, Oct 5, 2010 at 2:55 AM, Bruno Randolf wrote: > > This adds three new values to the survey results: > > > > * BUSY - percentage of time the channel was busy > > * BUSY_TX - percentage of tim

Re: [ath5k-devel] [PATCH 5/5] ath5k: Add busy ratios to survey data

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 07:38:34 Luis R. Rodriguez wrote: > On Tue, Oct 5, 2010 at 2:55 AM, Bruno Randolf wrote: > > Include the channel utilization (busy, rx, tx) in the survey results. > > > > Signed-off-by: Bruno Randolf > > --- > > drivers/net

Re: [ath5k-devel] [PATCH 3/5] ath9k: Use common cycle counters

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 10:18:07 Luis R. Rodriguez wrote: > On Tue, Oct 5, 2010 at 2:55 AM, Bruno Randolf wrote: > > Update ath9k to use the common cycle counters. > > > > This also includes other changes from Felix Fietkaus "[PATCH 2/4] > > ath9k_hw: merge codepat

Re: [ath5k-devel] [PATCH 3/5] ath9k: Use common cycle counters

2010-10-05 Thread Bruno Randolf
On Wed October 6 2010 05:14:07 Luis R. Rodriguez wrote: > On Tue, Oct 05, 2010 at 02:55:21AM -0700, Bruno Randolf wrote: > > Update ath9k to use the common cycle counters. > > > > This also includes other changes from Felix Fietkaus "[PATCH 2/4] > > ath9k_hw: merge

[ath5k-devel] [PATCH 5/5] ath5k: Add busy ratios to survey data

2010-10-05 Thread Bruno Randolf
Include the channel utilization (busy, rx, tx) in the survey results. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless

[ath5k-devel] [PATCH 4/5] nl80211/mac80211: Add channel utilization to survey

2010-10-05 Thread Bruno Randolf
match the Channel Utilization of the BSS Load IE of 802.11-2007, chapter 7.3.2.28, in case we want to use that later. I admit that these three values are ath[59]k centric - it's what is available there, and i don't know if other chipsets have similar information. Signed-off-by: Bru

[ath5k-devel] [PATCH 3/5] ath9k: Use common cycle counters

2010-10-05 Thread Bruno Randolf
Update ath9k to use the common cycle counters. This also includes other changes from Felix Fietkaus "[PATCH 2/4] ath9k_hw: merge codepaths that access the cycle counter registers". Compile tested only. ath9k team please review... Signed-off-by: Felix Fietkau Signed-off-by: Bru

[ath5k-devel] [PATCH 2/5] ath5k: Use common cycle counters for ANI

2010-10-05 Thread Bruno Randolf
Update ath5k to use the common cycle counters in it's ANI implementation. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ani.c | 34 drivers/net/wireless/ath/ath5k/ani.h |5 + drivers/net/wireless/ath/ath5k/debug.c |

[ath5k-devel] [PATCH 1/5] ath: Add common function for reading cycle counters

2010-10-05 Thread Bruno Randolf
unters should be required they would have to be added by hardcoding them in the function. This is not the most flexible way to deal with this, but it's easy and simple and i believe should be sufficient. Users have to hold the lock while accessing the counters. Signed-off-by: Bruno Randolf

[ath5k-devel] [PATCH] ath5k: Don't wake internal queues

2010-10-04 Thread Bruno Randolf
ueue it doesn't know about. this fixes: WARNING: at /home/br1/ath/wireless-testing/net/mac80211/util.c:275 __ieee80211_wake_queue+0xd6/0xe0 [mac80211]() Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [ath5k-devel] [PATCH v4] ath5k: Allow ath5k to support virtual STA and AP interfaces.

2010-09-28 Thread Bruno Randolf
On Tue September 28 2010 06:06:28 gree...@candelatech.com wrote: > From: Ben Greear > > Support up to 4 virtual APs and as many virtual STA interfaces > as desired. > > This patch is ported forward from a patch that Patrick McHardy > did for me against 2.6.31. hi ben! it's great to see this! :

[ath5k-devel] [PATCH] ath5k: Fix bitmasks and typos for PCU Diagnostic register

2010-09-26 Thread Bruno Randolf
As reported by Ryan Niemi, some bitmasks in the register definition for the PCU Diagnostic register (DIAG_SW) were missing a zero at the end. While at it fix some typos and add more comments. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/dma.c |4 ++-- drivers/net/wireless

[ath5k-devel] [PATCH 4/4] ath5k: Disable interrupts in ath5k_hw_get_tsf64

2010-09-26 Thread Bruno Randolf
The code in ath5k_hw_get_tsf64() is time critical and will return wrong results if we get interrupted, so disable local interrupts. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/pcu.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net

[ath5k-devel] [PATCH 3/4] ath5k: Increase "fudge" for beacon timers

2010-09-26 Thread Bruno Randolf
We use FUDGE to make sure the next TBTT is ahead of the current TU. Since we later substract AR5K_TUNE_SW_BEACON_RESP (10) in the timer configuration we need to make sure it is bigger than that. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/base.c |7 +-- 1 files

[ath5k-devel] [PATCH 2/4] ath5k: Check and fix ATIM window

2010-09-26 Thread Bruno Randolf
and these links: http://madwifi-project.org/ticket/1154 http://madwifi-project.org/changeset/3867 http://thread.gmane.org/gmane.linux.drivers.madwifi.devel/6066 Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 drivers/net/wireless/ath/ath5k/base.c |9 +++ d

[ath5k-devel] [PATCH 1/4] ath5k: Remove unused variable for atim window

2010-09-26 Thread Bruno Randolf
It's not used and it's unlikely we will ever implement ATIM. Signed-off-by: Bruno Randolf --- drivers/net/wireless/ath/ath5k/ath5k.h |1 - drivers/net/wireless/ath/ath5k/attach.c |1 - drivers/net/wireless/ath/ath5k/pcu.c|2 +- 3 files changed, 1 insertions(+), 3

[ath5k-devel] [PATCH 0/4] ath5k: ATIM and timer fixes

2010-09-26 Thread Bruno Randolf
The following series adds a check for a hardware condition which can cause an unwanted ATIM window configuration and some other smaller improvements for TSF related things. --- Bruno Randolf (4): ath5k: Remove unused variable for atim window ath5k: Check and fix ATIM window

  1   2   3   4   5   6   >