On Fri, 22 Mar 2024 05:15:38 GMT, Alexander Zuev wrote:
>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Got rid of the test wind
On Thu, 21 Mar 2024 20:22:18 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
>>
>>> 57: frame.add(textScrollPane, BorderLayout.CENTER);
>>> 58:
>>> 59: fd = new FileDialog(new Frame(), "Open");
>>
>> is there any need to mix
On Thu, 21 Mar 2024 16:16:55 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 60:
>
>> 58
> Convert test to a main based;
> Move test to an appropriate folder;
> Remove old files;
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Got rid of the test window, using OassFailJFrame instead;
Made all variables local;
Minor
On Sun, 21 Jan 2024 19:50:16 GMT, Phil Race wrote:
>> Fixed the formatting (at least in the marked cases), but am unsure what you
>> mean by set directly?
>
>> Fixed the formatting (at least in the marked cases), but am unsure what you
>> mean by set directly?
>
> See my comment
> "like in my
On Tue, 12 Mar 2024 12:49:06 GMT, Abhishek Kumar wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
This pull request has now been integrated.
Changeset: 256d48b1
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/256d48b19694
On Sat, 16 Mar 2024 07:43:18 GMT, Tejesh R wrote:
> Automated the Test `javax/swing/border/Test4129681.java` from manual as
> suggested in JBS description.
> Verified in CI system and its Green. The test has been verified for Metal L&F
> and the same is set explicitly..
This pull request has n
On Thu, 21 Mar 2024 19:10:40 GMT, Phil Race wrote:
> This previously closed test is cleaned up, opened and fixed to work on hidpi
> at fractional scales.
> It has unrelated problems on macOS 14 and is problem listed there (as it was
> when it was a closed test).
Problemlist on macOS no longer
On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
Marked as reviewed by honkar (Reviewer).
test/jdk/javax/swing/JColorChooser/Test6348456.java line 45:
> 43:
> 44: private static final DefaultColorSelectionModel WHITE = new
> De
On Thu, 21 Mar 2024 16:31:04 GMT, Damon Nguyen wrote:
> Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
> using PassFailJFrame for the instructions.
@DamonGuy Tested on macOS, JColorChooser DnD doesn't seem to work on it.
test/jdk/javax/swing/JColorChooser/8065098
On Wed, 20 Mar 2024 08:30:36 GMT, Abhishek Kumar wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Up
Clean up and opensource five tests.
-
Commit messages:
- 8316324: Opensource five miscellaneous Swing tests
Changes: https://git.openjdk.org/jdk/pull/18443/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18443&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8316324
On Wed, 20 Mar 2024 16:38:25 GMT, Harshitha Onkar wrote:
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixed again.**
> I believe this w
On Wed, 20 Mar 2024 18:01:51 GMT, Alisen Chung wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> text block instructions
test/jdk/javax/swing/JColorChooser/Test
On Fri, 15 Mar 2024 22:32:12 GMT, Phil Race wrote:
> Convert this applet based test to a main program
This pull request has now been integrated.
Changeset: f7f291c5
Author:Phil Race
URL:
https://git.openjdk.org/jdk/commit/f7f291c5d4d2d01dab3ccda7518ebc13f6bd58f6
Stats: 260 lines
On Thu, 21 Mar 2024 05:14:44 GMT, Tejesh R wrote:
>> Automated the Test `javax/swing/border/Test4129681.java` from manual as
>> suggested in JBS description.
>> Verified in CI system and its Green. The test has been verified for Metal
>> L&F and the same is set explicitly..
>
> Tejesh R has upd
On Thu, 21 Mar 2024 20:17:46 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe t
On Thu, 21 Mar 2024 18:15:23 GMT, Alisen Chung wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove .html from the @test clause
>
> test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 142:
>
>> 140:
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote:
>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove .html fro
On Thu, 21 Mar 2024 16:17:33 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding library and build clauses
>
> test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:
>
>> 57
On Thu, 21 Mar 2024 19:44:52 GMT, Alexander Zvegintsev
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 87:
>
>> 85: panel.add(new JL
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms,
On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race wrote:
> Converts
> java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.
This pull request has now been integrated.
Changeset: ab183e43
Author:Phil Race
URL:
https://git.openjdk.org/j
On Thu, 21 Mar 2024 13:51:16 GMT, Alexander Zvegintsev
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328642
>
> test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java
> li
> Converts
> java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8328642
-
Changes:
- all: https://git.openjdk.org/j
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms,
I don't know why this file is checked in. It has no @test tag and doesn't do
anything. I am deleting it.
-
Commit messages:
- 8328561
Changes: https://git.openjdk.org/jdk/pull/18440/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18440&range=00
Issue: https://bugs.openjd
On Thu, 21 Mar 2024 14:47:52 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added preciseWheelRotation logic & updated test
>
> Changes requested by aivanov (Reviewer).
@aivanov-jdk
I have
On Thu, 21 Mar 2024 18:13:41 GMT, Alisen Chung wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor jtreg tag change
>
> test/jdk/java/awt/im/bug4490692.java line 115:
>
>> 113: return panel;
>> 114:
On Thu, 21 Mar 2024 17:33:22 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/im/bug4490692.java line 95:
>>
>>> 93: @Override
>>> 94: public void keyPressed(KeyEvent e) {
>>> 95: if (e.getKeyCode() == 23 || e.getKeyCode() == 60) {
>>
>>> CASE 2: This step is automated and appl
On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe t
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has updated the pull request
On Thu, 21 Mar 2024 15:04:18 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added preciseWheelRotation logic & updated test
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java lin
On Wed, 20 Mar 2024 21:33:04 GMT, Phil Race wrote:
> Converts
> java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.html
> to a main program.
test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java
line 65:
> 63: fr
This previously closed test is cleaned up, opened and fixed to work on hidpi at
fractional scales.
It has unrelated problems on macOS 14 and is problem listed there (as it was
when it was a closed test).
-
Commit messages:
- 8328555
Changes: https://git.openjdk.org/jdk/pull/18439/
> This test is converted to main using PassFailJFrame. It verifies wheel
> rotation value for high-res mouse on windows.
>
> The test requires the updated PassFailJFrame's logArea() feature added in
> this PR https://github.com/openjdk/jdk/pull/18319
Harshitha Onkar has updated the pull request
On Wed, 20 Mar 2024 18:37:45 GMT, Alexander Zuev wrote:
>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove .html fro
On Thu, 21 Mar 2024 17:52:34 GMT, Harshitha Onkar wrote:
>> Following test is converted from applet to main using PassFailJFrame.
>>
>> The original test had ignore tag - **The fix for this problem was backed out
>> for 5057184. Remove this "ignore" tag when it is fixed again.**
>> I believe t
On Thu, 21 Mar 2024 17:19:25 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 68:
>
>> 66: Then
On Thu, 21 Mar 2024 15:20:16 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
> line 126:
>
>> 124:
> Convert this applet based test to a main program
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8328301
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18334/files
- new: https://git.openjdk.org/jdk/pull/18334/fil
On Thu, 21 Mar 2024 15:14:26 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
> line 110:
>
>> 108:
On Mon, 18 Mar 2024 17:31:07 GMT, Damon Nguyen wrote:
> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
> applet test to main using PassFailJFrame
This pull request has now been integrated.
Changeset: ba05c6d0
Author:Damon Nguyen
URL:
https://git.openj
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms,
On Tue, 19 Mar 2024 18:20:06 GMT, Phil Race wrote:
> A simple fix to the test to skip sampling the leftmost and rightmost ends of
> the divider
> to avoid possible issues at fractional scales.
This pull request has now been integrated.
Changeset: fa823bd2
Author:Phil Race
URL:
http
On Tue, 19 Mar 2024 23:30:39 GMT, Phil Race wrote:
> This seems to have been some previous not very complete conversion of a test
> from applet to main.
> It even still had Applet imported and miscellaneous comments. I've cleaned it
> up.
This pull request has now been integrated.
Changeset:
On Thu, 21 Mar 2024 17:40:55 GMT, Alexey Ivanov wrote:
>> I'm OK with either direction. To me, passing the test seems fine for cases
>> we'd skip, but adding a `Skip` button may seem more logical. I was OK with
>> this approach enough to stick with the original instructions.
>
> I'm not suggest
On Thu, 21 Mar 2024 17:36:24 GMT, Damon Nguyen wrote:
>> Do we need an occasional _Skip_ button? Yet adding such a button to throw
>> `jtreg.SkippedException` will introduce a transitive dependency on the
>> library which contains the `SkippedException`.
>
> I'm OK with either direction. To me,
On Thu, 21 Mar 2024 17:40:55 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision
> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
> applet test to main using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.
On Thu, 21 Mar 2024 17:34:19 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:
>>
>>> 77: and Mission Control behavior.
>>> 78:
>>> 79: Close the windows.
>>
>> Won't it fail the test?
>
> This was a part of the origina
On Thu, 21 Mar 2024 17:17:10 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 79:
>
>> 77: and
On Thu, 21 Mar 2024 17:15:31 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62:
>>
>>> 60: - 2nd display is non-HiDPI.
>>> 61:
>>> 62: In other cases please simply push "Pass".
>>
>> These conditions can be detected. On
On Thu, 21 Mar 2024 10:47:24 GMT, Tejesh R wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> instruction line length
>
> test/jdk/java/awt/im/bug4490692.java line 81:
>
>> 79:
>> 80: class TestFrame extends JFra
On Thu, 21 Mar 2024 16:45:40 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove getContentPane usage
>
> test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126:
>
>> 124: ke
> Few manual closed applet test converted to automated and open sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Remove getContentPane usage
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18428/files
-
On Thu, 21 Mar 2024 12:11:43 GMT, Alexander Zvegintsev
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> instruction line length
>
> test/jdk/java/awt/im/bug4490692.java line 74:
>
>> 72: .rows((
> Following test is converted from applet to main using PassFailJFrame.
>
> The original test had ignore tag - **The fix for this problem was backed out
> for 5057184. Remove this "ignore" tag when it is fixed again.**
> I believe this was fixed and the test works correctly on Linux platforms,
On Thu, 21 Mar 2024 17:13:34 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62:
>
>> 60: - 2n
On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision
On Thu, 21 Mar 2024 17:03:41 GMT, Alexander Zvegintsev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:
>
>> 107:
> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
> applet test to main using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove frame. Use JButton
-
Changes:
- all: ht
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> D
On Thu, 21 Mar 2024 16:51:36 GMT, Damon Nguyen wrote:
>> Convert
>> java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet
>> test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision
On Thu, 21 Mar 2024 12:02:52 GMT, Alexey Ivanov wrote:
>> Hi, I'm the submitter of the original bug report. I can confirm that you got
>> the reason for the change exactly right.
>
> @uckelman Is there a way to reproduce the original bug in the user's
> environment?
>
> I think there's a bug i
On Thu, 21 Mar 2024 16:11:44 GMT, Damon Nguyen wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
>> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
>> no longer an applet. Added test instructions related to the linked JBS issue.
>
> D
On Thu, 21 Mar 2024 14:14:17 GMT, Alexander Zvegintsev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 33:
>
>> 31: *
> Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java
> applet test to main using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.
On Thu, 21 Mar 2024 10:46:41 GMT, Abhishek Kumar wrote:
> Few manual closed applet test converted to automated and open sourced.
Marked as reviewed by psadhukhan (Reviewer).
test/jdk/javax/swing/JInternalFrame/Ctrli.java line 126:
> 124: keyecho.addMouseListener(mouseListener);
> 125:
On Wed, 20 Mar 2024 15:48:41 GMT, Alexander Zuev wrote:
>> Convert test to main manual;
>> Move test to appropriate folder;
>> Delete old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Moving test metadata closer
On Tue, 12 Mar 2024 18:50:58 GMT, Damon Nguyen wrote:
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
This pull request has now been integrated.
Changeset: cc5cda55
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/cc5cda558736ffeae2a
Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
using PassFailJFrame for the instructions.
-
Commit messages:
- Lambda replacement
- Initial test conversion
Changes: https://git.openjdk.org/jdk/pull/18436/files
Webrev: https://webrevs.openjdk.org/?r
On Tue, 19 Mar 2024 14:10:52 GMT, Alexander Zuev wrote:
>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding library and build
On Wed, 20 Mar 2024 16:46:40 GMT, Damon Nguyen wrote:
> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
> using PassFailJFrame
This pull request has now been integrated.
Changeset: ef2bd572
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/ef2bd5
On Thu, 21 Mar 2024 16:08:48 GMT, Damon Nguyen wrote:
>> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
>> using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace canvas with
> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
> using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove contentPane
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
On Thu, 21 Mar 2024 05:30:58 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Modify instructions more
>> - Modify instructions
>
> test/jdk/java/awt/print/Dialog/PrintModalDialog.java li
> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using
> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is
> no longer an applet. Added test instructions related to the linked JBS issue.
Damon Nguyen has updated the pull request incrementally with on
On Thu, 21 Mar 2024 07:41:15 GMT, Abhishek Kumar wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove reundant window constant
>
> test/jdk/java/awt/im/JTextFieldTest.java line 32:
>
>> 30: * work cor
> Convert java/awt/im/JTextFieldTest.java applet test to main using
> PassFailJFrame.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18247/files
-
On Thu, 21 Mar 2024 11:52:28 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new line
>
> test/jdk/javax/swing/JCheckBox/bug8032667.java line 78:
>
>> 76: final Image image1 = getIma
> Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
> using PassFailJFrame
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Replace canvas with jpanel
-
Changes:
- all: https://git.openjdk.org/j
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre-empted between t
On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov wrote:
> This is to simplify `TrayIconScalingTest.java`.
>
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more
> specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with the chained calls, includin
On Tue, 19 Mar 2024 01:14:29 GMT, Alexander Zvegintsev
wrote:
>> we need to add next to Pass/Fail a "Pause Timer" button, that
> (a) stops the count down
> (b) changes the Pause Timer to "Resume Timer"
> ~~(c) disables Pass/Fail until the timer is resumed~~
> the test will not have to pause or b
On Fri, 15 Mar 2024 22:54:23 GMT, Harshitha Onkar wrote:
> Following test
> java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html is converted
> to main using PassFailJFrame.
>
> This test is currently problem-listed on macOS and linux, but as per the
> previous JBS bugs
> [[JDK-62
On Wed, 20 Mar 2024 18:57:37 GMT, Phil Race wrote:
>> Convert this applet based test to a main program
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8328301
test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavo
On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung wrote:
> Removing applet usage from manual JFileChooser tests
test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 111:
> 109: } finally {
> 110: if (!res) {
> 111: throw new RuntimeException("BackSpace
On Thu, 21 Mar 2024 14:25:36 GMT, Alexander Zuev wrote:
> Since you are editing these files you can also drop the @author tag from the
> test metadata. Otherwise looks good.
Sure,
author removed
../../../regtesthelpers -> /java/awt/regtesthelpers,
moved whole block closer to class declaration
> Two tests may fail intermittently on Wayland, the standard `waitForIdle` and
> `delay` fixes the issue.
>
> Manual and CI testing looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
author removed, ../../../regtest
On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Thu, 21 Mar 2024 14:41:50 GMT, Prasanta Sadhukhan
wrote:
>> Couple closed manual applet text/html/CSS tests are converted to main based
>> and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review co
On Thu, 21 Mar 2024 01:13:50 GMT, Harshitha Onkar wrote:
>> This test is converted to main using PassFailJFrame. It verifies wheel
>> rotation value for high-res mouse on windows.
>>
>> The test requires the updated PassFailJFrame's logArea() feature added in
>> this PR https://github.com/open
On Thu, 21 Mar 2024 03:44:01 GMT, Prasanta Sadhukhan
wrote:
> Few closed manual applet JViewport tests are converted to main based and
> opensourced
This pull request has now been integrated.
Changeset: 725d87bb
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/725
On Thu, 21 Mar 2024 14:40:30 GMT, Alexander Zuev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting
>
> test/jdk/javax/swing/JViewport/bug4137282.java line 86:
>
>> 84: }
>> 85:
>> 86: stati
On Thu, 21 Mar 2024 14:42:49 GMT, Prasanta Sadhukhan
wrote:
>> Few closed manual applet JViewport tests are converted to main based and
>> opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> formatting
Mark
On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan
wrote:
>> Few closed manual applet JViewport tests are converted to main based and
>> opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> formatting
test
> Few closed manual applet JViewport tests are converted to main based and
> opensourced
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
formatting
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18418/files
On Thu, 21 Mar 2024 14:00:17 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> library path fix
>
> test/jdk/javax/swing/text/html/CSS/bug4271058.java line 60:
>
>> 58: .colu
> Couple closed manual applet text/html/CSS tests are converted to main based
> and opensourced
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk
1 - 100 of 149 matches
Mail list logo
