On Wed, 6 Mar 2024 21:36:10 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one
On Tue, 5 Mar 2024 12:13:02 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Suggesions incorporated
>
> test/jdk/java/awt/print/PrinterJob/PrintA
On Tue, 5 Mar 2024 14:56:22 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Suggesions added
>
> test/jdk/java/awt/print/PrinterJob/Pri
On Wed, 6 Mar 2024 09:46:58 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Wed, 6 Mar 2024 10:43:16 GMT, Tejesh R wrote:
>> Alexey Ivanov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Replace synchronized invalidateFileCache with synchronized block inside
>> - Declar
oncurrentModificationException` seen in
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in
> PR #18109.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since the
On Wed, 6 Mar 2024 06:07:20 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74:
>>
>>> 72: if (pj.printDialog(prSet)) {
>>> 73: pj.print(prSet);
>>> 74: }
>>
>> In this case, the
On Wed, 6 Mar 2024 06:57:12 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
On Wed, 6 Mar 2024 07:49:35 GMT, Christoph Langer wrote:
> > It looks good to me.
> > The only question I have is for the fallback in
> > `awt_Win32GraphicsDevice.cpp`.
> > Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits`
> > fails, we can bail out too.
> > If the
On Fri, 16 Feb 2024 08:45:59 GMT, Christoph Langer wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp
>> line 191:
>>
>>> 189: return;
>>> 190: }
>>> 191: VERIFY(::GetDIBits(hBMDC, hBM, 0, 1, NULL, gpBitmapInfo,
>>> DIB_RGB_COLORS));
>>
>> I
On Fri, 1 Mar 2024 08:01:08 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
>= c
> where
> a = C:\Users\Documents(true)
> b = C:\Users(false)
> c = C:\Users\Documents(false)
>
> as well as for the reverse case: `a > b & b > c`.
>
> How it is possible to have the same folder in a list of files twice remains
> unknown. I believe
The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are
cases where
`a < b & b < c but a == c`
which *violates its general contract*.
In particular, it happens for the personal folder (*Documents*) if it is listed
*twice*: as a special and as a regular folder.
The
On Mon, 4 Mar 2024 18:10:04 GMT, Phil Race wrote:
> And capitalise "We", and "In" since they begin sentences
I agree, yet it's not always followed in the comments.
> If we are going to fix that, we might as well fix the entire sentence.
Thank you for your suggestion. The sentence didn't sound
> A trivial change in a comment: consequent → _consecutive_ positions.
>
> This was found in [a code
> review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
> [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).
Alexey Ivanov has updated t
On Tue, 13 Feb 2024 12:06:46 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 48:
>>
>>> 46: "For non-windows OS, this test PASSes.\n" +
>>> 47: "You must have at least 2 printers available to perform
>>> this
On Mon, 4 Mar 2024 06:48:18 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 13 Feb 2024 14:01:40 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Fixed compiler error
>
> test/jdk/java/awt/print/PrinterJob/PrintA
On Mon, 4 Mar 2024 06:04:07 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 5 Mar 2024 12:27:28 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Tue, 5 Mar 2024 12:13:05 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 58:
>>
>>> 56: public static void main(String[] args) throws Exception {
>>> 57:
>>> UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
On Tue, 5 Mar 2024 06:08:00 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` threa
On Tue, 5 Mar 2024 09:24:52 GMT, Andrey Turbanov wrote:
>> Alexey Ivanov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Replace synchronized invalidateFileCache with synchronized block inside
>&g
oncurrentModificationException` seen in
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) using the test in
> PR #18109.
Alexey Ivanov has updated the pull request incrementally with four additional
commits sinc
On Tue, 5 Mar 2024 00:48:13 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Replace synchronized invalidateFileCache with synchronized block inside
>&g
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre
Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
synchronized.
Without synchronization, a thread checks if `filesLoader` is not null and
creates a new `FilesLoader` thread. If the thread is pre-empted between these
two operations, another thread or even several threads can
On Sun, 3 Mar 2024 09:01:49 GMT, Dmitry Markov wrote:
> Updated several tests to avoid potential failure with recent LCMS update and
> non-LCMS generated profile.
The fix is to always use the accuracy which is used for the LCMS library,
without trying to detect what colour profile is used.
I'm adding a regression test for
[JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
[JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
regression test for [JDK-8240690](https://bugs.openjdk.org/browse/JDK-8240690).
I referenced this test in PR #17462 in [this
On Fri, 1 Mar 2024 16:05:07 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Fri, 1 Mar 2024 11:39:09 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Fri, 1 Mar 2024 10:22:16 GMT, Abhishek Kumar wrote:
> > You could add @modules java.desktop/com.sun.java.swing.plaf.windows to
> > jtreg tags and access the
> > com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isMnemonicHidden method
> > to verify that the mnemonics are shown or hidden
A trivial change in a comment: consequent → _consecutive_ positions.
This was found in [a code
review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
[JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).
-
Commit messages:
- 8286759:
On Thu, 29 Feb 2024 07:42:44 GMT, Abhishek Kumar wrote:
> > This needs testing with popup menus and combobox popups.
>
> Popup menus doesn't show mnemonics in windows LAF by default. On press of alt
> or F10, popup menu windows becomes invisible.
This statement is generally false. Popup menus
On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Wed, 28 Feb 2024 12:20:04 GMT, Alexey Ivanov wrote:
> If a test runs in non-English locale, the digits displayed in the timeout
> could be locale-specific, which may be confusing.
>
> For example, in the Arabic locale `-Duser.language=ar`, the timeout is
> displayed like
On Wed, 28 Feb 2024 16:40:03 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified
On Wed, 28 Feb 2024 15:48:05 GMT, Andy Goryachev wrote:
>> If a test runs in non-English locale, the digits displayed in the timeout
>> could be locale-specific, which may be confusing.
>>
>> For example, in the Arabic locale `-Duser.language=ar`, the timeout is
>> displayed like this:
>>
>>
On Thu, 22 Feb 2024 11:11:01 GMT, Abhishek Kumar wrote:
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
> Behavior is not similar to windows native application. Fix is to ensure that
> menu mnemonic state toggles between show and hide.
>
> Can be verified with
On Tue, 27 Feb 2024 11:14:02 GMT, Alexey Ivanov wrote:
> The root cause has been resolved under another bug. Here, you update the
> test… because it uses `Applet`. You don't actually fix the test to make it
> pass.
>
> Perhaps even, create a _new bug_ with clear description an
On Wed, 14 Feb 2024 13:57:41 GMT, Alexey Ivanov wrote:
> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a
> single *Print* button as its test UI. To simplify the UI, I used the new
> `splitUI` method from #17845.
>
> In addition to it, I refa
On Tue, 27 Feb 2024 21:13:21 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one
On Tue, 27 Feb 2024 11:00:14 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove system property set
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest
On Wed, 28 Feb 2024 11:12:48 GMT, Alexey Ivanov wrote:
>> @alisenchung Since the trayicon is added back after removal and
>> PassFailJFrame handles disposal of test windows only, Aleksei is suggesting
>> we handle the removal of trayicon explicitly (when test is run ou
If a test runs in non-English locale, the digits displayed in the timeout could
be locale-specific, which may be confusing.
For example, in the Arabic locale `-Duser.language=ar`, the timeout is
displayed like this:
Test timeout: ٠٠:٠٤:٥٨
The fix explicitly sets English locale for formatting,
On Wed, 28 Feb 2024 01:31:16 GMT, Harshitha Onkar wrote:
>> i'm not sure i understand this, the test is trying to remove right after the
>> click action is delivered and not before the test is closing, so wouldn't
>> putting the removal of the icon in a finally block defeat the purpose of the
On Mon, 26 Feb 2024 20:32:54 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one
On Thu, 15 Feb 2024 19:29:52 GMT, Harshitha Onkar wrote:
>>> I have a printer configured but I'm running into `PrinterException: Access
>>> is denied.` The option of saving to pdf doesn't work too.
>>
>> Do other printer tests work? It seems more like a system configuration issue
>> rather
On Thu, 22 Feb 2024 11:11:01 GMT, Abhishek Kumar wrote:
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
> Behavior is not similar to windows native application. Fix is to ensure that
> menu mnemonic state toggles between show and hide.
>
> Can be verified with
a constant to ensure the same text is
> printed and displayed in the instructions.
> - Displayed an error message to the tester if `PrinterException` is caught
> and automatically failed the test.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 22 Feb 2024 13:52:23 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> I have updated the test with 'PassFailJFrame' with programmatically
>> generating image and print , please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull
On Thu, 15 Feb 2024 15:41:57 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Replaced skipped exception with runtime exception
>
> test/j
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote:
> This enhancement adds three methods to `PassFailJFrame.Builder`:
>
> 1. **`splitUIRight`** to display test UI to the right of the instructions;
> 2. **`splitUIBottom`** to display test UI to the bottom of the instructions;
&
On Tue, 20 Feb 2024 10:34:46 GMT, Tejesh R wrote:
>> Yes, we can. There's `@key printer` which implies the test is to be run on a
>> system where at least one printer is available.
>>
>> What do you suggest actually?
>
> I am thinking whether the printer availability check is required at
>
On Tue, 20 Feb 2024 06:56:06 GMT, Tejesh R wrote:
>> Alexey Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge 8294148-splitUI
>> - Revert the condition in print
On Mon, 19 Feb 2024 06:02:10 GMT, Prasanta Sadhukhan
wrote:
> guess you can do "\integrate" for us to "sponsor"
Or rather, @vtstydev, issue the
[`/integrate`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/integrate)
command to integrate the fix. Someone
On Wed, 31 Jan 2024 17:08:58 GMT, Alexey Ivanov wrote:
> When `` tag is used inside ``, the `line-through` style is lost, and
> the text is rendered with `underline` only. However, if `` is used,
> the text is rendered with both `underline` and `line-through` styles.
>
> Both `
On Fri, 16 Feb 2024 12:38:02 GMT, Christoph Langer wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp
>> line 200:
>>
>>> 198: }
>>> 199:
>>> 200: if (colorData->bitsperpixel > 8) {
>>
>> So at this time, the code below will not be run if an error
On Fri, 16 Feb 2024 08:46:10 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
On Fri, 16 Feb 2024 08:46:10 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
On Fri, 16 Feb 2024 08:42:28 GMT, Christoph Langer wrote:
>> Right, that's what's written. But (in the documentation,) the function is
>> declared as `BOOL GetMonitorInfoW...`. So I could epxect return values of
>> TRUE/FALSE, no?
>
> Addressed.
> So I could epxect return values of
On Thu, 15 Feb 2024 17:46:08 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - added space to a
On Thu, 15 Feb 2024 17:43:03 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 90:
>>
>>> 88: if (accessible instanceof AccessibleComponent) {
>>> 89: try {
>>> 90: AccessibleComponent component =
>>>
On Tue, 13 Feb 2024 04:49:28 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> I have updated the test with 'PassFailJFrame' with programmatically
>> generating image and print , please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull
On Wed, 14 Feb 2024 22:13:18 GMT, Harshitha Onkar wrote:
> I have a printer configured but I'm running into `PrinterException: Access is
> denied.` The option of saving to pdf doesn't work too.
Do other printer tests work? It seems more like a system configuration issue
rather than JDK issue.
On Wed, 31 Jan 2024 07:23:13 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>>
On Wed, 14 Feb 2024 19:47:30 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JTabbedPane/TabbedPaneNPECheck.java line 56:
>>
>>> 54: SwingUtilities.invokeAndWait(me::test);
>>> 55: } finally {
>>> 56: if (mainFrame != null) {
>>
>> should be disposed on EDT.
On Wed, 14 Feb 2024 19:50:34 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Moved frame disposal
On Wed, 14 Feb 2024 18:47:55 GMT, Harshitha Onkar wrote:
>> This enhancement adds three methods to `PassFailJFrame.Builder`:
>>
>> 1. **`splitUIRight`** to display test UI to the right of the instructions;
>> 2. **`splitUIBottom`** to display test UI to the bottom of the instructions;
>> 3.
On Wed, 14 Feb 2024 13:22:48 GMT, Alexey Ivanov wrote:
> This enhancement adds three methods to `PassFailJFrame.Builder`:
>
> 1. **`splitUIRight`** to display test UI to the right of the instructions;
> 2. **`splitUIBottom`** to display test UI to the bottom of the instructions;
&
On Wed, 14 Feb 2024 14:06:15 GMT, Alexey Ivanov wrote:
>> The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a
>> single *Print* button as its test UI. To simplify the UI, I used the new
>> `splitUI` method from #17845.
>>
>> In additio
a constant to ensure the same text is
> printed and displayed in the instructions.
> - Displayed an error message to the tester if `PrinterException` is caught
> and automatically failed the test.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase.
The `test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java` displays a
single *Print* button as its test UI. To simplify the UI, I used the new
`splitUI` method from #17845.
In addition to it, I refactored the test:
- Extracted the rendered text into a constant to ensure the same text is
This enhancement adds three methods to `PassFailJFrame.Builder`:
1. **`splitUIRight`** to display test UI to the right of the instructions;
2. **`splitUIBottom`** to display test UI to the bottom of the instructions;
3. `splitUI`: a convenience method for a default split orientation, currently
On Tue, 13 Feb 2024 07:50:15 GMT, Prasanta Sadhukhan
wrote:
>> Existing regression test is failing because textfield height is not as per
>> test's expectation..Seems like the indic character being tried to render is
>> not being loaded (probably because of missing glyphs) leading to 0
>>
On Wed, 14 Feb 2024 09:08:59 GMT, Prasanta Sadhukhan
wrote:
> > For me, it fails on Windows because no suitable font is found;
>
> It is not because of fonts availability...It's because of the order of `pack
> `and `setVisible `being called which is causing some issue with
> `i18nFieldView
On Wed, 14 Feb 2024 09:52:12 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Tue, 13 Feb 2024 15:21:13 GMT, Alexey Ivanov wrote:
> the test fails all the time in windows & linux if PL is removed...
Okay, I see it fails. For me, it fails on Windows because no suitable font is
found; on Ubuntu 22.04 there are fonts available and the test fails because
**[JDK-
On Tue, 13 Feb 2024 10:37:44 GMT, Prasanta Sadhukhan
wrote:
> > Can you spot a difference?
>
> Yes, I can...The `&& `is modified by JDK-8001470 to `||
> `[https://hg.openjdk.org/jdk9/jdk9/jdk/rev/ff8622450b29] and it was reverted
> back and current code in repo uses &&.. and yes, the test
On Tue, 13 Feb 2024 12:06:25 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Tue, 13 Feb 2024 08:47:06 GMT, Renjith Kannath Pariyangad
wrote:
>> Yes, there is a catch wanted to share with you.
>> This test more inclined with 7183516 issue. With respect to 4884389 issue
>> problem mentioned like _but when its
>> printed italic fonts are printed as plain in Win32._
On Wed, 7 Feb 2024 17:16:55 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
> test/jdk/ja
On Tue, 13 Feb 2024 08:46:19 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Thu, 1 Feb 2024 10:08:27 GMT, Renjith Kannath Pariyangad
wrote:
>> With the present frame size and layout settings, Set Paper" and "Print"
>> options are not visible.
>>
>> 
>
> Yes, Mac have an
On Tue, 13 Feb 2024 06:50:29 GMT, vtstydev wrote:
>> test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java
>> line 155:
>>
>>> 153: }
>>> 154:
>>> 155: class CustomPrintable implements Printable {
>>
>> I suggest making `CustomPrintable` a static nested class in
>>
On Tue, 13 Feb 2024 04:26:06 GMT, Prasanta Sadhukhan
wrote:
> Actually there is a misunderstanding of this issue. The original issue
> [JDK-8001470](https://bugs.openjdk.org/browse/JDK-8001470) fix caused
> regression [JDK-8130892](https://bugs.openjdk.org/browse/JDK-8130892) which
> caused
> When `` tag is used inside ``, the `line-through` style is lost, and
> the text is rendered with `underline` only. However, if `` is used,
> the text is rendered with both `underline` and `line-through` styles.
>
> Both `` and `` should render the text the same way.
Alexey Iva
On Fri, 26 Jan 2024 23:05:24 GMT, Phil Race wrote:
> "[JDK-8233177] JTextField's size is computed incorrectly when it contains
> Indic or Thai characters"
>
> This seems to be a copy of the original bug, but surely all we have now is a
> test bug ?? JDK-8233177 should be re-titled to
On Mon, 12 Feb 2024 10:18:14 GMT, Prasanta Sadhukhan
wrote:
>> Existing regression test is failing because textfield height is not as per
>> test's expectation..Seems like the indic character being tried to render is
>> not being loaded (probably because of missing glyphs) leading to 0
>>
On Tue, 23 Jan 2024 09:34:54 GMT, Abhishek Kumar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Check with FOnt.canDisplay
>
> test/jdk/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java line 71:
>
On Mon, 12 Feb 2024 12:33:30 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
Changes requested by aivanov (Reviewer).
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
What would be the best option to handle a missing printer?
On Sun, 11 Feb 2024 19:38:28 GMT, Phil Race wrote:
>> Hi Reviewers,
>> I have updated the test with 'PassFailJFrame' with programmatically
>> generating image and print , please review and let me know your suggestions.
>
> I had a slack chat with Jon Gibbons (maintainer of jtreg) and he thinks
On Fri, 9 Feb 2024 20:04:29 GMT, Phil Race wrote:
> Also adding that exception means you can't run without the jtreg framework,
> unless you provide the class as part of the test itself. I mean something has
> to provide that class.
Yes, we can the test without jtreg, the exception comes from
401 - 500 of 1956 matches
Mail list logo
