On Sun, 11 Feb 2024 19:33:06 GMT, Phil Race wrote:
>> As I said before, the new code just quiesces JNI warnings. It is anyway only
>> used in debug builds. And in the case one sees a "real" exception before
>> entering the assertion handler, this exception will be on the stack when
>>
On Mon, 12 Feb 2024 11:07:41 GMT, Alexey Ivanov wrote:
>> I agree we should do something about it. I think `ConvertAction` can be
>> subclass of `CharacterAction`, then the listed actions in the table will be
>> more inline with the implementation.
>
> I've submi
On Mon, 12 Feb 2024 10:50:18 GMT, Alexey Ivanov wrote:
>> Probably we can do away with those tags which mention internal class OR
>> mention the public action instead, like TagAction instead of ConvertAction
>> HiddenAction instead of TitleAction etc
>
> I agree we s
On Mon, 12 Feb 2024 07:09:43 GMT, Prasanta Sadhukhan
wrote:
>> It's a good question.
>>
>> We can't do it because `ConvertAction` is not public. In fact, `B`, `FONT`,
>> `I`, `STRIKE`, `SUB`, `SUP`, `U` use `ConvertAction` instead of the
>> specified `CharacterAction`.
>>
>> The bigger
On Fri, 9 Feb 2024 19:27:32 GMT, Alexey Ivanov wrote:
> > I thought SkippedException looks like a "pass" too ?
> > What is effectively different by using it here ?
>
> No, it's not. If a test throws `jtreg.SkippedException`, then it's reported
> as **skipped
On Fri, 9 Feb 2024 19:11:22 GMT, Phil Race wrote:
> I thought SkippedException looks like a "pass" too ?
> What is effectively different by using it here ?
No, it's not. If a test throws `jtreg.SkippedException`, then it's reported as
**skipped**. It is neither a failure nor a success — it
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
test/jdk/java/awt/PrintJob/ImageTest/ImageTest.java line 151:
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
Should we mark `paint` and `imageUpdate` with `@Override`
On Fri, 9 Feb 2024 10:52:54 GMT, Prasanta Sadhukhan
wrote:
>> When `` tag is used inside ``, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `` and
On Fri, 9 Feb 2024 03:12:57 GMT, Phil Race wrote:
>> Yes. However, it's "only" in the assertion callback that only exists in
>> debug VMs. And an original exception isn't lost.
>
> Perhaps what we should do here is
> if (ExceptionCheck) {
> ExceptionDescribe
> ExceptionClear
> }
> So someone
On Fri, 9 Feb 2024 14:20:02 GMT, Alexey Ivanov wrote:
>> Perhaps what we should do here is
>> if (ExceptionCheck) {
>> ExceptionDescribe
>> ExceptionClear
>> }
>> So someone can "see" [yes, this means it isn't propagated but we've printed
On Fri, 9 Feb 2024 10:52:01 GMT, Prasanta Sadhukhan
wrote:
>> When `` tag is used inside ``, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `` and
On Fri, 9 Feb 2024 02:17:01 GMT, Phil Race wrote:
> > I ran the test in our CI and I didn't notice an improvement.
>
> Did you run jdk:tier4 like Sergey was doing ?
No, I ran just this single test. I don't know how Sergey is running the test.
> Our CI runs some number of (headless) tests in
On Fri, 9 Feb 2024 02:13:16 GMT, Sergey Bylokhov wrote:
>> The ClipShapeTest test is split into 4 different tests which could be
>> executed in parallel.
>>
>> The execution time is changed from:
>>
>>
>> ==
>> Test summary
>> ==
>>
On Tue, 6 Feb 2024 08:39:01 GMT, Alexey Ivanov wrote:
> Replace _“effect”_ with _“affect”_¹ because the meaning in the phrase “…the
> changes only _effect_ subsequent notification” is to “have an effect on.”
>
> Add a comma to separate a conditional clause from the main o
On Wed, 31 Jan 2024 21:58:24 GMT, Alisen Chung wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Capitalized static final variables
>
> test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 63:
On Thu, 1 Feb 2024 11:44:27 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 6 Feb 2024 20:13:01 GMT, Alexander Zuev wrote:
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
I wonder if it's appropriate that location or dimension become `null`. I would
expect these properties always return a non-`null` value, maybe in
On Thu, 8 Feb 2024 11:21:16 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Thu, 8 Feb 2024 06:04:16 GMT, Sergey Bylokhov wrote:
>> The ClipShapeTest test is split into 4 different tests which could be
>> executed in parallel.
>>
>> The execution time is changed from:
>>
>>
>> ==
>> Test summary
>> ==
>>
On Thu, 8 Feb 2024 03:23:13 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Thu, 1 Feb 2024 00:38:37 GMT, Alisen Chung wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Capitalized static final variables
>
> test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 106:
>
On Thu, 1 Feb 2024 07:09:55 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/DrawStringMethods.java line 70:
>>
>>> 68: .build();
>>> 69:
>>> 70: PrinterJob pjob = PrinterJob.getPrinterJob();
>>
>> i think this could be moved into a helper
On Thu, 1 Feb 2024 07:09:00 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Thu, 1 Feb 2024 00:39:16 GMT, Alisen Chung wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Suggestions integrated
>
> test/jdk/java/awt/print/PageFormat/PageSetupDialog.java line 225:
>
>> 223:
On Thu, 1 Feb 2024 10:06:21 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Wed, 7 Feb 2024 16:38:11 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
> test
On Tue, 30 Jan 2024 00:23:04 GMT, Harshitha Onkar wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
>
On Wed, 7 Feb 2024 00:08:55 GMT, Harshitha Onkar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test updated
>
> test/jdk/javax/swing/plaf/basic/BasicTreeUI/TreeCellRendererLeakTest.java
> line 111:
>
>>
On Tue, 6 Feb 2024 03:10:36 GMT, Sergey Bylokhov wrote:
> The ClipShapeTest test is split into 4 different tests which could be
> executed in parallel.
>
> The execution time is changed from:
>
>
> ==
> Test summary
> ==
>TEST
On Tue, 6 Feb 2024 11:34:28 GMT, Aleksey Shipilev wrote:
>> The ClipShapeTest test is split into 4 different tests which could be
>> executed in parallel.
>>
>> The execution time is changed from:
>>
>>
>> ==
>> Test summary
>> ==
>>
Replace _“effect”_ with _“affect”_¹ because the meaning in the phrase “…the
changes only _effect_ subsequent notification” is to “have an effect on.”
Add a comma to separate a conditional clause from the main one.
Use `` instead of ``: the example should be either in-line or in a
separate
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial
On Thu, 1 Feb 2024 12:02:19 GMT, Prasanta Sadhukhan
wrote:
>> It didn't work. It would've, if you'd added a blank between the two line.
>
> let me retry
Looks like it needs to be a top-level comment rather than a reply to code
change discussion.
-
PR Review Comment:
On Thu, 1 Feb 2024 03:16:27 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Thu, 1 Feb 2024 03:13:52 GMT, Prasanta Sadhukhan
wrote:
>> Could you add me as contributor, please?
>
> Ok..
It didn't work. It would've, if you'd added a blank between the two line.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17458#discussion_r1474311914
On Wed, 31 Jan 2024 05:35:44 GMT, Prasanta Sadhukhan
wrote:
>> It's simpler with `PhantomReference`. This type of reference does not allow
>> getting its referent, and it's not needed in this case. When the referent of
>> a reference is cleared by the GC, the reference is added into the
On Wed, 31 Jan 2024 17:13:55 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimise test
>
> src/java.desktop/share/classes/javax/swing/plaf/basic
On Wed, 31 Jan 2024 05:39:11 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
When `` tag is used inside ``, the `line-through` style is lost, and the
text is rendered with `underline` only. However, if `` is used, the
text is rendered with both `underline` and `line-through` styles.
Both `` and `` should render the text the same way.
-
Commit messages:
-
n has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java
>
>Co-authored-by: Alexey Ivanov
> - Update test/jdk/java/awt/PopupMenu/TruncatedPopupMenuTest.java
&
On Tue, 30 Jan 2024 21:49:12 GMT, Rajat Mahajan wrote:
> Modified the test to use PassFailJFrame and open sourced it.
> The test shows two windows, one for instructions and the other to perform
> testing on.
> Tested locally and it works fine.
Looks good, except for minor nits.
On Wed, 31 Jan 2024 04:53:44 GMT, Tejesh R wrote:
> > I forgot to add a direct link to the test:
> >
On Tue, 30 Jan 2024 13:47:05 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Tue, 30 Jan 2024 15:35:54 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use removeAll and testcase modified
>
> test/jdk/java
On Mon, 29 Jan 2024 06:18:50 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Thu, 25 Jan 2024 09:56:08 GMT, Alexey Ivanov wrote:
> > > …I'm for replacing `Vector` with `ArrayList` for the `newFileCache` and
> > > `newFiles` variables. These are local variables, they're not accessed
> > > concurrently. Yet they're accessed from t
On Tue, 30 Jan 2024 13:47:05 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
On Tue, 30 Jan 2024 13:15:14 GMT, Alexey Ivanov wrote:
> Is there a guide which clearly states where `ExceptionCheck` is required?
I should've looked it up. [Java Native Interface
Specification](https://docs.oracle.com/en/java/javase/21/docs/specs/jni/index.html),
section on [handling J
On Mon, 29 Jan 2024 21:29:53 GMT, Phil Race wrote:
>> Christoph Langer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
On Mon, 29 Jan 2024 06:16:04 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/plaf/basic/BasicTreeUI/TreeCellRendererLeakTest.java
>> line 62:
>>
>>> 60: }
>>> 61:
>>> 62: public void finalize( ) {
>>
>> The `finalize` method is deprecated. Can't we use `Reference` API
t;> date
>>
>> Co-authored-by: Alexey Ivanov
>
> I am working to verify the initial fix of JDK-8270269 in OpenJDK 23 (beta).
> The basic environment is:
>
> OpenJDK: "Azul Systems, Inc.", "Zulu23+11-CA", "23-beta+1", "x86_6
On Mon, 29 Jan 2024 07:13:49 GMT, Christoph Langer wrote:
>> This picks up fixing the issue of
>> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) again. A fix had
>> been integrated with #17224 but @prrace had concerns and so it was backed
>> out.
>>
>> I have now spent quite some
On Thu, 25 Jan 2024 13:58:50 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Fri, 26 Jan 2024 22:57:49 GMT, Sergey Bylokhov wrote:
>>> What is the code path which modifies the vector when we iterate it?
>>
>> I don't think we are able to trace it out, since the issue intermittent and
>> previously I had made a copy of the vector list before checking for equality
>>
On Thu, 25 Jan 2024 13:58:50 GMT, Tejesh R wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposing an
On Mon, 29 Jan 2024 10:17:29 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 785:
>>
>>> 783: * Returns the minimum size for the {@code JScrollBar}.
>>> 784: * The scrollbar is flexible along its scrolling axis and
>>> 785: *
On Mon, 29 Jan 2024 10:26:54 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Mon, 29 Jan 2024 06:47:50 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Fri, 26 Jan 2024 22:57:49 GMT, Sergey Bylokhov wrote:
> > I don't think we are able to trace it out, since the issue intermittent and
> > previously I had made a copy of the vector list before checking for
> > equality of the list. There was again an issue in the code which I used to
> >
On Tue, 23 Jan 2024 00:58:27 GMT, Sergey Bylokhov wrote:
> The next bug in freetype was fixed upstream and fix already merged to OpenJDK:
> https://gitlab.freedesktop.org/freetype/freetype/-/issues/1245
> So now we can revert the workaround in the JDK:
>
On Thu, 25 Jan 2024 10:50:32 GMT, Alexey Ivanov wrote:
> Step 6 uses `doFire` variable, it could be set to false using the `cancel`
> method, which is synchronized. As such, reading the value of `doFire` must
> also be synchronised.
It's not a problem, the `run` method is syn
On Thu, 25 Jan 2024 10:50:32 GMT, Alexey Ivanov wrote:
> Looking at the methods of `BasicDirectoryModel`, I can see that some methods
> use `synchronized(fileCache)` before accessing the field but others
> (`getSize`, `contains`, `indexOf`, `getElementAt`), wh
On Wed, 17 Jan 2024 12:55:52 GMT, Tejesh R wrote:
> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) also
> created concurrent exception intermittently (monthly once/quarterly once) on
> CI system. The issue was not able to be reproduced yet, hence proposing an
>
On Thu, 25 Jan 2024 04:43:59 GMT, Tejesh R wrote:
> Instead of putting everything into `synchronized(fileCache)`, I guess the
> better solution would be to wrap this line
>
>
On Thu, 25 Jan 2024 04:33:25 GMT, Tejesh R wrote:
> > Even if you'll go this route, I'm for replacing `Vector` with `ArrayList`
> > for the `newFileCache` and `newFiles` variables. These are local variables,
> > they're not accessed concurrently. Yet they're accessed from two threads:
> > the
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and
On Tue, 23 Jan 2024 04:31:45 GMT, Prasanta Sadhukhan
wrote:
>> Lines are left behind when moving the scrollbar in the positive direction.
>> but are cleaned up on mouse release.
>> Additonally, with right arrow clicks too, the lines are left behind.
>> Seems like for mouseDragged and
On Wed, 24 Jan 2024 05:35:42 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Wed, 17 Jan 2024 12:55:52 GMT, Tejesh R wrote:
> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) also
> created concurrent exception intermittently (monthly once/quarterly once) on
> CI system. The issue was not able to be reproduced yet, hence proposing an
>
On Wed, 24 Jan 2024 16:51:15 GMT, Tejesh R wrote:
> Using `synchronized (fileCache)` inside `ShellFolder.invoke` would be better
> and one solution right? Than making local copy and again doing sanity
> checks/changing to `ArrayList`?
I'm afraid I can't answer this question without more
On Tue, 23 Jan 2024 08:41:02 GMT, Andrey Turbanov wrote:
>> Then adding `synchronized(fileCache)` in `FilesLoader` where list comparison
>> happens would be better idea?
>
> Yes. If you go with `synchronized` then it should be `synchronized
> (fileCache)`
This is my concern as well. It looks
On Tue, 23 Jan 2024 03:37:45 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Mon, 22 Jan 2024 21:07:03 GMT, Alexander Zuev wrote:
>> Replaced asserts with NullPointerException calls because outside of testing
>> that would be more informative - i do not think many people running their
>> applications with assertions in system libraries enabled;
>> Added a code that
On Thu, 18 Jan 2024 02:48:26 GMT, Prasanta Sadhukhan
wrote:
> As mentioned in the comment
>
> https://github.com/openjdk/jdk/blob/36f4b34f1953af736706ec67192204727808bc6c/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java#L3283-L3284
>
> the components are to be removed
On Tue, 23 Jan 2024 04:58:00 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java line
>> 1338:
>>
>>> 1336: if(rendererPane != null) {
>>> 1337: if (!tree.isVisible()) {
>>> 1338:
On Fri, 19 Jan 2024 04:48:40 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan
wrote:
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan
wrote:
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and
On Sun, 21 Jan 2024 00:39:38 GMT, Sergey Bylokhov wrote:
> > Also, it might be the case the scrollbar methods like getUnitIncrement,
> > scrollBar.getValue scrollbar.setValue setThumbBounds sets or returns or
> > uses integer value despite scale being non-integer, so I guess repainting
> >
On Mon, 22 Jan 2024 00:33:34 GMT, Sergey Bylokhov wrote:
> Maybe we should check that something useful is returned? at least non-null VS
> null value?
Makes sense to ensure the returned value is not `null`.
-
PR Review Comment:
On Thu, 18 Jan 2024 19:34:11 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1208:
>>
>>> 1206: } else {
>>> 1207: return new MultiResolutionIconImage(size,
>>> multiResolutionIcon);
>>> 1208:
On Thu, 18 Jan 2024 19:40:40 GMT, Alexander Zuev wrote:
>> Replaced asserts with NullPointerException calls because outside of testing
>> that would be more informative - i do not think many people running their
>> applications with assertions in system libraries enabled;
>> Added a code that
On Thu, 18 Jan 2024 00:47:00 GMT, Alexander Zuev wrote:
> Replaced asserts with NullPointerException calls because outside of testing
> that would be more informative - i do not think many people running their
> applications with assertions in system libraries enabled;
> Added a code that will
On Fri, 12 Jan 2024 02:55:59 GMT, Sergey Bylokhov wrote:
>> @mrserb ,
>>
>> Did you mean to use the wrapper for the middle like `ColorSpace mid =
>> createCS(ColorSpaceSelector.WRAPPED_PYCC);` , So we can achieve :
>>
>> **From**
>> wrapper->icc_color_space->wrapper
>>
On Wed, 17 Jan 2024 01:56:25 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Tue, 16 Jan 2024 18:54:42 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Tue, 16 Jan 2024 17:58:37 GMT, Harshitha Onkar wrote:
> Ran the updated test on macOS 13 and 14.2, it works well with the
> stabilization fix done for macOS 14.1. Changes look good.
I ran a job with 50 repeats of the test in our CI, the test passes. I've
submitted a new job, just in a
On Tue, 16 Jan 2024 17:29:50 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Tue, 16 Jan 2024 15:41:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Tue, 16 Jan 2024 12:47:50 GMT, Alexey Ivanov wrote:
> In addition to this, I propose removing `robot.delay(50);` from the
> for-loops, or at least reducing this value, let's say, to 5.
The test is unstable without a delay inside the for-loop.
`robot.delay(5)` does the trick. Th
On Wed, 3 Jan 2024 19:21:47 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> two additional commits since the last revision:
>>
>> - Copyright year updated
>> - Review suggestions implement
On Tue, 16 Jan 2024 04:21:48 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>>
On Tue, 16 Jan 2024 12:46:30 GMT, Alexey Ivanov wrote:
>> songpv-imt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update InterJVMGetDropSuccessTest.java
>> - Remove robot.setWaitForIdle(true) and
On Tue, 16 Jan 2024 10:52:34 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
501 - 600 of 1956 matches
Mail list logo
