Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk merged PR #37545: URL: https://github.com/apache/airflow/pull/37545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

boring-cyborg[bot] commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1956112111 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1955915557 ...merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496663189 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Done. --

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1955270729 As of the latest changes (submitted a few hours ago), both of the points you mentioned are implemented. Is it acceptable to resolve the threads then? -- This is an automated message

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1955260813 Well - it was you who proposed to do something common between pydantic and sqlachemy so you expanded scope and discussions yourself, so yes it took longer and had more twists.

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496640405 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496585992 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496574933 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496573431 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496493598 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496363904 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496368853 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496363904 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496362776 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496362776 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496361617 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496357974 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496357974 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496344380 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496322930 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1496320478 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1954752790 This error is expected, regression of https://github.com/apache/airflow/pull/37524 Every PR now have this error, except the PRs which do not require to run `LatestBoto` ci tests

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1954685502 Can someone please explain the build failure to me? I don't know what to do about it. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-195952 LGTM. @uranusjr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1954008085 @uranusjr @potiuk I moved the methods as suggested. Please resolve threads and approve if acceptable. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495648821 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495622884 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

uranusjr commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1953899291 Eh this is not what I suggested, I want the SQLA v1 check to go into `airflow.utils.sqlalchemy`, and the others kept as-is. -- This is an automated message from the Apache Git

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495456330 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495361597 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: I don’t like

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495291662 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: @uranusjr Thank

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495259187 ## airflow/utils/orm_event_handlers.py: ## @@ -23,18 +23,25 @@ import traceback import sqlalchemy.orm.mapper -from sqlalchemy import event, exc +from sqlalchemy

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

uranusjr commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495257952 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Since we have

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495242470 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment:

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495084373 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Window ME was

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495076941 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: I'm pretty

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

potiuk commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495072748 ## airflow/settings.py: ## @@ -107,6 +107,8 @@ "shutdown": "blue", } +SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1") Review Comment: Shoudln't that

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1495010233 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494980560 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494964997 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494959852 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494895941 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494895941 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494864956 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494839827 ## tests/utils/test_orm_event_handlers.py: ## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494831358 ## tests/utils/test_orm_event_handlers.py: ## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494686253 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494686253 ## airflow/settings.py: ## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494681358 ## tests/utils/test_orm_event_handlers.py: ## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494644533 ## tests/utils/test_orm_event_handlers.py: ## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1952446342 @potiuk Pinging as promised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

boring-cyborg[bot] commented on PR #37545: URL: https://github.com/apache/airflow/pull/37545#issuecomment-1952432960 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[PR] Refrain from passing `encoding` to the SQL engine in SQLAlchemy v2 [airflow]

Dev-iL opened a new pull request, #37545: URL: https://github.com/apache/airflow/pull/37545 This PR fixes 1 error and 1 warning related to SQLAlchemy v2 ("SQLA2"), as well as an unrelated documentation hyperlink issue. See motivation for changes here: