mbalassi merged PR #154:
URL: https://github.com/apache/flink-kubernetes-operator/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbalassi commented on PR #154:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/154#issuecomment-1087493205
Dank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
MartijnVisser opened a new pull request, #154:
URL: https://github.com/apache/flink-kubernetes-operator/pull/154
Making sure that notification schema is setup like it's currently for Flink
core. Details about this file can be found in
gyfora merged PR #153:
URL: https://github.com/apache/flink-kubernetes-operator/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gyfora commented on a change in pull request #153:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/153#discussion_r841231326
##
File path: docker-entrypoint.sh
##
@@ -27,12 +27,12 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "operator" ]; then
echo
gyfora commented on pull request #141:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/141#issuecomment-1086881368
@SteNicholas we have merged the session controller changes, I think it would
be a good time to rebase this :)
--
This is an automated message from the Apache
gyfora merged pull request #149:
URL: https://github.com/apache/flink-kubernetes-operator/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora merged pull request #112:
URL: https://github.com/apache/flink-kubernetes-operator/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841229469
##
File path:
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/AdmissionHandler.java
##
@@ -62,7
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841219042
##
File path:
flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/AdmissionHandler.java
##
@@ -62,7
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841216699
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java
##
@@ -270,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841216499
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/FlinkResourceValidator.java
##
@@
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841216442
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/FlinkResourceValidator.java
##
@@
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841198754
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java
##
@@ -270,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841182486
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841182486
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841182486
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##
gyfora merged pull request #139:
URL: https://github.com/apache/flink-kubernetes-operator/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841166659
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultSessionJobValidator.java
##
gyfora commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841166010
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##
@@ -94,6
gyfora commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841161449
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##
@@ -94,6
SteNicholas commented on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086776176
@gyfora, thanks for your review. I have addressed your comments for
`FlinkConfigBuilder`. Please help to take a look.
--
This is an automated message
Aitozi opened a new pull request #153:
URL: https://github.com/apache/flink-kubernetes-operator/pull/153
Provide a way to set jvm args and also print the start up options using the
flink tools
---
By this we can also easily remote debug in the minikube environment
```
gyfora merged pull request #152:
URL: https://github.com/apache/flink-kubernetes-operator/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora merged pull request #143:
URL: https://github.com/apache/flink-kubernetes-operator/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Aitozi commented on pull request #152:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/152#issuecomment-1086657195
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Aitozi opened a new pull request #152:
URL: https://github.com/apache/flink-kubernetes-operator/pull/152
Bp for https://github.com/apache/flink-kubernetes-operator/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Aitozi commented on pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#issuecomment-1086656035
From my perspective, I think it's ready for review again. Please take look
cc @gyfora @wangyang0918
--
This is an automated message from the Apache Git
gyfora commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r841082985
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java
##
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841082863
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841082716
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841082654
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841082244
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841081668
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841080501
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkSessionJobController.java
##
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841080302
##
File path:
helm/flink-kubernetes-operator/conf/flink-operator-config/log4j2.properties
##
@@ -24,3 +24,8 @@ appender.console.name =
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841080204
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkSessionJobController.java
##
gyfora merged pull request #151:
URL: https://github.com/apache/flink-kubernetes-operator/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841079315
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@ -69,4
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841079581
##
File path: docs/content/docs/development/guide.md
##
@@ -108,6 +108,14 @@ So if the CRD is changed, you have to delete the CRD
bgeng777 commented on pull request #151:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/151#issuecomment-1086646570
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bgeng777 opened a new pull request #151:
URL: https://github.com/apache/flink-kubernetes-operator/pull/151
- Backport #150 for [FLINK-26611] Document operator config options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r841078949
##
File path: docs/content/docs/development/guide.md
##
@@ -108,6 +108,14 @@ So if the CRD is changed, you have to delete the CRD
gyfora merged pull request #150:
URL: https://github.com/apache/flink-kubernetes-operator/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#issuecomment-1086645578
Merging this, @bgeng777 please open a backport PR for the `release-0.1`
branch
--
This is an automated message from the Apache Git Service.
To respond to the
bgeng777 edited a comment on pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#issuecomment-1086643295
> The changes look good but I would prefer to have them in the `operations`
section for now.
I am ok with both. Previous design follows the
bgeng777 commented on pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#issuecomment-1086643295
> The changes look good but I would prefer to have them in the `operations`
section for now.
I am ok to both. Previous design follows the pattern of
bgeng777 commented on a change in pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#discussion_r841076950
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@
gyfora commented on a change in pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#discussion_r841073496
##
File path: docs/content/docs/deployment/configuration.md
##
@@ -0,0 +1,38 @@
+---
Review comment:
Not very easy to do
gyfora merged pull request #145:
URL: https://github.com/apache/flink-kubernetes-operator/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1086633057
Merging this @Aitozi please prepare the backport pr for `release-1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message,
SteNicholas commented on a change in pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#discussion_r841065588
##
File path: docs/content/docs/deployment/configuration.md
##
@@ -0,0 +1,38 @@
+---
Review comment:
Could the document of
SteNicholas commented on a change in pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#discussion_r841065516
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@
SteNicholas commented on a change in pull request #150:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/150#discussion_r841065484
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@
bgeng777 opened a new pull request #150:
URL: https://github.com/apache/flink-kubernetes-operator/pull/150
- Add `Deployment` -> `Configuration` tab in the doc website. This page can
be used to document other configs as well. (e.g.
https://issues.apache.org/jira/browse/FLINK-27008)
-
SteNicholas commented on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086608996
> > I would probably go for a more conservative 5 or 10 minute interval maybe
>
> Make sense. @SteNicholas Would you like to update this PR
wangyang0918 commented on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086608902
> I would probably go for a more conservative 5 or 10 minute interval maybe
Make sense. @SteNicholas Would you like to update this PR accordingly?
wangyang0918 opened a new pull request #149:
URL: https://github.com/apache/flink-kubernetes-operator/pull/149
Using [cache](https://github.com/marketplace/actions/cache) to speed up
workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message,
gyfora commented on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086605175
@wangyang0918 I would probably go for a more conservative 5 or 10 minute
interval maybe
--
This is an automated message from the Apache Git Service.
To
wangyang0918 commented on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1086600640
@gyfora Does it make sense to you that adding a default value(maybe 120s)
for `execution.checkpointing.interval` when last-state upgrade mode is used. It
gyfora commented on a change in pull request #143:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/143#discussion_r841034062
##
File path: docs/content/docs/try-flink-kubernetes-operator/quick-start.md
##
@@ -123,4 +118,10 @@ To expose the Flink Dashboard you
wangyang0918 commented on a change in pull request #143:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/143#discussion_r841008158
##
File path: docs/content/docs/try-flink-kubernetes-operator/quick-start.md
##
@@ -123,4 +118,10 @@ To expose the Flink Dashboard
Aitozi commented on a change in pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#discussion_r841000170
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/SessionReconciler.java
##
@@
Aitozi commented on a change in pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#discussion_r840999698
##
File path:
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/SessionReconcilerTest.java
##
@@
wangyang0918 commented on a change in pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#discussion_r840997406
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/SessionReconciler.java
##
@@
wangyang0918 commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1086510627
@Aitozi @gyfora I also just forgot to verify the session cluster. I lean to
not make this as the blocker of release-0.1. Because the session cluster could
Aitozi commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1086469906
A test is added to guard this and also create a ticket for it.
Since in release-0.1 the functional of session cluster is not complete, I'm
OK not consider
zeus1ammon commented on pull request #129:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/129#issuecomment-1086426382
@mbalassi javadoc is added. please let me know, if the content of the
javadoc is enough.
--
This is an automated message from the Apache Git Service.
To
mbalassi merged pull request #148:
URL: https://github.com/apache/flink-kubernetes-operator/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
mbalassi opened a new pull request #148:
URL: https://github.com/apache/flink-kubernetes-operator/pull/148
Missed this in my previous PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gyfora commented on pull request #147:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/147#issuecomment-1086170192
please backport it to release-0.1 @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gyfora merged pull request #147:
URL: https://github.com/apache/flink-kubernetes-operator/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on pull request #146:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/146#issuecomment-1086169842
Please backport it to release-0.1 @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
gyfora merged pull request #146:
URL: https://github.com/apache/flink-kubernetes-operator/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora merged pull request #131:
URL: https://github.com/apache/flink-kubernetes-operator/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
gyfora commented on a change in pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#discussion_r840789333
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/Mode.java
##
@@ -19,13 +19,33 @@
bgeng777 commented on a change in pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#discussion_r840769013
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/Mode.java
##
@@ -19,13 +19,33 @@
SteNicholas edited a comment on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085628099
> What I am thinking is to add a default value for
`execution.checkpointing.interval` when HA enabled. It could be overridden by
user specified CR
SteNicholas commented on a change in pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#discussion_r840323877
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
gyfora commented on a change in pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#discussion_r840740946
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/Mode.java
##
@@ -19,13 +19,33 @@
gyfora commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1086103995
Thanks I understand now. It's an unfortunate bug that delays session
deployments, I would not consider it a release blocker at this stage.
@wangyang0918 what
mbalassi opened a new pull request #147:
URL: https://github.com/apache/flink-kubernetes-operator/pull/147
Should be merged to `release-0.1` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mbalassi opened a new pull request #146:
URL: https://github.com/apache/flink-kubernetes-operator/pull/146
Also limits nightly build only to relevant branches. Should be merged to
`release-0.1` too.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Aitozi commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1085970817
> I will check this when I get home. What happens when it is submitted the
second time? Will we get an error or 2 clusters?
It will trigger an upgade
gyfora commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1085900110
I will check this when I get home. What happens when it is submitted the
second time? Will we get an error or 2 clusters?
--
This is an automated message
bgeng777 edited a comment on pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#issuecomment-1085896373
> Looks good, one minor thing we still need to change is in the:
>
> `org.apache.flink.kubernetes.operator.config.Mode` logic.
>
> We need
bgeng777 commented on pull request #131:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/131#issuecomment-1085896373
> Looks good, one minor thing we still need to change is in the:
>
> `org.apache.flink.kubernetes.operator.config.Mode` logic.
>
> We need to
Aitozi commented on pull request #145:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/145#issuecomment-1085894903
pls take a look cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Aitozi commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r840578430
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##
gyfora commented on a change in pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#discussion_r840577763
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##
Aitozi opened a new pull request #145:
URL: https://github.com/apache/flink-kubernetes-operator/pull/145
When I test session cluster, I found that it will always start twice for the
session cluster. I think this fix should be included in the release-0.1
--
This is an automated message
Aitozi edited a comment on pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#issuecomment-1085875740
OK, I will push a next commit to fix the @wangyang0918's recent comments
about the event source and will solve the conflicts at the same time and will
Aitozi commented on pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#issuecomment-1085875740
OK, I will push a next commit to fix the @wangyang0918's recent comments
about the event source and will solve the conficts at the same time
--
This is an
gyfora commented on pull request #112:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/112#issuecomment-1085828791
I think we should try to merge this PR early next week, @Aitozi please
coordinate with @bgeng777 and @SteNicholas regarding the other outstanding PRs
Aitozi closed pull request #144:
URL: https://github.com/apache/flink-kubernetes-operator/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Aitozi opened a new pull request #144:
URL: https://github.com/apache/flink-kubernetes-operator/pull/144
…ing a namespace
A fix to the getSecondaryResource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
SteNicholas edited a comment on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085628099
> What I am thinking is to add a default value for
`execution.checkpointing.interval` when HA enabled. It could be overridden by
user specified CR
gyfora commented on a change in pull request #141:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r840412092
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@
wangyang0918 edited a comment on pull request #139:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/139#issuecomment-1085605936
> for the jobs that enable the checkpoint via
StreamExecutionEnvironment.enableCheckpointing(), we could guide the user to
use the configuration
wangyang0918 commented on a change in pull request #141:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/141#discussion_r840390336
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/OperatorConfigOptions.java
##
@@
1 - 100 of 1550 matches
Mail list logo
