On 2/3/15 4:01 PM, Brent Christian wrote:
The code in bug 8071667 [1] passes a mappingFunction to computeIfAbsent() which
itself put()s a sufficient number of additional entries into the HashMap to
cause a resize/rehash. As a result, computeIfAbsent() doesn't add the new entry
at the proper
Hi,
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071600-Collector-flatMapping/webrev/
This patch adds a new flat mapping collector to Collectors. This can be useful
if one needs to map 0 or more items into a downstream collector.
A CCC will be filed.
A following patch, which i plan to fold
Hi,
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8071670-Optional-ifPresentOrElse/webrev/
Here is another tweak to Optional (and primitives) that has some weight:
/**
* If a value is present, perform the given action with the value,
* otherwise perform the given empty-based action.
*
*
Hi Deven,
On 02/03/2015 08:42 AM, deven you wrote:
Hi Sean,
The performance degradation was reported by creating an object with always
getting its canonical path and there is no degradation heard after we made
the lazy load patch for the canonical path.
I have asked related people to give me
On 02/02/2015 21:06, Martin Buchholz wrote:
:
The historic spec allows for both SecurityException and IOException (but
not UOE).
Locked-down systems typically (but not necessarily) have a SecurityManager
that helps enforce the restrictions and so SecurityException seems vaguely
appropriate.
Hi Roger,
Did you mean to put the @Test annotation on the class itself?
Also for the test_valueOf test, I would also add the same comment style to it
as it is the only one missing a comment
I think you meant to have test_outofrange uses the values from invalidEras
array (though I would use a
Hi Mandy,
I added a test for the invalid Eras.
I do expect the additional conformance tests from the JCK team but this
will synchronize with the fix.
Webrev updated in place:
http://cr.openjdk.java.net/~rriggs/webrev-era-8068278/
Thanks, Roger
On 1/30/2015 6:48 PM, Mandy Chung wrote:
On
Can't say I've used isPresent() much, as map()/flatMap()/orElse() take
care of most use cases.
What is an issue is that the primitive optional classes do not have
ofNullable(), filter(), map() or flatMap(). It seems odd to be adding
an additional new method to the primitive optional classes
On Feb 3, 2015, at 4:47 PM, Stephen Colebourne scolebou...@joda.org wrote:
Can't say I've used isPresent() much, as map()/flatMap()/orElse() take
care of most use cases.
Yes, i suspect terminal action-based processing is less used than value
transformation.
What is an issue is that the
Looks good to me.
regards,
Sean.
On 03/02/2015 15:59, Aleksej Efimov wrote:
Hi,
Could I have a review the latest tzdata2015a integration fix to JDK9,
please. The regression tests run and JPRT testing (jdk_other,jdk_util,
jdk_text, jdk_time test sets) shows no TZ related JDK9 failures.
Hi,
Could I have a review the latest tzdata2015a integration fix to JDK9,
please. The regression tests run and JPRT testing (jdk_other,jdk_util,
jdk_text, jdk_time test sets) shows no TZ related JDK9 failures.
Thank you,
Aleksej
Bug link: https://bugs.openjdk.java.net/browse/JDK-8072042
Hi Lance,
Ok, 2nd try.
http://cr.openjdk.java.net/~rriggs/webrev-era-8068278/
On 2/3/2015 11:21 AM, Lance Andersen wrote:
Hi Roger,
Did you mean to put the @Test annotation on the class itself?
It is redundant with the @Test on individual methods but harmless and
was there previously.
Hello,
The looks good.
On 03.02.2015 3:38, Kumar Srinivasan wrote:
Hi,
Appreciate a review of this fix for JNI correctness when dealing with
Splash Screen
on MacOSX.
http://cr.openjdk.java.net/~ksrini/8068033/webrev.0/
Sergey, I think you took over from Anthony Petrov for SplashScreen, if
Hi Peter,
On 2 Feb 2015, at 11:16, Peter Firmstone peter.firmst...@zeus.net.au wrote:
As mentioned I've been experimenting with an invariant validating
ObjectInputStream, that's backward and forward compatible with Java's Object
Serialization stream protocol.
No changes have been made to
On 2 Feb 2015, at 11:36, Paul Sandoz paul.san...@oracle.com wrote:
...
This was a nasty race. In fact there is no guarantee that the CF, that sets
the AtomicReference would even complete, without join/get, right ?
I think the async completion of the thenComposed task will trigger (in the
Hi Roger,
Thank you. Ship it.
Best
Lance
On Feb 3, 2015, at 11:59 AM, Roger Riggs roger.ri...@oracle.com wrote:
Hi Lance,
Ok, 2nd try.
http://cr.openjdk.java.net/~rriggs/webrev-era-8068278/
On 2/3/2015 11:21 AM, Lance Andersen wrote:
Hi Roger,
Did you mean to put the @Test
On 2/3/15 8:59 AM, Roger Riggs wrote:
Ok, 2nd try.
http://cr.openjdk.java.net/~rriggs/webrev-era-8068278/
Looks good. Thanks for adding the regression test.
Mandy
Hi,
On 03 Feb 2015, at 10:15, Staffan Larsen staffan.lar...@oracle.com wrote:
Hi,
Please review this patch for hiding the lambda proxy frame in stack traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/
This is a
I agree that we should not be throwing SecurityException. We should be
throwing IOException.
But given a choice between SecurityException and
UnsupportedOperationException, I would regard the former as the lesser of
two evils.
On Tue, Feb 3, 2015 at 12:40 AM, Alan Bateman
Please review this specification clarification of the range of Hijrah
calendar variants.
The issue was exposed by a bug in the HijrahChronology.isLeapYear method.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-leap-year-8067800/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8067800
+1
On Feb 3, 2015, at 3:45 PM, Roger Riggs roger.ri...@oracle.com wrote:
Please review this specification clarification of the range of Hijrah
calendar variants.
The issue was exposed by a bug in the HijrahChronology.isLeapYear method.
Webrev:
Hi,
The code in bug 8071667 [1] passes a mappingFunction to
computeIfAbsent() which itself put()s a sufficient number of additional
entries into the HashMap to cause a resize/rehash. As a result,
computeIfAbsent() doesn't add the new entry at the proper place in the
HashMap.
While one
-1
As I indicated on JIRA, I don't believe that this change meets the
spec or intent of the definition on Chronology. That is specified to
not throw any exceptions and to handle all years, valid or not.
I don't foresee any significant issue where a year is not validated by
this method. Years out
Hi,
Please review this patch for hiding the lambda proxy frame in stack traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
https://bugs.openjdk.java.net/browse/JDK-8025636
webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/
http://cr.openjdk.java.net/~sla/8025636/webrev.00/
Looks good for me.
Rémi
Le 3 février 2015 10:15:24 CET, Staffan Larsen staffan.lar...@oracle.com a
écrit :
Hi,
Please review this patch for hiding the lambda proxy frame in stack
traces:
bug: https://bugs.openjdk.java.net/browse/JDK-8025636
https://bugs.openjdk.java.net/browse/JDK-8025636
25 matches
Mail list logo
