On Mon, 11 Dec 2023 15:17:49 GMT, Adam Sotona wrote:
> ClassFile API models and parses signatures, however parsing of the signatures
> mostly throws IIOBE when it fails.
> This patch improves SignaturesImpl parsing methods implementation and errors
> handling and adds relevant ne
On Tue, 2 Jan 2024 07:17:46 GMT, Jaikiran Pai wrote:
> I'm guessing you have intentionally not included the original
> `IndexOutOfBoundsException` as a cause in the `IllegalArgumentException` that
> gets thrown.
Yes, original exception does not contain any meaningful information.
> Also, it
tures validator yet, however this is a
> step forward to it.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright year
-
Changes:
- all: https://git
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Thu, 21 Dec 2023 12:01:25 GMT, Sergey Tsypanov wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - performance improvements
>> - SplitConstantPool performance fix
>
> src/
On Thu, 21 Dec 2023 01:12:07 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes.
>>
>> This patch converts it to use Classfile API.
>>
>> It is continuation of https://github.com/openjd
On Wed, 20 Dec 2023 20:39:55 GMT, Mandy Chung wrote:
> Can you include the performance comparison before and after this change and
> what performance benchmarks you run?
I've run two batches on Aurora with mixed results (linked to
[JDK-8294960](https://bugs.openjdk.org/browse/JDK-8294960)):
On Thu, 21 Dec 2023 01:12:07 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes.
>>
>> This patch converts it to use Classfile API.
>>
>> It is continuation of https://github.com/openjd
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Tue, 19 Dec 2023 20:45:58 GMT, Mandy Chung wrote:
> Can you include a summary of the performance comparison before and after the
> patch per the
> [comment](https://github.com/openjdk/jdk/pull/10991#pullrequestreview-1333426016)
> in #10991.
I've found significant performance regressions
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Sat, 16 Dec 2023 15:54:57 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLamb
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: liach <7806504+li...@users.noreply.github.com>
-
Chang
On Sat, 16 Dec 2023 16:53:26 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java lin
On Sat, 16 Dec 2023 16:49:26 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/MethodHand
On Sat, 16 Dec 2023 16:42:09 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytec
On Sat, 16 Dec 2023 16:37:16 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply suggestions from code review
>>
>> Co-authored-by: liach <7806504+
On Sat, 16 Dec 2023 16:32:23 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytec
On Sat, 16 Dec 2023 16:12:05 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InvokerBytec
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: liach <7806504+li...@users.noreply.github.com>
-
Chang
java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
This patch converts it to use Classfile API.
It is continuation of https://github.com/openjdk/jdk/pull/10991
Any comments and suggestions are welcome.
Please review.
Thank you,
Adam
-
Commit messages:
On Fri, 15 Dec 2023 12:27:16 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLamb
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added missing comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17108/files
- new: https://git.op
java.base java.lang.invoke package heavily uses ASM to generate lambdas and
method handles.
This patch converts ASM calls to Classfile API.
This PR is continuation of https://github.com/openjdk/jdk/pull/12945
Any comments and suggestions are welcome.
Please review.
Thank you,
Adam
On Thu, 7 Dec 2023 07:53:58 GMT, Adam Sotona wrote:
>> ClassFile API throws `IndexOutOfBoundsException` when classfile structure is
>> corrupted so the parser attempts to read beyond the classfile bounds.
>> General contract is that only `IllegalArgumentException`
On Mon, 11 Dec 2023 10:19:52 GMT, Adam Sotona wrote:
> 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec
> contains a copy-paste error
This pull request has now been integrated.
Changeset: a55e18ba
Author: Adam Sotona
URL:
https://git.openjdk.org
ClassFile API models and parses signatures, however parsing of the signatures
mostly throws IIOBE when it fails.
This patch improves SignaturesImpl parsing methods implementation and errors
handling and adds relevant negative tests.
The parser is not an ultimate signatures validator yet, however
8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion spec
contains a copy-paste error
-
Commit messages:
- Backport 3c6459e1de9e75898a1b32a95acf684050fbe1af
Changes: https://git.openjdk.org/jdk22/pull/5/files
Webrev:
On Mon, 11 Dec 2023 10:00:45 GMT, Adam Sotona wrote:
> This is a fix of ClassFile
> ModuleAttribute.ModuleAttributeBuilder::moduleVersion javadoc copy-paste
> error.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 3c6459e
This is a fix of ClassFile
ModuleAttribute.ModuleAttributeBuilder::moduleVersion javadoc copy-paste error.
Please review.
Thanks,
Adam
-
Commit messages:
- 8321641: ClassFile ModuleAttribute.ModuleAttributeBuilder::moduleVersion
spec contains a copy-paste error
Changes:
his patch wraps `IndexOutOfBoundsExceptions` thrown from all
> `ClassReaderImpl.buffer` manipulations into an
> `IllegalArgumentException("Reading beyond classfile bounds", iOOBECause)`.
> Relevant tests are added.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has up
On Wed, 6 Dec 2023 10:40:51 GMT, Adam Sotona wrote:
>> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an
>> optional argument and does not respect
>> `ClassFile.ClassHierarchyResolverOption` of the actual context.
>> Parsing, building and transf
On Mon, 4 Dec 2023 11:12:37 GMT, Adam Sotona wrote:
> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an
> optional argument and does not respect
> `ClassFile.ClassHierarchyResolverOption` of the actual context.
> Parsing, building and transforming take
gt;
> Impact of the API change is minimal as the API has not been released yet.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
reverted modified test
-
Changes:
- all:
On Wed, 6 Dec 2023 09:42:49 GMT, Adam Sotona wrote:
>> test/jdk/jdk/classfile/VerifierSelfTest.java line 62:
>>
>>> 60:
>>> 61: @Test
>>> 62: void testFailedDump() throws IOException {
>>
>> Why is this removed?
>
> Dump (p
On Wed, 6 Dec 2023 09:26:29 GMT, Maurizio Cimadamore
wrote:
>> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an
>> optional argument and does not respect
>> `ClassFile.ClassHierarchyResolverOption` of the actual context.
>> Parsing, building and transforming take
ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an
optional argument and does not respect `ClassFile.ClassHierarchyResolverOption`
of the actual context.
Parsing, building and transforming take options from the actual `ClassFile`
context and verification should follow the
On Wed, 13 Sep 2023 09:48:00 GMT, Adam Sotona wrote:
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote:
>> This is explicit list of supported class file versions, so I don't see any
>> other way.
>
> Would it not be possible to expose an immutable `Map` that
> maps from Java version to major class version?
This is actually out of scope of
On Tue, 28 Nov 2023 10:21:25 GMT, Per Minborg wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed SwitchBootstrapTest
>
> src/java.base/share/classes/java/lang/classfile/ClassFile
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated t
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Thu, 23 Nov 2023 11:52:05 GMT, Adam Sotona wrote:
> ClassFile API StackMapGenerator caused a NPE for a test case with invalid
> sequence of instructions.
> This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack
>
> Please review.
>
> Thanks,
>
ClassFile API StackMapGenerator caused a NPE for a test case with invalid
sequence of instructions.
This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack
Please review.
Thanks,
Adam
-
Commit messages:
- 8320618: NPE: Cannot invoke
ClassFile API throws `IndexOutOfBoundsException` when classfile structure is
corrupted so the parser attempts to read beyond the classfile bounds.
General contract is that only `IllegalArgumentException` or its subclasses is
expected when parser fails.
This patch wraps
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Thu, 16 Nov 2023 10:00:44 GMT, Adam Sotona wrote:
> Stack map generator in ClassFile API performs only minimal checks in favour
> of performance.
> However it led to situations where it generates invalid stack maps for
> corrupted code.
> This patch adds basic checks of
On Thu, 2 Nov 2023 13:49:17 GMT, Adam Sotona wrote:
> Javap ignores --system option when searching for JDK classes.
> This patch prepends search over JDK system modules.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: 604
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has update
On Thu, 16 Nov 2023 11:25:07 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changed StackMapGenerator::generatorError to return an exception instead
>> of directly
exception in case of stack size or content mismatch. Generated or
> transformed code with inconsistent stack will fail on stack maps generation.
> Relevant tests are added.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one add
Stack map generator in ClassFile API performs only minimal checks in favour of
performance.
However it led to situations where it generates invalid stack maps for
corrupted code.
This patch adds basic checks of stack when two frames are merged and throws an
exception in case of stack size or
> Javap ignores --system option when searching for JDK classes.
> This patch prepends search over JDK system modules.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
appl
On Fri, 10 Nov 2023 07:28:30 GMT, Jan Lahoda wrote:
> Is there a chance for a jtreg test?
Unfortunately I haven't found a simple way to include a different JDK as
`--system` for the test.
Any suggestions are welcome.
-
PR Comment:
On Fri, 10 Nov 2023 07:25:45 GMT, Jan Lahoda wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Skip search over JDK modules for classes in unnamed package (mainly to
>> skip JDK module-
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Wed, 8 Nov 2023 17:10:11 GMT, Mandy Chung wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to
On Wed, 8 Nov 2023 15:22:54 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 360 commits:
>>
>> - fixed condy tests
>> - Merge branch 'master' into JDK-8308
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has upda
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Tue, 7 Nov 2023 18:56:07 GMT, Mourad Abbay wrote:
>> early experimental version of the bytecode library is bundled under:
>> test/jdk/lib/testlibrary/bytecode
>>
>> following tests reference it:
>> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
>>
On Wed, 8 Nov 2023 12:14:09 GMT, Mourad Abbay wrote:
>> `` is not a valid name for dynamic constant.
>
> You can see `java.lang.constant.ConstantUtils.validateMemberName`
So how is it possible that `testValidNames` has been passing with the name?
Conversion should not change the tested
On Tue, 7 Nov 2023 18:56:07 GMT, Mourad Abbay wrote:
>> early experimental version of the bytecode library is bundled under:
>> test/jdk/lib/testlibrary/bytecode
>>
>> following tests reference it:
>> test/jdk/java/lang/invoke/common/test/java/lang/invoke/lib/InstructionHelper.java
>>
On Mon, 6 Nov 2023 06:00:20 GMT, Chen Liang wrote:
> Observed this erroneous implementation while browsing, and included a quick
> test against javac output class file to confirm the correct implementation.
> @asotona Please take a look.
Good catch, thanks for the fix.
-
Marked
On Fri, 3 Nov 2023 08:41:12 GMT, Jan Lahoda wrote:
> Consider code like:
>
> void test(Object o) {
> switch (o) {
> case X1 -> {}
> case X2 -> {}
> ...(about 100 cases)
> ```
>
> javac will compile the switch into a switch whose selector is an indy
> invocation to
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
> Javap ignores --system option when searching for JDK classes.
> This patch prepends search over JDK system modules.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Skip se
Javap ignores --system option when searching for JDK classes.
This patch prepends search over JDK system modules.
Please review.
Thanks,
Adam
-
Commit messages:
- 8304446: javap --system flag doesn't override system APIs
Changes: https://git.openjdk.org/jdk/pull/16476/files
On Tue, 31 Oct 2023 16:08:54 GMT, Alan Bateman wrote:
>> JImageValidator has been recently converted to use ClassFile API and
>> original weak validation of class files was replaced with full class
>> verification.
>> Unfortunately full class verification is too strong as it includes class
>>
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it inclu
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has upda
On Thu, 12 Oct 2023 11:11:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> src/java.base/sha
On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> make/test/BuildMicrob
On Tue, 10 Oct 2023 14:46:32 GMT, Chen Liang wrote:
> We need to remove the outdated exports in `BuildMicroBenchmarks.gmk` after
> the package migration.
Removed, good catch, thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15706#issuecomment-1756993662
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
JImageValidator has been recently converted to use ClassFile API and original
weak validation of class files was replaced with full class verification.
Unfortunately full class verification is too strong as it includes class
assignability verification according to class hierarchy resolution.
On Wed, 11 Oct 2023 05:44:42 GMT, Chen Liang wrote:
> Maybe we can consider moving verify to Class-File object for a new RFE?
Yes, that would be appropriate.
-
PR Comment: https://git.openjdk.org/jdk/pull/16123#issuecomment-1756874646
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has update
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated t
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has up
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
On Tue, 3 Oct 2023 18:55:36 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fixed case in the test text
>> - fixing javadoc
>> - Unified implementation
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona ha
On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/classfiles/attributes/SourceF
On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 13:54:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 13:50:56 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java
>> line 67:
>>
>>> 65:
>>> 66: /**
>>> 67: * {@return for an {@code invokeinterface}, the {@code count}
>>> value, as defined in {@jvms
le API is based on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
301 - 400 of 1034 matches
Mail list logo
