> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
8308646: Typo in ConstantValueAttribute
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openj
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- fixed String format arguments
- Classfile API javadoc make patch
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- Merge pull request #1 from liachmodded/fix/sotona-cf-obj-improvements
Changes discussed on mailing list plus minor doc error
- Change
On Fri, 23 Jun 2023 09:05:21 GMT, Andrey Turbanov wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete javadoc from implementation classes
>
> src/java.base/share/
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: liach <7806504+li...@users.noreply.github.com>
-
Changes:
- all:
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
ClassfileBenchmark::transformWithNewMaps changed to transformWithAddedNOP
-
Changes:
- all: https://git.openjdk.org/jdk/pull
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
ClassfileBenchmark minor fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openjdk.org/jd
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added new ClassfileBenchmark
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openjdk.org/jd
On Thu, 1 Jun 2023 19:25:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 55:
>>
>>> 53:
>>> 54: static Classfile of() {
>>> 55: return new ClassfileImpl();
>>
>> We can cre
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
static instance of default Classfile context
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Classfile.StackMapsOption names change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openj
On Tue, 13 Jun 2023 09:34:17 GMT, Chen Liang wrote:
>StackMapsOption doesn't fit in with other options, they should be
>ALWAYS_STACK_MAPS, NEVER_STACK_MAPS, etc.)
What about `STACK_MAPS_WHEN_REQUIRED`, `GENERATE_STACK_MAPS` and
`DROP_STACK_MAPS`?
-
PR Comment:
On Tue, 13 Jun 2023 11:32:59 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
On Tue, 13 Jun 2023 09:15:13 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ClassHierarchyResolver.DEFAULT_RESOLVER gets info from system class loader
>> and do
On Tue, 13 Jun 2023 09:19:00 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 38 commits:
>>
>> - Merge branch 'master' into JDK-8308
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
ClassHierarchyResolver.DEFAULT_RESOLVER gets info from system class loader
and does not cache
method-level caching is enabled if the provi
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 40 commits:
- performance fix
- Merge branch 'master' into JDK-8308899-context
- Merge branch 'master' into JD
On Mon, 12 Jun 2023 09:45:18 GMT, Chen Liang wrote:
> Thanks to @exe-boss for the reviews in #13082. This cleanup patch fixed the
> typos you pointed out and removed other redundancies in classfile Util as
> well.
It looks good
-
Marked as reviewed by asotona (Reviewer).
PR
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 38 commits:
- Merge branch 'master' into JDK-8308899-context
- Revert of DirectCodeBuilder.needsStackMap pre-cal
On Mon, 12 Jun 2023 11:20:40 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- Revert "removal of ClassHierarchyImpl.DEFAULT_RESOLVER"
esolver.java
- Revert "proposed semi-synchronized caching, where t
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed StackMapsOption dispatching in DirectCodeBuilder
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new:
From: kulla-dev on behalf of Brian Goetz
> I think there's something fishy going on.
Yes, transformation lambdas become significantly slower when moved from
ClassModel to Classfile (unless I missed anything else).
I’ll do some experiments to get the performance back.
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
To: Adam Sotona , core-libs-dev@openjdk.org
, kulla-...@openjdk.org
Subject: Re: RFR: 8308899: Introduce Classfile.Context and improve
Classfile.Option(s) [v9]
I still don't understand this point. Why are separate tests sharing a context
at all?
On 6/8/2023 9:26 AM, Adam Sotona wrote:
Unfortunately
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
On Thu, 8 Jun 2023 16:35:28 GMT, Brian Goetz wrote:
> I have a hard time imagining heavy parallel use here; concurrency against the
> same cache would most likely come from accidental sharing. So this is not
> necessarily a problem. Are you imagining differnet use cases?
I think it is
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- proposed semi-synchronized caching, where the map is not locked during
delegate call
- used Factory.INSTANCE for system C
On Thu, 8 Jun 2023 14:07:24 GMT, Brian Goetz wrote:
> Here are a few options:
- Make the CHA cache thread-safe using, say, CHM;
This is current solution for the default system CH cache.
We may also use a bit less strict custom semi-synchronization (just enough to
be thread safe) instead
f one
method.
On 6/8/2023 9:24 AM, Adam Sotona wrote:
>
> Unfortunately thread-unsafe context makes sharing of it in tests
> executed in parallel a nightmare.
> I can fix our Corpus tests and hope the race condition won't raise
> also somewhere else later.
> However how to e
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Revert "ClassHierarchyResolver::ofSystem is now thread-unsafe"
This reverts commit f3099cd5b252924392995bf65edc710c27822d2b.
-
On Thu, 8 Jun 2023 11:26:39 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixe
On Thu, 8 Jun 2023 11:07:21 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - removal of ClassHierarchyImpl.DEFAULT_RESOLVER
>>introduc
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
ClassHierarchyResolver::ofSystem is now thread-unsafe
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new:
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 29 commits:
- removal of ClassHierarchyImpl.DEFAULT_RESOLVER
introduction of ClassHierarchyResolver::ofSystem factory method
On Wed, 7 Jun 2023 14:15:10 GMT, Chen Liang wrote:
>> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
>> proper privileges, with tests.
>>
>> This addition is useful in case classes at runtime are not loaded from the
>> system class loader, such as Proxy. This is
On Fri, 2 Jun 2023 03:36:35 GMT, Chen Liang wrote:
>> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
>> proper privileges, with tests.
>>
>> This addition is useful in case classes at runtime are not loaded from the
>> system class loader, such as Proxy. This is
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The p
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 27 commits:
- Merge branch 'master' into JDK-8308899-context
# Conflicts:
#src/java.base/share/classes/jdk/intern
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
On Mon, 5 Jun 2023 15:14:35 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.jav
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- added missing javadoc
- simplified options names
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https
On Mon, 5 Jun 2023 16:30:16 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/constan
onstant poll or not).
>
> Newly introduced `ConstantPoolException` extends `IllegalArgumentException`
> to indicate the source of the problem is in constant pool.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one a
onstant poll or not).
>
> Newly introduced `ConstantPoolException` extends `IllegalArgumentException`
> to indicate the source of the problem is in constant pool.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one add
On Mon, 5 Jun 2023 15:03:01 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three addi
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed copyright header
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openjdk.org/jd
onstant poll or not).
>
> Newly introduced `ConstantPoolException` extends `IllegalArgumentException`
> to indicate the source of the problem is in constant pool.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 23 additional commits since the
last revisio
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 22 additional commits since the
last revision:
On Thu, 1 Jun 2023 19:23:05 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/Module.java line 1593:
>>
>>> 1591: private Class loadModuleInfoClass(InputStream in) throws
>>> IOException {
>>> 1592: final String MODULE_INFO =
On Thu, 1 Jun 2023 15:14:52 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed benchmarks
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerat
On Thu, 1 Jun 2023 15:04:00 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed benchmarks
>
> src/java.base/share/classes/java/lang/Module.java line 1593:
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed benchmarks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14180/files
- new: https://git.openjdk.org/jdk/pull/141
Classfile context object and multi-state options have been discussed at
https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
This patch implements the proposed changes in Classfile API and fixes all
affected code across JDK sources and tests.
Please review.
Thanks,
Adam
On Wed, 31 May 2023 05:42:58 GMT, Chen Liang wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Thu, 25 May 2023 12:24:59 GMT, Adam Sotona wrote:
> Fix of jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo returning correct
> zero power of two.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: a6109bf1
Author
> Fix of jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo returning correct
> zero power of two.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.b
On Thu, 25 May 2023 22:45:01 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc
>
> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 38
onstant poll or not).
>
> Newly introduced `ConstantPoolException` extends `IllegalArgumentException`
> to indicate the source of the problem is in constant pool.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one add
Fix of jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo returning correct
zero power of two.
Please review.
Thanks,
Adam
-
Commit messages:
- 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem
Changes: https://git.openjdk.org/jdk/pull/14148/files
Class-File API actually throws wide variety of exceptions based on the actual
situation. Complete error handling code must cover `IndexOutOfBoundsException`,
`IllegalStateException` and `IllegalArgumentException`.
Based on previous discussions we decided to consolidate on
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The p
On Tue, 23 May 2023 12:54:20 GMT, Adam Sotona wrote:
> Classfile API allowed to generate Code attribute exceeding the 65k limit. No
> exception has been thrown during class generation and the class failed
> verification later during class loading.
> This patch adds Code size
ass
> verification process.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added check for empty Code + test
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Wed, 24 May 2023 12:04:05 GMT, Jaikiran Pai wrote:
>> Classfile API allowed to generate Code attribute exceeding the 65k limit. No
>> exception has been thrown during class generation and the class failed
>> verification later during class loading.
>> This patch adds Code size limit check
On Tue, 23 May 2023 15:13:04 GMT, Chen Liang wrote:
> On a side note, does Classfile API reject methods with too many slots
> (locals) (MethodTypeDesc can represent parameter lists with over 255 slots)
> or stack (operand)?
Classfile API does not perform any extra verifications of
Classfile API allowed to generate Code attribute exceeding the 65k limit. No
exception has been thrown during class generation and the class failed
verification later during class loading.
This patch adds Code size limit check throwing IllegalArgumentException.
The patch also adds similar check
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All r
This patch disables temporary use of language preview features in JDK.
Temporary enabled language preview features (to allow Pattern Matching for
switch use in the Classfile API library) are no more necessary.
All redundant use of --enable-preview in the Classfile API tests are also
removed.
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to
On Fri, 19 May 2023 12:35:47 GMT, Alan Bateman wrote:
>> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
>> compilation on windows.
>> Unfortunately MSVC does not support variable length arrays.
>> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
On Fri, 19 May 2023 13:01:37 GMT, Adam Sotona wrote:
>> test/jdk/tools/launcher/exeJliLaunchTest.c line 39:
>>
>>> 37: {
>>> 38: //avoid null-terminated array of arguments to test JDK-8303669
>>> 39: char **argv = malloc(sizeof(char *) * a
JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
compilation on windows.
Unfortunately MSVC does not support variable length arrays.
This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
array allocation.
Please review.
Thanks,
Adam
-
On Wed, 3 May 2023 12:03:34 GMT, Adam Sotona wrote:
> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
> in some circumstances an instead checks if *argv == 0 in its while loop,
> which results in a segmentation fault if the provided array is not NULL
>
On Thu, 4 May 2023 09:17:05 GMT, Adam Sotona wrote:
>> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
>> in some circumstances an instead checks if *argv == 0 in its while loop,
>> which results in a segmentation fault if the provided
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
removed obsolete exports
-
Changes:
- all: https://git.openj
On Wed, 26 Apr 2023 15:04:50 GMT, Adam Sotona wrote:
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEn
On Wed, 17 May 2023 13:42:32 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 34 commits:
>>
>> - Merge branch 'master' into JDK-8306842-perf-improvements
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 34 commits:
- Merge branch 'master' into JDK-8306842-perf-impro
On Tue, 16 May 2023 22:00:18 GMT, Claes Redestad wrote:
>> I plan to share a backing list in #13186, with API additions so users can
>> avoid copying their input immutable parameter list as well. I see no reason
>> to use a direct array, for MTD is not passed to and used by the VM, unlike
>>
On Tue, 16 May 2023 18:10:08 GMT, Chen Liang wrote:
>> The jdk.internal.classfile.components package's interfaces have
>> implementations in their nested classes, which are implicitly public and
>> exported with the package. They are now moved to the impl package to avoid
>> unwanted
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> Al
On Mon, 15 May 2023 19:06:16 GMT, Glavo wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - changed LinkedList to ArrayList in RebuildMethodBodies benchmark
>> - added RepeatedModelTr
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
LinkedList replaced with ArrayList in benchmarks
-
Changes:
- all:
On Mon, 15 May 2023 17:04:54 GMT, Claes Redestad wrote:
>> I'm not questioning performance differences between list implementations.
>> The implementation of top level list for this benchmark is irrelevant
>> because ~10ns difference cannot affect ~100µs benchmark run.
>
> Fair point. The only
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: Andrey Turbanov
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- changed LinkedList to ArrayList in RebuildMethodBodies benchmark
- a
On Mon, 15 May 2023 13:42:05 GMT, Claes Redestad wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 57:
>>
>>> 55: public void setup() throws IOException {
>>> 56: shared = new LinkedList<>();
>>> 57: unshared = new LinkedList<>();
>>
>>
On Fri, 12 May 2023 13:19:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed jmh benchmark parameters
>
> test/micro/org/openjdk/bench/jdk/classfile/RebuildMetho
On Sat, 13 May 2023 14:11:11 GMT, Chen Liang wrote:
>> The jdk.internal.classfile.components package's interfaces have
>> implementations in their nested classes, which are implicitly public and
>> exported with the package. They are now moved to the impl package to avoid
>> unwanted
Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc` and
`PackageDesc` become obsolete after
[JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
All references to `jdk.internal.classfile.java.lang.constant.ModuleDesc` and
On Tue, 17 Jan 2023 15:55:40 GMT, Jan Lahoda wrote:
>> The pattern matching switches are using a bootstrap method
>> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch.
>> Basically, for a switch like:
>>
>> switch (obj) {
>> case String s when s.isEmpty() -> {}
>> case
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed jmh benchmark parameters
-
Changes:
- all: https://git.openj
On Tue, 9 May 2023 16:15:27 GMT, Claes Redestad wrote:
>> They are added in the `make/RunTests.gmk`:
>> https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f059233R599-R608
>
> That seems misplaced. Please file an RFE to have this
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed StackMapGenerator
-
Changes:
- all: https://git.openjdk.org/jd
pt 4 13380.272 ± 810.113 ops/s
> RebuildMethodBodies.unshared thrpt 49399.863 ± 557.060 ops/s
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
Co-authored-by: liach <7806504+li...@use
On Tue, 9 May 2023 15:09:54 GMT, Chen Liang wrote:
>> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
>> proper privileges, with tests.
>>
>> This addition is useful in case classes at runtime are not loaded from the
>> system class loader, such as Proxy. This is
501 - 600 of 1034 matches
Mail list logo
