Re: [VOTE] Add Probot Integrations to Airflow Github Repo

It really quick! Thanks Jarek! Best Wish — Jiajie

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

It was quick :). Unfortunately mergable does not support commit checking, but I quickly implemented it in Kaxil's Awesome Boring Cyborg :). @Kaxil Naik -> Note that it requires new permission (Commit Status : read & write). From what I saw adding permissions is a bit misleading - after you updat

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Working on it :) On Mon, Jan 13, 2020 at 3:50 AM hotmail wrote: > I just found out some of our PR title have specific `AIRFLOW-` or > `AIRFLOW-\d{4}`, but git commit message don’t, such as > https://github.com/apache/airflow/pull/7144 < > https://github.com/apache/airflow/pull/7144>, Could w

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I just found out some of our PR title have specific `AIRFLOW-` or `AIRFLOW-\d{4}`, but git commit message don’t, such as https://github.com/apache/airflow/pull/7144 , Could we add some bot to check git commit message? Best Wish — Jiajie

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

The reason why we stopped using mention-bot was that it was a hosted instance that wasn't maintained anymore. I really liked the mention-bot :-) Cheers, Fokko Op zo 5 jan. 2020 om 09:56 schreef Jarek Potiuk : > 👍💟 > > On Sun, Jan 5, 2020 at 4:38 AM Kaxil Naik wrote: > > > I have created a Githu

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

👍💟 On Sun, Jan 5, 2020 at 4:38 AM Kaxil Naik wrote: > I have created a Github app using Probot: > https://github.com/kaxil/boring-cyborg. > > This is integrated with Airflow and we now have auto-labeling enabled based > on filepaths of the changes files in the PR. > > We can add more integration

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I have created a Github app using Probot: https://github.com/kaxil/boring-cyborg. This is integrated with Airflow and we now have auto-labeling enabled based on filepaths of the changes files in the PR. We can add more integrations iteratively in the "boring-cyborg" and automate other boring chor

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Those both are cool. Love them :). Why not use the periodic labeler workaround? It seems to do the trick and uses the same configuration and does not seem to have any negative side effects. I think auto-labelling our PRs would be a great step (together with working stale bot) towards making more

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

On digging further I found out that it is an open BUG on both the Github actions: Bug: https://github.com/actions/labeler/issues/12 or https://github.com/actions/first-interaction/issues/10 *Details*: Quoting the Author: Workflows are run in the context "of the repository". But when any wo

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I think I was wrong. We still need permission from INFRA to enable the GITHUB_TOKEN, I have raised an ISSUE with INFRA team: https://issues.apache.org/jira/browse/INFRA-19657 Apache Spark recently added a Github Action for Stable , hence I thought we won

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I tried some Github actions today and fell in love. We don't even need to ask for approval from INFRA team. I have raised 2 PRs: - https://github.com/apache/airflow/pull/7032 - Add Labels on PRs based on file/dir - https://github.com/apache/airflow/pull/7031 - Welcome First time contr

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Yeah the mention-bot was archived and is no longer maintained. On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek wrote: > Hi all, > > I just discovered that some time ago we already used "mention-bot" that > suggests > potential reviewers based on history of changed files: > https://github.com/apac

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Hi all, I just discovered that some time ago we already used "mention-bot" that suggests potential reviewers based on history of changed files: https://github.com/apache/airflow/pull/2558#issuecomment-326686092 T. On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk wrote: > On Wed, Jan 1, 2020 at 11:

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk wrote: > One thing I realized after using the 4 Probot Integrations is that some of >> the Probot apps are not actively maintained and might even be broken. >> > Yeah. Even if limited my search to only the "featured ones" seems like not all of them are

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Oh yeah. I forgot about the probot from Max -> Happy to contribute to it to add some of the functionality we might need :). On Wed, Jan 1, 2020 at 11:42 PM Kaxil Naik wrote: > I loved *mergeable*. > One thing I realized after using the 4 Probot Integrations is that some of > the Probot apps are

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I loved *mergeable*. One thing I realized after using the 4 Probot Integrations is that some of the Probot apps are not actively maintained and might even be broken. For example, *ci-reporter *didn't work for us and there are other users facing similar issues

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Yeah. we can remove commitlint from that list. I think Mergable is much better than commitlint looking at your recent configuration :) On Tue, Dec 31, 2019 at 2:14 PM Kaxil Naik wrote: > Once we have got all the configs for the current integrations, I will > review the ones you have provided in

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Once we have got all the configs for the current integrations, I will review the ones you have provided in the link above and see if it is achievable with the current ones or not. On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk wrote: > How about adding a few more apps ? I reviewed some probot ap

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

How about adding a few more apps ? I reviewed some probot apps and maybe we should consider those: - https://probot.github.io/apps/welcome/ - Welcomes new users submitting their PRs for the first time - https://probot.github.io/apps/reminders/ - Allows to set reminders for certain issu

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Yup. I am adding some configs. PRs coming in. On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk wrote: > Seems like we have a new friendly bot :) > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk > wrote: > > > I opened a few tickets for INFRA and I am also waiting for answer. I > guess > > Xmas per

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Seems like we have a new friendly bot :) On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk wrote: > I opened a few tickets for INFRA and I am also waiting for answer. I guess > Xmas period got in the way. > > J. > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang wrote: > >> +1! >> >> Kaxil Naik 于2019年12

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I opened a few tickets for INFRA and I am also waiting for answer. I guess Xmas period got in the way. J. On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang wrote: > +1! > > Kaxil Naik 于2019年12月29日 周日下午6:21写道： > > > Thanks Max, > > > > I will raise a JIRA with the INFRA to add that too. > > > > Btw I h

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1! Kaxil Naik 于2019年12月29日 周日下午6:21写道： > Thanks Max, > > I will raise a JIRA with the INFRA to add that too. > > Btw I had raised a request for the 4 integrations > https://issues.apache.org/jira/browse/INFRA-19607 but looks like it hasn't > gained any traction from them yet. > > > > On Fri, Dec

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Thanks Max, I will raise a JIRA with the INFRA to add that too. Btw I had raised a request for the 4 integrations https://issues.apache.org/jira/browse/INFRA-19607 but looks like it hasn't gained any traction from them yet. On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin < maximebeauche...@g

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1! I forgot whether I shared this before, but I wrote a probot for Apache Superset that does a few nice things, and we can grow over time to do more things without having to beg Apache Infra for anything (currently only them have admin rights and can register apps on our repos) https://github.com

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1 +1 (if I can vote XD) Best Bin On 2019/12/20 13:43:11, Felix Uellendall wrote: > +1 > > Sent from ProtonMail Mobile > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek > wrote: > > > +1 for all four. > > T. > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła > > wrote: > > > >> +1 > >

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1 Sent from ProtonMail Mobile On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek wrote: > +1 for all four. > T. > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła > wrote: > >> +1 >> >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk >> wrote: >> >> > +100 >> > >> > On Fri, Dec 20, 2019 at 7:02 AM

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1 for all four. T. On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła wrote: > +1 > > On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk > wrote: > > > +100 > > > > On Fri, Dec 20, 2019 at 7:02 AM hotmail > > wrote: > > > > > I think the ci-reporter is great, because ours CI log is tooo long > to >

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1 On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk wrote: > +100 > > On Fri, Dec 20, 2019 at 7:02 AM hotmail > wrote: > > > I think the ci-reporter is great, because ours CI log is tooo long to > > read, and I just want to know what unittest failed in my PR > > > > Best Wish > > — Jiajie > > >

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+100 On Fri, Dec 20, 2019 at 7:02 AM hotmail wrote: > I think the ci-reporter is great, because ours CI log is tooo long to > read, and I just want to know what unittest failed in my PR > > Best Wish > — Jiajie > > -- Jarek Potiuk Polidea | Principal Software En

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

I think the ci-reporter is great, because ours CI log is tooo long to read, and I just want to know what unittest failed in my PR Best Wish — Jiajie

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

Hi all I did some thinking about this and how we can improve the contribution process. Hadn't had a chance to draft that mail yet but some of it is relevant to probot so I'll just reply here :) I think we already have probot stale (at least, I saw some bot comments on older PRs). I'd suggest we

Re: [VOTE] Add Probot Integrations to Airflow Github Repo

+1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 +1 … Yes please. via Newton Mail [https://cloudmagic.com/k/d/mailapp?ct=dx&cv=10.0.32&pv=10.14.5&source=email_footer_2] On Thu, Dec 19, 2019 at 5:51 PM, Kaxil Naik wrote: Hello all, I would like to propose that w

[VOTE] Add Probot Integrations to Airflow Github Repo

Hello all, I would like to propose that we add the following ProBot integrations to Airflow repo: - https://github.com/apps/ci-reporter - Works with your project's CI tool to report failed builds into the relevant PR. - https://github.com/apps/mergeable - Prevents merging of Pull Request