ZooKeeper-less - single bookie setup

2017-07-26 Thread Enrico Olivelli
Hi, I would like to share this idea with you before starting a real design effort for this new configuration. Sometimes I have to run Bookie + BookKeeper inside the same JVM, essentially because I want my applications to run both in "cluster mode" and in "single instance mode". I have some other

[GitHub] eolivelli commented on issue #275: BOOKKEEPER-1102: Clarify BookieInfoReader and fix associated test flappers

2017-07-26 Thread git
eolivelli commented on issue #275: BOOKKEEPER-1102: Clarify BookieInfoReader and fix associated test flappers URL: https://github.com/apache/bookkeeper/pull/275#issuecomment-318245729 @athanatos could you address @sijie comments ? the patch is almost ready to go

[GitHub] eolivelli closed issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed

2017-07-26 Thread git
eolivelli closed issue #271: LedgerHandle#readEntries leaks ByteBufs if getEntry not called or getEntryInputStream() not called and closed URL: https://github.com/apache/bookkeeper/issues/271 This is an automated message

[GitHub] eolivelli closed pull request #276: Issue-271 LedgerHandle#readEntries leaks ByteBufs

2017-07-26 Thread git
eolivelli closed pull request #276: Issue-271 LedgerHandle#readEntries leaks ByteBufs URL: https://github.com/apache/bookkeeper/pull/276 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eolivelli commented on issue #297: Issue 296: Bookie supports ephemeral port

2017-07-26 Thread git
eolivelli commented on issue #297: Issue 296: Bookie supports ephemeral port URL: https://github.com/apache/bookkeeper/pull/297#issuecomment-318245171 @zhaijack @sijie In DL tests do you need non-loopback addresses ? Another approach can be to allow port=0 (and automatic choose) on

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743899 ## File path:

[GitHub] eolivelli commented on issue #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on issue #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#issuecomment-318244413 @sijie overall I am not very happy with this patch, as I told on the mailing list, addressing the

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743733 ## File path:

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743937 ## File path:

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743415 ## File path:

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743133 ## File path:

[GitHub] eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129743142 ## File path:

[GitHub] eolivelli opened a new pull request #309: Issue-308 LocalBookKeeper.java rethrow Exception in case of failed boot

2017-07-26 Thread git
eolivelli opened a new pull request #309: Issue-308 LocalBookKeeper.java rethrow Exception in case of failed boot URL: https://github.com/apache/bookkeeper/pull/309 Do not swallow generic Exceptions during the boot of LocalBookKeeper and let the caller handle errors

[GitHub] eolivelli commented on a change in pull request #307: Issue 306: Update SCM info for using mvn:release

2017-07-26 Thread git
eolivelli commented on a change in pull request #307: Issue 306: Update SCM info for using mvn:release URL: https://github.com/apache/bookkeeper/pull/307#discussion_r129741697 ## File path: pom.xml ## @@ -29,8 +29,30 @@ 4.5.0-SNAPSHOT bookkeeper pom - bookkeeper

[GitHub] eolivelli commented on a change in pull request #307: Issue 306: Update SCM info for using mvn:release

2017-07-26 Thread git
eolivelli commented on a change in pull request #307: Issue 306: Update SCM info for using mvn:release URL: https://github.com/apache/bookkeeper/pull/307#discussion_r129741709 ## File path: pom.xml ## @@ -29,8 +29,30 @@ 4.5.0-SNAPSHOT bookkeeper pom - bookkeeper

[GitHub] eolivelli commented on a change in pull request #110: BOOKKEEPER-391 Support Kerberos authentication of bookkeeper

2017-07-26 Thread git
eolivelli commented on a change in pull request #110: BOOKKEEPER-391 Support Kerberos authentication of bookkeeper URL: https://github.com/apache/bookkeeper/pull/110#discussion_r129741003 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SaslServerState.java

[jira] [Commented] (BOOKKEEPER-935) Publish sources and javadocs to Maven Central

2017-07-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102609#comment-16102609 ] Enrico Olivelli commented on BOOKKEEPER-935: [~hustlmsp] This is a good candidate for 4.5,

[jira] [Updated] (BOOKKEEPER-935) Publish sources and javadocs to Maven Central

2017-07-26 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated BOOKKEEPER-935: --- Fix Version/s: 4.5.0 > Publish sources and javadocs to Maven Central >

[GitHub] EronWright commented on a change in pull request #110: BOOKKEEPER-391 Support Kerberos authentication of bookkeeper

2017-07-26 Thread git
EronWright commented on a change in pull request #110: BOOKKEEPER-391 Support Kerberos authentication of bookkeeper URL: https://github.com/apache/bookkeeper/pull/110#discussion_r129738693 ## File path:

[GitHub] sijie opened a new pull request #307: Issue 306: Update SCM info for using mvn:release

2017-07-26 Thread git
sijie opened a new pull request #307: Issue 306: Update SCM info for using mvn:release URL: https://github.com/apache/bookkeeper/pull/307 Descriptions of the changes in this PR: - update the SCM info in the pom files, so that mvn:release is able to create release branch.

[GitHub] sijie opened a new issue #306: update scm information in pom files so we can use maven:release

2017-07-26 Thread git
sijie opened a new issue #306: update scm information in pom files so we can use maven:release URL: https://github.com/apache/bookkeeper/issues/306 This is part of #304 Problem: In order to fully use maven:release for generating the artifacts, we need to fill up the SCM

[GitHub] sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-318223491 @kishorekasi travis and jenkins failed to compile this pull request. I think a ';' is missing in ClientConfiguration. Can you take a look at

[GitHub] sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129728455 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ##

Re: [Discuss] Release DL 0.5.0

2017-07-26 Thread Jia Zhai
Thanks a lot for your help, Enrico :) On Thu, Jul 27, 2017 at 1:37 AM, Sijie Guo wrote: > Thank you, Enrico. > > It might be good to also /cc or /bcc the original mailing list. > > - Sijie > > On Wed, Jul 26, 2017 at 7:32 AM, Enrico Olivelli > wrote: >

[GitHub] sijie commented on issue #305: Issue 305: New Release Guide

2017-07-26 Thread git
sijie commented on issue #305: Issue 305: New Release Guide URL: https://github.com/apache/bookkeeper/pull/305#issuecomment-318213065 https://github.com/sijie/bookkeeper/blob/8ce5642396d11f810822097e448e610ac2e06353/docs/community/committer/release_guide.md Here is a link for easy

[GitHub] sijie commented on issue #304: Improve Release Process

2017-07-26 Thread git
sijie commented on issue #304: Improve Release Process URL: https://github.com/apache/bookkeeper/issues/304#issuecomment-318212264 /cc @jvrao This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie opened a new pull request #305: Issue 305: New Release Guide

2017-07-26 Thread git
sijie opened a new pull request #305: Issue 305: New Release Guide URL: https://github.com/apache/bookkeeper/pull/305 Descriptions of the changes in this PR: This is an attempt to improve the current release guide base on a few references :

[GitHub] sijie opened a new issue #304: Improve Release Guide

2017-07-26 Thread git
sijie opened a new issue #304: Improve Release Guide URL: https://github.com/apache/bookkeeper/issues/304 **Problem** Currently [release doc](https://cwiki.apache.org/confluence/display/BOOKKEEPER/Creating+a+release) is a bit out of date. Especially we are using both JIRA and

[GitHub] athanatos opened a new pull request #303: BOOKKEEPER-1103: Fix LedgerMetadataCreateTest random id loop

2017-07-26 Thread git
athanatos opened a new pull request #303: BOOKKEEPER-1103: Fix LedgerMetadataCreateTest random id loop URL: https://github.com/apache/bookkeeper/pull/303 The previous version would loop indefinitely upon collision. Signed-off-by: Samuel Just

[jira] [Created] (BOOKKEEPER-1103) LedgerMetadataCreateTest bug in ledger id generation causes intermittent hang

2017-07-26 Thread Samuel Just (JIRA)
Samuel Just created BOOKKEEPER-1103: --- Summary: LedgerMetadataCreateTest bug in ledger id generation causes intermittent hang Key: BOOKKEEPER-1103 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1103

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-26 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129701187 ## File path:

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-26 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129701207 ## File path: bookkeeper-server/pom.xml ## @@ -217,11 +217,21 @@ ${netty.version}

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-26 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129701215 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/http/ConfigurationService.java

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-26 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129701176 ## File path:

[GitHub] yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-26 Thread git
yzang commented on a change in pull request #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#discussion_r129701200 ## File path: bookkeeper-server/pom.xml ## @@ -217,11 +217,21 @@ ${netty.version}

[GitHub] yzang commented on issue #266: Issue 265: Add persistable bookie status

2017-07-26 Thread git
yzang commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-318173782 @sijie Yeah, I think this change LGTM. This is an automated message from the

Re: BookKeeper 4.5.0 performance regression ?

2017-07-26 Thread Enrico Olivelli
Any idea? What happens after the first checkpoint? It seems that the bookies starts to behave in a different way. I image that in a first phase all is in memory + journal and then in a second phase we start using the disk because the amount of data (index + ledger data) cannot be retained in

[GitHub] sijie commented on issue #266: Issue 265: Add persistable bookie status

2017-07-26 Thread git
sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-318164018 @yzang cool. I assume that would be future improvement, not related to this pull request. for this change, we will make this persistable bookie

Re: [DISCUSS] Slack Channel for BookKeeper

2017-07-26 Thread Sijie Guo
On Wed, Jul 26, 2017 at 3:50 AM, atracymartin wrote: > I am interested in learning more about the decision to merge DL into BK. > What will that look like, and when will it be available? What can I do to > help? > Thank you Martin. In short, DL (especially the core

[GitHub] yzang commented on issue #266: Issue 265: Add persistable bookie status

2017-07-26 Thread git
yzang commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-318156986 Yup, adding a flag to disable auto status transition sounds like a good idea to me.

Re: [DISCUSS] Slack Channel for BookKeeper

2017-07-26 Thread atracymartin
I am interested in learning more about the decision to merge DL into BK.   What will that look like, and when will it be available?  What can I do to help? Sent from my T-Mobile 4G LTE Device Original message From: Sijie Guo Date: 7/25/17 8:22 PM

[GitHub] kishorekasi commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-318147091 Sije, I have address your comments and posted a new commit. This was initially planned for 4.5. But, I will let you prioritize

[GitHub] sijie commented on issue #266: Issue 265: Add persistable bookie status

2017-07-26 Thread git
sijie commented on issue #266: Issue 265: Add persistable bookie status URL: https://github.com/apache/bookkeeper/pull/266#issuecomment-318145467 @yzang sorry for late response. I was suggesting the status in BookieStatus is comprised of two parts : one is persisted status read from

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129650838 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129651712 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129651443 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129655166 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129650665 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129651895 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129649515 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129651779 ## File path:

[GitHub] sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
sijie commented on a change in pull request #301: Issue-299 EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/pull/301#discussion_r129648828 ## File path:

[GitHub] eolivelli commented on issue #296: Bookies supports ephemeral port

2017-07-26 Thread git
eolivelli commented on issue #296: Bookies supports ephemeral port URL: https://github.com/apache/bookkeeper/issues/296#issuecomment-318134569 Yes I just wanted to make it clear. For me is ok This is an automated message

[GitHub] eolivelli commented on issue #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
eolivelli commented on issue #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298#issuecomment-318135194 I Am sorry. I have already closed the pr. I will create a new one and do the proposed fix from @merlimat

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129647972 ## File path: bookkeeper-server/certs/keyStoreServerPassword.txt ## @@ -0,0 +1 @@ +server Review

[GitHub] sijie commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-07-26 Thread git
sijie commented on issue #206: Issue-196 Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/pull/206#issuecomment-318131033 @eolivelli +1 thank you This is an

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129646223 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java ##

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129645246 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129645271 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129645219 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@

[GitHub] sijie commented on issue #296: Bookies supports ephemeral port

2017-07-26 Thread git
sijie commented on issue #296: Bookies supports ephemeral port URL: https://github.com/apache/bookkeeper/issues/296#issuecomment-318128980 @eolivelli : I think the descriptions says it is only for testing, and it is typically a good practice to use ephemeral ports for testing, it can

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129643894 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@

Re: [Discuss] Release DL 0.5.0

2017-07-26 Thread Sijie Guo
Thank you, Enrico. It might be good to also /cc or /bcc the original mailing list. - Sijie On Wed, Jul 26, 2017 at 7:32 AM, Enrico Olivelli wrote: > (sorry for moving to another list) > > Jia, > I have pushed the fix and manually deployed current 4.5.0-SNAPSHOT to >

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129642892 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ## @@ -509,9

[GitHub] sijie commented on issue #287: Introduce BookieClusterManager and Improve BookieListener

2017-07-26 Thread git
sijie commented on issue #287: Introduce BookieClusterManager and Improve BookieListener URL: https://github.com/apache/bookkeeper/issues/287#issuecomment-318124987 @eolivelli this is just an attempt to improve the bookies management for auto-recovery, we are not touching the piece for

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129640711 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java ## @@

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129640538 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java ## @@

[GitHub] sijie commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
sijie commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298#discussion_r129640013 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java ## @@

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129638673 ## File path: bookkeeper-server/certs/keyStoreClientPassword.txt ## @@ -0,0 +1 @@ +client Review

[GitHub] kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper

2017-07-26 Thread git
kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129638382 ## File path: bookkeeper-server/bin/bookkeeper ## @@ -207,9 +207,9 @@ if [ $COMMAND == "bookie" ];

[GitHub] merlimat commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
merlimat commented on a change in pull request #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298#discussion_r129632908 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java ## @@

Re: [Discuss] Release DL 0.5.0

2017-07-26 Thread Enrico Olivelli
(sorry for moving to another list) Jia, I have pushed the fix and manually deployed current 4.5.0-SNAPSHOT to apache repo https://github.com/apache/bookkeeper/pull/298 I hope you can continue the tests with DL + BK 4.5 It is a good way to look for regressions on 4.5 -- Enrico 2017-07-26

[GitHub] eolivelli closed issue #295: LocalBookKeeper failed to start

2017-07-26 Thread git
eolivelli closed issue #295: LocalBookKeeper failed to start URL: https://github.com/apache/bookkeeper/issues/295 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] eolivelli closed pull request #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
eolivelli closed pull request #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (BOOKKEEPER-1017) Create documentation for ZooKeeper ACLs

2017-07-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101681#comment-16101681 ] Hudson commented on BOOKKEEPER-1017: SUCCESS: Integrated in Jenkins build bookkeeper-master #1829

[jira] [Commented] (BOOKKEEPER-1044) Entrylogger is not readding rolled logs back to the logChannelsToFlush list when exception happens while trying to flush rolled logs

2017-07-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101680#comment-16101680 ] Hudson commented on BOOKKEEPER-1044: SUCCESS: Integrated in Jenkins build bookkeeper-master #1829

[GitHub] ivankelly commented on issue #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
ivankelly commented on issue #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298#issuecomment-318057507 I came across this the other day. It failed to start because there was setLoopbackAllowed needed to be set in the configuration.

[GitHub] eolivelli commented on issue #298: Issue 295: LocalBookKeeper fails to start up

2017-07-26 Thread git
eolivelli commented on issue #298: Issue 295: LocalBookKeeper fails to start up URL: https://github.com/apache/bookkeeper/pull/298#issuecomment-318054034 Jenkins is brokenI will try on my laptop This is an automated

[GitHub] eolivelli closed issue #196: Create Jenkins configuration using OpenStack Jenkins Job Builder

2017-07-26 Thread git
eolivelli closed issue #196: Create Jenkins configuration using OpenStack Jenkins Job Builder URL: https://github.com/apache/bookkeeper/issues/196 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jiazhai closed pull request #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs

2017-07-26 Thread git
jiazhai closed pull request #185: BOOKKEEPER-1017 Create documentation for ZooKeeper ACLs URL: https://github.com/apache/bookkeeper/pull/185 This is an automated message from the Apache Git Service. To respond to the

[GitHub] eolivelli opened a new issue #300: EnsemblePlacementPolicy must not use com.google.common.base.Optional as it is shaded from BK 4.5

2017-07-26 Thread git
eolivelli opened a new issue #300: EnsemblePlacementPolicy must not use com.google.common.base.Optional as it is shaded from BK 4.5 URL: https://github.com/apache/bookkeeper/issues/300 In EnsemblePlacementPolicy during the development of 4.5 we used Guava com.google.common.base.Optional.

[GitHub] eolivelli commented on issue #299: EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli commented on issue #299: EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/issues/299#issuecomment-317987576 In my specific use-case I have custom policies which extend DefaultEnsemblePlacementPolicy, so a special

[GitHub] eolivelli opened a new issue #299: EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients

2017-07-26 Thread git
eolivelli opened a new issue #299: EnsemblePlacementPolicy in 4.5 is not compatible with 4.4 clients URL: https://github.com/apache/bookkeeper/issues/299 Is is not possible to use custom EnsemblePlacementPolicy compiled for BookKeeper 4.4 having 4.5 BookKeeper on the classpath. It

Re: BP-11: New BookKeeper Website

2017-07-26 Thread Enrico Olivelli
Great work Sijie and Luc ! There is lot of content!!! and I like the overall idea Some first-look feedback: - installation refers only to building from sources, I think we should talk about downloading the binaries and checking the checksums, ofter people who deploy software do not want to use