---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12500/#review23200
---
Hi, my first comment at the review board. :)
Looking at the diff, I
On July 16, 2013, 2:06 p.m., Ryan Lei wrote:
Hi, my first comment at the review board. :)
Looking at the diff, I think it's better to change the if else statements
so that 6.x is the default behavior. Like this:
if version[:3] == '5.6':
path1 = /local/domain/ + domid +
As a community we made good progress and closed 80 issues since Thursday night
and 192 issues in last 7 days. Thank you everyone
Animesh
-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: Thursday, July 11, 2013 11:24 PM
To:
Thanks Isaac for creating this branch. I'll keep an eye on the commits you
make your here . Once the code for handling nested query API calls are
ready , you can merge it into master.
@Jessica - I have had conversations with Isaac and he is in the process of
re-factoring the code for dedicated
LS,
I am looking at a method 200 lines long. I've seen more of those.
I would propose a maximum length of 80 lines per method and
A maximum of 10 methods per class, not including getters and setters of course.
I think this would help with the readability of the source base and thus the
growth
What is the method?
DL
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: 16 July 2013 10:00 AM
To: dev@cloudstack.apache.org
Subject: [DISCUSS] coding convention for method - and class length
LS,
I am looking at a method 200 lines long. I've
Hi,
On 07/16/2013 10:59 AM, Daan Hoogland wrote:
LS,
I am looking at a method 200 lines long. I've seen more of those.
Yes, that is pretty long.
I would propose a maximum length of 80 lines per method and
There was a recent discussion about this, but I wasn't able to find it
that
On 07/15/2013 06:38 PM, John Skinner wrote:
I dug a little bit deeper and found that it IS a supported storage type of NETFS, as a
valid poor format type (see below from libvirt.org). Now, not being familiar with how
CloudStack handles storage; I was think that under
+1 for the maximum length per line
I also agree with Wido that around 120 characters will be more fit current
needs.
Regards
Isaac
On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
I'm ok with a symptom fix on our end, if the root cause is in
Libvirt we can't do much about that. This is the sort of patch that
tends to get pulled into the regular update cycle of the
distributions, so unless there's more to it and it's not a
Can some one restart it .
Hmm. The original comment was maximum length of 80 lines per method.
Did you want to start a new thread covering max characters per line?
-Original Message-
From: Isaac Chiang [mailto:isaacchi...@gmail.com]
Sent: 16 July 2013 11:12 AM
To: dev@cloudstack.apache.org
Subject: Re:
I agree with Wido.
Moreover, the file lock will cause performane degrade of VM deployment.
-Wei
2013/7/16 Wido den Hollander w...@widodh.nl
On 07/16/2013 12:27 AM, Marcus Sorensen wrote:
I'm ok with a symptom fix on our end, if the root cause is in
Libvirt we can't do much about that.
On 07/16/2013 12:34 PM, Wei ZHOU wrote:
I agree with Wido.
So how do you propose how we refresh the pool?
Right now we call storagePoolRefresh() every time we do a
getStoragePool() to the LibvirtStorageAdapter, which is called on a very
regular basis by all KVM agents for various tasks.
Can someone log into the VM , and check if acpiphp is already loaded?
root@NEW:~# lsmod |grep acpiphp
acpiphp24231 0
if not, please run modprobe acpiphp, and try again
-Wei
2013/7/16 Marcus Sorensen shadow...@gmail.com
I'll try to track it down tonight. As far as anyone knows
Given the debate on system template changes in last few days of 4.1
requiring big testing effort and potential regression, I would like to see
that as community we lock down system templates for 4.2 pretty soon. If any
changes are needed we should call it out now and get them resolved.
As per my
You are right Abhi.
Enable RPS/RFS (CLOUDSTACK-2433) changes doesn't involve template changes.
Thanks,
jayapal
On 16-Jul-2013, at 5:18 PM, Abhinandan Prateek cloudst...@aprateek.com
wrote:
Given the debate on system template changes in last few days of 4.1
requiring big testing effort and
I am all for re-oping discussions on the ten commandments, but let's stick
to method and class level for now.
On Tue, Jul 16, 2013 at 12:19 PM, Donal Lafferty
donal.laffe...@citrix.comwrote:
Hmm. The original comment was maximum length of 80 lines per method.
Did you want to start a new
This issue appeared when I used StyleCheck and Eclipse to find and fix my
coding convention violations automatically. Details at
http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html
We inherit the 80 char line limit inherited from the Java Programming Style,
and it makes
Turns out faster to use CheckStyle, Eclipse and ACS code style file.
See http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html
-Original Message-
From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
Sent: 08 July 2013 10:15 AM
To: dev@cloudstack.apache.org
On Tue, Jul 16, 2013 at 01:22:22PM +, Donal Lafferty wrote:
Turns out faster to use CheckStyle, Eclipse and ACS code style file.
See http://dlafferty.blogspot.co.uk/2013/07/apache-cloudstack-java-coding.html
Awesome post Donal!
-Original Message-
From: Donal Lafferty
John,
The generic properties would fit the bill for a vendor that just wants to
provide the metadata and let the traditional primary-storage workflow take its
course. But, a form with additional fields may not be enough for a particular
implementation, so having the flexibility to display a
David,
Are you able to share more specific UI requirements? For example, would it be
possible to describe a basic flow through the UI you require?
My thoughts around the property bag are that it would be available at the
lowest levels of the storage layer-- passed into each driver
Me too not able to access Review board.
Fix for a blocker bug is in pending so attaching the patch to the bug ticket
itself. https://issues.apache.org/jira/browse/CLOUDSTACK-3551
Can someone review my patch and commit.
Thanks,
Harikrishna
On 16-Jul-2013, at 3:46 PM, Bharat Kumar
Donal,
Our coding convention says 180. It was discussed about a week or two back.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
--Alex
-Original Message-
From: Donal Lafferty [mailto:donal.laffe...@citrix.com]
Sent: Tuesday, July 16, 2013 6:02 AM
To:
On Tue, Jul 16, 2013, at 08:02 AM, Donal Lafferty wrote:
Can we loosen/ignore this rule when readability becomes an issue?
Alex raised this issue last week:
http://markmail.org/message/z2hzz7efujgmhfnh
I didn't see many responses to that particular part of his email,
though.
Personally, I
Chris,
If it is then it was written wrong. You can change it to public and send in a
patch.
--Alex
-Original Message-
From: SuichII, Christopher [mailto:chris.su...@netapp.com]
Sent: Monday, July 15, 2013 9:23 PM
To: dev@cloudstack.apache.org
Cc: Alex Huang; Chiradeep Vittal; Min
The deadline for proposals to the Xen Project user summit is near:
http://blog.xen.org/index.php/2013/06/03/call-for-proposals-opens-for-xen-project-user-summit-and-xen-project-developer-summit/
Hi all,
A reminder that we have the weekly CloudStack meeting in
#cloudstack-meeting at 17:00 UTC on Wednesdays. We scuttled the meeting
last week because we had low turnout, so I hope to see more folks turn
up tomorrow!
Best,
jzb
--
Joe Brockmeier
j...@zonker.net
Twitter: @jzb
My mistake. I'll have to update my style rules.
DL
-Original Message-
From: Alex Huang [mailto:alex.hu...@citrix.com]
Sent: 16 July 2013 2:54 PM
To: dev@cloudstack.apache.org
Subject: RE: [discuss] 80 char max length leads to illegiable source
Donal,
Our coding convention
On Tue, Jul 16, 2013, at 08:53 AM, Alex Huang wrote:
Donal,
Our coding convention says 180. It was discussed about a week or two
back.
So, I am surprised that it's already been changed. I noticed the comment
when I was doing the weekly news - but it was buried in an email with
the subject
Thanks for the reply Edison, I still have a query though...
if CS has more than one primary storage in a cluster and admin wants to know
about
location of a volume i.e. in which primary storage this volume is in, than as
per current behavior, admin has to
search in all the primary storage by
When I was developing the SolidFire plug-in for 4.2, I noticed the folder
column wasn't being used, as well.
I repurposed it for SolidFire plug-in volumes to store the ID of the iSCSI
volume (LUN) on our SAN.
On Tue, Jul 16, 2013 at 8:39 AM, Sanjay Tripathi sanjay.tripa...@citrix.com
wrote:
I refrained from lurking for a couple of weeks, but do definitely have the
intention to be a better citizen.
On Tue, Jul 16, 2013 at 4:16 PM, Joe Brockmeier j...@zonker.net wrote:
Hi all,
A reminder that we have the weekly CloudStack meeting in
#cloudstack-meeting at 17:00 UTC on
Hello community ,
Let me take the opportunity to thank each one you in the Apache CloudStack
community for your valuable contributions. It has been a pleasure working
with you all and unfortunately I have quit my $dayjob for pursuing my
higher studies in the US which means that I might not get
John,
UI requirements? A reusable wizard for plugin implementers to leverage, and
this has already been brought up by Chris Suich in another thread. That would
allow for the same look and feel as other wizards in CS, but what is gathered
in the wizard screens is entirely up to the vendor. I
-Original Message-
From: Joe Brockmeier [mailto:j...@zonker.net]
Sent: 16 July 2013 3:02 PM
To: dev@cloudstack.apache.org
Subject: Re: [discuss] 80 char max length leads to illegiable source
On Tue, Jul 16, 2013, at 08:02 AM, Donal Lafferty wrote:
Can we loosen/ignore this rule
Hi,
We just migrated our cloudstack management server (use basic networking) from
3.0.2 to 4.1, now we want upgrade cloudstack host xenserver from 6.0.2 to 6.1.
We have 4 host servers in the same pool and 30 VMs on it, and we also need
migrate them without downtime. So we choose xencenter
On Tue, Jul 16, 2013, at 10:37 AM, Alex Huang wrote:
I updated the wiki because several people asked me to post my eclipse
preference file which includes 180 column widths. There's also a follow
up mail thread after I checked it in. The column width was not
questioned. I can send out a
Hi Fabrice,
Changing the default config version at cluster level should do. Did you try
with a new template registered after modifying the cluster level setting?
Subsequently deployed VMs should follow.
CloudStack does clone the VMs from already deployed template. All the VMs
inherit the
I have code to delete the Plugin device from the system, when I try to execute
this code I get an exception before my Command gets invoked in system code that
tries to create an event. I debugged this to the event table underlying SQL
definition. I wanted to know what the best practice was for
I'd suggest shortening your event type literals.
On Tue, Jul 16, 2013 at 1:45 PM, Soheil Eizadi seiz...@infoblox.com wrote:
I have code to delete the Plugin device from the system, when I try to
execute this code I get an exception before my Command gets invoked in
system code that tries to
Hi,
Review board is seemly inaccessible, isn't it?
--
N.g.U.y.e.N.A.n.H.t.U
Yes - Infra is aware of the issue and working on addressing it.
--David
On Tue, Jul 16, 2013 at 2:00 PM, Nguyen Anh Tu ng.t...@gmail.com wrote:
Hi,
Review board is seemly inaccessible, isn't it?
--
N.g.U.y.e.N.A.n.H.t.U
Thanks for all your help, Pranav!
On Tue, Jul 16, 2013 at 9:08 AM, Pranav Saxena psb...@gmail.com wrote:
Hello community ,
Let me take the opportunity to thank each one you in the Apache CloudStack
community for your valuable contributions. It has been a pleasure working
with you all and
Good work Pranav! All the best for your future.
-Prachi
-Original Message-
From: Pranav Saxena [mailto:psb...@gmail.com]
Sent: Tuesday, July 16, 2013 8:09 AM
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org;
market...@cloudstack.apache.org
Subject: Thank you Apache community
Nice to work with Pranav. You are a great contributor, best wishes to your
advanced study.
-min
On 7/16/13 11:27 AM, Prachi Damle prachi.da...@citrix.com wrote:
Good work Pranav! All the best for your future.
-Prachi
-Original Message-
From: Pranav Saxena [mailto:psb...@gmail.com]
Thanks for your great job!
Best wishes for your further study and life.
-Wei
2013/7/16 Pranav Saxena psb...@gmail.com
Hello community ,
Let me take the opportunity to thank each one you in the Apache CloudStack
community for your valuable contributions. It has been a pleasure working
with
All the best Pranav,
I am sure you will do well in your new endeavors !
On Jul 16, 2013, at 3:27 PM, Wei ZHOU ustcweiz...@gmail.com wrote:
Thanks for your great job!
Best wishes for your further study and life.
-Wei
2013/7/16 Pranav Saxena psb...@gmail.com
Hello community ,
Let
Brian (and all),
I've come back to looking into this feature and want to discuss it a bit more.
I like the idea of putting each plugins dictionary into it's own namespace, but
that may make utilizing it a bit more difficult. Currently, strings are
automagically localized through the _l()
Due to bug fix for CLOUDSTACK-2823, we added a fix in the KVM code, to retry
passCmdLine several times during system vm start.
Somehow, during the retry, passCmdLine(the patchviasocket.pl itself) is hanging
forever, thus blocking startcommand, even the vm is already started.
The possible fix:
I am wondering what causes passCmdLine hanging forever?
-Wei
2013/7/16 Edison Su edison...@citrix.com
Due to bug fix for CLOUDSTACK-2823, we added a fix in the KVM code, to
retry passCmdLine several times during system vm start.
Somehow, during the retry, passCmdLine(the patchviasocket.pl
if this is how jira works I would like to put the ugly +1 to that. If we
don't go for code names we can still work like that by using a new label
'master' all the time and renaming that one before creating a new one. As I
said, I like the code naming principle.
regards,
On Mon, Jul 15, 2013 at
After working with a few different hardware VPN gateways in a few different
configurations I've found there's a relatively simple component missing to
allow us to easily support those other configurations. I've been able to
get the networks to connect with some modifications in the VPC router VM,
Marcus,
Nice.
I think it is because of the inconsistent between hypervisor and virtual
machines , for instance, hypervisor thinks volume is attached but in fact
not. It happens in some cases:
(1) attach volume when VM starting. To avoid it, it is better to allow
attach/detach only when vm is
Edison,
Thanks a lot . I will have a look at it tomorrow.
-Wei
2013/7/16 Edison Su edison...@citrix.com
The doc says, the agent command can block forever:
http://wiki.libvirt.org/page/Qemu_guest_agent
Warning: Like any monitor command, GA commands can block indefinitely
-Original
Hi Ian,
I've implemented the S2S vpn, but at this memory I am focus on 4.2 release,
so I am afraid I don't have much time for new feature.
But you can file a Jira ticket anyway, and probably somebody interested in
it in the community would take it. Java is not hard. :)
Please make sure you
Yes, the review board is still down. I just tried and wanted to post a review
When will it be fixed? Thanks,
-Fang
-Original Message-
From: Nguyen Anh Tu [mailto:ng.t...@gmail.com]
Sent: Tuesday, July 16, 2013 11:01 AM
To: dev@cloudstack.apache.org
Subject: Review board inaccessible
Done.
Thanks!
--Sheng
On Mon, Jul 15, 2013 at 6:30 PM, Chip Childers chip.child...@sungard.comwrote:
The branch is free for you to push stuff into. Feel free.
On Jul 15, 2013, at 9:06 PM, Sheng Yang sh...@yasker.org wrote:
Hi,
Please cherry-pick the following commit from MASTER(it's
The review board is working now
Thanks a lot!
-Original Message-
From: Fang Wang [mailto:fang.w...@citrix.com]
Sent: Tuesday, July 16, 2013 3:28 PM
To: dev@cloudstack.apache.org
Subject: RE: Review board inaccessible
Yes, the review board is still down. I just tried and wanted to post
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12591/
---
Review request for cloudstack and edison su.
Bugs: CLOUDSTACK-3566
Folks
We are now just 2 weeks from ACS 4.2 code freeze on 7/29. For the past week
there has been vibrant activity in filing and fixing issues. 120 new issues
were created and 140 issues were resolved. We managed to contain open defects
to less than 400 but blockers and critical continue to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12611/
---
Review request for cloudstack, Animesh Chaturvedi and Frank Zhang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12612/
---
Review request for cloudstack, Chip Childers, edison su, Kelven Yang, Sateesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12612/#review23217
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12591/#review23222
---
Ship it!
Ship It!
- edison su
On July 16, 2013, 10:37 p.m.,
Good Luck Pranav.
Thank you for all your advice with UI modifications.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12622/
---
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
---
(Updated July 17, 2013, 2:07 a.m.)
Review request for cloudstack, Abhinandan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12623/
---
Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/#review23233
---
Ship it!
Ship It!
- Abhinandan Prateek
On July 17, 2013, 2:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12622/#review23234
---
Ship it!
Ship It!
- Abhinandan Prateek
On July 17, 2013, 2:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12273/#review23235
---
Ship it!
Ship It!
- Abhinandan Prateek
On July 10, 2013, 5:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12109/
---
(Updated July 17, 2013, 3:41 a.m.)
Review request for cloudstack, Abhinandan
Thank you everyone for your wishes. They definitely mean a lot to me and I
hope I am able to contribute even more till the end of time :) .
Please feel free to add/contact me on Linked In -
http://in.linkedin.com/pub/pranav-saxena/13/904/98 or my personal email
ID's (psb...@gmail.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12625/
---
Review request for cloudstack and Prasanna Santhanam.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12629/
---
Review request for cloudstack and Devdeep Singh.
Bugs: CLOUDSTACK-3492
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12358/#review23238
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12427/#review23239
---
server/src/com/cloud/alert/AlertManagerImpl.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12324/#review23242
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12251/
---
(Updated July 17, 2013, 5:52 a.m.)
Review request for cloudstack, Alena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12631/
---
Review request for cloudstack and Prasanna Santhanam.
Bugs: CLOUDSTACK-3582
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12630/
---
Review request for cloudstack and Prasanna Santhanam.
Bugs: 17984
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12324/#review23243
---
84 matches
Mail list logo
