Github user AleksMeshkov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46529001
Hi to all! Have anyone noticed bug with getting wrong contact instance?
When I run code below I get contact instance witch I didn't pick. When I
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46532850
+1 and thx! @nadyaA could you pls update your fix by adding the same change
to show() method as well.
---
If your project is set up for it, you
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-wp8/pull/42
CB-6977 Support chip architecture as an option for run command for Windows
and Windows Phone projects
Implementation for [CB-6977](https://issues.apache.org/jira/browse/CB-6977)
Created new feature to track this work - CB-6976 Add support for Windows
Universal apps (Windows 8.1 and WP 8.1)
Should we create a new Jira component specially for this? Windows Universal
apps vs Windows 8.1 vs Windows?
I personally prefer just Windows since:
1. this is what we target to -
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/34
Adds support for build archs to run command
Implementation for [CB-6977](https://issues.apache.org/jira/browse/CB-6977)
Adds support for `--archs` option to `run` command.
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-medic/pull/12
CB-6889, CB-6899, CB-6909 Multiple fixes in master.cfg to ensure proper
work on windows slaves
This includes #9, #10 and #11 with conflicts resolved.
Issues:
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-medic/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-medic/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-medic/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user SunboX closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Hi All,
xcode verison : 6 beta
macox version: Mavericks 10.9.3
cordova vresion: 3.5
I got two issues when using CLI add platform, one is xcode-select error the
another one is Command failed with exit code 2.
Current I am already fixed xcode-select error ,*but I don't know how to fix
the *
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46556623
Merged, thx for the fix. Pls close PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nadyaA closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nadyaA commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46556813
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
On Wed, Jun 18, 2014 at 7:19 PM, Carlos Santana csantan...@gmail.com
wrote:
Joe what is the project structure that you don't like and think we should
not adopt?
http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Project-Structure
The default Gradle Java/Android project
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/30#discussion_r13974255
--- Diff: cordova-lib/src/cordova/metadata/android_parser.js ---
@@ -88,13 +88,54 @@ module.exports.prototype = {
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-js/pull/71
CB-6983 misleading debug statement
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-js CB-6983
Alternatively you can review
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/53
CB-6980 Fixing filesystem:null property in Entry
when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success it
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-46579029
This fix has been committed, and the tests are ensuring that the correct
keys appear in the callbacks. You can close this pull request, I think.
---
If
bump
On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve agri...@chromium.org
wrote:
Cool, yes! Thanks for the update!
Is there a JIRA for this? Was asked in
https://issues.apache.org/jira/browse/CB-5671.
On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny mmo...@chromium.org
wrote:
Awesome
GitHub user javierbb31 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/34
CB- 6958. Port camera test to plugin-test-framework
Ported tests from mobile-spec (which are written in jasmine 1.3) in
jasmine 2.0.
Added:
New js-module named tests to
GitHub user SSRico opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/19
CB-6959] Port capture tests to plugin-test-framework
Ported capture tests from mobile-spec to the new test framework working
with jasmine 2.0.
Added:
-New
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/36
CB-6698 Fix 'android update lib-project' command to work with paths
containing spaces
You can merge this pull request into a Git repository by running:
$ git pull
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13982226
--- Diff: plugin.xml ---
@@ -33,6 +33,9 @@
js-module src=www/CameraConstants.js name=Camera
clobbers target=Camera /
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13982279
--- Diff: plugin.xml ---
@@ -202,6 +205,7 @@
!-- windows8 --
platform name=windows8
+dependency
Github user javierbb31 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13983869
--- Diff: plugin.xml ---
@@ -202,6 +205,7 @@
!-- windows8 --
platform name=windows8
+dependency
Github user javierbb31 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r13984170
--- Diff: plugin.xml ---
@@ -33,6 +33,9 @@
js-module src=www/CameraConstants.js name=Camera
clobbers target=Camera /
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
OK, I did some tests with the misc content part of Mobile Spec and
everything checks out. We should write more tests with JUnit on the
Android project itself to test this, but overall things seem to still
work. This is something that we may want to backport to master as
well. What do people
Sorry I missed providing feedback on this earlier ...
Having a deeper look at this, I am not feeling great about the extra
requirement that every plugin have an additional branch.
Several concerns arise :
- test branch can be out of sync with master
- how do we test a specific version?
- tests
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/8#issuecomment-46603710
Junmin, can you comment any more on this? I'm not sure what the root issue
is? Does the current filetransfer plugin cause a crash with the crosswalk
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/19#issuecomment-46604018
This was fixed, I think, in 0f8467bd -- can you close this pull request?
---
If your project is set up for it, you can reply to this email and
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#issuecomment-46609974
I've started a conversation on this, before we go and create `test`
branches for all ~20ish plugins.
http://markmail.org/message/576yxsj6xvg6rycw
Jesee, the branch is NOT a requirement (I don't think I documented it as
such, except in the examples for installing plugins for initial look).
Actually, we should delete those stale branches now that we are moving
up-to-date tests into master. It was just for early experimentation on the
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/37
CB-6986 make npm run jshint work without a global jshint
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-lib cb_6986
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/12
CB-6962 globalization tests for test-framework
You can merge this pull request into a Git repository by running:
$ git pull
Heads up, I believe we (Adobe) are getting one of the devices for testing.
On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana csantan...@gmail.com
wrote:
Announced today:
http://www.amazon.com/gp/product/B00EOE0WKQ/
Runs Fire OS 3.5
When using single icon as application icon in config.xml this way icon src
=icon.png platform=android / cordova should use basic drawable folder,
because doesn't matter of resolution, PPI, etc., so doesn't matter of device
and for this purpose there are drawable folder. Not use drawable-hdpi,
On Thu, Jun 19, 2014 at 1:41 PM, Jan Velecký vve...@seznam.cz wrote:
When using single icon as application icon in config.xml this way icon src
=icon.png platform=android / cordova should use basic drawable folder,
because doesn't matter of resolution, PPI, etc., so doesn't matter of device
re:
Q: What do I do if my plugin tests must have very large assets?
- A: Don't bundle those assets with your plugin. If you can, have your
...
My concern is I do not want to see tests added to every project that uses a
plugin, even if the assets are not large, there are implications to
On 19 June 2014 13:52, Joe Bowser bows...@gmail.com wrote:
It's really not neccessary to have 5 not similar, but exactly same icon
files, when we can have only 1 icon file.
People should be changing their icons anyway, and I don't believe we
actually landed any support for the icon element
So, it resizes the icon? If not, then the point is still valid.
On Jun 19, 2014 2:11 PM, Darryl Pogue dvpdin...@gmail.com wrote:
On 19 June 2014 13:52, Joe Bowser bows...@gmail.com wrote:
It's really not neccessary to have 5 not similar, but exactly same icon
files, when we can have only 1
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46621747
Please file an issue at:
http://issues.apache.org/jira/browse/CB
... so it can be tracked and evaluated by the devs, and you can be notified.
Sorry. I forgot you asked the question. There was no issue but there is one now.
https://issues.apache.org/jira/browse/CB-6990
This feature is plugman only for now. How important is it to wire it
to CLI ? Have you guys had time to test it out yet ? How would it
work with CLI ? Add another flag
Andrew has raised that concern as well. My gut says that the bundling of a
few shorts scripts that get parsed but not run as long as they don't get
require() will not affect applications negatively (there are probably many
more significant overheads we live with today in cordova) -- but I
GitHub user dylin opened a pull request:
https://github.com/apache/cordova-lib/pull/38
Fixed issue: CB-6140
plugman dependency check will ignore platform/dependecy when removing an
intalled plugin, which will result in platform level dependencies is
uninstalled inproperly.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/38#issuecomment-46627998
1. The first line of your commit message should be of the form:
CB-6140 Don't allow deletion of platform dependencies
2. Please fix any misspellings
Option a) was what I suggested a ways back, and I still stand by it.
I think it provides the greatest transparency, and simplicity, yet it is
still very flexible.
I don't think it would be hard to accomplish either. This is the small
re-org I was hinting at, you've already done the hard part.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46631067
Could you please do a rebase so that there isn't an ugly merge (or multiple
ugly merges) in the history? I've done a number for #9 -- it makes things much
nicer.
My ultimate would be this:
cordova create TestFilePlugin
cd TestFilePlugin
cordova platform add android
cordova plugin add
http://git-wip-us.apache.org/repos/asf/cordova-labs.git#cdvtest:cordova-plugin-test-framework
cordova plugin add ../cordova-plugin-file/
cordova plugin add
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-lib/pull/22#issuecomment-46631277
@kingnebby : those two corrections are right, but you should squash them
into your other commits, and then you should rebase and resolve the merge
conflicts.
Thanks Anis!
Tougher for CLI since it's actually the prepare step that creates
cordova_plugins.js, but longer term (medium term?) I don't see why we
shouldn't just turn it on always anyways.
So... Maybe cordova prepare --browserify?
Build prepares first, so will also need: cordova run android
I don't think it should resize it, but I do agree we should delete the
template ones if any are present. Right now you aren't sure if the icon
tag even did anything if you fail to replace the right size. Android and
iOS both do a pretty good job at resizing at runtime if only one large icon
is
+1 I agree, this would be awesome.
New question, should this merely be the standard we adhere to for core
plugins, or should we actively make it difficult for plugin devs to not
ship tests directly with plugins? (Not sure how we could accomplish that,
so I hope its just a convention that applies
On Thu, Jun 19, 2014 at 6:01 PM, Andrew Grieve agri...@chromium.org wrote:
I don't think it should resize it, but I do agree we should delete the
template ones if any are present. Right now you aren't sure if the icon
tag even did anything if you fail to replace the right size.
The icon tag is
I think we just lead by example.
Sent from my iPhone
On Jun 19, 2014, at 6:18 PM, Michal Mocny mmo...@chromium.org wrote:
+1 I agree, this would be awesome.
New question, should this merely be the standard we adhere to for core
plugins, or should we actively make it difficult for plugin
testing is good, no need to hide it,
it would be good though to not copy it with the rendered app
Dnia Thu Jun 19 19:11:25 2014 purplecabbage pisze:
I think we just lead by example.
Sent from my iPhone
On Jun 19, 2014, at 6:18 PM, Michal Mocny mmo...@chromium.org wrote:
+1 I agree, this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46646255
Could we also incorporate the following PR to this one before merge? It
adds splash images support for iOS, WP8 and Windows8.
59 matches
Mail list logo
