[GitHub] chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199068099 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35 +3

[GitHub] chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r199060984 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/HashJoinPOP.java ## @@ -32,35 +3

[GitHub] sohami edited a comment on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami edited a comment on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352#issuecomment-401251159 @Ben-Zvi - Can you please review this ? Issue was in BuildSchema phase TopN was receiving NONE outcome

[GitHub] sohami commented on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami commented on issue #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352#issuecomment-401251159 @Ben-Zvi - Can you please review this ? This is an

[GitHub] sohami opened a new pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i…

2018-06-28 Thread GitBox
sohami opened a new pull request #1352: DRILL-6548: IllegalStateException: Unexpected EMIT outcome received i… URL: https://github.com/apache/drill/pull/1352 …n buildSchema phase This is an automated message from the Apache G

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198912485 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java ## @@ -63,17 +6

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198912059 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java ## @@ -83,15 +84,13

[GitHub] sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler

2018-06-28 Thread GitBox
sohami commented on a change in pull request #1345: DRILL-6494: Drill Plugins Handler URL: https://github.com/apache/drill/pull/1345#discussion_r198902957 ## File path: distribution/src/deb/control/conffiles ## @@ -16,3 +16,4 @@ /etc/drill/conf/drill-override.conf /etc/d

[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401246375 @weijietong thanks for the PR. Yes, this is high on my list to review. I am tied up until tomorrow but will review during the weekend. -

Travis CI Timed Out

2018-06-28 Thread Charles Givre
I submitted some changes and the following happened. Any suggestions? Audit done. [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @ drill-sqlline --- [INFO] [INFO] --- maven-i

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026541 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6 +38,7

[jira] [Created] (DRILL-6556) Provide secure location for JDBC credentials

2018-06-28 Thread Charles Givre (JIRA)
Charles Givre created DRILL-6556: Summary: Provide secure location for JDBC credentials Key: DRILL-6556 URL: https://issues.apache.org/jira/browse/DRILL-6556 Project: Apache Drill Issue Type:

[GitHub] sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401237920 - Updated code based on most recent comments - Fixed a compilation failure due to changes in the Batch Sizer APIs made

[jira] [Created] (DRILL-6555) Add unit tests for REST API

2018-06-28 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-6555: -- Summary: Add unit tests for REST API Key: DRILL-6555 URL: https://issues.apache.org/jira/browse/DRILL-6555 Project: Apache Drill Issue Type: Bug

Re: Discussion about the metadata design

2018-06-28 Thread weijie tong
Hi Vitalii: Glad to hear that you are also looking at this part. Let's keep discussion under that Jira. On Fri, Jun 29, 2018 at 1:27 AM Vitalii Diravka wrote: > Hi Weijie, > > Thanks for bringing this topic up! > > Basically you are right, Hive Metastore is one the best candidates for > stor

[GitHub] Ben-Zvi opened a new pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct

2018-06-28 Thread GitBox
Ben-Zvi opened a new pull request #1351: DRILL-6543: Disable Hash Join fallback, add percent_reserved_allowance_from_direct URL: https://github.com/apache/drill/pull/1351 (1) Turned the default for Hash Join Fallback to **false**. (2) Added a new option: **planner.memory.percent_reserve

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401234061 @sachouche I refer to your following comment: >User should be able to control batch statistics behavior within a client s

[GitHub] sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401231517 @vrozov The logging functionality is not exposed to end users. All batch stats flags are internal. -

[GitHub] vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
vrozov commented on issue #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#issuecomment-401230944 I am not convinced that a user should be able to change the amount of logging from a client session. A user may cause an exc

[GitHub] weijietong commented on issue #1334: DRILL-6385: Support JPPD feature

2018-06-28 Thread GitBox
weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-401230814 ping @amansinha100 @parthchandra or someone else would be pleased to review this PR.

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199037297 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199030833 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Pa

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198930977 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ##

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198935830 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198938982 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198940291 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199031515 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199037140 ## File path: exec/java-exec/src/main/resources/drill-module.conf ## @@ -482,6 +482,8

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036653 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036942 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.j

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199031792 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198932595 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ##

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198941031 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198933150 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionMan

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198937814 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198942743 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199029854 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionMan

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r199036789 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ba

[GitHub] sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality

2018-06-28 Thread GitBox
sachouche commented on a change in pull request #1330: DRILL-6147: Adding Columnar Parquet Batch Sizing functionality URL: https://github.com/apache/drill/pull/1330#discussion_r198937973 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/Va

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199036078 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199034500 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
chunhui-shi commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199033434 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6

[GitHub] HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-28 Thread GitBox
HanumathRao commented on issue #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#issuecomment-401215354 @vvysotskyi Thanks for making the code changes. Code changes look good to me. +1.

[GitHub] HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions

2018-06-28 Thread GitBox
HanumathRao commented on a change in pull request #1346: DRILL-6546: Allow unnest function with nested columns and complex expressions URL: https://github.com/apache/drill/pull/1346#discussion_r199027667 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl

[GitHub] Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error

2018-06-28 Thread GitBox
Ben-Zvi closed pull request #1340: DRILL-6539: Record count not set for this vector container error URL: https://github.com/apache/drill/pull/1340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer

2018-06-28 Thread GitBox
Ben-Zvi closed pull request #1341: DRILL-6512: Remove unnecessary processing overhead from RecordBatchSizer URL: https://github.com/apache/drill/pull/1341 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026644 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199026541 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6 +38,7

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r199023543 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ###

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199016141 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillLateralJo

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199020924 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectP

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199018067 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillProjectL

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199019017 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LateralJoinP

[GitHub] amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
amansinha100 commented on a change in pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347#discussion_r199022923 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUti

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022430 ## File path: exec/java-exec/src/main/resources/rest/storage/update.ftl ## @@ -48,6 +48

[GitHub] kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
kkhatua commented on a change in pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350#discussion_r199022055 ## File path: exec/java-exec/src/main/resources/rest/storage/list.ftl ## @@ -38,6 +38,7

[GitHub] Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations

2018-06-28 Thread GitBox
Agirish opened a new pull request #1350: DRILL-4580: Support for exporting storage plugin configurations URL: https://github.com/apache/drill/pull/1350 Added an "Export" button to enabled storage plugins to support exporting the configuration into a JSON file. This can be useful to backup

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
Hi Charles, So it is actually supported. Drill's boolean vector is BitVector. Internally bits are stored efficiently, but when you fetch a bit from the vector it becomes an int, -1 for true and 0 for false. So currently you can check this by using singletonInt and comparing against -1 and 0. Here

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
Hi Charles, Currently the RowSetReader doesn't support booleans, but it can be added. I'll try to add it now, and see if it could be done quickly. I'll update you on my progress. Tim On Thu, Jun 28, 2018 at 2:38 PM, Charles Givre wrote: > Hi Tim, > Could post some sample code as to how to test

[jira] [Resolved] (DRILL-6447) Unsupported Operation when reading parquet data

2018-06-28 Thread Pritesh Maker (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritesh Maker resolved DRILL-6447. -- Resolution: Fixed Resolved with the Parquet MR upgrade - DRILL-6353 > Unsupported Operation wh

[GitHub] Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
Ben-Zvi commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198962585 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ##

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Charles Givre
Hi Tim, Could post some sample code as to how to test a SQL query that returns a Boolean? —C > On Jun 28, 2018, at 17:30, Timothy Farkas wrote: > > - We would have to add a boolean column reader to ColumnAccessors and wire > it in and add a getBoolean method to ScalarReader. > > - Your exampl

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Timothy Farkas
- We would have to add a boolean column reader to ColumnAccessors and wire it in and add a getBoolean method to ScalarReader. - Your example should work as is, ClusterTest has a testBuilder method that allows you to use the traditional test builder. Is there something not working with the test b

[jira] [Resolved] (DRILL-6499) No need to calculate stdRowWidth for every batch by default

2018-06-28 Thread Pritesh Maker (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritesh Maker resolved DRILL-6499. -- Resolution: Duplicate DRILL-6512 will address this. > No need to calculate stdRowWidth for eve

[GitHub] vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling

2018-06-28 Thread GitBox
vrozov opened a new pull request #1349: DRILL-6554: Minor code improvements in parquet statistics handling URL: https://github.com/apache/drill/pull/1349 @arina-ielchiieva Please review This is an automated message from the A

Re: Deprecation of BaseTestQuery FYI

2018-06-28 Thread Arina Yelchiyeva
Hi Tim, it looks like deprecating BaseTestQuery was a little bit pre-mature. For example, from in this PR - https://github.com/apache/drill/pull/1331 - Charles is trying to re-work BaseTestQuery usage to ClusterTest. First, it did not contain getSigletonDouble method which Charles has implemented

[GitHub] arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
arina-ielchiieva edited a comment on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe we can consider allowing sto

[GitHub] arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
arina-ielchiieva commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401134771 @ilooner maybe can consider allowing stout to ease

[GitHub] Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container

2018-06-28 Thread GitBox
Agirish opened a new pull request #1348: DRILL-6346: Create an Official Drill Docker Container URL: https://github.com/apache/drill/pull/1348 Added apache-release profile in distribution/pom.xml to build a Docker image once the project is built successfully. While the Docker image can be b

[jira] [Created] (DRILL-6554) Minor code improvements in parquet statistics handling

2018-06-28 Thread Vlad Rozov (JIRA)
Vlad Rozov created DRILL-6554: - Summary: Minor code improvements in parquet statistics handling Key: DRILL-6554 URL: https://issues.apache.org/jira/browse/DRILL-6554 Project: Apache Drill Issue T

[GitHub] sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch

2018-06-28 Thread GitBox
sohami closed pull request #1323: DRILL-6498: Support for EMIT outcome in ExternalSortBatch URL: https://github.com/apache/drill/pull/1323 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[jira] [Resolved] (DRILL-6551) Concat function results in SYSTEM ERROR: IllegalStateException: Tried to remove unmanaged buffer.

2018-06-28 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-6551. Resolution: Duplicate [~priteshm] Yes, it seems the same issue. Closed this as duplicate.

[GitHub] ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-06-28 Thread GitBox
ilooner-mapr commented on issue #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336#issuecomment-401113654 Thx @vvysotskyi @arina-ielchiieva. I will do the renam

Re: Discussion about the metadata design

2018-06-28 Thread Vitalii Diravka
Hi Weijie, Thanks for bringing this topic up! Basically you are right, Hive Metastore is one the best candidates for storing Driil's metadata. Also it will be good to make an abstraction, which will allow to implement and use other kind of tools for Metastore. The question of Metastore performanc

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198904728 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,84 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198903696 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + + +http://maven.apache.org/POM

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198907077 ## File path: pom.xml ## @@ -3334,5 +3351,6 @@ exec drill-yarn distribution +drill

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198832226 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,133 @@ + + +http://maven.apache.org/POM

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-06-28 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r198905422 ## File path: drill-shaded/guava-shaded/pom.xml ## @@ -0,0 +1,147 @@ + + +http://maven.apache.org/POM

[jira] [Created] (DRILL-6553) Fix TopN for unnest operator

2018-06-28 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-6553: -- Summary: Fix TopN for unnest operator Key: DRILL-6553 URL: https://issues.apache.org/jira/browse/DRILL-6553 Project: Apache Drill Issue Type: Bug

[GitHub] ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on issue #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#issuecomment-401101245 @Ben-Zvi addressed review comments. please take a look. This is an automate

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911603 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java #

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198911099 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableTemplate.java ###

[jira] [Created] (DRILL-6552) Drill Metadata management "Drill MetaStore"

2018-06-28 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-6552: -- Summary: Drill Metadata management "Drill MetaStore" Key: DRILL-6552 URL: https://issues.apache.org/jira/browse/DRILL-6552 Project: Apache Drill Issue Ty

[GitHub] ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate

2018-06-28 Thread GitBox
ppadma commented on a change in pull request #1324: DRILL-6310: limit batch size for hash aggregate URL: https://github.com/apache/drill/pull/1324#discussion_r198910755 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java #

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198910736 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198907027 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198900647 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198899847 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetPushDownFilter.j

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198896839 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

Re: Discussion about the metadata design

2018-06-28 Thread Arina Yelchiyeva
Hi, Vitalii and Vova is also looking at this part, you might want to sync up with them. Or even better, we can create Jira for this and held all discussions there. Vitalii, what do you think? Kind regards, Arina On Thu, Jun 28, 2018 at 6:46 PM weijie tong wrote: > HI all: > > As @aman ever

Discussion about the metadata design

2018-06-28 Thread weijie tong
HI all: As @aman ever noticed me about the roadmap of DRILL-2.0 ,which includes the description of the metadata design ( https://lists.apache.org/thread.html/74cf48dd78d323535dc942c969e72008884e51f8715f4a20f6f8fb66@%3Cdev.drill.apache.org%3E) , I am interested in taking the role to implement

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198886170 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java ##

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198882619 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[GitHub] vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-06-28 Thread GitBox
vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r198882164 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetComparisonPredicate.

[jira] [Created] (DRILL-6551) Concat function results in SYSTEM ERROR: IllegalStateException: Tried to remove unmanaged buffer.

2018-06-28 Thread Nitin Pawar (JIRA)
Nitin Pawar created DRILL-6551: -- Summary: Concat function results in SYSTEM ERROR: IllegalStateException: Tried to remove unmanaged buffer. Key: DRILL-6551 URL: https://issues.apache.org/jira/browse/DRILL-6551

[GitHub] HanumathRao opened a new pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator.

2018-06-28 Thread GitBox
HanumathRao opened a new pull request #1347: DRILL-6545: Projection Push down into Lateral Join operator. URL: https://github.com/apache/drill/pull/1347 @amansinha100 Please review this PR. This PR includes. 1) Two new Rules for Push Project into lateral join and push project pas

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198863368 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198863368 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestPhoneticFunctions.j

[GitHub] arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions

2018-06-28 Thread GitBox
arina-ielchiieva commented on a change in pull request #1331: DRILL-6519: Add String Distance and Phonetic Functions URL: https://github.com/apache/drill/pull/1331#discussion_r198861948 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestStringDistanceFunct

  1   2   >