processes that way (until the server times them out,
but that is 15 seconds later; a *lot* longer than it would take to restart a
crashed child)
So... while it should be fixed, I wouldn't call it a showstopper.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
apr_file_read_full(). It will return
all the bytes that you ask for, unless an error condition occurs (EOF).
There is no need to do any looping.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
On Thu, May 23, 2002 at 02:31:45PM -0700, Justin Erenkrantz wrote:
On Thu, May 23, 2002 at 02:25:48PM -0700, Greg Stein wrote:
Oof... needlessly complicated. Just use apr_file_read_full(). It will return
all the bytes that you ask for, unless an error condition occurs (EOF
distributions, then why isn't it simply
httpd-2.0.36.zip ?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
--
Greg Stein, http://www.lyra.org/
at top level makes a lot more sense than the flags we
have nowadays. the current flags are a confusing much of where a directive
can or can't appear; the names are bad, the combinations aren't clear, and
even the symbols aren't properly namespace (e.g. OR_LIMIT) ]
Cheers,
-g
--
Greg Stein, http
the client does not accept an
encoding but the proxy does?)
We could certainly implement the proxy that way.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
.
If you're trying to debug the thing, then you really *do* want it to be
chatty. Most users won't be bothered by that because they don't run in debug
mode.
-0 on any reduction in debug chattiness.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
.
In particular, it might be possible for a third-party module to use
APLOG_NOERRNO and want to test for it. It doesn't hurt us to leave the value
in there.
Cheers,
-g
(*) http://apr.apache.org/versioning.html
--
Greg Stein, http://www.lyra.org/
of Win32 and Linux.
Martin
--
[EMAIL PROTECTED] | Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730 Munich, Germany
--
Greg Stein, http://www.lyra.org/
handled in the
core; by a similar analogy, chunking is handled in the core ]
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
about pid file races and staleness, differing versions of
ps/kill/killall/etc. It would be great to have a BSD-licensed version of
something like djb's daemontools.
That would be totally fine/cool. Are you volunteering? :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
from a socket. That
would give you delayed read from the socket (and possible later optimization
of doing a sendfile() from the socket fd into a file fd), yet apply the
appropriate request-boundary limitations.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
(??) (the app-level thing which starts
sucking input from the filter stack and processing it).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
.
For example, apr-1.0-1.i386.rpm might install *only* the .so file and its
symlinks. apr-devel would install the .a and .la files and the headers.
Thus, it would be quite reasonable and possible that a .la file does not
exist in a particular installation.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
$.02 and raise you another $.02
+1, ditto on all the above.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
...
...
else {
-return ISAPILogNotSupported must be on or off;
+return ISAPIlog_unsupported must be on or off;
blarg...
etc.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
directory
- Move the .v files on icarus
If you move the ,v files you'll be messing with history, how about
just
delete and add?
*cough*svn could probably do it*cough*
-aaron
--
Greg Stein, http://www.lyra.org/
for compile-time).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
function at compile time. For example:
#if MODULE_MAGIC_NUMBER_MINOR = 1
...
ap_get_mime_headers(...)
...
#endif
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
solutions, especially ap_pass_brigade() changes
[which would impose overhead on *everybody*]
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
On Wed, Apr 17, 2002 at 01:57:32PM -0700, Aaron Bannert wrote:
On Wed, Apr 17, 2002 at 01:56:13PM -0700, Greg Stein wrote:
Can we stop copying pod.[ch] all over the place? Maintenance is going to be
from hell. Just move the frickin' thing up into server/.
And before anybody says
module or to use CVS branches :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
: graceful works great on solaris8+worker
and linux2.4+worker when I pound the heck out of it while slamming it
with requests.
+1 here, too.
I just ran it, along with a bunch o' DAV tests on Redhat 7.2. Worked like a
charm.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
(!) of users out there.
The Apache HTTP server wouldn't enjoy its popularity without all of you!
Sincerely,
Greg Stein
Director of the ASF
-dev
Server built: Apr 3 2002 21:29:22
--
Sung Kim [EMAIL PROTECTED]
http://www.cse.ucsc.edu/~hunkim
Dreams become reality!
___
dav-dev maillist - [EMAIL PROTECTED]
http://dav.lyra.org/mailman/listinfo/dav-dev
--
Greg Stein, http
in ctx-bb.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
they don't know they are
operating as part of a subreq filter chain.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
that pure-brigade systems would not suffer the overhead.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
for an existing
OLD_WRITE to be present. If it is there, then another won't be added. If the
filter is not at the top, it won't be used.
And lastly, remember the ordering of the filters. Even if the subreq inserts
stuff, the OLD_WRITE should always remain at the top.
Cheers,
-g
--
Greg Stein, http
On Wed, Mar 27, 2002 at 02:28:16AM -, [EMAIL PROTECTED] wrote:
dougm 02/03/26 18:28:16
Modified:modules/ssl mod_ssl.h
Added: modules/ssl ssl_toolkit_compat.h
This header file needs a license at the top.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
--
Greg Stein, http://www.lyra.org/
bell-up. Adding return codes where possible can help to move towards that
long term goal.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
--
Greg Stein, http://www.lyra.org/
,
-g
--
Greg Stein, http://www.lyra.org/
this you do...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
is allowed in any comma-separated list
unless explicitly specified otherwise).
And empirically: mod_dav has been overriding OPTIONS for a long while now,
and returning a list without spaces.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
, so...
:-)
Thanks for fixing this!
CHeers,
-g
--
Greg Stein, http://www.lyra.org/
* occurred,
and the application will probably stop all processing.
You could also say that it returns APR_OS_START_USEERR+1 to signify the
authentication problem. The app then maps that to HTTP_UNAUTHORIZED.
But to tie the filter stack to HTTP_ error codes is wrong.
Cheers,
-g
--
Greg Stein, http
On Tue, Mar 26, 2002 at 06:40:35PM -0500, Cliff Woolley wrote:
On Tue, 26 Mar 2002, Greg Stein wrote:
...
And empirically: mod_dav has been overriding OPTIONS for a long while now,
and returning a list without spaces.
Fine... but we should at least be consistent. Right now it's possible
the system not to do a walk?
[ ap_process_request_internal appears to run walks even when map_to_storage
is going to be used ]
From my standpoint, m-to-s isn't an option right now. I can't see how it
relates to the normal processing...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
, too, for the M_INVALID change(!!)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
on the
mlockall thing.
So the net result is: new behavior and a new directive to support a case
(httpd running as root) that we don't even want/like people doing in the
first place.
I'd be a heavy -0 on such a thing.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
will just maintain it myself.
-0 for modules/filters
+1 for modules/experimental
If you do a modules/example/, then experimental/mod_example.c should move,
too.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
/zlib/advisory-2002-03-11.txt
Regards
-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .)
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6
--
Greg Stein, http://www.lyra.org/
have to recognize the idiom
to quickly understand it, or take a small pause to process it. The while
form is also an idiom, but even simpler in construction.
As with Bill and Jeff, I'd put #2 into the style guide, and leave the others
out.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
talking about a single line. Go for compact for readibility.
Should the day ever arrive to extend, then it is a simple manipulation.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
, and URL namespace versioning.
- Jim
- End forwarded message -
--
Greg Stein, http://www.lyra.org/
is currently solved by using a sub-request to map a URI to
the filesystem. Ugly, but that is how the server is currently set up.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
. If you need to call
this function, then you should ask yourself why. Modules should be more
concerned with r-uri and r-filename.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
, then it needs to
change, and it *will* get changed.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
. If not, then you
go off and flush out other stuff that was pending. (that is: take advantage
of idle time) Once you're done with the work, then you go ahead and block
to get more work.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
scheduled program
Cheers,
-g
--
Greg Stein, http://wwwlyraorg/
it.
*/
-request_rec *cur = r;
-
Looks like there is a comment sitting there that doesn't apply any more...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
,
and we can derive the proper name from the HTTP model: resource
YES, resource is markedly better than CONTENT. I have been using
resource all day when explaining this to people at work. Always scary
when Greg and I agree. :-)
Oh, for christssakes... put up some kind of argument...
;-)
--
Greg
page to navigate to them (today,
mod_autoindex is hard-wired to the filesystem, which means we cannot apply
its mechanisms to collections of resources in a Subversion repository).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
with adding a prepend macro in the API if others agree
it's useful
That is *very* obtuse I can't imagine anybody figuring out that idiom means
prepend Yes, please add an appropriate macro
thx!
-g
--
Greg Stein, http://wwwlyraorg/
(apr_hash_t *table,
+ const void *key);
Those keys are strings, so the signature should be const char *. That type
is compatible with the hash table key type.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
extra layers to protect the children from a broken parent.
You might not be able to keep the parent running. What happens with the
Linux OOM killer decides to nuke it? Your parent may have zero bugs, but it
cannot defeat the OOM killer :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
? If it isn't there, then what happens?
Isn't that what APR is for?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
just checked in a fix for that, thanks to Zack Weinberg.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
-2.0.31-alpha/
What is with the darn underscores?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
all. For example,
ap_ind() and ap_rind() are bogus. For the rare case when somebody needs an
*index*, then they can compute the damned number themselves. No sense in
populating the API with noise.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
-slash by the time request processing starts...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
,
what, phdr);
-#endif
And one more to put back.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
. In other words, it seems
that you should be able to release the tarball, but would need to call it
alpha or development, but the group would shoot down things like beta
or final.
[ this last part I'm a bit fuzzy on, so would like commentary from the
*real* old-timers... ]
Cheers,
-g
--
Greg
{
+if (fname_p != NULL)
+*fname_p = NULL;
}
*dirpath_p is not set in the 'else' branch.
Also note that no callers expect those values to be set to NULL. Given that
the paths have been processed by Apache already, it's a good bet they are
always valid.
Cheers,
-g
--
Greg
On Thu, Jan 24, 2002 at 08:42:05AM -0600, William A. Rowe, Jr. wrote:
From: Greg Stein [EMAIL PROTECTED]
Sent: Thursday, January 24, 2002 4:09 AM
...
Looking at the usage of 'finfo', this could be APR_FINFO_SIZE
Yup, I had limited time ... so I simply made it work. That patch can
apr implemention]. Identified by Greg Stein.
Well, it was also intended to mean root URI path. There is no parent for
http://example.com/. Similarly, there is no parent for
http://example.com/foo/bar/ when that Location maps to C:/
(yes, the latter case has a parent, but mod_dav_fs
)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
it doesn't exist now.
I say torch the damned thing. You're quite right: removing zero length
buckets is Bad Juju.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
On Sat, Jan 12, 2002 at 09:25:30AM -0800, Brian Pane wrote:
Greg Stein wrote:
...
null parents are ugly. isn't there another pool that has the right lifetime
for that pool?
There isn't a pool with the right lifetime in the current
worker design. The safe pool to use as the parent would
some regex matching to some proxy functions,
however, and I plan on doing so *only* via separate directives.
Speak up now if this causes excess heartburn for anyone...
+1
+0 on torching the existing, overloaded forms. (and have Apache issue
warnings for a few releases)
Cheers,
-g
--
Greg Stein
!
--
Greg Stein, http://www.lyra.org/
?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
them the info and let *them* decide.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
like two params.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
stylistic mood? To wit,
It's all right with me! I already have all that set up by default, but it
doesn't hurt to put it into the file, too.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
them the better code.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
to that method.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
reasonable to me. The intent was always to run that hook right before
the handling starts. It would let everything get set up in the request_rec,
and then people can make choices about whether to insert filters.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
should probably be linking the modules with libtool's -module
switch. It would be interesting to see if that prevents the installation of
the .la file.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
On Thu, Dec 13, 2001 at 09:14:55PM -0500, Jeff Trawick wrote:
...
We already do link DSOs with -module, though we also throw on
-export-dynamic as well, which doesn't seem appropriate.
Well, some modules export symbols for use by other modules. Maybe that is
why?
Cheers,
-g
--
Greg Stein
])
--
Greg Stein, http://www.lyra.org/
;
char *error_fmt = NULL;
--
Greg Stein, http://www.lyra.org/
-parse_uri.port. Of course, they could also lie on
that port and the server wouldn't know any better.
I'm not exactly sure what the right answer to this is. Kind of a fundamental
problem with Apache not able to get a port number for this server.
Ideas? Thoughts?
Cheers,
-g
--
Greg Stein, http
(apr_mmap_t));
+memcpy(*new_mmap, old_mmap, sizeof(apr_mmap_t));
+(*new_mmap)-cntxt = p;
For the two dup() functions, you can use apr_pmemdup() to simplify this.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
the socket (only the core filters),
but the MPM definitely should. It is the beast which maps *sockets* to
*workers*. It has to know.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
be
APR_HOOK_MIDDLE. There is no reason for it to be last. The MIDDLE is the
standard one to use when you just need to pick something and have no
particular concerns about where it falls. The core_create_conn is just
another hook.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
for socket and worker handling.
I like the code changes for reducing the socket usage from Apache proper.
But removing it from the MPM isn't right.
Please explain :-(
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Unless I'm mistaken, some code got dropped from connection.c. In the current
CVS, it is at line 195. A call to apr_socket_close() and a return are
missing.
It looks like they disappeared when rev 1.87 was checked in.
Right/wrong?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
* the proxy code still refers to conn-client_socket
* perchild refers to conn-client_socket
-g
--
Greg Stein, http://www.lyra.org/
that. If the server dies with a particular subrequest executed
from some wonky CGI-provided SSI document, then say get this patch. But we
gotta get more releases out into the public's hands.
2.0.16 was crap. Should people really be using that? Not a chance.
Give them 2.0.28.
-g
--
Greg Stein, http
request
processing.
That is bogus, as has been pointed out. You have to close them sometime.
Doing it sooner rather than later means that you have more file descriptors
available for further processing in the request.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
?
That isn't right.
-g
--
Greg Stein, http://www.lyra.org/
...
How about: redirect-carefully
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
.
The apr_table_t is interesting in that it can keep multiple values for a
key. That is only really used for headers, and that can be best-solved by
using a new type.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
in a handler in a module - and
want to do it properly -i.e. through the filter chain etc.
Any place I can cut and paste this from :-)
Dw
--
Greg Stein, http://www.lyra.org/
***
*** 129,134
--- 129,138
Sfio_t *sf_in;
Sfio_t *sf_out;
#endif
+
+ void *callback_data;
+ void (*filter_callback)(BUFF *, const void *, int );
+
};
#ifdef B_SFIO
--
Greg Stein, http://www.lyra.org/
+base-response_code_strings = NULL;
+
conf-d = new-d;
conf-d_is_fnmatch = new-d_is_fnmatch;
conf-d_components = new-d_components;
--
Greg Stein, http://www.lyra.org/
301 - 400 of 483 matches
Mail list logo
