Jenkins build is back to normal : JMeter-trunk #5213

See

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

On 19 April 2016 at 23:44, Vladimir Sitnikov wrote: > sebb>Yes, but is a stack trace necessary here? > sebb>So long as it's obvious what the problem is and how to fix it without > > You do not think "catch (Exception e)" is obvious, do you? Depends. > What if it

buildbot success in on jmeter-trunk

The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/1026 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

sebb>Yes, but is a stack trace necessary here? sebb>So long as it's obvious what the problem is and how to fix it without You do not think "catch (Exception e)" is obvious, do you? What if it fails with NPE in unknown line? Vladimir

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

On 19 April 2016 at 22:40, vlsi wrote: > Github user vlsi commented on a diff in the pull request: > > https://github.com/apache/jmeter/pull/174#discussion_r60316883 > > --- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java --- > @@ -386,16 +384,14

[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...

Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/202#issuecomment-212154513 Hi Philippe, Like you can see in https://docs.oracle.com/javase/7/docs/api/java/io/File.html#canRead%28%29 "Returns: true if and only if the

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/203#issuecomment-212153353 Hi Philippe, My title of PR is not good I have modified xdocs/changes.xml file and not the html file Antonio --- If your project is set up

Build failed in Jenkins: JMeter-trunk #5212

See Changes: [vladimirsitnikov] Refactor TestCacheManager: replace duplicated code with inheritance Reduce timeouts from 5 to 1 seconds to speedup test execution closes #178 [vladimirsitnikov] Compress PNGs Working copy is reduced by

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/1023 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler

[GitHub] jmeter pull request: Compress PNGs

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...

Github user pmouawad commented on a diff in the pull request: https://github.com/apache/jmeter/pull/202#discussion_r60310491 --- Diff: src/components/org/apache/jmeter/control/IncludeController.java --- @@ -121,19 +121,20 @@ protected HashTree loadIncludedElements() {

[GitHub] jmeter pull request: Compress PNGs

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/177#issuecomment-212119570 Hi @vlsi , Will you commit this ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...

Github user pmouawad closed the pull request at: https://github.com/apache/jmeter/pull/179 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/178#issuecomment-212119461 Hi @vlsi , Will you commit this ? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

Github user pmouawad commented on the pull request: https://github.com/apache/jmeter/pull/203#issuecomment-212119330 Hi Antonio, I think it's a good idea. But if you want to create a PR for docs, you must update changes.xml . All html files are generated from xml.

Re: New website: horizontal scrolling?

On 19/04/2016 20:36, Felix Schumacher wrote: Am 17.04.2016 um 13:04 schrieb Milamber: Hello, In the next website (3.0), all pages have a horizontal scrolling on my computer with Firefox or Chrome (and same issue on Windows with Edge, IE, FF) On the current website, the horizontal

Build failed in Jenkins: JMeter-trunk #5211

See Changes: [pmouawad] Groovy is now embedded in JMeter [pmouawad] Use correct Cookie policy Http Request Defaults : Use up to date pool size Set View Results Tree file name to recording.xml to save the recording [pmouawad] Use

Re: New website: horizontal scrolling?

Am 17.04.2016 um 13:04 schrieb Milamber: Hello, In the next website (3.0), all pages have a horizontal scrolling on my computer with Firefox or Chrome (and same issue on Windows with Edge, IE, FF) On the current website, the horizontal scrolling don't exist. Do you know why ? (@Felix?) I

Re: New website: horizontal scrolling?

On Tue, Apr 19, 2016 at 9:25 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Felix> I have done a simple setup for how it might look like on > Felix> http://internetallee.de/~felix/jmeter/index.html > > As for me, star/fork/maven central buttons draw attention a little bit > too

Re: [VOTE] Release JMeter 3.0 RC2

Hi sebb, all, I don't know what to do. We depend on sbadmin which embeds a lot of dependencies but we don't use them all. My initial idea was not to touch it to ease upgrade. But now, we are moving license.txt files into jmeter license folder so changing it Regarding your remarks sebb: sebb:

Re: New website: horizontal scrolling?

Felix> I have done a simple setup for how it might look like on Felix> http://internetallee.de/~felix/jmeter/index.html As for me, star/fork/maven central buttons draw attention a little bit too much: their colors are not in line with the page. What if we have just "fork me on github" ribbon

Re: sbadmin2 is now at 1.0.8

It was changed by me after your remark on license. i will revert this. Our version is 1.0.7 which is an Apache license and the readme was ok in fact On Tuesday, April 19, 2016, sebb wrote: > We seem to have the source from 1.0.7, but the README is now from 1.0.8 > > It looks

Re: New website: horizontal scrolling?

On Tuesday, April 19, 2016, Felix Schumacher < felix.schumac...@internetallee.de> wrote: > Am 19.04.2016 um 19:40 schrieb Vladimir Sitnikov: > >> Felix>I thought of a social bar at the right side of the content div, >> where only small buttons are shown for the various social media sides >> (like

Re: New website: horizontal scrolling?

Felix>I thought of a social bar at the right side of the content div, where only small buttons are shown for the various social media sides (like twitter, g+ or facebook). A sample of such an implementation could be seen on heise.de. +1 Felix>The badges for github I think just one github icon

Re: New website: horizontal scrolling?

Am 17.04.2016 um 15:16 schrieb Milamber: I will commit my changes to reduce the size of the block. We can continue to discuss to the better place for the Twitter button and/or the github/mc buttons, that isn't a blocker for the 3.0 release. Perhaps, Felix can purpose later some variants of

Re: [VOTE] Release JMeter 3.0 RC2

On 19 April 2016 at 14:10, Milamber wrote: > > > On 19/04/2016 01:32, sebb wrote: >> >> On 17 April 2016 at 18:03, Milamber wrote: >>> >>> Hello, >>> >>> The second release candidate for JMeter 3.0 (r1739623) has been prepared, >>> and your votes are

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

But wasn't it non final in previous commit ? On Tue, Apr 19, 2016 at 4:13 PM, sebb wrote: > On 19 April 2016 at 13:54, Felix Schumacher > wrote: > > > > > > Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org: > >>Author: sebb > >>Date:

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

On 19 April 2016 at 13:54, Felix Schumacher wrote: > > > Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org: >>Author: sebb >>Date: Tue Apr 19 12:40:57 2016 >>New Revision: 1739924 >> >>URL: http://svn.apache.org/viewvc?rev=1739924=rev >>Log: >>Field can

Re: [VOTE] Release JMeter 3.0 RC2

On 19/04/2016 01:32, sebb wrote: On 17 April 2016 at 18:03, Milamber wrote: Hello, The second release candidate for JMeter 3.0 (r1739623) has been prepared, and your votes are solicited. This release brings a lot of new features (over 100) and fixes many bugs (60). If

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org: >Author: sebb >Date: Tue Apr 19 12:40:57 2016 >New Revision: 1739924 > >URL: http://svn.apache.org/viewvc?rev=1739924=rev >Log: >Field can still be final > >Modified:

sbadmin2 is now at 1.0.8

We seem to have the source from 1.0.7, but the README is now from 1.0.8 It looks as though the license changed from AL2.0 in 1.0.7 to MIT in 1.0.8 So at the moment we have a mixture of the two releases. Source is mainly 1.0.7 (I assume) and README/LICENSE from 1.0.8. This needs to be fixed.

Re: [VOTE] Release JMeter 3.0 RC2

Also bin/report-template/sbadmin2-1.0.7/bower_components/datatables/license.txt bin/report-template/sbadmin2-1.0.7/bower_components/raphael/license.txt On 19 April 2016 at 12:54, sebb wrote: > On 19 April 2016 at 12:40, Philippe Mouawad > wrote:

Re: [VOTE] Release JMeter 3.0 RC2

On 19 April 2016 at 12:40, Philippe Mouawad wrote: > On Tue, Apr 19, 2016 at 12:35 PM, sebb wrote: > >> On 19 April 2016 at 11:30, Philippe Mouawad >> wrote: >> > On Tue, Apr 19, 2016 at 12:20 PM, sebb

buildbot success in on jmeter-trunk

The Buildbot has detected a restored build on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/1015 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler

Re: [VOTE] Release JMeter 3.0 RC2

On Tue, Apr 19, 2016 at 12:35 PM, sebb wrote: > On 19 April 2016 at 11:30, Philippe Mouawad > wrote: > > On Tue, Apr 19, 2016 at 12:20 PM, sebb wrote: > > > >> Also the actual file names covered by the licenses need to be

Re: Why does LogkitLoggerAdapter implement Serializable?

Fixed by: http://svn.apache.org/viewvc?rev=1739903=rev On Tue, Apr 19, 2016 at 12:16 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hi Sebb, > The ancestor is Serializable. > Existing implementations for other log frameworks are Serializable so I > would say yes. > > > > Regards > >

Jenkins build is back to normal : JMeter-trunk #5207

See

LICENSE ought to contain locations of the icons

The LICENSE file ought to contain the location(s) of the Open Icon library icons

Re: [VOTE] Release JMeter 3.0 RC2

On 19 April 2016 at 11:30, Philippe Mouawad wrote: > On Tue, Apr 19, 2016 at 12:20 PM, sebb wrote: > >> Also the actual file names covered by the licenses need to be mentioned. >> > > Can you be more explicit or do it ? > I don't understand. > Is the

Re: [VOTE] Release JMeter 3.0 RC2

On Tue, Apr 19, 2016 at 12:20 PM, sebb wrote: > Also the actual file names covered by the licenses need to be mentioned. > Can you be more explicit or do it ? I don't understand. Is the folder enough ? > > Note that the binary LICENSE section includes the full jar name, >

Re: [VOTE] Release JMeter 3.0 RC2

Also the actual file names covered by the licenses need to be mentioned. Note that the binary LICENSE section includes the full jar name, including the .jar. The source section needs to do likewise. There may need to be some updates to the unit test to deal with the source licenses. On 19 April

Re: Why does LogkitLoggerAdapter implement Serializable?

Hi Sebb, The ancestor is Serializable. Existing implementations for other log frameworks are Serializable so I would say yes. Regards On Tue, Apr 19, 2016 at 11:58 AM, sebb wrote: > PING - I think we need to resolve this before the re-release > > On 2 April 2016 at 13:59,

Re: [VOTE] Release JMeter 3.0 RC2

These are *source* files so the licenses belong under license/src. Also the final section of the main LICENSE file is intended for binary-only code. (It's not all that obvious at present) On 19 April 2016 at 07:33, Philippe Mouawad wrote: > Hi sebb, > I filled in in

Build failed in Jenkins: JMeter-trunk #5206

See Changes: [sebb] Fix MacOSX doc icon -- [...truncated 1311 lines...] [javadoc] Loading source files for package org.apache.jmeter.gui.action... [javadoc] Loading source files for package

Re: Why does LogkitLoggerAdapter implement Serializable?

PING - I think we need to resolve this before the re-release On 2 April 2016 at 13:59, sebb wrote: > Anyone? > > Code was added by Philippe as part of Bugzilla Id: 59240 > > > On 1 April 2016 at 00:29, sebb wrote: >> Is there any need to serialise this class?

Re: [VOTE] Release JMeter 3.0 RC2

Hi, The build failed with "[java] java.lang.AssertionError: LICENSE does not contain entry for bootstrap-3.3.4" error message. My PR don't modify any licence. Build is it broken? Do I need to do something? Thank Antonio 2016-04-19 9:19 GMT+02:00 Antonio Gomes Rodrigues : >

Re: [VOTE] Release JMeter 3.0 RC2

Hi, I propose to modify a little changes.html to be more clear about deprecated elements. I have add Spline Visualizer listener and Distribution Graph listener which are not mentioned in changes.xml See https://bz.apache.org/bugzilla/show_bug.cgi?id=59353 with the associated PR Antonio

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/203 Bug59353_NewPartInChanges.html Hi, I propose to have a dedicated part called "Deprecated and removed elements" in "Incompatible changes" part in changes.xml Like that it will be

Build failed in Jenkins: JMeter-trunk #5205

See Changes: [pmouawad] Bug 59350 - Add a space after "Writing log file to:" log message Contributed by Antonio Gomes Rodrigues #resolve #201 Bugzilla Id: 59350 [pmouawad] Bug 59345 - SMTPSampler connection leak #resolve #198 Bugzilla

[GitHub] jmeter pull request: Bug59350_WritingLogFileTo

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jmeter pull request: Bug 59345 - SMTPSampler connection leak

Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Release JMeter 3.0 RC2

I moved and renamed the license files mentioned by sebb @milamber I let you manage the other problems. Regards On Tue, Apr 19, 2016 at 8:33 AM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hi sebb, > I filled in in root LICENSE file the license information for the 4 > components. >

buildbot failure in on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/1009 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: The AnyBranchScheduler

Re: [VOTE] Release JMeter 3.0 RC2

Hi sebb, I filled in in root LICENSE file the license information for the 4 components. Do we need to also add the MIT license in license/bin folder ? Thanks On Tue, Apr 19, 2016 at 3:24 AM, sebb wrote: > On 19 April 2016 at 01:32, sebb wrote: > > On 17