Re: Colorized console

2015-04-04 Thread Igor Fedorenko
How do you expect this to work during multithreaded build, when there is more than one running plugin at any given time? What you probably want is some sort of thread-local logging level, which can be scoped to specific plugin and configured from the core. -- Regards, Igor On Sat, Apr 4, 2015,

Re: Colorized console

2015-04-04 Thread Robert Scholte
Indeed, that's how it should work. What's important to me is that the logging is *not* reduced to the plugin classes. So also Maven Core should switch to this new root logging level (for this thread), because that often gives the required info you need. Anyhow, it is a challenge, but I'm

Re: Colorized console

2015-04-04 Thread Robert Scholte
In case of logging frameworks you actually want to know the configuration before starting the application, in this case Maven. On my todo list is still a wish to change the logging level once reaching a specific plugin. Concrete: debugging is now way too verbose. In most cases you just want

Re: Colorized console

2015-04-01 Thread Romain Manni-Bucau
I'm +1 to have color by default but wonder if associated config shouldn't be in settings.xml. Personally my mvn often looks like: http://img11.hostingpics.net/pics/867383mvn.png Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github

Re: Colorized console

2015-04-01 Thread Arnaud Héritier
Right. In CI server we may have ansi colors (at least in jenkins) but yes we may consider to deactivate color with batch mode. Or we add a new command line option to turn it off. On Wed, Apr 1, 2015 at 5:48 PM, Manfred Moser manf...@mosabuam.com wrote: I agree we should activate colors by

Re: Colorized console

2015-04-01 Thread Arnaud Héritier
Yes for now color settings have to be in ${MAVEN_HOME}/ conf/logging/log4j2.xml For it gives this : https://www.dropbox.com/s/ottf0nc11sscgsz/Screenshot%202015-04-01%2018.19.11.png?dl=0 But I agree we won't make everyone happy and people will want to adapt them On Wed, Apr 1, 2015 at 6:04 PM,

Re: Colorized console

2015-04-01 Thread Manfred Moser
I agree we should activate colors by default, but only if they are automatically turned OFF in batch mode so that logs in CI server runs are no invalidated in terms of readability. manfred Arnaud Héritier wrote on 01.04.2015 02:33: Hi, Yesterday I rebased, cleaned and updated the

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-09 Thread Robert Scholte
I've tested this on Windows, there's only one small issue: the info-text is probably black, which makes it unreadable on the default background-color, which is black as well. The rest looks great! Op Mon, 03 Dec 2012 14:47:24 +0100 schreef Olivier Lamy ol...@apache.org: 2012/12/3 Marc

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-09 Thread Gary Gregory
ANSI can set the BG color... Gary On Dec 9, 2012, at 8:25, Robert Scholte rfscho...@apache.org wrote: I've tested this on Windows, there's only one small issue: the info-text is probably black, which makes it unreadable on the default background-color, which is black as well. The rest

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-09 Thread Arnaud Héritier
Just tested it. It's working fine Thx a lot. On Sun, Dec 9, 2012 at 4:38 AM, Jason van Zyl ja...@tesla.io wrote: Arnaud, It's all in there now. While I was fixing the logging in embedded mode for SLF4J Simple, I updated the Logback branch to do the same. I had to patch SLF4J Simple to get

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-09 Thread Arnaud Héritier
yes we discussed about it. That one reason why we should not activate it by default. We'll never find a solution that will satisfy everybody On Sun, Dec 9, 2012 at 2:25 PM, Robert Scholte rfscho...@apache.org wrote: I've tested this on Windows, there's only one small issue: the info-text is

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-08 Thread Jason van Zyl
Arnaud, It's all in there now. While I was fixing the logging in embedded mode for SLF4J Simple, I updated the Logback branch to do the same. I had to patch SLF4J Simple to get around some static initialization that doesn't work in embedded mode so I haven't updated trunk, but the Logback

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-04 Thread Arnaud Héritier
Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug cheers Arnaud On Sat, Dec 1, 2012 at 6:47 PM, Jason van Zyl ja...@tesla.io wrote: I already have started a logback version, but I don't think this should affect rolling the 3.1.0.

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-04 Thread Jason van Zyl
On Dec 4, 2012, at 9:44 AM, Arnaud Héritier aherit...@gmail.com wrote: Jason, I'll test more later but FYI it seems that your logback branch doesn't support options -X/--debug I've been talking to Ceki about configuration in SLF4J as there is really no way to change the log level

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-04 Thread Olivier Lamy
I did that in the branches using sys props properties property name=maven.logging.root.levelINFO/property /properties root level=${sys:maven.logging.root.level} appender-ref ref=console/ /root When starting and before any slf4j access, MavenCli check -q or -X or none of

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-04 Thread ceki
On 04.12.2012 19:18, Jason van Zyl wrote: I've been talking to Ceki about configuration in SLF4J as there is really no way to change the log level without assuming an implementation. If that's the way then for embedding the user can change the SLF4J implementation but for the CLI this will

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Marc Pasteur
hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by default ? [1]

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Olivier Lamy
2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in the console jansi.jar mut be put on maven/lib/ext folder Can it be by

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Gary Gregory
On Mon, Dec 3, 2012 at 8:47 AM, Olivier Lamy ol...@apache.org wrote: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to log4j2 docs [1] you need some additional library to make this works on Windows. So if you don't want to display some ←[37m[ stuffs in

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Arnaud Héritier
yes it is the same thing for logback version For sure we'll provided it by default the day we'll provide this feature. On Mon, Dec 3, 2012 at 2:05 PM, Marc Pasteur marc.past...@gmail.com wrote: hi, For the record according to log4j2 docs [1] you need some additional library to make this

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Arnaud Héritier
I had the feedback (not tested myself) that the log4j2 (I suppose it is the same for the logback) adds colors in netbeans console. Arnaud On Mon, Dec 3, 2012 at 2:47 PM, Olivier Lamy ol...@apache.org wrote: 2012/12/3 Marc Pasteur marc.past...@gmail.com: hi, For the record according to

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-03 Thread Marc Pasteur
works fine but as someone (don't remember who... arnaud maybe) said the color for info message is black so... not so readable on a black background :-) for la vie en rose i've to made a patch as only MAGENTA is allowed at the moment but that could be cute :-) it works neither in intellij nor in

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-02 Thread Arnaud Héritier
I agree but sincerely I'm sure that less than 0,01% of our users will customize their logs. On Sat, Dec 1, 2012 at 9:27 PM, Anders Hammar and...@hammar.net wrote: In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-02 Thread Arnaud Héritier
Thanks a lot to have pushed it. I tested it with success I like it, at least something that will improve the user experience soon. Note : Like Olivier's branch the default logging setup has an issue because the default color is set to black (or white) which are backgrounds colors commonly used.

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-02 Thread Arnaud Héritier
+1 I don't think we'll have another minor release before the end of the year. For sure it won't be included in a bug fix release. We already release a minor release without (or so few) end-user value, we won't start to add new feature in a bug fix release :-) Arnaud On Sat, Dec 1, 2012 at 7:33

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-01 Thread Arnaud Héritier
I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with latest master changes You can test the distro of this code : http://cl.ly/1B1z051O0T10 Tonight I'll try to do a logback version cheers Arnaud On Sat, Dec 1, 2012 at 11:15 AM,

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-01 Thread Jason van Zyl
I already have started a logback version, but I don't think this should affect rolling the 3.1.0. On Dec 1, 2012, at 6:57 AM, Arnaud Héritier aherit...@gmail.com wrote: I pushed the prototype developed by olivier using log4j2 in the branch feature/colorized-console/log4j2 I updated with

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-01 Thread Benson Margulies
OK, 3.1.1 or 3.1-m2 or whatever before Christmas. Let's get this fish out of the store and move on to the next one. On Sat, Dec 1, 2012 at 1:31 PM, Gary Gregory garydgreg...@gmail.com wrote: Oh do please give us a color console for Christmas :) Gary On Dec 1, 2012, at 12:47, Jason van Zyl

Re: Colorized console and logging implementation choice was Re: Re-spinning 3.1.0

2012-12-01 Thread Anders Hammar
In any case doing a choice nowadays for 3.1.0 won't prevent us to change it in the future. I really hope that the ability to switch from a logger implementation to another won't require several days of developments or I really missed something about it. Well, very likely it would affect the