---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45345
---
Patch looks great!
Reviews applied: [22424]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review45347
---
src/slave/slave.cpp
On June 11, 2014, 8:18 a.m., Yifan Gu wrote:
src/slave/slave.cpp, line 1204
https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1204
I found that these kind of checkers
(check framework/executor/slave state, then do some action)
appears in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated June 11, 2014, 8:50 a.m.)
Review request for mesos, Ian Downes and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2166/changes
Changes:
[vinod] Revert Switched to subprocess.Popen to get stdout streamed from
--
[...truncated 43806 lines...]
I0611 08:54:12.101644 14904
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review45350
---
Looks great. Just a couple of comments from me, and then I'll let
On June 11, 2014, 9:05 a.m., Adam B wrote:
src/slave/slave.cpp, line 1207
https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1207
Am I blind? Where does 'executor' come from? You have executorId to
start with, and it's not until later in this function that
On June 11, 2014, 2:05 a.m., Adam B wrote:
src/slave/slave.cpp, line 1207
https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1207
Am I blind? Where does 'executor' come from? You have executorId to
start with, and it's not until later in this function that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated June 11, 2014, 9:32 a.m.)
Review request for mesos, Ian Downes and
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2167/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/#review45367
---
Patch looks great!
Reviews applied: [22441]
All tests passed.
-
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1892/changes
Changes:
[dlester] Updates Mesos version in Getting Started guide to 0.19.0
[dlester] Simplifies documentation headers.
--
[...truncated 56264 lines...]
See https://builds.apache.org/job/mesos-reviewbot/879/
--
[...truncated 4641 lines...]
mesos-0.20.0 archives ready for distribution:
mesos-0.20.0.tar.gz
==
real60m50.832s
user71m56.778s
sys 5m12.168s
On June 11, 2014, 2:05 a.m., Adam B wrote:
src/slave/slave.cpp, line 1207
https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1207
Am I blind? Where does 'executor' come from? You have executorId to
start with, and it's not until later in this function that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22251/#review45391
---
Ship it!
Ship It!
- Jie Yu
On June 10, 2014, 5:57 p.m., Ian
On June 11, 2014, 1:18 a.m., Yifan Gu wrote:
src/slave/slave.cpp, line 1204
https://reviews.apache.org/r/22313/diff/5/?file=606994#file606994line1204
I found that these kind of checkers
(check framework/executor/slave state, then do some action)
appears in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20817/
---
(Updated June 11, 2014, 10:27 a.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20818/
---
(Updated June 11, 2014, 10:27 a.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22064/
---
(Updated June 11, 2014, 10:27 a.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21443/
---
(Updated June 11, 2014, 10:29 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21451/
---
(Updated June 11, 2014, 10:29 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22064/#review45396
---
src/slave/containerizer/linux_launcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/
---
(Updated June 11, 2014, 10:39 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/
---
(Updated June 11, 2014, 10:39 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22427/
---
(Updated June 11, 2014, 10:39 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22425/
---
(Updated June 11, 2014, 10:39 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22427/#review45334
---
src/master/master.cpp
On June 10, 2014, 11:32 a.m., Dominic Hamon wrote:
include/mesos/mesos.proto, line 672
https://reviews.apache.org/r/22425/diff/1/?file=606515#file606515line672
s/of be/to be/
Done.
- Jiang Yan
---
This is an automatically
On June 10, 2014, 11:30 a.m., Dominic Hamon wrote:
src/master/master.hpp, line 530
https://reviews.apache.org/r/22316/diff/2/?file=606511#file606511line530
Are we going to add more of these? It might make sense to combine them:
struct PerFrameworkPrincipalMetrics
On June 10, 2014, 2:06 p.m., Benjamin Hindman wrote:
src/master/master.hpp, lines 245-246
https://reviews.apache.org/r/22427/diff/1/?file=606520#file606520line245
Likely can just call these '_visit' since the signatures are different
due to the argument types.
Casted the
On June 10, 2014, 11:38 a.m., Dominic Hamon wrote:
src/master/master.cpp, line 380
https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line380
This seems arbitrary - why do we need to do this?
It's no longer necessary as I have revised RateLimiter to take a double
On June 10, 2014, 2:43 p.m., Vinod Kone wrote:
src/master/master.hpp, lines 245-246
https://reviews.apache.org/r/22427/diff/1/?file=606520#file606520line245
can you use casting to make it work? see authorizer for example.
Yes! Thanks.
On June 10, 2014, 2:43 p.m., Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/#review45398
---
Ship it!
Ship It!
- Ian Downes
On June 10, 2014, 1:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/#review45320
---
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45402
---
Ship it!
Ship It!
- Vinod Kone
On June 11, 2014, 5:39 p.m.,
if necessary
I0611 18:09:23.725260 6115 master.cpp:2620] Registering slave at
slave(181)@140.211.11.27:56092 (hemera.apache.org) with id
20140611-180923-453759884-56092-6066-0
I0611 18:09:23.725795 6115 registrar.cpp:422] Attempting to update the
'registry'
I0611 18:09:23.725899 6066 sched.cpp:128
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/#review45407
---
src/tests/slave_recovery_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21451/#review45409
---
Ship it!
Ship It!
- Vinod Kone
On June 11, 2014, 5:29 p.m., Ian
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1893/changes
[
https://issues.apache.org/jira/browse/MESOS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028194#comment-14028194
]
Yifan Gu commented on MESOS-1460:
-
Oops, seems I should ignore subsequent updates to the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21594/
---
(Updated June 11, 2014, 6:44 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22471/
---
(Updated June 11, 2014, 6:54 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22471/
---
Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
Repository:
See https://builds.apache.org/job/mesos-reviewbot/880/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22426/#review45414
---
Patch looks great!
Reviews applied: [22426]
All tests passed.
-
[
https://issues.apache.org/jira/browse/MESOS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028251#comment-14028251
]
Yifan Gu commented on MESOS-1460:
-
I compared this log to a successful log,
It looks like
[
https://issues.apache.org/jira/browse/MESOS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028251#comment-14028251
]
Yifan Gu edited comment on MESOS-1460 at 6/11/14 7:17 PM:
--
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22472/
---
(Updated June 11, 2014, 7:18 p.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3/
---
(Updated June 11, 2014, 7:34 p.m.)
Review request for mesos, Adam B, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21734/#review45417
---
Bad patch!
Reviews applied: [21734]
Failed command: make -j3
See https://builds.apache.org/job/mesos-reviewbot/881/
--
[...truncated 4744 lines...]
Removing src/deploy/mesos-start-slaves.sh
Removing src/deploy/mesos-stop-cluster.sh
Removing src/deploy/mesos-stop-masters.sh
Removing src/deploy/mesos-stop-slaves.sh
Hi All,
Below is the announcement that we recently posted to the Apache Mesos blog:
http://mesos.apache.org/blog/mesoscon-2014-program-announced/. Please
spread the word.
Looking forward to seeing you all in Chicago at #MesosCon!
Dave
___
Today we’re excited to announce the program
On June 11, 2014, 10:57 a.m., Vinod Kone wrote:
src/tests/rate_limiting_tests.cpp, lines 512-513
https://reviews.apache.org/r/22316/diff/3/?file=607141#file607141line512
there is no throttling because rate limiting is not setup correct?
Yeah I meant to add it to the framework
On June 11, 2014, 10:55 a.m., Vinod Kone wrote:
src/master/master.cpp, lines 3316-3317
https://reviews.apache.org/r/22316/diff/2/?file=606512#file606512line3316
Why is this Owned and on a heap?
It can't be an plain object because Counter doesn't have a default constructor
thus
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22316/
---
(Updated June 11, 2014, 1:49 p.m.)
Review request for mesos, Ben Mahler,
On June 10, 2014, 11:30 a.m., Dominic Hamon wrote:
src/master/master.hpp, line 530
https://reviews.apache.org/r/22316/diff/2/?file=606511#file606511line530
Are we going to add more of these? It might make sense to combine them:
struct PerFrameworkPrincipalMetrics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22441/
---
(Updated June 11, 2014, 2:01 p.m.)
Review request for mesos, Ian Downes and
[
https://issues.apache.org/jira/browse/MESOS-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler resolved MESOS-1348.
Resolution: Fixed
Fix Version/s: (was: 0.19.0)
0.20.0
On June 10, 2014, 11:38 a.m., Dominic Hamon wrote:
src/master/master.cpp, line 383
https://reviews.apache.org/r/22427/diff/1/?file=606521#file606521line383
why not clean these up during finalize?
Jiang Yan Xu wrote:
Because they are owned?
good point! i'm a little concerned
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22424/#review45430
---
3rdparty/libprocess/include/process/limiter.hpp
See https://builds.apache.org/job/mesos-reviewbot/882/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/#review45437
---
Patch looks great!
Reviews applied: [22313]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22064/
---
(Updated June 11, 2014, 3:21 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20817/
---
(Updated June 11, 2014, 3:21 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20818/
---
(Updated June 11, 2014, 3:21 p.m.)
Review request for mesos and Jie Yu.
Ian Downes created MESOS-1472:
-
Summary: Improve child exit if slave dies during executor launch
in MC
Key: MESOS-1472
URL: https://issues.apache.org/jira/browse/MESOS-1472
Project: Mesos
Issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21443/#review45441
---
Bad patch!
Reviews applied: [21442, 21443]
Failed command: git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22064/#review45440
---
src/slave/containerizer/isolators/cgroups/cpushare.cpp
[
https://issues.apache.org/jira/browse/MESOS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ian Downes updated MESOS-1472:
--
Sprint: Q2 Sprint 3
Improve child exit if slave dies during executor launch in MC
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22481/
---
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-1472
[
https://issues.apache.org/jira/browse/MESOS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028527#comment-14028527
]
Ian Downes commented on MESOS-1472:
---
https://reviews.apache.org/r/22481
Improve child
] Failed to collect resource usage
for container '19b19f0d-a221-44e4-986f-2c0242885c79' for executor 'default' of
framework '20140611-222850-160088899-55296-20940-': Unknown container:
19b19f0d-a221-44e4-986f-2c0242885c79
I0611 23:18:22.728389 20971 monitor.cpp:140] Failed to collect resource
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22481/#review45443
---
Ship it!
Ship It!
- Jie Yu
On June 11, 2014, 10:47 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22064/
---
(Updated June 11, 2014, 11:31 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21379/#review45445
---
Just a small amount of cleanup and we should be all set! Please
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/137/changes
Changes:
[bmahler] Fixed child process leaks in SlaveRecoveryTest.GCExecutor.
--
[...truncated 36932 lines...]
I0611 23:38:53.991155 6725 hierarchical_allocator_process.hpp:686]
Thomas Rampelberg created MESOS-1473:
Summary: Mesos slave becomes unresponsive after launching 8
external containers
Key: MESOS-1473
URL: https://issues.apache.org/jira/browse/MESOS-1473
See https://builds.apache.org/job/mesos-reviewbot/885/
--
[...truncated 4581 lines...]
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21451/#review45454
---
Bad patch!
Reviews applied: [21442, 20963, 21451]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21594/#review45455
---
Bad patch!
Reviews applied: [21594]
Failed command: git apply
See https://builds.apache.org/job/mesos-reviewbot/886/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22471/#review45457
---
Bad patch!
Reviews applied: [22471]
Failed command: make -j3
See https://builds.apache.org/job/mesos-reviewbot/887/
--
[...truncated 4581 lines...]
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22472/#review45462
---
Patch looks great!
Reviews applied: [22472]
All tests passed.
-
See https://builds.apache.org/job/mesos-reviewbot/888/
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/138/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2170/changes
Changes:
[vinod] Updated verify-reviews to catch exceptions during cleanup.
--
[...truncated 49667 lines...]
2014-06-12
87 matches
Mail list logo