---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 22, 2014, 5:25 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 22, 2014, 5:30 a.m.)
Review request for mesos, Benjamin
On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
src/module/manager.hpp, line 88
https://reviews.apache.org/r/25848/diff/1/?file=697028#file697028line88
Can we find some ABI documentation that supports this claim and maybe
throw in a reference?
Added a TODO for now.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review54118
---
Bad patch!
Reviews applied: [25848]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/
---
(Updated Sept. 22, 2014, 1:10 p.m.)
Review request for mesos, Benjamin
On Sept. 11, 2014, 3:45 p.m., Timothy St. Clair wrote:
src/exec/exec.cpp, line 82
https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line82
Maybe I'm missing something, but is there a reason we don't check
before a delay? If ShutdownProcess is spawned, it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54127
---
Patch looks great!
Reviews applied: [25622]
All tests passed.
-
Folks,
I think this thread has fallen off the rails a bit, perhaps we could get a
tcon/hangout going for this again.
I would be happy to moderate if needed, but it's pretty clear to me to that
trying to hash this out in an email thread is becoming couter-productive.
Cheers,
Tim
-
We now start using auto in the code (among several other C++11 features).
However we don't want to hamper reasoning about types. I would suggest we
select several use cases where we all agree using auto is welcomed and
several counterexamples. After the short conversation with BenH, we agreed
that
Agreed - I can do early morning PST any day during this week (for people
dialing in from the east coast and Europe).
Niklas
On 22 September 2014 07:15, Tim St Clair tstcl...@redhat.com wrote:
Folks,
I think this thread has fallen off the rails a bit, perhaps we could get a
tcon/hangout
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25250/
---
(Updated Sept. 22, 2014, 4:25 p.m.)
Review request for mesos, Benjamin Hindman
On Sept. 15, 2014, 4:38 p.m., Benjamin Hindman wrote:
src/master/master.cpp, line 4010
https://reviews.apache.org/r/25250/diff/4/?file=682254#file682254line4010
I suggest we use TASK_LOST here instead. We definitely want a terminal
state like TASK_KILLED, but we've reserved
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54125
---
Thanks Jie! 1st pass testing worked, but I need to beat on it some
On Sept. 22, 2014, 4:31 p.m., Timothy St. Clair wrote:
src/linux/cgroups.cpp, line 1795
https://reviews.apache.org/r/25858/diff/1/?file=698357#file698357line1795
I think I've missed something subtle, how did you bypass the cleanup
semantics?
The isolators won't try to unmount
On Sept. 22, 2014, 4:31 p.m., Timothy St. Clair wrote:
Thanks Jie! 1st pass testing worked, but I need to beat on it some more.
Normally I would say we should probably separate out the cleanup work from
the feature mod, but it's not that important to me.
Sorry about that. I should
For reference:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#auto
We should be able to adopt that wholesale but please document anywhere you
think we would diverge from those examples.
On Mon, Sep 22, 2014 at 7:28 AM, Alex Rukletsov a...@mesosphere.io wrote:
We now start
On Sept. 20, 2014, 12:22 p.m., Ben Mahler wrote:
Thanks Joris!
Any reason you want this exposed in the public include/ folder of
libprocess, as opposed to an internal header inside src/? Don't think we'd
want this in the public includes.
It seems to be a bit unconsistent whether
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54140
---
docs/mesos-c++-style-guide.md
+1.
On Sep 22, 2014, at 5:22 PM, Niklas Nielsen nik...@mesosphere.io wrote:
Agreed - I can do early morning PST any day during this week (for people
dialing in from the east coast and Europe).
Niklas
On 22 September 2014 07:15, Tim St Clair tstcl...@redhat.com wrote:
Folks,
I think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 22, 2014, 5:30 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54141
---
Ship it!
src/linux/cgroups.cpp
On Sept. 20, 2014, 7:22 p.m., Ben Mahler wrote:
Thanks Joris!
Any reason you want this exposed in the public include/ folder of
libprocess, as opposed to an internal header inside src/? Don't think we'd
want this in the public includes.
Niklas Nielsen wrote:
It seems to be
There are some cases where using auto for function return type deduction is
necessary to be able to state what you want generically in templates, and I
think we should allow that use case. I can ping some friends for good
examples if people would like. Definitely general use of return type
Hello
Here's our focus for the next two weeks. Some of these we are shepherding,
but are high enough profile that we want to track them.
Link to active sprint
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=35
Task reconciliation:
- Removing out-of-order updates
Isolation:
-
On Sept. 22, 2014, 5:33 p.m., Ian Downes wrote:
src/linux/cgroups.cpp, line 517
https://reviews.apache.org/r/25858/diff/1/?file=698357#file698357line517
Not your code, but it's a little silly to do this every time...
Added a TODO.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25861/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25862/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/
---
(Updated Sept. 22, 2014, 11:45 a.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/
---
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54165
---
Ship it!
Ship It!
- Timothy St. Clair
On Sept. 20, 2014, 12:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54164
---
src/linux/cgroups.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review54166
---
src/linux/cgroups.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25862/#review54167
---
src/slave/containerizer/linux_launcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/#review54169
---
src/slave/containerizer/isolators/namespaces/pid.cpp
On Sept. 20, 2014, 7:22 p.m., Ben Mahler wrote:
Thanks Joris!
Any reason you want this exposed in the public include/ folder of
libprocess, as opposed to an internal header inside src/? Don't think we'd
want this in the public includes.
Niklas Nielsen wrote:
It seems to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review54170
---
Why do you need this?
Seems like one would only watch for cgroup
On Sept. 19, 2014, 5:24 p.m., Adam B wrote:
I think it's valuable to outline some guidelines for anybody interested in
becoming a committer, but I don't think we should set too many strict rules
and regulations around it. Other thoughts below.
I think exactly the opposite. I think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review54173
---
docs/mesos-c++-style-guide.md
On Sept. 22, 2014, 12:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, line 104
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line104
Will work with gcc 4.4+? :)
yes. it's in the configure check :)
- Dominic
On Sept. 22, 2014, 12:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
-1
naming a variable after
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
On Sept. 20, 2014, 7:22 p.m., Ben Mahler wrote:
Thanks Joris!
Any reason you want this exposed in the public include/ folder of
libprocess, as opposed to an internal header inside src/? Don't think we'd
want this in the public includes.
Niklas Nielsen wrote:
It seems to be
On Sept. 22, 2014, 7:19 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, lines 96-99
https://reviews.apache.org/r/25622/diff/3/?file=699636#file699636line96
Why would the iterator be called `containerizer`?
s/containerizer/iterator/ ?
Dominic Hamon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review54179
---
Patch looks great!
Reviews applied: [25655, 24177, 25549]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review54181
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/
---
(Updated Sept. 22, 2014, 8:35 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25858/#review54187
---
Ship it!
Ship It!
- Timothy Chen
On Sept. 22, 2014, 8:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25863/#review54193
---
Patch looks great!
Reviews applied: [25863]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 22, 2014, 9:17 p.m.)
Review request for mesos and Ben Mahler.
Jumping on a tcon/hangout sounds healthy, but given I'm traveling right now
in Europe and timing is difficult I'm going to comment inline here.
- callsites need to be modules aware to use the right factory method to
instantiate the modular object
I don't know how else you'd accomplish making
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25862/#review54198
---
Bad patch!
Reviews applied: [25861]
Failed command: git apply
On Mon, Sep 22, 2014 at 2:36 PM, Benjamin Hindman b...@eecs.berkeley.edu
wrote:
Jumping on a tcon/hangout sounds healthy, but given I'm traveling right now
in Europe and timing is difficult I'm going to comment inline here.
- callsites need to be modules aware to use the right factory method
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-1817
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/#review54201
---
Did you look at the diff when you posted this review? Looks like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25865/#review54203
---
Bad patch!
Reviews applied: [25865]
Failed command: git apply
On Sept. 21, 2014, 9:20 a.m., Adam B wrote:
src/master/master.hpp, lines 947-950
https://reviews.apache.org/r/25866/diff/2/?file=699118#file699118line947
Comment here should be for the Slave.
'active' is set to false if resources from this slave should not be
offered. This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25866/
---
(Updated Sept. 22, 2014, 11:50 p.m.)
Review request for mesos, Adam B and Ben
On Sept. 20, 2014, 2:26 p.m., Dominic Hamon wrote:
src/master/master.cpp, line 4649
https://reviews.apache.org/r/25866/diff/1/?file=698461#file698461line4649
consider adding gauges for connected/disconnected slaves
done. added for frameworks too.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25867/
---
(Updated Sept. 22, 2014, 11:51 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review54211
---
Patch looks great!
Reviews applied: [25864]
All tests passed.
-
On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
src/module/manager.cpp, lines 43-44
https://reviews.apache.org/r/25848/diff/1/?file=697029#file697029line43
Ben, we did the module manager as a singleton. I know it is a uncommon
pattern in Mesos in general. Do you have any
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 22, 2014, 8:22 p.m.)
Review request for mesos, Benjamin
On Sept. 19, 2014, 7:39 p.m., Niklas Nielsen wrote:
src/examples/test_module.cpp, line 38
https://reviews.apache.org/r/25848/diff/1/?file=697027#file697027line38
You could also throw in a comment here on what function declaration
that gets generated i.e. exported symbol name and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/#review54217
---
Bad patch!
Reviews applied: [25911]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25866/#review54215
---
Ship it!
Great job.
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25911/#review54221
---
src/master/master.cpp
On Sept. 20, 2014, 7:22 p.m., Ben Mahler wrote:
Thanks Joris!
Any reason you want this exposed in the public include/ folder of
libprocess, as opposed to an internal header inside src/? Don't think we'd
want this in the public includes.
Niklas Nielsen wrote:
It seems to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/
---
(Updated Sept. 23, 2014, 1:18 a.m.)
Review request for mesos and Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25867/#review54240
---
Patch looks great!
Reviews applied: [25866, 25867]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25922/
---
Review request for mesos, Adam B and Benjamin Hindman.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54238
---
Ship it!
Looks great! A few minor nits and a request for a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 23, 2014, 12:05 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54245
---
Patch looks great!
Reviews applied: [25868]
All tests passed.
-
On Sept. 22, 2014, 10:52 p.m., Ben Mahler wrote:
Did you look at the diff when you posted this review? Looks like you needed
to rebase against master.
Sorry didn't really look at it and you're right it's not rebased!
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25569/
---
(Updated Sept. 23, 2014, 5:28 a.m.)
Review request for mesos and Ben Mahler.
Hi all,
The vote for Mesos 0.20.1 (rc3) has passed with the following votes.
+1 (Binding)
--
*** Vinod Kone
*** Till Toenshoff
*** Niklas Nielsen
*** Jie Yu
+1 (Non-binding)
--
*** Tim Chen
*** Tom Arnfeld
There were no 0 or -1 votes.
78 matches
Mail list logo
