Re: Review Request 30002: Fix docker tests and warnings running in verbose logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30002/#review68541 --- Patch looks great! Reviews applied: [29327, 29328, 29329, 29330, 29

Re: Review Request 29334: Add option to launch docker containers with helper containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29334/#review68537 --- Helper containers? Was there any discussion or ticket related to thi

Re: Review Request 26275: MESOS-444: Remove --checkpoint flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/#review68536 --- Patch looks great! Reviews applied: [26275] All tests passed. - M

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2395

See

Re: Review Request 29329: Add executor for docker containerizer

> On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: > > How are we going to manage the duplication across the command executor and > > the docker executor? I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker executor is solely responsible for

Re: Review Request 30002: Fix docker tests and warnings running in verbose logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30002/ --- (Updated Jan. 17, 2015, 1:43 a.m.) Review request for mesos, Benjamin Hindman a

Review Request 30002: Fix docker tests and warnings running in verbose logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30002/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: meso

Re: Review Request 30001: Add documentation for new docker flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30001/ --- (Updated Jan. 17, 2015, 1:40 a.m.) Review request for mesos, Benjamin Hindman a

Review Request 30001: Add documentation for new docker flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30001/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: meso

Re: Review Request 29329: Add executor for docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review68533 --- How are we going to manage the duplication across the command execut

Re: Review Request 29341: Fix docker recovery when launched in container and add more logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29341/ --- (Updated Jan. 17, 2015, 1:38 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29338: Install docker as part of the mesos docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29338/ --- (Updated Jan. 17, 2015, 1:37 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29340: Change docker executor launch command log level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29340/ --- (Updated Jan. 17, 2015, 1:38 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29339: Skip docker validation in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29339/ --- (Updated Jan. 17, 2015, 1:38 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29336: Recover docker containers that launched in containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29336/ --- (Updated Jan. 17, 2015, 1:37 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29337: Launch docker container and log through docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29337/ --- (Updated Jan. 17, 2015, 1:37 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29334: Add option to launch docker containers with helper containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29334/ --- (Updated Jan. 17, 2015, 1:36 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29335: Fix docker container naming and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29335/ --- (Updated Jan. 17, 2015, 1:36 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29333: Add docker_sock to slave flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 17, 2015, 1:35 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/#review68532 --- Just curious, what happens to the orphans if you don't kill them? Wa

Re: Review Request 29996: Added signal handling to the low level scheduler tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29996/#review68531 --- Ship it! - Cody Maloney On Jan. 16, 2015, 11:39 p.m., Ben Mahler

Re: Review Request 29332: Add docker_mesos_image flag to slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29332/ --- (Updated Jan. 17, 2015, 1:31 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29332: Add docker_mesos_image flag to slave flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29332/ --- (Updated Jan. 17, 2015, 1:27 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29331: Re-enable docker recover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29331/ --- (Updated Jan. 17, 2015, 1:27 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29330: Integrate docker executor into containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29330/ --- (Updated Jan. 17, 2015, 1:27 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29329: Add executor for docker containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated Jan. 17, 2015, 1:26 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/ --- (Updated Jan. 17, 2015, 1:26 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 29996: Added signal handling to the low level scheduler tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29996/#review68528 --- Patch looks great! Reviews applied: [29996] All tests passed. - M

Re: Review Request 29996: Added signal handling to the low level scheduler tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29996/#review68525 --- Ship it! Ship It! - Jie Yu On Jan. 16, 2015, 11:39 p.m., Ben Mah

Re: Review Request 29973: Passed framework ID instead framework info to Master::receive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29973/#review68521 --- src/master/master.cpp

Re: Review Request 29974: Added stream function for repeated protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29974/#review68520 --- Ship it! src/common/type_utils.hpp

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/#review68518 --- Ship it! src/slave/flags.hpp

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

> On Jan. 17, 2015, 12:18 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, lines 160-161 > > > > > > Let's clarify this one: > > > > For example: > > "... to check the overall disk usage managed by the sla

Re: Review Request 29895: Added disk usage statistics reporting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/ --- (Updated Jan. 17, 2015, 12:41 a.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/ --- (Updated Jan. 17, 2015, 12:41 a.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/#review68517 --- Patch looks great! Reviews applied: [29889] All tests passed. - M

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/#review68512 --- Thanks! Let's try to avoid the flag ambiguity and clean up the help

Re: Review Request 26275: MESOS-444: Remove --checkpoint flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26275/ --- (Updated Jan. 17, 2015, 12:15 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 29895: Added disk usage statistics reporting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/#review68511 --- Ship it! src/slave/containerizer/isolators/posix/disk.cpp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2394

See Changes: [niklas] Fixed MESOS-2049 by using circular_buffer>. -- [...truncated 73827 lines...] I0117 00:09:18.544383 14413 whitelist_watcher.cpp:65] No whitelis

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29896/ --- (Updated Jan. 16, 2015, 11:52 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 29895: Added disk usage statistics reporting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29895/ --- (Updated Jan. 16, 2015, 11:52 p.m.) Review request for mesos, Ben Mahler, Ian D

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2675

See

Re: Review Request 29896: Added a slave flag to turn off disk quota enforcement.

> On Jan. 16, 2015, 12:56 a.m., Ben Mahler wrote: > > src/slave/flags.hpp, line 391 > > > > > > Could you document that this is relevant only for the "posix/disk" > > isolator? Added. > On Jan. 16, 2015, 12:56 a.m.

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2393

gt; 3 > I0116 23:04:34.547657 13255 coordinator.cpp:340] Coordinator attempting to > write TRUNCATE action at position 4 > I0116 23:04:34.547994 13243 slave.cpp:2588] Received ping from > slave-observer(196)@67.195.81.189:55479 > I0116 23:04:34.547956 13242 master.cpp:3330] Registered slave

Re: Review Request 29991: Removed unnecessary allocator expectations in the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29991/#review68509 --- Patch looks great! Reviews applied: [29989, 29990, 29991] All test

Review Request 29996: Added signal handling to the low level scheduler tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29996/ --- Review request for mesos, Cody Maloney and Jie Yu. Bugs: MESOS-2144 https:/

Re: Review Request 29988: Fixed FaultToleranceTest.ReregisterFrameworkExitedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29988/#review68508 --- Ship it! Thanks for explaining in the ticket! - Ben Mahler On Ja

Re: Review Request 29328: Add option to disable docker containerizer killing orphans

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29328/ --- (Updated Jan. 16, 2015, 11:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889/ --- (Updated Jan. 16, 2015, 11:23 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 29327: Add slave id to docker container name prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/ --- (Updated Jan. 16, 2015, 11:21 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29895: Added disk usage statistics reporting.

> On Jan. 16, 2015, 12:52 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.hpp, lines 114-118 > > > > > > At this point, is it worth having single map with a struct capturing > > these values?

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2674

https://issues.apache.org/jira/browse/MESOS-2144 On Fri, Jan 16, 2015 at 2:53 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2674/changes > > > > Changes: > > [yuji

Review Request 29990: Updated TestAllocatorProcess to avoid the test warnings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29990/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2232 https://issues.ap

Review Request 29991: Removed unnecessary allocator expectations in the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29991/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2232 https://issues.ap

Review Request 29989: Renamed MockAllocatorProcess to TestAllocatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29989/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2232 https://issues.ap

Re: Review Request 29327: Add slave id to docker container name prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29327/ --- (Updated Jan. 16, 2015, 11:11 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29327: Add slave id to docker container name prefix.

> On Jan. 13, 2015, 3:27 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/docker.hpp, line 303 > > > > > > Was there any reason to use the '/' as a separator over something else? > > I'm wondering if the '/'

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2393

or attempting to write TRUNCATE action at position 4 I0116 23:04:34.547994 13243 slave.cpp:2588] Received ping from slave-observer(196)@67.195.81.189:55479 I0116 23:04:34.547956 13242 master.cpp:3330] Registered slave 20150116-230434-3176252227-55479-13226-S0 at slave(223)@67.

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2674

See Changes: [yujie.jay] Added three tuples overload for process::await. [yujie.jay] Added PosixDiskIsolator to monitor container disk usage and to enforce [yujie.jay] Ad

Re: Review Request 29988: Fixed FaultToleranceTest.ReregisterFrameworkExitedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29988/#review68496 --- Patch looks great! Reviews applied: [29988] All tests passed. - M

Review Request 29988: Fixed FaultToleranceTest.ReregisterFrameworkExitedExecutor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29988/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2225 https://issues.ap

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

> On Jan. 16, 2015, 12:42 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.hpp, lines 22-30 > > > > > > Do you want future, option, and resources included? > > Jie Yu wrote: > Those are part

Re: Review Request 29926: Wrapped underlying process in Owned<>.

Let's look at the two options: 1. Used Owned<> now only in this location, add a ticket to do a sweep. 2. Use the existing pattern, add a ticket to do a sweep. Removing a single instance from the sweep you're planning to do doesn't seem to warrant the inconsistency in such a common pattern (Proces

Re: Review Request 29688: Added DiskQuotaIsolator to enforce disk quota.

> On Jan. 16, 2015, 12:42 a.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.hpp, lines 22-30 > > > > > > Do you want future, option, and resources included? Those are part of the IsolatorProcess

Re: Review Request 29927: Added Allocator::ceaseAllocation() method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review68468 --- Is this speculative or could you show that the behaviour changed wit

Re: Review Request 29926: Wrapped underlying process in Owned<>.

> On Jan. 15, 2015, 11:43 a.m., Ben Mahler wrote: > > This is an extremely common pattern in the code, and so we should avoid > > doing it in an inconsistent manner. > > > > FWIW, we've yet to see leaks from this pattern, but if you want to make > > this change, let's do it as a broad sweep in

Re: Review Request 29890: Refactored allocator interface to support general implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29890/#review68273 --- src/master/allocator.hpp

Re: Review Request 29925: Moved allocation related sources into a separate directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29925/#review68465 --- Ship it! Ship It! - Niklas Nielsen On Jan. 15, 2015, 8:58 a.m.,

Re: Review Request 29976: Moved launchTasks logics to ACCEPT call handler in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29976/#review68462 --- Patch looks great! Reviews applied: [29973, 29974, 29975, 29976] A

Re: Review Request 29927: Added Allocator::ceaseAllocation() method.

It seems like this may become unnecessary as I fix MESOS-2232. Could you hold off on this one? On Fri, Jan 16, 2015 at 11:41 AM, Benjamin Mahler wrote: > That review doesn't describe what the issue was, unfortunately. And the > ticket is a bit vague. > > Is it about uninteresting mock calls? Do

Re: Review Request 29927: Added Allocator::ceaseAllocation() method.

That review doesn't describe what the issue was, unfortunately. And the ticket is a bit vague. Is it about uninteresting mock calls? Do we want to change our mocking approach to avoid the uninteresting mock calls? Note that most of our other mocks do not have uninteresting calls because we used EX

Review Request 29976: Moved launchTasks logics to ACCEPT call handler in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29976/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Review Request 29974: Added stream function for repeated protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29974/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Review Request 29975: Renamed the Accept call handler to accept.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29975/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Review Request 29973: Passed framework ID instead framework info to Master::receive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29973/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Repository:

Re: Review Request 29932: Renamed test allocator actions for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29932/#review68435 --- Patch looks great! Reviews applied: [29890, 29925, 29926, 29927, 29

Re: Review Request 29932: Renamed test allocator actions for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29932/ --- (Updated Jan. 16, 2015, 4:05 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 29883: Added /master/slaves and /master/frameworks/{framework}/tasks/{task} endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review68426 --- Patch looks great! Reviews applied: [29883] All tests passed. - M

Re: Review Request 29883: Added /master/slaves and /master/frameworks/{framework}/tasks/{task} endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/ --- (Updated Jan. 16, 2015, 1:37 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 29927: Added Allocator::ceaseAllocation() method.

> On Jan. 15, 2015, 8:12 p.m., Ben Mahler wrote: > > Yikes, could you elaborate on what the issue was? Based on this commit: b4bd08693f394a196e0310955b1afdfbe3c2de36, https://reviews.apache.org/r/24418 - Alexander --- This is an automa

Re: Review Request 29904: Changed slave to use collector interface.

> On Jan. 15, 2015, 7:31 a.m., Alexander Rukletsov wrote: > > src/slave/main.cpp, line 179 > > > > > > Let's wrap it into Shared<> or Owned<>. > > Ben Mahler wrote: > That would make the code here inconsistent, ar

Re: Review Request 29926: Wrapped underlying process in Owned<>.

> On Jan. 15, 2015, 7:43 p.m., Ben Mahler wrote: > > This is an extremely common pattern in the code, and so we should avoid > > doing it in an inconsistent manner. > > > > FWIW, we've yet to see leaks from this pattern, but if you want to make > > this change, let's do it as a broad sweep ins