---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30606/#review74445
---
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74446
---
Patch looks great!
Reviews applied: [30606, 30609, 30774]
All
On Feb. 26, 2015, 6:11 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/network.hpp, line 70
https://reviews.apache.org/r/29289/diff/18/?file=877548#file877548line70
leaking of abstraction here. is there something we can do better? Can
you just use
On Feb. 26, 2015, 6:42 p.m., Jie Yu wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 122
https://reviews.apache.org/r/31470/diff/1/?file=877501#file877501line122
s/net mask/netmask/
Here and everywhere else please.
I saw that the the change netmask
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/
---
(Updated Feb. 27, 2015, 6:52 a.m.)
Review request for mesos, Benjamin Hindman,
On Feb. 26, 2015, 6:47 p.m., Dominic Hamon wrote:
i don't see the change to the actual method here..
Evelina Dumitrescu wrote:
The changes are in the fromLinkDevice test
ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of
net::fromLinkDevice(link, AF_INET);
On Feb. 26, 2015, 6:06 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp, line 17
https://reviews.apache.org/r/31471/diff/1/?file=877505#file877505line17
why do you need this?
Accidentally left, I used it for debugging.
On Feb. 26, 2015, 6:06 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated Feb. 27, 2015, 6:52 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated Feb. 27, 2015, 6:54 a.m.)
Review request for .
Bugs: MESOS-1919
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated Feb. 27, 2015, 6:54 a.m.)
Review request for .
Bugs: MESOS-1919
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/
---
(Updated Feb. 27, 2015, 6:53 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/
---
(Updated Feb. 27, 2015, 6:53 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74456
---
Bad patch!
Reviews applied: [29288]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review74457
---
src/slave/containerizer/isolators/network/port_mapping.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review74395
---
please add a reference to the jira and any dependencies.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74278
---
Patch looks great!
Reviews applied: [30606, 30609, 30774]
All
On Feb. 25, 2015, 2:20 p.m., Till Toenshoff wrote:
This really is an impressive project Bernd, tipping my hat here!
I did not get all the way through, had to ignore the tests in this review
(to be continued!).
For playing a bit with this and for testing the functionality, it
On Feb. 26, 2015, 8:05 a.m., Kapil Arya wrote:
src/slave/state.cpp, line 621
https://reviews.apache.org/r/31480/diff/1/?file=878304#file878304line621
Should we also add strerror(errno) to inform about the lseek error?
Just realized that it's using ErrnoError :-).
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review74271
---
src/slave/containerizer/fetcher.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31480/#review74264
---
Ship it!
LGTM minus the lseek errno handling. Feel free to drop
On Feb. 25, 2015, 10:30 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 686
https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line686
Seems like lookupEntry is only used here, and it's always coupled with
a reference call.
How
On Feb. 25, 2015, 10:56 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 528
https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line528
return size.error();
That does not compile.
On Feb. 25, 2015, 10:56 a.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated Feb. 26, 2015, 6:03 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/
---
Review request for mesos, Joerg Schad and Till Toenshoff.
Bugs: MESOS-2412
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31471/#review74300
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
On Feb. 26, 2015, 10:14 a.m., Ben Mahler wrote:
This is pretty inconsistent with the rest of our code. Why can't you add
the missing deletes?
we can. but why not start getting rid of the archaic practice of using raw
pointers?
- Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31246/#review74302
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
On Feb. 26, 2015, 6:14 p.m., Ben Mahler wrote:
This is pretty inconsistent with the rest of our code. Why can't you add
the missing deletes?
Dominic Hamon wrote:
we can. but why not start getting rid of the archaic practice of using
raw pointers?
I agree having less prone to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74304
---
3rdparty/libprocess/include/process/network.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/#review74294
---
Ship it!
Ship It!
- Ian Downes
On Feb. 26, 2015, 1:10 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/#review74303
---
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review74301
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 25, 2015, 11:18 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/#review74307
---
Ship it!
Ship It!
- Timothy Chen
On Feb. 26, 2015, 6:14 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/#review74295
---
I replaced the buffers with vectors to avoid deletes here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/#review74298
---
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/#review74305
---
This is pretty inconsistent with the rest of our code. Why can't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/
---
(Updated Feb. 26, 2015, 10:14 a.m.)
Review request for mesos, Joerg Schad and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31455/#review74296
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 25, 2015, 5:49 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/#review74316
---
Ship it!
Ship It!
- Alexander Rojas
On Feb. 26, 2015, 7:14
On Feb. 26, 2015, 6:47 p.m., Dominic Hamon wrote:
i don't see the change to the actual method here..
The changes are in the fromLinkDevice test
ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of
net::fromLinkDevice(link, AF_INET);
- Evelina
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31446/#review74351
---
Patch looks great!
Reviews applied: [31446]
All tests passed.
-
On Feb. 26, 2015, 6:14 p.m., Ben Mahler wrote:
This is pretty inconsistent with the rest of our code. Why can't you add
the missing deletes?
Dominic Hamon wrote:
we can. but why not start getting rid of the archaic practice of using
raw pointers?
Timothy Chen wrote:
I
-registration
request from framework 20150226-194118-3176252227-58620-6446- (default)
at scheduler-c0b56fcf-0d0c-47cf-a2db-c4dce96f5de2@67.195.81.189:58620
I0226 19:41:18.548668 6471 master.cpp:1435] Authorizing framework
principal 'test-principal' to receive offers for role '*'
I0226 19:41:18.549022
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/#review74321
---
Ship it!
Ship It!
- Dominic Hamon
On Feb. 25, 2015, 10:41 p.m.,
On Feb. 26, 2015, 10:47 a.m., Dominic Hamon wrote:
i don't see the change to the actual method here..
Evelina Dumitrescu wrote:
The changes are in the fromLinkDevice test
ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of
net::fromLinkDevice(link, AF_INET);
this
On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote:
I replaced the buffers with vectors to avoid deletes here:
https://reviews.apache.org/r/31489/
Sounds good, I'll discard this.
- Timothy
---
This is an automatically generated
On Feb. 26, 2015, 6:47 p.m., Dominic Hamon wrote:
i don't see the change to the actual method here..
Evelina Dumitrescu wrote:
The changes are in the fromLinkDevice test
ie: net::IPNetwork::fromLinkDevice(link, AF_INET); instead of
net::fromLinkDevice(link, AF_INET);
Noted - thanks!
On 26 February 2015 at 10:17, Jie Yu (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/MESOS-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338835#comment-14338835
]
Jie Yu commented on MESOS-2410:
On Feb. 23, 2015, 3:52 p.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 93
https://reviews.apache.org/r/30606/diff/3/?file=869525#file869525line93
Should we move this to a static initializtion that just gets called
once? According to the
:554] Will retry registration in
1.760884282secs if necessary
I0226 19:41:18.548595 6471 master.cpp:1711] Received re-registration request
from framework 20150226-194118-3176252227-58620-6446- (default) at
scheduler-c0b56fcf-0d0c-47cf-a2db-c4dce96f5de2@67.195.81.189:58620
I0226 19:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31470/#review74309
---
This is looking great, Evelina! Thanks for all the efforts. No
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review74320
---
i don't see the change to the actual method here..
- Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31446/
---
(Updated Feb. 26, 2015, 10:53 a.m.)
Review request for mesos and Vinod Kone.
On Feb. 26, 2015, 2:01 a.m., Adam B wrote:
Ship It!
What happened here? This is blocking 0.22.0. Bernd, are you on top of the flaky
test?
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
Hi,
I would like to be added to the contributor list so I can assign a bug to
myself to work on.
My JIRA username is: lunsee
Thanks!
--
Best,
Nancy Ko
On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote:
I replaced the buffers with vectors to avoid deletes here:
https://reviews.apache.org/r/31489/
Timothy Chen wrote:
Sounds good, I'll discard this.
I just noticed this patch, why did we decide to throw away the fix that most
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31443/#review74359
---
Ship it!
src/linux/fs.hpp
On Feb. 26, 2015, 6:14 p.m., Ben Mahler wrote:
This is pretty inconsistent with the rest of our code. Why can't you add
the missing deletes?
Dominic Hamon wrote:
we can. but why not start getting rid of the archaic practice of using
raw pointers?
Timothy Chen wrote:
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31480/
---
Review request for mesos.
Repository: mesos
Description
---
Fix check
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/
---
Review request for mesos.
Repository: mesos
Description
---
Add missing
On Feb. 23, 2015, 4:05 p.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 409
https://reviews.apache.org/r/30609/diff/3/?file=859975#file859975line409
I was quite confused by the ownsize name, I think everyone will be
too, since it's a term no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/
---
(Updated Feb. 26, 2015, 1:16 a.m.)
Review request for mesos, Adam B, Benjamin
On Feb. 23, 2015, 3:52 p.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 93
https://reviews.apache.org/r/30606/diff/3/?file=869525#file869525line93
Should we move this to a static initializtion that just gets called
once? According to the
On Feb. 23, 2015, 11:52 p.m., Timothy Chen wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 93
https://reviews.apache.org/r/30606/diff/3/?file=869525#file869525line93
Should we move this to a static initializtion that just gets called
once? According to the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31362/#review74250
---
Ship it!
Ship It!
- Adam B
On Feb. 26, 2015, 12:16 a.m., Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/#review74249
---
Patch looks great!
Reviews applied: [31479]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31480/#review74252
---
Patch looks great!
Reviews applied: [31480]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31362/#review74243
---
Patch looks great!
Reviews applied: [31362]
All tests passed.
-
On Feb. 25, 2015, 10:06 a.m., Timothy Chen wrote:
docs/fetcher.md, line 165
https://reviews.apache.org/r/30774/diff/18/?file=875537#file875537line165
Doesn't cache items have TTLs? Then frameworks should never get into
content that is stale for a long time?
TTLs are not
On Feb. 25, 2015, 10:25 a.m., Timothy Chen wrote:
src/slave/containerizer/fetcher.cpp, line 103
https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line103
How about introducing a Cache namespace, so then we can just do
Fetcher::Cache::recover,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31503/#review74394
---
please add a jira reference and a dependency on the first part.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review74396
---
add a jira reference and any dependencies please.
On Feb. 26, 2015, 2:01 a.m., Adam B wrote:
Ship It!
Niklas Nielsen wrote:
What happened here? This is blocking 0.22.0. Bernd, are you on top of the
flaky test?
Adam B wrote:
The latest revision (4) fixed the broken test by writing the script into
the tests tmpdir rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/#review74404
---
Duplicate detected: https://reviews.apache.org/r/31494/
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review74416
---
Bad patch!
Reviews applied: [31504]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31494/
---
(Updated Feb. 26, 2015, 10:42 p.m.)
Review request for mesos and Till
On Feb. 25, 2015, 4:01 p.m., Niklas Nielsen wrote:
Hey Till,
Can you rebase this? :)
Vinod, think that this is only awaiting responses from you on a few
questions/answers above :) Would love to get this in.
- Niklas
---
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502/#review74389
---
src/Makefile.am
https://reviews.apache.org/r/31502/#comment120961
On Feb. 26, 2015, 11:19 p.m., Chi Zhang wrote:
A lot of tricky manuevers; likely have grasped it fully :)
s/have/haven not/
- Chi
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502/#review74393
---
please also add a jira reference to the bug field.
- Dominic Hamon
Earlier today, Niklas Nielsen created an initial document to catalog
previous and future Mesos releases:
https://cwiki.apache.org/confluence/display/MESOS/Mesos+Release+Planning.
This made my day, thanks Niklas!
I've gone ahead and begun to add additional info to thedocument,
specifically links
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31503/#review74414
---
Bad patch!
Reviews applied: [31503]
Failed command:
Added you to the contributor list. Welcome on board!
Niklas
On 26 February 2015 at 13:11, N K konan...@gmail.com wrote:
Hi,
I would like to be added to the contributor list so I can assign a bug to
myself to work on.
My JIRA username is: lunsee
Thanks!
--
Best,
Nancy Ko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review74388
---
A lot of tricky manuevers; likely have grasped it fully :)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31494/#review74398
---
Patch looks great!
Reviews applied: [31494]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31503/
---
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502/
---
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/
---
Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502/#review74408
---
Patch looks great!
Reviews applied: [31502]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/
---
(Updated Feb. 26, 2015, 10:08 p.m.)
Review request for mesos.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31494/#review74403
---
Please check https://reviews.apache.org/r/31479/
- Alexander
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2779/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31518/#review74430
---
Patch looks great!
Reviews applied: [31518]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31512/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31511/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31514/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31518/
---
Review request for mesos, Jie Yu and Niklas Nielsen.
Bugs: MESOS-2407
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review74423
---
Patch looks great!
Reviews applied: [31505]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
---
(Updated Feb. 27, 2015, 2:28 a.m.)
Review request for mesos, Adam B, Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31516/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2392
1 - 100 of 114 matches
Mail list logo
