Re: NetBeans has landed in Apache Git

2017-09-21 Thread Geertjan Wielenga
OK, it's done: 29334 are relicensed to ASF. Gj On Thu, Sep 21, 2017 at 8:40 AM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > We've been discussing this a while now. I'm going to take the tool and run > it, relicensing around 29,000, as documented here: > > https://cwiki.apache.

Re: NetBeans has landed in Apache Git

2017-09-21 Thread Geertjan Wielenga
We've been discussing this a while now. I'm going to take the tool and run it, relicensing around 29,000, as documented here: https://cwiki.apache.org/confluence/display/NETBEANS/NetBeans+Transition+Process I'll then do the push of those changed headers. I'm also on the Infra chat just in case so

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Bertrand Delacretaz
Hi, On Thu, Sep 21, 2017 at 12:34 PM, Neil C Smith wrote: > ...Take > > https://github.com/apache/incubator-netbeans/blob/master/apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/wizard/instantiatingIterator.javx Ok - IIUC that's a template that NetBeans uses at runtime to

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Neil C Smith
On Thu, Sep 21, 2017 at 10:26 AM Bertrand Delacretaz wrote: > On Thu, Sep 21, 2017 at 11:16 AM, Neil C Smith > wrote: > > ...I assume we wouldn't want the output of > > them to be under any kind of license?... > > As a podling, NetBeans releases are approved by the Incubator PMC, and > I doubt t

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Jan Lahoda
If in NetBeans IDE the user does New/Java Class, then (I think) this template will be instantiated: https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=blob;f=java.project.ui/src/org/netbeans/modules/java/project/ui/resources/Class.java.template;h=e9890cf1ebbfa872259a65b4259e10fd0505

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Bertrand Delacretaz
On Thu, Sep 21, 2017 at 11:16 AM, Neil C Smith wrote: > ...I assume we wouldn't want the output of > them to be under any kind of license?... As a podling, NetBeans releases are approved by the Incubator PMC, and I doubt they would approve a release containing files with no license. See "Source

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Neil C Smith
Hi, On Thu, Sep 21, 2017 at 9:58 AM Bertrand Delacretaz wrote: > On Thu, Sep 21, 2017 at 9:38 AM, Emilian Bold > wrote: > > ...But it's a bit silly no? Any new project based on an Apache sample > would have to post a notice about the Apache > > license and include a copy of the license > >

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Bertrand Delacretaz
On Thu, Sep 21, 2017 at 9:38 AM, Emilian Bold wrote: > Pe 21 sept. 2017, la 09:51, Bertrand Delacretaz a > scris: >> ...Code produced by the ASF must use the Apache License, so that's not an >> option here... > ...But it's a bit silly no? Any new project based on an Apache sample would > have

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-21 Thread Emilian Bold
But it's a bit silly no? Any new project based on an Apache sample would have to post a notice about the Apache license and include a copy of the license. --emi Pe 21 sept. 2017, la 09:51, Bertrand Delacretaz a scris: > Hi, > >> On Wed, Sep 20, 2017 at 10:07 PM, Emilian Bold >> wrote: >> .

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-20 Thread Bertrand Delacretaz
Hi, On Wed, Sep 20, 2017 at 10:07 PM, Emilian Bold wrote: > ...My concern was that sample code should not trigger any licensing > thoughts. In that light Apache or BSD doesn't matter. > Since it's designed to be used as a starting point it should be Public > Domain... Code produced by the ASF m

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-20 Thread Geertjan Wielenga
Thanks, it was a small fun clean up task. Gj On Wed, Sep 20, 2017 at 4:07 PM, Emilian Bold wrote: > Well, that was very effective! > > My concern was that sample code should not trigger any licensing > thoughts. In that light Apache or BSD doesn't matter. > > Since it's designed to be used as a

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-20 Thread Emilian Bold
Well, that was very effective! My concern was that sample code should not trigger any licensing thoughts. In that light Apache or BSD doesn't matter. Since it's designed to be used as a starting point it should be Public Domain. Of course, everybody treats sample code as Public Domain, but that'

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-20 Thread Geertjan Wielenga
OK, done, including references in various supporting files, and did a build and run to check everything still works and resolved the issue: https://issues.apache.org/jira/browse/NETBEANS-62 Gj On Wed, Sep 20, 2017 at 2:02 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Those

Re: FYI, new incubator-netbeans-tools repository (was: NetBeans has landed in Apache Git)

2017-09-20 Thread Geertjan Wielenga
Excellent, thanks! Jan, can you check the license converter into that new repo when it's there? Gj On Wed, Sep 20, 2017 at 2:41 PM, Bertrand Delacretaz wrote: > On Wed, Sep 20, 2017 at 8:36 PM, Geertjan Wielenga > wrote: > > Can someone create a repo for tools for Apache NetBeans, i.e., > > i

FYI, new incubator-netbeans-tools repository (was: NetBeans has landed in Apache Git)

2017-09-20 Thread Bertrand Delacretaz
On Wed, Sep 20, 2017 at 8:36 PM, Geertjan Wielenga wrote: > Can someone create a repo for tools for Apache NetBeans, i.e., > incubator-netbeans-tools? ... Should be ready soon, reporeq says: this will create https://git-wip-us.apache.org/repos/asf/incubator-netbeans-tools.git, notifications will

Re: NetBeans has landed in Apache Git

2017-09-20 Thread Geertjan Wielenga
Can someone create a repo for tools for Apache NetBeans, i.e., incubator-netbeans-tools? Also, can someone verify that the license header pattern is good? We want to minimize as much as possible the situation where later on someone tells us we did something wrong and need to do things all over aga

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-20 Thread Geertjan Wielenga
Those specific files, i.e., the samples relating to the NetBeans Platform (FeedReader, PaintApp, OSGIDemo and maybe another one or two) should simply be deleted, they're old and out of date and it would simplify things simply not having them. https://issues.apache.org/jira/browse/NETBEANS-62 I'm

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jan Lahoda
Hi Bertrand, The tool is currently a zip attached to the wiki - but the zip contains a git repository, so no history is lost. I just tried to create a new repository (incubator-netbeans-tools) using: https://reporeq.apache.org/ but it seems I cannot create such a repository. Aside for this, any

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Could it be a subfolder in this incubator-netbeans? Or a new repo since the tool will be useful for other NetBeans repos too: incubator-netbeans-tools. There may be more scripts and things we'll be needing. Gj On Tue, 19 Sep 2017 at 15:08, Jaroslav Tulach wrote: > On úterý 19. září 2017 15:24:5

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jaroslav Tulach
On úterý 19. září 2017 15:24:53 CEST Bertrand Delacretaz wrote: > Hi, > > On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda wrote: > > ...I've uploaded an updated version of the tool... > > You mean the tool is not in Git? I think it should, maybe using a > specific "tools" repository. We don't have

Re: Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-19 Thread Bertrand Delacretaz
Hi, On Tue, Sep 19, 2017 at 9:58 AM, Emilian Bold wrote: >> ...some files in the repository (typically samples) are using 3-clause (if I >> get that correctly) BSD license... If those files have been donated to Apache they can be relicensed, and IMO they should, in order to simplify things. -B

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Good idea. Can you do this, Jan? Gj On Tue, 19 Sep 2017 at 14:25, Bertrand Delacretaz wrote: > Hi, > > On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda wrote: > > ...I've uploaded an updated version of the tool... > > You mean the tool is not in Git? I think it should, maybe using a > specific "to

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Bertrand Delacretaz
Hi, On Sun, Sep 17, 2017 at 5:06 PM, Jan Lahoda wrote: > ...I've uploaded an updated version of the tool... You mean the tool is not in Git? I think it should, maybe using a specific "tools" repository. -Bertrand

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jaroslav Tulach
On úterý 19. září 2017 11:33:03 CEST Geertjan Wielenga wrote: > PS: re the samples, I propse we remove the NetBeans Platform samples, e.g., > FeedReader. These samples are old and include code and approaches that one > wouldn't use anymore, e.g., TopComponents manually registered in layer > instead

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
PS: re the samples, I propse we remove the NetBeans Platform samples, e.g., FeedReader. These samples are old and include code and approaches that one wouldn't use anymore, e.g., TopComponents manually registered in layer instead of via annotations. We can recreate some samples easily from scratch,

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Geertjan Wielenga
Sounds like a plan -- I'll use the tool to convert the licenses to Apache, push that to Git, and then we'll use Rat to narrow down the remainder. How does that sound to everyone? Gj On Tue, 19 Sep 2017 at 08:50, Jan Lahoda wrote: > I can try to categorize the files a little, but I was hoping

Sample code license [WAS: Re: NetBeans has landed in Apache Git]

2017-09-19 Thread Emilian Bold
> As a side note, some files in the repository (typically samples) are using > 3-clause (if I get that correctly) BSD license Last time this was a talking point you couldn't tweak the installer without changing the source code that was under the standard CDDL + GPL w/ CPE license. So each custom

Re: NetBeans has landed in Apache Git

2017-09-19 Thread Jan Lahoda
I can try to categorize the files a little, but I was hoping we could switch to using Rat to do the checks (after the bulk of the changes are done). So if e.g. the META-INF files would be OK to not have a header, we could simply exclude them in the Rat configuration, and they would be ignored (but

Re: NetBeans has landed in Apache Git

2017-09-18 Thread Geertjan Wielenga
Does the above make sense, i.e., I'm suggesting a few ways to finetune the results a bit further -- and are there other ideas for finetuning, i.e., trying to somehow incorporate those 14,651 files, so we can minimize the manual checking we'll need to do? Thanks, Gj On Mon, Sep 18, 2017 at 10:53

Re: NetBeans has landed in Apache Git

2017-09-18 Thread Geertjan Wielenga
Great, I've tried it, works well. In the report, there's a list of 14,651 files under the heading "Files without CDDL (14651)". Could a distinction be made between those that have a license (i.e., some license other than CDDL) and those that do not have a license at all? I also think that it wou

Re: NetBeans has landed in Apache Git

2017-09-17 Thread Jan Lahoda
Hi, I've uploaded an updated version of the tool - fixing a bug in rewriting headers of bundle files (where it was deleting one line after the header, reported by Geertjan offline), making it a little bit more strict (currently rewrites 29474 files), adding support for bat files, and adding abilit

Re: NetBeans has landed in Apache Git

2017-09-15 Thread Geertjan Wielenga
Ah, found this: https://issues.apache.org/jira/secure/attachment/12886241/categorized-1.zip I.e., quite some analysis done by you already and found here: https://issues.apache.org/jira/browse/NETBEANS-54 Gj On Fri, Sep 15, 2017 at 11:43 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> w

Re: NetBeans has landed in Apache Git

2017-09-15 Thread Geertjan Wielenga
I've used the tool, it's really great, not only analyzes but also actually changes the licenses, 29,496 of 44,324: https://cwiki.apache.org/confluence/display/NETBEANS/NetBeans+Transition+Process Could the tool be tuned to list all the files that are not in the 29,496? I have updated the table i

Re: NetBeans has landed in Apache Git

2017-09-14 Thread Geertjan Wielenga
Agree completely. Gj On Thu, Sep 14, 2017 at 3:05 PM, Jan Lahoda wrote: > On Thu, Sep 14, 2017 at 2:59 PM, Geertjan Wielenga < > geertjan.wiele...@googlemail.com> wrote: > > > I think we also need to fill out the "Relicensing of incubator-netbeans" > > table on the page > > https://cwiki.apache

Re: NetBeans has landed in Apache Git

2017-09-14 Thread Jan Lahoda
On Thu, Sep 14, 2017 at 2:59 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > I think we also need to fill out the "Relicensing of incubator-netbeans" > table on the page > https://cwiki.apache.org/confluence/display/NETBEANS/ > NetBeans+Transition+Process, > i.e., with the vario

Re: NetBeans has landed in Apache Git

2017-09-14 Thread Geertjan Wielenga
I think we also need to fill out the "Relicensing of incubator-netbeans" table on the page https://cwiki.apache.org/confluence/display/NETBEANS/NetBeans+Transition+Process, i.e., with the various file types in a column, related numbers, and in each case what the problems are/could be, so that we ca

Re: NetBeans has landed in Apache Git

2017-09-14 Thread Jan Lahoda
On Mon, Sep 11, 2017 at 10:00 PM, Ate Douma wrote: > Wonderful news and big next step indeed! > > Now, while I understand everyone being 'trigger happy' to start committing > improvements, fixes, etc. (and currently I already see 2 addition commits) > the next step should be to adjust the license

Re: NetBeans has landed in Apache Git

2017-09-12 Thread Geertjan Wielenga
In sorting through the files and doing the relicensing, since it's going to be a very large set of changes, we'd like to do one big merge from a fork. I.e., we propose doing a fork of incubator-netbeans to, for example, github.com/geertjanwielenga, and then doing all the license changes there, afte

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Ate Douma
On 2017-09-11 22:42, Jan Lahoda wrote: Hi Ate, On Mon, Sep 11, 2017 at 10:00 PM, Ate Douma wrote: Wonderful news and big next step indeed! Now, while I understand everyone being 'trigger happy' to start committing improvements, fixes, etc. (and currently I already see 2 addition commits)

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Jan Lahoda
Hi Ate, On Mon, Sep 11, 2017 at 10:00 PM, Ate Douma wrote: > Wonderful news and big next step indeed! > > Now, while I understand everyone being 'trigger happy' to start committing > improvements, fixes, etc. (and currently I already see 2 addition commits) > As Geertjan mentions - one of the c

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
Thanks a lot for the support and advice throughout this process, Ate. The two addition commits you see are specifically to enable the build to succeed, there were two small problems in that area. And in general for right now, and of course we need to discuss this as a community, we probably should

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Ate Douma
Wonderful news and big next step indeed! Now, while I understand everyone being 'trigger happy' to start committing improvements, fixes, etc. (and currently I already see 2 addition commits) the next step should be to adjust the license headers! Which this should be done by a Oracle representing

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
The sooner the better. :-) Gj On Mon, Sep 11, 2017 at 5:28 PM, Simon IJskes wrote: > When can we start contributing patches? > > G. Simon > > > On 11-09-17 17:22, Geertjan Wielenga wrote: > >> Yes, README and much more must be added. >> >> -- Build it: ant build -Dcluster.config=java in the roo

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Simon IJskes
When can we start contributing patches? G. Simon On 11-09-17 17:22, Geertjan Wielenga wrote: Yes, README and much more must be added. -- Build it: ant build -Dcluster.config=java in the root of the sources -- Try it: ant tryme in the root of the sources Gj

AW: NetBeans has landed in Apache Git

2017-09-11 Thread Christian Lenz
Thx 😊 Gesendet von Mail für Windows 10 Von: Geertjan Wielenga Gesendet: Montag, 11. September 2017 17:25 An: dev@netbeans.incubator.apache.org Betreff: Re: NetBeans has landed in Apache Git On Mon, Sep 11, 2017 at 5:14 PM, Christian Lenz wrote: If the 2nd and (if there is one) the 3rd Code

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
On Mon, Sep 11, 2017 at 5:14 PM, Christian Lenz wrote: If the 2nd and (if there is one) the 3rd Code donation is transfered, does > that mean, that we will have separated github repos for the Code? Or will > the other stuff landed in the incubation-netbeans (later hopefully > netbeans) repo too? >

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
Yes, README and much more must be added. -- Build it: ant build -Dcluster.config=java in the root of the sources -- Try it: ant tryme in the root of the sources Gj On Mon, Sep 11, 2017 at 5:20 PM, Simon IJskes wrote: > Also: > > should these be mentioned as 'externals' in the README? > > [down

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Simon IJskes
Also: should these be mentioned as 'externals' in the README? [downloadbinaries] Downloading: http://hg.netbeans.org/binaries/CA70822C47A67FC3A11670270567C2D01566DAE1-jhall-2.0_05.jar [downloadbinaries] Downloading: http://hg.netbeans.org/binaries/2973D150C0DC1FEFE998F834810D68F278EA58EC-junit

Re: NetBeans has landed in Apache Git

2017-09-11 Thread David Heffelfinger
Great accomplishment. Congrats to all. David On Mon, Sep 11, 2017 at 11:15 AM, Simon IJskes wrote: > Also: > > running 'ant' produces a lot of messages and in the end: > > BUILD FAILED > /home/xxx/apache/incubator-netbeans/nbbuild/build.xml:180: Some modules > according your cluster config 'ful

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Simon IJskes
Also: running 'ant' produces a lot of messages and in the end: BUILD FAILED /home/xxx/apache/incubator-netbeans/nbbuild/build.xml:180: Some modules according your cluster config 'full' are missing from checkout, see messages above. On 11-09-17 17:12, Simon IJskes wrote: I'm missing a READM

AW: NetBeans has landed in Apache Git

2017-09-11 Thread Christian Lenz
. September 2017 17:12 An: dev@netbeans.incubator.apache.org Betreff: Re: NetBeans has landed in Apache Git I'm missing a README or something with the build instructions. G. Simon On 11-09-17 17:07, Geertjan Wielenga wrote: > Would be great to do some sanity checks, e.g., does it build, if

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Simon IJskes
I'm missing a README or something with the build instructions. G. Simon On 11-09-17 17:07, Geertjan Wielenga wrote: Would be great to do some sanity checks, e.g., does it build, if not why not, and somebody should try to check it out and do a quick recursive diff with the unzipped donation ZIP

Re: NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
Would be great to do some sanity checks, e.g., does it build, if not why not, and somebody should try to check it out and do a quick recursive diff with the unzipped donation ZIP file to make sure all files are there. Gj On Mon, Sep 11, 2017 at 5:04 PM, Geertjan Wielenga < geertjan.wiele...@goog

NetBeans has landed in Apache Git

2017-09-11 Thread Geertjan Wielenga
Hi all, Big milestone -- git://git.apache.org/incubator-netbeans.git https://github.com/apache/incubator-netbeans The main repo from the 1st code donation has landed in Apache Git, mirrored at Apache GitHub. Thanks all, especially Petr Gebauer, for doing the push, and thanks also for the great