Le 09/02/2015 à 11:21, Jacques Le Roux a écrit :
Le 06/02/2015 17:27, Ron Wheeler a écrit : If there are a lot of required
issues, then make it a community project to release it and get it done.
If it is not clear about the state of a release branch, then have a meeting and
make a decision.
Thanks for the feedback Adrian.
I check commit logs and see the grid widget additions back in January
that you recommended using for OFBIZ-6402 which I did.
But grids don't appear to support embedding of screens. Is this
something that is intended to be added later?
If so, the difficulty is
Thanks Adrian and sorry for the misunderstanding, you are right grids
are rendered as tables.
The embedded menu rendering functionality provided by Nicolas in
OFBIZ-6404 needs to be modified so that menus are rendered outside of
any forms that may be created for grid row submissions. As of right
Keep in mind that menu items are rendered as forms for a reason - to
fight XSS attacks. So, whatever solution you have in mind should not
change that behavior.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/14/2015 10:05 AM, Christian Carlow wrote:
Thanks Adrian and sorry for
I thought a grid is rendered as a table element, I was not aware that
it is rendered as a form element.
Grids do not support including screens. That feature was suggested
before, and it would be a nice one to have. Actually, it would be nice
if grid and form widgets worked more like the
Thanks again for the feedback Adrian,
I updated OFBIZ-6404 patch so that form/grid embedded menu rendering is
treated as display instead of edit fields. This causes the menus to be
rendered outside the edit form that gets created preventing violation of
html standard conformance.
Extra logic
The grid widget is implemented. Please check the commit logs.
The column widget is not intended to implement a grid. It is intended to
be used for multi-column layout of screens (like newspaper columns).
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/11/2015 2:57 PM,
column-container and column screen widgets seem to have been
implemented based on the discussion and JIRAs, but creating a single
table to contain a list doesn't seem supported for screens yet. The
following creates multiple tables for each column-container:
iterate-section
The column widget is intended to be used for multi-column layout. It is
not a replacement for a grid widget.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/11/2015 1:21 PM, Christian Carlow wrote:
column-container and column screen widgets seem to have been
implemented based
Adrian,
So grid widget isn't implemented yet?
Is there a JIRA for it?
Would my proposal for iterate-column conflict with it's
implementation?
If not, would iterate-column be worthy of a JIRA?
On Thu, 2015-06-11 at 14:18 -0700, Adrian Crum wrote:
The column widget is intended to be used
Various JIRA issues have been created, and several addressed/resolved. See
https://issues.apache.org/jira/browse/OFBIZ-6314 for a placeholder issue
(does not link all).
Best regards,
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Thanks for the pointer Pierre.
I commented on OFBIZ-6404 about menus with link-type=hidden-form not
being supported by the form menu embedding functionality because html
forms cannot be nested. It seems the grid or column functionality will
allow forms to be embedded in columns of table lists.
What is the status of the grid widget enhancements discussed by Adrian
and Gavin in this thread? Can other widgets be embedded within grids
yet? Is Nicolas' enhancement allowing menus to be embedded as form
fields of OFBIZ-6404 related to this?
On Mon, 2015-01-19 at 08:30 +0200, Gavin Mabie
Le 06/02/2015 17:27, Ron Wheeler a écrit :
On 06/02/2015 10:02 AM, Jacques Le Roux wrote:
Le 05/02/2015 15:41, Ron Wheeler a écrit :
Releases are stable.
Things that are not released are mutable.
The use of unconventional conventions should be stopped as soon as possible.
+1! Thanks Ron,
Le 31/01/2015 00:28, Adrian Crum a écrit :
The portlets are outside the scope of my current effort.
I understand, it's own effort to work on it ;)
Le 05/02/2015 15:41, Ron Wheeler a écrit :
Releases are stable.
Things that are not released are mutable.
The use of unconventional conventions should be stopped as soon as possible.
+1! Thanks Ron, I'd hope that people express more their opinions before events
happen than ranting after
On 06/02/2015 10:02 AM, Jacques Le Roux wrote:
Le 05/02/2015 15:41, Ron Wheeler a écrit :
Releases are stable.
Things that are not released are mutable.
The use of unconventional conventions should be stopped as soon as
possible.
+1! Thanks Ron, I'd hope that people express more their
I would though wait that all the possibly related opened Jiras will be fixed. Some projects are based on the R14.12 branch and people expect this
branch to be stable even if not yet released.
Jacques
Le 04/02/2015 06:34, Jacopo Cappellato a écrit :
On Jan 17, 2015, at 11:16 PM, Adrian Crum
On 05/02/2015 9:49 AM, Adrian Crum wrote:
All of this is already stated on the OFBiz web site, so I don't
understand the point of this reply.
Reference?
My plans are no different than many other branch backports that have
been done in the past.
Jacques seemed to find that not to be true.
I
Exactly. I would like to wait a few months to make sure all issues have
surfaced and have been fixed.
Btw, I apologize for all of the recent bugs resulting from the refactor.
I had done some work on it on one weekend, and then set it aside. When I
returned to it the next weekend, I thought it
I created https://issues.apache.org/jira/browse/OFBIZ-6060 for that
While at it I found this discussion:
http://markmail.org/message/e63blvefzkxvvjrn
I though noticed that nowadays clearing all caches manually does not take much time on an up to date machine. So clearing only services caches
All of this is already stated on the OFBiz web site, so I don't
understand the point of this reply.
My plans are no different than many other branch backports that have
been done in the past.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 2/5/2015 6:41 AM, Ron Wheeler wrote:
Releases are stable.
Things that are not released are mutable.
The use of unconventional conventions should be stopped as soon as possible.
If a branch has reached a state where no more changes except bug fixes
are expected then prioritize and clean up the JIRA issues that are
sufficiently
Le 05/02/2015 15:49, Adrian Crum a écrit :
All of this is already stated on the OFBiz web site, so I don't understand the
point of this reply.
My plans are no different than many other branch backports that have been done
in the past.
If memory serves, other branches backports have always
On Jan 17, 2015, at 11:16 PM, Adrian Crum adrian.c...@sandglass-software.com
wrote:
After all of this work is completed, I would like to backport it to the R14
branch.
Hi Adrian,
I just wanted to mention that I agree that we should backport all this work to
the 14.12 branch, which is
Hi Adrian, this work is welcome !
The widget model is an important element to deploy OFBiz as an ERP and
its own goal is to be improved to be more user-friendly and easy to
maintain for developer.
I see two axis that are missing at this time :
* create high configurable portal page to offer
Take a look at the visitor design pattern I added and see if that will
accommodate your binary renderer. There is an example implementation in
XmlWidgetVisitor.java.
The portlets are outside the scope of my current effort.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On
Thanks!
Best regards,
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail Trade
http://www.orrtiz.com
On Fri, Jan 23, 2015 at 11:17 PM, Adrian Crum
adrian.c...@sandglass-software.com wrote:
Done.
Adrian Crum
Done.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/23/2015 12:45 PM, Pierre Smits wrote:
Adrian,
Could you update http://ofbiz.apache.org/dtds/ so that the underlaying xsd
files reflect the recent changes?
Best regards,
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Adrian,
Could you update http://ofbiz.apache.org/dtds/ so that the underlaying xsd
files reflect the recent changes?
Best regards,
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail Trade
http://www.orrtiz.com
Hi Adrian,
Would it not be a good thing to have all the linking definition to be
refactored to one single definiton?
Currently we have:
- link
- hyperlink
- sub-hyperlink
It seems to me that they are intended to deliver the same functionality,
but are applied differently per
I did that already - in the schema and in code. There is a common link
type, then the various widgets extend it to add their specific attributes.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/23/2015 1:45 AM, Pierre Smits wrote:
Hi Adrian,
Would it not be a good thing to
Right. The renderers need to be updated to render links consistently. So
far, I have avoided touching the renderers. I will work on those later
if I have time. Meanwhile, feel free to create a patch and I will apply it.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/23/2015
Ahh. Ok.
Thanks for the insights.
Best regards,
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail Trade
http://www.orrtiz.com
On Fri, Jan 23, 2015 at 4:18 PM, Adrian Crum
adrian.c...@sandglass-software.com
I have created the placeholder for now:
https://issues.apache.org/jira/browse/OFBIZ-6034
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail Trade
http://www.orrtiz.com
On Fri, Jan 23, 2015 at 4:24 PM, Pierre
Yes, I thought so too.
But when I use link in a Sreen.xml, like example below:
link link-type=ajax-window target=
newaction?partyId=${parameters.partyId} width=1000 height=400 text=
${uiLabelMap.CommonCreateNew} style=buttontext create/
I get a popup window.
Whereas when I use the same in a
So I can use ajax-window in a screen, but then must I resort to a complex
setup in a section with regards to conditon settings to get an ajax window.
Or when using a menu and menu item to utilise conditions, I must resort to
calling a javascript to get an ajax window.
Pierre Smits
*ORRTIZ.COM
So, you're suggesting a grid widget would accept any screen widget
within a cell? That could be done fairly easily.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/18/2015 8:49 PM, Gavin Mabie wrote:
With columns already existing, rendering them inside rows would constitute
a
Yes. Cell/Column sizes in conjunction with screen media directives can
then be used to achieve responsive layouts.
On Mon, Jan 19, 2015 at 7:13 AM, Adrian Crum
adrian.c...@sandglass-software.com wrote:
So, you're suggesting a grid widget would accept any screen widget within
a cell? That
With columns already existing, rendering them inside rows would constitute
a grid.
On Sun, Jan 18, 2015 at 6:19 PM, Adrian Crum
adrian.c...@sandglass-software.com wrote:
We have columns for that.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/17/2015 6:14 PM, Gavin Mabie
We have columns for that.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/17/2015 6:14 PM, Gavin Mabie wrote:
Hi Adrian
I like the grid idea. It will almost certainly simplify and enhance UI
design. Furthermore, it will facilitate responsive design in Ofbiz. I
agree that form
Some time ago I started working on the screen widget thread safety.
There were many places in code where widget models were being modified
during rendering - resulting in unpredictable behavior, and in some
cases it resulted in users having access to data they shouldn't be able
to see.
While
Hi Adrian,
I am inclined to say that any code improvement that removes quirkiness in
current code or unpredictable behaviour while at the same time helping
contributors to develop better solutions deserves a +1.
However I have some concerns regarding the approach you're following.
First, as we
I am not doing anything that affects performance, so I am not interested
in a comparison.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/17/2015 2:58 PM, Pierre Smits wrote:
True.
But would you not like it that this refactoring isn't a factor when a
comparison between a
Comparisons can be done on any branch.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 1/17/2015 1:40 PM, Pierre Smits wrote:
Hi Adrian,
I am inclined to say that any code improvement that removes quirkiness in
current code or unpredictable behaviour while at the same time
True.
But would you not like it that this refactoring isn't a factor when a
comparison between a release and trunk shows that trunk is performing worse
than a release?
Pierre Smits
*ORRTIZ.COM http://www.orrtiz.com*
Services Solutions for Cloud-
Based Manufacturing, Professional
Services and
Hi Adrian
I like the grid idea. It will almost certainly simplify and enhance UI
design. Furthermore, it will facilitate responsive design in Ofbiz. I
agree that form widget should apply to forms. I would recommend that we
create a table widget for multi-column lists instead of the proposed
47 matches
Mail list logo
