Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485551
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
[
https://issues.apache.org/jira/browse/PHOENIX-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225665#comment-15225665
]
James Taylor commented on PHOENIX-2819:
---
+1, but one question here, don't you need the commas as
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225664#comment-15225664
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user chrajeshbabu commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225663#comment-15225663
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user chrajeshbabu commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225662#comment-15225662
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user chrajeshbabu commented on a diff in the
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58485360
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -157,6 +162,7 @@ public Reader
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225661#comment-15225661
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on the pull
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/156#issuecomment-205637233
Thanks for the patch, @chrajeshbabu. This is a big improvement over your
initial approach. It's still complex, though. There's an on going cost to
complicating
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225654#comment-15225654
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225653#comment-15225653
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484354
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484328
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225652#comment-15225652
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484293
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58484006
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -107,8 +127,37 @@ public synchronized void close()
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225645#comment-15225645
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225643#comment-15225643
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483863
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19 @@
};
-
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225637#comment-15225637
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483665
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483591
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225636#comment-15225636
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225625#comment-15225625
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483357
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -556,35 +564,55 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483341
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225622#comment-15225622
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -465,7 +465,14 @@ private static String
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483244
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
---
@@ -326,11 +325,12 @@ private static void
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225621#comment-15225621
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58483157
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java ---
@@ -209,7 +209,11 @@ protected ResultIterator
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225600#comment-15225600
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58482201
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java ---
@@ -196,26 +196,31 @@ public Expression getDynamicFilter() {
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225598#comment-15225598
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58482075
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -402,8 +405,8 @@ private RegionScanner
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481927
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -423,7 +426,14 @@ private RegionScanner
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225591#comment-15225591
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225588#comment-15225588
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481858
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481703
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225583#comment-15225583
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225579#comment-15225579
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481542
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -279,6 +301,31 @@ protected RegionScanner
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225574#comment-15225574
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58481362
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -337,6 +384,22 @@ public boolean
[
https://issues.apache.org/jira/browse/PHOENIX-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maryann Xue updated PHOENIX-2819:
-
Attachment: PHOENIX-2819.patch
Could you please review this patch, [~jamestaylor]?
> Remove
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225545#comment-15225545
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58479273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -165,7 +183,7 @@ public RegionScanner
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225539#comment-15225539
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58478944
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58478608
--- Diff:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
---
@@ -157,6 +162,7 @@ public Reader
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225533#comment-15225533
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225527#comment-15225527
]
Hadoop QA commented on PHOENIX-2817:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225523#comment-15225523
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58477862
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -86,8 +98,8 @@ public static void doSetup() throws
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225521#comment-15225521
]
ASF GitHub Bot commented on PHOENIX-2628:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r5845
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java ---
@@ -727,7 +727,7 @@ public void
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/157#issuecomment-205598163
@codymarcel - would it be possible for you to review this pull as Mujtaba
is on PTO?
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/PHOENIX-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225464#comment-15225464
]
James Taylor commented on PHOENIX-2802:
---
Thanks, [~maryannxue]. I filed PHOENIX-2820 for some
James Taylor created PHOENIX-2820:
-
Summary: Investigate why SortMergeJoinIT has a sort in the explain
plan
Key: PHOENIX-2820
URL: https://issues.apache.org/jira/browse/PHOENIX-2820
Project: Phoenix
[
https://issues.apache.org/jira/browse/PHOENIX-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225443#comment-15225443
]
Maryann Xue commented on PHOENIX-2802:
--
[~jamestaylor], sorry for jumping in late. The changes in
[
https://issues.apache.org/jira/browse/PHOENIX-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Soldatov updated PHOENIX-2817:
-
Attachment: PHOENIX-2817-3.patch
[~jmahonin] thank you for you review. Updated patch
[
https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225397#comment-15225397
]
James Taylor commented on PHOENIX-2156:
---
Thanks, [~tdsilva]. Couple of comments/questions:
-
[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225382#comment-15225382
]
Rajeshbabu Chintaguntla commented on PHOENIX-2628:
--
Ping [~jamestaylor] [~enis]
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225358#comment-15225358
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58470085
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableSerialIterators.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225346#comment-15225346
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469780
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/execute/CorrelatePlanTest.java ---
@@ -172,17 +172,38 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225343#comment-15225343
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469617
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
@@ -138,6 +138,9 @@
public final static String
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225340#comment-15225340
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469369
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/OrderedResultIterator.java
---
@@ -130,9 +135,9 @@ public
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225338#comment-15225338
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469290
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225337#comment-15225337
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225336#comment-15225336
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225332#comment-15225332
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225334#comment-15225334
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469125
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58469109
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/MergeSortTopNResultIterator.java
---
@@ -79,9 +86,11 @@ public Tuple peek() throws
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58469055
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225327#comment-15225327
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468877
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225316#comment-15225316
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468394
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225300#comment-15225300
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58468008
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ---
@@ -1279,4 +1304,129 @@ public static boolean
[
https://issues.apache.org/jira/browse/PHOENIX-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225298#comment-15225298
]
Josh Mahonin commented on PHOENIX-2817:
---
In PhoenixRDD.scala, you likely want to check if the
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225295#comment-15225295
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58467711
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -897,4 +941,86 @@ public static boolean hasRowTimestampColumn(PTable
[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225284#comment-15225284
]
ASF GitHub Bot commented on PHOENIX-1311:
-
Github user samarthjain commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225285#comment-15225285
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58467402
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -218,7 +228,11 @@ protected RegionScanner
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r58467374
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java ---
@@ -897,4 +941,86 @@ public static boolean hasRowTimestampColumn(PTable
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225280#comment-15225280
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58467131
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/SubselectRewriter.java ---
@@ -188,6 +190,13 @@ private SelectStatement
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225278#comment-15225278
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58467053
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/SubqueryRewriter.java ---
@@ -167,7 +167,7 @@ public ParseNode
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225274#comment-15225274
]
ASF GitHub Bot commented on PHOENIX-2722:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/154#discussion_r58466849
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -168,7 +169,11 @@ public QueryPlan
1 - 100 of 125 matches
Mail list logo
