[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554836#comment-16554836
]
Josh Elser commented on PHOENIX-3655:
-
Part 1 is spot-on.
For part2, I would copy
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554787#comment-16554787
]
Karan Mehta commented on PHOENIX-3655:
--
[~elserj] Getting back on this one after a long time. Need
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495845#comment-16495845
]
Josh Elser commented on PHOENIX-3655:
-
{quote}Would not this mean that we will have to manage the
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495828#comment-16495828
]
Karan Mehta commented on PHOENIX-3655:
--
{quote}Maybe we're talking past each other. I am talking
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479635#comment-16479635
]
Josh Elser commented on PHOENIX-3655:
-
{quote}The stuff you are talking about is implemented as a
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479636#comment-16479636
]
Thomas D'Silva commented on PHOENIX-3655:
-
I think the raw value is still useful. Lets say a
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479630#comment-16479630
]
Karan Mehta commented on PHOENIX-3655:
--
{quote}The rest of what you were saying is about on track:
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479556#comment-16479556
]
Andrew Purtell commented on PHOENIX-3655:
-
I would argue for converting the metrics to hbase
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479534#comment-16479534
]
Thomas D'Silva commented on PHOENIX-3655:
-
GLOBAL_MUTATION_BYTES is useful for trending, to see
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479510#comment-16479510
]
Josh Elser commented on PHOENIX-3655:
-
{quote}Do you want to move towards {{MetricRegistry}}
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479490#comment-16479490
]
Karan Mehta commented on PHOENIX-3655:
--
I digged in further through the code. HBase has
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474802#comment-16474802
]
Karan Mehta commented on PHOENIX-3655:
--
[~elserj] [~apurtell] [~tdsilva] [~xucang]
I digged into
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471315#comment-16471315
]
James Taylor commented on PHOENIX-3655:
---
For discussion on putting statement level metrics into
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471218#comment-16471218
]
Andrew Purtell commented on PHOENIX-3655:
-
> we can expose them via a servlet just like how
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471214#comment-16471214
]
Andrew Purtell commented on PHOENIX-3655:
-
FWIW internally we brainstormed maybe putting
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471211#comment-16471211
]
Thomas D'Silva commented on PHOENIX-3655:
-
I agree it doesn't make sense to expose connection
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469953#comment-16469953
]
Josh Elser commented on PHOENIX-3655:
-
{quote}Avatica Handler Metrics
{quote}
There is a comment
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469530#comment-16469530
]
Karan Mehta commented on PHOENIX-3655:
--
Thanks [~elserj] for helping out.
I had some internal
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433025#comment-16433025
]
Josh Elser commented on PHOENIX-3655:
-
[~karanmehta93], that's great! I don't think I have much more
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429212#comment-16429212
]
Karan Mehta commented on PHOENIX-3655:
--
I would like to take up this patch and finish up the
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166659#comment-16166659
]
Rahul Shrivastava commented on PHOENIX-3655:
Thanks [~elserj]
I will start working on this
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162307#comment-16162307
]
Andrew Purtell commented on PHOENIX-3655:
-
[~rahulshrivastava]
Above you asked about
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161825#comment-16161825
]
Rahul Shrivastava commented on PHOENIX-3655:
[~lhofhansl] - Lars, Please let us know the
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145535#comment-16145535
]
Josh Elser commented on PHOENIX-3655:
-
That sounds like a good first-pass idea to me!
> Metrics for
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145261#comment-16145261
]
Andrew Purtell commented on PHOENIX-3655:
-
At a minimum I think the PQS should surface the same
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16141849#comment-16141849
]
Josh Elser commented on PHOENIX-3655:
-
I'm finding it difficult to weigh in because the scope of
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137581#comment-16137581
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj] [~jamestaylor] [~samarthjain]
Hi
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020571#comment-16020571
]
Samarth Jain commented on PHOENIX-3655:
---
The idea behind the metrics APIs provided by Phoenix
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020446#comment-16020446
]
James Taylor commented on PHOENIX-3655:
---
There are both global metrics and per statement metrics
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020440#comment-16020440
]
Rahul Shrivastava commented on PHOENIX-3655:
[~jamestaylor]
Phoenix metrics provide
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019833#comment-16019833
]
James Taylor commented on PHOENIX-3655:
---
[~elserj] - I think your review comments are most
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018587#comment-16018587
]
Josh Elser commented on PHOENIX-3655:
-
Let me try to clear the air here, I think my previous comment
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018067#comment-16018067
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj]
We value your suggestion on this and
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018022#comment-16018022
]
Josh Elser commented on PHOENIX-3655:
-
bq. Not sure we are being fair to the contributor in
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014382#comment-16014382
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj],
According to me, the initial design
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014297#comment-16014297
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014291#comment-16014291
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013404#comment-16013404
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013382#comment-16013382
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013209#comment-16013209
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013186#comment-16013186
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013182#comment-16013182
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013184#comment-16013184
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013180#comment-16013180
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013183#comment-16013183
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013181#comment-16013181
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013185#comment-16013185
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013187#comment-16013187
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013143#comment-16013143
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj] [~jamestaylor]
I have made all the
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011520#comment-16011520
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on the issue:
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008775#comment-16008775
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008757#comment-16008757
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008753#comment-16008753
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008751#comment-16008751
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008687#comment-16008687
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008622#comment-16008622
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008612#comment-16008612
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user rahulsIOT commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990897#comment-15990897
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990894#comment-15990894
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990900#comment-15990900
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990901#comment-15990901
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990887#comment-15990887
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990895#comment-15990895
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990898#comment-15990898
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990890#comment-15990890
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990893#comment-15990893
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990899#comment-15990899
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990888#comment-15990888
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990892#comment-15990892
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990896#comment-15990896
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990891#comment-15990891
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990889#comment-15990889
]
ASF GitHub Bot commented on PHOENIX-3655:
-
Github user joshelser commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990638#comment-15990638
]
Rahul Shrivastava commented on PHOENIX-3655:
[~jamestaylor]
[~elserj]
Please check the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990636#comment-15990636
]
ASF GitHub Bot commented on PHOENIX-3655:
-
GitHub user rahulsIOT opened a pull request:
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877054#comment-15877054
]
Rahul Shrivastava commented on PHOENIX-3655:
Hi Josh,
Just to clarify: you're only talking
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875091#comment-15875091
]
Josh Elser commented on PHOENIX-3655:
-
bq. Expose metrics for Phoenix to a preconfigured Sink.
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864668#comment-15864668
]
Josh Elser commented on PHOENIX-3655:
-
bq. we want the PQS driver to export the same metrics through
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864651#comment-15864651
]
Andrew Purtell commented on PHOENIX-3655:
-
I think wherever it makes sense, we want the PQS
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861797#comment-15861797
]
Josh Elser commented on PHOENIX-3655:
-
bq. My understanding is PQS comes with Phoenix driver. The
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861738#comment-15861738
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj] - My answers inline.
> I
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859949#comment-15859949
]
Josh Elser commented on PHOENIX-3655:
-
Some context: Avatica provides an extensible metrics library
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858745#comment-15858745
]
Rahul Shrivastava commented on PHOENIX-3655:
[~elserj]
[~giacomotaylor]
> Metrics for PQS
>
82 matches
Mail list logo
