Github user Alex-Vol closed the pull request at:
https://github.com/apache/thrift/pull/1468
---
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
@jeking3 per our offline discussion, I am closing this and pushing to my
branch the update with the commit user email corrected so it does not trigger a
new build. You can pick up the changes
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
Yes, as it stands right now we will need to change the "making a release"
page to eliminate the manual editing of the gradle.properties file since it is
now automated to ju
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r162795265
--- Diff: lib/java/CMakeLists.txt ---
@@ -17,14 +17,13 @@
# under the License.
#
-file(GLOB java_sources src/**/*.java
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
Right after I pushed the last commit with the sources restored to the
original locations I found the sonar-project.properties file that had a
reference to the new source code layout
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I have identified the following issues as duplicates or related to this.
[THRIFT-4178](https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-4178)
[THRIFT-4120](https
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I am marking JIRA items already fixed by this one as duplicates/related to
and will update the description.
---
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I felt the need to make this organization like all the other java projects
in Github. The files were moved for sure, splitting the cross-test files just
makes them stand out. If you think
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I really hope AppVeyor works now. For some reason the CMakeLists.txt in
Java had an implicit dependency on the compiler but did not have a target
dependency declaration. The new build requires
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I may have figured out the issue with AppVeyor. I was unable to
troubleshoot with RDP, AppVeyor has not run a build since 55 hours ago. But I
figured out that the configuration in CMakeLists.txt
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I believe I found the problem with make-dist. I hope that takes care of the
builds because it is the final piece of the puzzle. I wonder if that caused the
AppVeryor build failures as well.
---
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1470
I am closing this. I had a mistake which I corrected in my other pull
request.
---
Github user Alex-Vol closed the pull request at:
https://github.com/apache/thrift/pull/1470
---
GitHub user Alex-Vol opened a pull request:
https://github.com/apache/thrift/pull/1470
Fix the Travis build issue with Java SSL ubuntu-trusty container
The latest Trusty JDK7 builds with Gradle seem to have encountered this
issue
because the OpenJDK removed the SunEC algorithms
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I have successfully gotten the cross-check tests to pass on Travis.
What is still broken is the Appveyor builds which seem to hang for some
strange reason. No root cause yet
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161421393
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
I will register in Apache Jira to have this properly handled.
---
Github user Alex-Vol commented on the issue:
https://github.com/apache/thrift/pull/1468
The failures are coming from the cross-check system. In my initial approach
of the conversion I did not realize that the cross-check build starts a build
equivalent just to run a test harness
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161404044
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161403984
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389750
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389720
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389670
--- Diff: lib/java/build.gradle ---
@@ -0,0 +1,495 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384041
--- Diff: lib/java/gradle/wrapper/gradle-wrapper.properties ---
@@ -0,0 +1,5 @@
+distributionBase=GRADLE_USER_HOME
--- End diff
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384037
--- Diff: lib/java/gradlew ---
@@ -0,0 +1,172 @@
+#!/usr/bin/env sh
--- End diff --
This script is autogenerated by the Gradle Wrapper
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384031
--- Diff: lib/java/gradlew.bat ---
@@ -0,0 +1,84 @@
+@if "%DEBUG%" == "" @echo off
--- End diff --
This scr
GitHub user Alex-Vol opened a pull request:
https://github.com/apache/thrift/pull/1468
Thrift 4259: Thrift does not compile due to Ant Maven task errors
This pull request changes the build system used to Gradle. The integration
uses the recommended and popular option of the Gradle
27 matches
Mail list logo
