[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318818#comment-16318818 ] ASF GitHub Bot commented on THRIFT-4285: Github user johnboiles commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318804#comment-16318804 ] ASF GitHub Bot commented on THRIFT-4285: Github user johnboiles commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256909#comment-16256909 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256541#comment-16256541 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238675#comment-16238675 ] ASF GitHub Bot commented on THRIFT-4285: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238674#comment-16238674 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238360#comment-16238360 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237713#comment-16237713 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237714#comment-16237714 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237712#comment-16237712 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237709#comment-16237709 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237666#comment-16237666 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237661#comment-16237661 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237657#comment-16237657 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237645#comment-16237645 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237646#comment-16237646 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220658#comment-16220658 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209819#comment-16209819 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208900#comment-16208900 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198648#comment-16198648 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198624#comment-16198624 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198288#comment-16198288 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192757#comment-16192757 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188375#comment-16188375 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188349#comment-16188349 ] ASF GitHub Bot commented on THRIFT-4285: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188187#comment-16188187 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun commented on the issue:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187973#comment-16187973 ] ASF GitHub Bot commented on THRIFT-4285: GitHub user dcelasun opened a pull request:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187807#comment-16187807 ] ASF GitHub Bot commented on THRIFT-4285: Github user dcelasun closed the pull request at:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187710#comment-16187710 ] ASF GitHub Bot commented on THRIFT-4285: GitHub user dcelasun opened a pull request:

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174844#comment-16174844 ] Can Celasun commented on THRIFT-4285: - Just had a chance to review. The patch doesn't apply cleanly

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145048#comment-16145048 ] Can Celasun commented on THRIFT-4285: - Tried running the tests, there are some failures: {code}

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124973#comment-16124973 ] Can Celasun commented on THRIFT-4285: - I didn't have a chance to review the patch yet, but I really

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124955#comment-16124955 ] Chris Bannister commented on THRIFT-4285: - This is a breaking change for the generated code as