Re: svn commit: r998120 - /tomcat/jk/trunk/native/common/jk_connect.c

2010-09-25 Thread Mladen Turk
On 09/25/2010 03:00 PM, Rainer Jung wrote: On 17.09.2010 15:26, mt...@apache.org wrote: Author: mturk Date: Fri Sep 17 13:26:58 2010 New Revision: 998120 URL: http://svn.apache.org/viewvc?rev=998120view=rev Log: Make sure errno survives JK_TRACE_EXIT call Good catch! WDYT about Index:

Re: svn commit: r998129 - /tomcat/jk/trunk/native/common/jk_ajp_common.c

2010-09-25 Thread Mladen Turk
On 09/25/2010 02:50 PM, Rainer Jung wrote: On 17.09.2010 15:44, mt...@apache.org wrote: Author: mturk Date: Fri Sep 17 13:44:50 2010 New Revision: 998129 URL: http://svn.apache.org/viewvc?rev=998129view=rev Log: Axe excess logging. We already logged that within jk_open_socket Modified:

Re: svn commit: r999983 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

2010-09-25 Thread Mladen Turk
On 09/25/2010 06:11 PM, Rainer Jung wrote: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml This commit changed umlauts in changelog.xml from ISO to UTF in a couple of places. I'm not sure that's OK. Ni idea. However my box has utf-8 locale, so might be my editor to blame. However the

Re: svn commit: r1002263 - /tomcat/trunk/bin/catalina.sh

2010-09-28 Thread Mladen Turk
On 09/28/2010 06:59 PM, ma...@apache.org wrote: Author: markt Date: Tue Sep 28 16:59:54 2010 New Revision: 1002263 URL: http://svn.apache.org/viewvc?rev=1002263view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49728 Improve PID file handling, particularly when another process

Re: svn commit: r1002277 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-28 Thread Mladen Turk
On 09/28/2010 07:24 PM, ma...@apache.org wrote: Author: markt +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 + Better handling for missing TLD files. Report JSP filename and location. + http://svn.apache.org/viewvc?rev=1002274view=rev + +1: markt + -1: Could you guys

Re: svn commit: r1002263 - /tomcat/trunk/bin/catalina.sh

2010-09-28 Thread Mladen Turk
On 09/28/2010 06:59 PM, ma...@apache.org wrote: Author: markt +PID=`cat $CATALINA_PID` +if ps -p $PID /dev/null; then + echo Tomcat appears to still be running with PID $PID. Start aborted. + exit 1 if $CATALINA_PID points to the file that has invalid

Re: svn commit: r1002277 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-28 Thread Mladen Turk
On 09/28/2010 08:16 PM, Konstantin Kolinko wrote: 2010/9/28 Mladen Turkmt...@apache.org: On 09/28/2010 07:24 PM, ma...@apache.org wrote: Author: markt +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 + Better handling for missing TLD files. Report JSP filename and location. +

Re: svn commit: r1002263 - /tomcat/trunk/bin/catalina.sh

2010-09-29 Thread Mladen Turk
On 09/29/2010 10:51 AM, Rainer Jung wrote: On 28.09.2010 19:41, Mladen Turk wrote: Next the code echo Tomact stopped but PID file could not be removed ($CATALINA_PID). Will fail on shells that handle ( ...) like ` ... ` Just as an info: you can use echo 'Tomcat stopped but PID file could

Re: Need a new tc native release?

2010-10-04 Thread Mladen Turk
On 10/04/2010 10:34 AM, Mark Thomas wrote: On 04/10/2010 08:27, Mladen Turk wrote: On 10/03/2010 03:02 PM, Mark Thomas wrote: I've seen the shut down issues reported in [1] with the 1.1.20 native connector on Windows, Linux and OSX. Has a bug crept in here or do the changes to the shut down

Re: Need a new tc native release?

2010-10-04 Thread Mladen Turk
On 10/03/2010 03:02 PM, Mark Thomas wrote: I've seen the shut down issues reported in [1] with the 1.1.20 native connector on Windows, Linux and OSX. Has a bug crept in here or do the changes to the shut down code mean we need to release 1.1.21? Nope. The fix in Java side (I did with 992211

Re: Need a new tc native release?

2010-10-04 Thread Mladen Turk
On 10/04/2010 10:34 AM, Mark Thomas wrote: On 04/10/2010 08:27, Mladen Turk wrote: On 10/03/2010 03:02 PM, Mark Thomas wrote: I've seen the shut down issues reported in [1] with the 1.1.20 native connector on Windows, Linux and OSX. Has a bug crept in here or do the changes to the shut down

Re: Need a new tc native release?

2010-10-04 Thread Mladen Turk
On 10/04/2010 10:34 AM, Mark Thomas wrote: That's likely my bad then. I'll take a look. Thanks for the confirmation. Fixed. It was getSocketProperties().getSoTimeout() returning -1 causing exception Now it defaults to 2 seconds, which means that in the worse case it'll be called 30 times for

Re: svn commit: r1005367 - in /tomcat/trunk: java/org/apache/coyote/ajp/AbstractAjpProtocol.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpProtocol.java webapps/docs

2010-10-08 Thread Mladen Turk
On 10/07/2010 10:54 AM, kfuj...@apache.org wrote: +/** + * AJP packet size. + */ +protected int packetSize = Constants.MAX_PACKET_SIZE; +public int getPacketSize() { return packetSize; } +public void setPacketSize(int packetSize) { +if(packetSize

Re: Domino Tomcat connector: I'd like to hire somebody to bring it back

2010-10-08 Thread Mladen Turk
On 10/08/2010 12:08 AM, Erik C. Brooks wrote: Hello group, I'd like to modernize the Domino Tomcat connector for Win64. I've got a great Domino C developer here who has a lot of DSAPI experience. I'm more than willing to pay, and would love to release it back to the community. Please contact

Re: svn commit: r1005367 - in /tomcat/trunk: java/org/apache/coyote/ajp/AbstractAjpProtocol.java java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpProtocol.java webapps/docs

2010-10-08 Thread Mladen Turk
On 10/08/2010 09:50 AM, Keiichi Fujino wrote: Does it mean to rename MAX_PACKET_SIZE to MIN_PACKET_SIZE ? Huh, I thought we enlarged the MAX_PACKET_SIZE to 65536. We should have DEF_PACKET_SIZE=8192 (or MIN_PACKET_SIZE) and MAX_PACKET_SIZE=65536 Currently we allow to set packet size to

req: Need someone to publish daemon 1.0.3 to maven repository

2010-10-13 Thread Mladen Turk
Hi, One user asked to put commons-daemon-1.0.3 to the Maven repository I know everything is explained here: http://www.apache.org/dev/publishing-maven-artifacts.html However, never did that, so would appreciate if someone familiar could to push the released jar's. Thanks -- ^TM

Re: req: Need someone to publish daemon 1.0.3 to maven repository

2010-10-13 Thread Mladen Turk
Huh, wrong Apache tribe (I was sending that to the commons dev list). Sorry for the noise. One user asked to put commons-daemon-1.0.3 to the Maven repository Cheers -- ^TM - To unsubscribe, e-mail:

Creating tomcat VFS

2010-10-15 Thread Mladen Turk
Hi, I'm working for quite some time on the light-weight VFS layer (with the java.io.* as the only provider at the moment) to be used as the Tomcat's physical file system access. The ultimate goal is to be able to run the Tomcat on top of things like Hadoop or similar distributed file systems

Re: Creating tomcat VFS

2010-10-15 Thread Mladen Turk
On 10/15/2010 09:58 AM, Mark Thomas wrote: On 15/10/2010 08:02, Mladen Turk wrote: Hi, I'm working for quite some time on the light-weight VFS layer (with the java.io.* as the only provider at the moment) to be used as the Tomcat's physical file system access. The ultimate goal is to be able

Re: Creating tomcat VFS

2010-10-15 Thread Mladen Turk
On 10/15/2010 04:57 PM, Costin Manolache wrote: Are you going to replace DirContext ? If yes - great, but please first send a quick summary comparing your API with the other VFS around in apache. I think commons has few targets, including a hdfs, I remember there are more. Well it's not a

Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
Hi, Seems we are fine for 1.2.31 now that httpd 2.3 compiles without problems. I plan to tag 1.2.31_RC1 and make release candidate set of sources and bin at the ususal place. If voted we would just need to svn mv 1.2.31_RC1 1.2.31 If someone again needs more time for testing :) the release

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 02:29 PM, Rainer Jung wrote: On 21.10.2010 09:02, Mladen Turk wrote: Hi, Hmmm, the problem with the RCs is: - either we don't want to change any contents of the release between the last RC and the release. Then the RCs do not contain any indication that they are actually RCs

Re: svn commit: r1025975 - /tomcat/jk/trunk/native/common/jk.rc

2010-10-21 Thread Mladen Turk
On 10/21/2010 02:47 PM, rj...@apache.org wrote: Propchange: tomcat/jk/trunk/native/common/jk.rc -- svn:eol-style = native Not needed, but it doesn't hurt :) rc.exe can compile a .rc with LF line endings.

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:02 PM, Rainer Jung wrote: On 21.10.2010 14:48, Mladen Turk wrote: My point is: once we circulate something, ... But the point is that we don't circulate that. It's supposed to be used only by PMC members that would vote or no vote for that release. We are not creating

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:58 PM, Rainer Jung wrote: On 21.10.2010 17:47, Igor Galić wrote: tags are cheap (: I know that slogan, but from a users perspective I think missing versions are always strange. It's OK if it happens every now and then but it give a very strange feeling, if a lot of versions

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 05:59 PM, Rainer Jung wrote: 1.2.31 (r1003456) What file name do you plan for the RC source tarball? The same as a release. I'll put them in the p.a.o/~mturk for potential voters. Again, this is not a release, release candidate or something third. It is my proposal made from

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:05 PM, Mladen Turk wrote: Before we were using tomcat.apache.org/dev/dist and this should be axed completely. What I mean, anything that we dist *must* be voted before. Since our entire site is mirrored anything on the site must be voted for (even if the readme says

Re: Tagging JK 1.2.31

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:44 PM, Rainer Jung wrote: On 21.10.2010 18:05, Mladen Turk wrote: I will commit a small change to the release script, that will add the svn revision number to the end of JK_EXPOSED_VERSION. For me that is sufficient. And this would mean that this cannot be used

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung /* Source Control Revision as a suffix, e.g. -r12345 */ -#define JK_REVISION +#define JK_REVISION $Revision$ /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -65,7 +65,7 @@ #if (JK_VERRC != 0)

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do it officially, so here it is: -1 veto Please revert adding this to the exposed version. (or

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:33, Rainer Jung wrote: On 21.10.2010 19:12, Mladen Turk wrote: It means that we won't have jk-1.2.31 but jk-1.2.31-rSomething even for a release? You mean It means we won't have? or It means we will have? Guess it's a typo. Well, I meant we wont have just mod_jk-1.2.31

Re: svn commit: r1026064 - /tomcat/jk/trunk/native/common/jk_version.h

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:36, Rainer Jung wrote: On 21.10.2010 20:01, Mladen Turk wrote: On 10/21/2010 06:52 PM, rj...@apache.org wrote: Author: rjung -#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT +#define JK_EXPOSED_VERSION JK_EXPOSED_VERSION_INT JK_REVISION Ok, it seems I have to do

Re: svn commit: r1026100 - in /tomcat/jk/trunk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c common/jk_status.c common/jk_version.h iis/jk_isapi_plugin.c netscape/jk_nsapi_plugin.c

2010-10-21 Thread Mladen Turk
On 21/10/2010 20:53, rj...@apache.org wrote: Author: rjung The new JK_FULL_EXPOSED_VERSION is used during init/startup/shutdown logging, not for the short version numbers. Ok that makes more sense, although I still don't get the what's the point and the *problem* you had to solve with adding

[VOTE] Release Tomcat Connectors 1.2.31

2010-10-22 Thread Mladen Turk
Hi, 1.2.31 release proposal based on the JK_1_2_31_RC2 tag is available for testing at: http://people.apache.org/~mturk/tomcat-connectors/jk/ Beside sources there is assorted set of binaries for your convenience. Just browse down the binaries directory and you might get lucky :) Documentation

Re: [PROPOSAL] Parallel deployment

2010-10-22 Thread Mladen Turk
On 10/21/2010 08:52 PM, Mark Thomas wrote: - decide once we can see the patch without the clean-up if it is safe for 7.0.x or needs to be held back for 7.1.x If it doesn't break things or existing users configs, I have no problem of having it in 7.0. Adding 7.1 to the list would just confuse

Re: [VOTE] Release Tomcat Connectors 1.2.31

2010-10-22 Thread Mladen Turk
On 10/22/2010 05:09 PM, Rainer Jung wrote: On 22.10.2010 15:10, Mladen Turk wrote: Since nsapi is so rare and I assume only Solaris is hit by the problem, I wouldn't say it's a showstopper. We can open a bugzilla to document and fix next time. What do you think? +1 That's how I build them

Re: use_server_errors and JKMount

2010-10-23 Thread Mladen Turk
On 10/23/2010 03:48 PM, Henri Gomez wrote: Hi to all, Did there is a way to to inject the use_server_errors directive without uriworkermap ? Sure it is: JkMount /examples/* loadbalancer;fail_on_status=-404,-500,503 Regards -- ^TM

Re: use_server_errors and JKMount

2010-10-23 Thread Mladen Turk
On 10/23/2010 04:22 PM, Mladen Turk wrote: On 10/23/2010 03:48 PM, Henri Gomez wrote: Hi to all, Did there is a way to to inject the use_server_errors directive without uriworkermap ? Sure it is: JkMount /examples/* loadbalancer;fail_on_status=-404,-500,503 It should be JkMount /examples

Re: Tomcat native ia64 binaries wrong?

2010-10-26 Thread Mladen Turk
On 10/26/2010 11:28 AM, Mark Thomas wrote: Hi, I don't have the hardware to test if this is an issue on ia64 this but the following files have the same MD5 hash: http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/binaries/win64/ia64/tcnative-1.dll

Re: Tomcat native ia64 binaries wrong?

2010-10-26 Thread Mladen Turk
On 10/26/2010 01:29 PM, Mark Thomas wrote: Since you are the first one that figured that out after more then 8 months, it just convinces me that we should drop IA64 binaries altogether. At least I don't plan to produce them any more Fine with me. That will mean a updates to the build scripts,

Re: Tomcat native ia64 binaries wrong?

2010-10-26 Thread Mladen Turk
On 10/26/2010 01:29 PM, Mark Thomas wrote: http://www.apache.org/dist/tomcat/tomcat-connectors/native/1.1.20/binaries/win64/ia64/tcnative-1.dll I have updated the correct binaries for IA64 Give it couple of hours for a sync. Remaining stays however. I don't plan to make them in the future.

Re: [VOTE] Release Tomcat Connectors 1.2.31

2010-10-26 Thread Mladen Turk
So, Tomcat Connectors 1.2.31 is: [X] +1 release it [ ] -1 nope, it's broken Here is my vote just for the record. I'll left the vote open for another 24 hours, and since I won't have time for another spin for at least a month, if not voted this will have to wait some better times or another

[RESULT] Was: [VOTE] Release Tomcat Connectors 1.2.31

2010-10-31 Thread Mladen Turk
We have collected needed three binding votes; Rainer, Tim and Mladen I'll copy the artifacts to the bin directory and make an announcement afterward. On 10/22/2010 03:10 PM, Mladen Turk wrote: Hi, 1.2.31 release proposal based on the JK_1_2_31_RC2 tag is available for testing at: http

[ANN] Apache Tomcat Connectors 1.2.31 released

2010-11-01 Thread Mladen Turk
The Apache Tomcat team announces the immediate availability of Apache Tomcat Connectors 1.2.31 stable. Apache Tomcat Connectors 1.2.31 concentrates mainly on bug fixes. Please refer to the change log for the list of changes: http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html

Re: svn commit: r1036232 - /tomcat/site/trunk/docs/images/tomcat.gif

2010-11-18 Thread Mladen Turk
Currently it's only on the main site. If no one objects I'll replace all tomcat logos across all subprojects and branches with this one. On 11/17/2010 10:21 PM, mt...@apache.org wrote: Author: mturk Date: Wed Nov 17 21:21:52 2010 New Revision: 1036232 URL:

Re: svn commit: r1036232 - /tomcat/site/trunk/docs/images/tomcat.gif

2010-11-18 Thread Mladen Turk
On 11/18/2010 12:00 PM, Mark Thomas wrote: The TM seems a little big / too bold but maybe that is because I'm not used to it being there. If it is just me that thinks this then feel free to go ahead and replace the other logos. I'm sure I'll get used to it. That was my first notice as well,

[ANN] Apache Tomcat Twitter feed

2010-11-23 Thread Mladen Turk
Hi, We have launched the official Apache Tomcat project Twitter feed at: http://twitter.com/TheApacheTomcat We will regularly post there announce and other relevant news, and we are welcoming all new followers to our new Twitter feed. For those interested in ASF in general, there is also

Re: svn commit: r1039109 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-11-25 Thread Mladen Turk
On 11/25/2010 06:40 PM, ma...@apache.org wrote: Author: markt * Backport AprEndpoint shutdown patch (BZ49795 and similar). http://people.apache.org/~mturk/tomcat/patches/tomcat-6.0.x-aprshutdown.patch +1: mturk + -0: markt - Patch doesn't apply cleanly to tc6.0.x/trunk Sure since

Re: svn commit: r1036595 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ test/org/apache/catalina/session/

2010-11-29 Thread Mladen Turk
On 11/25/2010 05:33 PM, Mark Thomas wrote: How about this as an approach to reduce the complexity: 1. Remove the MD5 code (optional) 2. Default to /dev/urandom then SecureRandom. Don't fall back to Random. 3. Provide a class that implements Random that reads data from a file 4. If randomFile is

Re: DO NOT REPLY [Bug 50339] mod_jk parsing error if workers.properties contains whitespaces

2010-11-29 Thread Mladen Turk
On 11/29/2010 06:08 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50339 -strcpy(s,s[i]); +for (off = i; '\0' != s[i]; i++); { +s[i - off] = s[i]; +} +s[i - off] = s[i]; memmove ;) It would mean HPUX has a crappy

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/01/2010 07:37 PM, ma...@apache.org wrote: Author: markt Date: Wed Dec 1 18:37:29 2010 New Revision: 1041120 URL: http://svn.apache.org/viewvc?rev=1041120view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Bind/release socket on start()/stop() Register/deregister

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: 2010/12/3 Mladen Turkmt...@apache.org: Think that single eg. EndpointState enum will cover all the states during start(),pause(),resume(),stop() replacing multiple booleans (at least running and paused) with a single enum. WDTYT? It makes

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 08:21 AM, Mladen Turk wrote: On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: So, binding to port 80 should be performed during initialization while we have the root privileges, and not during startup. Does binding to port 80 still work with Tomcat 7? Didn't test

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: So, binding to port 80 should be performed during initialization while we have the root privileges, and not during startup. Does binding to port 80 still work with Tomcat 7? Created BZ50406. IMO the entire r1041120 should be reverted and

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-03 Thread Mladen Turk
On 12/03/2010 06:58 PM, Mark Thomas wrote: Think that single eg. EndpointState enum will cover all the states during start(),pause(),resume(),stop() replacing multiple booleans (at least running and paused) with a single enum. WDTYT? What we really need is the Lifecycle stuff that is in

Re: svn commit: r1043611 - /tomcat/native/trunk/native/src/poll.c

2010-12-08 Thread Mladen Turk
On 12/08/2010 08:07 PM, cos...@apache.org wrote: Author: costin +// Pass the ENOTIMPL to java, as described in javadocs. Java must clean the +// flag, will know it's not supported. .c file and c++ style comment ??? Welcome to the beautiful land of native code, Costin :)

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I think we don't use stdio. APR has apr_file_open() which uses CreateFile() and apr_file_write() which goes back to WriteFile() on Windows. We are using stdio for other web servers, so if you add CRLF then the IIS will be broken. Perhaps opening the files as

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I built against an installed form of the official download apache_1.3.37-win32-x86-src.msi. ... and you are using VS 2005 I suppose? That won't work cause you have different MSVCRT's Regards, Mladen.

Re: svn commit: r524660 - in /tomcat/tc6.0.x/trunk: build.properties.default java/org/apache/catalina/core/AprLifecycleListener.java res/tomcat.nsi

2007-04-01 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Apr 1 12:37:58 2007 New Revision: 524660 URL: http://svn.apache.org/viewvc?view=revrev=524660 Log: Use the tomcat-native-1.1.9 as recommended version. I am against this change. Other than minor fixes, existing users

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: I used 2003 .net, but this includes a 7.0 version of msvcrt.dll. I build apache httpd 1.3 by myself and then mod_jk, and now everything works as expected. So you are right, the binary httpd download is not compatible with module compilation by vc++ 7.0. Any idea how one can

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-02 Thread Mladen Turk
Henri Gomez wrote: May be at some time in the future we should think about a mod_jk 2.x requiring and using APR to remove all platform complexity :-) Think we tried that with jk2 and failed. Even on Apache 1.3 we could have jk bundled with APR statically Don't think so. Regards, Mladen.

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-02 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I checked out jk trunk today and built mod_jk Can you double check the trunk? Think I've fixed the CRLF issue. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: Quality check mod_jk-1.2.22

2007-04-02 Thread Mladen Turk
William L. Thomson Jr. wrote: The next version of mod_jk is approaching its release. A code snapshot is available at: http://people.apache.org/~mturk/jk-1.2.22-dev/ Little version funkiness? 1.1.22 ? LOL, my bad, but you already know what I meant (1.2.22) Cheers, Mladen.

Re: svn commit: r524777 - /tomcat/connectors/trunk/jk/tools/jkrelease.sh

2007-04-03 Thread Mladen Turk
Rainer Jung wrote: OK, I forgot, that I actually had a user and group named asf (I thought tar would ignore their non-existance). All in all I would suggest root:bin to. I used root:users instead. Think the users group exists on all *nixes. Regards, Mladen.

Passing configuration param to a AprLifecycleListener

2007-04-03 Thread Mladen Turk
Hi, Few months ago Filip added something like Listener className=org.apache.catalina.core.AprLifecycleListener SSLEngine=someengine/on/off / Now, that simply doeasn't work because SSL.initialize(null) is always called, and my perception was that this would allow having

Re: Passing configuration param to a AprLifecycleListener

2007-04-03 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: That should be pretty straight forward, no mbean or anything needed. I'll take a look at it tonight Cool, otherwise if we have a native compiled without SSL, it throws exception instead not initializing SSL at all. Regards, Mladen.

Tagging 1.2.22

2007-04-05 Thread Mladen Turk
Hi, The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: Tagging 1.2.22

2007-04-05 Thread Mladen Turk
Jim Jagielski wrote: The quality check release was out few days ago. I plan to tag the mod_jk tomorrow morning Europe time. Any objections? This is a holiday weekend, so maybe afterwards? OK, so the schedule is then for Tuesday May 10th. Regards, Mladen.

Re: Jk_isapi_plugin.c bug #42038 in JK 1.2.20, 21, 22

2007-04-10 Thread Mladen Turk
Coffman, Steven wrote: Hi, I have a question for 42038. I only recently figured out exactly what was causing it, so I'm sorry for the bugzilla spam as I zeroed in on it. I already explain that in the bz case. Please do not steal threads! Regards, Mladen.

Re: Tagging 1.2.22

2007-04-11 Thread Mladen Turk
Mladen Turk wrote: Hi, The quality check release was out few days ago. Hi there is new quality check release available from: http://people.apache.org/~mturk/jk-1.2.22-dev/ It contains few minor fixes mostly for documentation and release script (owner/group for .tar) I'll give it 24 hours

[VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
Hi, Mod_jk 1.2.22 has been available for testing for some days. No new bugs have been reported so far, so it is time to proceed with the release vote. The source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.22/ or

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: The source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.22/ or http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/ May I ask -why-? It's not released (quite yet

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: Don't understand your question. It was more then a week available for a developers review. The official stable is still 1.2.21 until 1.2.22 gets votes or not, in which case we'll go for 1.2.23. So what's the problem? How many times will I repeat

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: I suggest you revoke my commit privileges to the www.apache.org/dist/ so it won't happen again and you won't need to repeat this again. I'm sure infra would be happy to if you would prefer this. LOL. Man, you really don't like me

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
Jim Jagielski wrote: On Apr 13, 2007, at 7:20 AM, Yoav Shapira wrote: Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. ++1 (especially on the chill out part ;) ) !! I think the issue is that,

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: So, can we agree I made an mistake? Hey, I make 'em all the time... No - I don't dislike you Mladen :) Nor Redhat - work with Marc and Joe all the time on httpd-stuff. Cool, let's move forward. I'll make sure I don't upload files on random places any more :)

Re: snprintf/vsnprintf in mod_jk

2007-04-14 Thread Mladen Turk
Guenter Knauf wrote: Hi, Therefore I would like to suggest another approach: let us import ap_snprintf.c from Apache 1.3.x into the mod_jk project. comments welcome! Just commit if you think it's more portable. Regards, Mladen.

Re: snprintf/vsnprintf in mod_jk

2007-04-16 Thread Mladen Turk
Henri Gomez wrote: Still on mod_jk and this kind of stuff. We switch our dev servers from i5/OS v5R4 and many changes occurs in IBM HTTP Server powered by Apache, and for instance this one : If I could'nt fix/adapt for i5/OS, we may have to remove the whole AS400 support in next release of

Re: snprintf/vsnprintf in mod_jk

2007-04-16 Thread Mladen Turk
Henri Gomez wrote: 2007/4/16, Mladen Turk [EMAIL PROTECTED]: You mean the support for the IBM HTTP Server. I suppose the AS400 is still able to have genuine Apache Httpd and mod_jk compiled and running. Nope on AS400, there is an IBM HTTP Server (powered by Apache), so it's not a genuine

Re: snprintf/vsnprintf in mod_jk

2007-04-16 Thread Mladen Turk
Henri Gomez wrote: Right, but one can compile Apache Httpd from the ASF thought and run it on AS400. I suppose all the EBCDIC we added to mod_jk will allow it compile with standard httpd like before. On AS400, it will be more than difficult and not supported by IBM. But it will be supported

[RESULT][VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-17 Thread Mladen Turk
Hi, The results of the vote are: Stable: 5 votes (Rainer, Guenter, Jim, Peter and mine implicit) Beta, Alpha: None. According to the vote, I'll put the releases from tomcat.apacheorg/dev/dist to apache.org/dist, wait for few hours and make an Announce Regards, Mladen.

Files at tomcat.apache.org have wrong permission

2007-04-18 Thread Mladen Turk
Hi, Some files on /x1/www/tomcat.apache.org have 0644, instead 0664 and are owned by markt. Mark can you change those the files to a correct permission? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For

[ANN] Apache Tomcat JK 1.2.22 Web Server Connector released

2007-04-18 Thread Mladen Turk
The Apache Tomcat team is pleased to announce the immediate availability of version 1.2.22 of the Apache Tomcat Connectors. It contains connectors, which allow a web server such as Apache HTTPD, Microsoft IIS and Sun Web Server to act as a front end to the Tomcat web application server. This

Re: svn commit: r530674 - in /tomcat/connectors/trunk/jk: native/apache-2.0/ native/common/ xdocs/webserver_howto/

2007-04-20 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: hgomez -#ifdef AS400 +#if defined(AS400) !defined(AS400_UTF8) So, seems that UTF8 is now default for AS400 I wonder why are you maintain AS400 since you said it doesn't work anyhow. Also, UTF8 in mod_jk does not exist. All we have is 127, so there is no

Re: svn commit: r530674 - in /tomcat/connectors/trunk/jk: native/apache-2.0/ native/common/ xdocs/webserver_howto/

2007-04-20 Thread Mladen Turk
Henri Gomez wrote: 2007/4/20, Mladen Turk [EMAIL PROTECTED]: [EMAIL PROTECTED] wrote: Author: hgomez -#ifdef AS400 +#if defined(AS400) !defined(AS400_UTF8) So, seems that UTF8 is now default for AS400 On i5/OS V5R4 (not on previous release) But they are supposed to work, right

Re: Candidate binaries for 6.0.12

2007-04-29 Thread Mladen Turk
Remy Maucherat wrote: The candidates binaries in which I suppose a horrible bug will be found in about 5 minutes are available here: http://people.apache.org/~remm/tomcat-6/v6.0.12/ Tested on all windows versions and linux. Works fine. Will you propose a vote? Regards, Mladen.

Re: [VOTE] Release build 6.0.13

2007-05-09 Thread Mladen Turk
Remy Maucherat wrote: According to the release process, the 6.0.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable BTW, can you repack the binaries with the latest tomcat6.exe. At least it allows a thread dump to the stdout.log for standard log level. If it would require a new tag, just

Shipping tomcat[5|6].exe binaries with .zip distribution

2007-05-11 Thread Mladen Turk
Hi, Right now we are only shipping windows 32-bit binaries inside .zip distro. Can we modify the build so the zip contains windows 64-bit amd64/emt64 and ia64 binaries as well. It would increase the .zip only by 200K. I'll also try to modify the service.bat script so that install detects if the

Re: [VOTE] Release build 6.0.13

2007-05-14 Thread Mladen Turk
Peter Rossbach wrote: All my tests are working... :-) You have a lousy tests! Sorry, I simply couldn't resist :) Anyhow according to the Ferengi rule #16 A deal is a deal ... until a better one comes along. Just replace the 'deal' with the 'release', and you'll got the eternal truth about our

Re: svn commit: r537640 - /tomcat/connectors/trunk/jk/native/configure.in

2007-05-14 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Rearrange configure.in, such that in case we got with-apxs we detect CC from apxs and warn, if the CC environment variable differs. Is this really needed? I mean having that the apxs wouldn't work for any custom module thought. I think that instead fixing other people

Re: New branch ?

2007-05-17 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: +1 Sure, I'd prefer the new branch, it's a good idea in the scenario where the new changes may not be complete and we have to do a security fix/release 6.0 But then 6.0 should be frozen for any API change. 6.1.x would work If the 6.2 stable branch will

Re: [VOTE] Releasing Tomcat Connectors 1.2.23

2007-05-18 Thread Mladen Turk
Rainer Jung wrote: Hello to all Tomcat project members, Apache Tomcat Connectors 1.2.23 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Tested on Linux and

Re: Improving mod_jk URI forwarding

2007-05-19 Thread Mladen Turk
Rainer Jung wrote: Hi, now that we changed the default way how to forward URIs from mod_jk to Tomcat (mod_jk 1.2.23) because of a directory traversal issue, I want to propose a better long term solution. My proposal is that we make our own decoder if the URI is encoded and then do a match

Re: Improving mod_jk URI forwarding

2007-05-19 Thread Mladen Turk
Rainer Jung wrote: Mladen Turk wrote: My proposal is that we make our own decoder if the URI is encoded and then do a match and forward that. As far as I understand you suggestion, this would not help. There's nothing wrong with our decoder (the httpd decoder), what's wrong

Re: Improving mod_jk URI forwarding

2007-05-19 Thread Mladen Turk
Jean-Frederic wrote: What about url like /context-a/../context-b/? There could be a problem if the goal is not to map /context-b. Should we normalise /context-a/../context-b/ to /context-b and then do the mapping. Yes. It would require some programming of course, but it'll solve the issues

Re: Improving mod_jk URI forwarding

2007-05-19 Thread Mladen Turk
Rainer Jung wrote: Mladen Turk wrote: You got me wrong. I suggest we decode the encoded uri, do mapping, remove ;jsessionid=xxx and send that to the Tomcat. This way tomcat won't have double encoding issue. And it's completely legitimate if we comply to the RFC. This would also solve malicious

Re: Improving mod_jk URI forwarding

2007-05-19 Thread Mladen Turk
Rainer Jung wrote: OK Mladen, I understand that, but I think it's not correct. Might be. But: none of the existing options does the right thing. That's why I suggested another way of handling the forward. I think my sugeggested variant forward r-uri with encoded '%' is the right way of

Re: Improving mod_jk URI forwarding

2007-05-20 Thread Mladen Turk
Rainer Jung wrote: Mladen Turk wrote: Can you write a simple example of the uris that make the problem and why we would need to encode the %. How it is passed now, and how it would be passed with your proposal. Original URI: /myapp/%252e%252e/otherapp/danger JkMount /myapp/* Apache httpd

Re: Improving mod_jk URI forwarding

2007-05-20 Thread Mladen Turk
Rainer Jung wrote: Before I answer, let me first ask a question: What's wrong withg my suggestion? Or even better: use the encoding done with mod_proxy_ajp? Because it doesn't solve the real problem. Original URI: /myapp/%252e%252e/otherapp/danger JkMount /myapp/* Apache httpd will

Re: Improving mod_jk URI forwarding

2007-05-20 Thread Mladen Turk
Bill Barker wrote: Now the reverse proxy should have the ability to modify the URI (in the sense of mod_rewrite). If we accept, that mod_rewrite in httpd 1.3-2.2 is only able to operate on the decoded URI, we have no chance of making this interoperable with forwarding the original undecoded

<    3   4   5   6   7   8   9   10   11   12   >