GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/80
(TWILL-264) Fix Discoverable.hashCode implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill TWILL-264-fix-discoverable
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221661663
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -345,6 +388,28 @@ private static FileSystem
getFileSystem
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221661290
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221661448
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221660462
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221663573
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -72,7 +77,23 @@
HADOOP_26
}
- private static
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r221660130
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration
Github user chtyim closed the pull request at:
https://github.com/apache/twill/pull/61
---
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/68
(TWILL-258) Use loopback address for ZK server
- Fix a race condition in the LocationCacheTest
- Fix race condition in LogLevelChangeTestRun
You can merge this pull request into a Git repository
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174644467
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterMain.java
---
@@ -170,45 +167,7 @@ private ApplicationKafkaService
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/67
I've addressed the comments and fixed one more issue (one deletion failure,
if the node not exist, we can just go ahead and recreate the node instead of
failing).
Also refactored the callback
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174626043
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaPublisher.java
---
@@ -159,30 +159,37 @@ public void changed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174618874
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
@@ -216,11 +217,52 @@ protected final void shutDown() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174618395
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
@@ -216,11 +217,52 @@ protected final void shutDown() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174618087
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
@@ -216,11 +217,52 @@ protected final void shutDown() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/67#discussion_r174617783
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
@@ -216,11 +217,52 @@ protected final void shutDown() throws
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/67
(TWILL-61) Fix to allow higher attempts to relaunch the app after the first
attempt failed
- Delete the Kafka root zk node for the application if already exist
- Delete the AM instance zk node
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/65
Changes LGTM.
---
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/65#discussion_r166160088
--- Diff: pom.xml ---
@@ -680,9 +680,9 @@
-hadoop-2.5
+hadoop-2.6
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/65
The change looks mostly ok to me, except for the change in the pom.xml
profile.
---
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/65#discussion_r166078366
--- Diff: pom.xml ---
@@ -680,9 +680,9 @@
-hadoop-2.5
+hadoop-2.6
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/64
(TWILL-251) Reduce log level of YarnNMClient
- Also reduce the polling frequency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/63
(TWILL-248) Speedup shutdown of tracker service
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
feature/TWILL-248-speedup-shutdown
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/62#discussion_r143854276
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java ---
@@ -52,12 +54,16 @@
public ResourceReport get
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/62
(TWILL-248) Upgrade to use Netty-4.1
- Also enable ResourceReportClient to use HTTP compression
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/61#discussion_r137130751
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ResourceReportClient.java ---
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/61
(TWILL-244) Make resource report available to TwillRunnable
- Make resource report available to TwillContext
- Enhance tracker service to provide more resource related endpoints
- Provide
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/58
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322898
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322316
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322087
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -181,19 +190,130 @@ public Reader getInput
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/60
(TWILL-242) Fixed the dropping of extra jvm opts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
feature/TWILL-242-fix-extra-jvm
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132298929
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132297954
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -401,6 +409,24 @@ void stopAll() {
// When we
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132297305
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296875
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296480
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132296198
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -193,7 +200,91 @@ private EventHandler
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132295847
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -181,7 +189,6 @@ public Reader getInput() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132037568
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -221,7 +229,8 @@ protected void doStart() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132038521
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -267,6 +280,14 @@ void stopByIdAndWait(String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132038164
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -173,6 +183,9 @@ void start(String runnableName
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132040768
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java ---
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132040093
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -267,6 +280,14 @@ void stopByIdAndWait(String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132029508
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java ---
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132029465
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java ---
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132029365
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/EventHandlerTest.java ---
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/59
@anew Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131762189
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -291,6 +300,24 @@ public void run
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131761843
--- Diff:
twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java ---
@@ -22,5 +22,9 @@
*/
public interface EventHandlerContext
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131762593
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java ---
@@ -85,13 +105,29 @@ public TimeoutAction
launchTimeout(Iterable
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131762365
--- Diff:
twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java ---
@@ -22,5 +22,9 @@
*/
public interface EventHandlerContext
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131762894
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java ---
@@ -85,13 +105,29 @@ public TimeoutAction
launchTimeout(Iterable
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131761787
--- Diff:
twill-api/src/main/java/org/apache/twill/api/EventHandlerContext.java ---
@@ -22,5 +22,9 @@
*/
public interface EventHandlerContext
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511384
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -183,6 +184,13 @@ public TwillPreparer withConfiguration(Map<Str
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511349
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -87,19 +86,46 @@ public String getTwillAppName
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/59
(TWILL-241) Added per runnable configuration and jvm options support
This PR has two commits, one for adding per runnable configuration, the
other for adding per runnable jvm options.
You can merge
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131211956
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java ---
@@ -79,12 +83,22 @@ public void initialize(EventHandlerContext
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131210382
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -291,6 +301,23 @@ public void run
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131209163
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -135,6 +135,15 @@
private final Map<Str
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131208560
--- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java ---
@@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131210237
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -291,6 +301,23 @@ public void run
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r131207866
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java
---
@@ -162,7 +163,8 @@ public URI toURI() {
// append "
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r131208032
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocationUtil.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r130406951
--- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java ---
@@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/56#discussion_r126296669
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -17,15 +17,14 @@
*/
package org.apache.twill.api
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r124058716
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java
---
@@ -162,7 +163,8 @@ public URI toURI() {
// append "
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/54
(TWILL-180) Reflects YARN application completion status via TwillController
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/53#discussion_r109553180
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -322,7 +314,46 @@ private boolean hasRun(YarnApplicationState state
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/52
(TWILL-176) Redirect all requests to tracker URL to /resources path
- "/resources" is the only path supported for the tracker service for now
You can merge this pull request into a Git
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/51
(TWILL-179) Added support for custom ClassLoader for containers
- Added method TwillPreparer.setClassLoader
- Use system property "twill.custom.class.loader" to pass the class name of
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/48
I tried to create a unit test using MiniKdc, but seems like I hit this bug
https://issues.apache.org/jira/browse/HDFS-9213
---
If your project is set up for it, you can reply to this email and have
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/49
For AM, currently it is not settable. For Runnable containers, user can add
as resources / localize a `logback.xml` file and specify it in the classpath.
---
If your project is set up for it, you can
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/46#discussion_r108542463
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -159,19 +159,19 @@ public static ApplicationId createApplicationId(long
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/46
This replaces #45 due to accidentally deleting the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtyim closed the pull request at:
https://github.com/apache/twill/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/45
(TWILL-227) Disabling caching of FileSystem instance when getting
delegation token
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/44
(TWILL-226) Remove the deprecated HDFSLocationFactory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/TWILL-226
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/42
(TWILL-171) Clone the HDFS delegation in HA mode.
- This is for working around HDFS-9276
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107773444
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -105,4 +114,17 @@ public String getRmSchedulerAddr
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107717653
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -105,4 +114,17 @@ public String getRmSchedulerAddr
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107717203
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -77,7 +77,7 @@
*/
YarnTwillController(String appName
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/40
@hsaputra Thanks for the review. Please see my replies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107347828
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java ---
@@ -77,7 +77,7 @@
*/
YarnTwillController(String appName
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107347590
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -105,4 +114,17 @@ public String getRmSchedulerAddr
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/40#discussion_r107344859
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -71,21 +71,37 @@
private static final Logger LOG
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/40
(TWILL-122) Allow disabling log collection
- Introduced a new configuration twill.log.collection.enabled for
turning off log collection
- Refactor YarnTwillController and related class
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/39#discussion_r107264780
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -455,21 +475,40 @@ private void saveLogLevels(String runnableName,
Map
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/39#discussion_r10700
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -155,25 +153,16 @@ public String apply(Class cls) {
private
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/36
Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/36
(TWILL-90) Add new configuration options to set AM memory size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/TWILL-90
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/35
As said in the description, you will see the important changes when
ignoring white space changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/35
Force push a change to trigger travis build again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
Seems like the github sync is lagging. I merged this change about 6 hours
ago
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
I squashed them after getting LGTM to prepare for the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/35
(TWILL-207) Only use list of class names as the cache name
- Also some indentation changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/34#discussion_r103596214
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java
---
@@ -50,12 +51,11 @@
private static final Logger LOG
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/34
Feature/twill 186
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/twill-186
Alternatively you can review and apply
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101789920
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -38,7 +38,6 @@
import
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101699381
--- Diff: twill-api/src/main/java/org/apache/twill/api/Configs.java ---
@@ -75,6 +82,7 @@ private Keys() {
*/
public static final int
1 - 100 of 209 matches
Mail list logo
